diff options
Diffstat (limited to 'drivers/ata')
-rw-r--r-- | drivers/ata/ahci.c | 2 | ||||
-rw-r--r-- | drivers/ata/ahci.h | 4 | ||||
-rw-r--r-- | drivers/ata/ata_piix.c | 10 | ||||
-rw-r--r-- | drivers/ata/libata-core.c | 2 | ||||
-rw-r--r-- | drivers/ata/libata-eh.c | 10 | ||||
-rw-r--r-- | drivers/ata/libata-scsi.c | 2 | ||||
-rw-r--r-- | drivers/ata/libata-sff.c | 4 | ||||
-rw-r--r-- | drivers/ata/pata_amd.c | 2 | ||||
-rw-r--r-- | drivers/ata/pata_arasan_cf.c | 8 | ||||
-rw-r--r-- | drivers/ata/pata_bf54x.c | 2 | ||||
-rw-r--r-- | drivers/ata/pata_cs5520.c | 2 | ||||
-rw-r--r-- | drivers/ata/pata_mpiix.c | 2 | ||||
-rw-r--r-- | drivers/ata/pata_palmld.c | 43 | ||||
-rw-r--r-- | drivers/ata/pata_rz1000.c | 2 | ||||
-rw-r--r-- | drivers/ata/pata_sil680.c | 4 | ||||
-rw-r--r-- | drivers/ata/pata_sis.c | 4 | ||||
-rw-r--r-- | drivers/ata/pata_triflex.c | 2 | ||||
-rw-r--r-- | drivers/ata/sata_fsl.c | 4 | ||||
-rw-r--r-- | drivers/ata/sata_mv.c | 4 | ||||
-rw-r--r-- | drivers/ata/sata_nv.c | 2 | ||||
-rw-r--r-- | drivers/ata/sata_via.c | 2 |
21 files changed, 59 insertions, 58 deletions
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index e62f693be8ea..39d829cd82dd 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c | |||
@@ -926,7 +926,7 @@ static bool ahci_broken_suspend(struct pci_dev *pdev) | |||
926 | /* | 926 | /* |
927 | * Acer eMachines G725 has the same problem. BIOS | 927 | * Acer eMachines G725 has the same problem. BIOS |
928 | * V1.03 is known to be broken. V3.04 is known to | 928 | * V1.03 is known to be broken. V3.04 is known to |
929 | * work. Inbetween, there are V1.06, V2.06 and V3.03 | 929 | * work. Between, there are V1.06, V2.06 and V3.03 |
930 | * that we don't have much idea about. For now, | 930 | * that we don't have much idea about. For now, |
931 | * blacklist anything older than V3.04. | 931 | * blacklist anything older than V3.04. |
932 | * | 932 | * |
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h index ccaf08122058..39865009c251 100644 --- a/drivers/ata/ahci.h +++ b/drivers/ata/ahci.h | |||
@@ -225,7 +225,7 @@ enum { | |||
225 | /* em_ctl bits */ | 225 | /* em_ctl bits */ |
226 | EM_CTL_RST = (1 << 9), /* Reset */ | 226 | EM_CTL_RST = (1 << 9), /* Reset */ |
227 | EM_CTL_TM = (1 << 8), /* Transmit Message */ | 227 | EM_CTL_TM = (1 << 8), /* Transmit Message */ |
228 | EM_CTL_MR = (1 << 0), /* Message Recieved */ | 228 | EM_CTL_MR = (1 << 0), /* Message Received */ |
229 | EM_CTL_ALHD = (1 << 26), /* Activity LED */ | 229 | EM_CTL_ALHD = (1 << 26), /* Activity LED */ |
230 | EM_CTL_XMT = (1 << 25), /* Transmit Only */ | 230 | EM_CTL_XMT = (1 << 25), /* Transmit Only */ |
231 | EM_CTL_SMB = (1 << 24), /* Single Message Buffer */ | 231 | EM_CTL_SMB = (1 << 24), /* Single Message Buffer */ |
@@ -281,7 +281,7 @@ struct ahci_port_priv { | |||
281 | }; | 281 | }; |
282 | 282 | ||
283 | struct ahci_host_priv { | 283 | struct ahci_host_priv { |
284 | void __iomem * mmio; /* bus-independant mem map */ | 284 | void __iomem * mmio; /* bus-independent mem map */ |
285 | unsigned int flags; /* AHCI_HFLAG_* */ | 285 | unsigned int flags; /* AHCI_HFLAG_* */ |
286 | u32 cap; /* cap to use */ | 286 | u32 cap; /* cap to use */ |
287 | u32 cap2; /* cap2 to use */ | 287 | u32 cap2; /* cap2 to use */ |
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c index cdec4ab3b159..0bc3fd6c3fdb 100644 --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c | |||
@@ -38,16 +38,16 @@ | |||
38 | * Hardware documentation available at http://developer.intel.com/ | 38 | * Hardware documentation available at http://developer.intel.com/ |
39 | * | 39 | * |
40 | * Documentation | 40 | * Documentation |
41 | * Publically available from Intel web site. Errata documentation | 41 | * Publicly available from Intel web site. Errata documentation |
42 | * is also publically available. As an aide to anyone hacking on this | 42 | * is also publicly available. As an aide to anyone hacking on this |
43 | * driver the list of errata that are relevant is below, going back to | 43 | * driver the list of errata that are relevant is below, going back to |
44 | * PIIX4. Older device documentation is now a bit tricky to find. | 44 | * PIIX4. Older device documentation is now a bit tricky to find. |
45 | * | 45 | * |
46 | * The chipsets all follow very much the same design. The original Triton | 46 | * The chipsets all follow very much the same design. The original Triton |
47 | * series chipsets do _not_ support independant device timings, but this | 47 | * series chipsets do _not_ support independent device timings, but this |
48 | * is fixed in Triton II. With the odd mobile exception the chips then | 48 | * is fixed in Triton II. With the odd mobile exception the chips then |
49 | * change little except in gaining more modes until SATA arrives. This | 49 | * change little except in gaining more modes until SATA arrives. This |
50 | * driver supports only the chips with independant timing (that is those | 50 | * driver supports only the chips with independent timing (that is those |
51 | * with SITRE and the 0x44 timing register). See pata_oldpiix and pata_mpiix | 51 | * with SITRE and the 0x44 timing register). See pata_oldpiix and pata_mpiix |
52 | * for the early chip drivers. | 52 | * for the early chip drivers. |
53 | * | 53 | * |
@@ -122,7 +122,7 @@ enum { | |||
122 | P2 = 2, /* port 2 */ | 122 | P2 = 2, /* port 2 */ |
123 | P3 = 3, /* port 3 */ | 123 | P3 = 3, /* port 3 */ |
124 | IDE = -1, /* IDE */ | 124 | IDE = -1, /* IDE */ |
125 | NA = -2, /* not avaliable */ | 125 | NA = -2, /* not available */ |
126 | RV = -3, /* reserved */ | 126 | RV = -3, /* reserved */ |
127 | 127 | ||
128 | PIIX_AHCI_DEVICE = 6, | 128 | PIIX_AHCI_DEVICE = 6, |
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b91e19cab102..423c0a6952b2 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c | |||
@@ -5340,7 +5340,7 @@ int ata_host_suspend(struct ata_host *host, pm_message_t mesg) | |||
5340 | * | 5340 | * |
5341 | * Resume @host. Actual operation is performed by EH. This | 5341 | * Resume @host. Actual operation is performed by EH. This |
5342 | * function requests EH to perform PM operations and returns. | 5342 | * function requests EH to perform PM operations and returns. |
5343 | * Note that all resume operations are performed parallely. | 5343 | * Note that all resume operations are performed parallelly. |
5344 | * | 5344 | * |
5345 | * LOCKING: | 5345 | * LOCKING: |
5346 | * Kernel thread context (may sleep). | 5346 | * Kernel thread context (may sleep). |
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index df3f3140c9c7..88cd22fa65cd 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c | |||
@@ -771,7 +771,7 @@ void ata_scsi_port_error_handler(struct Scsi_Host *host, struct ata_port *ap) | |||
771 | /* process port suspend request */ | 771 | /* process port suspend request */ |
772 | ata_eh_handle_port_suspend(ap); | 772 | ata_eh_handle_port_suspend(ap); |
773 | 773 | ||
774 | /* Exception might have happend after ->error_handler | 774 | /* Exception might have happened after ->error_handler |
775 | * recovered the port but before this point. Repeat | 775 | * recovered the port but before this point. Repeat |
776 | * EH in such case. | 776 | * EH in such case. |
777 | */ | 777 | */ |
@@ -1742,7 +1742,7 @@ void ata_eh_analyze_ncq_error(struct ata_link *link) | |||
1742 | * | 1742 | * |
1743 | * Analyze taskfile of @qc and further determine cause of | 1743 | * Analyze taskfile of @qc and further determine cause of |
1744 | * failure. This function also requests ATAPI sense data if | 1744 | * failure. This function also requests ATAPI sense data if |
1745 | * avaliable. | 1745 | * available. |
1746 | * | 1746 | * |
1747 | * LOCKING: | 1747 | * LOCKING: |
1748 | * Kernel thread context (may sleep). | 1748 | * Kernel thread context (may sleep). |
@@ -1893,7 +1893,7 @@ static int speed_down_verdict_cb(struct ata_ering_entry *ent, void *void_arg) | |||
1893 | * occurred during last 5 mins, NCQ_OFF. | 1893 | * occurred during last 5 mins, NCQ_OFF. |
1894 | * | 1894 | * |
1895 | * 3. If more than 8 ATA_BUS, TOUT_HSM or UNK_DEV errors | 1895 | * 3. If more than 8 ATA_BUS, TOUT_HSM or UNK_DEV errors |
1896 | * ocurred during last 5 mins, FALLBACK_TO_PIO | 1896 | * occurred during last 5 mins, FALLBACK_TO_PIO |
1897 | * | 1897 | * |
1898 | * 4. If more than 3 TOUT_HSM or UNK_DEV errors occurred | 1898 | * 4. If more than 3 TOUT_HSM or UNK_DEV errors occurred |
1899 | * during last 10 mins, NCQ_OFF. | 1899 | * during last 10 mins, NCQ_OFF. |
@@ -2577,7 +2577,7 @@ int ata_eh_reset(struct ata_link *link, int classify, | |||
2577 | if (link->flags & ATA_LFLAG_NO_SRST) | 2577 | if (link->flags & ATA_LFLAG_NO_SRST) |
2578 | softreset = NULL; | 2578 | softreset = NULL; |
2579 | 2579 | ||
2580 | /* make sure each reset attemp is at least COOL_DOWN apart */ | 2580 | /* make sure each reset attempt is at least COOL_DOWN apart */ |
2581 | if (ehc->i.flags & ATA_EHI_DID_RESET) { | 2581 | if (ehc->i.flags & ATA_EHI_DID_RESET) { |
2582 | now = jiffies; | 2582 | now = jiffies; |
2583 | WARN_ON(time_after(ehc->last_reset, now)); | 2583 | WARN_ON(time_after(ehc->last_reset, now)); |
@@ -2736,7 +2736,7 @@ int ata_eh_reset(struct ata_link *link, int classify, | |||
2736 | if (!reset) { | 2736 | if (!reset) { |
2737 | ata_link_printk(link, KERN_ERR, | 2737 | ata_link_printk(link, KERN_ERR, |
2738 | "follow-up softreset required " | 2738 | "follow-up softreset required " |
2739 | "but no softreset avaliable\n"); | 2739 | "but no softreset available\n"); |
2740 | failed_link = link; | 2740 | failed_link = link; |
2741 | rc = -EINVAL; | 2741 | rc = -EINVAL; |
2742 | goto fail; | 2742 | goto fail; |
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index a83419991357..e2f57e9e12f0 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c | |||
@@ -999,7 +999,7 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) | |||
999 | * @qc: Command that we are erroring out | 999 | * @qc: Command that we are erroring out |
1000 | * | 1000 | * |
1001 | * Generate sense block for a failed ATA command @qc. Descriptor | 1001 | * Generate sense block for a failed ATA command @qc. Descriptor |
1002 | * format is used to accomodate LBA48 block address. | 1002 | * format is used to accommodate LBA48 block address. |
1003 | * | 1003 | * |
1004 | * LOCKING: | 1004 | * LOCKING: |
1005 | * None. | 1005 | * None. |
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index cf7acbc0cfcb..f8380ce0f4d1 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c | |||
@@ -2839,7 +2839,7 @@ unsigned int ata_bmdma_port_intr(struct ata_port *ap, struct ata_queued_cmd *qc) | |||
2839 | bmdma_stopped = true; | 2839 | bmdma_stopped = true; |
2840 | 2840 | ||
2841 | if (unlikely(host_stat & ATA_DMA_ERR)) { | 2841 | if (unlikely(host_stat & ATA_DMA_ERR)) { |
2842 | /* error when transfering data to/from memory */ | 2842 | /* error when transferring data to/from memory */ |
2843 | qc->err_mask |= AC_ERR_HOST_BUS; | 2843 | qc->err_mask |= AC_ERR_HOST_BUS; |
2844 | ap->hsm_task_state = HSM_ST_ERR; | 2844 | ap->hsm_task_state = HSM_ST_ERR; |
2845 | } | 2845 | } |
@@ -3032,7 +3032,7 @@ void ata_bmdma_start(struct ata_queued_cmd *qc) | |||
3032 | * Or maybe I'm just being paranoid. | 3032 | * Or maybe I'm just being paranoid. |
3033 | * | 3033 | * |
3034 | * FIXME: The posting of this write means I/O starts are | 3034 | * FIXME: The posting of this write means I/O starts are |
3035 | * unneccessarily delayed for MMIO | 3035 | * unnecessarily delayed for MMIO |
3036 | */ | 3036 | */ |
3037 | } | 3037 | } |
3038 | EXPORT_SYMBOL_GPL(ata_bmdma_start); | 3038 | EXPORT_SYMBOL_GPL(ata_bmdma_start); |
diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c index 620a07cabe31..b0975a5ad8c4 100644 --- a/drivers/ata/pata_amd.c +++ b/drivers/ata/pata_amd.c | |||
@@ -11,7 +11,7 @@ | |||
11 | * Power management on ports | 11 | * Power management on ports |
12 | * | 12 | * |
13 | * | 13 | * |
14 | * Documentation publically available. | 14 | * Documentation publicly available. |
15 | */ | 15 | */ |
16 | 16 | ||
17 | #include <linux/kernel.h> | 17 | #include <linux/kernel.h> |
diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c index 65cee74605b4..719bb73a73e0 100644 --- a/drivers/ata/pata_arasan_cf.c +++ b/drivers/ata/pata_arasan_cf.c | |||
@@ -385,7 +385,7 @@ static inline int wait4buf(struct arasan_cf_dev *acdev) | |||
385 | return -ETIMEDOUT; | 385 | return -ETIMEDOUT; |
386 | } | 386 | } |
387 | 387 | ||
388 | /* Check if PIO Error interrupt has occured */ | 388 | /* Check if PIO Error interrupt has occurred */ |
389 | if (acdev->dma_status & ATA_DMA_ERR) | 389 | if (acdev->dma_status & ATA_DMA_ERR) |
390 | return -EAGAIN; | 390 | return -EAGAIN; |
391 | 391 | ||
@@ -450,7 +450,7 @@ static int sg_xfer(struct arasan_cf_dev *acdev, struct scatterlist *sg) | |||
450 | /* | 450 | /* |
451 | * For each sg: | 451 | * For each sg: |
452 | * MAX_XFER_COUNT data will be transferred before we get transfer | 452 | * MAX_XFER_COUNT data will be transferred before we get transfer |
453 | * complete interrupt. Inbetween after FIFO_SIZE data | 453 | * complete interrupt. Between after FIFO_SIZE data |
454 | * buffer available interrupt will be generated. At this time we will | 454 | * buffer available interrupt will be generated. At this time we will |
455 | * fill FIFO again: max FIFO_SIZE data. | 455 | * fill FIFO again: max FIFO_SIZE data. |
456 | */ | 456 | */ |
@@ -463,7 +463,7 @@ static int sg_xfer(struct arasan_cf_dev *acdev, struct scatterlist *sg) | |||
463 | acdev->vbase + XFER_CTR); | 463 | acdev->vbase + XFER_CTR); |
464 | spin_unlock_irqrestore(&acdev->host->lock, flags); | 464 | spin_unlock_irqrestore(&acdev->host->lock, flags); |
465 | 465 | ||
466 | /* continue dma xfers untill current sg is completed */ | 466 | /* continue dma xfers until current sg is completed */ |
467 | while (xfer_cnt) { | 467 | while (xfer_cnt) { |
468 | /* wait for read to complete */ | 468 | /* wait for read to complete */ |
469 | if (!write) { | 469 | if (!write) { |
@@ -563,7 +563,7 @@ static void data_xfer(struct work_struct *work) | |||
563 | 563 | ||
564 | chan_request_fail: | 564 | chan_request_fail: |
565 | spin_lock_irqsave(&acdev->host->lock, flags); | 565 | spin_lock_irqsave(&acdev->host->lock, flags); |
566 | /* error when transfering data to/from memory */ | 566 | /* error when transferring data to/from memory */ |
567 | qc->err_mask |= AC_ERR_HOST_BUS; | 567 | qc->err_mask |= AC_ERR_HOST_BUS; |
568 | qc->ap->hsm_task_state = HSM_ST_ERR; | 568 | qc->ap->hsm_task_state = HSM_ST_ERR; |
569 | 569 | ||
diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c index e0b58b8dfe6f..ea64967000ff 100644 --- a/drivers/ata/pata_bf54x.c +++ b/drivers/ata/pata_bf54x.c | |||
@@ -1342,7 +1342,7 @@ static unsigned int bfin_ata_host_intr(struct ata_port *ap, | |||
1342 | ap->ops->bmdma_stop(qc); | 1342 | ap->ops->bmdma_stop(qc); |
1343 | 1343 | ||
1344 | if (unlikely(host_stat & ATA_DMA_ERR)) { | 1344 | if (unlikely(host_stat & ATA_DMA_ERR)) { |
1345 | /* error when transfering data to/from memory */ | 1345 | /* error when transferring data to/from memory */ |
1346 | qc->err_mask |= AC_ERR_HOST_BUS; | 1346 | qc->err_mask |= AC_ERR_HOST_BUS; |
1347 | ap->hsm_task_state = HSM_ST_ERR; | 1347 | ap->hsm_task_state = HSM_ST_ERR; |
1348 | } | 1348 | } |
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c index 030952f1f97c..e3254fcff0f1 100644 --- a/drivers/ata/pata_cs5520.c +++ b/drivers/ata/pata_cs5520.c | |||
@@ -29,7 +29,7 @@ | |||
29 | * General Public License for more details. | 29 | * General Public License for more details. |
30 | * | 30 | * |
31 | * Documentation: | 31 | * Documentation: |
32 | * Not publically available. | 32 | * Not publicly available. |
33 | */ | 33 | */ |
34 | #include <linux/kernel.h> | 34 | #include <linux/kernel.h> |
35 | #include <linux/module.h> | 35 | #include <linux/module.h> |
diff --git a/drivers/ata/pata_mpiix.c b/drivers/ata/pata_mpiix.c index b21f0021f54a..d8d9c5807740 100644 --- a/drivers/ata/pata_mpiix.c +++ b/drivers/ata/pata_mpiix.c | |||
@@ -15,7 +15,7 @@ | |||
15 | * with PCI IDE and also that we do not disable the device when our driver is | 15 | * with PCI IDE and also that we do not disable the device when our driver is |
16 | * unloaded (as it has many other functions). | 16 | * unloaded (as it has many other functions). |
17 | * | 17 | * |
18 | * The driver conciously keeps this logic internally to avoid pushing quirky | 18 | * The driver consciously keeps this logic internally to avoid pushing quirky |
19 | * PATA history into the clean libata layer. | 19 | * PATA history into the clean libata layer. |
20 | * | 20 | * |
21 | * Thinkpad specific note: If you boot an MPIIX using a thinkpad with a PCMCIA | 21 | * Thinkpad specific note: If you boot an MPIIX using a thinkpad with a PCMCIA |
diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c index a2a73d953840..b86d7e22595e 100644 --- a/drivers/ata/pata_palmld.c +++ b/drivers/ata/pata_palmld.c | |||
@@ -33,6 +33,11 @@ | |||
33 | 33 | ||
34 | #define DRV_NAME "pata_palmld" | 34 | #define DRV_NAME "pata_palmld" |
35 | 35 | ||
36 | static struct gpio palmld_hdd_gpios[] = { | ||
37 | { GPIO_NR_PALMLD_IDE_PWEN, GPIOF_INIT_HIGH, "HDD Power" }, | ||
38 | { GPIO_NR_PALMLD_IDE_RESET, GPIOF_INIT_LOW, "HDD Reset" }, | ||
39 | }; | ||
40 | |||
36 | static struct scsi_host_template palmld_sht = { | 41 | static struct scsi_host_template palmld_sht = { |
37 | ATA_PIO_SHT(DRV_NAME), | 42 | ATA_PIO_SHT(DRV_NAME), |
38 | }; | 43 | }; |
@@ -52,28 +57,23 @@ static __devinit int palmld_pata_probe(struct platform_device *pdev) | |||
52 | 57 | ||
53 | /* allocate host */ | 58 | /* allocate host */ |
54 | host = ata_host_alloc(&pdev->dev, 1); | 59 | host = ata_host_alloc(&pdev->dev, 1); |
55 | if (!host) | 60 | if (!host) { |
56 | return -ENOMEM; | 61 | ret = -ENOMEM; |
62 | goto err1; | ||
63 | } | ||
57 | 64 | ||
58 | /* remap drive's physical memory address */ | 65 | /* remap drive's physical memory address */ |
59 | mem = devm_ioremap(&pdev->dev, PALMLD_IDE_PHYS, 0x1000); | 66 | mem = devm_ioremap(&pdev->dev, PALMLD_IDE_PHYS, 0x1000); |
60 | if (!mem) | 67 | if (!mem) { |
61 | return -ENOMEM; | 68 | ret = -ENOMEM; |
69 | goto err1; | ||
70 | } | ||
62 | 71 | ||
63 | /* request and activate power GPIO, IRQ GPIO */ | 72 | /* request and activate power GPIO, IRQ GPIO */ |
64 | ret = gpio_request(GPIO_NR_PALMLD_IDE_PWEN, "HDD PWR"); | 73 | ret = gpio_request_array(palmld_hdd_gpios, |
74 | ARRAY_SIZE(palmld_hdd_gpios)); | ||
65 | if (ret) | 75 | if (ret) |
66 | goto err1; | 76 | goto err1; |
67 | ret = gpio_direction_output(GPIO_NR_PALMLD_IDE_PWEN, 1); | ||
68 | if (ret) | ||
69 | goto err2; | ||
70 | |||
71 | ret = gpio_request(GPIO_NR_PALMLD_IDE_RESET, "HDD RST"); | ||
72 | if (ret) | ||
73 | goto err2; | ||
74 | ret = gpio_direction_output(GPIO_NR_PALMLD_IDE_RESET, 0); | ||
75 | if (ret) | ||
76 | goto err3; | ||
77 | 77 | ||
78 | /* reset the drive */ | 78 | /* reset the drive */ |
79 | gpio_set_value(GPIO_NR_PALMLD_IDE_RESET, 0); | 79 | gpio_set_value(GPIO_NR_PALMLD_IDE_RESET, 0); |
@@ -96,13 +96,15 @@ static __devinit int palmld_pata_probe(struct platform_device *pdev) | |||
96 | ata_sff_std_ports(&ap->ioaddr); | 96 | ata_sff_std_ports(&ap->ioaddr); |
97 | 97 | ||
98 | /* activate host */ | 98 | /* activate host */ |
99 | return ata_host_activate(host, 0, NULL, IRQF_TRIGGER_RISING, | 99 | ret = ata_host_activate(host, 0, NULL, IRQF_TRIGGER_RISING, |
100 | &palmld_sht); | 100 | &palmld_sht); |
101 | if (ret) | ||
102 | goto err2; | ||
103 | |||
104 | return ret; | ||
101 | 105 | ||
102 | err3: | ||
103 | gpio_free(GPIO_NR_PALMLD_IDE_RESET); | ||
104 | err2: | 106 | err2: |
105 | gpio_free(GPIO_NR_PALMLD_IDE_PWEN); | 107 | gpio_free_array(palmld_hdd_gpios, ARRAY_SIZE(palmld_hdd_gpios)); |
106 | err1: | 108 | err1: |
107 | return ret; | 109 | return ret; |
108 | } | 110 | } |
@@ -116,8 +118,7 @@ static __devexit int palmld_pata_remove(struct platform_device *dev) | |||
116 | /* power down the HDD */ | 118 | /* power down the HDD */ |
117 | gpio_set_value(GPIO_NR_PALMLD_IDE_PWEN, 0); | 119 | gpio_set_value(GPIO_NR_PALMLD_IDE_PWEN, 0); |
118 | 120 | ||
119 | gpio_free(GPIO_NR_PALMLD_IDE_RESET); | 121 | gpio_free_array(palmld_hdd_gpios, ARRAY_SIZE(palmld_hdd_gpios)); |
120 | gpio_free(GPIO_NR_PALMLD_IDE_PWEN); | ||
121 | 122 | ||
122 | return 0; | 123 | return 0; |
123 | } | 124 | } |
diff --git a/drivers/ata/pata_rz1000.c b/drivers/ata/pata_rz1000.c index 4a454a88aa9d..4d04471794b6 100644 --- a/drivers/ata/pata_rz1000.c +++ b/drivers/ata/pata_rz1000.c | |||
@@ -112,7 +112,7 @@ static int rz1000_reinit_one(struct pci_dev *pdev) | |||
112 | if (rc) | 112 | if (rc) |
113 | return rc; | 113 | return rc; |
114 | 114 | ||
115 | /* If this fails on resume (which is a "cant happen" case), we | 115 | /* If this fails on resume (which is a "can't happen" case), we |
116 | must stop as any progress risks data loss */ | 116 | must stop as any progress risks data loss */ |
117 | if (rz1000_fifo_disable(pdev)) | 117 | if (rz1000_fifo_disable(pdev)) |
118 | panic("rz1000 fifo"); | 118 | panic("rz1000 fifo"); |
diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c index 00eefbd84b33..118787caa93f 100644 --- a/drivers/ata/pata_sil680.c +++ b/drivers/ata/pata_sil680.c | |||
@@ -11,7 +11,7 @@ | |||
11 | * | 11 | * |
12 | * May be copied or modified under the terms of the GNU General Public License | 12 | * May be copied or modified under the terms of the GNU General Public License |
13 | * | 13 | * |
14 | * Documentation publically available. | 14 | * Documentation publicly available. |
15 | * | 15 | * |
16 | * If you have strange problems with nVidia chipset systems please | 16 | * If you have strange problems with nVidia chipset systems please |
17 | * see the SI support documentation and update your system BIOS | 17 | * see the SI support documentation and update your system BIOS |
@@ -43,7 +43,7 @@ | |||
43 | * | 43 | * |
44 | * Turn a config register offset into the right address in either | 44 | * Turn a config register offset into the right address in either |
45 | * PCI space or MMIO space to access the control register in question | 45 | * PCI space or MMIO space to access the control register in question |
46 | * Thankfully this is a configuration operation so isnt performance | 46 | * Thankfully this is a configuration operation so isn't performance |
47 | * criticial. | 47 | * criticial. |
48 | */ | 48 | */ |
49 | 49 | ||
diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c index c04abc393fc5..be08ff92db17 100644 --- a/drivers/ata/pata_sis.c +++ b/drivers/ata/pata_sis.c | |||
@@ -331,7 +331,7 @@ static void sis_old_set_dmamode (struct ata_port *ap, struct ata_device *adev) | |||
331 | 331 | ||
332 | if (adev->dma_mode < XFER_UDMA_0) { | 332 | if (adev->dma_mode < XFER_UDMA_0) { |
333 | /* bits 3-0 hold recovery timing bits 8-10 active timing and | 333 | /* bits 3-0 hold recovery timing bits 8-10 active timing and |
334 | the higher bits are dependant on the device */ | 334 | the higher bits are dependent on the device */ |
335 | timing &= ~0x870F; | 335 | timing &= ~0x870F; |
336 | timing |= mwdma_bits[speed]; | 336 | timing |= mwdma_bits[speed]; |
337 | } else { | 337 | } else { |
@@ -371,7 +371,7 @@ static void sis_66_set_dmamode (struct ata_port *ap, struct ata_device *adev) | |||
371 | 371 | ||
372 | if (adev->dma_mode < XFER_UDMA_0) { | 372 | if (adev->dma_mode < XFER_UDMA_0) { |
373 | /* bits 3-0 hold recovery timing bits 8-10 active timing and | 373 | /* bits 3-0 hold recovery timing bits 8-10 active timing and |
374 | the higher bits are dependant on the device, bit 15 udma */ | 374 | the higher bits are dependent on the device, bit 15 udma */ |
375 | timing &= ~0x870F; | 375 | timing &= ~0x870F; |
376 | timing |= mwdma_bits[speed]; | 376 | timing |= mwdma_bits[speed]; |
377 | } else { | 377 | } else { |
diff --git a/drivers/ata/pata_triflex.c b/drivers/ata/pata_triflex.c index 0d1f89e571dd..03b6d69d6197 100644 --- a/drivers/ata/pata_triflex.c +++ b/drivers/ata/pata_triflex.c | |||
@@ -30,7 +30,7 @@ | |||
30 | * Loosely based on the piix & svwks drivers. | 30 | * Loosely based on the piix & svwks drivers. |
31 | * | 31 | * |
32 | * Documentation: | 32 | * Documentation: |
33 | * Not publically available. | 33 | * Not publicly available. |
34 | */ | 34 | */ |
35 | 35 | ||
36 | #include <linux/kernel.h> | 36 | #include <linux/kernel.h> |
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index 0f91e583892e..35a71d875d0e 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c | |||
@@ -42,7 +42,7 @@ enum { | |||
42 | 42 | ||
43 | /* | 43 | /* |
44 | * SATA-FSL host controller supports a max. of (15+1) direct PRDEs, and | 44 | * SATA-FSL host controller supports a max. of (15+1) direct PRDEs, and |
45 | * chained indirect PRDEs upto a max count of 63. | 45 | * chained indirect PRDEs up to a max count of 63. |
46 | * We are allocating an array of 63 PRDEs contiguously, but PRDE#15 will | 46 | * We are allocating an array of 63 PRDEs contiguously, but PRDE#15 will |
47 | * be setup as an indirect descriptor, pointing to it's next | 47 | * be setup as an indirect descriptor, pointing to it's next |
48 | * (contiguous) PRDE. Though chained indirect PRDE arrays are | 48 | * (contiguous) PRDE. Though chained indirect PRDE arrays are |
@@ -907,7 +907,7 @@ static int sata_fsl_softreset(struct ata_link *link, unsigned int *class, | |||
907 | ata_msleep(ap, 1); | 907 | ata_msleep(ap, 1); |
908 | 908 | ||
909 | /* | 909 | /* |
910 | * SATA device enters reset state after receving a Control register | 910 | * SATA device enters reset state after receiving a Control register |
911 | * FIS with SRST bit asserted and it awaits another H2D Control reg. | 911 | * FIS with SRST bit asserted and it awaits another H2D Control reg. |
912 | * FIS with SRST bit cleared, then the device does internal diags & | 912 | * FIS with SRST bit cleared, then the device does internal diags & |
913 | * initialization, followed by indicating it's initialization status | 913 | * initialization, followed by indicating it's initialization status |
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index cd40651e9b72..b52c0519ad0b 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c | |||
@@ -1352,7 +1352,7 @@ static int mv_scr_write(struct ata_link *link, unsigned int sc_reg_in, u32 val) | |||
1352 | /* | 1352 | /* |
1353 | * Workaround for 88SX60x1 FEr SATA#26: | 1353 | * Workaround for 88SX60x1 FEr SATA#26: |
1354 | * | 1354 | * |
1355 | * COMRESETs have to take care not to accidently | 1355 | * COMRESETs have to take care not to accidentally |
1356 | * put the drive to sleep when writing SCR_CONTROL. | 1356 | * put the drive to sleep when writing SCR_CONTROL. |
1357 | * Setting bits 12..15 prevents this problem. | 1357 | * Setting bits 12..15 prevents this problem. |
1358 | * | 1358 | * |
@@ -2044,7 +2044,7 @@ static void mv_qc_prep(struct ata_queued_cmd *qc) | |||
2044 | 2044 | ||
2045 | cw = &pp->crqb[in_index].ata_cmd[0]; | 2045 | cw = &pp->crqb[in_index].ata_cmd[0]; |
2046 | 2046 | ||
2047 | /* Sadly, the CRQB cannot accomodate all registers--there are | 2047 | /* Sadly, the CRQB cannot accommodate all registers--there are |
2048 | * only 11 bytes...so we must pick and choose required | 2048 | * only 11 bytes...so we must pick and choose required |
2049 | * registers based on the command. So, we drop feature and | 2049 | * registers based on the command. So, we drop feature and |
2050 | * hob_feature for [RW] DMA commands, but they are needed for | 2050 | * hob_feature for [RW] DMA commands, but they are needed for |
diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c index 42344e3c686d..f173ef3bfc10 100644 --- a/drivers/ata/sata_nv.c +++ b/drivers/ata/sata_nv.c | |||
@@ -2121,7 +2121,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap) | |||
2121 | 2121 | ||
2122 | host_stat = ap->ops->bmdma_status(ap); | 2122 | host_stat = ap->ops->bmdma_status(ap); |
2123 | if (unlikely(host_stat & ATA_DMA_ERR)) { | 2123 | if (unlikely(host_stat & ATA_DMA_ERR)) { |
2124 | /* error when transfering data to/from memory */ | 2124 | /* error when transferring data to/from memory */ |
2125 | ata_ehi_clear_desc(ehi); | 2125 | ata_ehi_clear_desc(ehi); |
2126 | ata_ehi_push_desc(ehi, "BMDMA stat 0x%x", host_stat); | 2126 | ata_ehi_push_desc(ehi, "BMDMA stat 0x%x", host_stat); |
2127 | ehi->err_mask |= AC_ERR_HOST_BUS; | 2127 | ehi->err_mask |= AC_ERR_HOST_BUS; |
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c index 21242c5709a0..54434db15b12 100644 --- a/drivers/ata/sata_via.c +++ b/drivers/ata/sata_via.c | |||
@@ -582,7 +582,7 @@ static void svia_configure(struct pci_dev *pdev, int board_id) | |||
582 | * When host issues HOLD, device may send up to 20DW of data | 582 | * When host issues HOLD, device may send up to 20DW of data |
583 | * before acknowledging it with HOLDA and the host should be | 583 | * before acknowledging it with HOLDA and the host should be |
584 | * able to buffer them in FIFO. Unfortunately, some WD drives | 584 | * able to buffer them in FIFO. Unfortunately, some WD drives |
585 | * send upto 40DW before acknowledging HOLD and, in the | 585 | * send up to 40DW before acknowledging HOLD and, in the |
586 | * default configuration, this ends up overflowing vt6421's | 586 | * default configuration, this ends up overflowing vt6421's |
587 | * FIFO, making the controller abort the transaction with | 587 | * FIFO, making the controller abort the transaction with |
588 | * R_ERR. | 588 | * R_ERR. |