1 files changed, 48 insertions, 10 deletions

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 37ae5dc1070c..870dcfd82357 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -1881,6 +1881,39 @@ static u8 mv_bmdma_status(struct ata_port *ap)
         return status;
 }
 
+static void mv_rw_multi_errata_sata24(struct ata_queued_cmd *qc)
+{
+        struct ata_taskfile *tf = &qc->tf;
+        /*
+         * Workaround for 88SX60x1 FEr SATA#24.
+         *
+         * Chip may corrupt WRITEs if multi_count >= 4kB.
+         * Note that READs are unaffected.
+         *
+         * It's not clear if this errata really means "4K bytes",
+         * or if it always happens for multi_count > 7
+         * regardless of device sector_size.
+         *
+         * So, for safety, any write with multi_count > 7
+         * gets converted here into a regular PIO write instead:
+         */
+        if ((tf->flags & ATA_TFLAG_WRITE) && is_multi_taskfile(tf)) {
+                if (qc->dev->multi_count > 7) {
+                        switch (tf->command) {
+                        case ATA_CMD_WRITE_MULTI:
+                                tf->command = ATA_CMD_PIO_WRITE;
+                                break;
+                        case ATA_CMD_WRITE_MULTI_FUA_EXT:
+                                tf->flags &= ~ATA_TFLAG_FUA; /* ugh */
+                                /* fall through */
+                        case ATA_CMD_WRITE_MULTI_EXT:
+                                tf->command = ATA_CMD_PIO_WRITE_EXT;
+                                break;
+                        }
+                }
+        }
+}
+
 /**
  *      mv_qc_prep - Host specific command preparation.
  *      @qc: queued command to prepare
@@ -1898,17 +1931,24 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
         struct ata_port *ap = qc->ap;
         struct mv_port_priv *pp = ap->private_data;
         __le16 *cw;
-        struct ata_taskfile *tf;
+        struct ata_taskfile *tf = &qc->tf;
         u16 flags = 0;
         unsigned in_index;
 
-        if ((qc->tf.protocol != ATA_PROT_DMA) &&
-            (qc->tf.protocol != ATA_PROT_NCQ))
+        switch (tf->protocol) {
+        case ATA_PROT_DMA:
+        case ATA_PROT_NCQ:
+                break;  /* continue below */
+        case ATA_PROT_PIO:
+                mv_rw_multi_errata_sata24(qc);
+                return;
+        default:
                 return;
+        }
 
         /* Fill in command request block
          */
-        if (!(qc->tf.flags & ATA_TFLAG_WRITE))
+        if (!(tf->flags & ATA_TFLAG_WRITE))
                 flags |= CRQB_FLAG_READ;
         WARN_ON(MV_MAX_Q_DEPTH <= qc->tag);
         flags |= qc->tag << CRQB_TAG_SHIFT;
@@ -1924,7 +1964,6 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
         pp->crqb[in_index].ctrl_flags = cpu_to_le16(flags);
 
         cw = &pp->crqb[in_index].ata_cmd[0];
-        tf = &qc->tf;
 
         /* Sadly, the CRQB cannot accomodate all registers--there are
          * only 11 bytes...so we must pick and choose required
@@ -1990,16 +2029,16 @@ static void mv_qc_prep_iie(struct ata_queued_cmd *qc)
         struct ata_port *ap = qc->ap;
         struct mv_port_priv *pp = ap->private_data;
         struct mv_crqb_iie *crqb;
-        struct ata_taskfile *tf;
+        struct ata_taskfile *tf = &qc->tf;
         unsigned in_index;
         u32 flags = 0;
 
-        if ((qc->tf.protocol != ATA_PROT_DMA) &&
-            (qc->tf.protocol != ATA_PROT_NCQ))
+        if ((tf->protocol != ATA_PROT_DMA) &&
+            (tf->protocol != ATA_PROT_NCQ))
                 return;
 
         /* Fill in Gen IIE command request block */
-        if (!(qc->tf.flags & ATA_TFLAG_WRITE))
+        if (!(tf->flags & ATA_TFLAG_WRITE))
                 flags |= CRQB_FLAG_READ;
 
         WARN_ON(MV_MAX_Q_DEPTH <= qc->tag);
@@ -2015,7 +2054,6 @@ static void mv_qc_prep_iie(struct ata_queued_cmd *qc)
         crqb->addr_hi = cpu_to_le32((pp->sg_tbl_dma[qc->tag] >> 16) >> 16);
         crqb->flags = cpu_to_le32(flags);
 
-        tf = &qc->tf;
         crqb->ata_cmd[0] = cpu_to_le32(
                         (tf->command << 16) |
                         (tf->feature << 24)