diff options
Diffstat (limited to 'drivers/ata/ata_piix.c')
-rw-r--r-- | drivers/ata/ata_piix.c | 39 |
1 files changed, 20 insertions, 19 deletions
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c index 6f6e7718b05c..9842faac097f 100644 --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c | |||
@@ -1225,8 +1225,9 @@ static int piix_pci_device_resume(struct pci_dev *pdev) | |||
1225 | */ | 1225 | */ |
1226 | rc = pci_reenable_device(pdev); | 1226 | rc = pci_reenable_device(pdev); |
1227 | if (rc) | 1227 | if (rc) |
1228 | dev_printk(KERN_ERR, &pdev->dev, "failed to enable " | 1228 | dev_err(&pdev->dev, |
1229 | "device after resume (%d)\n", rc); | 1229 | "failed to enable device after resume (%d)\n", |
1230 | rc); | ||
1230 | } else | 1231 | } else |
1231 | rc = ata_pci_device_do_resume(pdev); | 1232 | rc = ata_pci_device_do_resume(pdev); |
1232 | 1233 | ||
@@ -1303,9 +1304,11 @@ static int __devinit piix_check_450nx_errata(struct pci_dev *ata_dev) | |||
1303 | no_piix_dma = 2; | 1304 | no_piix_dma = 2; |
1304 | } | 1305 | } |
1305 | if (no_piix_dma) | 1306 | if (no_piix_dma) |
1306 | dev_printk(KERN_WARNING, &ata_dev->dev, "450NX errata present, disabling IDE DMA.\n"); | 1307 | dev_warn(&ata_dev->dev, |
1307 | if (no_piix_dma == 2) | 1308 | "450NX errata present, disabling IDE DMA%s\n", |
1308 | dev_printk(KERN_WARNING, &ata_dev->dev, "A BIOS update may resolve this.\n"); | 1309 | no_piix_dma == 2 ? " - a BIOS update may resolve this" |
1310 | : ""); | ||
1311 | |||
1309 | return no_piix_dma; | 1312 | return no_piix_dma; |
1310 | } | 1313 | } |
1311 | 1314 | ||
@@ -1338,37 +1341,36 @@ static const int *__devinit piix_init_sata_map(struct pci_dev *pdev, | |||
1338 | 1341 | ||
1339 | map = map_db->map[map_value & map_db->mask]; | 1342 | map = map_db->map[map_value & map_db->mask]; |
1340 | 1343 | ||
1341 | dev_printk(KERN_INFO, &pdev->dev, "MAP ["); | 1344 | dev_info(&pdev->dev, "MAP ["); |
1342 | for (i = 0; i < 4; i++) { | 1345 | for (i = 0; i < 4; i++) { |
1343 | switch (map[i]) { | 1346 | switch (map[i]) { |
1344 | case RV: | 1347 | case RV: |
1345 | invalid_map = 1; | 1348 | invalid_map = 1; |
1346 | printk(" XX"); | 1349 | pr_cont(" XX"); |
1347 | break; | 1350 | break; |
1348 | 1351 | ||
1349 | case NA: | 1352 | case NA: |
1350 | printk(" --"); | 1353 | pr_cont(" --"); |
1351 | break; | 1354 | break; |
1352 | 1355 | ||
1353 | case IDE: | 1356 | case IDE: |
1354 | WARN_ON((i & 1) || map[i + 1] != IDE); | 1357 | WARN_ON((i & 1) || map[i + 1] != IDE); |
1355 | pinfo[i / 2] = piix_port_info[ich_pata_100]; | 1358 | pinfo[i / 2] = piix_port_info[ich_pata_100]; |
1356 | i++; | 1359 | i++; |
1357 | printk(" IDE IDE"); | 1360 | pr_cont(" IDE IDE"); |
1358 | break; | 1361 | break; |
1359 | 1362 | ||
1360 | default: | 1363 | default: |
1361 | printk(" P%d", map[i]); | 1364 | pr_cont(" P%d", map[i]); |
1362 | if (i & 1) | 1365 | if (i & 1) |
1363 | pinfo[i / 2].flags |= ATA_FLAG_SLAVE_POSS; | 1366 | pinfo[i / 2].flags |= ATA_FLAG_SLAVE_POSS; |
1364 | break; | 1367 | break; |
1365 | } | 1368 | } |
1366 | } | 1369 | } |
1367 | printk(" ]\n"); | 1370 | pr_cont(" ]\n"); |
1368 | 1371 | ||
1369 | if (invalid_map) | 1372 | if (invalid_map) |
1370 | dev_printk(KERN_ERR, &pdev->dev, | 1373 | dev_err(&pdev->dev, "invalid MAP value %u\n", map_value); |
1371 | "invalid MAP value %u\n", map_value); | ||
1372 | 1374 | ||
1373 | return map; | 1375 | return map; |
1374 | } | 1376 | } |
@@ -1398,8 +1400,8 @@ static bool piix_no_sidpr(struct ata_host *host) | |||
1398 | if (pdev->vendor == PCI_VENDOR_ID_INTEL && pdev->device == 0x2920 && | 1400 | if (pdev->vendor == PCI_VENDOR_ID_INTEL && pdev->device == 0x2920 && |
1399 | pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG && | 1401 | pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG && |
1400 | pdev->subsystem_device == 0xb049) { | 1402 | pdev->subsystem_device == 0xb049) { |
1401 | dev_printk(KERN_WARNING, host->dev, | 1403 | dev_warn(host->dev, |
1402 | "Samsung DB-P70 detected, disabling SIDPR\n"); | 1404 | "Samsung DB-P70 detected, disabling SIDPR\n"); |
1403 | return true; | 1405 | return true; |
1404 | } | 1406 | } |
1405 | 1407 | ||
@@ -1451,8 +1453,8 @@ static int __devinit piix_init_sidpr(struct ata_host *host) | |||
1451 | piix_sidpr_scr_read(link0, SCR_CONTROL, &scontrol); | 1453 | piix_sidpr_scr_read(link0, SCR_CONTROL, &scontrol); |
1452 | 1454 | ||
1453 | if ((scontrol & 0xf00) != 0x300) { | 1455 | if ((scontrol & 0xf00) != 0x300) { |
1454 | dev_printk(KERN_INFO, host->dev, "SCR access via " | 1456 | dev_info(host->dev, |
1455 | "SIDPR is available but doesn't work\n"); | 1457 | "SCR access via SIDPR is available but doesn't work\n"); |
1456 | return 0; | 1458 | return 0; |
1457 | } | 1459 | } |
1458 | } | 1460 | } |
@@ -1501,8 +1503,7 @@ static void piix_iocfg_bit18_quirk(struct ata_host *host) | |||
1501 | * affected systems. | 1503 | * affected systems. |
1502 | */ | 1504 | */ |
1503 | if (hpriv->saved_iocfg & (1 << 18)) { | 1505 | if (hpriv->saved_iocfg & (1 << 18)) { |
1504 | dev_printk(KERN_INFO, &pdev->dev, | 1506 | dev_info(&pdev->dev, "applying IOCFG bit18 quirk\n"); |
1505 | "applying IOCFG bit18 quirk\n"); | ||
1506 | pci_write_config_dword(pdev, PIIX_IOCFG, | 1507 | pci_write_config_dword(pdev, PIIX_IOCFG, |
1507 | hpriv->saved_iocfg & ~(1 << 18)); | 1508 | hpriv->saved_iocfg & ~(1 << 18)); |
1508 | } | 1509 | } |