2 files changed, 13 insertions, 19 deletions

diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index bec561c14beb..3c1a2fec8cda 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -23,7 +23,7 @@ static int set_no_mwait(const struct dmi_system_id *id)
 {
         printk(KERN_NOTICE PREFIX "%s detected - "
                 "disabling mwait for CPU C-states\n", id->ident);
-        idle_nomwait = 1;
+        boot_option_idle_override = IDLE_NOMWAIT;
         return 0;
 }
 
@@ -283,7 +283,7 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
 {
         acpi_status status = AE_OK;
 
-        if (idle_nomwait) {
+        if (boot_option_idle_override == IDLE_NOMWAIT) {
                 /*
                  * If mwait is disabled for CPU C-states, the C2C3_FFH access
                  * mode will be disabled in the parameter of _PDC object.
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index a765b823aa9e..d615b7d69bca 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -79,6 +79,13 @@ module_param(bm_check_disable, uint, 0000);
 static unsigned int latency_factor __read_mostly = 2;
 module_param(latency_factor, uint, 0644);
 
+static int disabled_by_idle_boot_param(void)
+{
+        return boot_option_idle_override == IDLE_POLL ||
+                boot_option_idle_override == IDLE_FORCE_MWAIT ||
+                boot_option_idle_override == IDLE_HALT;
+}
+
 /*
  * IBM ThinkPad R40e crashes mysteriously when going into C2 or C3.
  * For now disable this. Probably a bug somewhere else.
@@ -455,7 +462,7 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr)
                                 continue;
                         }
                         if (cx.type == ACPI_STATE_C1 &&
-                                        (idle_halt || idle_nomwait)) {
+                            (boot_option_idle_override == IDLE_NOMWAIT)) {
                                 /*
                                  * In most cases the C1 space_id obtained from
                                  * _CST object is FIXED_HARDWARE access mode.
@@ -1016,7 +1023,6 @@ static int acpi_processor_setup_cpuidle(struct acpi_processor *pr)
                 state->flags = 0;
                 switch (cx->type) {
                         case ACPI_STATE_C1:
-                        state->flags |= CPUIDLE_FLAG_SHALLOW;
                         if (cx->entry_method == ACPI_CSTATE_FFH)
                                 state->flags |= CPUIDLE_FLAG_TIME_VALID;
 
@@ -1025,16 +1031,13 @@ static int acpi_processor_setup_cpuidle(struct acpi_processor *pr)
                         break;
 
                         case ACPI_STATE_C2:
-                        state->flags |= CPUIDLE_FLAG_BALANCED;
                         state->flags |= CPUIDLE_FLAG_TIME_VALID;
                         state->enter = acpi_idle_enter_simple;
                         dev->safe_state = state;
                         break;
 
                         case ACPI_STATE_C3:
-                        state->flags |= CPUIDLE_FLAG_DEEP;
                         state->flags |= CPUIDLE_FLAG_TIME_VALID;
-                        state->flags |= CPUIDLE_FLAG_CHECK_BM;
                         state->enter = pr->flags.bm_check ?
                                         acpi_idle_enter_bm :
                                         acpi_idle_enter_simple;
@@ -1058,7 +1061,7 @@ int acpi_processor_cst_has_changed(struct acpi_processor *pr)
 {
         int ret = 0;
 
-        if (boot_option_idle_override)
+        if (disabled_by_idle_boot_param())
                 return 0;
 
         if (!pr)
@@ -1089,19 +1092,10 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr,
         acpi_status status = 0;
         static int first_run;
 
-        if (boot_option_idle_override)
+        if (disabled_by_idle_boot_param())
                 return 0;
 
         if (!first_run) {
-                if (idle_halt) {
-                        /*
-                         * When the boot option of "idle=halt" is added, halt
-                         * is used for CPU IDLE.
-                         * In such case C2/C3 is meaningless. So the max_cstate
-                         * is set to one.
-                         */
-                        max_cstate = 1;
-                }
                 dmi_check_system(processor_power_dmi_table);
                 max_cstate = acpi_processor_cstate_check(max_cstate);
                 if (max_cstate < ACPI_C_STATES_MAX)
@@ -1142,7 +1136,7 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr,
 int acpi_processor_power_exit(struct acpi_processor *pr,
                               struct acpi_device *device)
 {
-        if (boot_option_idle_override)
+        if (disabled_by_idle_boot_param())
                 return 0;
 
         cpuidle_unregister_device(&pr->power.dev);