1 files changed, 5 insertions, 5 deletions

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index f051b151580d..bd4887518373 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -812,7 +812,7 @@ acpi_video_device_write_brightness(struct file *file,
 
         ACPI_FUNCTION_TRACE("acpi_video_device_write_brightness");
 
-        if (!dev || count + 1 > sizeof str)
+        if (!dev || !dev->brightness || count + 1 > sizeof str)
                 return_VALUE(-EINVAL);
 
         if (copy_from_user(str, buffer, count))
@@ -920,8 +920,8 @@ static int acpi_video_device_add_fs(struct acpi_device *device)
                 ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
                                   "Unable to create 'state' fs entry\n"));
         else {
+                acpi_video_device_state_fops.write = acpi_video_device_write_state;
                 entry->proc_fops = &acpi_video_device_state_fops;
-                entry->proc_fops->write = acpi_video_device_write_state;
                 entry->data = acpi_driver_data(device);
                 entry->owner = THIS_MODULE;
         }
@@ -934,8 +934,8 @@ static int acpi_video_device_add_fs(struct acpi_device *device)
                 ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
                                   "Unable to create 'brightness' fs entry\n"));
         else {
+                acpi_video_device_brightness_fops.write = acpi_video_device_write_brightness;
                 entry->proc_fops = &acpi_video_device_brightness_fops;
-                entry->proc_fops->write = acpi_video_device_write_brightness;
                 entry->data = acpi_driver_data(device);
                 entry->owner = THIS_MODULE;
         }
@@ -1239,8 +1239,8 @@ static int acpi_video_bus_add_fs(struct acpi_device *device)
                 ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
                                   "Unable to create 'POST' fs entry\n"));
         else {
+                acpi_video_bus_POST_fops.write = acpi_video_bus_write_POST;
                 entry->proc_fops = &acpi_video_bus_POST_fops;
-                entry->proc_fops->write = acpi_video_bus_write_POST;
                 entry->data = acpi_driver_data(device);
                 entry->owner = THIS_MODULE;
         }
@@ -1253,8 +1253,8 @@ static int acpi_video_bus_add_fs(struct acpi_device *device)
                 ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
                                   "Unable to create 'DOS' fs entry\n"));
         else {
+                acpi_video_bus_DOS_fops.write = acpi_video_bus_write_DOS;
                 entry->proc_fops = &acpi_video_bus_DOS_fops;
-                entry->proc_fops->write = acpi_video_bus_write_DOS;
                 entry->data = acpi_driver_data(device);
                 entry->owner = THIS_MODULE;
         }