8 files changed, 76 insertions, 80 deletions

diff --git a/drivers/acpi/tables/tbconvrt.c b/drivers/acpi/tables/tbconvrt.c
index a913a927d321..d697fcb35d52 100644
--- a/drivers/acpi/tables/tbconvrt.c
+++ b/drivers/acpi/tables/tbconvrt.c
@@ -492,7 +492,7 @@ acpi_status acpi_tb_convert_table_fadt(void)
         struct fadt_descriptor *local_fadt;
         struct acpi_table_desc *table_desc;
 
-        ACPI_FUNCTION_TRACE("tb_convert_table_fadt");
+        ACPI_FUNCTION_TRACE(tb_convert_table_fadt);
 
         /*
          * acpi_gbl_FADT is valid. Validate the FADT length. The table must be
@@ -541,7 +541,7 @@ acpi_status acpi_tb_convert_table_fadt(void)
 
         /* Free the original table */
 
-        table_desc = acpi_gbl_table_lists[ACPI_TABLE_FADT].next;
+        table_desc = acpi_gbl_table_lists[ACPI_TABLE_ID_FADT].next;
         acpi_tb_delete_single_table(table_desc);
 
         /* Install the new table */
@@ -579,7 +579,7 @@ acpi_status acpi_tb_convert_table_fadt(void)
 acpi_status acpi_tb_build_common_facs(struct acpi_table_desc *table_info)
 {
 
-        ACPI_FUNCTION_TRACE("tb_build_common_facs");
+        ACPI_FUNCTION_TRACE(tb_build_common_facs);
 
         /* Absolute minimum length is 24, but the ACPI spec says 64 */
 
diff --git a/drivers/acpi/tables/tbget.c b/drivers/acpi/tables/tbget.c
index b7bd20b9a75e..3a4f46ca3884 100644
--- a/drivers/acpi/tables/tbget.c
+++ b/drivers/acpi/tables/tbget.c
@@ -78,7 +78,7 @@ acpi_tb_get_table(struct acpi_pointer *address,
         acpi_status status;
         struct acpi_table_header header;
 
-        ACPI_FUNCTION_TRACE("tb_get_table");
+        ACPI_FUNCTION_TRACE(tb_get_table);
 
         /* Get the header in order to get signature and table size */
 
@@ -124,7 +124,7 @@ acpi_tb_get_table_header(struct acpi_pointer *address,
         acpi_status status = AE_OK;
         struct acpi_table_header *header = NULL;
 
-        ACPI_FUNCTION_TRACE("tb_get_table_header");
+        ACPI_FUNCTION_TRACE(tb_get_table_header);
 
         /*
          * Flags contains the current processor mode (Virtual or Physical
@@ -202,7 +202,7 @@ acpi_tb_get_table_body(struct acpi_pointer *address,
 {
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("tb_get_table_body");
+        ACPI_FUNCTION_TRACE(tb_get_table_body);
 
         if (!table_info || !address) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
@@ -246,7 +246,7 @@ acpi_tb_table_override(struct acpi_table_header *header,
         acpi_status status;
         struct acpi_pointer address;
 
-        ACPI_FUNCTION_TRACE("tb_table_override");
+        ACPI_FUNCTION_TRACE(tb_table_override);
 
         /*
          * The OSL will examine the header and decide whether to override this
@@ -318,7 +318,7 @@ acpi_tb_get_this_table(struct acpi_pointer *address,
         u8 allocation;
         acpi_status status = AE_OK;
 
-        ACPI_FUNCTION_TRACE("tb_get_this_table");
+        ACPI_FUNCTION_TRACE(tb_get_this_table);
 
         /*
          * Flags contains the current processor mode (Virtual or Physical
@@ -383,7 +383,7 @@ acpi_tb_get_this_table(struct acpi_pointer *address,
          * Validate checksum for _most_ tables,
          * even the ones whose signature we don't recognize
          */
-        if (table_info->type != ACPI_TABLE_FACS) {
+        if (table_info->type != ACPI_TABLE_ID_FACS) {
                 status = acpi_tb_verify_table_checksum(full_table);
 
 #if (!ACPI_CHECKSUM_ABORT)
@@ -433,13 +433,13 @@ acpi_tb_get_table_ptr(acpi_table_type table_type,
         struct acpi_table_desc *table_desc;
         u32 i;
 
-        ACPI_FUNCTION_TRACE("tb_get_table_ptr");
+        ACPI_FUNCTION_TRACE(tb_get_table_ptr);
 
         if (!acpi_gbl_DSDT) {
                 return_ACPI_STATUS(AE_NO_ACPI_TABLES);
         }
 
-        if (table_type > ACPI_TABLE_MAX) {
+        if (table_type > ACPI_TABLE_ID_MAX) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
         }
 
diff --git a/drivers/acpi/tables/tbgetall.c b/drivers/acpi/tables/tbgetall.c
index b4ec61d7cf06..ad982112e4c6 100644
--- a/drivers/acpi/tables/tbgetall.c
+++ b/drivers/acpi/tables/tbgetall.c
@@ -77,7 +77,7 @@ acpi_tb_get_primary_table(struct acpi_pointer *address,
         acpi_status status;
         struct acpi_table_header header;
 
-        ACPI_FUNCTION_TRACE("tb_get_primary_table");
+        ACPI_FUNCTION_TRACE(tb_get_primary_table);
 
         /* Ignore a NULL address in the RSDT */
 
@@ -140,7 +140,7 @@ acpi_tb_get_secondary_table(struct acpi_pointer *address,
         acpi_status status;
         struct acpi_table_header header;
 
-        ACPI_FUNCTION_TRACE_STR("tb_get_secondary_table", signature);
+        ACPI_FUNCTION_TRACE_STR(tb_get_secondary_table, signature);
 
         /* Get the header in order to match the signature */
 
@@ -151,7 +151,7 @@ acpi_tb_get_secondary_table(struct acpi_pointer *address,
 
         /* Signature must match request */
 
-        if (ACPI_STRNCMP(header.signature, signature, ACPI_NAME_SIZE)) {
+        if (!ACPI_COMPARE_NAME(header.signature, signature)) {
                 ACPI_ERROR((AE_INFO,
                             "Incorrect table signature - wanted [%s] found [%4.4s]",
                             signature, header.signature));
@@ -207,7 +207,7 @@ acpi_status acpi_tb_get_required_tables(void)
         struct acpi_table_desc table_info;
         struct acpi_pointer address;
 
-        ACPI_FUNCTION_TRACE("tb_get_required_tables");
+        ACPI_FUNCTION_TRACE(tb_get_required_tables);
 
         ACPI_DEBUG_PRINT((ACPI_DB_INFO, "%d ACPI tables in RSDT\n",
                           acpi_gbl_rsdt_table_count));
@@ -306,6 +306,6 @@ acpi_status acpi_tb_get_required_tables(void)
 
         /* Always delete the RSDP mapping, we are done with it */
 
-        acpi_tb_delete_tables_by_type(ACPI_TABLE_RSDP);
+        acpi_tb_delete_tables_by_type(ACPI_TABLE_ID_RSDP);
         return_ACPI_STATUS(status);
 }
diff --git a/drivers/acpi/tables/tbinstal.c b/drivers/acpi/tables/tbinstal.c
index ce57a195577a..7ca2df75bb11 100644
--- a/drivers/acpi/tables/tbinstal.c
+++ b/drivers/acpi/tables/tbinstal.c
@@ -73,11 +73,11 @@ acpi_tb_match_signature(char *signature,
 {
         acpi_native_uint i;
 
-        ACPI_FUNCTION_TRACE("tb_match_signature");
+        ACPI_FUNCTION_TRACE(tb_match_signature);
 
         /* Search for a signature match among the known table types */
 
-        for (i = 0; i < NUM_ACPI_TABLE_TYPES; i++) {
+        for (i = 0; i < (ACPI_TABLE_ID_MAX + 1); i++) {
                 if (!(acpi_gbl_table_data[i].flags & search_type)) {
                         continue;
                 }
@@ -123,7 +123,7 @@ acpi_status acpi_tb_install_table(struct acpi_table_desc *table_info)
 {
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("tb_install_table");
+        ACPI_FUNCTION_TRACE(tb_install_table);
 
         /* Lock tables while installing */
 
@@ -188,7 +188,7 @@ acpi_tb_recognize_table(struct acpi_table_desc *table_info, u8 search_type)
         struct acpi_table_header *table_header;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("tb_recognize_table");
+        ACPI_FUNCTION_TRACE(tb_recognize_table);
 
         /* Ensure that we have a valid table pointer */
 
@@ -219,7 +219,6 @@ acpi_tb_recognize_table(struct acpi_table_desc *table_info, u8 search_type)
         /* Return the table type and length via the info struct */
 
         table_info->length = (acpi_size) table_header->length;
-
         return_ACPI_STATUS(status);
 }
 
@@ -244,7 +243,7 @@ acpi_tb_init_table_descriptor(acpi_table_type table_type,
         struct acpi_table_desc *table_desc;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE_U32("tb_init_table_descriptor", table_type);
+        ACPI_FUNCTION_TRACE_U32(tb_init_table_descriptor, table_type);
 
         /* Allocate a descriptor for this table */
 
@@ -313,15 +312,14 @@ acpi_tb_init_table_descriptor(acpi_table_type table_type,
 
         /* Finish initialization of the table descriptor */
 
+        table_desc->loaded_into_namespace = FALSE;
         table_desc->type = (u8) table_type;
         table_desc->pointer = table_info->pointer;
         table_desc->length = table_info->length;
         table_desc->allocation = table_info->allocation;
         table_desc->aml_start = (u8 *) (table_desc->pointer + 1),
-            table_desc->aml_length = (u32) (table_desc->length -
-                                            (u32) sizeof(struct
-                                                         acpi_table_header));
-        table_desc->loaded_into_namespace = FALSE;
+            table_desc->aml_length = (u32)
+            (table_desc->length - (u32) sizeof(struct acpi_table_header));
 
         /*
          * Set the appropriate global pointer (if there is one) to point to the
@@ -336,7 +334,6 @@ acpi_tb_init_table_descriptor(acpi_table_type table_type,
 
         table_info->owner_id = table_desc->owner_id;
         table_info->installed_desc = table_desc;
-
         return_ACPI_STATUS(AE_OK);
 }
 
@@ -360,7 +357,7 @@ void acpi_tb_delete_all_tables(void)
          * Free memory allocated for ACPI tables
          * Memory can either be mapped or allocated
          */
-        for (type = 0; type < NUM_ACPI_TABLE_TYPES; type++) {
+        for (type = 0; type < (ACPI_TABLE_ID_MAX + 1); type++) {
                 acpi_tb_delete_tables_by_type(type);
         }
 }
@@ -384,9 +381,9 @@ void acpi_tb_delete_tables_by_type(acpi_table_type type)
         u32 count;
         u32 i;
 
-        ACPI_FUNCTION_TRACE_U32("tb_delete_tables_by_type", type);
+        ACPI_FUNCTION_TRACE_U32(tb_delete_tables_by_type, type);
 
-        if (type > ACPI_TABLE_MAX) {
+        if (type > ACPI_TABLE_ID_MAX) {
                 return_VOID;
         }
 
@@ -397,28 +394,28 @@ void acpi_tb_delete_tables_by_type(acpi_table_type type)
         /* Clear the appropriate "typed" global table pointer */
 
         switch (type) {
-        case ACPI_TABLE_RSDP:
+        case ACPI_TABLE_ID_RSDP:
                 acpi_gbl_RSDP = NULL;
                 break;
 
-        case ACPI_TABLE_DSDT:
+        case ACPI_TABLE_ID_DSDT:
                 acpi_gbl_DSDT = NULL;
                 break;
 
-        case ACPI_TABLE_FADT:
+        case ACPI_TABLE_ID_FADT:
                 acpi_gbl_FADT = NULL;
                 break;
 
-        case ACPI_TABLE_FACS:
+        case ACPI_TABLE_ID_FACS:
                 acpi_gbl_FACS = NULL;
                 break;
 
-        case ACPI_TABLE_XSDT:
+        case ACPI_TABLE_ID_XSDT:
                 acpi_gbl_XSDT = NULL;
                 break;
 
-        case ACPI_TABLE_SSDT:
-        case ACPI_TABLE_PSDT:
+        case ACPI_TABLE_ID_SSDT:
+        case ACPI_TABLE_ID_PSDT:
         default:
                 break;
         }
@@ -504,7 +501,7 @@ struct acpi_table_desc *acpi_tb_uninstall_table(struct acpi_table_desc
 {
         struct acpi_table_desc *next_desc;
 
-        ACPI_FUNCTION_TRACE_PTR("tb_uninstall_table", table_desc);
+        ACPI_FUNCTION_TRACE_PTR(tb_uninstall_table, table_desc);
 
         if (!table_desc) {
                 return_PTR(NULL);
diff --git a/drivers/acpi/tables/tbrsdt.c b/drivers/acpi/tables/tbrsdt.c
index 9e0ebe625ed9..9e226438a3f6 100644
--- a/drivers/acpi/tables/tbrsdt.c
+++ b/drivers/acpi/tables/tbrsdt.c
@@ -64,7 +64,7 @@ acpi_status acpi_tb_verify_rsdp(struct acpi_pointer *address)
         acpi_status status;
         struct rsdp_descriptor *rsdp;
 
-        ACPI_FUNCTION_TRACE("tb_verify_rsdp");
+        ACPI_FUNCTION_TRACE(tb_verify_rsdp);
 
         switch (address->pointer_type) {
         case ACPI_LOGICAL_POINTER:
@@ -103,7 +103,7 @@ acpi_status acpi_tb_verify_rsdp(struct acpi_pointer *address)
 
         /* Save the table pointers and allocation info */
 
-        status = acpi_tb_init_table_descriptor(ACPI_TABLE_RSDP, &table_info);
+        status = acpi_tb_init_table_descriptor(ACPI_TABLE_ID_RSDP, &table_info);
         if (ACPI_FAILURE(status)) {
                 goto cleanup;
         }
@@ -174,22 +174,19 @@ void acpi_tb_get_rsdt_address(struct acpi_pointer *out_address)
 
 acpi_status acpi_tb_validate_rsdt(struct acpi_table_header *table_ptr)
 {
-        int no_match;
+        char *signature;
 
         ACPI_FUNCTION_ENTRY();
 
-        /*
-         * Search for appropriate signature, RSDT or XSDT
-         */
+        /* Search for appropriate signature, RSDT or XSDT */
+
         if (acpi_gbl_root_table_type == ACPI_TABLE_TYPE_RSDT) {
-                no_match = ACPI_STRNCMP((char *)table_ptr, RSDT_SIG,
-                                        sizeof(RSDT_SIG) - 1);
+                signature = RSDT_SIG;
         } else {
-                no_match = ACPI_STRNCMP((char *)table_ptr, XSDT_SIG,
-                                        sizeof(XSDT_SIG) - 1);
+                signature = XSDT_SIG;
         }
 
-        if (no_match) {
+        if (!ACPI_COMPARE_NAME(table_ptr->signature, signature)) {
 
                 /* Invalid RSDT or XSDT signature */
 
@@ -235,13 +232,13 @@ acpi_status acpi_tb_get_table_rsdt(void)
         acpi_status status;
         struct acpi_pointer address;
 
-        ACPI_FUNCTION_TRACE("tb_get_table_rsdt");
+        ACPI_FUNCTION_TRACE(tb_get_table_rsdt);
 
         /* Get the RSDT/XSDT via the RSDP */
 
         acpi_tb_get_rsdt_address(&address);
 
-        table_info.type = ACPI_TABLE_XSDT;
+        table_info.type = ACPI_TABLE_ID_XSDT;
         status = acpi_tb_get_table(&address, &table_info);
         if (ACPI_FAILURE(status)) {
                 ACPI_EXCEPTION((AE_INFO, status,
@@ -275,7 +272,7 @@ acpi_status acpi_tb_get_table_rsdt(void)
 
         /* Save the table pointers and allocation info */
 
-        status = acpi_tb_init_table_descriptor(ACPI_TABLE_XSDT, &table_info);
+        status = acpi_tb_init_table_descriptor(ACPI_TABLE_ID_XSDT, &table_info);
         if (ACPI_FAILURE(status)) {
                 return_ACPI_STATUS(status);
         }
diff --git a/drivers/acpi/tables/tbutils.c b/drivers/acpi/tables/tbutils.c
index f8d28ae8811d..5f1440376514 100644
--- a/drivers/acpi/tables/tbutils.c
+++ b/drivers/acpi/tables/tbutils.c
@@ -71,7 +71,7 @@ acpi_status acpi_tb_is_table_installed(struct acpi_table_desc *new_table_desc)
 {
         struct acpi_table_desc *table_desc;
 
-        ACPI_FUNCTION_TRACE("tb_is_table_installed");
+        ACPI_FUNCTION_TRACE(tb_is_table_installed);
 
         /* Get the list descriptor and first table descriptor */
 
@@ -100,7 +100,7 @@ acpi_status acpi_tb_is_table_installed(struct acpi_table_desc *new_table_desc)
                         /* Match: this table is already installed */
 
                         ACPI_DEBUG_PRINT((ACPI_DB_TABLES,
-                                          "Table [%4.4s] already installed: Rev %X oem_table_id [%8.8s]\n",
+                                          "Table [%4.4s] already installed: Rev %X OemTableId [%8.8s]\n",
                                           new_table_desc->pointer->signature,
                                           new_table_desc->pointer->revision,
                                           new_table_desc->pointer->
@@ -288,7 +288,7 @@ acpi_tb_verify_table_checksum(struct acpi_table_header *table_header)
 {
         u8 checksum;
 
-        ACPI_FUNCTION_TRACE("tb_verify_table_checksum");
+        ACPI_FUNCTION_TRACE(tb_verify_table_checksum);
 
         /* Compute the checksum on the table */
 
@@ -329,7 +329,7 @@ acpi_tb_handle_to_object(u16 table_id,
         u32 i;
         struct acpi_table_desc *table_desc;
 
-        ACPI_FUNCTION_NAME("tb_handle_to_object");
+        ACPI_FUNCTION_NAME(tb_handle_to_object);
 
         for (i = 0; i < ACPI_TABLE_MAX; i++) {
                 table_desc = acpi_gbl_table_lists[i].next;
@@ -343,7 +343,7 @@ acpi_tb_handle_to_object(u16 table_id,
                 }
         }
 
-        ACPI_ERROR((AE_INFO, "table_id=%X does not exist", table_id));
+        ACPI_ERROR((AE_INFO, "TableId=%X does not exist", table_id));
         return (AE_BAD_PARAMETER);
 }
 #endif
diff --git a/drivers/acpi/tables/tbxface.c b/drivers/acpi/tables/tbxface.c
index 53c627e401bf..4e91f2984815 100644
--- a/drivers/acpi/tables/tbxface.c
+++ b/drivers/acpi/tables/tbxface.c
@@ -66,7 +66,7 @@ acpi_status acpi_load_tables(void)
         struct acpi_pointer rsdp_address;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("acpi_load_tables");
+        ACPI_FUNCTION_TRACE(acpi_load_tables);
 
         /* Get the RSDP */
 
@@ -145,7 +145,7 @@ acpi_status acpi_load_table(struct acpi_table_header *table_ptr)
         struct acpi_table_desc table_info;
         struct acpi_pointer address;
 
-        ACPI_FUNCTION_TRACE("acpi_load_table");
+        ACPI_FUNCTION_TRACE(acpi_load_table);
 
         if (!table_ptr) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
@@ -188,12 +188,12 @@ acpi_status acpi_load_table(struct acpi_table_header *table_ptr)
         /* Convert the table to common format if necessary */
 
         switch (table_info.type) {
-        case ACPI_TABLE_FADT:
+        case ACPI_TABLE_ID_FADT:
 
                 status = acpi_tb_convert_table_fadt();
                 break;
 
-        case ACPI_TABLE_FACS:
+        case ACPI_TABLE_ID_FACS:
 
                 status = acpi_tb_build_common_facs(&table_info);
                 break;
@@ -234,11 +234,11 @@ acpi_status acpi_unload_table(acpi_table_type table_type)
 {
         struct acpi_table_desc *table_desc;
 
-        ACPI_FUNCTION_TRACE("acpi_unload_table");
+        ACPI_FUNCTION_TRACE(acpi_unload_table);
 
         /* Parameter validation */
 
-        if (table_type > ACPI_TABLE_MAX) {
+        if (table_type > ACPI_TABLE_ID_MAX) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
         }
 
@@ -292,16 +292,16 @@ acpi_get_table_header(acpi_table_type table_type,
         struct acpi_table_header *tbl_ptr;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("acpi_get_table_header");
+        ACPI_FUNCTION_TRACE(acpi_get_table_header);
 
         if ((instance == 0) ||
-            (table_type == ACPI_TABLE_RSDP) || (!out_table_header)) {
+            (table_type == ACPI_TABLE_ID_RSDP) || (!out_table_header)) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
         }
 
         /* Check the table type and instance */
 
-        if ((table_type > ACPI_TABLE_MAX) ||
+        if ((table_type > ACPI_TABLE_ID_MAX) ||
             (ACPI_IS_SINGLE_TABLE(acpi_gbl_table_data[table_type].flags) &&
              instance > 1)) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
@@ -361,7 +361,7 @@ acpi_get_table(acpi_table_type table_type,
         acpi_status status;
         acpi_size table_length;
 
-        ACPI_FUNCTION_TRACE("acpi_get_table");
+        ACPI_FUNCTION_TRACE(acpi_get_table);
 
         /* Parameter validation */
 
@@ -376,7 +376,7 @@ acpi_get_table(acpi_table_type table_type,
 
         /* Check the table type and instance */
 
-        if ((table_type > ACPI_TABLE_MAX) ||
+        if ((table_type > ACPI_TABLE_ID_MAX) ||
             (ACPI_IS_SINGLE_TABLE(acpi_gbl_table_data[table_type].flags) &&
              instance > 1)) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
@@ -399,7 +399,7 @@ acpi_get_table(acpi_table_type table_type,
 
         /* Get the table length */
 
-        if (table_type == ACPI_TABLE_RSDP) {
+        if (table_type == ACPI_TABLE_ID_RSDP) {
 
                 /* RSD PTR is the only "table" without a header */
 
diff --git a/drivers/acpi/tables/tbxfroot.c b/drivers/acpi/tables/tbxfroot.c
index 550284f5d1ed..3107e741d510 100644
--- a/drivers/acpi/tables/tbxfroot.c
+++ b/drivers/acpi/tables/tbxfroot.c
@@ -119,7 +119,7 @@ acpi_tb_find_table(char *signature,
         acpi_status status;
         struct acpi_table_header *table;
 
-        ACPI_FUNCTION_TRACE("tb_find_table");
+        ACPI_FUNCTION_TRACE(tb_find_table);
 
         /* Validate string lengths */
 
@@ -129,7 +129,7 @@ acpi_tb_find_table(char *signature,
                 return_ACPI_STATUS(AE_AML_STRING_LIMIT);
         }
 
-        if (!ACPI_STRNCMP(signature, DSDT_SIG, ACPI_NAME_SIZE)) {
+        if (ACPI_COMPARE_NAME(signature, DSDT_SIG)) {
                 /*
                  * The DSDT pointer is contained in the FADT, not the RSDT.
                  * This code should suffice, because the only code that would perform
@@ -154,10 +154,12 @@ acpi_tb_find_table(char *signature,
 
         /* Check oem_id and oem_table_id */
 
-        if ((oem_id[0] && ACPI_STRNCMP(oem_id, table->oem_id,
-                                       sizeof(table->oem_id))) ||
-            (oem_table_id[0] && ACPI_STRNCMP(oem_table_id, table->oem_table_id,
-                                             sizeof(table->oem_table_id)))) {
+        if ((oem_id[0] &&
+             ACPI_STRNCMP(oem_id, table->oem_id,
+                          sizeof(table->oem_id))) ||
+            (oem_table_id[0] &&
+             ACPI_STRNCMP(oem_table_id, table->oem_table_id,
+                          sizeof(table->oem_table_id)))) {
                 return_ACPI_STATUS(AE_AML_NAME_NOT_FOUND);
         }
 
@@ -201,7 +203,7 @@ acpi_get_firmware_table(acpi_string signature,
         u32 i;
         u32 j;
 
-        ACPI_FUNCTION_TRACE("acpi_get_firmware_table");
+        ACPI_FUNCTION_TRACE(acpi_get_firmware_table);
 
         /*
          * Ensure that at least the table manager is initialized.  We don't
@@ -325,7 +327,7 @@ acpi_get_firmware_table(acpi_string signature,
 
                 /* Compare table signatures and table instance */
 
-                if (!ACPI_STRNCMP(header->signature, signature, ACPI_NAME_SIZE)) {
+                if (ACPI_COMPARE_NAME(header->signature, signature)) {
 
                         /* An instance of the table was found */
 
@@ -388,7 +390,7 @@ acpi_status acpi_find_root_pointer(u32 flags, struct acpi_pointer *rsdp_address)
         struct acpi_table_desc table_info;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("acpi_find_root_pointer");
+        ACPI_FUNCTION_TRACE(acpi_find_root_pointer);
 
         /* Get the RSDP */
 
@@ -425,7 +427,7 @@ static u8 *acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length)
         u8 *mem_rover;
         u8 *end_address;
 
-        ACPI_FUNCTION_TRACE("tb_scan_memory_for_rsdp");
+        ACPI_FUNCTION_TRACE(tb_scan_memory_for_rsdp);
 
         end_address = start_address + length;
 
@@ -490,7 +492,7 @@ acpi_tb_find_rsdp(struct acpi_table_desc *table_info, u32 flags)
         u32 physical_address;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("tb_find_rsdp");
+        ACPI_FUNCTION_TRACE(tb_find_rsdp);
 
         /*
          * Scan supports either logical addressing or physical addressing