1 files changed, 16 insertions, 19 deletions

diff --git a/drivers/acpi/parser/psparse.c b/drivers/acpi/parser/psparse.c
index a9f3229f4106..7ee2f2e77525 100644
--- a/drivers/acpi/parser/psparse.c
+++ b/drivers/acpi/parser/psparse.c
@@ -106,6 +106,7 @@ u16 acpi_ps_peek_opcode(struct acpi_parse_state * parser_state)
         opcode = (u16) ACPI_GET8(aml);
 
         if (opcode == AML_EXTENDED_OP_PREFIX) {
+
                 /* Extended opcode, get the second opcode byte */
 
                 aml++;
@@ -137,7 +138,7 @@ acpi_ps_complete_this_op(struct acpi_walk_state * walk_state,
         const struct acpi_opcode_info *parent_info;
         union acpi_parse_object *replacement_op = NULL;
 
-        ACPI_FUNCTION_TRACE_PTR("ps_complete_this_op", op);
+        ACPI_FUNCTION_TRACE_PTR(ps_complete_this_op, op);
 
         /* Check for null Op, can happen if AML code is corrupt */
 
@@ -158,6 +159,7 @@ acpi_ps_complete_this_op(struct acpi_walk_state * walk_state,
         if (op->common.parent) {
                 prev = op->common.parent->common.value.arg;
                 if (!prev) {
+
                         /* Nothing more to do */
 
                         goto cleanup;
@@ -245,6 +247,7 @@ acpi_ps_complete_this_op(struct acpi_walk_state * walk_state,
                 /* We must unlink this op from the parent tree */
 
                 if (prev == op) {
+
                         /* This op is the first in the list */
 
                         if (replacement_op) {
@@ -265,6 +268,7 @@ acpi_ps_complete_this_op(struct acpi_walk_state * walk_state,
 
                 else
                         while (prev) {
+
                                 /* Traverse all siblings in the parent's argument list */
 
                                 next = prev->common.next;
@@ -329,7 +333,7 @@ acpi_ps_next_parse_state(struct acpi_walk_state *walk_state,
         struct acpi_parse_state *parser_state = &walk_state->parser_state;
         acpi_status status = AE_CTRL_PENDING;
 
-        ACPI_FUNCTION_TRACE_PTR("ps_next_parse_state", op);
+        ACPI_FUNCTION_TRACE_PTR(ps_next_parse_state, op);
 
         switch (callback_status) {
         case AE_CTRL_TERMINATE:
@@ -449,10 +453,10 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
         struct acpi_thread_state *prev_walk_list = acpi_gbl_current_walk_list;
         struct acpi_walk_state *previous_walk_state;
 
-        ACPI_FUNCTION_TRACE("ps_parse_aml");
+        ACPI_FUNCTION_TRACE(ps_parse_aml);
 
         ACPI_DEBUG_PRINT((ACPI_DB_PARSE,
-                          "Entered with walk_state=%p Aml=%p size=%X\n",
+                          "Entered with WalkState=%p Aml=%p size=%X\n",
                           walk_state, walk_state->parser_state.aml,
                           walk_state->parser_state.aml_size));
 
@@ -460,6 +464,7 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
 
         thread = acpi_ut_create_thread_state();
         if (!thread) {
+                acpi_ds_delete_walk_state(walk_state);
                 return_ACPI_STATUS(AE_NO_MEMORY);
         }
 
@@ -510,6 +515,7 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
                 } else if (status == AE_CTRL_TERMINATE) {
                         status = AE_OK;
                 } else if ((status != AE_OK) && (walk_state->method_desc)) {
+
                         /* Either the method parse or actual execution failed */
 
                         ACPI_ERROR_METHOD("Method parse/execution failed",
@@ -550,20 +556,9 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
                  */
                 if (((walk_state->parse_flags & ACPI_PARSE_MODE_MASK) ==
                      ACPI_PARSE_EXECUTE) || (ACPI_FAILURE(status))) {
-                        if (walk_state->method_desc) {
-                                /* Decrement the thread count on the method parse tree */
-
-                                if (walk_state->method_desc->method.
-                                    thread_count) {
-                                        walk_state->method_desc->method.
-                                            thread_count--;
-                                } else {
-                                        ACPI_ERROR((AE_INFO,
-                                                    "Invalid zero thread count in method"));
-                                }
-                        }
-
-                        acpi_ds_terminate_control_method(walk_state);
+                        acpi_ds_terminate_control_method(walk_state->
+                                                         method_desc,
+                                                         walk_state);
                 }
 
                 /* Delete this walk state and all linked control states */
@@ -572,7 +567,7 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
                 previous_walk_state = walk_state;
 
                 ACPI_DEBUG_PRINT((ACPI_DB_PARSE,
-                                  "return_value=%p, implicit_value=%p State=%p\n",
+                                  "ReturnValue=%p, ImplicitValue=%p State=%p\n",
                                   walk_state->return_desc,
                                   walk_state->implicit_return_obj, walk_state));
 
@@ -633,12 +628,14 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
                         }
                 } else {
                         if (previous_walk_state->return_desc) {
+
                                 /* Caller doesn't want it, must delete it */
 
                                 acpi_ut_remove_reference(previous_walk_state->
                                                          return_desc);
                         }
                         if (previous_walk_state->implicit_return_obj) {
+
                                 /* Caller doesn't want it, must delete it */
 
                                 acpi_ut_remove_reference(previous_walk_state->