1 files changed, 31 insertions, 26 deletions

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 30f3ef236ecb..8dfcbb8aff73 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -42,7 +42,6 @@
 #include <asm/io.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
-#include <acpi/actypes.h>
 
 #define ACPI_EC_CLASS                   "embedded_controller"
 #define ACPI_EC_DEVICE_NAME             "Embedded Controller"
@@ -370,7 +369,7 @@ unlock:
  * Note: samsung nv5000 doesn't work with ec burst mode.
  * http://bugzilla.kernel.org/show_bug.cgi?id=4980
  */
-int acpi_ec_burst_enable(struct acpi_ec *ec)
+static int acpi_ec_burst_enable(struct acpi_ec *ec)
 {
         u8 d;
         struct transaction t = {.command = ACPI_EC_BURST_ENABLE,
@@ -380,7 +379,7 @@ int acpi_ec_burst_enable(struct acpi_ec *ec)
         return acpi_ec_transaction(ec, &t, 0);
 }
 
-int acpi_ec_burst_disable(struct acpi_ec *ec)
+static int acpi_ec_burst_disable(struct acpi_ec *ec)
 {
         struct transaction t = {.command = ACPI_EC_BURST_DISABLE,
                                 .wdata = NULL, .rdata = NULL,
@@ -756,10 +755,15 @@ static acpi_status
 acpi_ec_register_query_methods(acpi_handle handle, u32 level,
                                void *context, void **return_value)
 {
-        struct acpi_namespace_node *node = handle;
+        char node_name[5];
+        struct acpi_buffer buffer = { sizeof(node_name), node_name };
         struct acpi_ec *ec = context;
         int value = 0;
-        if (sscanf(node->name.ascii, "_Q%x", &value) == 1) {
+        acpi_status status;
+
+        status = acpi_get_name(handle, ACPI_SINGLE_NAME, &buffer);
+
+        if (ACPI_SUCCESS(status) && sscanf(node_name, "_Q%x", &value) == 1) {
                 acpi_ec_add_query_handler(ec, value, handle, NULL, NULL);
         }
         return AE_OK;
@@ -978,9 +982,9 @@ static const struct acpi_device_id ec_device_ids[] = {
 
 int __init acpi_ec_ecdt_probe(void)
 {
-        int ret;
         acpi_status status;
         struct acpi_table_ecdt *ecdt_ptr;
+        acpi_handle dummy;
 
         boot_ec = make_acpi_ec();
         if (!boot_ec)
@@ -1006,30 +1010,31 @@ int __init acpi_ec_ecdt_probe(void)
                 boot_ec->gpe = ecdt_ptr->gpe;
                 boot_ec->handle = ACPI_ROOT_OBJECT;
                 acpi_get_handle(ACPI_ROOT_OBJECT, ecdt_ptr->id, &boot_ec->handle);
-        } else {
-                /* This workaround is needed only on some broken machines,
-                 * which require early EC, but fail to provide ECDT */
-                acpi_handle x;
-                printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
-                status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
-                                                boot_ec, NULL);
-                /* Check that acpi_get_devices actually find something */
-                if (ACPI_FAILURE(status) || !boot_ec->handle)
-                        goto error;
-                /* We really need to limit this workaround, the only ASUS,
-                 * which needs it, has fake EC._INI method, so use it as flag.
-                 * Keep boot_ec struct as it will be needed soon.
-                 */
-                if (ACPI_FAILURE(acpi_get_handle(boot_ec->handle, "_INI", &x)))
-                        return -ENODEV;
+                /* Add some basic check against completely broken table */
+                if (boot_ec->data_addr != boot_ec->command_addr)
+                        goto install;
+        /* fall through */
         }
-
-        ret = ec_install_handlers(boot_ec);
-        if (!ret) {
+        /* This workaround is needed only on some broken machines,
+         * which require early EC, but fail to provide ECDT */
+        printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
+        status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
+                                        boot_ec, NULL);
+        /* Check that acpi_get_devices actually find something */
+        if (ACPI_FAILURE(status) || !boot_ec->handle)
+                goto error;
+        /* We really need to limit this workaround, the only ASUS,
+         * which needs it, has fake EC._INI method, so use it as flag.
+         * Keep boot_ec struct as it will be needed soon.
+         */
+        if (ACPI_FAILURE(acpi_get_handle(boot_ec->handle, "_INI", &dummy)))
+                return -ENODEV;
+install:
+        if (!ec_install_handlers(boot_ec)) {
                 first_ec = boot_ec;
                 return 0;
         }
-      error:
+error:
         kfree(boot_ec);
         boot_ec = NULL;
         return -ENODEV;