3 files changed, 21 insertions, 6 deletions

diff --git a/drivers/acpi/dispatcher/dsmethod.c b/drivers/acpi/dispatcher/dsmethod.c
index e348db0e541e..21f059986273 100644
--- a/drivers/acpi/dispatcher/dsmethod.c
+++ b/drivers/acpi/dispatcher/dsmethod.c
@@ -231,7 +231,7 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
         struct acpi_namespace_node *method_node;
         struct acpi_walk_state *next_walk_state = NULL;
         union acpi_operand_object *obj_desc;
-        struct acpi_parameter_info info;
+        struct acpi_evaluate_info *info;
         u32 i;
 
         ACPI_FUNCTION_TRACE_PTR(ds_call_control_method, this_walk_state);
@@ -319,12 +319,24 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
          */
         this_walk_state->operands[this_walk_state->num_operands] = NULL;
 
-        info.parameters = &this_walk_state->operands[0];
-        info.parameter_type = ACPI_PARAM_ARGS;
+        /*
+         * Allocate and initialize the evaluation information block
+         * TBD: this is somewhat inefficient, should change interface to
+         * ds_init_aml_walk. For now, keeps this struct off the CPU stack
+         */
+        info = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_evaluate_info));
+        if (!info) {
+                return_ACPI_STATUS(AE_NO_MEMORY);
+        }
+
+        info->parameters = &this_walk_state->operands[0];
+        info->parameter_type = ACPI_PARAM_ARGS;
 
         status = acpi_ds_init_aml_walk(next_walk_state, NULL, method_node,
                                        obj_desc->method.aml_start,
-                                       obj_desc->method.aml_length, &info, 3);
+                                       obj_desc->method.aml_length, info, 3);
+
+        ACPI_FREE(info);
         if (ACPI_FAILURE(status)) {
                 goto cleanup;
         }
diff --git a/drivers/acpi/dispatcher/dswexec.c b/drivers/acpi/dispatcher/dswexec.c
index 8afb20384e96..3acbd9145d72 100644
--- a/drivers/acpi/dispatcher/dswexec.c
+++ b/drivers/acpi/dispatcher/dswexec.c
@@ -295,7 +295,7 @@ acpi_ds_exec_begin_op(struct acpi_walk_state *walk_state,
 
         case AML_CLASS_NAMED_OBJECT:
 
-                if (walk_state->walk_type == ACPI_WALK_METHOD) {
+                if (walk_state->walk_type & ACPI_WALK_METHOD) {
                         /*
                          * Found a named object declaration during method execution;
                          * we must enter this object into the namespace.  The created
diff --git a/drivers/acpi/dispatcher/dswstate.c b/drivers/acpi/dispatcher/dswstate.c
index 82c1e219bf15..7817e5522679 100644
--- a/drivers/acpi/dispatcher/dswstate.c
+++ b/drivers/acpi/dispatcher/dswstate.c
@@ -703,7 +703,7 @@ acpi_ds_init_aml_walk(struct acpi_walk_state *walk_state,
                       struct acpi_namespace_node *method_node,
                       u8 * aml_start,
                       u32 aml_length,
-                      struct acpi_parameter_info *info, u8 pass_number)
+                      struct acpi_evaluate_info *info, u8 pass_number)
 {
         acpi_status status;
         struct acpi_parse_state *parser_state = &walk_state->parser_state;
@@ -825,9 +825,12 @@ void acpi_ds_delete_walk_state(struct acpi_walk_state *walk_state)
                 return;
         }
 
+        /* There should not be any open scopes */
+
         if (walk_state->parser_state.scope) {
                 ACPI_ERROR((AE_INFO, "%p walk still has a scope list",
                             walk_state));
+                acpi_ps_cleanup_scope(&walk_state->parser_state);
         }
 
         /* Always must free any linked control states */