11 files changed, 361 insertions, 221 deletions

diff --git a/drivers/acpi/dispatcher/dsfield.c b/drivers/acpi/dispatcher/dsfield.c
index 76bc0463f6de..a6d77efb41a0 100644
--- a/drivers/acpi/dispatcher/dsfield.c
+++ b/drivers/acpi/dispatcher/dsfield.c
@@ -87,7 +87,7 @@ acpi_ds_create_buffer_field(union acpi_parse_object *op,
         union acpi_operand_object *second_desc = NULL;
         u32 flags;
 
-        ACPI_FUNCTION_TRACE("ds_create_buffer_field");
+        ACPI_FUNCTION_TRACE(ds_create_buffer_field);
 
         /* Get the name_string argument */
 
@@ -210,7 +210,7 @@ acpi_ds_get_field_names(struct acpi_create_field_info *info,
         acpi_status status;
         acpi_integer position;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_get_field_names", info);
+        ACPI_FUNCTION_TRACE_PTR(ds_get_field_names, info);
 
         /* First field starts at bit zero */
 
@@ -342,7 +342,7 @@ acpi_ds_create_field(union acpi_parse_object *op,
         union acpi_parse_object *arg;
         struct acpi_create_field_info info;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_create_field", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_create_field, op);
 
         /* First arg is the name of the parent op_region (must already exist) */
 
@@ -399,7 +399,7 @@ acpi_ds_init_field_objects(union acpi_parse_object *op,
         struct acpi_namespace_node *node;
         u8 type = 0;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_init_field_objects", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_init_field_objects, op);
 
         switch (walk_state->opcode) {
         case AML_FIELD_OP:
@@ -425,6 +425,7 @@ acpi_ds_init_field_objects(union acpi_parse_object *op,
          * Walk the list of entries in the field_list
          */
         while (arg) {
+
                 /* Ignore OFFSET and ACCESSAS terms here */
 
                 if (arg->common.aml_opcode == AML_INT_NAMEDFIELD_OP) {
@@ -481,7 +482,7 @@ acpi_ds_create_bank_field(union acpi_parse_object *op,
         union acpi_parse_object *arg;
         struct acpi_create_field_info info;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_create_bank_field", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_create_bank_field, op);
 
         /* First arg is the name of the parent op_region (must already exist) */
 
@@ -554,7 +555,7 @@ acpi_ds_create_index_field(union acpi_parse_object *op,
         union acpi_parse_object *arg;
         struct acpi_create_field_info info;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_create_index_field", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_create_index_field, op);
 
         /* First arg is the name of the Index register (must already exist) */
 
diff --git a/drivers/acpi/dispatcher/dsinit.c b/drivers/acpi/dispatcher/dsinit.c
index e65a07ad2422..bbdf990e9f65 100644
--- a/drivers/acpi/dispatcher/dsinit.c
+++ b/drivers/acpi/dispatcher/dsinit.c
@@ -184,7 +184,7 @@ acpi_ds_init_one_object(acpi_handle obj_handle,
  *
  * RETURN:      Status
  *
- * DESCRIPTION: Walk the namespace starting at "start_node" and perform any
+ * DESCRIPTION: Walk the namespace starting at "StartNode" and perform any
  *              necessary initialization on the objects found therein
  *
  ******************************************************************************/
@@ -196,7 +196,7 @@ acpi_ds_initialize_objects(struct acpi_table_desc * table_desc,
         acpi_status status;
         struct acpi_init_walk_info info;
 
-        ACPI_FUNCTION_TRACE("ds_initialize_objects");
+        ACPI_FUNCTION_TRACE(ds_initialize_objects);
 
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
                           "**** Starting initialization of namespace objects ****\n"));
@@ -213,7 +213,7 @@ acpi_ds_initialize_objects(struct acpi_table_desc * table_desc,
         status = acpi_walk_namespace(ACPI_TYPE_ANY, start_node, ACPI_UINT32_MAX,
                                      acpi_ds_init_one_object, &info, NULL);
         if (ACPI_FAILURE(status)) {
-                ACPI_EXCEPTION((AE_INFO, status, "During walk_namespace"));
+                ACPI_EXCEPTION((AE_INFO, status, "During WalkNamespace"));
         }
 
         ACPI_DEBUG_PRINT_RAW((ACPI_DB_INIT,
diff --git a/drivers/acpi/dispatcher/dsmethod.c b/drivers/acpi/dispatcher/dsmethod.c
index c475546535b6..bc9aca4e7401 100644
--- a/drivers/acpi/dispatcher/dsmethod.c
+++ b/drivers/acpi/dispatcher/dsmethod.c
@@ -81,6 +81,7 @@ acpi_ds_method_error(acpi_status status, struct acpi_walk_state *walk_state)
         /* Invoke the global exception handler */
 
         if (acpi_gbl_exception_handler) {
+
                 /* Exit the interpreter, allow handler to execute methods */
 
                 acpi_ex_exit_interpreter();
@@ -100,6 +101,7 @@ acpi_ds_method_error(acpi_status status, struct acpi_walk_state *walk_state)
         }
 #ifdef ACPI_DISASSEMBLER
         if (ACPI_FAILURE(status)) {
+
                 /* Display method locals/args if disassembler is present */
 
                 acpi_dm_dump_method_info(status, walk_state, walk_state->op);
@@ -132,7 +134,7 @@ acpi_ds_begin_method_execution(struct acpi_namespace_node * method_node,
 {
         acpi_status status = AE_OK;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_begin_method_execution", method_node);
+        ACPI_FUNCTION_TRACE_PTR(ds_begin_method_execution, method_node);
 
         if (!method_node) {
                 return_ACPI_STATUS(AE_NULL_ENTRY);
@@ -168,11 +170,14 @@ acpi_ds_begin_method_execution(struct acpi_namespace_node * method_node,
 
                 /*
                  * Get a unit from the method semaphore. This releases the
-                 * interpreter if we block
+                 * interpreter if we block (then reacquires it)
                  */
                 status =
                     acpi_ex_system_wait_semaphore(obj_desc->method.semaphore,
                                                   ACPI_WAIT_FOREVER);
+                if (ACPI_FAILURE(status)) {
+                        return_ACPI_STATUS(status);
+                }
         }
 
         /*
@@ -183,7 +188,7 @@ acpi_ds_begin_method_execution(struct acpi_namespace_node * method_node,
         if (!obj_desc->method.owner_id) {
                 status = acpi_ut_allocate_owner_id(&obj_desc->method.owner_id);
                 if (ACPI_FAILURE(status)) {
-                        return_ACPI_STATUS(status);
+                        goto cleanup;
                 }
         }
 
@@ -193,6 +198,14 @@ acpi_ds_begin_method_execution(struct acpi_namespace_node * method_node,
          */
         obj_desc->method.thread_count++;
         return_ACPI_STATUS(status);
+
+      cleanup:
+        /* On error, must signal the method semaphore if present */
+
+        if (obj_desc->method.semaphore) {
+                (void)acpi_os_signal_semaphore(obj_desc->method.semaphore, 1);
+        }
+        return_ACPI_STATUS(status);
 }
 
 /*******************************************************************************
@@ -218,10 +231,10 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
         struct acpi_namespace_node *method_node;
         struct acpi_walk_state *next_walk_state = NULL;
         union acpi_operand_object *obj_desc;
-        struct acpi_parameter_info info;
+        struct acpi_evaluate_info *info;
         u32 i;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_call_control_method", this_walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_call_control_method, this_walk_state);
 
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
                           "Execute method %p, currentstate=%p\n",
@@ -240,25 +253,31 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
                 return_ACPI_STATUS(AE_NULL_OBJECT);
         }
 
-        /* Init for new method, wait on concurrency semaphore */
+        /* Init for new method, possibly wait on concurrency semaphore */
 
         status = acpi_ds_begin_method_execution(method_node, obj_desc,
                                                 this_walk_state->method_node);
         if (ACPI_FAILURE(status)) {
-                goto cleanup;
+                return_ACPI_STATUS(status);
         }
 
+        /*
+         * 1) Parse the method. All "normal" methods are parsed for each execution.
+         * Internal methods (_OSI, etc.) do not require parsing.
+         */
         if (!(obj_desc->method.method_flags & AML_METHOD_INTERNAL_ONLY)) {
-                /* 1) Parse: Create a new walk state for the preempting walk */
+
+                /* Create a new walk state for the parse */
 
                 next_walk_state =
                     acpi_ds_create_walk_state(obj_desc->method.owner_id, op,
                                               obj_desc, NULL);
                 if (!next_walk_state) {
-                        return_ACPI_STATUS(AE_NO_MEMORY);
+                        status = AE_NO_MEMORY;
+                        goto cleanup;
                 }
 
-                /* Create and init a Root Node */
+                /* Create and init a parse tree root */
 
                 op = acpi_ps_create_scope_op();
                 if (!op) {
@@ -271,17 +290,20 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
                                                obj_desc->method.aml_length,
                                                NULL, 1);
                 if (ACPI_FAILURE(status)) {
-                        acpi_ds_delete_walk_state(next_walk_state);
+                        acpi_ps_delete_parse_tree(op);
                         goto cleanup;
                 }
 
-                /* Begin AML parse */
+                /* Begin AML parse (deletes next_walk_state) */
 
                 status = acpi_ps_parse_aml(next_walk_state);
                 acpi_ps_delete_parse_tree(op);
+                if (ACPI_FAILURE(status)) {
+                        goto cleanup;
+                }
         }
 
-        /* 2) Execute: Create a new state for the preempting walk */
+        /* 2) Begin method execution. Create a new walk state */
 
         next_walk_state = acpi_ds_create_walk_state(obj_desc->method.owner_id,
                                                     NULL, obj_desc, thread);
@@ -289,6 +311,7 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
                 status = AE_NO_MEMORY;
                 goto cleanup;
         }
+
         /*
          * The resolved arguments were put on the previous walk state's operand
          * stack. Operands on the previous walk state stack always
@@ -296,12 +319,24 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
          */
         this_walk_state->operands[this_walk_state->num_operands] = NULL;
 
-        info.parameters = &this_walk_state->operands[0];
-        info.parameter_type = ACPI_PARAM_ARGS;
+        /*
+         * Allocate and initialize the evaluation information block
+         * TBD: this is somewhat inefficient, should change interface to
+         * ds_init_aml_walk. For now, keeps this struct off the CPU stack
+         */
+        info = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_evaluate_info));
+        if (!info) {
+                return_ACPI_STATUS(AE_NO_MEMORY);
+        }
+
+        info->parameters = &this_walk_state->operands[0];
+        info->parameter_type = ACPI_PARAM_ARGS;
 
         status = acpi_ds_init_aml_walk(next_walk_state, NULL, method_node,
                                        obj_desc->method.aml_start,
-                                       obj_desc->method.aml_length, &info, 3);
+                                       obj_desc->method.aml_length, info, 3);
+
+        ACPI_FREE(info);
         if (ACPI_FAILURE(status)) {
                 goto cleanup;
         }
@@ -323,6 +358,8 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
                           "Starting nested execution, newstate=%p\n",
                           next_walk_state));
 
+        /* Invoke an internal method if necessary */
+
         if (obj_desc->method.method_flags & AML_METHOD_INTERNAL_ONLY) {
                 status = obj_desc->method.implementation(next_walk_state);
         }
@@ -330,16 +367,14 @@ acpi_ds_call_control_method(struct acpi_thread_state *thread,
         return_ACPI_STATUS(status);
 
       cleanup:
-        /* Decrement the thread count on the method parse tree */
 
-        if (next_walk_state && (next_walk_state->method_desc)) {
-                next_walk_state->method_desc->method.thread_count--;
-        }
+        /* On error, we must terminate the method properly */
 
-        /* On error, we must delete the new walk state */
+        acpi_ds_terminate_control_method(obj_desc, next_walk_state);
+        if (next_walk_state) {
+                acpi_ds_delete_walk_state(next_walk_state);
+        }
 
-        acpi_ds_terminate_control_method(next_walk_state);
-        acpi_ds_delete_walk_state(next_walk_state);
         return_ACPI_STATUS(status);
 }
 
@@ -362,25 +397,33 @@ acpi_ds_restart_control_method(struct acpi_walk_state *walk_state,
                                union acpi_operand_object *return_desc)
 {
         acpi_status status;
+        int same_as_implicit_return;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_restart_control_method", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_restart_control_method, walk_state);
 
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
-                          "****Restart [%4.4s] Op %p return_value_from_callee %p\n",
+                          "****Restart [%4.4s] Op %p ReturnValueFromCallee %p\n",
                           (char *)&walk_state->method_node->name,
                           walk_state->method_call_op, return_desc));
 
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
-                          "    return_from_this_method_used?=%X res_stack %p Walk %p\n",
+                          "    ReturnFromThisMethodUsed?=%X ResStack %p Walk %p\n",
                           walk_state->return_used,
                           walk_state->results, walk_state));
 
         /* Did the called method return a value? */
 
         if (return_desc) {
+
+                /* Is the implicit return object the same as the return desc? */
+
+                same_as_implicit_return =
+                    (walk_state->implicit_return_obj == return_desc);
+
                 /* Are we actually going to use the return value? */
 
                 if (walk_state->return_used) {
+
                         /* Save the return value from the previous method */
 
                         status = acpi_ds_result_push(return_desc, walk_state);
@@ -397,18 +440,23 @@ acpi_ds_restart_control_method(struct acpi_walk_state *walk_state,
                 }
 
                 /*
-                 * The following code is the
-                 * optional support for a so-called "implicit return". Some AML code
-                 * assumes that the last value of the method is "implicitly" returned
-                 * to the caller. Just save the last result as the return value.
+                 * The following code is the optional support for the so-called
+                 * "implicit return". Some AML code assumes that the last value of the
+                 * method is "implicitly" returned to the caller, in the absence of an
+                 * explicit return value.
+                 *
+                 * Just save the last result of the method as the return value.
+                 *
                  * NOTE: this is optional because the ASL language does not actually
                  * support this behavior.
                  */
                 else if (!acpi_ds_do_implicit_return
-                         (return_desc, walk_state, FALSE)) {
+                         (return_desc, walk_state, FALSE)
+                         || same_as_implicit_return) {
                         /*
                          * Delete the return value if it will not be used by the
-                         * calling method
+                         * calling method or remove one reference if the explicit return
+                         * is the same as the implicit return value.
                          */
                         acpi_ut_remove_reference(return_desc);
                 }
@@ -421,7 +469,8 @@ acpi_ds_restart_control_method(struct acpi_walk_state *walk_state,
  *
  * FUNCTION:    acpi_ds_terminate_control_method
  *
- * PARAMETERS:  walk_state          - State of the method
+ * PARAMETERS:  method_desc         - Method object
+ *              walk_state          - State associated with the method
  *
  * RETURN:      None
  *
@@ -431,95 +480,100 @@ acpi_ds_restart_control_method(struct acpi_walk_state *walk_state,
  *
  ******************************************************************************/
 
-void acpi_ds_terminate_control_method(struct acpi_walk_state *walk_state)
+void
+acpi_ds_terminate_control_method(union acpi_operand_object *method_desc,
+                                 struct acpi_walk_state *walk_state)
 {
-        union acpi_operand_object *obj_desc;
         struct acpi_namespace_node *method_node;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_terminate_control_method", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_terminate_control_method, walk_state);
 
-        if (!walk_state) {
-                return_VOID;
-        }
+        /* method_desc is required, walk_state is optional */
 
-        /* The current method object was saved in the walk state */
-
-        obj_desc = walk_state->method_desc;
-        if (!obj_desc) {
+        if (!method_desc) {
                 return_VOID;
         }
 
-        /* Delete all arguments and locals */
+        if (walk_state) {
 
-        acpi_ds_method_data_delete_all(walk_state);
+                /* Delete all arguments and locals */
+
+                acpi_ds_method_data_delete_all(walk_state);
+        }
 
         /*
          * Lock the parser while we terminate this method.
          * If this is the last thread executing the method,
          * we have additional cleanup to perform
          */
-        status = acpi_ut_acquire_mutex(ACPI_MTX_PARSER);
+        status = acpi_ut_acquire_mutex(ACPI_MTX_CONTROL_METHOD);
         if (ACPI_FAILURE(status)) {
                 return_VOID;
         }
 
         /* Signal completion of the execution of this method if necessary */
 
-        if (walk_state->method_desc->method.semaphore) {
+        if (method_desc->method.semaphore) {
                 status =
-                    acpi_os_signal_semaphore(walk_state->method_desc->method.
-                                             semaphore, 1);
+                    acpi_os_signal_semaphore(method_desc->method.semaphore, 1);
                 if (ACPI_FAILURE(status)) {
-                        ACPI_ERROR((AE_INFO,
-                                    "Could not signal method semaphore"));
 
-                        /* Ignore error and continue cleanup */
+                        /* Ignore error and continue */
+
+                        ACPI_EXCEPTION((AE_INFO, status,
+                                        "Could not signal method semaphore"));
                 }
         }
 
-        /*
-         * There are no more threads executing this method.  Perform
-         * additional cleanup.
-         *
-         * The method Node is stored in the walk state
-         */
-        method_node = walk_state->method_node;
+        if (walk_state) {
+                /*
+                 * Delete any objects created by this method during execution.
+                 * The method Node is stored in the walk state
+                 */
+                method_node = walk_state->method_node;
 
-        /* Lock namespace for possible update */
+                /* Lock namespace for possible update */
 
-        status = acpi_ut_acquire_mutex(ACPI_MTX_NAMESPACE);
-        if (ACPI_FAILURE(status)) {
-                goto exit;
-        }
+                status = acpi_ut_acquire_mutex(ACPI_MTX_NAMESPACE);
+                if (ACPI_FAILURE(status)) {
+                        goto exit;
+                }
 
-        /*
-         * Delete any namespace entries created immediately underneath
-         * the method
-         */
-        if (method_node->child) {
-                acpi_ns_delete_namespace_subtree(method_node);
+                /*
+                 * Delete any namespace entries created immediately underneath
+                 * the method
+                 */
+                if (method_node && method_node->child) {
+                        acpi_ns_delete_namespace_subtree(method_node);
+                }
+
+                /*
+                 * Delete any namespace entries created anywhere else within
+                 * the namespace by the execution of this method
+                 */
+                acpi_ns_delete_namespace_by_owner(method_desc->method.owner_id);
+                status = acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
         }
 
-        /*
-         * Delete any namespace entries created anywhere else within
-         * the namespace by the execution of this method
-         */
-        acpi_ns_delete_namespace_by_owner(walk_state->method_desc->method.
-                                          owner_id);
-        status = acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
+        /* Decrement the thread count on the method */
+
+        if (method_desc->method.thread_count) {
+                method_desc->method.thread_count--;
+        } else {
+                ACPI_ERROR((AE_INFO, "Invalid zero thread count in method"));
+        }
 
         /* Are there any other threads currently executing this method? */
 
-        if (walk_state->method_desc->method.thread_count) {
+        if (method_desc->method.thread_count) {
                 /*
                  * Additional threads. Do not release the owner_id in this case,
                  * we immediately reuse it for the next thread executing this method
                  */
                 ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
                                   "*** Completed execution of one thread, %d threads remaining\n",
-                                  walk_state->method_desc->method.
-                                  thread_count));
+                                  method_desc->method.thread_count));
         } else {
                 /* This is the only executing thread for this method */
 
@@ -533,22 +587,20 @@ void acpi_ds_terminate_control_method(struct acpi_walk_state *walk_state)
                  * This code is here because we must wait until the last thread exits
                  * before creating the synchronization semaphore.
                  */
-                if ((walk_state->method_desc->method.concurrency == 1) &&
-                    (!walk_state->method_desc->method.semaphore)) {
+                if ((method_desc->method.concurrency == 1) &&
+                    (!method_desc->method.semaphore)) {
                         status = acpi_os_create_semaphore(1, 1,
-                                                          &walk_state->
-                                                          method_desc->method.
+                                                          &method_desc->method.
                                                           semaphore);
                 }
 
                 /* No more threads, we can free the owner_id */
 
-                acpi_ut_release_owner_id(&walk_state->method_desc->method.
-                                         owner_id);
+                acpi_ut_release_owner_id(&method_desc->method.owner_id);
         }
 
       exit:
-        (void)acpi_ut_release_mutex(ACPI_MTX_PARSER);
+        (void)acpi_ut_release_mutex(ACPI_MTX_CONTROL_METHOD);
         return_VOID;
 }
 
@@ -581,7 +633,7 @@ acpi_status acpi_ds_parse_method(struct acpi_namespace_node *node)
         union acpi_parse_object *op;
         struct acpi_walk_state *walk_state;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_parse_method", node);
+        ACPI_FUNCTION_TRACE_PTR(ds_parse_method, node);
 
         /* Parameter Validation */
 
@@ -590,7 +642,7 @@ acpi_status acpi_ds_parse_method(struct acpi_namespace_node *node)
         }
 
         ACPI_DEBUG_PRINT((ACPI_DB_PARSE,
-                          "**** Parsing [%4.4s] **** named_obj=%p\n",
+                          "**** Parsing [%4.4s] **** NamedObj=%p\n",
                           acpi_ut_get_node_name(node), node));
 
         /* Extract the method object from the method Node */
@@ -669,7 +721,7 @@ acpi_status acpi_ds_parse_method(struct acpi_namespace_node *node)
         }
 
         ACPI_DEBUG_PRINT((ACPI_DB_PARSE,
-                          "**** [%4.4s] Parsed **** named_obj=%p Op=%p\n",
+                          "**** [%4.4s] Parsed **** NamedObj=%p Op=%p\n",
                           acpi_ut_get_node_name(node), node, op));
 
         /*
diff --git a/drivers/acpi/dispatcher/dsmthdat.c b/drivers/acpi/dispatcher/dsmthdat.c
index c025674f938b..459160ff9058 100644
--- a/drivers/acpi/dispatcher/dsmthdat.c
+++ b/drivers/acpi/dispatcher/dsmthdat.c
@@ -81,7 +81,7 @@ acpi_ds_method_data_get_type(u16 opcode,
  *              special data types.
  *
  * NOTES:       walk_state fields are initialized to zero by the
- *              ACPI_MEM_CALLOCATE().
+ *              ACPI_ALLOCATE_ZEROED().
  *
  *              A pseudo-Namespace Node is assigned to each argument and local
  *              so that ref_of() can return a pointer to the Node.
@@ -92,7 +92,7 @@ void acpi_ds_method_data_init(struct acpi_walk_state *walk_state)
 {
         u32 i;
 
-        ACPI_FUNCTION_TRACE("ds_method_data_init");
+        ACPI_FUNCTION_TRACE(ds_method_data_init);
 
         /* Init the method arguments */
 
@@ -100,10 +100,10 @@ void acpi_ds_method_data_init(struct acpi_walk_state *walk_state)
                 ACPI_MOVE_32_TO_32(&walk_state->arguments[i].name,
                                    NAMEOF_ARG_NTE);
                 walk_state->arguments[i].name.integer |= (i << 24);
-                walk_state->arguments[i].descriptor = ACPI_DESC_TYPE_NAMED;
+                walk_state->arguments[i].descriptor_type = ACPI_DESC_TYPE_NAMED;
                 walk_state->arguments[i].type = ACPI_TYPE_ANY;
-                walk_state->arguments[i].flags = ANOBJ_END_OF_PEER_LIST |
-                    ANOBJ_METHOD_ARG;
+                walk_state->arguments[i].flags =
+                    ANOBJ_END_OF_PEER_LIST | ANOBJ_METHOD_ARG;
         }
 
         /* Init the method locals */
@@ -113,11 +113,11 @@ void acpi_ds_method_data_init(struct acpi_walk_state *walk_state)
                                    NAMEOF_LOCAL_NTE);
 
                 walk_state->local_variables[i].name.integer |= (i << 24);
-                walk_state->local_variables[i].descriptor =
+                walk_state->local_variables[i].descriptor_type =
                     ACPI_DESC_TYPE_NAMED;
                 walk_state->local_variables[i].type = ACPI_TYPE_ANY;
-                walk_state->local_variables[i].flags = ANOBJ_END_OF_PEER_LIST |
-                    ANOBJ_METHOD_LOCAL;
+                walk_state->local_variables[i].flags =
+                    ANOBJ_END_OF_PEER_LIST | ANOBJ_METHOD_LOCAL;
         }
 
         return_VOID;
@@ -140,7 +140,7 @@ void acpi_ds_method_data_delete_all(struct acpi_walk_state *walk_state)
 {
         u32 index;
 
-        ACPI_FUNCTION_TRACE("ds_method_data_delete_all");
+        ACPI_FUNCTION_TRACE(ds_method_data_delete_all);
 
         /* Detach the locals */
 
@@ -199,7 +199,7 @@ acpi_ds_method_data_init_args(union acpi_operand_object **params,
         acpi_status status;
         u32 index = 0;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_method_data_init_args", params);
+        ACPI_FUNCTION_TRACE_PTR(ds_method_data_init_args, params);
 
         if (!params) {
                 ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
@@ -251,7 +251,7 @@ acpi_ds_method_data_get_node(u16 opcode,
                              struct acpi_walk_state *walk_state,
                              struct acpi_namespace_node **node)
 {
-        ACPI_FUNCTION_TRACE("ds_method_data_get_node");
+        ACPI_FUNCTION_TRACE(ds_method_data_get_node);
 
         /*
          * Method Locals and Arguments are supported
@@ -318,10 +318,10 @@ acpi_ds_method_data_set_value(u16 opcode,
         acpi_status status;
         struct acpi_namespace_node *node;
 
-        ACPI_FUNCTION_TRACE("ds_method_data_set_value");
+        ACPI_FUNCTION_TRACE(ds_method_data_set_value);
 
         ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
-                          "new_obj %p Opcode %X, Refs=%d [%s]\n", object,
+                          "NewObj %p Opcode %X, Refs=%d [%s]\n", object,
                           opcode, object->common.reference_count,
                           acpi_ut_get_type_name(object->common.type)));
 
@@ -336,7 +336,7 @@ acpi_ds_method_data_set_value(u16 opcode,
          * Increment ref count so object can't be deleted while installed.
          * NOTE: We do not copy the object in order to preserve the call by
          * reference semantics of ACPI Control Method invocation.
-         * (See ACPI specification 2.0_c)
+         * (See ACPI Specification 2.0_c)
          */
         acpi_ut_add_reference(object);
 
@@ -351,7 +351,7 @@ acpi_ds_method_data_set_value(u16 opcode,
  * FUNCTION:    acpi_ds_method_data_get_value
  *
  * PARAMETERS:  Opcode              - Either AML_LOCAL_OP or AML_ARG_OP
- *              Index               - which local_var or argument to get
+ *              Index               - Which local_var or argument to get
  *              walk_state          - Current walk state object
  *              dest_desc           - Where Arg or Local value is returned
  *
@@ -372,7 +372,7 @@ acpi_ds_method_data_get_value(u16 opcode,
         struct acpi_namespace_node *node;
         union acpi_operand_object *object;
 
-        ACPI_FUNCTION_TRACE("ds_method_data_get_value");
+        ACPI_FUNCTION_TRACE(ds_method_data_get_value);
 
         /* Validate the object descriptor */
 
@@ -459,7 +459,7 @@ acpi_ds_method_data_get_value(u16 opcode,
  * FUNCTION:    acpi_ds_method_data_delete_value
  *
  * PARAMETERS:  Opcode              - Either AML_LOCAL_OP or AML_ARG_OP
- *              Index               - which local_var or argument to delete
+ *              Index               - Which local_var or argument to delete
  *              walk_state          - Current walk state object
  *
  * RETURN:      None
@@ -477,7 +477,7 @@ acpi_ds_method_data_delete_value(u16 opcode,
         struct acpi_namespace_node *node;
         union acpi_operand_object *object;
 
-        ACPI_FUNCTION_TRACE("ds_method_data_delete_value");
+        ACPI_FUNCTION_TRACE(ds_method_data_delete_value);
 
         /* Get the namespace node for the arg/local */
 
@@ -538,7 +538,7 @@ acpi_ds_store_object_to_local(u16 opcode,
         union acpi_operand_object *current_obj_desc;
         union acpi_operand_object *new_obj_desc;
 
-        ACPI_FUNCTION_TRACE("ds_store_object_to_local");
+        ACPI_FUNCTION_TRACE(ds_store_object_to_local);
         ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "Opcode=%X Index=%d Obj=%p\n",
                           opcode, index, obj_desc));
 
@@ -614,7 +614,7 @@ acpi_ds_store_object_to_local(u16 opcode,
                             && (current_obj_desc->reference.opcode ==
                                 AML_REF_OF_OP)) {
                                 ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
-                                                  "Arg (%p) is an obj_ref(Node), storing in node %p\n",
+                                                  "Arg (%p) is an ObjRef(Node), storing in node %p\n",
                                                   new_obj_desc,
                                                   current_obj_desc));
 
@@ -688,7 +688,7 @@ acpi_ds_method_data_get_type(u16 opcode,
         struct acpi_namespace_node *node;
         union acpi_operand_object *object;
 
-        ACPI_FUNCTION_TRACE("ds_method_data_get_type");
+        ACPI_FUNCTION_TRACE(ds_method_data_get_type);
 
         /* Get the namespace node for the arg/local */
 
@@ -701,6 +701,7 @@ acpi_ds_method_data_get_type(u16 opcode,
 
         object = acpi_ns_get_attached_object(node);
         if (!object) {
+
                 /* Uninitialized local/arg, return TYPE_ANY */
 
                 return_VALUE(ACPI_TYPE_ANY);
diff --git a/drivers/acpi/dispatcher/dsobject.c b/drivers/acpi/dispatcher/dsobject.c
index 8b21f0f9e517..72190abb1d59 100644
--- a/drivers/acpi/dispatcher/dsobject.c
+++ b/drivers/acpi/dispatcher/dsobject.c
@@ -81,7 +81,7 @@ acpi_ds_build_internal_object(struct acpi_walk_state *walk_state,
         union acpi_operand_object *obj_desc;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("ds_build_internal_object");
+        ACPI_FUNCTION_TRACE(ds_build_internal_object);
 
         *obj_desc_ptr = NULL;
         if (op->common.aml_opcode == AML_INT_NAMEPATH_OP) {
@@ -103,6 +103,7 @@ acpi_ds_build_internal_object(struct acpi_walk_state *walk_state,
                                                                          common.
                                                                          node)));
                         if (ACPI_FAILURE(status)) {
+
                                 /* Check if we are resolving a named reference within a package */
 
                                 if ((status == AE_NOT_FOUND)
@@ -186,7 +187,7 @@ acpi_ds_build_internal_buffer_obj(struct acpi_walk_state *walk_state,
         union acpi_parse_object *byte_list;
         u32 byte_list_length = 0;
 
-        ACPI_FUNCTION_TRACE("ds_build_internal_buffer_obj");
+        ACPI_FUNCTION_TRACE(ds_build_internal_buffer_obj);
 
         /*
          * If we are evaluating a Named buffer object "Name (xxxx, Buffer)".
@@ -195,6 +196,7 @@ acpi_ds_build_internal_buffer_obj(struct acpi_walk_state *walk_state,
          */
         obj_desc = *obj_desc_ptr;
         if (!obj_desc) {
+
                 /* Create a new buffer object */
 
                 obj_desc = acpi_ut_create_internal_object(ACPI_TYPE_BUFFER);
@@ -243,7 +245,7 @@ acpi_ds_build_internal_buffer_obj(struct acpi_walk_state *walk_state,
                                   "Buffer defined with zero length in AML, creating\n"));
         } else {
                 obj_desc->buffer.pointer =
-                    ACPI_MEM_CALLOCATE(obj_desc->buffer.length);
+                    ACPI_ALLOCATE_ZEROED(obj_desc->buffer.length);
                 if (!obj_desc->buffer.pointer) {
                         acpi_ut_delete_object_desc(obj_desc);
                         return_ACPI_STATUS(AE_NO_MEMORY);
@@ -291,7 +293,7 @@ acpi_ds_build_internal_package_obj(struct acpi_walk_state *walk_state,
         acpi_status status = AE_OK;
         acpi_native_uint i;
 
-        ACPI_FUNCTION_TRACE("ds_build_internal_package_obj");
+        ACPI_FUNCTION_TRACE(ds_build_internal_package_obj);
 
         /* Find the parent of a possibly nested package */
 
@@ -339,9 +341,10 @@ acpi_ds_build_internal_package_obj(struct acpi_walk_state *walk_state,
          * individual objects). Add an extra pointer slot so
          * that the list is always null terminated.
          */
-        obj_desc->package.elements = ACPI_MEM_CALLOCATE(((acpi_size) obj_desc->
-                                                         package.count +
-                                                         1) * sizeof(void *));
+        obj_desc->package.elements = ACPI_ALLOCATE_ZEROED(((acpi_size)
+                                                           obj_desc->package.
+                                                           count +
+                                                           1) * sizeof(void *));
 
         if (!obj_desc->package.elements) {
                 acpi_ut_delete_object_desc(obj_desc);
@@ -355,6 +358,7 @@ acpi_ds_build_internal_package_obj(struct acpi_walk_state *walk_state,
         arg = arg->common.next;
         for (i = 0; arg; i++) {
                 if (arg->common.aml_opcode == AML_INT_RETURN_VALUE_OP) {
+
                         /* Object (package or buffer) is already built */
 
                         obj_desc->package.elements[i] =
@@ -396,7 +400,7 @@ acpi_ds_create_node(struct acpi_walk_state *walk_state,
         acpi_status status;
         union acpi_operand_object *obj_desc;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_create_node", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_create_node, op);
 
         /*
          * Because of the execution pass through the non-control-method
@@ -408,6 +412,7 @@ acpi_ds_create_node(struct acpi_walk_state *walk_state,
         }
 
         if (!op->common.value.arg) {
+
                 /* No arguments, there is nothing to do */
 
                 return_ACPI_STATUS(AE_OK);
@@ -464,11 +469,12 @@ acpi_ds_init_object_from_op(struct acpi_walk_state *walk_state,
         union acpi_operand_object *obj_desc;
         acpi_status status = AE_OK;
 
-        ACPI_FUNCTION_TRACE("ds_init_object_from_op");
+        ACPI_FUNCTION_TRACE(ds_init_object_from_op);
 
         obj_desc = *ret_obj_desc;
         op_info = acpi_ps_get_opcode_info(opcode);
         if (op_info->class == AML_CLASS_UNKNOWN) {
+
                 /* Unknown opcode */
 
                 return_ACPI_STATUS(AE_TYPE);
@@ -626,6 +632,7 @@ acpi_ds_init_object_from_op(struct acpi_walk_state *walk_state,
                 default:        /* Other literals, etc.. */
 
                         if (op->common.aml_opcode == AML_INT_NAMEPATH_OP) {
+
                                 /* Node was saved in Op */
 
                                 obj_desc->reference.node = op->common.node;
diff --git a/drivers/acpi/dispatcher/dsopcode.c b/drivers/acpi/dispatcher/dsopcode.c
index 6229c10674e1..5b974a8fe614 100644
--- a/drivers/acpi/dispatcher/dsopcode.c
+++ b/drivers/acpi/dispatcher/dsopcode.c
@@ -91,7 +91,7 @@ acpi_ds_execute_arguments(struct acpi_namespace_node *node,
         union acpi_parse_object *op;
         struct acpi_walk_state *walk_state;
 
-        ACPI_FUNCTION_TRACE("ds_execute_arguments");
+        ACPI_FUNCTION_TRACE(ds_execute_arguments);
 
         /*
          * Allocate a new parser op to be the root of the parsed tree
@@ -193,7 +193,7 @@ acpi_ds_get_buffer_field_arguments(union acpi_operand_object *obj_desc)
         struct acpi_namespace_node *node;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_get_buffer_field_arguments", obj_desc);
+        ACPI_FUNCTION_TRACE_PTR(ds_get_buffer_field_arguments, obj_desc);
 
         if (obj_desc->common.flags & AOPOBJ_DATA_VALID) {
                 return_ACPI_STATUS(AE_OK);
@@ -206,7 +206,7 @@ acpi_ds_get_buffer_field_arguments(union acpi_operand_object *obj_desc)
 
         ACPI_DEBUG_EXEC(acpi_ut_display_init_pathname
                         (ACPI_TYPE_BUFFER_FIELD, node, NULL));
-        ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "[%4.4s] buffer_field Arg Init\n",
+        ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "[%4.4s] BufferField Arg Init\n",
                           acpi_ut_get_node_name(node)));
 
         /* Execute the AML code for the term_arg arguments */
@@ -235,7 +235,7 @@ acpi_status acpi_ds_get_buffer_arguments(union acpi_operand_object *obj_desc)
         struct acpi_namespace_node *node;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_get_buffer_arguments", obj_desc);
+        ACPI_FUNCTION_TRACE_PTR(ds_get_buffer_arguments, obj_desc);
 
         if (obj_desc->common.flags & AOPOBJ_DATA_VALID) {
                 return_ACPI_STATUS(AE_OK);
@@ -279,7 +279,7 @@ acpi_status acpi_ds_get_package_arguments(union acpi_operand_object *obj_desc)
         struct acpi_namespace_node *node;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_get_package_arguments", obj_desc);
+        ACPI_FUNCTION_TRACE_PTR(ds_get_package_arguments, obj_desc);
 
         if (obj_desc->common.flags & AOPOBJ_DATA_VALID) {
                 return_ACPI_STATUS(AE_OK);
@@ -324,7 +324,7 @@ acpi_status acpi_ds_get_region_arguments(union acpi_operand_object *obj_desc)
         acpi_status status;
         union acpi_operand_object *extra_desc;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_get_region_arguments", obj_desc);
+        ACPI_FUNCTION_TRACE_PTR(ds_get_region_arguments, obj_desc);
 
         if (obj_desc->region.flags & AOPOBJ_DATA_VALID) {
                 return_ACPI_STATUS(AE_OK);
@@ -342,8 +342,7 @@ acpi_status acpi_ds_get_region_arguments(union acpi_operand_object *obj_desc)
         ACPI_DEBUG_EXEC(acpi_ut_display_init_pathname
                         (ACPI_TYPE_REGION, node, NULL));
 
-        ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
-                          "[%4.4s] op_region Arg Init at AML %p\n",
+        ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "[%4.4s] OpRegion Arg Init at AML %p\n",
                           acpi_ut_get_node_name(node),
                           extra_desc->extra.aml_start));
 
@@ -352,6 +351,28 @@ acpi_status acpi_ds_get_region_arguments(union acpi_operand_object *obj_desc)
         status = acpi_ds_execute_arguments(node, acpi_ns_get_parent_node(node),
                                            extra_desc->extra.aml_length,
                                            extra_desc->extra.aml_start);
+        if (ACPI_FAILURE(status)) {
+                return_ACPI_STATUS(status);
+        }
+
+        /* Validate the region address/length via the host OS */
+
+        status = acpi_os_validate_address(obj_desc->region.space_id,
+                                          obj_desc->region.address,
+                                          (acpi_size) obj_desc->region.length);
+        if (ACPI_FAILURE(status)) {
+                /*
+                 * Invalid address/length. We will emit an error message and mark
+                 * the region as invalid, so that it will cause an additional error if
+                 * it is ever used. Then return AE_OK.
+                 */
+                ACPI_EXCEPTION((AE_INFO, status,
+                                "During address validation of OpRegion [%4.4s]",
+                                node->name.ascii));
+                obj_desc->common.flags |= AOPOBJ_INVALID;
+                status = AE_OK;
+        }
+
         return_ACPI_STATUS(status);
 }
 
@@ -411,7 +432,7 @@ acpi_ds_init_buffer_field(u16 aml_opcode,
         u8 field_flags;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_init_buffer_field", obj_desc);
+        ACPI_FUNCTION_TRACE_PTR(ds_init_buffer_field, obj_desc);
 
         /* Host object must be a Buffer */
 
@@ -457,7 +478,7 @@ acpi_ds_init_buffer_field(u16 aml_opcode,
 
                 if (bit_count == 0) {
                         ACPI_ERROR((AE_INFO,
-                                    "Attempt to create_field of length zero"));
+                                    "Attempt to CreateField of length zero"));
                         status = AE_AML_OPERAND_VALUE;
                         goto cleanup;
                 }
@@ -595,7 +616,7 @@ acpi_ds_eval_buffer_field_operands(struct acpi_walk_state *walk_state,
         struct acpi_namespace_node *node;
         union acpi_parse_object *next_op;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_eval_buffer_field_operands", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_eval_buffer_field_operands, op);
 
         /*
          * This is where we evaluate the address and length fields of the
@@ -627,7 +648,7 @@ acpi_ds_eval_buffer_field_operands(struct acpi_walk_state *walk_state,
         ACPI_DUMP_OPERANDS(ACPI_WALK_OPERANDS, ACPI_IMODE_EXECUTE,
                            acpi_ps_get_opcode_name(op->common.aml_opcode),
                            walk_state->num_operands,
-                           "after acpi_ex_resolve_operands");
+                           "after AcpiExResolveOperands");
 
         if (ACPI_FAILURE(status)) {
                 ACPI_ERROR((AE_INFO, "(%s) bad operand(s) (%X)",
@@ -640,6 +661,7 @@ acpi_ds_eval_buffer_field_operands(struct acpi_walk_state *walk_state,
         /* Initialize the Buffer Field */
 
         if (op->common.aml_opcode == AML_CREATE_FIELD_OP) {
+
                 /* NOTE: Slightly different operands for this opcode */
 
                 status =
@@ -685,7 +707,7 @@ acpi_ds_eval_region_operands(struct acpi_walk_state *walk_state,
         struct acpi_namespace_node *node;
         union acpi_parse_object *next_op;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_eval_region_operands", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_eval_region_operands, op);
 
         /*
          * This is where we evaluate the address and length fields of the
@@ -718,7 +740,7 @@ acpi_ds_eval_region_operands(struct acpi_walk_state *walk_state,
 
         ACPI_DUMP_OPERANDS(ACPI_WALK_OPERANDS, ACPI_IMODE_EXECUTE,
                            acpi_ps_get_opcode_name(op->common.aml_opcode),
-                           1, "after acpi_ex_resolve_operands");
+                           1, "after AcpiExResolveOperands");
 
         obj_desc = acpi_ns_get_attached_object(node);
         if (!obj_desc) {
@@ -744,7 +766,7 @@ acpi_ds_eval_region_operands(struct acpi_walk_state *walk_state,
             operand_desc->integer.value;
         acpi_ut_remove_reference(operand_desc);
 
-        ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "rgn_obj %p Addr %8.8X%8.8X Len %X\n",
+        ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "RgnObj %p Addr %8.8X%8.8X Len %X\n",
                           obj_desc,
                           ACPI_FORMAT_UINT64(obj_desc->region.address),
                           obj_desc->region.length));
@@ -780,7 +802,7 @@ acpi_ds_eval_data_object_operands(struct acpi_walk_state *walk_state,
         union acpi_operand_object *arg_desc;
         u32 length;
 
-        ACPI_FUNCTION_TRACE("ds_eval_data_object_operands");
+        ACPI_FUNCTION_TRACE(ds_eval_data_object_operands);
 
         /* The first operand (for all of these data objects) is the length */
 
@@ -874,7 +896,7 @@ acpi_ds_exec_begin_control_op(struct acpi_walk_state *walk_state,
         acpi_status status = AE_OK;
         union acpi_generic_state *control_state;
 
-        ACPI_FUNCTION_NAME("ds_exec_begin_control_op");
+        ACPI_FUNCTION_NAME(ds_exec_begin_control_op);
 
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "Op=%p Opcode=%2.2X State=%p\n", op,
                           op->common.aml_opcode, walk_state));
@@ -952,7 +974,7 @@ acpi_ds_exec_end_control_op(struct acpi_walk_state * walk_state,
         acpi_status status = AE_OK;
         union acpi_generic_state *control_state;
 
-        ACPI_FUNCTION_NAME("ds_exec_end_control_op");
+        ACPI_FUNCTION_NAME(ds_exec_end_control_op);
 
         switch (op->common.aml_opcode) {
         case AML_IF_OP:
@@ -984,6 +1006,7 @@ acpi_ds_exec_end_control_op(struct acpi_walk_state * walk_state,
                 ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "[WHILE_OP] Op=%p\n", op));
 
                 if (walk_state->control_state->common.value) {
+
                         /* Predicate was true, go back and evaluate it again! */
 
                         status = AE_CTRL_PENDING;
@@ -1014,6 +1037,7 @@ acpi_ds_exec_end_control_op(struct acpi_walk_state * walk_state,
                  * has been bubbled up the tree
                  */
                 if (op->common.value.arg) {
+
                         /* Since we have a real Return(), delete any implicit return */
 
                         acpi_ds_clear_implicit_return(walk_state);
@@ -1047,6 +1071,7 @@ acpi_ds_exec_end_control_op(struct acpi_walk_state * walk_state,
                         walk_state->return_desc = walk_state->operands[0];
                 } else if ((walk_state->results) &&
                            (walk_state->results->results.num_results > 0)) {
+
                         /* Since we have a real Return(), delete any implicit return */
 
                         acpi_ds_clear_implicit_return(walk_state);
@@ -1095,7 +1120,7 @@ acpi_ds_exec_end_control_op(struct acpi_walk_state * walk_state,
                 }
 
                 ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
-                                  "Completed RETURN_OP State=%p, ret_val=%p\n",
+                                  "Completed RETURN_OP State=%p, RetVal=%p\n",
                                   walk_state, walk_state->return_desc));
 
                 /* End the control method execution right now */
diff --git a/drivers/acpi/dispatcher/dsutils.c b/drivers/acpi/dispatcher/dsutils.c
index 53356a591ac1..05230baf5de8 100644
--- a/drivers/acpi/dispatcher/dsutils.c
+++ b/drivers/acpi/dispatcher/dsutils.c
@@ -68,7 +68,7 @@ ACPI_MODULE_NAME("dsutils")
  ******************************************************************************/
 void acpi_ds_clear_implicit_return(struct acpi_walk_state *walk_state)
 {
-        ACPI_FUNCTION_NAME("ds_clear_implicit_return");
+        ACPI_FUNCTION_NAME(ds_clear_implicit_return);
 
         /*
          * Slack must be enabled for this feature
@@ -115,7 +115,7 @@ u8
 acpi_ds_do_implicit_return(union acpi_operand_object *return_desc,
                            struct acpi_walk_state *walk_state, u8 add_reference)
 {
-        ACPI_FUNCTION_NAME("ds_do_implicit_return");
+        ACPI_FUNCTION_NAME(ds_do_implicit_return);
 
         /*
          * Slack must be enabled for this feature, and we must
@@ -171,7 +171,7 @@ acpi_ds_is_result_used(union acpi_parse_object * op,
 {
         const struct acpi_opcode_info *parent_info;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_is_result_used", op);
+        ACPI_FUNCTION_TRACE_PTR(ds_is_result_used, op);
 
         /* Must have both an Op and a Result Object */
 
@@ -202,6 +202,7 @@ acpi_ds_is_result_used(union acpi_parse_object * op,
          */
         if ((!op->common.parent) ||
             (op->common.parent->common.aml_opcode == AML_SCOPE_OP)) {
+
                 /* No parent, the return value cannot possibly be used */
 
                 ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
@@ -340,7 +341,7 @@ acpi_ds_delete_result_if_not_used(union acpi_parse_object *op,
         union acpi_operand_object *obj_desc;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_delete_result_if_not_used", result_obj);
+        ACPI_FUNCTION_TRACE_PTR(ds_delete_result_if_not_used, result_obj);
 
         if (!op) {
                 ACPI_ERROR((AE_INFO, "Null Op"));
@@ -352,6 +353,7 @@ acpi_ds_delete_result_if_not_used(union acpi_parse_object *op,
         }
 
         if (!acpi_ds_is_result_used(op, walk_state)) {
+
                 /* Must pop the result stack (obj_desc should be equal to result_obj) */
 
                 status = acpi_ds_result_pop(&obj_desc, walk_state);
@@ -382,7 +384,7 @@ acpi_status acpi_ds_resolve_operands(struct acpi_walk_state *walk_state)
         u32 i;
         acpi_status status = AE_OK;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_resolve_operands", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_resolve_operands, walk_state);
 
         /*
          * Attempt to resolve each of the valid operands
@@ -417,7 +419,7 @@ void acpi_ds_clear_operands(struct acpi_walk_state *walk_state)
 {
         u32 i;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_clear_operands", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_clear_operands, walk_state);
 
         /* Remove a reference on each operand on the stack */
 
@@ -465,7 +467,7 @@ acpi_ds_create_operand(struct acpi_walk_state *walk_state,
         acpi_interpreter_mode interpreter_mode;
         const struct acpi_opcode_info *op_info;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_create_operand", arg);
+        ACPI_FUNCTION_TRACE_PTR(ds_create_operand, arg);
 
         /* A valid name must be looked up in the namespace */
 
@@ -498,7 +500,9 @@ acpi_ds_create_operand(struct acpi_walk_state *walk_state,
                  */
                 if ((walk_state->deferred_node) &&
                     (walk_state->deferred_node->type == ACPI_TYPE_BUFFER_FIELD)
-                    && (arg_index != 0)) {
+                    && (arg_index ==
+                        (u32) ((walk_state->opcode ==
+                                AML_CREATE_FIELD_OP) ? 3 : 2))) {
                         obj_desc =
                             ACPI_CAST_PTR(union acpi_operand_object,
                                           walk_state->deferred_node);
@@ -521,6 +525,7 @@ acpi_ds_create_operand(struct acpi_walk_state *walk_state,
                             && (parent_op->common.aml_opcode != AML_REGION_OP)
                             && (parent_op->common.aml_opcode !=
                                 AML_INT_NAMEPATH_OP)) {
+
                                 /* Enter name into namespace if not found */
 
                                 interpreter_mode = ACPI_IMODE_LOAD_PASS2;
@@ -572,7 +577,7 @@ acpi_ds_create_operand(struct acpi_walk_state *walk_state,
 
                 /* Free the namestring created above */
 
-                ACPI_MEM_FREE(name_string);
+                ACPI_FREE(name_string);
 
                 /* Check status from the lookup */
 
@@ -696,7 +701,7 @@ acpi_ds_create_operands(struct acpi_walk_state *walk_state,
         union acpi_parse_object *arg;
         u32 arg_count = 0;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_create_operands", first_arg);
+        ACPI_FUNCTION_TRACE_PTR(ds_create_operands, first_arg);
 
         /* For all arguments in the list... */
 
diff --git a/drivers/acpi/dispatcher/dswexec.c b/drivers/acpi/dispatcher/dswexec.c
index f1af655ff113..3acbd9145d72 100644
--- a/drivers/acpi/dispatcher/dswexec.c
+++ b/drivers/acpi/dispatcher/dswexec.c
@@ -49,7 +49,6 @@
 #include <acpi/acinterp.h>
 #include <acpi/acnamesp.h>
 #include <acpi/acdebug.h>
-#include <acpi/acdisasm.h>
 
 #define _COMPONENT          ACPI_DISPATCHER
 ACPI_MODULE_NAME("dswexec")
@@ -93,7 +92,7 @@ acpi_ds_get_predicate_value(struct acpi_walk_state *walk_state,
         union acpi_operand_object *obj_desc;
         union acpi_operand_object *local_obj_desc = NULL;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_get_predicate_value", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_get_predicate_value, walk_state);
 
         walk_state->control_state->common.state = 0;
 
@@ -123,7 +122,7 @@ acpi_ds_get_predicate_value(struct acpi_walk_state *walk_state,
 
         if (!obj_desc) {
                 ACPI_ERROR((AE_INFO,
-                            "No predicate obj_desc=%p State=%p",
+                            "No predicate ObjDesc=%p State=%p",
                             obj_desc, walk_state));
 
                 return_ACPI_STATUS(AE_AML_NO_OPERAND);
@@ -140,7 +139,7 @@ acpi_ds_get_predicate_value(struct acpi_walk_state *walk_state,
 
         if (ACPI_GET_OBJECT_TYPE(local_obj_desc) != ACPI_TYPE_INTEGER) {
                 ACPI_ERROR((AE_INFO,
-                            "Bad predicate (not an integer) obj_desc=%p State=%p Type=%X",
+                            "Bad predicate (not an integer) ObjDesc=%p State=%p Type=%X",
                             obj_desc, walk_state,
                             ACPI_GET_OBJECT_TYPE(obj_desc)));
 
@@ -214,7 +213,7 @@ acpi_ds_exec_begin_op(struct acpi_walk_state *walk_state,
         acpi_status status = AE_OK;
         u32 opcode_class;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_exec_begin_op", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_exec_begin_op, walk_state);
 
         op = walk_state->op;
         if (!op) {
@@ -296,7 +295,7 @@ acpi_ds_exec_begin_op(struct acpi_walk_state *walk_state,
 
         case AML_CLASS_NAMED_OBJECT:
 
-                if (walk_state->walk_type == ACPI_WALK_METHOD) {
+                if (walk_state->walk_type & ACPI_WALK_METHOD) {
                         /*
                          * Found a named object declaration during method execution;
                          * we must enter this object into the namespace.  The created
@@ -354,7 +353,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
         union acpi_parse_object *next_op;
         union acpi_parse_object *first_arg;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_exec_end_op", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_exec_end_op, walk_state);
 
         op = walk_state->op;
         op_type = walk_state->op_info->type;
@@ -409,6 +408,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
                  * being the object_type and size_of operators.
                  */
                 if (!(walk_state->op_info->flags & AML_NO_OPERAND_RESOLVE)) {
+
                         /* Resolve all operands */
 
                         status = acpi_ex_resolve_operands(walk_state->opcode,
@@ -423,7 +423,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
                                                    acpi_ps_get_opcode_name
                                                    (walk_state->opcode),
                                                    walk_state->num_operands,
-                                                   "after ex_resolve_operands");
+                                                   "after ExResolveOperands");
                         }
                 }
 
@@ -437,7 +437,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
                             acpi_gbl_op_type_dispatch[op_type] (walk_state);
                 } else {
                         /*
-                         * Treat constructs of the form "Store(local_x,local_x)" as noops when the
+                         * Treat constructs of the form "Store(LocalX,LocalX)" as noops when the
                          * Local is uninitialized.
                          */
                         if ((status == AE_AML_UNINITIALIZED_LOCAL) &&
@@ -548,6 +548,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
                          */
                         status = acpi_ds_resolve_operands(walk_state);
                         if (ACPI_FAILURE(status)) {
+
                                 /* On error, clear all resolved operands */
 
                                 acpi_ds_clear_operands(walk_state);
@@ -569,7 +570,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
                 case AML_TYPE_CREATE_FIELD:
 
                         ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
-                                          "Executing create_field Buffer/Index Op=%p\n",
+                                          "Executing CreateField Buffer/Index Op=%p\n",
                                           op));
 
                         status = acpi_ds_load2_end_op(walk_state);
@@ -584,7 +585,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
                 case AML_TYPE_CREATE_OBJECT:
 
                         ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
-                                          "Executing create_object (Buffer/Package) Op=%p\n",
+                                          "Executing CreateObject (Buffer/Package) Op=%p\n",
                                           op));
 
                         switch (op->common.parent->common.aml_opcode) {
@@ -657,7 +658,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
 
                         if (op->common.aml_opcode == AML_REGION_OP) {
                                 ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
-                                                  "Executing op_region Address/Length Op=%p\n",
+                                                  "Executing OpRegion Address/Length Op=%p\n",
                                                   op));
 
                                 status =
@@ -722,6 +723,7 @@ acpi_status acpi_ds_exec_end_op(struct acpi_walk_state *walk_state)
       cleanup:
 
         if (walk_state->result_obj) {
+
                 /* Break to debugger to display result */
 
                 ACPI_DEBUGGER_EXEC(acpi_db_display_result_object
diff --git a/drivers/acpi/dispatcher/dswload.c b/drivers/acpi/dispatcher/dswload.c
index d3d24da31c81..35074399c617 100644
--- a/drivers/acpi/dispatcher/dswload.c
+++ b/drivers/acpi/dispatcher/dswload.c
@@ -127,7 +127,7 @@ acpi_ds_load1_begin_op(struct acpi_walk_state * walk_state,
         char *path;
         u32 flags;
 
-        ACPI_FUNCTION_TRACE("ds_load1_begin_op");
+        ACPI_FUNCTION_TRACE(ds_load1_begin_op);
 
         op = walk_state->op;
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "Op=%p State=%p\n", op,
@@ -178,12 +178,12 @@ acpi_ds_load1_begin_op(struct acpi_walk_state * walk_state,
                          * Target of Scope() not found.  Generate an External for it, and
                          * insert the name into the namespace.
                          */
-                        acpi_dm_add_to_external_list(path);
+                        acpi_dm_add_to_external_list(path, ACPI_TYPE_DEVICE, 0);
                         status =
                             acpi_ns_lookup(walk_state->scope_info, path,
                                            object_type, ACPI_IMODE_LOAD_PASS1,
                                            ACPI_NS_SEARCH_PARENT, walk_state,
-                                           &(node));
+                                           &node);
                 }
 #endif
                 if (ACPI_FAILURE(status)) {
@@ -261,6 +261,7 @@ acpi_ds_load1_begin_op(struct acpi_walk_state * walk_state,
                  */
 
                 if (walk_state->deferred_node) {
+
                         /* This name is already in the namespace, get the node */
 
                         node = walk_state->deferred_node;
@@ -300,10 +301,41 @@ acpi_ds_load1_begin_op(struct acpi_walk_state * walk_state,
                 status =
                     acpi_ns_lookup(walk_state->scope_info, path, object_type,
                                    ACPI_IMODE_LOAD_PASS1, flags, walk_state,
-                                   &(node));
+                                   &node);
                 if (ACPI_FAILURE(status)) {
-                        ACPI_ERROR_NAMESPACE(path, status);
-                        return_ACPI_STATUS(status);
+                        if (status == AE_ALREADY_EXISTS) {
+
+                                /* The name already exists in this scope */
+
+                                if (node->flags & ANOBJ_IS_EXTERNAL) {
+                                        /*
+                                         * Allow one create on an object or segment that was
+                                         * previously declared External
+                                         */
+                                        node->flags &= ~ANOBJ_IS_EXTERNAL;
+                                        node->type = (u8) object_type;
+
+                                        /* Just retyped a node, probably will need to open a scope */
+
+                                        if (acpi_ns_opens_scope(object_type)) {
+                                                status =
+                                                    acpi_ds_scope_stack_push
+                                                    (node, object_type,
+                                                     walk_state);
+                                                if (ACPI_FAILURE(status)) {
+                                                        return_ACPI_STATUS
+                                                            (status);
+                                                }
+                                        }
+                                        status = AE_OK;
+                                }
+                        }
+
+                        if (ACPI_FAILURE(status)) {
+
+                                ACPI_ERROR_NAMESPACE(path, status);
+                                return_ACPI_STATUS(status);
+                        }
                 }
                 break;
         }
@@ -311,6 +343,7 @@ acpi_ds_load1_begin_op(struct acpi_walk_state * walk_state,
         /* Common exit */
 
         if (!op) {
+
                 /* Create a new op */
 
                 op = acpi_ps_alloc_op(walk_state->opcode);
@@ -359,7 +392,7 @@ acpi_status acpi_ds_load1_end_op(struct acpi_walk_state *walk_state)
         acpi_object_type object_type;
         acpi_status status = AE_OK;
 
-        ACPI_FUNCTION_TRACE("ds_load1_end_op");
+        ACPI_FUNCTION_TRACE(ds_load1_end_op);
 
         op = walk_state->op;
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "Op=%p State=%p\n", op,
@@ -413,6 +446,7 @@ acpi_status acpi_ds_load1_end_op(struct acpi_walk_state *walk_state)
 #endif
 
         if (op->common.aml_opcode == AML_NAME_OP) {
+
                 /* For Name opcode, get the object type from the argument */
 
                 if (op->common.value.arg) {
@@ -445,7 +479,7 @@ acpi_status acpi_ds_load1_end_op(struct acpi_walk_state *walk_state)
                          * arguments.)
                          */
                         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
-                                          "LOADING-Method: State=%p Op=%p named_obj=%p\n",
+                                          "LOADING-Method: State=%p Op=%p NamedObj=%p\n",
                                           walk_state, op, op->named.node));
 
                         if (!acpi_ns_get_attached_object(op->named.node)) {
@@ -511,7 +545,7 @@ acpi_ds_load2_begin_op(struct acpi_walk_state *walk_state,
         acpi_object_type object_type;
         char *buffer_ptr;
 
-        ACPI_FUNCTION_TRACE("ds_load2_begin_op");
+        ACPI_FUNCTION_TRACE(ds_load2_begin_op);
 
         op = walk_state->op;
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "Op=%p State=%p\n", op,
@@ -521,6 +555,7 @@ acpi_ds_load2_begin_op(struct acpi_walk_state *walk_state,
                 if ((walk_state->control_state) &&
                     (walk_state->control_state->common.state ==
                      ACPI_CONTROL_CONDITIONAL_EXECUTING)) {
+
                         /* We are executing a while loop outside of a method */
 
                         status = acpi_ds_exec_begin_op(walk_state, out_op);
@@ -554,10 +589,12 @@ acpi_ds_load2_begin_op(struct acpi_walk_state *walk_state,
                 /* Get the name we are going to enter or lookup in the namespace */
 
                 if (walk_state->opcode == AML_INT_NAMEPATH_OP) {
+
                         /* For Namepath op, get the path string */
 
                         buffer_ptr = op->common.value.string;
                         if (!buffer_ptr) {
+
                                 /* No name, just exit */
 
                                 return_ACPI_STATUS(AE_OK);
@@ -680,6 +717,7 @@ acpi_ds_load2_begin_op(struct acpi_walk_state *walk_state,
                 /* All other opcodes */
 
                 if (op && op->common.node) {
+
                         /* This op/node was previously entered into the namespace */
 
                         node = op->common.node;
@@ -705,6 +743,7 @@ acpi_ds_load2_begin_op(struct acpi_walk_state *walk_state,
                  * Note: Name may already exist if we are executing a deferred opcode.
                  */
                 if (walk_state->deferred_node) {
+
                         /* This name is already in the namespace, get the node */
 
                         node = walk_state->deferred_node;
@@ -727,6 +766,7 @@ acpi_ds_load2_begin_op(struct acpi_walk_state *walk_state,
         }
 
         if (!op) {
+
                 /* Create a new op */
 
                 op = acpi_ps_alloc_op(walk_state->opcode);
@@ -776,7 +816,7 @@ acpi_status acpi_ds_load2_end_op(struct acpi_walk_state *walk_state)
         u32 i;
 #endif
 
-        ACPI_FUNCTION_TRACE("ds_load2_end_op");
+        ACPI_FUNCTION_TRACE(ds_load2_end_op);
 
         op = walk_state->op;
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, "Opcode [%s] Op %p State %p\n",
@@ -870,7 +910,7 @@ acpi_status acpi_ds_load2_end_op(struct acpi_walk_state *walk_state)
          */
 
         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
-                          "Create-Load [%s] State=%p Op=%p named_obj=%p\n",
+                          "Create-Load [%s] State=%p Op=%p NamedObj=%p\n",
                           acpi_ps_get_opcode_name(op->common.aml_opcode),
                           walk_state, op, node));
 
@@ -1045,7 +1085,7 @@ acpi_status acpi_ds_load2_end_op(struct acpi_walk_state *walk_state)
                          * arguments.)
                          */
                         ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
-                                          "LOADING-Method: State=%p Op=%p named_obj=%p\n",
+                                          "LOADING-Method: State=%p Op=%p NamedObj=%p\n",
                                           walk_state, op, op->named.node));
 
                         if (!acpi_ns_get_attached_object(op->named.node)) {
@@ -1090,7 +1130,7 @@ acpi_status acpi_ds_load2_end_op(struct acpi_walk_state *walk_state)
         case AML_CLASS_METHOD_CALL:
 
                 ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH,
-                                  "RESOLVING-method_call: State=%p Op=%p named_obj=%p\n",
+                                  "RESOLVING-MethodCall: State=%p Op=%p NamedObj=%p\n",
                                   walk_state, op, node));
 
                 /*
@@ -1104,7 +1144,6 @@ acpi_status acpi_ds_load2_end_op(struct acpi_walk_state *walk_state)
                                    ACPI_NS_DONT_OPEN_SCOPE, walk_state,
                                    &(new_node));
                 if (ACPI_SUCCESS(status)) {
-
                         /*
                          * Make sure that what we found is indeed a method
                          * We didn't search for a method on purpose, to see if the name
diff --git a/drivers/acpi/dispatcher/dswscope.c b/drivers/acpi/dispatcher/dswscope.c
index ada21ef4a174..c9228972f5f6 100644
--- a/drivers/acpi/dispatcher/dswscope.c
+++ b/drivers/acpi/dispatcher/dswscope.c
@@ -63,9 +63,10 @@ void acpi_ds_scope_stack_clear(struct acpi_walk_state *walk_state)
 {
         union acpi_generic_state *scope_info;
 
-        ACPI_FUNCTION_NAME("ds_scope_stack_clear");
+        ACPI_FUNCTION_NAME(ds_scope_stack_clear);
 
         while (walk_state->scope_info) {
+
                 /* Pop a scope off the stack */
 
                 scope_info = walk_state->scope_info;
@@ -102,9 +103,10 @@ acpi_ds_scope_stack_push(struct acpi_namespace_node *node,
         union acpi_generic_state *scope_info;
         union acpi_generic_state *old_scope_info;
 
-        ACPI_FUNCTION_TRACE("ds_scope_stack_push");
+        ACPI_FUNCTION_TRACE(ds_scope_stack_push);
 
         if (!node) {
+
                 /* Invalid scope   */
 
                 ACPI_ERROR((AE_INFO, "Null scope parameter"));
@@ -126,7 +128,7 @@ acpi_ds_scope_stack_push(struct acpi_namespace_node *node,
 
         /* Init new scope object */
 
-        scope_info->common.data_type = ACPI_DESC_TYPE_STATE_WSCOPE;
+        scope_info->common.descriptor_type = ACPI_DESC_TYPE_STATE_WSCOPE;
         scope_info->scope.node = node;
         scope_info->common.value = (u16) type;
 
@@ -176,7 +178,7 @@ acpi_status acpi_ds_scope_stack_pop(struct acpi_walk_state *walk_state)
         union acpi_generic_state *scope_info;
         union acpi_generic_state *new_scope_info;
 
-        ACPI_FUNCTION_TRACE("ds_scope_stack_pop");
+        ACPI_FUNCTION_TRACE(ds_scope_stack_pop);
 
         /*
          * Pop scope info object off the stack.
diff --git a/drivers/acpi/dispatcher/dswstate.c b/drivers/acpi/dispatcher/dswstate.c
index fa78cb74ee36..7817e5522679 100644
--- a/drivers/acpi/dispatcher/dswstate.c
+++ b/drivers/acpi/dispatcher/dswstate.c
@@ -66,7 +66,6 @@ void *acpi_ds_obj_stack_get_value(u32 index,
 #endif
 
 #ifdef ACPI_FUTURE_USAGE
-
 /*******************************************************************************
  *
  * FUNCTION:    acpi_ds_result_remove
@@ -88,7 +87,7 @@ acpi_ds_result_remove(union acpi_operand_object **object,
 {
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_NAME("ds_result_remove");
+        ACPI_FUNCTION_NAME(ds_result_remove);
 
         state = walk_state->results;
         if (!state) {
@@ -128,7 +127,6 @@ acpi_ds_result_remove(union acpi_operand_object **object,
 
         return (AE_OK);
 }
-
 #endif                          /*  ACPI_FUTURE_USAGE  */
 
 /*******************************************************************************
@@ -152,7 +150,7 @@ acpi_ds_result_pop(union acpi_operand_object ** object,
         acpi_native_uint index;
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_NAME("ds_result_pop");
+        ACPI_FUNCTION_NAME(ds_result_pop);
 
         state = walk_state->results;
         if (!state) {
@@ -170,6 +168,7 @@ acpi_ds_result_pop(union acpi_operand_object ** object,
         state->results.num_results--;
 
         for (index = ACPI_OBJ_NUM_OPERANDS; index; index--) {
+
                 /* Check for a valid result object */
 
                 if (state->results.obj_desc[index - 1]) {
@@ -213,7 +212,7 @@ acpi_ds_result_pop_from_bottom(union acpi_operand_object ** object,
         acpi_native_uint index;
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_NAME("ds_result_pop_from_bottom");
+        ACPI_FUNCTION_NAME(ds_result_pop_from_bottom);
 
         state = walk_state->results;
         if (!state) {
@@ -278,7 +277,7 @@ acpi_ds_result_push(union acpi_operand_object * object,
 {
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_NAME("ds_result_push");
+        ACPI_FUNCTION_NAME(ds_result_push);
 
         state = walk_state->results;
         if (!state) {
@@ -331,14 +330,14 @@ acpi_status acpi_ds_result_stack_push(struct acpi_walk_state * walk_state)
 {
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_NAME("ds_result_stack_push");
+        ACPI_FUNCTION_NAME(ds_result_stack_push);
 
         state = acpi_ut_create_generic_state();
         if (!state) {
                 return (AE_NO_MEMORY);
         }
 
-        state->common.data_type = ACPI_DESC_TYPE_STATE_RESULT;
+        state->common.descriptor_type = ACPI_DESC_TYPE_STATE_RESULT;
         acpi_ut_push_generic_state(&walk_state->results, state);
 
         ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "Results=%p State=%p\n",
@@ -363,7 +362,7 @@ acpi_status acpi_ds_result_stack_pop(struct acpi_walk_state * walk_state)
 {
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_NAME("ds_result_stack_pop");
+        ACPI_FUNCTION_NAME(ds_result_stack_pop);
 
         /* Check for stack underflow */
 
@@ -376,7 +375,7 @@ acpi_status acpi_ds_result_stack_pop(struct acpi_walk_state * walk_state)
         state = acpi_ut_pop_generic_state(&walk_state->results);
 
         ACPI_DEBUG_PRINT((ACPI_DB_EXEC,
-                          "Result=%p remaining_results=%X State=%p\n",
+                          "Result=%p RemainingResults=%X State=%p\n",
                           state, state->results.num_results, walk_state));
 
         acpi_ut_delete_generic_state(state);
@@ -400,7 +399,7 @@ acpi_status acpi_ds_result_stack_pop(struct acpi_walk_state * walk_state)
 acpi_status
 acpi_ds_obj_stack_push(void *object, struct acpi_walk_state * walk_state)
 {
-        ACPI_FUNCTION_NAME("ds_obj_stack_push");
+        ACPI_FUNCTION_NAME(ds_obj_stack_push);
 
         /* Check for stack overflow */
 
@@ -445,9 +444,10 @@ acpi_ds_obj_stack_pop(u32 pop_count, struct acpi_walk_state * walk_state)
 {
         u32 i;
 
-        ACPI_FUNCTION_NAME("ds_obj_stack_pop");
+        ACPI_FUNCTION_NAME(ds_obj_stack_pop);
 
         for (i = 0; i < pop_count; i++) {
+
                 /* Check for stack underflow */
 
                 if (walk_state->num_operands == 0) {
@@ -491,9 +491,10 @@ acpi_ds_obj_stack_pop_and_delete(u32 pop_count,
         u32 i;
         union acpi_operand_object *obj_desc;
 
-        ACPI_FUNCTION_NAME("ds_obj_stack_pop_and_delete");
+        ACPI_FUNCTION_NAME(ds_obj_stack_pop_and_delete);
 
         for (i = 0; i < pop_count; i++) {
+
                 /* Check for stack underflow */
 
                 if (walk_state->num_operands == 0) {
@@ -538,13 +539,13 @@ acpi_ds_obj_stack_pop_and_delete(u32 pop_count,
 struct acpi_walk_state *acpi_ds_get_current_walk_state(struct acpi_thread_state
                                                        *thread)
 {
-        ACPI_FUNCTION_NAME("ds_get_current_walk_state");
+        ACPI_FUNCTION_NAME(ds_get_current_walk_state);
 
         if (!thread) {
                 return (NULL);
         }
 
-        ACPI_DEBUG_PRINT((ACPI_DB_PARSE, "Current walk_state %p\n",
+        ACPI_DEBUG_PRINT((ACPI_DB_PARSE, "Current WalkState %p\n",
                           thread->walk_state_list));
 
         return (thread->walk_state_list);
@@ -567,7 +568,7 @@ void
 acpi_ds_push_walk_state(struct acpi_walk_state *walk_state,
                         struct acpi_thread_state *thread)
 {
-        ACPI_FUNCTION_TRACE("ds_push_walk_state");
+        ACPI_FUNCTION_TRACE(ds_push_walk_state);
 
         walk_state->next = thread->walk_state_list;
         thread->walk_state_list = walk_state;
@@ -593,11 +594,12 @@ struct acpi_walk_state *acpi_ds_pop_walk_state(struct acpi_thread_state *thread)
 {
         struct acpi_walk_state *walk_state;
 
-        ACPI_FUNCTION_TRACE("ds_pop_walk_state");
+        ACPI_FUNCTION_TRACE(ds_pop_walk_state);
 
         walk_state = thread->walk_state_list;
 
         if (walk_state) {
+
                 /* Next walk state becomes the current walk state */
 
                 thread->walk_state_list = walk_state->next;
@@ -618,7 +620,7 @@ struct acpi_walk_state *acpi_ds_pop_walk_state(struct acpi_thread_state *thread)
  *
  * PARAMETERS:  owner_id        - ID for object creation
  *              Origin          - Starting point for this walk
- *              mth_desc        - Method object
+ *              method_desc     - Method object
  *              Thread          - Current thread state
  *
  * RETURN:      Pointer to the new walk state.
@@ -632,24 +634,24 @@ struct acpi_walk_state *acpi_ds_create_walk_state(acpi_owner_id owner_id,
                                                   union acpi_parse_object
                                                   *origin,
                                                   union acpi_operand_object
-                                                  *mth_desc,
+                                                  *method_desc,
                                                   struct acpi_thread_state
                                                   *thread)
 {
         struct acpi_walk_state *walk_state;
         acpi_status status;
 
-        ACPI_FUNCTION_TRACE("ds_create_walk_state");
+        ACPI_FUNCTION_TRACE(ds_create_walk_state);
 
-        walk_state = ACPI_MEM_CALLOCATE(sizeof(struct acpi_walk_state));
+        walk_state = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_walk_state));
         if (!walk_state) {
                 return_PTR(NULL);
         }
 
-        walk_state->data_type = ACPI_DESC_TYPE_WALK;
+        walk_state->descriptor_type = ACPI_DESC_TYPE_WALK;
+        walk_state->method_desc = method_desc;
         walk_state->owner_id = owner_id;
         walk_state->origin = origin;
-        walk_state->method_desc = mth_desc;
         walk_state->thread = thread;
 
         walk_state->parser_state.start_op = origin;
@@ -664,7 +666,7 @@ struct acpi_walk_state *acpi_ds_create_walk_state(acpi_owner_id owner_id,
 
         status = acpi_ds_result_stack_push(walk_state);
         if (ACPI_FAILURE(status)) {
-                ACPI_MEM_FREE(walk_state);
+                ACPI_FREE(walk_state);
                 return_PTR(NULL);
         }
 
@@ -701,13 +703,13 @@ acpi_ds_init_aml_walk(struct acpi_walk_state *walk_state,
                       struct acpi_namespace_node *method_node,
                       u8 * aml_start,
                       u32 aml_length,
-                      struct acpi_parameter_info *info, u8 pass_number)
+                      struct acpi_evaluate_info *info, u8 pass_number)
 {
         acpi_status status;
         struct acpi_parse_state *parser_state = &walk_state->parser_state;
         union acpi_parse_object *extra_op;
 
-        ACPI_FUNCTION_TRACE("ds_init_aml_walk");
+        ACPI_FUNCTION_TRACE(ds_init_aml_walk);
 
         walk_state->parser_state.aml =
             walk_state->parser_state.aml_start = aml_start;
@@ -778,6 +780,7 @@ acpi_ds_init_aml_walk(struct acpi_walk_state *walk_state,
                 }
 
                 if (parser_state->start_node) {
+
                         /* Push start scope on scope stack and make it current  */
 
                         status =
@@ -810,21 +813,24 @@ void acpi_ds_delete_walk_state(struct acpi_walk_state *walk_state)
 {
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_delete_walk_state", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_delete_walk_state, walk_state);
 
         if (!walk_state) {
                 return;
         }
 
-        if (walk_state->data_type != ACPI_DESC_TYPE_WALK) {
+        if (walk_state->descriptor_type != ACPI_DESC_TYPE_WALK) {
                 ACPI_ERROR((AE_INFO, "%p is not a valid walk state",
                             walk_state));
                 return;
         }
 
+        /* There should not be any open scopes */
+
         if (walk_state->parser_state.scope) {
                 ACPI_ERROR((AE_INFO, "%p walk still has a scope list",
                             walk_state));
+                acpi_ps_cleanup_scope(&walk_state->parser_state);
         }
 
         /* Always must free any linked control states */
@@ -854,7 +860,7 @@ void acpi_ds_delete_walk_state(struct acpi_walk_state *walk_state)
                 acpi_ut_delete_generic_state(state);
         }
 
-        ACPI_MEM_FREE(walk_state);
+        ACPI_FREE(walk_state);
         return_VOID;
 }
 
@@ -879,7 +885,7 @@ acpi_ds_result_insert(void *object,
 {
         union acpi_generic_state *state;
 
-        ACPI_FUNCTION_NAME("ds_result_insert");
+        ACPI_FUNCTION_NAME(ds_result_insert);
 
         state = walk_state->results;
         if (!state) {
@@ -937,7 +943,7 @@ acpi_status acpi_ds_obj_stack_delete_all(struct acpi_walk_state * walk_state)
 {
         u32 i;
 
-        ACPI_FUNCTION_TRACE_PTR("ds_obj_stack_delete_all", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_obj_stack_delete_all, walk_state);
 
         /* The stack size is configurable, but fixed */
 
@@ -969,7 +975,7 @@ acpi_status
 acpi_ds_obj_stack_pop_object(union acpi_operand_object **object,
                              struct acpi_walk_state *walk_state)
 {
-        ACPI_FUNCTION_NAME("ds_obj_stack_pop_object");
+        ACPI_FUNCTION_NAME(ds_obj_stack_pop_object);
 
         /* Check for stack underflow */
 
@@ -1025,7 +1031,7 @@ acpi_ds_obj_stack_pop_object(union acpi_operand_object **object,
 void *acpi_ds_obj_stack_get_value(u32 index, struct acpi_walk_state *walk_state)
 {
 
-        ACPI_FUNCTION_TRACE_PTR("ds_obj_stack_get_value", walk_state);
+        ACPI_FUNCTION_TRACE_PTR(ds_obj_stack_get_value, walk_state);
 
         /* Can't do it if the stack is empty */