3 files changed, 9 insertions, 26 deletions

diff --git a/crypto/algapi.c b/crypto/algapi.c
index 056571b85445..c3b9bfeeb7ff 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -24,22 +24,6 @@
 
 static LIST_HEAD(crypto_template_list);
 
-void crypto_larval_error(const char *name, u32 type, u32 mask)
-{
-        struct crypto_alg *alg;
-
-        alg = crypto_alg_lookup(name, type, mask);
-
-        if (alg) {
-                if (crypto_is_larval(alg)) {
-                        struct crypto_larval *larval = (void *)alg;
-                        complete_all(&larval->completion);
-                }
-                crypto_mod_put(alg);
-        }
-}
-EXPORT_SYMBOL_GPL(crypto_larval_error);
-
 static inline int crypto_set_driver_name(struct crypto_alg *alg)
 {
         static const char suffix[] = "-generic";
@@ -295,7 +279,6 @@ found:
                                 continue;
 
                         larval->adult = alg;
-                        complete_all(&larval->completion);
                         continue;
                 }
 
diff --git a/crypto/algboss.c b/crypto/algboss.c
index 791d194958fa..f97027e7d996 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -11,6 +11,7 @@
  */
 
 #include <crypto/internal/aead.h>
+#include <linux/completion.h>
 #include <linux/ctype.h>
 #include <linux/err.h>
 #include <linux/init.h>
@@ -47,6 +48,8 @@ struct cryptomgr_param {
         char larval[CRYPTO_MAX_ALG_NAME];
         char template[CRYPTO_MAX_ALG_NAME];
 
+        struct completion *completion;
+
         u32 otype;
         u32 omask;
 };
@@ -66,7 +69,7 @@ static int cryptomgr_probe(void *data)
 
         tmpl = crypto_lookup_template(param->template);
         if (!tmpl)
-                goto err;
+                goto out;
 
         do {
                 if (tmpl->create) {
@@ -83,16 +86,10 @@ static int cryptomgr_probe(void *data)
 
         crypto_tmpl_put(tmpl);
 
-        if (err)
-                goto err;
-
 out:
+        complete(param->completion);
         kfree(param);
         module_put_and_exit(0);
-
-err:
-        crypto_larval_error(param->larval, param->otype, param->omask);
-        goto out;
 }
 
 static int cryptomgr_schedule_probe(struct crypto_larval *larval)
@@ -192,10 +189,14 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
 
         memcpy(param->larval, larval->alg.cra_name, CRYPTO_MAX_ALG_NAME);
 
+        param->completion = &larval->completion;
+
         thread = kthread_run(cryptomgr_probe, param, "cryptomgr_probe");
         if (IS_ERR(thread))
                 goto err_free_param;
 
+        wait_for_completion_interruptible(&larval->completion);
+
         return NOTIFY_STOP;
 
 err_free_param:
diff --git a/crypto/internal.h b/crypto/internal.h
index b865ca1a8613..9ebedae3fb54 100644
--- a/crypto/internal.h
+++ b/crypto/internal.h
@@ -83,7 +83,6 @@ void crypto_exit_compress_ops(struct crypto_tfm *tfm);
 struct crypto_larval *crypto_larval_alloc(const char *name, u32 type, u32 mask);
 void crypto_larval_kill(struct crypto_alg *alg);
 struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask);
-void crypto_larval_error(const char *name, u32 type, u32 mask);
 void crypto_alg_tested(const char *name, int err);
 
 void crypto_remove_spawns(struct crypto_alg *alg, struct list_head *list,