aboutsummaryrefslogtreecommitdiffstats
path: root/block/blk-barrier.c
diff options
context:
space:
mode:
Diffstat (limited to 'block/blk-barrier.c')
-rw-r--r--block/blk-barrier.c20
1 files changed, 10 insertions, 10 deletions
diff --git a/block/blk-barrier.c b/block/blk-barrier.c
index 6e72d661ae42..1d7adc72c95d 100644
--- a/block/blk-barrier.c
+++ b/block/blk-barrier.c
@@ -24,8 +24,8 @@
24int blk_queue_ordered(struct request_queue *q, unsigned ordered, 24int blk_queue_ordered(struct request_queue *q, unsigned ordered,
25 prepare_flush_fn *prepare_flush_fn) 25 prepare_flush_fn *prepare_flush_fn)
26{ 26{
27 if (ordered & (QUEUE_ORDERED_PREFLUSH | QUEUE_ORDERED_POSTFLUSH) && 27 if (!prepare_flush_fn && (ordered & (QUEUE_ORDERED_DO_PREFLUSH |
28 prepare_flush_fn == NULL) { 28 QUEUE_ORDERED_DO_POSTFLUSH))) {
29 printk(KERN_ERR "%s: prepare_flush_fn required\n", __func__); 29 printk(KERN_ERR "%s: prepare_flush_fn required\n", __func__);
30 return -EINVAL; 30 return -EINVAL;
31 } 31 }
@@ -134,7 +134,7 @@ static void queue_flush(struct request_queue *q, unsigned which)
134 struct request *rq; 134 struct request *rq;
135 rq_end_io_fn *end_io; 135 rq_end_io_fn *end_io;
136 136
137 if (which == QUEUE_ORDERED_PREFLUSH) { 137 if (which == QUEUE_ORDERED_DO_PREFLUSH) {
138 rq = &q->pre_flush_rq; 138 rq = &q->pre_flush_rq;
139 end_io = pre_flush_end_io; 139 end_io = pre_flush_end_io;
140 } else { 140 } else {
@@ -167,7 +167,7 @@ static inline struct request *start_ordered(struct request_queue *q,
167 blk_rq_init(q, rq); 167 blk_rq_init(q, rq);
168 if (bio_data_dir(q->orig_bar_rq->bio) == WRITE) 168 if (bio_data_dir(q->orig_bar_rq->bio) == WRITE)
169 rq->cmd_flags |= REQ_RW; 169 rq->cmd_flags |= REQ_RW;
170 if (q->ordered & QUEUE_ORDERED_FUA) 170 if (q->ordered & QUEUE_ORDERED_DO_FUA)
171 rq->cmd_flags |= REQ_FUA; 171 rq->cmd_flags |= REQ_FUA;
172 init_request_from_bio(rq, q->orig_bar_rq->bio); 172 init_request_from_bio(rq, q->orig_bar_rq->bio);
173 rq->end_io = bar_end_io; 173 rq->end_io = bar_end_io;
@@ -181,20 +181,20 @@ static inline struct request *start_ordered(struct request_queue *q,
181 * there will be no data written between the pre and post flush. 181 * there will be no data written between the pre and post flush.
182 * Hence a single flush will suffice. 182 * Hence a single flush will suffice.
183 */ 183 */
184 if ((q->ordered & QUEUE_ORDERED_POSTFLUSH) && !blk_empty_barrier(rq)) 184 if ((q->ordered & QUEUE_ORDERED_DO_POSTFLUSH) && !blk_empty_barrier(rq))
185 queue_flush(q, QUEUE_ORDERED_POSTFLUSH); 185 queue_flush(q, QUEUE_ORDERED_DO_POSTFLUSH);
186 else 186 else
187 q->ordseq |= QUEUE_ORDSEQ_POSTFLUSH; 187 q->ordseq |= QUEUE_ORDSEQ_POSTFLUSH;
188 188
189 elv_insert(q, rq, ELEVATOR_INSERT_FRONT); 189 elv_insert(q, rq, ELEVATOR_INSERT_FRONT);
190 190
191 if (q->ordered & QUEUE_ORDERED_PREFLUSH) { 191 if (q->ordered & QUEUE_ORDERED_DO_PREFLUSH) {
192 queue_flush(q, QUEUE_ORDERED_PREFLUSH); 192 queue_flush(q, QUEUE_ORDERED_DO_PREFLUSH);
193 rq = &q->pre_flush_rq; 193 rq = &q->pre_flush_rq;
194 } else 194 } else
195 q->ordseq |= QUEUE_ORDSEQ_PREFLUSH; 195 q->ordseq |= QUEUE_ORDSEQ_PREFLUSH;
196 196
197 if ((q->ordered & QUEUE_ORDERED_TAG) || q->in_flight == 0) 197 if ((q->ordered & QUEUE_ORDERED_BY_TAG) || q->in_flight == 0)
198 q->ordseq |= QUEUE_ORDSEQ_DRAIN; 198 q->ordseq |= QUEUE_ORDSEQ_DRAIN;
199 else 199 else
200 rq = NULL; 200 rq = NULL;
@@ -237,7 +237,7 @@ int blk_do_ordered(struct request_queue *q, struct request **rqp)
237 rq != &q->pre_flush_rq && rq != &q->post_flush_rq) 237 rq != &q->pre_flush_rq && rq != &q->post_flush_rq)
238 return 1; 238 return 1;
239 239
240 if (q->ordered & QUEUE_ORDERED_TAG) { 240 if (q->ordered & QUEUE_ORDERED_BY_TAG) {
241 /* Ordered by tag. Blocking the next barrier is enough. */ 241 /* Ordered by tag. Blocking the next barrier is enough. */
242 if (is_barrier && rq != &q->bar_rq) 242 if (is_barrier && rq != &q->bar_rq)
243 *rqp = NULL; 243 *rqp = NULL;