diff options
Diffstat (limited to 'arch/x86')
-rw-r--r-- | arch/x86/Kconfig | 1 | ||||
-rw-r--r-- | arch/x86/include/asm/a.out-core.h | 8 | ||||
-rw-r--r-- | arch/x86/include/asm/debugreg.h | 29 | ||||
-rw-r--r-- | arch/x86/include/asm/hw_breakpoint.h | 55 | ||||
-rw-r--r-- | arch/x86/include/asm/processor.h | 8 | ||||
-rw-r--r-- | arch/x86/kernel/Makefile | 2 | ||||
-rw-r--r-- | arch/x86/kernel/hw_breakpoint.c | 391 | ||||
-rw-r--r-- | arch/x86/kernel/kgdb.c | 6 | ||||
-rw-r--r-- | arch/x86/kernel/kprobes.c | 9 | ||||
-rw-r--r-- | arch/x86/kernel/machine_kexec_32.c | 2 | ||||
-rw-r--r-- | arch/x86/kernel/machine_kexec_64.c | 2 | ||||
-rw-r--r-- | arch/x86/kernel/process.c | 22 | ||||
-rw-r--r-- | arch/x86/kernel/process_32.c | 28 | ||||
-rw-r--r-- | arch/x86/kernel/process_64.c | 31 | ||||
-rw-r--r-- | arch/x86/kernel/ptrace.c | 231 | ||||
-rw-r--r-- | arch/x86/kernel/signal.c | 9 | ||||
-rw-r--r-- | arch/x86/kernel/smpboot.c | 3 | ||||
-rw-r--r-- | arch/x86/kernel/traps.c | 73 | ||||
-rw-r--r-- | arch/x86/mm/kmmio.c | 8 | ||||
-rw-r--r-- | arch/x86/power/cpu.c | 24 |
20 files changed, 748 insertions, 194 deletions
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 071c6b0e760c..f46f30d23eb0 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig | |||
@@ -49,6 +49,7 @@ config X86 | |||
49 | select HAVE_KERNEL_GZIP | 49 | select HAVE_KERNEL_GZIP |
50 | select HAVE_KERNEL_BZIP2 | 50 | select HAVE_KERNEL_BZIP2 |
51 | select HAVE_KERNEL_LZMA | 51 | select HAVE_KERNEL_LZMA |
52 | select HAVE_HW_BREAKPOINT | ||
52 | select HAVE_ARCH_KMEMCHECK | 53 | select HAVE_ARCH_KMEMCHECK |
53 | 54 | ||
54 | config OUTPUT_FORMAT | 55 | config OUTPUT_FORMAT |
diff --git a/arch/x86/include/asm/a.out-core.h b/arch/x86/include/asm/a.out-core.h index bb70e397aa84..fc4685dd6e4d 100644 --- a/arch/x86/include/asm/a.out-core.h +++ b/arch/x86/include/asm/a.out-core.h | |||
@@ -32,10 +32,10 @@ static inline void aout_dump_thread(struct pt_regs *regs, struct user *dump) | |||
32 | >> PAGE_SHIFT; | 32 | >> PAGE_SHIFT; |
33 | dump->u_dsize -= dump->u_tsize; | 33 | dump->u_dsize -= dump->u_tsize; |
34 | dump->u_ssize = 0; | 34 | dump->u_ssize = 0; |
35 | dump->u_debugreg[0] = current->thread.debugreg0; | 35 | dump->u_debugreg[0] = current->thread.debugreg[0]; |
36 | dump->u_debugreg[1] = current->thread.debugreg1; | 36 | dump->u_debugreg[1] = current->thread.debugreg[1]; |
37 | dump->u_debugreg[2] = current->thread.debugreg2; | 37 | dump->u_debugreg[2] = current->thread.debugreg[2]; |
38 | dump->u_debugreg[3] = current->thread.debugreg3; | 38 | dump->u_debugreg[3] = current->thread.debugreg[3]; |
39 | dump->u_debugreg[4] = 0; | 39 | dump->u_debugreg[4] = 0; |
40 | dump->u_debugreg[5] = 0; | 40 | dump->u_debugreg[5] = 0; |
41 | dump->u_debugreg[6] = current->thread.debugreg6; | 41 | dump->u_debugreg[6] = current->thread.debugreg6; |
diff --git a/arch/x86/include/asm/debugreg.h b/arch/x86/include/asm/debugreg.h index 3ea6f37be9e2..23439fbb1d0e 100644 --- a/arch/x86/include/asm/debugreg.h +++ b/arch/x86/include/asm/debugreg.h | |||
@@ -18,6 +18,7 @@ | |||
18 | #define DR_TRAP1 (0x2) /* db1 */ | 18 | #define DR_TRAP1 (0x2) /* db1 */ |
19 | #define DR_TRAP2 (0x4) /* db2 */ | 19 | #define DR_TRAP2 (0x4) /* db2 */ |
20 | #define DR_TRAP3 (0x8) /* db3 */ | 20 | #define DR_TRAP3 (0x8) /* db3 */ |
21 | #define DR_TRAP_BITS (DR_TRAP0|DR_TRAP1|DR_TRAP2|DR_TRAP3) | ||
21 | 22 | ||
22 | #define DR_STEP (0x4000) /* single-step */ | 23 | #define DR_STEP (0x4000) /* single-step */ |
23 | #define DR_SWITCH (0x8000) /* task switch */ | 24 | #define DR_SWITCH (0x8000) /* task switch */ |
@@ -49,6 +50,8 @@ | |||
49 | 50 | ||
50 | #define DR_LOCAL_ENABLE_SHIFT 0 /* Extra shift to the local enable bit */ | 51 | #define DR_LOCAL_ENABLE_SHIFT 0 /* Extra shift to the local enable bit */ |
51 | #define DR_GLOBAL_ENABLE_SHIFT 1 /* Extra shift to the global enable bit */ | 52 | #define DR_GLOBAL_ENABLE_SHIFT 1 /* Extra shift to the global enable bit */ |
53 | #define DR_LOCAL_ENABLE (0x1) /* Local enable for reg 0 */ | ||
54 | #define DR_GLOBAL_ENABLE (0x2) /* Global enable for reg 0 */ | ||
52 | #define DR_ENABLE_SIZE 2 /* 2 enable bits per register */ | 55 | #define DR_ENABLE_SIZE 2 /* 2 enable bits per register */ |
53 | 56 | ||
54 | #define DR_LOCAL_ENABLE_MASK (0x55) /* Set local bits for all 4 regs */ | 57 | #define DR_LOCAL_ENABLE_MASK (0x55) /* Set local bits for all 4 regs */ |
@@ -67,4 +70,30 @@ | |||
67 | #define DR_LOCAL_SLOWDOWN (0x100) /* Local slow the pipeline */ | 70 | #define DR_LOCAL_SLOWDOWN (0x100) /* Local slow the pipeline */ |
68 | #define DR_GLOBAL_SLOWDOWN (0x200) /* Global slow the pipeline */ | 71 | #define DR_GLOBAL_SLOWDOWN (0x200) /* Global slow the pipeline */ |
69 | 72 | ||
73 | /* | ||
74 | * HW breakpoint additions | ||
75 | */ | ||
76 | #ifdef __KERNEL__ | ||
77 | |||
78 | /* For process management */ | ||
79 | extern void flush_thread_hw_breakpoint(struct task_struct *tsk); | ||
80 | extern int copy_thread_hw_breakpoint(struct task_struct *tsk, | ||
81 | struct task_struct *child, unsigned long clone_flags); | ||
82 | |||
83 | /* For CPU management */ | ||
84 | extern void load_debug_registers(void); | ||
85 | static inline void hw_breakpoint_disable(void) | ||
86 | { | ||
87 | /* Zero the control register for HW Breakpoint */ | ||
88 | set_debugreg(0UL, 7); | ||
89 | |||
90 | /* Zero-out the individual HW breakpoint address registers */ | ||
91 | set_debugreg(0UL, 0); | ||
92 | set_debugreg(0UL, 1); | ||
93 | set_debugreg(0UL, 2); | ||
94 | set_debugreg(0UL, 3); | ||
95 | } | ||
96 | |||
97 | #endif /* __KERNEL__ */ | ||
98 | |||
70 | #endif /* _ASM_X86_DEBUGREG_H */ | 99 | #endif /* _ASM_X86_DEBUGREG_H */ |
diff --git a/arch/x86/include/asm/hw_breakpoint.h b/arch/x86/include/asm/hw_breakpoint.h new file mode 100644 index 000000000000..1acb4d45de70 --- /dev/null +++ b/arch/x86/include/asm/hw_breakpoint.h | |||
@@ -0,0 +1,55 @@ | |||
1 | #ifndef _I386_HW_BREAKPOINT_H | ||
2 | #define _I386_HW_BREAKPOINT_H | ||
3 | |||
4 | #ifdef __KERNEL__ | ||
5 | #define __ARCH_HW_BREAKPOINT_H | ||
6 | |||
7 | struct arch_hw_breakpoint { | ||
8 | char *name; /* Contains name of the symbol to set bkpt */ | ||
9 | unsigned long address; | ||
10 | u8 len; | ||
11 | u8 type; | ||
12 | }; | ||
13 | |||
14 | #include <linux/kdebug.h> | ||
15 | #include <asm-generic/hw_breakpoint.h> | ||
16 | |||
17 | /* Available HW breakpoint length encodings */ | ||
18 | #define HW_BREAKPOINT_LEN_1 0x40 | ||
19 | #define HW_BREAKPOINT_LEN_2 0x44 | ||
20 | #define HW_BREAKPOINT_LEN_4 0x4c | ||
21 | #define HW_BREAKPOINT_LEN_EXECUTE 0x40 | ||
22 | |||
23 | #ifdef CONFIG_X86_64 | ||
24 | #define HW_BREAKPOINT_LEN_8 0x48 | ||
25 | #endif | ||
26 | |||
27 | /* Available HW breakpoint type encodings */ | ||
28 | |||
29 | /* trigger on instruction execute */ | ||
30 | #define HW_BREAKPOINT_EXECUTE 0x80 | ||
31 | /* trigger on memory write */ | ||
32 | #define HW_BREAKPOINT_WRITE 0x81 | ||
33 | /* trigger on memory read or write */ | ||
34 | #define HW_BREAKPOINT_RW 0x83 | ||
35 | |||
36 | /* Total number of available HW breakpoint registers */ | ||
37 | #define HBP_NUM 4 | ||
38 | |||
39 | extern struct hw_breakpoint *hbp_kernel[HBP_NUM]; | ||
40 | DECLARE_PER_CPU(struct hw_breakpoint*, this_hbp_kernel[HBP_NUM]); | ||
41 | extern unsigned int hbp_user_refcount[HBP_NUM]; | ||
42 | |||
43 | extern void arch_install_thread_hw_breakpoint(struct task_struct *tsk); | ||
44 | extern void arch_uninstall_thread_hw_breakpoint(void); | ||
45 | extern int arch_check_va_in_userspace(unsigned long va, u8 hbp_len); | ||
46 | extern int arch_validate_hwbkpt_settings(struct hw_breakpoint *bp, | ||
47 | struct task_struct *tsk); | ||
48 | extern void arch_update_user_hw_breakpoint(int pos, struct task_struct *tsk); | ||
49 | extern void arch_flush_thread_hw_breakpoint(struct task_struct *tsk); | ||
50 | extern void arch_update_kernel_hw_breakpoint(void *); | ||
51 | extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, | ||
52 | unsigned long val, void *data); | ||
53 | #endif /* __KERNEL__ */ | ||
54 | #endif /* _I386_HW_BREAKPOINT_H */ | ||
55 | |||
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index c7768269b1cf..2b03f700d3f2 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h | |||
@@ -29,6 +29,7 @@ struct mm_struct; | |||
29 | #include <linux/threads.h> | 29 | #include <linux/threads.h> |
30 | #include <linux/init.h> | 30 | #include <linux/init.h> |
31 | 31 | ||
32 | #define HBP_NUM 4 | ||
32 | /* | 33 | /* |
33 | * Default implementation of macro that returns current | 34 | * Default implementation of macro that returns current |
34 | * instruction pointer ("program counter"). | 35 | * instruction pointer ("program counter"). |
@@ -433,12 +434,11 @@ struct thread_struct { | |||
433 | #endif | 434 | #endif |
434 | unsigned long gs; | 435 | unsigned long gs; |
435 | /* Hardware debugging registers: */ | 436 | /* Hardware debugging registers: */ |
436 | unsigned long debugreg0; | 437 | unsigned long debugreg[HBP_NUM]; |
437 | unsigned long debugreg1; | ||
438 | unsigned long debugreg2; | ||
439 | unsigned long debugreg3; | ||
440 | unsigned long debugreg6; | 438 | unsigned long debugreg6; |
441 | unsigned long debugreg7; | 439 | unsigned long debugreg7; |
440 | /* Hardware breakpoint info */ | ||
441 | struct hw_breakpoint *hbp[HBP_NUM]; | ||
442 | /* Fault info: */ | 442 | /* Fault info: */ |
443 | unsigned long cr2; | 443 | unsigned long cr2; |
444 | unsigned long trap_no; | 444 | unsigned long trap_no; |
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 430d5b24af7b..bf04201b6575 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile | |||
@@ -40,7 +40,7 @@ obj-$(CONFIG_X86_64) += sys_x86_64.o x8664_ksyms_64.o | |||
40 | obj-$(CONFIG_X86_64) += syscall_64.o vsyscall_64.o | 40 | obj-$(CONFIG_X86_64) += syscall_64.o vsyscall_64.o |
41 | obj-y += bootflag.o e820.o | 41 | obj-y += bootflag.o e820.o |
42 | obj-y += pci-dma.o quirks.o i8237.o topology.o kdebugfs.o | 42 | obj-y += pci-dma.o quirks.o i8237.o topology.o kdebugfs.o |
43 | obj-y += alternative.o i8253.o pci-nommu.o | 43 | obj-y += alternative.o i8253.o pci-nommu.o hw_breakpoint.o |
44 | obj-y += tsc.o io_delay.o rtc.o | 44 | obj-y += tsc.o io_delay.o rtc.o |
45 | 45 | ||
46 | obj-$(CONFIG_X86_TRAMPOLINE) += trampoline.o | 46 | obj-$(CONFIG_X86_TRAMPOLINE) += trampoline.o |
diff --git a/arch/x86/kernel/hw_breakpoint.c b/arch/x86/kernel/hw_breakpoint.c new file mode 100644 index 000000000000..9316a9de4de3 --- /dev/null +++ b/arch/x86/kernel/hw_breakpoint.c | |||
@@ -0,0 +1,391 @@ | |||
1 | /* | ||
2 | * This program is free software; you can redistribute it and/or modify | ||
3 | * it under the terms of the GNU General Public License as published by | ||
4 | * the Free Software Foundation; either version 2 of the License, or | ||
5 | * (at your option) any later version. | ||
6 | * | ||
7 | * This program is distributed in the hope that it will be useful, | ||
8 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
9 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
10 | * GNU General Public License for more details. | ||
11 | * | ||
12 | * You should have received a copy of the GNU General Public License | ||
13 | * along with this program; if not, write to the Free Software | ||
14 | * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. | ||
15 | * | ||
16 | * Copyright (C) 2007 Alan Stern | ||
17 | * Copyright (C) 2009 IBM Corporation | ||
18 | */ | ||
19 | |||
20 | /* | ||
21 | * HW_breakpoint: a unified kernel/user-space hardware breakpoint facility, | ||
22 | * using the CPU's debug registers. | ||
23 | */ | ||
24 | |||
25 | #include <linux/irqflags.h> | ||
26 | #include <linux/notifier.h> | ||
27 | #include <linux/kallsyms.h> | ||
28 | #include <linux/kprobes.h> | ||
29 | #include <linux/percpu.h> | ||
30 | #include <linux/kdebug.h> | ||
31 | #include <linux/kernel.h> | ||
32 | #include <linux/module.h> | ||
33 | #include <linux/sched.h> | ||
34 | #include <linux/init.h> | ||
35 | #include <linux/smp.h> | ||
36 | |||
37 | #include <asm/hw_breakpoint.h> | ||
38 | #include <asm/processor.h> | ||
39 | #include <asm/debugreg.h> | ||
40 | |||
41 | /* Unmasked kernel DR7 value */ | ||
42 | static unsigned long kdr7; | ||
43 | |||
44 | /* | ||
45 | * Masks for the bits corresponding to registers DR0 - DR3 in DR7 register. | ||
46 | * Used to clear and verify the status of bits corresponding to DR0 - DR3 | ||
47 | */ | ||
48 | static const unsigned long dr7_masks[HBP_NUM] = { | ||
49 | 0x000f0003, /* LEN0, R/W0, G0, L0 */ | ||
50 | 0x00f0000c, /* LEN1, R/W1, G1, L1 */ | ||
51 | 0x0f000030, /* LEN2, R/W2, G2, L2 */ | ||
52 | 0xf00000c0 /* LEN3, R/W3, G3, L3 */ | ||
53 | }; | ||
54 | |||
55 | |||
56 | /* | ||
57 | * Encode the length, type, Exact, and Enable bits for a particular breakpoint | ||
58 | * as stored in debug register 7. | ||
59 | */ | ||
60 | static unsigned long encode_dr7(int drnum, unsigned int len, unsigned int type) | ||
61 | { | ||
62 | unsigned long bp_info; | ||
63 | |||
64 | bp_info = (len | type) & 0xf; | ||
65 | bp_info <<= (DR_CONTROL_SHIFT + drnum * DR_CONTROL_SIZE); | ||
66 | bp_info |= (DR_GLOBAL_ENABLE << (drnum * DR_ENABLE_SIZE)) | | ||
67 | DR_GLOBAL_SLOWDOWN; | ||
68 | return bp_info; | ||
69 | } | ||
70 | |||
71 | void arch_update_kernel_hw_breakpoint(void *unused) | ||
72 | { | ||
73 | struct hw_breakpoint *bp; | ||
74 | int i, cpu = get_cpu(); | ||
75 | unsigned long temp_kdr7 = 0; | ||
76 | |||
77 | /* Don't allow debug exceptions while we update the registers */ | ||
78 | set_debugreg(0UL, 7); | ||
79 | |||
80 | for (i = hbp_kernel_pos; i < HBP_NUM; i++) { | ||
81 | per_cpu(this_hbp_kernel[i], cpu) = bp = hbp_kernel[i]; | ||
82 | if (bp) { | ||
83 | temp_kdr7 |= encode_dr7(i, bp->info.len, bp->info.type); | ||
84 | set_debugreg(bp->info.address, i); | ||
85 | } | ||
86 | } | ||
87 | |||
88 | /* No need to set DR6. Update the debug registers with kernel-space | ||
89 | * breakpoint values from kdr7 and user-space requests from the | ||
90 | * current process | ||
91 | */ | ||
92 | kdr7 = temp_kdr7; | ||
93 | set_debugreg(kdr7 | current->thread.debugreg7, 7); | ||
94 | put_cpu(); | ||
95 | } | ||
96 | |||
97 | /* | ||
98 | * Install the thread breakpoints in their debug registers. | ||
99 | */ | ||
100 | void arch_install_thread_hw_breakpoint(struct task_struct *tsk) | ||
101 | { | ||
102 | struct thread_struct *thread = &(tsk->thread); | ||
103 | |||
104 | switch (hbp_kernel_pos) { | ||
105 | case 4: | ||
106 | set_debugreg(thread->debugreg[3], 3); | ||
107 | case 3: | ||
108 | set_debugreg(thread->debugreg[2], 2); | ||
109 | case 2: | ||
110 | set_debugreg(thread->debugreg[1], 1); | ||
111 | case 1: | ||
112 | set_debugreg(thread->debugreg[0], 0); | ||
113 | default: | ||
114 | break; | ||
115 | } | ||
116 | |||
117 | /* No need to set DR6 */ | ||
118 | set_debugreg((kdr7 | thread->debugreg7), 7); | ||
119 | } | ||
120 | |||
121 | /* | ||
122 | * Install the debug register values for just the kernel, no thread. | ||
123 | */ | ||
124 | void arch_uninstall_thread_hw_breakpoint(void) | ||
125 | { | ||
126 | /* Clear the user-space portion of debugreg7 by setting only kdr7 */ | ||
127 | set_debugreg(kdr7, 7); | ||
128 | |||
129 | } | ||
130 | |||
131 | static int get_hbp_len(u8 hbp_len) | ||
132 | { | ||
133 | unsigned int len_in_bytes = 0; | ||
134 | |||
135 | switch (hbp_len) { | ||
136 | case HW_BREAKPOINT_LEN_1: | ||
137 | len_in_bytes = 1; | ||
138 | break; | ||
139 | case HW_BREAKPOINT_LEN_2: | ||
140 | len_in_bytes = 2; | ||
141 | break; | ||
142 | case HW_BREAKPOINT_LEN_4: | ||
143 | len_in_bytes = 4; | ||
144 | break; | ||
145 | #ifdef CONFIG_X86_64 | ||
146 | case HW_BREAKPOINT_LEN_8: | ||
147 | len_in_bytes = 8; | ||
148 | break; | ||
149 | #endif | ||
150 | } | ||
151 | return len_in_bytes; | ||
152 | } | ||
153 | |||
154 | /* | ||
155 | * Check for virtual address in user space. | ||
156 | */ | ||
157 | int arch_check_va_in_userspace(unsigned long va, u8 hbp_len) | ||
158 | { | ||
159 | unsigned int len; | ||
160 | |||
161 | len = get_hbp_len(hbp_len); | ||
162 | |||
163 | return (va <= TASK_SIZE - len); | ||
164 | } | ||
165 | |||
166 | /* | ||
167 | * Check for virtual address in kernel space. | ||
168 | */ | ||
169 | static int arch_check_va_in_kernelspace(unsigned long va, u8 hbp_len) | ||
170 | { | ||
171 | unsigned int len; | ||
172 | |||
173 | len = get_hbp_len(hbp_len); | ||
174 | |||
175 | return (va >= TASK_SIZE) && ((va + len - 1) >= TASK_SIZE); | ||
176 | } | ||
177 | |||
178 | /* | ||
179 | * Store a breakpoint's encoded address, length, and type. | ||
180 | */ | ||
181 | static int arch_store_info(struct hw_breakpoint *bp, struct task_struct *tsk) | ||
182 | { | ||
183 | /* | ||
184 | * User-space requests will always have the address field populated | ||
185 | * Symbol names from user-space are rejected | ||
186 | */ | ||
187 | if (tsk && bp->info.name) | ||
188 | return -EINVAL; | ||
189 | /* | ||
190 | * For kernel-addresses, either the address or symbol name can be | ||
191 | * specified. | ||
192 | */ | ||
193 | if (bp->info.name) | ||
194 | bp->info.address = (unsigned long) | ||
195 | kallsyms_lookup_name(bp->info.name); | ||
196 | if (bp->info.address) | ||
197 | return 0; | ||
198 | return -EINVAL; | ||
199 | } | ||
200 | |||
201 | /* | ||
202 | * Validate the arch-specific HW Breakpoint register settings | ||
203 | */ | ||
204 | int arch_validate_hwbkpt_settings(struct hw_breakpoint *bp, | ||
205 | struct task_struct *tsk) | ||
206 | { | ||
207 | unsigned int align; | ||
208 | int ret = -EINVAL; | ||
209 | |||
210 | switch (bp->info.type) { | ||
211 | /* | ||
212 | * Ptrace-refactoring code | ||
213 | * For now, we'll allow instruction breakpoint only for user-space | ||
214 | * addresses | ||
215 | */ | ||
216 | case HW_BREAKPOINT_EXECUTE: | ||
217 | if ((!arch_check_va_in_userspace(bp->info.address, | ||
218 | bp->info.len)) && | ||
219 | bp->info.len != HW_BREAKPOINT_LEN_EXECUTE) | ||
220 | return ret; | ||
221 | break; | ||
222 | case HW_BREAKPOINT_WRITE: | ||
223 | break; | ||
224 | case HW_BREAKPOINT_RW: | ||
225 | break; | ||
226 | default: | ||
227 | return ret; | ||
228 | } | ||
229 | |||
230 | switch (bp->info.len) { | ||
231 | case HW_BREAKPOINT_LEN_1: | ||
232 | align = 0; | ||
233 | break; | ||
234 | case HW_BREAKPOINT_LEN_2: | ||
235 | align = 1; | ||
236 | break; | ||
237 | case HW_BREAKPOINT_LEN_4: | ||
238 | align = 3; | ||
239 | break; | ||
240 | #ifdef CONFIG_X86_64 | ||
241 | case HW_BREAKPOINT_LEN_8: | ||
242 | align = 7; | ||
243 | break; | ||
244 | #endif | ||
245 | default: | ||
246 | return ret; | ||
247 | } | ||
248 | |||
249 | if (bp->triggered) | ||
250 | ret = arch_store_info(bp, tsk); | ||
251 | |||
252 | if (ret < 0) | ||
253 | return ret; | ||
254 | /* | ||
255 | * Check that the low-order bits of the address are appropriate | ||
256 | * for the alignment implied by len. | ||
257 | */ | ||
258 | if (bp->info.address & align) | ||
259 | return -EINVAL; | ||
260 | |||
261 | /* Check that the virtual address is in the proper range */ | ||
262 | if (tsk) { | ||
263 | if (!arch_check_va_in_userspace(bp->info.address, bp->info.len)) | ||
264 | return -EFAULT; | ||
265 | } else { | ||
266 | if (!arch_check_va_in_kernelspace(bp->info.address, | ||
267 | bp->info.len)) | ||
268 | return -EFAULT; | ||
269 | } | ||
270 | return 0; | ||
271 | } | ||
272 | |||
273 | void arch_update_user_hw_breakpoint(int pos, struct task_struct *tsk) | ||
274 | { | ||
275 | struct thread_struct *thread = &(tsk->thread); | ||
276 | struct hw_breakpoint *bp = thread->hbp[pos]; | ||
277 | |||
278 | thread->debugreg7 &= ~dr7_masks[pos]; | ||
279 | if (bp) { | ||
280 | thread->debugreg[pos] = bp->info.address; | ||
281 | thread->debugreg7 |= encode_dr7(pos, bp->info.len, | ||
282 | bp->info.type); | ||
283 | } else | ||
284 | thread->debugreg[pos] = 0; | ||
285 | } | ||
286 | |||
287 | void arch_flush_thread_hw_breakpoint(struct task_struct *tsk) | ||
288 | { | ||
289 | int i; | ||
290 | struct thread_struct *thread = &(tsk->thread); | ||
291 | |||
292 | thread->debugreg7 = 0; | ||
293 | for (i = 0; i < HBP_NUM; i++) | ||
294 | thread->debugreg[i] = 0; | ||
295 | } | ||
296 | |||
297 | /* | ||
298 | * Handle debug exception notifications. | ||
299 | * | ||
300 | * Return value is either NOTIFY_STOP or NOTIFY_DONE as explained below. | ||
301 | * | ||
302 | * NOTIFY_DONE returned if one of the following conditions is true. | ||
303 | * i) When the causative address is from user-space and the exception | ||
304 | * is a valid one, i.e. not triggered as a result of lazy debug register | ||
305 | * switching | ||
306 | * ii) When there are more bits than trap<n> set in DR6 register (such | ||
307 | * as BD, BS or BT) indicating that more than one debug condition is | ||
308 | * met and requires some more action in do_debug(). | ||
309 | * | ||
310 | * NOTIFY_STOP returned for all other cases | ||
311 | * | ||
312 | */ | ||
313 | static int __kprobes hw_breakpoint_handler(struct die_args *args) | ||
314 | { | ||
315 | int i, cpu, rc = NOTIFY_STOP; | ||
316 | struct hw_breakpoint *bp; | ||
317 | unsigned long dr7, dr6; | ||
318 | unsigned long *dr6_p; | ||
319 | |||
320 | /* The DR6 value is pointed by args->err */ | ||
321 | dr6_p = (unsigned long *)ERR_PTR(args->err); | ||
322 | dr6 = *dr6_p; | ||
323 | |||
324 | /* Do an early return if no trap bits are set in DR6 */ | ||
325 | if ((dr6 & DR_TRAP_BITS) == 0) | ||
326 | return NOTIFY_DONE; | ||
327 | |||
328 | /* Lazy debug register switching */ | ||
329 | if (!test_tsk_thread_flag(current, TIF_DEBUG)) | ||
330 | arch_uninstall_thread_hw_breakpoint(); | ||
331 | |||
332 | get_debugreg(dr7, 7); | ||
333 | /* Disable breakpoints during exception handling */ | ||
334 | set_debugreg(0UL, 7); | ||
335 | /* | ||
336 | * Assert that local interrupts are disabled | ||
337 | * Reset the DRn bits in the virtualized register value. | ||
338 | * The ptrace trigger routine will add in whatever is needed. | ||
339 | */ | ||
340 | current->thread.debugreg6 &= ~DR_TRAP_BITS; | ||
341 | cpu = get_cpu(); | ||
342 | |||
343 | /* Handle all the breakpoints that were triggered */ | ||
344 | for (i = 0; i < HBP_NUM; ++i) { | ||
345 | if (likely(!(dr6 & (DR_TRAP0 << i)))) | ||
346 | continue; | ||
347 | /* | ||
348 | * Find the corresponding hw_breakpoint structure and | ||
349 | * invoke its triggered callback. | ||
350 | */ | ||
351 | if (i >= hbp_kernel_pos) | ||
352 | bp = per_cpu(this_hbp_kernel[i], cpu); | ||
353 | else { | ||
354 | bp = current->thread.hbp[i]; | ||
355 | if (bp) | ||
356 | rc = NOTIFY_DONE; | ||
357 | } | ||
358 | /* | ||
359 | * Reset the 'i'th TRAP bit in dr6 to denote completion of | ||
360 | * exception handling | ||
361 | */ | ||
362 | (*dr6_p) &= ~(DR_TRAP0 << i); | ||
363 | /* | ||
364 | * bp can be NULL due to lazy debug register switching | ||
365 | * or due to the delay between updates of hbp_kernel_pos | ||
366 | * and this_hbp_kernel. | ||
367 | */ | ||
368 | if (!bp) | ||
369 | continue; | ||
370 | |||
371 | (bp->triggered)(bp, args->regs); | ||
372 | } | ||
373 | if (dr6 & (~DR_TRAP_BITS)) | ||
374 | rc = NOTIFY_DONE; | ||
375 | |||
376 | set_debugreg(dr7, 7); | ||
377 | put_cpu(); | ||
378 | return rc; | ||
379 | } | ||
380 | |||
381 | /* | ||
382 | * Handle debug exception notifications. | ||
383 | */ | ||
384 | int __kprobes hw_breakpoint_exceptions_notify( | ||
385 | struct notifier_block *unused, unsigned long val, void *data) | ||
386 | { | ||
387 | if (val != DIE_DEBUG) | ||
388 | return NOTIFY_DONE; | ||
389 | |||
390 | return hw_breakpoint_handler(data); | ||
391 | } | ||
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c index 8d82a77a3f3b..34e86b67550c 100644 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/kernel/kgdb.c | |||
@@ -43,6 +43,7 @@ | |||
43 | #include <linux/smp.h> | 43 | #include <linux/smp.h> |
44 | #include <linux/nmi.h> | 44 | #include <linux/nmi.h> |
45 | 45 | ||
46 | #include <asm/debugreg.h> | ||
46 | #include <asm/apicdef.h> | 47 | #include <asm/apicdef.h> |
47 | #include <asm/system.h> | 48 | #include <asm/system.h> |
48 | 49 | ||
@@ -434,6 +435,11 @@ single_step_cont(struct pt_regs *regs, struct die_args *args) | |||
434 | "resuming...\n"); | 435 | "resuming...\n"); |
435 | kgdb_arch_handle_exception(args->trapnr, args->signr, | 436 | kgdb_arch_handle_exception(args->trapnr, args->signr, |
436 | args->err, "c", "", regs); | 437 | args->err, "c", "", regs); |
438 | /* | ||
439 | * Reset the BS bit in dr6 (pointed by args->err) to | ||
440 | * denote completion of processing | ||
441 | */ | ||
442 | (*(unsigned long *)ERR_PTR(args->err)) &= ~DR_STEP; | ||
437 | 443 | ||
438 | return NOTIFY_STOP; | 444 | return NOTIFY_STOP; |
439 | } | 445 | } |
diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c index 7b5169d2b000..b5b1848c5336 100644 --- a/arch/x86/kernel/kprobes.c +++ b/arch/x86/kernel/kprobes.c | |||
@@ -54,6 +54,7 @@ | |||
54 | #include <asm/pgtable.h> | 54 | #include <asm/pgtable.h> |
55 | #include <asm/uaccess.h> | 55 | #include <asm/uaccess.h> |
56 | #include <asm/alternative.h> | 56 | #include <asm/alternative.h> |
57 | #include <asm/debugreg.h> | ||
57 | 58 | ||
58 | void jprobe_return_end(void); | 59 | void jprobe_return_end(void); |
59 | 60 | ||
@@ -967,8 +968,14 @@ int __kprobes kprobe_exceptions_notify(struct notifier_block *self, | |||
967 | ret = NOTIFY_STOP; | 968 | ret = NOTIFY_STOP; |
968 | break; | 969 | break; |
969 | case DIE_DEBUG: | 970 | case DIE_DEBUG: |
970 | if (post_kprobe_handler(args->regs)) | 971 | if (post_kprobe_handler(args->regs)) { |
972 | /* | ||
973 | * Reset the BS bit in dr6 (pointed by args->err) to | ||
974 | * denote completion of processing | ||
975 | */ | ||
976 | (*(unsigned long *)ERR_PTR(args->err)) &= ~DR_STEP; | ||
971 | ret = NOTIFY_STOP; | 977 | ret = NOTIFY_STOP; |
978 | } | ||
972 | break; | 979 | break; |
973 | case DIE_GPF: | 980 | case DIE_GPF: |
974 | /* | 981 | /* |
diff --git a/arch/x86/kernel/machine_kexec_32.c b/arch/x86/kernel/machine_kexec_32.c index c1c429d00130..c843f8406da2 100644 --- a/arch/x86/kernel/machine_kexec_32.c +++ b/arch/x86/kernel/machine_kexec_32.c | |||
@@ -25,6 +25,7 @@ | |||
25 | #include <asm/desc.h> | 25 | #include <asm/desc.h> |
26 | #include <asm/system.h> | 26 | #include <asm/system.h> |
27 | #include <asm/cacheflush.h> | 27 | #include <asm/cacheflush.h> |
28 | #include <asm/debugreg.h> | ||
28 | 29 | ||
29 | static void set_idt(void *newidt, __u16 limit) | 30 | static void set_idt(void *newidt, __u16 limit) |
30 | { | 31 | { |
@@ -202,6 +203,7 @@ void machine_kexec(struct kimage *image) | |||
202 | 203 | ||
203 | /* Interrupts aren't acceptable while we reboot */ | 204 | /* Interrupts aren't acceptable while we reboot */ |
204 | local_irq_disable(); | 205 | local_irq_disable(); |
206 | hw_breakpoint_disable(); | ||
205 | 207 | ||
206 | if (image->preserve_context) { | 208 | if (image->preserve_context) { |
207 | #ifdef CONFIG_X86_IO_APIC | 209 | #ifdef CONFIG_X86_IO_APIC |
diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c index 84c3bf209e98..4a8bb82248ae 100644 --- a/arch/x86/kernel/machine_kexec_64.c +++ b/arch/x86/kernel/machine_kexec_64.c | |||
@@ -18,6 +18,7 @@ | |||
18 | #include <asm/pgtable.h> | 18 | #include <asm/pgtable.h> |
19 | #include <asm/tlbflush.h> | 19 | #include <asm/tlbflush.h> |
20 | #include <asm/mmu_context.h> | 20 | #include <asm/mmu_context.h> |
21 | #include <asm/debugreg.h> | ||
21 | 22 | ||
22 | static int init_one_level2_page(struct kimage *image, pgd_t *pgd, | 23 | static int init_one_level2_page(struct kimage *image, pgd_t *pgd, |
23 | unsigned long addr) | 24 | unsigned long addr) |
@@ -282,6 +283,7 @@ void machine_kexec(struct kimage *image) | |||
282 | 283 | ||
283 | /* Interrupts aren't acceptable while we reboot */ | 284 | /* Interrupts aren't acceptable while we reboot */ |
284 | local_irq_disable(); | 285 | local_irq_disable(); |
286 | hw_breakpoint_disable(); | ||
285 | 287 | ||
286 | if (image->preserve_context) { | 288 | if (image->preserve_context) { |
287 | #ifdef CONFIG_X86_IO_APIC | 289 | #ifdef CONFIG_X86_IO_APIC |
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 071166a4ba83..1092a1a2fbe6 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c | |||
@@ -17,6 +17,8 @@ | |||
17 | #include <asm/uaccess.h> | 17 | #include <asm/uaccess.h> |
18 | #include <asm/i387.h> | 18 | #include <asm/i387.h> |
19 | #include <asm/ds.h> | 19 | #include <asm/ds.h> |
20 | #include <asm/debugreg.h> | ||
21 | #include <asm/hw_breakpoint.h> | ||
20 | 22 | ||
21 | unsigned long idle_halt; | 23 | unsigned long idle_halt; |
22 | EXPORT_SYMBOL(idle_halt); | 24 | EXPORT_SYMBOL(idle_halt); |
@@ -48,6 +50,8 @@ void free_thread_xstate(struct task_struct *tsk) | |||
48 | kmem_cache_free(task_xstate_cachep, tsk->thread.xstate); | 50 | kmem_cache_free(task_xstate_cachep, tsk->thread.xstate); |
49 | tsk->thread.xstate = NULL; | 51 | tsk->thread.xstate = NULL; |
50 | } | 52 | } |
53 | if (unlikely(test_tsk_thread_flag(tsk, TIF_DEBUG))) | ||
54 | flush_thread_hw_breakpoint(tsk); | ||
51 | 55 | ||
52 | WARN(tsk->thread.ds_ctx, "leaking DS context\n"); | 56 | WARN(tsk->thread.ds_ctx, "leaking DS context\n"); |
53 | } | 57 | } |
@@ -108,12 +112,8 @@ void flush_thread(void) | |||
108 | 112 | ||
109 | clear_tsk_thread_flag(tsk, TIF_DEBUG); | 113 | clear_tsk_thread_flag(tsk, TIF_DEBUG); |
110 | 114 | ||
111 | tsk->thread.debugreg0 = 0; | 115 | if (unlikely(test_tsk_thread_flag(tsk, TIF_DEBUG))) |
112 | tsk->thread.debugreg1 = 0; | 116 | flush_thread_hw_breakpoint(tsk); |
113 | tsk->thread.debugreg2 = 0; | ||
114 | tsk->thread.debugreg3 = 0; | ||
115 | tsk->thread.debugreg6 = 0; | ||
116 | tsk->thread.debugreg7 = 0; | ||
117 | memset(tsk->thread.tls_array, 0, sizeof(tsk->thread.tls_array)); | 117 | memset(tsk->thread.tls_array, 0, sizeof(tsk->thread.tls_array)); |
118 | /* | 118 | /* |
119 | * Forget coprocessor state.. | 119 | * Forget coprocessor state.. |
@@ -195,16 +195,6 @@ void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p, | |||
195 | else if (next->debugctlmsr != prev->debugctlmsr) | 195 | else if (next->debugctlmsr != prev->debugctlmsr) |
196 | update_debugctlmsr(next->debugctlmsr); | 196 | update_debugctlmsr(next->debugctlmsr); |
197 | 197 | ||
198 | if (test_tsk_thread_flag(next_p, TIF_DEBUG)) { | ||
199 | set_debugreg(next->debugreg0, 0); | ||
200 | set_debugreg(next->debugreg1, 1); | ||
201 | set_debugreg(next->debugreg2, 2); | ||
202 | set_debugreg(next->debugreg3, 3); | ||
203 | /* no 4 and 5 */ | ||
204 | set_debugreg(next->debugreg6, 6); | ||
205 | set_debugreg(next->debugreg7, 7); | ||
206 | } | ||
207 | |||
208 | if (test_tsk_thread_flag(prev_p, TIF_NOTSC) ^ | 198 | if (test_tsk_thread_flag(prev_p, TIF_NOTSC) ^ |
209 | test_tsk_thread_flag(next_p, TIF_NOTSC)) { | 199 | test_tsk_thread_flag(next_p, TIF_NOTSC)) { |
210 | /* prev and next are different */ | 200 | /* prev and next are different */ |
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c index 59f4524984af..00a8fe4c58bb 100644 --- a/arch/x86/kernel/process_32.c +++ b/arch/x86/kernel/process_32.c | |||
@@ -58,6 +58,8 @@ | |||
58 | #include <asm/idle.h> | 58 | #include <asm/idle.h> |
59 | #include <asm/syscalls.h> | 59 | #include <asm/syscalls.h> |
60 | #include <asm/ds.h> | 60 | #include <asm/ds.h> |
61 | #include <asm/debugreg.h> | ||
62 | #include <asm/hw_breakpoint.h> | ||
61 | 63 | ||
62 | asmlinkage void ret_from_fork(void) __asm__("ret_from_fork"); | 64 | asmlinkage void ret_from_fork(void) __asm__("ret_from_fork"); |
63 | 65 | ||
@@ -262,7 +264,13 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, | |||
262 | 264 | ||
263 | task_user_gs(p) = get_user_gs(regs); | 265 | task_user_gs(p) = get_user_gs(regs); |
264 | 266 | ||
267 | p->thread.io_bitmap_ptr = NULL; | ||
265 | tsk = current; | 268 | tsk = current; |
269 | err = -ENOMEM; | ||
270 | if (unlikely(test_tsk_thread_flag(tsk, TIF_DEBUG))) | ||
271 | if (copy_thread_hw_breakpoint(tsk, p, clone_flags)) | ||
272 | goto out; | ||
273 | |||
266 | if (unlikely(test_tsk_thread_flag(tsk, TIF_IO_BITMAP))) { | 274 | if (unlikely(test_tsk_thread_flag(tsk, TIF_IO_BITMAP))) { |
267 | p->thread.io_bitmap_ptr = kmemdup(tsk->thread.io_bitmap_ptr, | 275 | p->thread.io_bitmap_ptr = kmemdup(tsk->thread.io_bitmap_ptr, |
268 | IO_BITMAP_BYTES, GFP_KERNEL); | 276 | IO_BITMAP_BYTES, GFP_KERNEL); |
@@ -282,10 +290,13 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, | |||
282 | err = do_set_thread_area(p, -1, | 290 | err = do_set_thread_area(p, -1, |
283 | (struct user_desc __user *)childregs->si, 0); | 291 | (struct user_desc __user *)childregs->si, 0); |
284 | 292 | ||
293 | out: | ||
285 | if (err && p->thread.io_bitmap_ptr) { | 294 | if (err && p->thread.io_bitmap_ptr) { |
286 | kfree(p->thread.io_bitmap_ptr); | 295 | kfree(p->thread.io_bitmap_ptr); |
287 | p->thread.io_bitmap_max = 0; | 296 | p->thread.io_bitmap_max = 0; |
288 | } | 297 | } |
298 | if (err) | ||
299 | flush_thread_hw_breakpoint(p); | ||
289 | 300 | ||
290 | clear_tsk_thread_flag(p, TIF_DS_AREA_MSR); | 301 | clear_tsk_thread_flag(p, TIF_DS_AREA_MSR); |
291 | p->thread.ds_ctx = NULL; | 302 | p->thread.ds_ctx = NULL; |
@@ -424,6 +435,23 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) | |||
424 | lazy_load_gs(next->gs); | 435 | lazy_load_gs(next->gs); |
425 | 436 | ||
426 | percpu_write(current_task, next_p); | 437 | percpu_write(current_task, next_p); |
438 | /* | ||
439 | * There's a problem with moving the arch_install_thread_hw_breakpoint() | ||
440 | * call before current is updated. Suppose a kernel breakpoint is | ||
441 | * triggered in between the two, the hw-breakpoint handler will see that | ||
442 | * the 'current' task does not have TIF_DEBUG flag set and will think it | ||
443 | * is leftover from an old task (lazy switching) and will erase it. Then | ||
444 | * until the next context switch, no user-breakpoints will be installed. | ||
445 | * | ||
446 | * The real problem is that it's impossible to update both current and | ||
447 | * physical debug registers at the same instant, so there will always be | ||
448 | * a window in which they disagree and a breakpoint might get triggered. | ||
449 | * Since we use lazy switching, we are forced to assume that a | ||
450 | * disagreement means that current is correct and the exception is due | ||
451 | * to lazy debug register switching. | ||
452 | */ | ||
453 | if (unlikely(test_tsk_thread_flag(next_p, TIF_DEBUG))) | ||
454 | arch_install_thread_hw_breakpoint(next_p); | ||
427 | 455 | ||
428 | return prev_p; | 456 | return prev_p; |
429 | } | 457 | } |
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index ebefb5407b9d..89c46f1259d3 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c | |||
@@ -52,6 +52,8 @@ | |||
52 | #include <asm/idle.h> | 52 | #include <asm/idle.h> |
53 | #include <asm/syscalls.h> | 53 | #include <asm/syscalls.h> |
54 | #include <asm/ds.h> | 54 | #include <asm/ds.h> |
55 | #include <asm/debugreg.h> | ||
56 | #include <asm/hw_breakpoint.h> | ||
55 | 57 | ||
56 | asmlinkage extern void ret_from_fork(void); | 58 | asmlinkage extern void ret_from_fork(void); |
57 | 59 | ||
@@ -245,6 +247,8 @@ void release_thread(struct task_struct *dead_task) | |||
245 | BUG(); | 247 | BUG(); |
246 | } | 248 | } |
247 | } | 249 | } |
250 | if (unlikely(dead_task->thread.debugreg7)) | ||
251 | flush_thread_hw_breakpoint(dead_task); | ||
248 | } | 252 | } |
249 | 253 | ||
250 | static inline void set_32bit_tls(struct task_struct *t, int tls, u32 addr) | 254 | static inline void set_32bit_tls(struct task_struct *t, int tls, u32 addr) |
@@ -300,12 +304,18 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, | |||
300 | 304 | ||
301 | p->thread.fs = me->thread.fs; | 305 | p->thread.fs = me->thread.fs; |
302 | p->thread.gs = me->thread.gs; | 306 | p->thread.gs = me->thread.gs; |
307 | p->thread.io_bitmap_ptr = NULL; | ||
303 | 308 | ||
304 | savesegment(gs, p->thread.gsindex); | 309 | savesegment(gs, p->thread.gsindex); |
305 | savesegment(fs, p->thread.fsindex); | 310 | savesegment(fs, p->thread.fsindex); |
306 | savesegment(es, p->thread.es); | 311 | savesegment(es, p->thread.es); |
307 | savesegment(ds, p->thread.ds); | 312 | savesegment(ds, p->thread.ds); |
308 | 313 | ||
314 | err = -ENOMEM; | ||
315 | if (unlikely(test_tsk_thread_flag(me, TIF_DEBUG))) | ||
316 | if (copy_thread_hw_breakpoint(me, p, clone_flags)) | ||
317 | goto out; | ||
318 | |||
309 | if (unlikely(test_tsk_thread_flag(me, TIF_IO_BITMAP))) { | 319 | if (unlikely(test_tsk_thread_flag(me, TIF_IO_BITMAP))) { |
310 | p->thread.io_bitmap_ptr = kmalloc(IO_BITMAP_BYTES, GFP_KERNEL); | 320 | p->thread.io_bitmap_ptr = kmalloc(IO_BITMAP_BYTES, GFP_KERNEL); |
311 | if (!p->thread.io_bitmap_ptr) { | 321 | if (!p->thread.io_bitmap_ptr) { |
@@ -344,6 +354,9 @@ out: | |||
344 | kfree(p->thread.io_bitmap_ptr); | 354 | kfree(p->thread.io_bitmap_ptr); |
345 | p->thread.io_bitmap_max = 0; | 355 | p->thread.io_bitmap_max = 0; |
346 | } | 356 | } |
357 | if (err) | ||
358 | flush_thread_hw_breakpoint(p); | ||
359 | |||
347 | return err; | 360 | return err; |
348 | } | 361 | } |
349 | 362 | ||
@@ -489,6 +502,24 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) | |||
489 | */ | 502 | */ |
490 | if (tsk_used_math(next_p) && next_p->fpu_counter > 5) | 503 | if (tsk_used_math(next_p) && next_p->fpu_counter > 5) |
491 | math_state_restore(); | 504 | math_state_restore(); |
505 | /* | ||
506 | * There's a problem with moving the arch_install_thread_hw_breakpoint() | ||
507 | * call before current is updated. Suppose a kernel breakpoint is | ||
508 | * triggered in between the two, the hw-breakpoint handler will see that | ||
509 | * the 'current' task does not have TIF_DEBUG flag set and will think it | ||
510 | * is leftover from an old task (lazy switching) and will erase it. Then | ||
511 | * until the next context switch, no user-breakpoints will be installed. | ||
512 | * | ||
513 | * The real problem is that it's impossible to update both current and | ||
514 | * physical debug registers at the same instant, so there will always be | ||
515 | * a window in which they disagree and a breakpoint might get triggered. | ||
516 | * Since we use lazy switching, we are forced to assume that a | ||
517 | * disagreement means that current is correct and the exception is due | ||
518 | * to lazy debug register switching. | ||
519 | */ | ||
520 | if (unlikely(test_tsk_thread_flag(next_p, TIF_DEBUG))) | ||
521 | arch_install_thread_hw_breakpoint(next_p); | ||
522 | |||
492 | return prev_p; | 523 | return prev_p; |
493 | } | 524 | } |
494 | 525 | ||
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index 8d7d5c9c1be3..113b8927c822 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c | |||
@@ -34,6 +34,7 @@ | |||
34 | #include <asm/prctl.h> | 34 | #include <asm/prctl.h> |
35 | #include <asm/proto.h> | 35 | #include <asm/proto.h> |
36 | #include <asm/ds.h> | 36 | #include <asm/ds.h> |
37 | #include <asm/hw_breakpoint.h> | ||
37 | 38 | ||
38 | #include "tls.h" | 39 | #include "tls.h" |
39 | 40 | ||
@@ -137,11 +138,6 @@ static int set_segment_reg(struct task_struct *task, | |||
137 | return 0; | 138 | return 0; |
138 | } | 139 | } |
139 | 140 | ||
140 | static unsigned long debugreg_addr_limit(struct task_struct *task) | ||
141 | { | ||
142 | return TASK_SIZE - 3; | ||
143 | } | ||
144 | |||
145 | #else /* CONFIG_X86_64 */ | 141 | #else /* CONFIG_X86_64 */ |
146 | 142 | ||
147 | #define FLAG_MASK (FLAG_MASK_32 | X86_EFLAGS_NT) | 143 | #define FLAG_MASK (FLAG_MASK_32 | X86_EFLAGS_NT) |
@@ -266,15 +262,6 @@ static int set_segment_reg(struct task_struct *task, | |||
266 | return 0; | 262 | return 0; |
267 | } | 263 | } |
268 | 264 | ||
269 | static unsigned long debugreg_addr_limit(struct task_struct *task) | ||
270 | { | ||
271 | #ifdef CONFIG_IA32_EMULATION | ||
272 | if (test_tsk_thread_flag(task, TIF_IA32)) | ||
273 | return IA32_PAGE_OFFSET - 3; | ||
274 | #endif | ||
275 | return TASK_SIZE_MAX - 7; | ||
276 | } | ||
277 | |||
278 | #endif /* CONFIG_X86_32 */ | 265 | #endif /* CONFIG_X86_32 */ |
279 | 266 | ||
280 | static unsigned long get_flags(struct task_struct *task) | 267 | static unsigned long get_flags(struct task_struct *task) |
@@ -465,95 +452,159 @@ static int genregs_set(struct task_struct *target, | |||
465 | } | 452 | } |
466 | 453 | ||
467 | /* | 454 | /* |
468 | * This function is trivial and will be inlined by the compiler. | 455 | * Decode the length and type bits for a particular breakpoint as |
469 | * Having it separates the implementation details of debug | 456 | * stored in debug register 7. Return the "enabled" status. |
470 | * registers from the interface details of ptrace. | ||
471 | */ | 457 | */ |
472 | static unsigned long ptrace_get_debugreg(struct task_struct *child, int n) | 458 | static int decode_dr7(unsigned long dr7, int bpnum, unsigned *len, |
459 | unsigned *type) | ||
473 | { | 460 | { |
474 | switch (n) { | 461 | int bp_info = dr7 >> (DR_CONTROL_SHIFT + bpnum * DR_CONTROL_SIZE); |
475 | case 0: return child->thread.debugreg0; | 462 | |
476 | case 1: return child->thread.debugreg1; | 463 | *len = (bp_info & 0xc) | 0x40; |
477 | case 2: return child->thread.debugreg2; | 464 | *type = (bp_info & 0x3) | 0x80; |
478 | case 3: return child->thread.debugreg3; | 465 | return (dr7 >> (bpnum * DR_ENABLE_SIZE)) & 0x3; |
479 | case 6: return child->thread.debugreg6; | ||
480 | case 7: return child->thread.debugreg7; | ||
481 | } | ||
482 | return 0; | ||
483 | } | 466 | } |
484 | 467 | ||
485 | static int ptrace_set_debugreg(struct task_struct *child, | 468 | static void ptrace_triggered(struct hw_breakpoint *bp, struct pt_regs *regs) |
486 | int n, unsigned long data) | ||
487 | { | 469 | { |
470 | struct thread_struct *thread = &(current->thread); | ||
488 | int i; | 471 | int i; |
489 | 472 | ||
490 | if (unlikely(n == 4 || n == 5)) | 473 | /* |
491 | return -EIO; | 474 | * Store in the virtual DR6 register the fact that the breakpoint |
475 | * was hit so the thread's debugger will see it. | ||
476 | */ | ||
477 | for (i = 0; i < hbp_kernel_pos; i++) | ||
478 | /* | ||
479 | * We will check bp->info.address against the address stored in | ||
480 | * thread's hbp structure and not debugreg[i]. This is to ensure | ||
481 | * that the corresponding bit for 'i' in DR7 register is enabled | ||
482 | */ | ||
483 | if (bp->info.address == thread->hbp[i]->info.address) | ||
484 | break; | ||
492 | 485 | ||
493 | if (n < 4 && unlikely(data >= debugreg_addr_limit(child))) | 486 | thread->debugreg6 |= (DR_TRAP0 << i); |
494 | return -EIO; | 487 | } |
495 | 488 | ||
496 | switch (n) { | 489 | /* |
497 | case 0: child->thread.debugreg0 = data; break; | 490 | * Handle ptrace writes to debug register 7. |
498 | case 1: child->thread.debugreg1 = data; break; | 491 | */ |
499 | case 2: child->thread.debugreg2 = data; break; | 492 | static int ptrace_write_dr7(struct task_struct *tsk, unsigned long data) |
500 | case 3: child->thread.debugreg3 = data; break; | 493 | { |
494 | struct thread_struct *thread = &(tsk->thread); | ||
495 | unsigned long old_dr7 = thread->debugreg7; | ||
496 | int i, orig_ret = 0, rc = 0; | ||
497 | int enabled, second_pass = 0; | ||
498 | unsigned len, type; | ||
499 | struct hw_breakpoint *bp; | ||
500 | |||
501 | data &= ~DR_CONTROL_RESERVED; | ||
502 | restore: | ||
503 | /* | ||
504 | * Loop through all the hardware breakpoints, making the | ||
505 | * appropriate changes to each. | ||
506 | */ | ||
507 | for (i = 0; i < HBP_NUM; i++) { | ||
508 | enabled = decode_dr7(data, i, &len, &type); | ||
509 | bp = thread->hbp[i]; | ||
510 | |||
511 | if (!enabled) { | ||
512 | if (bp) { | ||
513 | /* Don't unregister the breakpoints right-away, | ||
514 | * unless all register_user_hw_breakpoint() | ||
515 | * requests have succeeded. This prevents | ||
516 | * any window of opportunity for debug | ||
517 | * register grabbing by other users. | ||
518 | */ | ||
519 | if (!second_pass) | ||
520 | continue; | ||
521 | unregister_user_hw_breakpoint(tsk, bp); | ||
522 | kfree(bp); | ||
523 | } | ||
524 | continue; | ||
525 | } | ||
526 | if (!bp) { | ||
527 | rc = -ENOMEM; | ||
528 | bp = kzalloc(sizeof(struct hw_breakpoint), GFP_KERNEL); | ||
529 | if (bp) { | ||
530 | bp->info.address = thread->debugreg[i]; | ||
531 | bp->triggered = ptrace_triggered; | ||
532 | bp->info.len = len; | ||
533 | bp->info.type = type; | ||
534 | rc = register_user_hw_breakpoint(tsk, bp); | ||
535 | if (rc) | ||
536 | kfree(bp); | ||
537 | } | ||
538 | } else | ||
539 | rc = modify_user_hw_breakpoint(tsk, bp); | ||
540 | if (rc) | ||
541 | break; | ||
542 | } | ||
543 | /* | ||
544 | * Make a second pass to free the remaining unused breakpoints | ||
545 | * or to restore the original breakpoints if an error occurred. | ||
546 | */ | ||
547 | if (!second_pass) { | ||
548 | second_pass = 1; | ||
549 | if (rc < 0) { | ||
550 | orig_ret = rc; | ||
551 | data = old_dr7; | ||
552 | } | ||
553 | goto restore; | ||
554 | } | ||
555 | return ((orig_ret < 0) ? orig_ret : rc); | ||
556 | } | ||
501 | 557 | ||
502 | case 6: | 558 | /* |
503 | if ((data & ~0xffffffffUL) != 0) | 559 | * Handle PTRACE_PEEKUSR calls for the debug register area. |
504 | return -EIO; | 560 | */ |
505 | child->thread.debugreg6 = data; | 561 | static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n) |
506 | break; | 562 | { |
563 | struct thread_struct *thread = &(tsk->thread); | ||
564 | unsigned long val = 0; | ||
565 | |||
566 | if (n < HBP_NUM) | ||
567 | val = thread->debugreg[n]; | ||
568 | else if (n == 6) | ||
569 | val = thread->debugreg6; | ||
570 | else if (n == 7) | ||
571 | val = thread->debugreg7; | ||
572 | return val; | ||
573 | } | ||
507 | 574 | ||
508 | case 7: | 575 | /* |
509 | /* | 576 | * Handle PTRACE_POKEUSR calls for the debug register area. |
510 | * Sanity-check data. Take one half-byte at once with | 577 | */ |
511 | * check = (val >> (16 + 4*i)) & 0xf. It contains the | 578 | int ptrace_set_debugreg(struct task_struct *tsk, int n, unsigned long val) |
512 | * R/Wi and LENi bits; bits 0 and 1 are R/Wi, and bits | 579 | { |
513 | * 2 and 3 are LENi. Given a list of invalid values, | 580 | struct thread_struct *thread = &(tsk->thread); |
514 | * we do mask |= 1 << invalid_value, so that | 581 | int rc = 0; |
515 | * (mask >> check) & 1 is a correct test for invalid | 582 | |
516 | * values. | 583 | /* There are no DR4 or DR5 registers */ |
517 | * | 584 | if (n == 4 || n == 5) |
518 | * R/Wi contains the type of the breakpoint / | 585 | return -EIO; |
519 | * watchpoint, LENi contains the length of the watched | 586 | |
520 | * data in the watchpoint case. | 587 | if (n == 6) { |
521 | * | 588 | tsk->thread.debugreg6 = val; |
522 | * The invalid values are: | 589 | goto ret_path; |
523 | * - LENi == 0x10 (undefined), so mask |= 0x0f00. [32-bit] | ||
524 | * - R/Wi == 0x10 (break on I/O reads or writes), so | ||
525 | * mask |= 0x4444. | ||
526 | * - R/Wi == 0x00 && LENi != 0x00, so we have mask |= | ||
527 | * 0x1110. | ||
528 | * | ||
529 | * Finally, mask = 0x0f00 | 0x4444 | 0x1110 == 0x5f54. | ||
530 | * | ||
531 | * See the Intel Manual "System Programming Guide", | ||
532 | * 15.2.4 | ||
533 | * | ||
534 | * Note that LENi == 0x10 is defined on x86_64 in long | ||
535 | * mode (i.e. even for 32-bit userspace software, but | ||
536 | * 64-bit kernel), so the x86_64 mask value is 0x5454. | ||
537 | * See the AMD manual no. 24593 (AMD64 System Programming) | ||
538 | */ | ||
539 | #ifdef CONFIG_X86_32 | ||
540 | #define DR7_MASK 0x5f54 | ||
541 | #else | ||
542 | #define DR7_MASK 0x5554 | ||
543 | #endif | ||
544 | data &= ~DR_CONTROL_RESERVED; | ||
545 | for (i = 0; i < 4; i++) | ||
546 | if ((DR7_MASK >> ((data >> (16 + 4*i)) & 0xf)) & 1) | ||
547 | return -EIO; | ||
548 | child->thread.debugreg7 = data; | ||
549 | if (data) | ||
550 | set_tsk_thread_flag(child, TIF_DEBUG); | ||
551 | else | ||
552 | clear_tsk_thread_flag(child, TIF_DEBUG); | ||
553 | break; | ||
554 | } | 590 | } |
591 | if (n < HBP_NUM) { | ||
592 | if (thread->hbp[n]) { | ||
593 | if (arch_check_va_in_userspace(val, | ||
594 | thread->hbp[n]->info.len) == 0) { | ||
595 | rc = -EIO; | ||
596 | goto ret_path; | ||
597 | } | ||
598 | thread->hbp[n]->info.address = val; | ||
599 | } | ||
600 | thread->debugreg[n] = val; | ||
601 | } | ||
602 | /* All that's left is DR7 */ | ||
603 | if (n == 7) | ||
604 | rc = ptrace_write_dr7(tsk, val); | ||
555 | 605 | ||
556 | return 0; | 606 | ret_path: |
607 | return rc; | ||
557 | } | 608 | } |
558 | 609 | ||
559 | /* | 610 | /* |
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c index 4c578751e94e..0f89a4f20db2 100644 --- a/arch/x86/kernel/signal.c +++ b/arch/x86/kernel/signal.c | |||
@@ -799,15 +799,6 @@ static void do_signal(struct pt_regs *regs) | |||
799 | 799 | ||
800 | signr = get_signal_to_deliver(&info, &ka, regs, NULL); | 800 | signr = get_signal_to_deliver(&info, &ka, regs, NULL); |
801 | if (signr > 0) { | 801 | if (signr > 0) { |
802 | /* | ||
803 | * Re-enable any watchpoints before delivering the | ||
804 | * signal to user space. The processor register will | ||
805 | * have been cleared if the watchpoint triggered | ||
806 | * inside the kernel. | ||
807 | */ | ||
808 | if (current->thread.debugreg7) | ||
809 | set_debugreg(current->thread.debugreg7, 7); | ||
810 | |||
811 | /* Whee! Actually deliver the signal. */ | 802 | /* Whee! Actually deliver the signal. */ |
812 | if (handle_signal(signr, &info, &ka, oldset, regs) == 0) { | 803 | if (handle_signal(signr, &info, &ka, oldset, regs) == 0) { |
813 | /* | 804 | /* |
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 2fecda69ee64..dee0f3d814af 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c | |||
@@ -63,6 +63,7 @@ | |||
63 | #include <asm/apic.h> | 63 | #include <asm/apic.h> |
64 | #include <asm/setup.h> | 64 | #include <asm/setup.h> |
65 | #include <asm/uv/uv.h> | 65 | #include <asm/uv/uv.h> |
66 | #include <asm/debugreg.h> | ||
66 | #include <linux/mc146818rtc.h> | 67 | #include <linux/mc146818rtc.h> |
67 | 68 | ||
68 | #include <asm/smpboot_hooks.h> | 69 | #include <asm/smpboot_hooks.h> |
@@ -326,6 +327,7 @@ notrace static void __cpuinit start_secondary(void *unused) | |||
326 | setup_secondary_clock(); | 327 | setup_secondary_clock(); |
327 | 328 | ||
328 | wmb(); | 329 | wmb(); |
330 | load_debug_registers(); | ||
329 | cpu_idle(); | 331 | cpu_idle(); |
330 | } | 332 | } |
331 | 333 | ||
@@ -1254,6 +1256,7 @@ void cpu_disable_common(void) | |||
1254 | remove_cpu_from_maps(cpu); | 1256 | remove_cpu_from_maps(cpu); |
1255 | unlock_vector_lock(); | 1257 | unlock_vector_lock(); |
1256 | fixup_irqs(); | 1258 | fixup_irqs(); |
1259 | hw_breakpoint_disable(); | ||
1257 | } | 1260 | } |
1258 | 1261 | ||
1259 | int native_cpu_disable(void) | 1262 | int native_cpu_disable(void) |
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 5204332f475d..ae04589a579b 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c | |||
@@ -532,77 +532,56 @@ asmlinkage __kprobes struct pt_regs *sync_regs(struct pt_regs *eregs) | |||
532 | dotraplinkage void __kprobes do_debug(struct pt_regs *regs, long error_code) | 532 | dotraplinkage void __kprobes do_debug(struct pt_regs *regs, long error_code) |
533 | { | 533 | { |
534 | struct task_struct *tsk = current; | 534 | struct task_struct *tsk = current; |
535 | unsigned long condition; | 535 | unsigned long dr6; |
536 | int si_code; | 536 | int si_code; |
537 | 537 | ||
538 | get_debugreg(condition, 6); | 538 | get_debugreg(dr6, 6); |
539 | 539 | ||
540 | /* Catch kmemcheck conditions first of all! */ | 540 | /* Catch kmemcheck conditions first of all! */ |
541 | if (condition & DR_STEP && kmemcheck_trap(regs)) | 541 | if ((dr6 & DR_STEP) && kmemcheck_trap(regs)) |
542 | return; | 542 | return; |
543 | 543 | ||
544 | /* DR6 may or may not be cleared by the CPU */ | ||
545 | set_debugreg(0, 6); | ||
544 | /* | 546 | /* |
545 | * The processor cleared BTF, so don't mark that we need it set. | 547 | * The processor cleared BTF, so don't mark that we need it set. |
546 | */ | 548 | */ |
547 | clear_tsk_thread_flag(tsk, TIF_DEBUGCTLMSR); | 549 | clear_tsk_thread_flag(tsk, TIF_DEBUGCTLMSR); |
548 | tsk->thread.debugctlmsr = 0; | 550 | tsk->thread.debugctlmsr = 0; |
549 | 551 | ||
550 | if (notify_die(DIE_DEBUG, "debug", regs, condition, error_code, | 552 | /* Store the virtualized DR6 value */ |
551 | SIGTRAP) == NOTIFY_STOP) | 553 | tsk->thread.debugreg6 = dr6; |
554 | |||
555 | if (notify_die(DIE_DEBUG, "debug", regs, PTR_ERR(&dr6), error_code, | ||
556 | SIGTRAP) == NOTIFY_STOP) | ||
552 | return; | 557 | return; |
553 | 558 | ||
554 | /* It's safe to allow irq's after DR6 has been saved */ | 559 | /* It's safe to allow irq's after DR6 has been saved */ |
555 | preempt_conditional_sti(regs); | 560 | preempt_conditional_sti(regs); |
556 | 561 | ||
557 | /* Mask out spurious debug traps due to lazy DR7 setting */ | 562 | if (regs->flags & X86_VM_MASK) { |
558 | if (condition & (DR_TRAP0|DR_TRAP1|DR_TRAP2|DR_TRAP3)) { | 563 | handle_vm86_trap((struct kernel_vm86_regs *) regs, |
559 | if (!tsk->thread.debugreg7) | 564 | error_code, 1); |
560 | goto clear_dr7; | 565 | return; |
561 | } | 566 | } |
562 | 567 | ||
563 | #ifdef CONFIG_X86_32 | ||
564 | if (regs->flags & X86_VM_MASK) | ||
565 | goto debug_vm86; | ||
566 | #endif | ||
567 | |||
568 | /* Save debug status register where ptrace can see it */ | ||
569 | tsk->thread.debugreg6 = condition; | ||
570 | |||
571 | /* | 568 | /* |
572 | * Single-stepping through TF: make sure we ignore any events in | 569 | * Single-stepping through system calls: ignore any exceptions in |
573 | * kernel space (but re-enable TF when returning to user mode). | 570 | * kernel space, but re-enable TF when returning to user mode. |
571 | * | ||
572 | * We already checked v86 mode above, so we can check for kernel mode | ||
573 | * by just checking the CPL of CS. | ||
574 | */ | 574 | */ |
575 | if (condition & DR_STEP) { | 575 | if ((dr6 & DR_STEP) && !user_mode(regs)) { |
576 | if (!user_mode(regs)) | 576 | tsk->thread.debugreg6 &= ~DR_STEP; |
577 | goto clear_TF_reenable; | 577 | set_tsk_thread_flag(tsk, TIF_SINGLESTEP); |
578 | regs->flags &= ~X86_EFLAGS_TF; | ||
578 | } | 579 | } |
579 | 580 | si_code = get_si_code(tsk->thread.debugreg6); | |
580 | si_code = get_si_code(condition); | 581 | if (tsk->thread.debugreg6 & (DR_STEP | DR_TRAP_BITS)) |
581 | /* Ok, finally something we can handle */ | 582 | send_sigtrap(tsk, regs, error_code, si_code); |
582 | send_sigtrap(tsk, regs, error_code, si_code); | ||
583 | |||
584 | /* | ||
585 | * Disable additional traps. They'll be re-enabled when | ||
586 | * the signal is delivered. | ||
587 | */ | ||
588 | clear_dr7: | ||
589 | set_debugreg(0, 7); | ||
590 | preempt_conditional_cli(regs); | 583 | preempt_conditional_cli(regs); |
591 | return; | ||
592 | 584 | ||
593 | #ifdef CONFIG_X86_32 | ||
594 | debug_vm86: | ||
595 | /* reenable preemption: handle_vm86_trap() might sleep */ | ||
596 | dec_preempt_count(); | ||
597 | handle_vm86_trap((struct kernel_vm86_regs *) regs, error_code, 1); | ||
598 | conditional_cli(regs); | ||
599 | return; | ||
600 | #endif | ||
601 | |||
602 | clear_TF_reenable: | ||
603 | set_tsk_thread_flag(tsk, TIF_SINGLESTEP); | ||
604 | regs->flags &= ~X86_EFLAGS_TF; | ||
605 | preempt_conditional_cli(regs); | ||
606 | return; | 585 | return; |
607 | } | 586 | } |
608 | 587 | ||
diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c index 16ccbd77917f..11a4ad4d6253 100644 --- a/arch/x86/mm/kmmio.c +++ b/arch/x86/mm/kmmio.c | |||
@@ -540,8 +540,14 @@ kmmio_die_notifier(struct notifier_block *nb, unsigned long val, void *args) | |||
540 | struct die_args *arg = args; | 540 | struct die_args *arg = args; |
541 | 541 | ||
542 | if (val == DIE_DEBUG && (arg->err & DR_STEP)) | 542 | if (val == DIE_DEBUG && (arg->err & DR_STEP)) |
543 | if (post_kmmio_handler(arg->err, arg->regs) == 1) | 543 | if (post_kmmio_handler(arg->err, arg->regs) == 1) { |
544 | /* | ||
545 | * Reset the BS bit in dr6 (pointed by args->err) to | ||
546 | * denote completion of processing | ||
547 | */ | ||
548 | (*(unsigned long *)ERR_PTR(arg->err)) &= ~DR_STEP; | ||
544 | return NOTIFY_STOP; | 549 | return NOTIFY_STOP; |
550 | } | ||
545 | 551 | ||
546 | return NOTIFY_DONE; | 552 | return NOTIFY_DONE; |
547 | } | 553 | } |
diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c index b3d20b9cac63..9e63db8cdee4 100644 --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c | |||
@@ -18,6 +18,7 @@ | |||
18 | #include <asm/mce.h> | 18 | #include <asm/mce.h> |
19 | #include <asm/xcr.h> | 19 | #include <asm/xcr.h> |
20 | #include <asm/suspend.h> | 20 | #include <asm/suspend.h> |
21 | #include <asm/debugreg.h> | ||
21 | 22 | ||
22 | #ifdef CONFIG_X86_32 | 23 | #ifdef CONFIG_X86_32 |
23 | static struct saved_context saved_context; | 24 | static struct saved_context saved_context; |
@@ -104,6 +105,7 @@ static void __save_processor_state(struct saved_context *ctxt) | |||
104 | ctxt->cr4 = read_cr4(); | 105 | ctxt->cr4 = read_cr4(); |
105 | ctxt->cr8 = read_cr8(); | 106 | ctxt->cr8 = read_cr8(); |
106 | #endif | 107 | #endif |
108 | hw_breakpoint_disable(); | ||
107 | } | 109 | } |
108 | 110 | ||
109 | /* Needed by apm.c */ | 111 | /* Needed by apm.c */ |
@@ -146,27 +148,7 @@ static void fix_processor_context(void) | |||
146 | /* | 148 | /* |
147 | * Now maybe reload the debug registers | 149 | * Now maybe reload the debug registers |
148 | */ | 150 | */ |
149 | if (current->thread.debugreg7) { | 151 | load_debug_registers(); |
150 | #ifdef CONFIG_X86_32 | ||
151 | set_debugreg(current->thread.debugreg0, 0); | ||
152 | set_debugreg(current->thread.debugreg1, 1); | ||
153 | set_debugreg(current->thread.debugreg2, 2); | ||
154 | set_debugreg(current->thread.debugreg3, 3); | ||
155 | /* no 4 and 5 */ | ||
156 | set_debugreg(current->thread.debugreg6, 6); | ||
157 | set_debugreg(current->thread.debugreg7, 7); | ||
158 | #else | ||
159 | /* CONFIG_X86_64 */ | ||
160 | loaddebug(¤t->thread, 0); | ||
161 | loaddebug(¤t->thread, 1); | ||
162 | loaddebug(¤t->thread, 2); | ||
163 | loaddebug(¤t->thread, 3); | ||
164 | /* no 4 and 5 */ | ||
165 | loaddebug(¤t->thread, 6); | ||
166 | loaddebug(¤t->thread, 7); | ||
167 | #endif | ||
168 | } | ||
169 | |||
170 | } | 152 | } |
171 | 153 | ||
172 | /** | 154 | /** |