3 files changed, 34 insertions, 32 deletions

diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386
index f191a550a079..d6cffb27fff8 100644
--- a/arch/um/Kconfig.i386
+++ b/arch/um/Kconfig.i386
@@ -19,31 +19,31 @@ config SEMAPHORE_SLEEPERS
 choice
         prompt "Host memory split"
         default HOST_VMSPLIT_3G
-        ---help---
-           This is needed when the host kernel on which you run has a non-default
-           (like 2G/2G) memory split, instead of the customary 3G/1G. If you did
-           not recompile your own kernel but use the default distro's one, you can
-           safely accept the "Default split" option.
-
-           It can be enabled on recent (>=2.6.16-rc2) vanilla kernels via
-           CONFIG_VM_SPLIT_*, or on previous kernels with special patches (-ck
-           patchset by Con Kolivas, or other ones) - option names match closely the
-           host CONFIG_VM_SPLIT_* ones.
-
-           A lower setting (where 1G/3G is lowest and 3G/1G is higher) will
-           tolerate even more "normal" host kernels, but an higher setting will be
-           stricter.
-
-           So, if you do not know what to do here, say 'Default split'.
-
-        config HOST_VMSPLIT_3G
-                bool "Default split (3G/1G user/kernel host split)"
-        config HOST_VMSPLIT_3G_OPT
-                bool "3G/1G user/kernel host split (for full 1G low memory)"
-        config HOST_VMSPLIT_2G
-                bool "2G/2G user/kernel host split"
-        config HOST_VMSPLIT_1G
-                bool "1G/3G user/kernel host split"
+        help
+        This is needed when the host kernel on which you run has a non-default
+        (like 2G/2G) memory split, instead of the customary 3G/1G. If you did
+        not recompile your own kernel but use the default distro's one, you can
+        safely accept the "Default split" option.
+
+        It can be enabled on recent (>=2.6.16-rc2) vanilla kernels via
+        CONFIG_VM_SPLIT_*, or on previous kernels with special patches (-ck
+        patchset by Con Kolivas, or other ones) - option names match closely the
+        host CONFIG_VM_SPLIT_* ones.
+
+        A lower setting (where 1G/3G is lowest and 3G/1G is higher) will
+        tolerate even more "normal" host kernels, but an higher setting will be
+        stricter.
+
+        So, if you do not know what to do here, say 'Default split'.
+
+config HOST_VMSPLIT_3G
+        bool "Default split (3G/1G user/kernel host split)"
+config HOST_VMSPLIT_3G_OPT
+        bool "3G/1G user/kernel host split (for full 1G low memory)"
+config HOST_VMSPLIT_2G
+        bool "2G/2G user/kernel host split"
+config HOST_VMSPLIT_1G
+        bool "1G/3G user/kernel host split"
 endchoice
 
 config TOP_ADDR
@@ -67,13 +67,13 @@ config 3_LEVEL_PGTABLES
 
 config STUB_CODE
         hex
-        default 0xbfffe000 if !HOST_2G_2G
-        default 0x7fffe000 if HOST_2G_2G
+        default 0xbfffe000 if !HOST_VMSPLIT_2G
+        default 0x7fffe000 if HOST_VMSPLIT_2G
 
 config STUB_DATA
         hex
-        default 0xbffff000 if !HOST_2G_2G
-        default 0x7ffff000 if HOST_2G_2G
+        default 0xbffff000 if !HOST_VMSPLIT_2G
+        default 0x7ffff000 if HOST_VMSPLIT_2G
 
 config STUB_START
         hex
diff --git a/arch/um/sys-i386/signal.c b/arch/um/sys-i386/signal.c
index 0709fc6670c2..3f6acd667717 100644
--- a/arch/um/sys-i386/signal.c
+++ b/arch/um/sys-i386/signal.c
@@ -219,7 +219,8 @@ int setup_signal_stack_sc(unsigned long stack_top, int sig,
         unsigned long save_sp = PT_REGS_SP(regs);
         int err = 0;
 
-        stack_top &= -8UL;
+        /* This is the same calculation as i386 - ((sp + 4) & 15) == 0 */
+        stack_top = ((stack_top + 4) & -16UL) - 4;
         frame = (struct sigframe __user *) stack_top - 1;
         if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame)))
                 return 1;
diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signal.c
index 9edf114faf79..af2f017617b4 100644
--- a/arch/um/sys-x86_64/signal.c
+++ b/arch/um/sys-x86_64/signal.c
@@ -191,8 +191,9 @@ int setup_signal_stack_si(unsigned long stack_top, int sig,
         struct task_struct *me = current;
 
         frame = (struct rt_sigframe __user *)
-                round_down(stack_top - sizeof(struct rt_sigframe), 16) - 8;
-        frame = (struct rt_sigframe __user *) ((unsigned long) frame - 128);
+                round_down(stack_top - sizeof(struct rt_sigframe), 16);
+        /* Subtract 128 for a red zone and 8 for proper alignment */
+        frame = (struct rt_sigframe __user *) ((unsigned long) frame - 128 - 8);
 
         if (!access_ok(VERIFY_WRITE, fp, sizeof(struct _fpstate)))
                 goto out;