1 files changed, 70 insertions, 54 deletions

diff --git a/arch/um/drivers/chan_kern.c b/arch/um/drivers/chan_kern.c
index 5b58fad45290..8b1262e9fb66 100644
--- a/arch/um/drivers/chan_kern.c
+++ b/arch/um/drivers/chan_kern.c
@@ -58,7 +58,7 @@ static void *not_configged_init(char *str, int device, struct chan_opts *opts)
 {
         my_puts("Using a channel type which is configured out of "
                "UML\n");
-        return(NULL);
+        return NULL;
 }
 
 static int not_configged_open(int input, int output, int primary, void *data,
@@ -66,7 +66,7 @@ static int not_configged_open(int input, int output, int primary, void *data,
 {
         my_puts("Using a channel type which is configured out of "
                "UML\n");
-        return(-ENODEV);
+        return -ENODEV;
 }
 
 static void not_configged_close(int fd, void *data)
@@ -79,21 +79,21 @@ static int not_configged_read(int fd, char *c_out, void *data)
 {
         my_puts("Using a channel type which is configured out of "
                "UML\n");
-        return(-EIO);
+        return -EIO;
 }
 
 static int not_configged_write(int fd, const char *buf, int len, void *data)
 {
         my_puts("Using a channel type which is configured out of "
                "UML\n");
-        return(-EIO);
+        return -EIO;
 }
 
 static int not_configged_console_write(int fd, const char *buf, int len)
 {
         my_puts("Using a channel type which is configured out of "
                "UML\n");
-        return(-EIO);
+        return -EIO;
 }
 
 static int not_configged_window_size(int fd, void *data, unsigned short *rows,
@@ -101,7 +101,7 @@ static int not_configged_window_size(int fd, void *data, unsigned short *rows,
 {
         my_puts("Using a channel type which is configured out of "
                "UML\n");
-        return(-ENODEV);
+        return -ENODEV;
 }
 
 static void not_configged_free(void *data)
@@ -135,17 +135,17 @@ int generic_read(int fd, char *c_out, void *unused)
         n = os_read_file(fd, c_out, sizeof(*c_out));
 
         if(n == -EAGAIN)
-                return(0);
+                return 0;
         else if(n == 0)
-                return(-EIO);
-        return(n);
+                return -EIO;
+        return n;
 }
 
 /* XXX Trivial wrapper around os_write_file */
 
 int generic_write(int fd, const char *buf, int n, void *unused)
 {
-        return(os_write_file(fd, buf, n));
+        return os_write_file(fd, buf, n);
 }
 
 int generic_window_size(int fd, void *unused, unsigned short *rows_out,
@@ -156,14 +156,14 @@ int generic_window_size(int fd, void *unused, unsigned short *rows_out,
 
         ret = os_window_size(fd, &rows, &cols);
         if(ret < 0)
-                return(ret);
+                return ret;
 
         ret = ((*rows_out != rows) || (*cols_out != cols));
 
         *rows_out = rows;
         *cols_out = cols;
 
-        return(ret);
+        return ret;
 }
 
 void generic_free(void *data)
@@ -186,25 +186,29 @@ static void tty_receive_char(struct tty_struct *tty, char ch)
                 }
         }
 
-        if((tty->flip.flag_buf_ptr == NULL) || 
+        if((tty->flip.flag_buf_ptr == NULL) ||
            (tty->flip.char_buf_ptr == NULL))
                 return;
         tty_insert_flip_char(tty, ch, TTY_NORMAL);
 }
 
-static int open_one_chan(struct chan *chan, int input, int output, int primary)
+static int open_one_chan(struct chan *chan)
 {
         int fd;
 
-        if(chan->opened) return(0);
-        if(chan->ops->open == NULL) fd = 0;
-        else fd = (*chan->ops->open)(input, output, primary, chan->data,
-                                     &chan->dev);
-        if(fd < 0) return(fd);
+        if(chan->opened)
+                return 0;
+
+        if(chan->ops->open == NULL)
+                fd = 0;
+        else fd = (*chan->ops->open)(chan->input, chan->output, chan->primary,
+                                     chan->data, &chan->dev);
+        if(fd < 0)
+                return fd;
         chan->fd = fd;
 
         chan->opened = 1;
-        return(0);
+        return 0;
 }
 
 int open_chan(struct list_head *chans)
@@ -215,11 +219,11 @@ int open_chan(struct list_head *chans)
 
         list_for_each(ele, chans){
                 chan = list_entry(ele, struct chan, list);
-                ret = open_one_chan(chan, chan->input, chan->output,
-                                    chan->primary);
-                if(chan->primary) err = ret;
+                ret = open_one_chan(chan);
+                if(chan->primary)
+                        err = ret;
         }
-        return(err);
+        return err;
 }
 
 void chan_enable_winch(struct list_head *chans, struct tty_struct *tty)
@@ -267,7 +271,7 @@ void close_chan(struct list_head *chans)
         }
 }
 
-int write_chan(struct list_head *chans, const char *buf, int len, 
+int write_chan(struct list_head *chans, const char *buf, int len,
                int write_irq)
 {
         struct list_head *ele;
@@ -285,7 +289,7 @@ int write_chan(struct list_head *chans, const char *buf, int len,
                                 reactivate_fd(chan->fd, write_irq);
                 }
         }
-        return(ret);
+        return ret;
 }
 
 int console_write_chan(struct list_head *chans, const char *buf, int len)
@@ -301,10 +305,11 @@ int console_write_chan(struct list_head *chans, const char *buf, int len)
                 n = chan->ops->console_write(chan->fd, buf, len);
                 if(chan->primary) ret = n;
         }
-        return(ret);
+        return ret;
 }
 
-int console_open_chan(struct line *line, struct console *co, struct chan_opts *opts)
+int console_open_chan(struct line *line, struct console *co,
+                      struct chan_opts *opts)
 {
         if (!list_empty(&line->chan_list))
                 return 0;
@@ -327,12 +332,13 @@ int chan_window_size(struct list_head *chans, unsigned short *rows_out,
         list_for_each(ele, chans){
                 chan = list_entry(ele, struct chan, list);
                 if(chan->primary){
-                        if(chan->ops->window_size == NULL) return(0);
-                        return(chan->ops->window_size(chan->fd, chan->data,
-                                                      rows_out, cols_out));
+                        if(chan->ops->window_size == NULL)
+                                return 0;
+                        return chan->ops->window_size(chan->fd, chan->data,
+                                                      rows_out, cols_out);
                 }
         }
-        return(0);
+        return 0;
 }
 
 void free_one_chan(struct chan *chan)
@@ -363,23 +369,23 @@ static int one_chan_config_string(struct chan *chan, char *str, int size,
 
         if(chan == NULL){
                 CONFIG_CHUNK(str, size, n, "none", 1);
-                return(n);
+                return n;
         }
 
         CONFIG_CHUNK(str, size, n, chan->ops->type, 0);
 
         if(chan->dev == NULL){
                 CONFIG_CHUNK(str, size, n, "", 1);
-                return(n);
+                return n;
         }
 
         CONFIG_CHUNK(str, size, n, ":", 0);
         CONFIG_CHUNK(str, size, n, chan->dev, 0);
 
-        return(n);
+        return n;
 }
 
-static int chan_pair_config_string(struct chan *in, struct chan *out, 
+static int chan_pair_config_string(struct chan *in, struct chan *out,
                                    char *str, int size, char **error_out)
 {
         int n;
@@ -390,7 +396,7 @@ static int chan_pair_config_string(struct chan *in, struct chan *out,
 
         if(in == out){
                 CONFIG_CHUNK(str, size, n, "", 1);
-                return(n);
+                return n;
         }
 
         CONFIG_CHUNK(str, size, n, ",", 1);
@@ -399,10 +405,10 @@ static int chan_pair_config_string(struct chan *in, struct chan *out,
         size -= n;
         CONFIG_CHUNK(str, size, n, "", 1);
 
-        return(n);
+        return n;
 }
 
-int chan_config_string(struct list_head *chans, char *str, int size, 
+int chan_config_string(struct list_head *chans, char *str, int size,
                        char **error_out)
 {
         struct list_head *ele;
@@ -418,7 +424,7 @@ int chan_config_string(struct list_head *chans, char *str, int size,
                         out = chan;
         }
 
-        return(chan_pair_config_string(in, out, str, size, error_out));
+        return chan_pair_config_string(in, out, str, size, error_out);
 }
 
 struct chan_type {
@@ -462,7 +468,7 @@ struct chan_type chan_table[] = {
 #endif
 };
 
-static struct chan *parse_chan(char *str, int pri, int device, 
+static struct chan *parse_chan(char *str, int pri, int device,
                                struct chan_opts *opts)
 {
         struct chan_type *entry;
@@ -484,14 +490,17 @@ static struct chan *parse_chan(char *str, int pri, int device,
         if(ops == NULL){
                 my_printf("parse_chan couldn't parse \"%s\"\n",
                        str);
-                return(NULL);
+                return NULL;
         }
-        if(ops->init == NULL) return(NULL); 
+        if(ops->init == NULL)
+                return NULL;
         data = (*ops->init)(str, device, opts);
-        if(data == NULL) return(NULL);
+        if(data == NULL)
+                return NULL;
 
         chan = kmalloc(sizeof(*chan), GFP_ATOMIC);
-        if(chan == NULL) return(NULL);
+        if(chan == NULL)
+                return NULL;
         *chan = ((struct chan) { .list          = LIST_HEAD_INIT(chan->list),
                                  .primary       = 1,
                                  .input         = 0,
@@ -501,7 +510,7 @@ static struct chan *parse_chan(char *str, int pri, int device,
                                  .pri           = pri,
                                  .ops           = ops,
                                  .data          = data });
-        return(chan);
+        return chan;
 }
 
 int parse_chan_pair(char *str, struct list_head *chans, int pri, int device,
@@ -512,7 +521,8 @@ int parse_chan_pair(char *str, struct list_head *chans, int pri, int device,
 
         if(!list_empty(chans)){
                 chan = list_entry(chans->next, struct chan, list);
-                if(chan->pri >= pri) return(0);
+                if(chan->pri >= pri)
+                        return 0;
                 free_chan(chans);
                 INIT_LIST_HEAD(chans);
         }
@@ -523,23 +533,29 @@ int parse_chan_pair(char *str, struct list_head *chans, int pri, int device,
                 *out = '\0';
                 out++;
                 new = parse_chan(in, pri, device, opts);
-                if(new == NULL) return(-1);
+                if(new == NULL)
+                        return -1;
+
                 new->input = 1;
                 list_add(&new->list, chans);
 
                 new = parse_chan(out, pri, device, opts);
-                if(new == NULL) return(-1);
+                if(new == NULL)
+                        return -1;
+
                 list_add(&new->list, chans);
                 new->output = 1;
         }
         else {
                 new = parse_chan(str, pri, device, opts);
-                if(new == NULL) return(-1);
+                if(new == NULL)
+                        return -1;
+
                 list_add(&new->list, chans);
                 new->input = 1;
                 new->output = 1;
         }
-        return(0);
+        return 0;
 }
 
 int chan_out_fd(struct list_head *chans)
@@ -550,9 +566,9 @@ int chan_out_fd(struct list_head *chans)
         list_for_each(ele, chans){
                 chan = list_entry(ele, struct chan, list);
                 if(chan->primary && chan->output)
-                        return(chan->fd);
+                        return chan->fd;
         }
-        return(-1);
+        return -1;
 }
 
 void chan_interrupt(struct list_head *chans, struct work_struct *task,
@@ -567,7 +583,7 @@ void chan_interrupt(struct list_head *chans, struct work_struct *task,
                 chan = list_entry(ele, struct chan, list);
                 if(!chan->input || (chan->ops->read == NULL)) continue;
                 do {
-                        if((tty != NULL) && 
+                        if((tty != NULL) &&
                            (tty->flip.count >= TTY_FLIPBUF_SIZE)){
                                 schedule_work(task);
                                 goto out;