2 files changed, 4 insertions, 4 deletions

diff --git a/arch/sparc64/kernel/pci.c b/arch/sparc64/kernel/pci.c
index 023af41ad68d..9a549547cb2b 100644
--- a/arch/sparc64/kernel/pci.c
+++ b/arch/sparc64/kernel/pci.c
@@ -1092,10 +1092,10 @@ int arch_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc)
                 return -EINVAL;
 
         err = p->setup_msi_irq(&virt_irq, pdev, desc);
-        if (err < 0)
+        if (err)
                 return err;
 
-        return virt_irq;
+        return 0;
 }
 
 void arch_teardown_msi_irq(unsigned int virt_irq)
diff --git a/arch/sparc64/kernel/pci_sun4v.c b/arch/sparc64/kernel/pci_sun4v.c
index 94295c219329..1ccf4c9a9a43 100644
--- a/arch/sparc64/kernel/pci_sun4v.c
+++ b/arch/sparc64/kernel/pci_sun4v.c
@@ -1169,8 +1169,6 @@ static int pci_sun4v_setup_msi_irq(unsigned int *virt_irq_p,
         if (!devino)
                 goto out_err;
 
-        set_irq_msi(*virt_irq_p, entry);
-
         msiqid = ((devino - pbm->msiq_first_devino) +
                   pbm->msiq_first);
 
@@ -1204,6 +1202,8 @@ static int pci_sun4v_setup_msi_irq(unsigned int *virt_irq_p,
                 msg.address_lo = pbm->msi32_start;
         }
         msg.data = msi_num;
+
+        set_irq_msi(*virt_irq_p, entry);
         write_msi_msg(*virt_irq_p, &msg);
 
         irq_install_pre_handler(*virt_irq_p,