6 files changed, 135 insertions, 63 deletions

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 20aae16cbadf..20a8fdcaacbf 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -11,6 +11,11 @@ config PPC64
           This option selects whether a 32-bit or a 64-bit kernel
           will be built.
 
+config PPC_PM_NEEDS_RTC_LIB
+        bool
+        select RTC_LIB
+        default y if PM
+
 config PPC32
         bool
         default y if !PPC64
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 0df049215503..d7d7602e348f 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -402,11 +402,11 @@ static void printbits(unsigned long val, struct regbit *bits)
 }
 
 #ifdef CONFIG_PPC64
-#define REG             "%016lX"
+#define REG             "%016lx"
 #define REGS_PER_LINE   4
 #define LAST_VOLATILE   13
 #else
-#define REG             "%08lX"
+#define REG             "%08lx"
 #define REGS_PER_LINE   8
 #define LAST_VOLATILE   12
 #endif
@@ -421,7 +421,7 @@ void show_regs(struct pt_regs * regs)
                regs, regs->trap, print_tainted(), init_utsname()->release);
         printk("MSR: "REG" ", regs->msr);
         printbits(regs->msr, msr_bits);
-        printk("  CR: %08lX  XER: %08lX\n", regs->ccr, regs->xer);
+        printk("  CR: %08lx  XER: %08lx\n", regs->ccr, regs->xer);
         trap = TRAP(regs);
         if (trap == 0x300 || trap == 0x600)
                 printk("DAR: "REG", DSISR: "REG"\n", regs->dar, regs->dsisr);
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 17724fb2067f..f7862224fe85 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -90,21 +90,11 @@ EXPORT_SYMBOL(unregister_die_notifier);
  * Trap & Exception support
  */
 
-static DEFINE_SPINLOCK(die_lock);
-
-int die(const char *str, struct pt_regs *regs, long err)
-{
-        static int die_counter;
-
-        if (debugger(regs))
-                return 1;
-
-        console_verbose();
-        spin_lock_irq(&die_lock);
-        bust_spinlocks(1);
 #ifdef CONFIG_PMAC_BACKLIGHT
+static void pmac_backlight_unblank(void)
+{
         mutex_lock(&pmac_backlight_mutex);
-        if (machine_is(powermac) && pmac_backlight) {
+        if (pmac_backlight) {
                 struct backlight_properties *props;
 
                 props = &pmac_backlight->props;
@@ -113,26 +103,67 @@ int die(const char *str, struct pt_regs *regs, long err)
                 backlight_update_status(pmac_backlight);
         }
         mutex_unlock(&pmac_backlight_mutex);
+}
+#else
+static inline void pmac_backlight_unblank(void) { }
 #endif
-        printk("Oops: %s, sig: %ld [#%d]\n", str, err, ++die_counter);
+
+int die(const char *str, struct pt_regs *regs, long err)
+{
+        static struct {
+                spinlock_t lock;
+                u32 lock_owner;
+                int lock_owner_depth;
+        } die = {
+                .lock =                 __SPIN_LOCK_UNLOCKED(die.lock),
+                .lock_owner =           -1,
+                .lock_owner_depth =     0
+        };
+        static int die_counter;
+        unsigned long flags;
+
+        if (debugger(regs))
+                return 1;
+
+        oops_enter();
+
+        if (die.lock_owner != raw_smp_processor_id()) {
+                console_verbose();
+                spin_lock_irqsave(&die.lock, flags);
+                die.lock_owner = smp_processor_id();
+                die.lock_owner_depth = 0;
+                bust_spinlocks(1);
+                if (machine_is(powermac))
+                        pmac_backlight_unblank();
+        } else {
+                local_save_flags(flags);
+        }
+
+        if (++die.lock_owner_depth < 3) {
+                printk("Oops: %s, sig: %ld [#%d]\n", str, err, ++die_counter);
 #ifdef CONFIG_PREEMPT
-        printk("PREEMPT ");
+                printk("PREEMPT ");
 #endif
 #ifdef CONFIG_SMP
-        printk("SMP NR_CPUS=%d ", NR_CPUS);
+                printk("SMP NR_CPUS=%d ", NR_CPUS);
 #endif
 #ifdef CONFIG_DEBUG_PAGEALLOC
-        printk("DEBUG_PAGEALLOC ");
+                printk("DEBUG_PAGEALLOC ");
 #endif
 #ifdef CONFIG_NUMA
-        printk("NUMA ");
+                printk("NUMA ");
 #endif
-        printk("%s\n", ppc_md.name ? "" : ppc_md.name);
+                printk("%s\n", ppc_md.name ? ppc_md.name : "");
+
+                print_modules();
+                show_regs(regs);
+        } else {
+                printk("Recursive die() failure, output suppressed\n");
+        }
 
-        print_modules();
-        show_regs(regs);
         bust_spinlocks(0);
-        spin_unlock_irq(&die_lock);
+        die.lock_owner = -1;
+        spin_unlock_irqrestore(&die.lock, flags);
 
         if (kexec_should_crash(current) ||
                 kexec_sr_activated(smp_processor_id()))
@@ -145,6 +176,7 @@ int die(const char *str, struct pt_regs *regs, long err)
         if (panic_on_oops)
                 panic("Fatal exception");
 
+        oops_exit();
         do_exit(err);
 
         return 0;
diff --git a/arch/powerpc/platforms/powermac/time.c b/arch/powerpc/platforms/powermac/time.c
index a4173906e945..bf9da56942e8 100644
--- a/arch/powerpc/platforms/powermac/time.c
+++ b/arch/powerpc/platforms/powermac/time.c
@@ -297,49 +297,11 @@ int __init via_calibrate_decr(void)
 }
 #endif
 
-#ifdef CONFIG_PM
-/*
- * Reset the time after a sleep.
- */
-static int
-time_sleep_notify(struct pmu_sleep_notifier *self, int when)
-{
-        static unsigned long time_diff;
-        unsigned long flags;
-        unsigned long seq;
-        struct timespec tv;
-
-        switch (when) {
-        case PBOOK_SLEEP_NOW:
-                do {
-                        seq = read_seqbegin_irqsave(&xtime_lock, flags);
-                        time_diff = xtime.tv_sec - pmac_get_boot_time();
-                } while (read_seqretry_irqrestore(&xtime_lock, seq, flags));
-                break;
-        case PBOOK_WAKE:
-                tv.tv_sec = pmac_get_boot_time() + time_diff;
-                tv.tv_nsec = 0;
-                do_settimeofday(&tv);
-                break;
-        }
-        return PBOOK_SLEEP_OK;
-}
-
-static struct pmu_sleep_notifier time_sleep_notifier = {
-        time_sleep_notify, SLEEP_LEVEL_MISC,
-};
-#endif /* CONFIG_PM */
-
 /*
  * Query the OF and get the decr frequency.
  */
 void __init pmac_calibrate_decr(void)
 {
-#if defined(CONFIG_PM) && defined(CONFIG_ADB_PMU)
-        /* XXX why here? */
-        pmu_register_sleep_notifier(&time_sleep_notifier);
-#endif
-
         generic_calibrate_decr();
 
 #ifdef CONFIG_PPC32
diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile
index 26ca3ffbc1de..e57379d22b61 100644
--- a/arch/powerpc/sysdev/Makefile
+++ b/arch/powerpc/sysdev/Makefile
@@ -14,6 +14,9 @@ obj-$(CONFIG_FSL_SOC)		+= fsl_soc.o
 obj-$(CONFIG_TSI108_BRIDGE)     += tsi108_pci.o tsi108_dev.o
 obj-$(CONFIG_QUICC_ENGINE)      += qe_lib/
 
+# contains only the suspend handler for time
+obj-$(CONFIG_PM)                += timer.o
+
 ifeq ($(CONFIG_PPC_MERGE),y)
 obj-$(CONFIG_PPC_I8259)         += i8259.o
 obj-$(CONFIG_PPC_83xx)          += ipic.o
diff --git a/arch/powerpc/sysdev/timer.c b/arch/powerpc/sysdev/timer.c
new file mode 100644
index 000000000000..bdbf8fe520e4
--- /dev/null
+++ b/arch/powerpc/sysdev/timer.c
@@ -0,0 +1,70 @@
+/*
+ * Common code to keep time when machine suspends.
+ *
+ * Copyright 2007       Johannes Berg <johannes@sipsolutions.net>
+ *
+ * GPLv2
+ */
+
+#include <linux/time.h>
+#include <asm/rtc.h>
+
+static unsigned long suspend_rtc_time;
+
+/*
+ * Reset the time after a sleep.
+ */
+static int timer_resume(struct sys_device *dev)
+{
+        struct timeval tv;
+        struct timespec ts;
+        struct rtc_time cur_rtc_tm;
+        unsigned long cur_rtc_time, diff;
+
+        /* get current RTC time and convert to seconds */
+        get_rtc_time(&cur_rtc_tm);
+        rtc_tm_to_time(&cur_rtc_tm, &cur_rtc_time);
+
+        diff = cur_rtc_time - suspend_rtc_time;
+
+        /* adjust time of day by seconds that elapsed while
+         * we were suspended */
+        do_gettimeofday(&tv);
+        ts.tv_sec = tv.tv_sec + diff;
+        ts.tv_nsec = tv.tv_usec * NSEC_PER_USEC;
+        do_settimeofday(&ts);
+
+        return 0;
+}
+
+static int timer_suspend(struct sys_device *dev, pm_message_t state)
+{
+        struct rtc_time suspend_rtc_tm;
+        WARN_ON(!ppc_md.get_rtc_time);
+
+        get_rtc_time(&suspend_rtc_tm);
+        rtc_tm_to_time(&suspend_rtc_tm, &suspend_rtc_time);
+
+        return 0;
+}
+
+static struct sysdev_class timer_sysclass = {
+        .resume = timer_resume,
+        .suspend = timer_suspend,
+        set_kset_name("timer"),
+};
+
+static struct sys_device device_timer = {
+        .id = 0,
+        .cls = &timer_sysclass,
+};
+
+static int time_init_device(void)
+{
+        int error = sysdev_class_register(&timer_sysclass);
+        if (!error)
+                error = sysdev_register(&device_timer);
+        return error;
+}
+
+device_initcall(time_init_device);