5 files changed, 29 insertions, 92 deletions

diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
index c168c54e3c40..b49fdbd15808 100644
--- a/arch/powerpc/xmon/Makefile
+++ b/arch/powerpc/xmon/Makefile
@@ -6,7 +6,7 @@ GCOV_PROFILE := n
 
 ccflags-$(CONFIG_PPC64) := -mno-minimal-toc
 
-obj-y                   += xmon.o start.o nonstdio.o
+obj-y                   += xmon.o nonstdio.o
 
 ifdef CONFIG_XMON_DISASSEMBLY
 obj-y                   += ppc-dis.o ppc-opc.o
diff --git a/arch/powerpc/xmon/nonstdio.c b/arch/powerpc/xmon/nonstdio.c
index bfac84fbe780..bce3dcfe5058 100644
--- a/arch/powerpc/xmon/nonstdio.c
+++ b/arch/powerpc/xmon/nonstdio.c
@@ -7,9 +7,23 @@
  *      2 of the License, or (at your option) any later version.
  */
 #include <linux/string.h>
+#include <asm/udbg.h>
 #include <asm/time.h>
 #include "nonstdio.h"
 
+
+static int xmon_write(const void *ptr, int nb)
+{
+        return udbg_write(ptr, nb);
+}
+
+static int xmon_readchar(void)
+{
+        if (udbg_getc)
+                return udbg_getc();
+        return -1;
+}
+
 int xmon_putchar(int c)
 {
         char ch = c;
@@ -23,34 +37,7 @@ static char line[256];
 static char *lineptr;
 static int lineleft;
 
-int xmon_expect(const char *str, unsigned long timeout)
-{
-        int c;
-        unsigned long t0;
-
-        /* assume 25MHz default timebase if tb_ticks_per_sec not set yet */
-        timeout *= tb_ticks_per_sec? tb_ticks_per_sec: 25000000;
-        t0 = get_tbl();
-        do {
-                lineptr = line;
-                for (;;) {
-                        c = xmon_read_poll();
-                        if (c == -1) {
-                                if (get_tbl() - t0 > timeout)
-                                        return 0;
-                                continue;
-                        }
-                        if (c == '\n')
-                                break;
-                        if (c != '\r' && lineptr < &line[sizeof(line) - 1])
-                                *lineptr++ = c;
-                }
-                *lineptr = 0;
-        } while (strstr(line, str) == NULL);
-        return 1;
-}
-
-int xmon_getchar(void)
+static int xmon_getchar(void)
 {
         int c;
 
@@ -124,13 +111,19 @@ char *xmon_gets(char *str, int nb)
 void xmon_printf(const char *format, ...)
 {
         va_list args;
-        int n;
         static char xmon_outbuf[1024];
+        int rc, n;
 
         va_start(args, format);
         n = vsnprintf(xmon_outbuf, sizeof(xmon_outbuf), format, args);
         va_end(args);
-        xmon_write(xmon_outbuf, n);
+
+        rc = xmon_write(xmon_outbuf, n);
+
+        if (n && rc == 0) {
+                /* No udbg hooks, fallback to printk() - dangerous */
+                printk(xmon_outbuf);
+        }
 }
 
 void xmon_puts(const char *str)
diff --git a/arch/powerpc/xmon/nonstdio.h b/arch/powerpc/xmon/nonstdio.h
index 23dd95f4599c..18a51ded4ffd 100644
--- a/arch/powerpc/xmon/nonstdio.h
+++ b/arch/powerpc/xmon/nonstdio.h
@@ -4,12 +4,6 @@
 #define putchar xmon_putchar
 
 extern int xmon_putchar(int c);
-extern int xmon_getchar(void);
 extern void xmon_puts(const char *);
 extern char *xmon_gets(char *, int);
 extern void xmon_printf(const char *, ...);
-extern void xmon_map_scc(void);
-extern int xmon_expect(const char *str, unsigned long timeout);
-extern int xmon_write(const void *ptr, int nb);
-extern int xmon_readchar(void);
-extern int xmon_read_poll(void);
diff --git a/arch/powerpc/xmon/start.c b/arch/powerpc/xmon/start.c
deleted file mode 100644
index 8864de2af382..000000000000
--- a/arch/powerpc/xmon/start.c
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * Copyright (C) 1996 Paul Mackerras.
- *
- *      This program is free software; you can redistribute it and/or
- *      modify it under the terms of the GNU General Public License
- *      as published by the Free Software Foundation; either version
- *      2 of the License, or (at your option) any later version.
- */
-#include <asm/machdep.h>
-#include <asm/udbg.h>
-#include "nonstdio.h"
-
-void xmon_map_scc(void)
-{
-}
-
-int xmon_write(const void *ptr, int nb)
-{
-        return udbg_write(ptr, nb);
-}
-
-int xmon_readchar(void)
-{
-        if (udbg_getc)
-                return udbg_getc();
-        return -1;
-}
-
-int xmon_read_poll(void)
-{
-        if (udbg_getc_poll)
-                return udbg_getc_poll();
-        return -1;
-}
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 3a56a639a92e..1f8d2f10a432 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -52,9 +52,6 @@
 #include "nonstdio.h"
 #include "dis-asm.h"
 
-#define scanhex xmon_scanhex
-#define skipbl  xmon_skipbl
-
 #ifdef CONFIG_SMP
 static cpumask_t cpus_in_xmon = CPU_MASK_NONE;
 static unsigned long xmon_taken = 1;
@@ -169,12 +166,8 @@ extern void xmon_leave(void);
 
 #ifdef CONFIG_PPC64
 #define REG             "%.16lx"
-#define REGS_PER_LINE   4
-#define LAST_VOLATILE   13
 #else
 #define REG             "%.8lx"
-#define REGS_PER_LINE   8
-#define LAST_VOLATILE   12
 #endif
 
 #define GETWORD(v)      (((v)[0] << 24) + ((v)[1] << 16) + ((v)[2] << 8) + (v)[3])
@@ -1288,27 +1281,19 @@ static void get_function_bounds(unsigned long pc, unsigned long *startp,
         catch_memory_errors = 0;
 }
 
-static int xmon_depth_to_print = 64;
-
 #define LRSAVE_OFFSET           (STACK_FRAME_LR_SAVE * sizeof(unsigned long))
 #define MARKER_OFFSET           (STACK_FRAME_MARKER * sizeof(unsigned long))
 
-#ifdef __powerpc64__
-#define REGS_OFFSET             0x70
-#else
-#define REGS_OFFSET             16
-#endif
-
 static void xmon_show_stack(unsigned long sp, unsigned long lr,
                             unsigned long pc)
 {
+        int max_to_print = 64;
         unsigned long ip;
         unsigned long newsp;
         unsigned long marker;
-        int count = 0;
         struct pt_regs regs;
 
-        do {
+        while (max_to_print--) {
                 if (sp < PAGE_OFFSET) {
                         if (sp != 0)
                                 printf("SP (%lx) is in userspace\n", sp);
@@ -1362,10 +1347,10 @@ static void xmon_show_stack(unsigned long sp, unsigned long lr,
                    an exception frame. */
                 if (mread(sp + MARKER_OFFSET, &marker, sizeof(unsigned long))
                     && marker == STACK_FRAME_REGS_MARKER) {
-                        if (mread(sp + REGS_OFFSET, &regs, sizeof(regs))
+                        if (mread(sp + STACK_FRAME_OVERHEAD, &regs, sizeof(regs))
                             != sizeof(regs)) {
                                 printf("Couldn't read registers at %lx\n",
-                                       sp + REGS_OFFSET);
+                                       sp + STACK_FRAME_OVERHEAD);
                                 break;
                         }
                         printf("--- Exception: %lx %s at ", regs.trap,
@@ -1379,7 +1364,7 @@ static void xmon_show_stack(unsigned long sp, unsigned long lr,
                         break;
 
                 sp = newsp;
-        } while (count++ < xmon_depth_to_print);
+        }
 }
 
 static void backtrace(struct pt_regs *excp)
@@ -2943,7 +2928,6 @@ static void xmon_init(int enable)
                 __debugger_dabr_match = NULL;
                 __debugger_fault_handler = NULL;
         }
-        xmon_map_scc();
 }
 
 #ifdef CONFIG_MAGIC_SYSRQ