1 files changed, 27 insertions, 26 deletions

diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
index 74c64c0d3b71..893e65439e85 100644
--- a/arch/powerpc/sysdev/mpic.c
+++ b/arch/powerpc/sysdev/mpic.c
@@ -156,8 +156,7 @@ static inline u32 _mpic_read(enum mpic_reg_type type,
         switch(type) {
 #ifdef CONFIG_PPC_DCR
         case mpic_access_dcr:
-                return dcr_read(rb->dhost,
-                                rb->dbase + reg + rb->doff);
+                return dcr_read(rb->dhost, rb->dhost.base + reg);
 #endif
         case mpic_access_mmio_be:
                 return in_be32(rb->base + (reg >> 2));
@@ -174,8 +173,7 @@ static inline void _mpic_write(enum mpic_reg_type type,
         switch(type) {
 #ifdef CONFIG_PPC_DCR
         case mpic_access_dcr:
-                return dcr_write(rb->dhost,
-                                 rb->dbase + reg + rb->doff, value);
+                return dcr_write(rb->dhost, rb->dhost.base + reg, value);
 #endif
         case mpic_access_mmio_be:
                 return out_be32(rb->base + (reg >> 2), value);
@@ -228,8 +226,13 @@ static inline u32 _mpic_irq_read(struct mpic *mpic, unsigned int src_no, unsigne
         unsigned int    isu = src_no >> mpic->isu_shift;
         unsigned int    idx = src_no & mpic->isu_mask;
 
-        return _mpic_read(mpic->reg_type, &mpic->isus[isu],
-                          reg + (idx * MPIC_INFO(IRQ_STRIDE)));
+#ifdef CONFIG_MPIC_BROKEN_REGREAD
+        if (reg == 0)
+                return mpic->isu_reg0_shadow[idx];
+        else
+#endif
+                return _mpic_read(mpic->reg_type, &mpic->isus[isu],
+                                  reg + (idx * MPIC_INFO(IRQ_STRIDE)));
 }
 
 static inline void _mpic_irq_write(struct mpic *mpic, unsigned int src_no,
@@ -240,6 +243,11 @@ static inline void _mpic_irq_write(struct mpic *mpic, unsigned int src_no,
 
         _mpic_write(mpic->reg_type, &mpic->isus[isu],
                     reg + (idx * MPIC_INFO(IRQ_STRIDE)), value);
+
+#ifdef CONFIG_MPIC_BROKEN_REGREAD
+        if (reg == 0)
+                mpic->isu_reg0_shadow[idx] = value;
+#endif
 }
 
 #define mpic_read(b,r)          _mpic_read(mpic->reg_type,&(b),(r))
@@ -269,9 +277,11 @@ static void _mpic_map_mmio(struct mpic *mpic, unsigned long phys_addr,
 static void _mpic_map_dcr(struct mpic *mpic, struct mpic_reg_bank *rb,
                           unsigned int offset, unsigned int size)
 {
-        rb->dbase = mpic->dcr_base;
-        rb->doff = offset;
-        rb->dhost = dcr_map(mpic->of_node, rb->dbase + rb->doff, size);
+        const u32 *dbasep;
+
+        dbasep = of_get_property(mpic->irqhost->of_node, "dcr-reg", NULL);
+
+        rb->dhost = dcr_map(mpic->irqhost->of_node, *dbasep + offset, size);
         BUG_ON(!DCR_MAP_OK(rb->dhost));
 }
 
@@ -758,7 +768,7 @@ static void mpic_end_ipi(unsigned int irq)
 
 #endif /* CONFIG_SMP */
 
-static void mpic_set_affinity(unsigned int irq, cpumask_t cpumask)
+void mpic_set_affinity(unsigned int irq, cpumask_t cpumask)
 {
         struct mpic *mpic = mpic_from_irq(irq);
         unsigned int src = mpic_irq_to_hw(irq);
@@ -861,10 +871,8 @@ static struct irq_chip mpic_irq_ht_chip = {
 
 static int mpic_host_match(struct irq_host *h, struct device_node *node)
 {
-        struct mpic *mpic = h->host_data;
-
         /* Exact match, unless mpic node is NULL */
-        return mpic->of_node == NULL || mpic->of_node == node;
+        return h->of_node == NULL || h->of_node == node;
 }
 
 static int mpic_host_map(struct irq_host *h, unsigned int virq,
@@ -985,10 +993,9 @@ struct mpic * __init mpic_alloc(struct device_node *node,
         
         memset(mpic, 0, sizeof(struct mpic));
         mpic->name = name;
-        mpic->of_node = of_node_get(node);
 
-        mpic->irqhost = irq_alloc_host(IRQ_HOST_MAP_LINEAR, isu_size,
-                                       &mpic_host_ops,
+        mpic->irqhost = irq_alloc_host(of_node_get(node), IRQ_HOST_MAP_LINEAR,
+                                       isu_size, &mpic_host_ops,
                                        flags & MPIC_LARGE_VECTORS ? 2048 : 256);
         if (mpic->irqhost == NULL) {
                 of_node_put(node);
@@ -1068,20 +1075,14 @@ struct mpic * __init mpic_alloc(struct device_node *node,
         BUG_ON(paddr == 0 && node == NULL);
 
         /* If no physical address passed in, check if it's dcr based */
-        if (paddr == 0 && of_get_property(node, "dcr-reg", NULL) != NULL)
-                mpic->flags |= MPIC_USES_DCR;
-
+        if (paddr == 0 && of_get_property(node, "dcr-reg", NULL) != NULL) {
 #ifdef CONFIG_PPC_DCR
-        if (mpic->flags & MPIC_USES_DCR) {
-                const u32 *dbasep;
-                dbasep = of_get_property(node, "dcr-reg", NULL);
-                BUG_ON(dbasep == NULL);
-                mpic->dcr_base = *dbasep;
+                mpic->flags |= MPIC_USES_DCR;
                 mpic->reg_type = mpic_access_dcr;
-        }
 #else
-        BUG_ON (mpic->flags & MPIC_USES_DCR);
+                BUG();
 #endif /* CONFIG_PPC_DCR */
+        }
 
         /* If the MPIC is not DCR based, and no physical address was passed
          * in, try to obtain one