diff options
Diffstat (limited to 'arch/powerpc/platforms/pseries/setup.c')
-rw-r--r-- | arch/powerpc/platforms/pseries/setup.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index e78c39368841..a093a0d4dd69 100644 --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c | |||
@@ -469,6 +469,7 @@ static inline void dedicated_idle_sleep(unsigned int cpu) | |||
469 | * more. | 469 | * more. |
470 | */ | 470 | */ |
471 | clear_thread_flag(TIF_POLLING_NRFLAG); | 471 | clear_thread_flag(TIF_POLLING_NRFLAG); |
472 | smp_mb__after_clear_bit(); | ||
472 | 473 | ||
473 | /* | 474 | /* |
474 | * SMT dynamic mode. Cede will result in this thread going | 475 | * SMT dynamic mode. Cede will result in this thread going |
@@ -481,6 +482,7 @@ static inline void dedicated_idle_sleep(unsigned int cpu) | |||
481 | cede_processor(); | 482 | cede_processor(); |
482 | else | 483 | else |
483 | local_irq_enable(); | 484 | local_irq_enable(); |
485 | set_thread_flag(TIF_POLLING_NRFLAG); | ||
484 | } else { | 486 | } else { |
485 | /* | 487 | /* |
486 | * Give the HV an opportunity at the processor, since we are | 488 | * Give the HV an opportunity at the processor, since we are |
@@ -492,11 +494,11 @@ static inline void dedicated_idle_sleep(unsigned int cpu) | |||
492 | 494 | ||
493 | static void pseries_dedicated_idle(void) | 495 | static void pseries_dedicated_idle(void) |
494 | { | 496 | { |
495 | long oldval; | ||
496 | struct paca_struct *lpaca = get_paca(); | 497 | struct paca_struct *lpaca = get_paca(); |
497 | unsigned int cpu = smp_processor_id(); | 498 | unsigned int cpu = smp_processor_id(); |
498 | unsigned long start_snooze; | 499 | unsigned long start_snooze; |
499 | unsigned long *smt_snooze_delay = &__get_cpu_var(smt_snooze_delay); | 500 | unsigned long *smt_snooze_delay = &__get_cpu_var(smt_snooze_delay); |
501 | set_thread_flag(TIF_POLLING_NRFLAG); | ||
500 | 502 | ||
501 | while (1) { | 503 | while (1) { |
502 | /* | 504 | /* |
@@ -505,10 +507,7 @@ static void pseries_dedicated_idle(void) | |||
505 | */ | 507 | */ |
506 | lpaca->lppaca.idle = 1; | 508 | lpaca->lppaca.idle = 1; |
507 | 509 | ||
508 | oldval = test_and_clear_thread_flag(TIF_NEED_RESCHED); | 510 | if (!need_resched()) { |
509 | if (!oldval) { | ||
510 | set_thread_flag(TIF_POLLING_NRFLAG); | ||
511 | |||
512 | start_snooze = __get_tb() + | 511 | start_snooze = __get_tb() + |
513 | *smt_snooze_delay * tb_ticks_per_usec; | 512 | *smt_snooze_delay * tb_ticks_per_usec; |
514 | 513 | ||
@@ -531,15 +530,14 @@ static void pseries_dedicated_idle(void) | |||
531 | } | 530 | } |
532 | 531 | ||
533 | HMT_medium(); | 532 | HMT_medium(); |
534 | clear_thread_flag(TIF_POLLING_NRFLAG); | ||
535 | } else { | ||
536 | set_need_resched(); | ||
537 | } | 533 | } |
538 | 534 | ||
539 | lpaca->lppaca.idle = 0; | 535 | lpaca->lppaca.idle = 0; |
540 | ppc64_runlatch_on(); | 536 | ppc64_runlatch_on(); |
541 | 537 | ||
538 | preempt_enable_no_resched(); | ||
542 | schedule(); | 539 | schedule(); |
540 | preempt_disable(); | ||
543 | 541 | ||
544 | if (cpu_is_offline(cpu) && system_state == SYSTEM_RUNNING) | 542 | if (cpu_is_offline(cpu) && system_state == SYSTEM_RUNNING) |
545 | cpu_die(); | 543 | cpu_die(); |
@@ -583,7 +581,9 @@ static void pseries_shared_idle(void) | |||
583 | lpaca->lppaca.idle = 0; | 581 | lpaca->lppaca.idle = 0; |
584 | ppc64_runlatch_on(); | 582 | ppc64_runlatch_on(); |
585 | 583 | ||
584 | preempt_enable_no_resched(); | ||
586 | schedule(); | 585 | schedule(); |
586 | preempt_disable(); | ||
587 | 587 | ||
588 | if (cpu_is_offline(cpu) && system_state == SYSTEM_RUNNING) | 588 | if (cpu_is_offline(cpu) && system_state == SYSTEM_RUNNING) |
589 | cpu_die(); | 589 | cpu_die(); |