1 files changed, 46 insertions, 44 deletions

diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
index 556c279a789d..3c95392f4f41 100644
--- a/arch/powerpc/platforms/pseries/iommu.c
+++ b/arch/powerpc/platforms/pseries/iommu.c
@@ -309,7 +309,7 @@ static void iommu_table_setparms_lpar(struct pci_controller *phb,
         tbl->it_size = size >> IOMMU_PAGE_SHIFT;
 }
 
-static void iommu_bus_setup_pSeries(struct pci_bus *bus)
+static void pci_dma_bus_setup_pSeries(struct pci_bus *bus)
 {
         struct device_node *dn;
         struct iommu_table *tbl;
@@ -318,10 +318,9 @@ static void iommu_bus_setup_pSeries(struct pci_bus *bus)
         struct pci_dn *pci;
         int children;
 
-        DBG("iommu_bus_setup_pSeries, bus %p, bus->self %p\n", bus, bus->self);
-
         dn = pci_bus_to_OF_node(bus);
-        pci = PCI_DN(dn);
+
+        DBG("pci_dma_bus_setup_pSeries: setting up bus %s\n", dn->full_name);
 
         if (bus->self) {
                 /* This is not a root bus, any setup will be done for the
@@ -329,6 +328,7 @@ static void iommu_bus_setup_pSeries(struct pci_bus *bus)
                  */
                 return;
         }
+        pci = PCI_DN(dn);
 
         /* Check if the ISA bus on the system is under
          * this PHB.
@@ -390,17 +390,17 @@ static void iommu_bus_setup_pSeries(struct pci_bus *bus)
 }
 
 
-static void iommu_bus_setup_pSeriesLP(struct pci_bus *bus)
+static void pci_dma_bus_setup_pSeriesLP(struct pci_bus *bus)
 {
         struct iommu_table *tbl;
         struct device_node *dn, *pdn;
         struct pci_dn *ppci;
         const void *dma_window = NULL;
 
-        DBG("iommu_bus_setup_pSeriesLP, bus %p, bus->self %p\n", bus, bus->self);
-
         dn = pci_bus_to_OF_node(bus);
 
+        DBG("pci_dma_bus_setup_pSeriesLP: setting up bus %s\n", dn->full_name);
+
         /* Find nearest ibm,dma-window, walking up the device tree */
         for (pdn = dn; pdn != NULL; pdn = pdn->parent) {
                 dma_window = get_property(pdn, "ibm,dma-window", NULL);
@@ -409,11 +409,15 @@ static void iommu_bus_setup_pSeriesLP(struct pci_bus *bus)
         }
 
         if (dma_window == NULL) {
-                DBG("iommu_bus_setup_pSeriesLP: bus %s seems to have no ibm,dma-window property\n", dn->full_name);
+                DBG("  no ibm,dma-window property !\n");
                 return;
         }
 
         ppci = PCI_DN(pdn);
+
+        DBG("  parent is %s, iommu_table: 0x%p\n",
+            pdn->full_name, ppci->iommu_table);
+
         if (!ppci->iommu_table) {
                 /* Bussubno hasn't been copied yet.
                  * Do it now because iommu_table_setparms_lpar needs it.
@@ -427,6 +431,7 @@ static void iommu_bus_setup_pSeriesLP(struct pci_bus *bus)
                 iommu_table_setparms_lpar(ppci->phb, pdn, tbl, dma_window);
 
                 ppci->iommu_table = iommu_init_table(tbl, ppci->phb->node);
+                DBG("  created table: %p\n", ppci->iommu_table);
         }
 
         if (pdn != dn)
@@ -434,27 +439,27 @@ static void iommu_bus_setup_pSeriesLP(struct pci_bus *bus)
 }
 
 
-static void iommu_dev_setup_pSeries(struct pci_dev *dev)
+static void pci_dma_dev_setup_pSeries(struct pci_dev *dev)
 {
-        struct device_node *dn, *mydn;
+        struct device_node *dn;
         struct iommu_table *tbl;
 
-        DBG("iommu_dev_setup_pSeries, dev %p (%s)\n", dev, pci_name(dev));
+        DBG("pci_dma_dev_setup_pSeries: %s\n", pci_name(dev));
 
-        mydn = dn = pci_device_to_OF_node(dev);
+        dn = dev->dev.archdata.of_node;
 
         /* If we're the direct child of a root bus, then we need to allocate
          * an iommu table ourselves. The bus setup code should have setup
          * the window sizes already.
          */
         if (!dev->bus->self) {
+                struct pci_controller *phb = PCI_DN(dn)->phb;
+
                 DBG(" --> first child, no bridge. Allocating iommu table.\n");
                 tbl = kmalloc_node(sizeof(struct iommu_table), GFP_KERNEL,
-                                   PCI_DN(dn)->phb->node);
-                iommu_table_setparms(PCI_DN(dn)->phb, dn, tbl);
-                PCI_DN(dn)->iommu_table = iommu_init_table(tbl,
-                                                PCI_DN(dn)->phb->node);
-
+                                   phb->node);
+                iommu_table_setparms(phb, dn, tbl);
+                dev->dev.archdata.dma_data = iommu_init_table(tbl, phb->node);
                 return;
         }
 
@@ -465,11 +470,11 @@ static void iommu_dev_setup_pSeries(struct pci_dev *dev)
         while (dn && PCI_DN(dn) && PCI_DN(dn)->iommu_table == NULL)
                 dn = dn->parent;
 
-        if (dn && PCI_DN(dn)) {
-                PCI_DN(mydn)->iommu_table = PCI_DN(dn)->iommu_table;
-        } else {
-                DBG("iommu_dev_setup_pSeries, dev %p (%s) has no iommu table\n", dev, pci_name(dev));
-        }
+        if (dn && PCI_DN(dn))
+                dev->dev.archdata.dma_data = PCI_DN(dn)->iommu_table;
+        else
+                printk(KERN_WARNING "iommu: Device %s has no iommu table\n",
+                       pci_name(dev));
 }
 
 static int iommu_reconfig_notifier(struct notifier_block *nb, unsigned long action, void *node)
@@ -495,13 +500,15 @@ static struct notifier_block iommu_reconfig_nb = {
         .notifier_call = iommu_reconfig_notifier,
 };
 
-static void iommu_dev_setup_pSeriesLP(struct pci_dev *dev)
+static void pci_dma_dev_setup_pSeriesLP(struct pci_dev *dev)
 {
         struct device_node *pdn, *dn;
         struct iommu_table *tbl;
         const void *dma_window = NULL;
         struct pci_dn *pci;
 
+        DBG("pci_dma_dev_setup_pSeriesLP: %s\n", pci_name(dev));
+
         /* dev setup for LPAR is a little tricky, since the device tree might
          * contain the dma-window properties per-device and not neccesarily
          * for the bus. So we need to search upwards in the tree until we
@@ -509,9 +516,7 @@ static void iommu_dev_setup_pSeriesLP(struct pci_dev *dev)
          * already allocated.
          */
         dn = pci_device_to_OF_node(dev);
-
-        DBG("iommu_dev_setup_pSeriesLP, dev %p (%s) %s\n",
-             dev, pci_name(dev), dn->full_name);
+        DBG("  node is %s\n", dn->full_name);
 
         for (pdn = dn; pdn && PCI_DN(pdn) && !PCI_DN(pdn)->iommu_table;
              pdn = pdn->parent) {
@@ -520,16 +525,17 @@ static void iommu_dev_setup_pSeriesLP(struct pci_dev *dev)
                         break;
         }
 
+        DBG("  parent is %s\n", pdn->full_name);
+
         /* Check for parent == NULL so we don't try to setup the empty EADS
          * slots on POWER4 machines.
          */
         if (dma_window == NULL || pdn->parent == NULL) {
-                DBG("No dma window for device, linking to parent\n");
-                PCI_DN(dn)->iommu_table = PCI_DN(pdn)->iommu_table;
+                DBG("  no dma window for device, linking to parent\n");
+                dev->dev.archdata.dma_data = PCI_DN(pdn)->iommu_table;
                 return;
-        } else {
-                DBG("Found DMA window, allocating table\n");
         }
+        DBG("  found DMA window, table: %p\n", pci->iommu_table);
 
         pci = PCI_DN(pdn);
         if (!pci->iommu_table) {
@@ -542,24 +548,20 @@ static void iommu_dev_setup_pSeriesLP(struct pci_dev *dev)
                 iommu_table_setparms_lpar(pci->phb, pdn, tbl, dma_window);
 
                 pci->iommu_table = iommu_init_table(tbl, pci->phb->node);
+                DBG("  created table: %p\n", pci->iommu_table);
         }
 
-        if (pdn != dn)
-                PCI_DN(dn)->iommu_table = pci->iommu_table;
+        dev->dev.archdata.dma_data = pci->iommu_table;
 }
 
-static void iommu_bus_setup_null(struct pci_bus *b) { }
-static void iommu_dev_setup_null(struct pci_dev *d) { }
-
 /* These are called very early. */
 void iommu_init_early_pSeries(void)
 {
         if (of_chosen && get_property(of_chosen, "linux,iommu-off", NULL)) {
                 /* Direct I/O, IOMMU off */
-                ppc_md.iommu_dev_setup = iommu_dev_setup_null;
-                ppc_md.iommu_bus_setup = iommu_bus_setup_null;
-                pci_direct_iommu_init();
-
+                ppc_md.pci_dma_dev_setup = NULL;
+                ppc_md.pci_dma_bus_setup = NULL;
+                pci_dma_ops = &dma_direct_ops;
                 return;
         }
 
@@ -572,19 +574,19 @@ void iommu_init_early_pSeries(void)
                         ppc_md.tce_free  = tce_free_pSeriesLP;
                 }
                 ppc_md.tce_get   = tce_get_pSeriesLP;
-                ppc_md.iommu_bus_setup = iommu_bus_setup_pSeriesLP;
-                ppc_md.iommu_dev_setup = iommu_dev_setup_pSeriesLP;
+                ppc_md.pci_dma_bus_setup = pci_dma_bus_setup_pSeriesLP;
+                ppc_md.pci_dma_dev_setup = pci_dma_dev_setup_pSeriesLP;
         } else {
                 ppc_md.tce_build = tce_build_pSeries;
                 ppc_md.tce_free  = tce_free_pSeries;
                 ppc_md.tce_get   = tce_get_pseries;
-                ppc_md.iommu_bus_setup = iommu_bus_setup_pSeries;
-                ppc_md.iommu_dev_setup = iommu_dev_setup_pSeries;
+                ppc_md.pci_dma_bus_setup = pci_dma_bus_setup_pSeries;
+                ppc_md.pci_dma_dev_setup = pci_dma_dev_setup_pSeries;
         }
 
 
         pSeries_reconfig_notifier_register(&iommu_reconfig_nb);
 
-        pci_iommu_init();
+        pci_dma_ops = &dma_iommu_ops;
 }