4 files changed, 87 insertions, 34 deletions

diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index 97ddc02a3d42..68e5ab0443d2 100644
--- a/arch/powerpc/kernel/ibmebus.c
+++ b/arch/powerpc/kernel/ibmebus.c
@@ -323,7 +323,7 @@ int ibmebus_request_irq(struct ibmebus_dev *dev,
                         unsigned long irq_flags, const char * devname,
                         void *dev_id)
 {
-        unsigned int irq = irq_create_mapping(NULL, ist, 0);
+        unsigned int irq = irq_create_mapping(NULL, ist);
         
         if (irq == NO_IRQ)
                 return -EINVAL;
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index 8cf987809c66..01bdae35cb55 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -391,15 +391,14 @@ struct irq_host *irq_alloc_host(unsigned int revmap_type,
                         irq_map[i].host = host;
                         smp_wmb();
 
-                        /* Clear some flags */
-                        get_irq_desc(i)->status
-                                &= ~(IRQ_NOREQUEST | IRQ_LEVEL);
+                        /* Clear norequest flags */
+                        get_irq_desc(i)->status &= ~IRQ_NOREQUEST;
 
                         /* Legacy flags are left to default at this point,
                          * one can then use irq_create_mapping() to
                          * explicitely change them
                          */
-                        ops->map(host, i, i, 0);
+                        ops->map(host, i, i);
                 }
                 break;
         case IRQ_HOST_MAP_LINEAR:
@@ -457,13 +456,11 @@ void irq_set_virq_count(unsigned int count)
 }
 
 unsigned int irq_create_mapping(struct irq_host *host,
-                                irq_hw_number_t hwirq,
-                                unsigned int flags)
+                                irq_hw_number_t hwirq)
 {
         unsigned int virq, hint;
 
-        pr_debug("irq: irq_create_mapping(0x%p, 0x%lx, 0x%x)\n",
-                 host, hwirq, flags);
+        pr_debug("irq: irq_create_mapping(0x%p, 0x%lx)\n", host, hwirq);
 
         /* Look for default host if nececssary */
         if (host == NULL)
@@ -482,7 +479,6 @@ unsigned int irq_create_mapping(struct irq_host *host,
         virq = irq_find_mapping(host, hwirq);
         if (virq != IRQ_NONE) {
                 pr_debug("irq: -> existing mapping on virq %d\n", virq);
-                host->ops->map(host, virq, hwirq, flags);
                 return virq;
         }
 
@@ -504,18 +500,18 @@ unsigned int irq_create_mapping(struct irq_host *host,
         }
         pr_debug("irq: -> obtained virq %d\n", virq);
 
-        /* Clear some flags */
-        get_irq_desc(virq)->status &= ~(IRQ_NOREQUEST | IRQ_LEVEL);
+        /* Clear IRQ_NOREQUEST flag */
+        get_irq_desc(virq)->status &= ~IRQ_NOREQUEST;
 
         /* map it */
-        if (host->ops->map(host, virq, hwirq, flags)) {
+        smp_wmb();
+        irq_map[virq].hwirq = hwirq;
+        smp_mb();
+        if (host->ops->map(host, virq, hwirq)) {
                 pr_debug("irq: -> mapping failed, freeing\n");
                 irq_free_virt(virq, 1);
                 return NO_IRQ;
         }
-        smp_wmb();
-        irq_map[virq].hwirq = hwirq;
-        smp_mb();
         return virq;
 }
 EXPORT_SYMBOL_GPL(irq_create_mapping);
@@ -525,25 +521,38 @@ extern unsigned int irq_create_of_mapping(struct device_node *controller,
 {
         struct irq_host *host;
         irq_hw_number_t hwirq;
-        unsigned int flags = IRQ_TYPE_NONE;
+        unsigned int type = IRQ_TYPE_NONE;
+        unsigned int virq;
 
         if (controller == NULL)
                 host = irq_default_host;
         else
                 host = irq_find_host(controller);
-        if (host == NULL)
+        if (host == NULL) {
+                printk(KERN_WARNING "irq: no irq host found for %s !\n",
+                       controller->full_name);
                 return NO_IRQ;
+        }
 
         /* If host has no translation, then we assume interrupt line */
         if (host->ops->xlate == NULL)
                 hwirq = intspec[0];
         else {
                 if (host->ops->xlate(host, controller, intspec, intsize,
-                                     &hwirq, &flags))
+                                     &hwirq, &type))
                         return NO_IRQ;
         }
 
-        return irq_create_mapping(host, hwirq, flags);
+        /* Create mapping */
+        virq = irq_create_mapping(host, hwirq);
+        if (virq == NO_IRQ)
+                return virq;
+
+        /* Set type if specified and different than the current one */
+        if (type != IRQ_TYPE_NONE &&
+            type != (get_irq_desc(virq)->status & IRQF_TRIGGER_MASK))
+                set_irq_type(virq, type);
+        return virq;
 }
 EXPORT_SYMBOL_GPL(irq_create_of_mapping);
 
diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c
index 898dae8ab6d9..09b1e1bbb29b 100644
--- a/arch/powerpc/kernel/pci_32.c
+++ b/arch/powerpc/kernel/pci_32.c
@@ -11,6 +11,7 @@
 #include <linux/sched.h>
 #include <linux/errno.h>
 #include <linux/bootmem.h>
+#include <linux/irq.h>
 
 #include <asm/processor.h>
 #include <asm/io.h>
@@ -18,7 +19,6 @@
 #include <asm/sections.h>
 #include <asm/pci-bridge.h>
 #include <asm/byteorder.h>
-#include <asm/irq.h>
 #include <asm/uaccess.h>
 #include <asm/machdep.h>
 
@@ -1420,15 +1420,37 @@ int pci_read_irq_line(struct pci_dev *pci_dev)
 
         DBG("Try to map irq for %s...\n", pci_name(pci_dev));
 
+        /* Try to get a mapping from the device-tree */
         if (of_irq_map_pci(pci_dev, &oirq)) {
-                DBG(" -> failed !\n");
-                return -1;
-        }
+                u8 line, pin;
+
+                /* If that fails, lets fallback to what is in the config
+                 * space and map that through the default controller. We
+                 * also set the type to level low since that's what PCI
+                 * interrupts are. If your platform does differently, then
+                 * either provide a proper interrupt tree or don't use this
+                 * function.
+                 */
+                if (pci_read_config_byte(pci_dev, PCI_INTERRUPT_PIN, &pin))
+                        return -1;
+                if (pin == 0)
+                        return -1;
+                if (pci_read_config_byte(pci_dev, PCI_INTERRUPT_LINE, &line) ||
+                    line == 0xff) {
+                        return -1;
+                }
+                DBG(" -> no map ! Using irq line %d from PCI config\n", line);
 
-        DBG(" -> got one, spec %d cells (0x%08x...) on %s\n",
-            oirq.size, oirq.specifier[0], oirq.controller->full_name);
+                virq = irq_create_mapping(NULL, line);
+                if (virq != NO_IRQ)
+                        set_irq_type(virq, IRQ_TYPE_LEVEL_LOW);
+        } else {
+                DBG(" -> got one, spec %d cells (0x%08x...) on %s\n",
+                    oirq.size, oirq.specifier[0], oirq.controller->full_name);
 
-        virq = irq_create_of_mapping(oirq.controller, oirq.specifier, oirq.size);
+                virq = irq_create_of_mapping(oirq.controller, oirq.specifier,
+                                             oirq.size);
+        }
         if(virq == NO_IRQ) {
                 DBG(" -> failed to map !\n");
                 return -1;
diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c
index efc0b5559ee0..2fce7738e9e2 100644
--- a/arch/powerpc/kernel/pci_64.c
+++ b/arch/powerpc/kernel/pci_64.c
@@ -21,13 +21,13 @@
 #include <linux/mm.h>
 #include <linux/list.h>
 #include <linux/syscalls.h>
+#include <linux/irq.h>
 
 #include <asm/processor.h>
 #include <asm/io.h>
 #include <asm/prom.h>
 #include <asm/pci-bridge.h>
 #include <asm/byteorder.h>
-#include <asm/irq.h>
 #include <asm/machdep.h>
 #include <asm/ppc-pci.h>
 
@@ -1289,15 +1289,37 @@ int pci_read_irq_line(struct pci_dev *pci_dev)
 
         DBG("Try to map irq for %s...\n", pci_name(pci_dev));
 
+        /* Try to get a mapping from the device-tree */
         if (of_irq_map_pci(pci_dev, &oirq)) {
-                DBG(" -> failed !\n");
-                return -1;
-        }
+                u8 line, pin;
+
+                /* If that fails, lets fallback to what is in the config
+                 * space and map that through the default controller. We
+                 * also set the type to level low since that's what PCI
+                 * interrupts are. If your platform does differently, then
+                 * either provide a proper interrupt tree or don't use this
+                 * function.
+                 */
+                if (pci_read_config_byte(pci_dev, PCI_INTERRUPT_PIN, &pin))
+                        return -1;
+                if (pin == 0)
+                        return -1;
+                if (pci_read_config_byte(pci_dev, PCI_INTERRUPT_LINE, &line) ||
+                    line == 0xff) {
+                        return -1;
+                }
+                DBG(" -> no map ! Using irq line %d from PCI config\n", line);
 
-        DBG(" -> got one, spec %d cells (0x%08x...) on %s\n",
-            oirq.size, oirq.specifier[0], oirq.controller->full_name);
+                virq = irq_create_mapping(NULL, line);
+                if (virq != NO_IRQ)
+                        set_irq_type(virq, IRQ_TYPE_LEVEL_LOW);
+        } else {
+                DBG(" -> got one, spec %d cells (0x%08x...) on %s\n",
+                    oirq.size, oirq.specifier[0], oirq.controller->full_name);
 
-        virq = irq_create_of_mapping(oirq.controller, oirq.specifier, oirq.size);
+                virq = irq_create_of_mapping(oirq.controller, oirq.specifier,
+                                             oirq.size);
+        }
         if(virq == NO_IRQ) {
                 DBG(" -> failed to map !\n");
                 return -1;