5 files changed, 26 insertions, 37 deletions

diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
index 5259d8c20676..837530ea32e7 100644
--- a/arch/parisc/kernel/cache.c
+++ b/arch/parisc/kernel/cache.c
@@ -551,10 +551,7 @@ void flush_cache_range(struct vm_area_struct *vma,
 {
         int sr3;
 
-        if (!vma->vm_mm->context) {
-                BUG();
-                return;
-        }
+        BUG_ON(!vma->vm_mm->context);
 
         sr3 = mfsp(3);
         if (vma->vm_mm->context == sr3) {
diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S
index d1fa4edd2d80..0db9fdcb7709 100644
--- a/arch/parisc/kernel/entry.S
+++ b/arch/parisc/kernel/entry.S
@@ -368,7 +368,7 @@
          * abstractions for the macros */
         .macro          EXTR    reg1,start,length,reg2
 #ifdef CONFIG_64BIT
-        extrd,u         \reg1,32+\start,\length,\reg2
+        extrd,u         \reg1,32+(\start),\length,\reg2
 #else
         extrw,u         \reg1,\start,\length,\reg2
 #endif
@@ -376,7 +376,7 @@
 
         .macro          DEP     reg1,start,length,reg2
 #ifdef CONFIG_64BIT
-        depd            \reg1,32+\start,\length,\reg2
+        depd            \reg1,32+(\start),\length,\reg2
 #else
         depw            \reg1,\start,\length,\reg2
 #endif
@@ -384,7 +384,7 @@
 
         .macro          DEPI    val,start,length,reg
 #ifdef CONFIG_64BIT
-        depdi           \val,32+\start,\length,\reg
+        depdi           \val,32+(\start),\length,\reg
 #else
         depwi           \val,\start,\length,\reg
 #endif
diff --git a/arch/parisc/kernel/firmware.c b/arch/parisc/kernel/firmware.c
index 03f26bd75bd8..f6d241238a78 100644
--- a/arch/parisc/kernel/firmware.c
+++ b/arch/parisc/kernel/firmware.c
@@ -151,7 +151,7 @@ static void convert_to_wide(unsigned long *addr)
 }
 
 #ifdef CONFIG_64BIT
-void __init set_firmware_width_unlocked(void)
+void __cpuinit set_firmware_width_unlocked(void)
 {
         int ret;
 
@@ -168,7 +168,7 @@ void __init set_firmware_width_unlocked(void)
  * This function must be called before any pdc_* function that uses the
  * convert_to_wide function.
  */
-void __init set_firmware_width(void)
+void __cpuinit set_firmware_width(void)
 {
         unsigned long flags;
         spin_lock_irqsave(&pdc_lock, flags);
@@ -176,11 +176,11 @@ void __init set_firmware_width(void)
         spin_unlock_irqrestore(&pdc_lock, flags);
 }
 #else
-void __init set_firmware_width_unlocked(void) {
+void __cpuinit set_firmware_width_unlocked(void) {
         return;
 }
 
-void __init set_firmware_width(void) {
+void __cpuinit set_firmware_width(void) {
         return;
 }
 #endif /*CONFIG_64BIT*/
@@ -302,7 +302,7 @@ int pdc_chassis_warn(unsigned long *warn)
         return retval;
 }
 
-int __init pdc_coproc_cfg_unlocked(struct pdc_coproc_cfg *pdc_coproc_info)
+int __cpuinit pdc_coproc_cfg_unlocked(struct pdc_coproc_cfg *pdc_coproc_info)
 {
         int ret;
 
@@ -323,7 +323,7 @@ int __init pdc_coproc_cfg_unlocked(struct pdc_coproc_cfg *pdc_coproc_info)
  * This PDC call returns the presence and status of all the coprocessors
  * attached to the processor.
  */
-int __init pdc_coproc_cfg(struct pdc_coproc_cfg *pdc_coproc_info)
+int __cpuinit pdc_coproc_cfg(struct pdc_coproc_cfg *pdc_coproc_info)
 {
         int ret;
         unsigned long flags;
diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c
index ac2c822928c7..29e70e16ede8 100644
--- a/arch/parisc/kernel/irq.c
+++ b/arch/parisc/kernel/irq.c
@@ -112,7 +112,7 @@ void cpu_end_irq(unsigned int irq)
 }
 
 #ifdef CONFIG_SMP
-int cpu_check_affinity(unsigned int irq, cpumask_t *dest)
+int cpu_check_affinity(unsigned int irq, const struct cpumask *dest)
 {
         int cpu_dest;
 
@@ -120,23 +120,25 @@ int cpu_check_affinity(unsigned int irq, cpumask_t *dest)
         if (CHECK_IRQ_PER_CPU(irq)) {
                 /* Bad linux design decision.  The mask has already
                  * been set; we must reset it */
-                irq_desc[irq].affinity = CPU_MASK_ALL;
+                cpumask_setall(&irq_desc[irq].affinity);
                 return -EINVAL;
         }
 
         /* whatever mask they set, we just allow one CPU */
         cpu_dest = first_cpu(*dest);
-        *dest = cpumask_of_cpu(cpu_dest);
 
-        return 0;
+        return cpu_dest;
 }
 
 static void cpu_set_affinity_irq(unsigned int irq, const struct cpumask *dest)
 {
-        if (cpu_check_affinity(irq, dest))
+        int cpu_dest;
+
+        cpu_dest = cpu_check_affinity(irq, dest);
+        if (cpu_dest < 0)
                 return;
 
-        irq_desc[irq].affinity = *dest;
+        cpumask_copy(&irq_desc[irq].affinity, &cpumask_of_cpu(cpu_dest));
 }
 #endif
 
@@ -295,7 +297,7 @@ int txn_alloc_irq(unsigned int bits_wide)
 unsigned long txn_affinity_addr(unsigned int irq, int cpu)
 {
 #ifdef CONFIG_SMP
-        irq_desc[irq].affinity = cpumask_of_cpu(cpu);
+        cpumask_copy(&irq_desc[irq].affinity, cpumask_of(cpu));
 #endif
 
         return per_cpu(cpu_data, cpu).txn_addr;
@@ -352,7 +354,7 @@ void do_cpu_irq_mask(struct pt_regs *regs)
         irq = eirr_to_irq(eirr_val);
 
 #ifdef CONFIG_SMP
-        dest = irq_desc[irq].affinity;
+        cpumask_copy(&dest, &irq_desc[irq].affinity);
         if (CHECK_IRQ_PER_CPU(irq_desc[irq].status) &&
             !cpu_isset(smp_processor_id(), dest)) {
                 int cpu = first_cpu(dest);
diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index df47895db828..7d927eac932b 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -447,10 +447,7 @@ static void pa11_dma_free_consistent (struct device *dev, size_t size, void *vad
 
 static dma_addr_t pa11_dma_map_single(struct device *dev, void *addr, size_t size, enum dma_data_direction direction)
 {
-        if (direction == DMA_NONE) {
-                printk(KERN_ERR "pa11_dma_map_single(PCI_DMA_NONE) called by %p\n", __builtin_return_address(0));
-                BUG();
-        }
+        BUG_ON(direction == DMA_NONE);
 
         flush_kernel_dcache_range((unsigned long) addr, size);
         return virt_to_phys(addr);
@@ -458,10 +455,7 @@ static dma_addr_t pa11_dma_map_single(struct device *dev, void *addr, size_t siz
 
 static void pa11_dma_unmap_single(struct device *dev, dma_addr_t dma_handle, size_t size, enum dma_data_direction direction)
 {
-        if (direction == DMA_NONE) {
-                printk(KERN_ERR "pa11_dma_unmap_single(PCI_DMA_NONE) called by %p\n", __builtin_return_address(0));
-                BUG();
-        }
+        BUG_ON(direction == DMA_NONE);
 
         if (direction == DMA_TO_DEVICE)
             return;
@@ -480,8 +474,7 @@ static int pa11_dma_map_sg(struct device *dev, struct scatterlist *sglist, int n
 {
         int i;
 
-        if (direction == DMA_NONE)
-            BUG();
+        BUG_ON(direction == DMA_NONE);
 
         for (i = 0; i < nents; i++, sglist++ ) {
                 unsigned long vaddr = sg_virt_addr(sglist);
@@ -496,8 +489,7 @@ static void pa11_dma_unmap_sg(struct device *dev, struct scatterlist *sglist, in
 {
         int i;
 
-        if (direction == DMA_NONE)
-            BUG();
+        BUG_ON(direction == DMA_NONE);
 
         if (direction == DMA_TO_DEVICE)
             return;
@@ -511,16 +503,14 @@ static void pa11_dma_unmap_sg(struct device *dev, struct scatterlist *sglist, in
 
 static void pa11_dma_sync_single_for_cpu(struct device *dev, dma_addr_t dma_handle, unsigned long offset, size_t size, enum dma_data_direction direction)
 {
-        if (direction == DMA_NONE)
-            BUG();
+        BUG_ON(direction == DMA_NONE);
 
         flush_kernel_dcache_range((unsigned long) phys_to_virt(dma_handle) + offset, size);
 }
 
 static void pa11_dma_sync_single_for_device(struct device *dev, dma_addr_t dma_handle, unsigned long offset, size_t size, enum dma_data_direction direction)
 {
-        if (direction == DMA_NONE)
-            BUG();
+        BUG_ON(direction == DMA_NONE);
 
         flush_kernel_dcache_range((unsigned long) phys_to_virt(dma_handle) + offset, size);
 }