1 files changed, 17 insertions, 14 deletions

diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index f1c0fb974177..bdbd7da99286 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -40,6 +40,7 @@
 #include <linux/device.h>
 #include <linux/init.h>
 #include <linux/mutex.h>
+#include <linux/kthread.h>
 
 #include <asm/dma.h>
 #include <asm/ecard.h>
@@ -50,6 +51,8 @@
 #include <asm/mach/irq.h>
 #include <asm/tlbflush.h>
 
+#include "ecard.h"
+
 #ifndef CONFIG_ARCH_RPC
 #define HAVE_EXPMASK
 #endif
@@ -123,7 +126,7 @@ static void ecard_task_reset(struct ecard_request *req)
 
         res = ec->slot_no == 8
                 ? &ec->resource[ECARD_RES_MEMC]
-                : ec->type == ECARD_EASI
+                : ec->easi
                   ? &ec->resource[ECARD_RES_EASI]
                   : &ec->resource[ECARD_RES_IOCSYNC];
 
@@ -178,7 +181,7 @@ static void ecard_task_readbytes(struct ecard_request *req)
                         index += 1;
                 }
         } else {
-                unsigned long base = (ec->type == ECARD_EASI
+                unsigned long base = (ec->easi
                          ? &ec->resource[ECARD_RES_EASI]
                          : &ec->resource[ECARD_RES_IOCSYNC])->start;
                 void __iomem *pbase = (void __iomem *)base;
@@ -263,8 +266,6 @@ static int ecard_init_mm(void)
 static int
 ecard_task(void * unused)
 {
-        daemonize("kecardd");
-
         /*
          * Allocate a mm.  We're not a lazy-TLB kernel task since we need
          * to set page table entries where the user space would be.  Note
@@ -727,7 +728,7 @@ static int ecard_prints(char *buffer, ecard_t *ec)
         char *start = buffer;
 
         buffer += sprintf(buffer, "  %d: %s ", ec->slot_no,
-                          ec->type == ECARD_EASI ? "EASI" : "    ");
+                          ec->easi ? "EASI" : "    ");
 
         if (ec->cid.id == 0) {
                 struct in_chunk_dir incd;
@@ -814,7 +815,7 @@ static struct expansion_card *__init ecard_alloc_card(int type, int slot)
         }
 
         ec->slot_no = slot;
-        ec->type = type;
+        ec->easi = type == ECARD_EASI;
         ec->irq = NO_IRQ;
         ec->fiq = NO_IRQ;
         ec->dma = NO_DMA;
@@ -825,6 +826,7 @@ static struct expansion_card *__init ecard_alloc_card(int type, int slot)
         ec->dev.bus = &ecard_bus_type;
         ec->dev.dma_mask = &ec->dma_mask;
         ec->dma_mask = (u64)0xffffffff;
+        ec->dev.coherent_dma_mask = ec->dma_mask;
 
         if (slot < 4) {
                 ec_set_resource(ec, ECARD_RES_MEMC,
@@ -907,7 +909,7 @@ static ssize_t ecard_show_device(struct device *dev, struct device_attribute *at
 static ssize_t ecard_show_type(struct device *dev, struct device_attribute *attr, char *buf)
 {
         struct expansion_card *ec = ECARD_DEV(dev);
-        return sprintf(buf, "%s\n", ec->type == ECARD_EASI ? "EASI" : "IOC");
+        return sprintf(buf, "%s\n", ec->easi ? "EASI" : "IOC");
 }
 
 static struct device_attribute ecard_dev_attrs[] = {
@@ -1058,13 +1060,14 @@ ecard_probe(int slot, card_type_t type)
  */
 static int __init ecard_init(void)
 {
-        int slot, irqhw, ret;
-
-        ret = kernel_thread(ecard_task, NULL, CLONE_KERNEL);
-        if (ret < 0) {
-                printk(KERN_ERR "Ecard: unable to create kernel thread: %d\n",
-                       ret);
-                return ret;
+        struct task_struct *task;
+        int slot, irqhw;
+
+        task = kthread_run(ecard_task, NULL, "kecardd");
+        if (IS_ERR(task)) {
+                printk(KERN_ERR "Ecard: unable to create kernel thread: %ld\n",
+                       PTR_ERR(task));
+                return PTR_ERR(task);
         }
 
         printk("Probing expansion cards\n");