2 files changed, 12 insertions, 19 deletions

diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 9d63a01214eb..cbf2165476b0 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -93,15 +93,12 @@ static void print_alloc_stats(struct dmabounce_device_info *device_info)
 static inline struct dmabounce_device_info *
 find_dmabounce_dev(struct device *dev)
 {
-        struct list_head *entry;
-
-        list_for_each(entry, &dmabounce_devs) {
-                struct dmabounce_device_info *d =
-                        list_entry(entry, struct dmabounce_device_info, node);
+        struct dmabounce_device_info *d;
 
+        list_for_each_entry(d, &dmabounce_devs, node)
                 if (d->dev == dev)
                         return d;
-        }
+
         return NULL;
 }
 
@@ -172,15 +169,11 @@ alloc_safe_buffer(struct dmabounce_device_info *device_info, void *ptr,
 static inline struct safe_buffer *
 find_safe_buffer(struct dmabounce_device_info *device_info, dma_addr_t safe_dma_addr)
 {
-        struct list_head *entry;
-
-        list_for_each(entry, &device_info->safe_buffers) {
-                struct safe_buffer *b =
-                        list_entry(entry, struct safe_buffer, node);
+        struct safe_buffer *b;
 
+        list_for_each_entry(b, &device_info->safe_buffers, node)
                 if (b->safe_dma_addr == safe_dma_addr)
                         return b;
-        }
 
         return NULL;
 }
@@ -301,7 +294,6 @@ unmap_single(struct device *dev, dma_addr_t dma_addr, size_t size,
                         __func__, buf->ptr, (void *) virt_to_dma(dev, buf->ptr),
                         buf->safe, (void *) buf->safe_dma_addr);
 
-
                 DO_STATS ( device_info->bounce_count++ );
 
                 if (dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL) {
diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
index 21fce3414ed1..38c2eb667eb9 100644
--- a/arch/arm/common/sa1111.c
+++ b/arch/arm/common/sa1111.c
@@ -721,16 +721,17 @@ __sa1111_probe(struct device *me, struct resource *mem, int irq)
         return ret;
 }
 
+static int sa1111_remove_one(struct device *dev, void *data)
+{
+        device_unregister(dev);
+        return 0;
+}
+
 static void __sa1111_remove(struct sa1111 *sachip)
 {
-        struct list_head *l, *n;
         void __iomem *irqbase = sachip->base + SA1111_INTC;
 
-        list_for_each_safe(l, n, &sachip->dev->children) {
-                struct device *d = list_to_dev(l);
-
-                device_unregister(d);
-        }
+        device_for_each_child(sachip->dev, NULL, sa1111_remove_one);
 
         /* disable all IRQs */
         sa1111_writel(0, irqbase + SA1111_INTEN0);