diff options
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r-- | Documentation/SubmittingPatches | 20 |
1 files changed, 18 insertions, 2 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 0958e97d4bf4..3f9a7912e69b 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches | |||
@@ -464,9 +464,25 @@ section Linus Computer Science 101. | |||
464 | Nuff said. If your code deviates too much from this, it is likely | 464 | Nuff said. If your code deviates too much from this, it is likely |
465 | to be rejected without further review, and without comment. | 465 | to be rejected without further review, and without comment. |
466 | 466 | ||
467 | Once significant exception is when moving code from one file to | ||
468 | another in this case you should not modify the moved code at all in | ||
469 | the same patch which moves it. This clearly delineates the act of | ||
470 | moving the code and your changes. This greatly aids review of the | ||
471 | actual differences and allows tools to better track the history of | ||
472 | the code itself. | ||
473 | |||
467 | Check your patches with the patch style checker prior to submission | 474 | Check your patches with the patch style checker prior to submission |
468 | (scripts/checkpatch.pl). You should be able to justify all | 475 | (scripts/checkpatch.pl). The style checker should be viewed as |
469 | violations that remain in your patch. | 476 | a guide not as the final word. If your code looks better with |
477 | a violation then its probably best left alone. | ||
478 | |||
479 | The checker reports at three levels: | ||
480 | - ERROR: things that are very likely to be wrong | ||
481 | - WARNING: things requiring careful review | ||
482 | - CHECK: things requiring thought | ||
483 | |||
484 | You should be able to justify all violations that remain in your | ||
485 | patch. | ||
470 | 486 | ||
471 | 487 | ||
472 | 488 | ||