aboutsummaryrefslogtreecommitdiffstats
path: root/Documentation/SubmittingPatches
diff options
context:
space:
mode:
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r--Documentation/SubmittingPatches20
1 files changed, 18 insertions, 2 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 0958e97d4bf4..3f9a7912e69b 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -464,9 +464,25 @@ section Linus Computer Science 101.
464Nuff said. If your code deviates too much from this, it is likely 464Nuff said. If your code deviates too much from this, it is likely
465to be rejected without further review, and without comment. 465to be rejected without further review, and without comment.
466 466
467Once significant exception is when moving code from one file to
468another in this case you should not modify the moved code at all in
469the same patch which moves it. This clearly delineates the act of
470moving the code and your changes. This greatly aids review of the
471actual differences and allows tools to better track the history of
472the code itself.
473
467Check your patches with the patch style checker prior to submission 474Check your patches with the patch style checker prior to submission
468(scripts/checkpatch.pl). You should be able to justify all 475(scripts/checkpatch.pl). The style checker should be viewed as
469violations that remain in your patch. 476a guide not as the final word. If your code looks better with
477a violation then its probably best left alone.
478
479The checker reports at three levels:
480 - ERROR: things that are very likely to be wrong
481 - WARNING: things requiring careful review
482 - CHECK: things requiring thought
483
484You should be able to justify all violations that remain in your
485patch.
470 486
471 487
472 488