6 files changed, 64 insertions, 54 deletions

diff --git a/arch/x86/kernel/cpu/addon_cpuid_features.c b/arch/x86/kernel/cpu/addon_cpuid_features.c
index c2e1ce33c7cb..84a8220a6072 100644
--- a/arch/x86/kernel/cpu/addon_cpuid_features.c
+++ b/arch/x86/kernel/cpu/addon_cpuid_features.c
@@ -1,9 +1,7 @@
-
 /*
  *      Routines to indentify additional cpu features that are scattered in
  *      cpuid space.
  */
-
 #include <linux/cpu.h>
 
 #include <asm/pat.h>
@@ -53,19 +51,20 @@ void __cpuinit init_scattered_cpuid_features(struct cpuinfo_x86 *c)
 #ifdef CONFIG_X86_PAT
 void __cpuinit validate_pat_support(struct cpuinfo_x86 *c)
 {
+        if (!cpu_has_pat)
+                pat_disable("PAT not supported by CPU.");
+
         switch (c->x86_vendor) {
-        case X86_VENDOR_AMD:
-                if (c->x86 >= 0xf && c->x86 <= 0x11)
-                        return;
-                break;
         case X86_VENDOR_INTEL:
                 if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >= 15))
                         return;
                 break;
+        case X86_VENDOR_AMD:
+        case X86_VENDOR_CENTAUR:
+        case X86_VENDOR_TRANSMETA:
+                return;
         }
 
-        pat_disable(cpu_has_pat ?
-                    "PAT disabled. Not yet verified on this CPU type." :
-                    "PAT not supported by CPU.");
+        pat_disable("PAT disabled. Not yet verified on this CPU type.");
 }
 #endif
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 2b2bb3f9b683..7452eb31ed12 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -261,7 +261,7 @@ void __iomem *ioremap_nocache(resource_size_t phys_addr, unsigned long size)
 {
         /*
          * Ideally, this should be:
-         *      pat_wc_enabled ? _PAGE_CACHE_UC : _PAGE_CACHE_UC_MINUS;
+         *      pat_enabled ? _PAGE_CACHE_UC : _PAGE_CACHE_UC_MINUS;
          *
          * Till we fix all X drivers to use ioremap_wc(), we will use
          * UC MINUS.
@@ -285,7 +285,7 @@ EXPORT_SYMBOL(ioremap_nocache);
  */
 void __iomem *ioremap_wc(unsigned long phys_addr, unsigned long size)
 {
-        if (pat_wc_enabled)
+        if (pat_enabled)
                 return __ioremap_caller(phys_addr, size, _PAGE_CACHE_WC,
                                         __builtin_return_address(0));
         else
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 60bcb5b6a37e..6916fe4bf0cb 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -805,7 +805,7 @@ int _set_memory_wc(unsigned long addr, int numpages)
 
 int set_memory_wc(unsigned long addr, int numpages)
 {
-        if (!pat_wc_enabled)
+        if (!pat_enabled)
                 return set_memory_uc(addr, numpages);
 
         if (reserve_memtype(addr, addr + numpages * PAGE_SIZE,
diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 06b7a1c90fb8..7c21572bbdda 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -26,11 +26,11 @@
 #include <asm/io.h>
 
 #ifdef CONFIG_X86_PAT
-int __read_mostly pat_wc_enabled = 1;
+int __read_mostly pat_enabled = 1;
 
 void __cpuinit pat_disable(char *reason)
 {
-        pat_wc_enabled = 0;
+        pat_enabled = 0;
         printk(KERN_INFO "%s\n", reason);
 }
 
@@ -42,6 +42,19 @@ static int __init nopat(char *str)
 early_param("nopat", nopat);
 #endif
 
+
+static int debug_enable;
+static int __init pat_debug_setup(char *str)
+{
+        debug_enable = 1;
+        return 0;
+}
+__setup("debugpat", pat_debug_setup);
+
+#define dprintk(fmt, arg...) \
+        do { if (debug_enable) printk(KERN_INFO fmt, ##arg); } while (0)
+
+
 static u64 __read_mostly boot_pat_state;
 
 enum {
@@ -53,24 +66,25 @@ enum {
         PAT_UC_MINUS = 7,       /* UC, but can be overriden by MTRR */
 };
 
-#define PAT(x,y)        ((u64)PAT_ ## y << ((x)*8))
+#define PAT(x, y)       ((u64)PAT_ ## y << ((x)*8))
 
 void pat_init(void)
 {
         u64 pat;
 
-        if (!pat_wc_enabled)
+        if (!pat_enabled)
                 return;
 
         /* Paranoia check. */
-        if (!cpu_has_pat) {
-                printk(KERN_ERR "PAT enabled, but CPU feature cleared\n");
+        if (!cpu_has_pat && boot_pat_state) {
                 /*
-                 * Panic if this happens on the secondary CPU, and we
+                 * If this happens we are on a secondary CPU, but
                  * switched to PAT on the boot CPU. We have no way to
                  * undo PAT.
-                */
-                BUG_ON(boot_pat_state);
+                 */
+                printk(KERN_ERR "PAT enabled, "
+                       "but not supported by secondary CPU\n");
+                BUG();
         }
 
         /* Set PWT to Write-Combining. All other bits stay the same */
@@ -86,8 +100,8 @@ void pat_init(void)
          *      011 UC          _PAGE_CACHE_UC
          * PAT bit unused
          */
-        pat = PAT(0,WB) | PAT(1,WC) | PAT(2,UC_MINUS) | PAT(3,UC) |
-              PAT(4,WB) | PAT(5,WC) | PAT(6,UC_MINUS) | PAT(7,UC);
+        pat = PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, UC) |
+              PAT(4, WB) | PAT(5, WC) | PAT(6, UC_MINUS) | PAT(7, UC);
 
         /* Boot CPU check */
         if (!boot_pat_state)
@@ -103,11 +117,11 @@ void pat_init(void)
 static char *cattr_name(unsigned long flags)
 {
         switch (flags & _PAGE_CACHE_MASK) {
-                case _PAGE_CACHE_UC:            return "uncached";
-                case _PAGE_CACHE_UC_MINUS:      return "uncached-minus";
-                case _PAGE_CACHE_WB:            return "write-back";
-                case _PAGE_CACHE_WC:            return "write-combining";
-                default:                        return "broken";
+        case _PAGE_CACHE_UC:            return "uncached";
+        case _PAGE_CACHE_UC_MINUS:      return "uncached-minus";
+        case _PAGE_CACHE_WB:            return "write-back";
+        case _PAGE_CACHE_WC:            return "write-combining";
+        default:                        return "broken";
         }
 }
 
@@ -211,8 +225,8 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
         unsigned long actual_type;
         int err = 0;
 
-        /* Only track when pat_wc_enabled */
-        if (!pat_wc_enabled) {
+        /* Only track when pat_enabled */
+        if (!pat_enabled) {
                 /* This is identical to page table setting without PAT */
                 if (ret_type) {
                         if (req_type == -1) {
@@ -278,7 +292,7 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
                 struct memtype *saved_ptr;
 
                 if (parse->start >= end) {
-                        pr_debug("New Entry\n");
+                        dprintk("New Entry\n");
                         list_add(&new_entry->nd, parse->nd.prev);
                         new_entry = NULL;
                         break;
@@ -328,7 +342,7 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
                                 break;
                         }
 
-                        pr_debug("Overlap at 0x%Lx-0x%Lx\n",
+                        dprintk("Overlap at 0x%Lx-0x%Lx\n",
                                saved_ptr->start, saved_ptr->end);
                         /* No conflict. Go ahead and add this new entry */
                         list_add(&new_entry->nd, saved_ptr->nd.prev);
@@ -380,7 +394,7 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
                                 break;
                         }
 
-                        pr_debug(KERN_INFO "Overlap at 0x%Lx-0x%Lx\n",
+                        dprintk("Overlap at 0x%Lx-0x%Lx\n",
                                  saved_ptr->start, saved_ptr->end);
                         /* No conflict. Go ahead and add this new entry */
                         list_add(&new_entry->nd, &saved_ptr->nd);
@@ -402,16 +416,16 @@ int reserve_memtype(u64 start, u64 end, unsigned long req_type,
         if (new_entry) {
                 /* No conflict. Not yet added to the list. Add to the tail */
                 list_add_tail(&new_entry->nd, &memtype_list);
-                pr_debug("New Entry\n");
+                dprintk("New Entry\n");
         }
 
         if (ret_type) {
-                pr_debug(
+                dprintk(
         "reserve_memtype added 0x%Lx-0x%Lx, track %s, req %s, ret %s\n",
                         start, end, cattr_name(actual_type),
                         cattr_name(req_type), cattr_name(*ret_type));
         } else {
-                pr_debug(
+                dprintk(
         "reserve_memtype added 0x%Lx-0x%Lx, track %s, req %s\n",
                         start, end, cattr_name(actual_type),
                         cattr_name(req_type));
@@ -426,8 +440,8 @@ int free_memtype(u64 start, u64 end)
         struct memtype *ml;
         int err = -EINVAL;
 
-        /* Only track when pat_wc_enabled */
-        if (!pat_wc_enabled) {
+        /* Only track when pat_enabled */
+        if (!pat_enabled) {
                 return 0;
         }
 
@@ -452,7 +466,7 @@ int free_memtype(u64 start, u64 end)
                         current->comm, current->pid, start, end);
         }
 
-        pr_debug("free_memtype request 0x%Lx-0x%Lx\n", start, end);
+        dprintk("free_memtype request 0x%Lx-0x%Lx\n", start, end);
         return err;
 }
 
@@ -521,12 +535,12 @@ int phys_mem_access_prot_allowed(struct file *file, unsigned long pfn,
          * caching for the high addresses through the KEN pin, but
          * we maintain the tradition of paranoia in this code.
          */
-        if (!pat_wc_enabled &&
-            ! ( test_bit(X86_FEATURE_MTRR, boot_cpu_data.x86_capability) ||
-                test_bit(X86_FEATURE_K6_MTRR, boot_cpu_data.x86_capability) ||
-                test_bit(X86_FEATURE_CYRIX_ARR, boot_cpu_data.x86_capability) ||
-                test_bit(X86_FEATURE_CENTAUR_MCR, boot_cpu_data.x86_capability)) &&
-           (pfn << PAGE_SHIFT) >= __pa(high_memory)) {
+        if (!pat_enabled &&
+            !(boot_cpu_has(X86_FEATURE_MTRR) ||
+              boot_cpu_has(X86_FEATURE_K6_MTRR) ||
+              boot_cpu_has(X86_FEATURE_CYRIX_ARR) ||
+              boot_cpu_has(X86_FEATURE_CENTAUR_MCR)) &&
+            (pfn << PAGE_SHIFT) >= __pa(high_memory)) {
                 flags = _PAGE_CACHE_UC;
         }
 #endif
@@ -548,7 +562,7 @@ int phys_mem_access_prot_allowed(struct file *file, unsigned long pfn,
                 return 0;
 
         if (pfn <= max_pfn_mapped &&
-            ioremap_change_attr((unsigned long)__va(offset), size, flags) < 0) {
+            ioremap_change_attr((unsigned long)__va(offset), size, flags) < 0) {
                 free_memtype(offset, offset + size);
                 printk(KERN_INFO
                 "%s:%d /dev/mem ioremap_change_attr failed %s for %Lx-%Lx\n",
@@ -586,4 +600,3 @@ void unmap_devmem(unsigned long pfn, unsigned long size, pgprot_t vma_prot)
 
         free_memtype(addr, addr + size);
 }
-
diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index 10fb308fded8..6ccd7a108cd4 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -299,9 +299,9 @@ int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma,
                 return -EINVAL;
 
         prot = pgprot_val(vma->vm_page_prot);
-        if (pat_wc_enabled && write_combine)
+        if (pat_enabled && write_combine)
                 prot |= _PAGE_CACHE_WC;
-        else if (pat_wc_enabled || boot_cpu_data.x86 > 3)
+        else if (pat_enabled || boot_cpu_data.x86 > 3)
                 /*
                  * ioremap() and ioremap_nocache() defaults to UC MINUS for now.
                  * To avoid attribute conflicts, request UC MINUS here
diff --git a/include/asm-x86/pat.h b/include/asm-x86/pat.h
index 88f60cc6a227..7edc47307217 100644
--- a/include/asm-x86/pat.h
+++ b/include/asm-x86/pat.h
@@ -1,14 +1,13 @@
-
 #ifndef _ASM_PAT_H
-#define _ASM_PAT_H 1
+#define _ASM_PAT_H
 
 #include <linux/types.h>
 
 #ifdef CONFIG_X86_PAT
-extern int pat_wc_enabled;
+extern int pat_enabled;
 extern void validate_pat_support(struct cpuinfo_x86 *c);
 #else
-static const int pat_wc_enabled = 0;
+static const int pat_enabled;
 static inline void validate_pat_support(struct cpuinfo_x86 *c) { }
 #endif
 
@@ -21,4 +20,3 @@ extern int free_memtype(u64 start, u64 end);
 extern void pat_disable(char *reason);
 
 #endif
-