diff options
-rw-r--r-- | arch/arm/mach-integrator/integrator_ap.c | 6 | ||||
-rw-r--r-- | arch/arm/mach-integrator/integrator_cp.c | 7 | ||||
-rw-r--r-- | arch/arm/mach-ux500/cpu.c | 5 |
3 files changed, 6 insertions, 12 deletions
diff --git a/arch/arm/mach-integrator/integrator_ap.c b/arch/arm/mach-integrator/integrator_ap.c index 11e2a4145807..61225e12a749 100644 --- a/arch/arm/mach-integrator/integrator_ap.c +++ b/arch/arm/mach-integrator/integrator_ap.c | |||
@@ -540,16 +540,14 @@ static void __init ap_init_of(void) | |||
540 | 'A' + (ap_sc_id & 0x0f)); | 540 | 'A' + (ap_sc_id & 0x0f)); |
541 | 541 | ||
542 | soc_dev = soc_device_register(soc_dev_attr); | 542 | soc_dev = soc_device_register(soc_dev_attr); |
543 | if (IS_ERR_OR_NULL(soc_dev)) { | 543 | if (IS_ERR(soc_dev)) { |
544 | kfree(soc_dev_attr->revision); | 544 | kfree(soc_dev_attr->revision); |
545 | kfree(soc_dev_attr); | 545 | kfree(soc_dev_attr); |
546 | return; | 546 | return; |
547 | } | 547 | } |
548 | 548 | ||
549 | parent = soc_device_to_device(soc_dev); | 549 | parent = soc_device_to_device(soc_dev); |
550 | 550 | integrator_init_sysfs(parent, ap_sc_id); | |
551 | if (!IS_ERR_OR_NULL(parent)) | ||
552 | integrator_init_sysfs(parent, ap_sc_id); | ||
553 | 551 | ||
554 | of_platform_populate(root, of_default_bus_match_table, | 552 | of_platform_populate(root, of_default_bus_match_table, |
555 | ap_auxdata_lookup, parent); | 553 | ap_auxdata_lookup, parent); |
diff --git a/arch/arm/mach-integrator/integrator_cp.c b/arch/arm/mach-integrator/integrator_cp.c index 7322838c0447..601618903dfb 100644 --- a/arch/arm/mach-integrator/integrator_cp.c +++ b/arch/arm/mach-integrator/integrator_cp.c | |||
@@ -364,17 +364,14 @@ static void __init intcp_init_of(void) | |||
364 | 'A' + (intcp_sc_id & 0x0f)); | 364 | 'A' + (intcp_sc_id & 0x0f)); |
365 | 365 | ||
366 | soc_dev = soc_device_register(soc_dev_attr); | 366 | soc_dev = soc_device_register(soc_dev_attr); |
367 | if (IS_ERR_OR_NULL(soc_dev)) { | 367 | if (IS_ERR(soc_dev)) { |
368 | kfree(soc_dev_attr->revision); | 368 | kfree(soc_dev_attr->revision); |
369 | kfree(soc_dev_attr); | 369 | kfree(soc_dev_attr); |
370 | return; | 370 | return; |
371 | } | 371 | } |
372 | 372 | ||
373 | parent = soc_device_to_device(soc_dev); | 373 | parent = soc_device_to_device(soc_dev); |
374 | 374 | integrator_init_sysfs(parent, intcp_sc_id); | |
375 | if (!IS_ERR_OR_NULL(parent)) | ||
376 | integrator_init_sysfs(parent, intcp_sc_id); | ||
377 | |||
378 | of_platform_populate(root, of_default_bus_match_table, | 375 | of_platform_populate(root, of_default_bus_match_table, |
379 | intcp_auxdata_lookup, parent); | 376 | intcp_auxdata_lookup, parent); |
380 | } | 377 | } |
diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c index 721e7b4275f3..a48026651504 100644 --- a/arch/arm/mach-ux500/cpu.c +++ b/arch/arm/mach-ux500/cpu.c | |||
@@ -145,14 +145,13 @@ struct device * __init ux500_soc_device_init(const char *soc_id) | |||
145 | soc_info_populate(soc_dev_attr, soc_id); | 145 | soc_info_populate(soc_dev_attr, soc_id); |
146 | 146 | ||
147 | soc_dev = soc_device_register(soc_dev_attr); | 147 | soc_dev = soc_device_register(soc_dev_attr); |
148 | if (IS_ERR_OR_NULL(soc_dev)) { | 148 | if (IS_ERR(soc_dev)) { |
149 | kfree(soc_dev_attr); | 149 | kfree(soc_dev_attr); |
150 | return NULL; | 150 | return NULL; |
151 | } | 151 | } |
152 | 152 | ||
153 | parent = soc_device_to_device(soc_dev); | 153 | parent = soc_device_to_device(soc_dev); |
154 | if (!IS_ERR_OR_NULL(parent)) | 154 | device_create_file(parent, &ux500_soc_attr); |
155 | device_create_file(parent, &ux500_soc_attr); | ||
156 | 155 | ||
157 | return parent; | 156 | return parent; |
158 | } | 157 | } |