aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/media/video/mt9m001.c20
-rw-r--r--drivers/media/video/mt9m111.c11
-rw-r--r--drivers/media/video/mt9t031.c16
-rw-r--r--drivers/media/video/mt9v022.c16
-rw-r--r--drivers/media/video/ov772x.c6
-rw-r--r--drivers/media/video/tw9910.c6
6 files changed, 38 insertions, 37 deletions
diff --git a/drivers/media/video/mt9m001.c b/drivers/media/video/mt9m001.c
index 6e762cd06e3f..775e1a3c98d3 100644
--- a/drivers/media/video/mt9m001.c
+++ b/drivers/media/video/mt9m001.c
@@ -118,7 +118,7 @@ static int mt9m001_init(struct soc_camera_device *icd)
118 struct i2c_client *client = to_i2c_client(to_soc_camera_control(icd)); 118 struct i2c_client *client = to_i2c_client(to_soc_camera_control(icd));
119 int ret; 119 int ret;
120 120
121 dev_dbg(&icd->dev, "%s\n", __func__); 121 dev_dbg(&client->dev, "%s\n", __func__);
122 122
123 /* 123 /*
124 * We don't know, whether platform provides reset, 124 * We don't know, whether platform provides reset,
@@ -421,7 +421,7 @@ static int mt9m001_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
421 unsigned long range = qctrl->default_value - qctrl->minimum; 421 unsigned long range = qctrl->default_value - qctrl->minimum;
422 data = ((ctrl->value - qctrl->minimum) * 8 + range / 2) / range; 422 data = ((ctrl->value - qctrl->minimum) * 8 + range / 2) / range;
423 423
424 dev_dbg(&icd->dev, "Setting gain %d\n", data); 424 dev_dbg(&client->dev, "Setting gain %d\n", data);
425 data = reg_write(client, MT9M001_GLOBAL_GAIN, data); 425 data = reg_write(client, MT9M001_GLOBAL_GAIN, data);
426 if (data < 0) 426 if (data < 0)
427 return -EIO; 427 return -EIO;
@@ -439,7 +439,7 @@ static int mt9m001_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
439 else 439 else
440 data = ((gain - 64) * 7 + 28) / 56 + 96; 440 data = ((gain - 64) * 7 + 28) / 56 + 96;
441 441
442 dev_dbg(&icd->dev, "Setting gain from %d to %d\n", 442 dev_dbg(&client->dev, "Setting gain from %d to %d\n",
443 reg_read(client, MT9M001_GLOBAL_GAIN), data); 443 reg_read(client, MT9M001_GLOBAL_GAIN), data);
444 data = reg_write(client, MT9M001_GLOBAL_GAIN, data); 444 data = reg_write(client, MT9M001_GLOBAL_GAIN, data);
445 if (data < 0) 445 if (data < 0)
@@ -458,8 +458,10 @@ static int mt9m001_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
458 unsigned long shutter = ((ctrl->value - qctrl->minimum) * 1048 + 458 unsigned long shutter = ((ctrl->value - qctrl->minimum) * 1048 +
459 range / 2) / range + 1; 459 range / 2) / range + 1;
460 460
461 dev_dbg(&icd->dev, "Setting shutter width from %d to %lu\n", 461 dev_dbg(&client->dev,
462 reg_read(client, MT9M001_SHUTTER_WIDTH), shutter); 462 "Setting shutter width from %d to %lu\n",
463 reg_read(client, MT9M001_SHUTTER_WIDTH),
464 shutter);
463 if (reg_write(client, MT9M001_SHUTTER_WIDTH, shutter) < 0) 465 if (reg_write(client, MT9M001_SHUTTER_WIDTH, shutter) < 0)
464 return -EIO; 466 return -EIO;
465 icd->exposure = ctrl->value; 467 icd->exposure = ctrl->value;
@@ -504,7 +506,7 @@ static int mt9m001_video_probe(struct soc_camera_device *icd,
504 506
505 /* Enable the chip */ 507 /* Enable the chip */
506 data = reg_write(client, MT9M001_CHIP_ENABLE, 1); 508 data = reg_write(client, MT9M001_CHIP_ENABLE, 1);
507 dev_dbg(&icd->dev, "write: %d\n", data); 509 dev_dbg(&client->dev, "write: %d\n", data);
508 510
509 /* Read out the chip version register */ 511 /* Read out the chip version register */
510 data = reg_read(client, MT9M001_CHIP_VERSION); 512 data = reg_read(client, MT9M001_CHIP_VERSION);
@@ -521,7 +523,7 @@ static int mt9m001_video_probe(struct soc_camera_device *icd,
521 icd->formats = mt9m001_monochrome_formats; 523 icd->formats = mt9m001_monochrome_formats;
522 break; 524 break;
523 default: 525 default:
524 dev_err(&icd->dev, 526 dev_err(&client->dev,
525 "No MT9M001 chip detected, register read %x\n", data); 527 "No MT9M001 chip detected, register read %x\n", data);
526 return -ENODEV; 528 return -ENODEV;
527 } 529 }
@@ -546,7 +548,7 @@ static int mt9m001_video_probe(struct soc_camera_device *icd,
546 if (flags & SOCAM_DATAWIDTH_8) 548 if (flags & SOCAM_DATAWIDTH_8)
547 icd->num_formats++; 549 icd->num_formats++;
548 550
549 dev_info(&icd->dev, "Detected a MT9M001 chip ID %x (%s)\n", data, 551 dev_info(&client->dev, "Detected a MT9M001 chip ID %x (%s)\n", data,
550 data == 0x8431 ? "C12STM" : "C12ST"); 552 data == 0x8431 ? "C12STM" : "C12ST");
551 553
552 return 0; 554 return 0;
@@ -557,7 +559,7 @@ static void mt9m001_video_remove(struct soc_camera_device *icd)
557 struct i2c_client *client = to_i2c_client(to_soc_camera_control(icd)); 559 struct i2c_client *client = to_i2c_client(to_soc_camera_control(icd));
558 struct soc_camera_link *icl = to_soc_camera_link(icd); 560 struct soc_camera_link *icl = to_soc_camera_link(icd);
559 561
560 dev_dbg(&icd->dev, "Video %x removed: %p, %p\n", client->addr, 562 dev_dbg(&client->dev, "Video %x removed: %p, %p\n", client->addr,
561 icd->dev.parent, icd->vdev); 563 icd->dev.parent, icd->vdev);
562 if (icl->free_bus) 564 if (icl->free_bus)
563 icl->free_bus(icl); 565 icl->free_bus(icl);
diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c
index bef415170186..3637376da755 100644
--- a/drivers/media/video/mt9m111.c
+++ b/drivers/media/video/mt9m111.c
@@ -400,10 +400,9 @@ static int mt9m111_s_crop(struct v4l2_subdev *sd, struct v4l2_crop *a)
400 struct v4l2_rect *rect = &a->c; 400 struct v4l2_rect *rect = &a->c;
401 struct i2c_client *client = sd->priv; 401 struct i2c_client *client = sd->priv;
402 struct mt9m111 *mt9m111 = to_mt9m111(client); 402 struct mt9m111 *mt9m111 = to_mt9m111(client);
403 struct soc_camera_device *icd = client->dev.platform_data;
404 int ret; 403 int ret;
405 404
406 dev_dbg(&icd->dev, "%s left=%d, top=%d, width=%d, height=%d\n", 405 dev_dbg(&client->dev, "%s left=%d, top=%d, width=%d, height=%d\n",
407 __func__, rect->left, rect->top, rect->width, 406 __func__, rect->left, rect->top, rect->width,
408 rect->height); 407 rect->height);
409 408
@@ -818,7 +817,7 @@ static int mt9m111_init(struct soc_camera_device *icd)
818 if (!ret) 817 if (!ret)
819 ret = mt9m111_set_autoexposure(client, mt9m111->autoexposure); 818 ret = mt9m111_set_autoexposure(client, mt9m111->autoexposure);
820 if (ret) 819 if (ret)
821 dev_err(&icd->dev, "mt9m11x init failed: %d\n", ret); 820 dev_err(&client->dev, "mt9m11x init failed: %d\n", ret);
822 return ret; 821 return ret;
823} 822}
824 823
@@ -833,7 +832,7 @@ static int mt9m111_release(struct soc_camera_device *icd)
833 mt9m111->powered = 0; 832 mt9m111->powered = 0;
834 833
835 if (ret < 0) 834 if (ret < 0)
836 dev_err(&icd->dev, "mt9m11x release failed: %d\n", ret); 835 dev_err(&client->dev, "mt9m11x release failed: %d\n", ret);
837 836
838 return ret; 837 return ret;
839} 838}
@@ -875,7 +874,7 @@ static int mt9m111_video_probe(struct soc_camera_device *icd,
875 break; 874 break;
876 default: 875 default:
877 ret = -ENODEV; 876 ret = -ENODEV;
878 dev_err(&icd->dev, 877 dev_err(&client->dev,
879 "No MT9M11x chip detected, register read %x\n", data); 878 "No MT9M11x chip detected, register read %x\n", data);
880 goto ei2c; 879 goto ei2c;
881 } 880 }
@@ -883,7 +882,7 @@ static int mt9m111_video_probe(struct soc_camera_device *icd,
883 icd->formats = mt9m111_colour_formats; 882 icd->formats = mt9m111_colour_formats;
884 icd->num_formats = ARRAY_SIZE(mt9m111_colour_formats); 883 icd->num_formats = ARRAY_SIZE(mt9m111_colour_formats);
885 884
886 dev_info(&icd->dev, "Detected a MT9M11x chip ID %x\n", data); 885 dev_info(&client->dev, "Detected a MT9M11x chip ID %x\n", data);
887 886
888 mt9m111->autoexposure = 1; 887 mt9m111->autoexposure = 1;
889 mt9m111->autowhitebalance = 1; 888 mt9m111->autowhitebalance = 1;
diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c
index 3fa87be2fc6e..cd3eb7731ac2 100644
--- a/drivers/media/video/mt9t031.c
+++ b/drivers/media/video/mt9t031.c
@@ -248,7 +248,7 @@ static int mt9t031_set_params(struct soc_camera_device *icd,
248 xbin = min(xskip, (u16)3); 248 xbin = min(xskip, (u16)3);
249 ybin = min(yskip, (u16)3); 249 ybin = min(yskip, (u16)3);
250 250
251 dev_dbg(&icd->dev, "xskip %u, width %u/%u, yskip %u, height %u/%u\n", 251 dev_dbg(&client->dev, "xskip %u, width %u/%u, yskip %u, height %u/%u\n",
252 xskip, width, rect->width, yskip, height, rect->height); 252 xskip, width, rect->width, yskip, height, rect->height);
253 253
254 /* Could just do roundup(rect->left, [xy]bin * 2); but this is cheaper */ 254 /* Could just do roundup(rect->left, [xy]bin * 2); but this is cheaper */
@@ -287,7 +287,7 @@ static int mt9t031_set_params(struct soc_camera_device *icd,
287 ret = reg_write(client, MT9T031_ROW_ADDRESS_MODE, 287 ret = reg_write(client, MT9T031_ROW_ADDRESS_MODE,
288 ((ybin - 1) << 4) | (yskip - 1)); 288 ((ybin - 1) << 4) | (yskip - 1));
289 } 289 }
290 dev_dbg(&icd->dev, "new physical left %u, top %u\n", left, top); 290 dev_dbg(&client->dev, "new physical left %u, top %u\n", left, top);
291 291
292 /* The caller provides a supported format, as guaranteed by 292 /* The caller provides a supported format, as guaranteed by
293 * icd->try_fmt_cap(), soc_camera_s_crop() and soc_camera_cropcap() */ 293 * icd->try_fmt_cap(), soc_camera_s_crop() and soc_camera_cropcap() */
@@ -567,7 +567,7 @@ static int mt9t031_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
567 unsigned long range = qctrl->default_value - qctrl->minimum; 567 unsigned long range = qctrl->default_value - qctrl->minimum;
568 data = ((ctrl->value - qctrl->minimum) * 8 + range / 2) / range; 568 data = ((ctrl->value - qctrl->minimum) * 8 + range / 2) / range;
569 569
570 dev_dbg(&icd->dev, "Setting gain %d\n", data); 570 dev_dbg(&client->dev, "Setting gain %d\n", data);
571 data = reg_write(client, MT9T031_GLOBAL_GAIN, data); 571 data = reg_write(client, MT9T031_GLOBAL_GAIN, data);
572 if (data < 0) 572 if (data < 0)
573 return -EIO; 573 return -EIO;
@@ -587,7 +587,7 @@ static int mt9t031_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
587 /* calculated gain 65..1024 -> (1..120) << 8 + 0x60 */ 587 /* calculated gain 65..1024 -> (1..120) << 8 + 0x60 */
588 data = (((gain - 64 + 7) * 32) & 0xff00) | 0x60; 588 data = (((gain - 64 + 7) * 32) & 0xff00) | 0x60;
589 589
590 dev_dbg(&icd->dev, "Setting gain from 0x%x to 0x%x\n", 590 dev_dbg(&client->dev, "Set gain from 0x%x to 0x%x\n",
591 reg_read(client, MT9T031_GLOBAL_GAIN), data); 591 reg_read(client, MT9T031_GLOBAL_GAIN), data);
592 data = reg_write(client, MT9T031_GLOBAL_GAIN, data); 592 data = reg_write(client, MT9T031_GLOBAL_GAIN, data);
593 if (data < 0) 593 if (data < 0)
@@ -608,7 +608,7 @@ static int mt9t031_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
608 u32 old; 608 u32 old;
609 609
610 get_shutter(client, &old); 610 get_shutter(client, &old);
611 dev_dbg(&icd->dev, "Setting shutter width from %u to %u\n", 611 dev_dbg(&client->dev, "Set shutter from %u to %u\n",
612 old, shutter); 612 old, shutter);
613 if (set_shutter(client, shutter) < 0) 613 if (set_shutter(client, shutter) < 0)
614 return -EIO; 614 return -EIO;
@@ -653,7 +653,7 @@ static int mt9t031_video_probe(struct i2c_client *client)
653 653
654 /* Enable the chip */ 654 /* Enable the chip */
655 data = reg_write(client, MT9T031_CHIP_ENABLE, 1); 655 data = reg_write(client, MT9T031_CHIP_ENABLE, 1);
656 dev_dbg(&icd->dev, "write: %d\n", data); 656 dev_dbg(&client->dev, "write: %d\n", data);
657 657
658 /* Read out the chip version register */ 658 /* Read out the chip version register */
659 data = reg_read(client, MT9T031_CHIP_VERSION); 659 data = reg_read(client, MT9T031_CHIP_VERSION);
@@ -665,12 +665,12 @@ static int mt9t031_video_probe(struct i2c_client *client)
665 icd->num_formats = ARRAY_SIZE(mt9t031_colour_formats); 665 icd->num_formats = ARRAY_SIZE(mt9t031_colour_formats);
666 break; 666 break;
667 default: 667 default:
668 dev_err(&icd->dev, 668 dev_err(&client->dev,
669 "No MT9T031 chip detected, register read %x\n", data); 669 "No MT9T031 chip detected, register read %x\n", data);
670 return -ENODEV; 670 return -ENODEV;
671 } 671 }
672 672
673 dev_info(&icd->dev, "Detected a MT9T031 chip ID %x\n", data); 673 dev_info(&client->dev, "Detected a MT9T031 chip ID %x\n", data);
674 674
675 return 0; 675 return 0;
676} 676}
diff --git a/drivers/media/video/mt9v022.c b/drivers/media/video/mt9v022.c
index e609ff51aa66..ab1965425289 100644
--- a/drivers/media/video/mt9v022.c
+++ b/drivers/media/video/mt9v022.c
@@ -224,7 +224,7 @@ static int mt9v022_set_bus_param(struct soc_camera_device *icd,
224 if (ret < 0) 224 if (ret < 0)
225 return ret; 225 return ret;
226 226
227 dev_dbg(&icd->dev, "Calculated pixclk 0x%x, chip control 0x%x\n", 227 dev_dbg(&client->dev, "Calculated pixclk 0x%x, chip control 0x%x\n",
228 pixclk, mt9v022->chip_control); 228 pixclk, mt9v022->chip_control);
229 229
230 return 0; 230 return 0;
@@ -287,7 +287,7 @@ static int mt9v022_s_crop(struct v4l2_subdev *sd, struct v4l2_crop *a)
287 if (ret < 0) 287 if (ret < 0)
288 return ret; 288 return ret;
289 289
290 dev_dbg(&icd->dev, "Frame %ux%u pixel\n", rect->width, rect->height); 290 dev_dbg(&client->dev, "Frame %ux%u pixel\n", rect->width, rect->height);
291 291
292 return 0; 292 return 0;
293} 293}
@@ -545,7 +545,7 @@ static int mt9v022_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
545 if (reg_clear(client, MT9V022_AEC_AGC_ENABLE, 0x2) < 0) 545 if (reg_clear(client, MT9V022_AEC_AGC_ENABLE, 0x2) < 0)
546 return -EIO; 546 return -EIO;
547 547
548 dev_info(&icd->dev, "Setting gain from %d to %lu\n", 548 dev_info(&client->dev, "Setting gain from %d to %lu\n",
549 reg_read(client, MT9V022_ANALOG_GAIN), gain); 549 reg_read(client, MT9V022_ANALOG_GAIN), gain);
550 if (reg_write(client, MT9V022_ANALOG_GAIN, gain) < 0) 550 if (reg_write(client, MT9V022_ANALOG_GAIN, gain) < 0)
551 return -EIO; 551 return -EIO;
@@ -566,7 +566,7 @@ static int mt9v022_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
566 if (reg_clear(client, MT9V022_AEC_AGC_ENABLE, 0x1) < 0) 566 if (reg_clear(client, MT9V022_AEC_AGC_ENABLE, 0x1) < 0)
567 return -EIO; 567 return -EIO;
568 568
569 dev_dbg(&icd->dev, "Shutter width from %d to %lu\n", 569 dev_dbg(&client->dev, "Shutter width from %d to %lu\n",
570 reg_read(client, MT9V022_TOTAL_SHUTTER_WIDTH), 570 reg_read(client, MT9V022_TOTAL_SHUTTER_WIDTH),
571 shutter); 571 shutter);
572 if (reg_write(client, MT9V022_TOTAL_SHUTTER_WIDTH, 572 if (reg_write(client, MT9V022_TOTAL_SHUTTER_WIDTH,
@@ -616,7 +616,7 @@ static int mt9v022_video_probe(struct soc_camera_device *icd,
616 /* must be 0x1311 or 0x1313 */ 616 /* must be 0x1311 or 0x1313 */
617 if (data != 0x1311 && data != 0x1313) { 617 if (data != 0x1311 && data != 0x1313) {
618 ret = -ENODEV; 618 ret = -ENODEV;
619 dev_info(&icd->dev, "No MT9V022 detected, ID register 0x%x\n", 619 dev_info(&client->dev, "No MT9V022 found, ID register 0x%x\n",
620 data); 620 data);
621 goto ei2c; 621 goto ei2c;
622 } 622 }
@@ -628,7 +628,7 @@ static int mt9v022_video_probe(struct soc_camera_device *icd,
628 /* 15 clock cycles */ 628 /* 15 clock cycles */
629 udelay(200); 629 udelay(200);
630 if (reg_read(client, MT9V022_RESET)) { 630 if (reg_read(client, MT9V022_RESET)) {
631 dev_err(&icd->dev, "Resetting MT9V022 failed!\n"); 631 dev_err(&client->dev, "Resetting MT9V022 failed!\n");
632 if (ret > 0) 632 if (ret > 0)
633 ret = -EIO; 633 ret = -EIO;
634 goto ei2c; 634 goto ei2c;
@@ -669,7 +669,7 @@ static int mt9v022_video_probe(struct soc_camera_device *icd,
669 if (flags & SOCAM_DATAWIDTH_8) 669 if (flags & SOCAM_DATAWIDTH_8)
670 icd->num_formats++; 670 icd->num_formats++;
671 671
672 dev_info(&icd->dev, "Detected a MT9V022 chip ID %x, %s sensor\n", 672 dev_info(&client->dev, "Detected a MT9V022 chip ID %x, %s sensor\n",
673 data, mt9v022->model == V4L2_IDENT_MT9V022IX7ATM ? 673 data, mt9v022->model == V4L2_IDENT_MT9V022IX7ATM ?
674 "monochrome" : "colour"); 674 "monochrome" : "colour");
675 675
@@ -682,7 +682,7 @@ static void mt9v022_video_remove(struct soc_camera_device *icd)
682 struct i2c_client *client = to_i2c_client(to_soc_camera_control(icd)); 682 struct i2c_client *client = to_i2c_client(to_soc_camera_control(icd));
683 struct soc_camera_link *icl = to_soc_camera_link(icd); 683 struct soc_camera_link *icl = to_soc_camera_link(icd);
684 684
685 dev_dbg(&icd->dev, "Video %x removed: %p, %p\n", client->addr, 685 dev_dbg(&client->dev, "Video %x removed: %p, %p\n", client->addr,
686 icd->dev.parent, icd->vdev); 686 icd->dev.parent, icd->vdev);
687 if (icl->free_bus) 687 if (icl->free_bus)
688 icl->free_bus(icl); 688 icl->free_bus(icl);
diff --git a/drivers/media/video/ov772x.c b/drivers/media/video/ov772x.c
index bbe6f2d71c15..bbf5331a2eae 100644
--- a/drivers/media/video/ov772x.c
+++ b/drivers/media/video/ov772x.c
@@ -1002,7 +1002,7 @@ static int ov772x_video_probe(struct soc_camera_device *icd,
1002 */ 1002 */
1003 if (SOCAM_DATAWIDTH_10 != priv->info->buswidth && 1003 if (SOCAM_DATAWIDTH_10 != priv->info->buswidth &&
1004 SOCAM_DATAWIDTH_8 != priv->info->buswidth) { 1004 SOCAM_DATAWIDTH_8 != priv->info->buswidth) {
1005 dev_err(&icd->dev, "bus width error\n"); 1005 dev_err(&client->dev, "bus width error\n");
1006 return -ENODEV; 1006 return -ENODEV;
1007 } 1007 }
1008 1008
@@ -1025,12 +1025,12 @@ static int ov772x_video_probe(struct soc_camera_device *icd,
1025 priv->model = V4L2_IDENT_OV7725; 1025 priv->model = V4L2_IDENT_OV7725;
1026 break; 1026 break;
1027 default: 1027 default:
1028 dev_err(&icd->dev, 1028 dev_err(&client->dev,
1029 "Product ID error %x:%x\n", pid, ver); 1029 "Product ID error %x:%x\n", pid, ver);
1030 return -ENODEV; 1030 return -ENODEV;
1031 } 1031 }
1032 1032
1033 dev_info(&icd->dev, 1033 dev_info(&client->dev,
1034 "%s Product ID %0x:%0x Manufacturer ID %x:%x\n", 1034 "%s Product ID %0x:%0x Manufacturer ID %x:%x\n",
1035 devname, 1035 devname,
1036 pid, 1036 pid,
diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c
index b6b15468b40a..94bd5b09f057 100644
--- a/drivers/media/video/tw9910.c
+++ b/drivers/media/video/tw9910.c
@@ -793,7 +793,7 @@ static int tw9910_video_probe(struct soc_camera_device *icd,
793 */ 793 */
794 if (SOCAM_DATAWIDTH_16 != priv->info->buswidth && 794 if (SOCAM_DATAWIDTH_16 != priv->info->buswidth &&
795 SOCAM_DATAWIDTH_8 != priv->info->buswidth) { 795 SOCAM_DATAWIDTH_8 != priv->info->buswidth) {
796 dev_err(&icd->dev, "bus width error\n"); 796 dev_err(&client->dev, "bus width error\n");
797 return -ENODEV; 797 return -ENODEV;
798 } 798 }
799 799
@@ -807,12 +807,12 @@ static int tw9910_video_probe(struct soc_camera_device *icd,
807 807
808 if (0x0B != GET_ID(val) || 808 if (0x0B != GET_ID(val) ||
809 0x00 != GET_ReV(val)) { 809 0x00 != GET_ReV(val)) {
810 dev_err(&icd->dev, 810 dev_err(&client->dev,
811 "Product ID error %x:%x\n", GET_ID(val), GET_ReV(val)); 811 "Product ID error %x:%x\n", GET_ID(val), GET_ReV(val));
812 return -ENODEV; 812 return -ENODEV;
813 } 813 }
814 814
815 dev_info(&icd->dev, 815 dev_info(&client->dev,
816 "tw9910 Product ID %0x:%0x\n", GET_ID(val), GET_ReV(val)); 816 "tw9910 Product ID %0x:%0x\n", GET_ID(val), GET_ReV(val));
817 817
818 icd->vdev->tvnorms = V4L2_STD_NTSC | V4L2_STD_PAL; 818 icd->vdev->tvnorms = V4L2_STD_NTSC | V4L2_STD_PAL;