aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Documentation/SubmittingPatches4
-rwxr-xr-xscripts/checkpatch.pl9
2 files changed, 11 insertions, 2 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 447671bd2927..b03a832a08e2 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -614,8 +614,8 @@ The canonical patch message body contains the following:
614 614
615 - An empty line. 615 - An empty line.
616 616
617 - The body of the explanation, which will be copied to the 617 - The body of the explanation, line wrapped at 75 columns, which will
618 permanent changelog to describe this patch. 618 be copied to the permanent changelog to describe this patch.
619 619
620 - The "Signed-off-by:" lines, described above, which will 620 - The "Signed-off-by:" lines, described above, which will
621 also go in the changelog. 621 also go in the changelog.
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c72e7ee1000b..9a8b2bd14dc2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1898,6 +1898,7 @@ sub process {
1898 1898
1899 my $in_header_lines = $file ? 0 : 1; 1899 my $in_header_lines = $file ? 0 : 1;
1900 my $in_commit_log = 0; #Scanning lines before patch 1900 my $in_commit_log = 0; #Scanning lines before patch
1901 my $commit_log_long_line = 0;
1901 my $reported_maintainer_file = 0; 1902 my $reported_maintainer_file = 0;
1902 my $non_utf8_charset = 0; 1903 my $non_utf8_charset = 0;
1903 1904
@@ -2233,6 +2234,14 @@ sub process {
2233 "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr); 2234 "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
2234 } 2235 }
2235 2236
2237# Check for line lengths > 75 in commit log, warn once
2238 if ($in_commit_log && !$commit_log_long_line &&
2239 length($line) > 75) {
2240 WARN("COMMIT_LOG_LONG_LINE",
2241 "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
2242 $commit_log_long_line = 1;
2243 }
2244
2236# Check for git id commit length and improperly formed commit descriptions 2245# Check for git id commit length and improperly formed commit descriptions
2237 if ($in_commit_log && $line =~ /\b(c)ommit\s+([0-9a-f]{5,})/i) { 2246 if ($in_commit_log && $line =~ /\b(c)ommit\s+([0-9a-f]{5,})/i) {
2238 my $init_char = $1; 2247 my $init_char = $1;