diff options
-rw-r--r-- | include/net/genetlink.h | 5 | ||||
-rw-r--r-- | net/netlink/genetlink.c | 4 |
2 files changed, 3 insertions, 6 deletions
diff --git a/include/net/genetlink.h b/include/net/genetlink.h index ace4abf118d7..771af09e90eb 100644 --- a/include/net/genetlink.h +++ b/include/net/genetlink.h | |||
@@ -265,7 +265,7 @@ static inline int genlmsg_multicast_netns(struct genl_family *family, | |||
265 | struct net *net, struct sk_buff *skb, | 265 | struct net *net, struct sk_buff *skb, |
266 | u32 portid, unsigned int group, gfp_t flags) | 266 | u32 portid, unsigned int group, gfp_t flags) |
267 | { | 267 | { |
268 | if (group >= family->n_mcgrps) | 268 | if (WARN_ON_ONCE(group >= family->n_mcgrps)) |
269 | return -EINVAL; | 269 | return -EINVAL; |
270 | group = family->mcgrp_offset + group; | 270 | group = family->mcgrp_offset + group; |
271 | return nlmsg_multicast(net->genl_sock, skb, portid, group, flags); | 271 | return nlmsg_multicast(net->genl_sock, skb, portid, group, flags); |
@@ -283,9 +283,6 @@ static inline int genlmsg_multicast(struct genl_family *family, | |||
283 | struct sk_buff *skb, u32 portid, | 283 | struct sk_buff *skb, u32 portid, |
284 | unsigned int group, gfp_t flags) | 284 | unsigned int group, gfp_t flags) |
285 | { | 285 | { |
286 | if (group >= family->n_mcgrps) | ||
287 | return -EINVAL; | ||
288 | group = family->mcgrp_offset + group; | ||
289 | return genlmsg_multicast_netns(family, &init_net, skb, | 286 | return genlmsg_multicast_netns(family, &init_net, skb, |
290 | portid, group, flags); | 287 | portid, group, flags); |
291 | } | 288 | } |
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 7dbc4f732c75..4518a57aa5fe 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c | |||
@@ -1045,7 +1045,7 @@ static int genlmsg_mcast(struct sk_buff *skb, u32 portid, unsigned long group, | |||
1045 | int genlmsg_multicast_allns(struct genl_family *family, struct sk_buff *skb, | 1045 | int genlmsg_multicast_allns(struct genl_family *family, struct sk_buff *skb, |
1046 | u32 portid, unsigned int group, gfp_t flags) | 1046 | u32 portid, unsigned int group, gfp_t flags) |
1047 | { | 1047 | { |
1048 | if (group >= family->n_mcgrps) | 1048 | if (WARN_ON_ONCE(group >= family->n_mcgrps)) |
1049 | return -EINVAL; | 1049 | return -EINVAL; |
1050 | group = family->mcgrp_offset + group; | 1050 | group = family->mcgrp_offset + group; |
1051 | return genlmsg_mcast(skb, portid, group, flags); | 1051 | return genlmsg_mcast(skb, portid, group, flags); |
@@ -1062,7 +1062,7 @@ void genl_notify(struct genl_family *family, | |||
1062 | if (nlh) | 1062 | if (nlh) |
1063 | report = nlmsg_report(nlh); | 1063 | report = nlmsg_report(nlh); |
1064 | 1064 | ||
1065 | if (group >= family->n_mcgrps) | 1065 | if (WARN_ON_ONCE(group >= family->n_mcgrps)) |
1066 | return; | 1066 | return; |
1067 | group = family->mcgrp_offset + group; | 1067 | group = family->mcgrp_offset + group; |
1068 | nlmsg_notify(sk, skb, portid, group, report, flags); | 1068 | nlmsg_notify(sk, skb, portid, group, report, flags); |