diff options
-rw-r--r-- | drivers/scsi/cxgb3i/cxgb3i_ddp.c | 5 | ||||
-rw-r--r-- | drivers/scsi/cxgb3i/cxgb3i_ddp.h | 8 | ||||
-rw-r--r-- | drivers/scsi/cxgb3i/cxgb3i_iscsi.c | 17 | ||||
-rw-r--r-- | drivers/scsi/cxgb3i/cxgb3i_offload.c | 3 | ||||
-rw-r--r-- | drivers/scsi/cxgb3i/cxgb3i_offload.h | 1 |
5 files changed, 14 insertions, 20 deletions
diff --git a/drivers/scsi/cxgb3i/cxgb3i_ddp.c b/drivers/scsi/cxgb3i/cxgb3i_ddp.c index a83d36e4926f..4eb6f5593b3e 100644 --- a/drivers/scsi/cxgb3i/cxgb3i_ddp.c +++ b/drivers/scsi/cxgb3i/cxgb3i_ddp.c | |||
@@ -196,7 +196,7 @@ static inline int ddp_alloc_gl_skb(struct cxgb3i_ddp_info *ddp, int idx, | |||
196 | } | 196 | } |
197 | 197 | ||
198 | /** | 198 | /** |
199 | * cxgb3i_ddp_find_page_index - return ddp page index for a given page size. | 199 | * cxgb3i_ddp_find_page_index - return ddp page index for a given page size |
200 | * @pgsz: page size | 200 | * @pgsz: page size |
201 | * return the ddp page index, if no match is found return DDP_PGIDX_MAX. | 201 | * return the ddp page index, if no match is found return DDP_PGIDX_MAX. |
202 | */ | 202 | */ |
@@ -355,8 +355,7 @@ EXPORT_SYMBOL_GPL(cxgb3i_ddp_release_gl); | |||
355 | * @tdev: t3cdev adapter | 355 | * @tdev: t3cdev adapter |
356 | * @tid: connection id | 356 | * @tid: connection id |
357 | * @tformat: tag format | 357 | * @tformat: tag format |
358 | * @tagp: the s/w tag, if ddp setup is successful, it will be updated with | 358 | * @tagp: contains s/w tag initially, will be updated with ddp/hw tag |
359 | * ddp/hw tag | ||
360 | * @gl: the page momory list | 359 | * @gl: the page momory list |
361 | * @gfp: allocation mode | 360 | * @gfp: allocation mode |
362 | * | 361 | * |
diff --git a/drivers/scsi/cxgb3i/cxgb3i_ddp.h b/drivers/scsi/cxgb3i/cxgb3i_ddp.h index 3faae7831c83..75a63a81e873 100644 --- a/drivers/scsi/cxgb3i/cxgb3i_ddp.h +++ b/drivers/scsi/cxgb3i/cxgb3i_ddp.h | |||
@@ -185,12 +185,11 @@ static inline int cxgb3i_is_ddp_tag(struct cxgb3i_tag_format *tformat, u32 tag) | |||
185 | } | 185 | } |
186 | 186 | ||
187 | /** | 187 | /** |
188 | * cxgb3i_sw_tag_usable - check if a given s/w tag has enough bits left for | 188 | * cxgb3i_sw_tag_usable - check if s/w tag has enough bits left for hw bits |
189 | * the reserved/hw bits | ||
190 | * @tformat: tag format information | 189 | * @tformat: tag format information |
191 | * @sw_tag: s/w tag to be checked | 190 | * @sw_tag: s/w tag to be checked |
192 | * | 191 | * |
193 | * return true if the tag is a ddp tag, false otherwise. | 192 | * return true if the tag can be used for hw ddp tag, false otherwise. |
194 | */ | 193 | */ |
195 | static inline int cxgb3i_sw_tag_usable(struct cxgb3i_tag_format *tformat, | 194 | static inline int cxgb3i_sw_tag_usable(struct cxgb3i_tag_format *tformat, |
196 | u32 sw_tag) | 195 | u32 sw_tag) |
@@ -222,8 +221,7 @@ static inline u32 cxgb3i_set_non_ddp_tag(struct cxgb3i_tag_format *tformat, | |||
222 | } | 221 | } |
223 | 222 | ||
224 | /** | 223 | /** |
225 | * cxgb3i_ddp_tag_base - shift the s/w tag bits so that reserved bits are not | 224 | * cxgb3i_ddp_tag_base - shift s/w tag bits so that reserved bits are not used |
226 | * used. | ||
227 | * @tformat: tag format information | 225 | * @tformat: tag format information |
228 | * @sw_tag: s/w tag to be checked | 226 | * @sw_tag: s/w tag to be checked |
229 | */ | 227 | */ |
diff --git a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c index ae4a93090725..e185dedc4c1f 100644 --- a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c +++ b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c | |||
@@ -101,8 +101,7 @@ free_snic: | |||
101 | } | 101 | } |
102 | 102 | ||
103 | /** | 103 | /** |
104 | * cxgb3i_adapter_remove - release all the resources held and cleanup any | 104 | * cxgb3i_adapter_remove - release the resources held and cleanup h/w settings |
105 | * h/w settings | ||
106 | * @t3dev: t3cdev adapter | 105 | * @t3dev: t3cdev adapter |
107 | */ | 106 | */ |
108 | void cxgb3i_adapter_remove(struct t3cdev *t3dev) | 107 | void cxgb3i_adapter_remove(struct t3cdev *t3dev) |
@@ -135,8 +134,7 @@ void cxgb3i_adapter_remove(struct t3cdev *t3dev) | |||
135 | } | 134 | } |
136 | 135 | ||
137 | /** | 136 | /** |
138 | * cxgb3i_hba_find_by_netdev - find the cxgb3i_hba structure with a given | 137 | * cxgb3i_hba_find_by_netdev - find the cxgb3i_hba structure via net_device |
139 | * net_device | ||
140 | * @t3dev: t3cdev adapter | 138 | * @t3dev: t3cdev adapter |
141 | */ | 139 | */ |
142 | struct cxgb3i_hba *cxgb3i_hba_find_by_netdev(struct net_device *ndev) | 140 | struct cxgb3i_hba *cxgb3i_hba_find_by_netdev(struct net_device *ndev) |
@@ -390,9 +388,9 @@ static void cxgb3i_session_destroy(struct iscsi_cls_session *cls_session) | |||
390 | } | 388 | } |
391 | 389 | ||
392 | /** | 390 | /** |
393 | * cxgb3i_conn_max_xmit_dlength -- check the max. xmit pdu segment size, | 391 | * cxgb3i_conn_max_xmit_dlength -- calc the max. xmit pdu segment size |
394 | * reduce it to be within the hardware limit if needed | ||
395 | * @conn: iscsi connection | 392 | * @conn: iscsi connection |
393 | * check the max. xmit pdu payload, reduce it if needed | ||
396 | */ | 394 | */ |
397 | static inline int cxgb3i_conn_max_xmit_dlength(struct iscsi_conn *conn) | 395 | static inline int cxgb3i_conn_max_xmit_dlength(struct iscsi_conn *conn) |
398 | 396 | ||
@@ -413,8 +411,7 @@ static inline int cxgb3i_conn_max_xmit_dlength(struct iscsi_conn *conn) | |||
413 | } | 411 | } |
414 | 412 | ||
415 | /** | 413 | /** |
416 | * cxgb3i_conn_max_recv_dlength -- check the max. recv pdu segment size against | 414 | * cxgb3i_conn_max_recv_dlength -- check the max. recv pdu segment size |
417 | * the hardware limit | ||
418 | * @conn: iscsi connection | 415 | * @conn: iscsi connection |
419 | * return 0 if the value is valid, < 0 otherwise. | 416 | * return 0 if the value is valid, < 0 otherwise. |
420 | */ | 417 | */ |
@@ -755,9 +752,9 @@ static void cxgb3i_parse_itt(struct iscsi_conn *conn, itt_t itt, | |||
755 | 752 | ||
756 | /** | 753 | /** |
757 | * cxgb3i_reserve_itt - generate tag for a give task | 754 | * cxgb3i_reserve_itt - generate tag for a give task |
758 | * Try to set up ddp for a scsi read task. | ||
759 | * @task: iscsi task | 755 | * @task: iscsi task |
760 | * @hdr_itt: tag, filled in by this function | 756 | * @hdr_itt: tag, filled in by this function |
757 | * Set up ddp for scsi read tasks if possible. | ||
761 | */ | 758 | */ |
762 | int cxgb3i_reserve_itt(struct iscsi_task *task, itt_t *hdr_itt) | 759 | int cxgb3i_reserve_itt(struct iscsi_task *task, itt_t *hdr_itt) |
763 | { | 760 | { |
@@ -805,9 +802,9 @@ int cxgb3i_reserve_itt(struct iscsi_task *task, itt_t *hdr_itt) | |||
805 | 802 | ||
806 | /** | 803 | /** |
807 | * cxgb3i_release_itt - release the tag for a given task | 804 | * cxgb3i_release_itt - release the tag for a given task |
808 | * if the tag is a ddp tag, release the ddp setup | ||
809 | * @task: iscsi task | 805 | * @task: iscsi task |
810 | * @hdr_itt: tag | 806 | * @hdr_itt: tag |
807 | * If the tag is a ddp tag, release the ddp setup | ||
811 | */ | 808 | */ |
812 | void cxgb3i_release_itt(struct iscsi_task *task, itt_t hdr_itt) | 809 | void cxgb3i_release_itt(struct iscsi_task *task, itt_t hdr_itt) |
813 | { | 810 | { |
diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.c b/drivers/scsi/cxgb3i/cxgb3i_offload.c index de3b3b614cca..c2e434e54e28 100644 --- a/drivers/scsi/cxgb3i/cxgb3i_offload.c +++ b/drivers/scsi/cxgb3i/cxgb3i_offload.c | |||
@@ -1417,8 +1417,7 @@ static void c3cn_active_close(struct s3_conn *c3cn) | |||
1417 | } | 1417 | } |
1418 | 1418 | ||
1419 | /** | 1419 | /** |
1420 | * cxgb3i_c3cn_release - close and release an iscsi tcp connection and any | 1420 | * cxgb3i_c3cn_release - close and release an iscsi tcp connection |
1421 | * resource held | ||
1422 | * @c3cn: the iscsi tcp connection | 1421 | * @c3cn: the iscsi tcp connection |
1423 | */ | 1422 | */ |
1424 | void cxgb3i_c3cn_release(struct s3_conn *c3cn) | 1423 | void cxgb3i_c3cn_release(struct s3_conn *c3cn) |
diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.h b/drivers/scsi/cxgb3i/cxgb3i_offload.h index 6344b9eb2589..275f23f16eb7 100644 --- a/drivers/scsi/cxgb3i/cxgb3i_offload.h +++ b/drivers/scsi/cxgb3i/cxgb3i_offload.h | |||
@@ -139,6 +139,7 @@ enum c3cn_flags { | |||
139 | 139 | ||
140 | /** | 140 | /** |
141 | * cxgb3i_sdev_data - Per adapter data. | 141 | * cxgb3i_sdev_data - Per adapter data. |
142 | * | ||
142 | * Linked off of each Ethernet device port on the adapter. | 143 | * Linked off of each Ethernet device port on the adapter. |
143 | * Also available via the t3cdev structure since we have pointers to our port | 144 | * Also available via the t3cdev structure since we have pointers to our port |
144 | * net_device's there ... | 145 | * net_device's there ... |