diff options
-rw-r--r-- | fs/xfs/xfs_sb.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/fs/xfs/xfs_sb.c b/fs/xfs/xfs_sb.c index 13c7834b0e65..b7c9aea77f8f 100644 --- a/fs/xfs/xfs_sb.c +++ b/fs/xfs/xfs_sb.c | |||
@@ -588,6 +588,11 @@ xfs_sb_verify( | |||
588 | * single bit error could clear the feature bit and unused parts of the | 588 | * single bit error could clear the feature bit and unused parts of the |
589 | * superblock are supposed to be zero. Hence a non-null crc field indicates that | 589 | * superblock are supposed to be zero. Hence a non-null crc field indicates that |
590 | * we've potentially lost a feature bit and we should check it anyway. | 590 | * we've potentially lost a feature bit and we should check it anyway. |
591 | * | ||
592 | * However, past bugs (i.e. in growfs) left non-zeroed regions beyond the | ||
593 | * last field in V4 secondary superblocks. So for secondary superblocks, | ||
594 | * we are more forgiving, and ignore CRC failures if the primary doesn't | ||
595 | * indicate that the fs version is V5. | ||
591 | */ | 596 | */ |
592 | static void | 597 | static void |
593 | xfs_sb_read_verify( | 598 | xfs_sb_read_verify( |
@@ -608,8 +613,12 @@ xfs_sb_read_verify( | |||
608 | 613 | ||
609 | if (!xfs_verify_cksum(bp->b_addr, be16_to_cpu(dsb->sb_sectsize), | 614 | if (!xfs_verify_cksum(bp->b_addr, be16_to_cpu(dsb->sb_sectsize), |
610 | offsetof(struct xfs_sb, sb_crc))) { | 615 | offsetof(struct xfs_sb, sb_crc))) { |
611 | error = EFSCORRUPTED; | 616 | /* Only fail bad secondaries on a known V5 filesystem */ |
612 | goto out_error; | 617 | if (bp->b_bn != XFS_SB_DADDR && |
618 | xfs_sb_version_hascrc(&mp->m_sb)) { | ||
619 | error = EFSCORRUPTED; | ||
620 | goto out_error; | ||
621 | } | ||
613 | } | 622 | } |
614 | } | 623 | } |
615 | error = xfs_sb_verify(bp, true); | 624 | error = xfs_sb_verify(bp, true); |