diff options
| -rw-r--r-- | block/blk-merge.c | 6 | ||||
| -rw-r--r-- | block/elevator.c | 8 | ||||
| -rw-r--r-- | drivers/block/cciss.c | 15 | ||||
| -rw-r--r-- | drivers/block/cciss_cmd.h | 1 |
4 files changed, 28 insertions, 2 deletions
diff --git a/block/blk-merge.c b/block/blk-merge.c index 39ce64432ba6..e1999679a4d5 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c | |||
| @@ -350,6 +350,12 @@ static int attempt_merge(struct request_queue *q, struct request *req, | |||
| 350 | if (blk_integrity_rq(req) != blk_integrity_rq(next)) | 350 | if (blk_integrity_rq(req) != blk_integrity_rq(next)) |
| 351 | return 0; | 351 | return 0; |
| 352 | 352 | ||
| 353 | /* don't merge requests of different failfast settings */ | ||
| 354 | if (blk_failfast_dev(req) != blk_failfast_dev(next) || | ||
| 355 | blk_failfast_transport(req) != blk_failfast_transport(next) || | ||
| 356 | blk_failfast_driver(req) != blk_failfast_driver(next)) | ||
| 357 | return 0; | ||
| 358 | |||
| 353 | /* | 359 | /* |
| 354 | * If we are allowed to merge, then append bio list | 360 | * If we are allowed to merge, then append bio list |
| 355 | * from next to rq and release next. merge_requests_fn | 361 | * from next to rq and release next. merge_requests_fn |
diff --git a/block/elevator.c b/block/elevator.c index ca861927ba41..6f2375339a99 100644 --- a/block/elevator.c +++ b/block/elevator.c | |||
| @@ -100,6 +100,14 @@ int elv_rq_merge_ok(struct request *rq, struct bio *bio) | |||
| 100 | if (bio_integrity(bio) != blk_integrity_rq(rq)) | 100 | if (bio_integrity(bio) != blk_integrity_rq(rq)) |
| 101 | return 0; | 101 | return 0; |
| 102 | 102 | ||
| 103 | /* | ||
| 104 | * Don't merge if failfast settings don't match | ||
| 105 | */ | ||
| 106 | if (bio_failfast_dev(bio) != blk_failfast_dev(rq) || | ||
| 107 | bio_failfast_transport(bio) != blk_failfast_transport(rq) || | ||
| 108 | bio_failfast_driver(bio) != blk_failfast_driver(rq)) | ||
| 109 | return 0; | ||
| 110 | |||
| 103 | if (!elv_iosched_allow_merge(rq, bio)) | 111 | if (!elv_iosched_allow_merge(rq, bio)) |
| 104 | return 0; | 112 | return 0; |
| 105 | 113 | ||
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index c7a527c08a09..65a0655e7fc8 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
| @@ -226,8 +226,18 @@ static inline void addQ(struct hlist_head *list, CommandList_struct *c) | |||
| 226 | 226 | ||
| 227 | static inline void removeQ(CommandList_struct *c) | 227 | static inline void removeQ(CommandList_struct *c) |
| 228 | { | 228 | { |
| 229 | if (WARN_ON(hlist_unhashed(&c->list))) | 229 | /* |
| 230 | * After kexec/dump some commands might still | ||
| 231 | * be in flight, which the firmware will try | ||
| 232 | * to complete. Resetting the firmware doesn't work | ||
| 233 | * with old fw revisions, so we have to mark | ||
| 234 | * them off as 'stale' to prevent the driver from | ||
| 235 | * falling over. | ||
| 236 | */ | ||
| 237 | if (WARN_ON(hlist_unhashed(&c->list))) { | ||
| 238 | c->cmd_type = CMD_MSG_STALE; | ||
| 230 | return; | 239 | return; |
| 240 | } | ||
| 231 | 241 | ||
| 232 | hlist_del_init(&c->list); | 242 | hlist_del_init(&c->list); |
| 233 | } | 243 | } |
| @@ -4246,7 +4256,8 @@ static void fail_all_cmds(unsigned long ctlr) | |||
| 4246 | while (!hlist_empty(&h->cmpQ)) { | 4256 | while (!hlist_empty(&h->cmpQ)) { |
| 4247 | c = hlist_entry(h->cmpQ.first, CommandList_struct, list); | 4257 | c = hlist_entry(h->cmpQ.first, CommandList_struct, list); |
| 4248 | removeQ(c); | 4258 | removeQ(c); |
| 4249 | c->err_info->CommandStatus = CMD_HARDWARE_ERR; | 4259 | if (c->cmd_type != CMD_MSG_STALE) |
| 4260 | c->err_info->CommandStatus = CMD_HARDWARE_ERR; | ||
| 4250 | if (c->cmd_type == CMD_RWREQ) { | 4261 | if (c->cmd_type == CMD_RWREQ) { |
| 4251 | complete_command(h, c, 0); | 4262 | complete_command(h, c, 0); |
| 4252 | } else if (c->cmd_type == CMD_IOCTL_PEND) | 4263 | } else if (c->cmd_type == CMD_IOCTL_PEND) |
diff --git a/drivers/block/cciss_cmd.h b/drivers/block/cciss_cmd.h index cd665b00c7c5..dbaed1ea0da3 100644 --- a/drivers/block/cciss_cmd.h +++ b/drivers/block/cciss_cmd.h | |||
| @@ -274,6 +274,7 @@ typedef struct _ErrorInfo_struct { | |||
| 274 | #define CMD_SCSI 0x03 | 274 | #define CMD_SCSI 0x03 |
| 275 | #define CMD_MSG_DONE 0x04 | 275 | #define CMD_MSG_DONE 0x04 |
| 276 | #define CMD_MSG_TIMEOUT 0x05 | 276 | #define CMD_MSG_TIMEOUT 0x05 |
| 277 | #define CMD_MSG_STALE 0xff | ||
| 277 | 278 | ||
| 278 | /* This structure needs to be divisible by 8 for new | 279 | /* This structure needs to be divisible by 8 for new |
| 279 | * indexing method. | 280 | * indexing method. |
