diff options
-rw-r--r-- | mm/huge_memory.c | 11 | ||||
-rw-r--r-- | mm/memory.c | 5 |
2 files changed, 10 insertions, 6 deletions
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index e2f7f5aaaafb..45eaae030628 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c | |||
@@ -713,6 +713,11 @@ static int __do_huge_pmd_anonymous_page(struct mm_struct *mm, | |||
713 | return VM_FAULT_OOM; | 713 | return VM_FAULT_OOM; |
714 | 714 | ||
715 | clear_huge_page(page, haddr, HPAGE_PMD_NR); | 715 | clear_huge_page(page, haddr, HPAGE_PMD_NR); |
716 | /* | ||
717 | * The memory barrier inside __SetPageUptodate makes sure that | ||
718 | * clear_huge_page writes become visible before the set_pmd_at() | ||
719 | * write. | ||
720 | */ | ||
716 | __SetPageUptodate(page); | 721 | __SetPageUptodate(page); |
717 | 722 | ||
718 | spin_lock(&mm->page_table_lock); | 723 | spin_lock(&mm->page_table_lock); |
@@ -724,12 +729,6 @@ static int __do_huge_pmd_anonymous_page(struct mm_struct *mm, | |||
724 | } else { | 729 | } else { |
725 | pmd_t entry; | 730 | pmd_t entry; |
726 | entry = mk_huge_pmd(page, vma); | 731 | entry = mk_huge_pmd(page, vma); |
727 | /* | ||
728 | * The spinlocking to take the lru_lock inside | ||
729 | * page_add_new_anon_rmap() acts as a full memory | ||
730 | * barrier to be sure clear_huge_page writes become | ||
731 | * visible after the set_pmd_at() write. | ||
732 | */ | ||
733 | page_add_new_anon_rmap(page, vma, haddr); | 732 | page_add_new_anon_rmap(page, vma, haddr); |
734 | set_pmd_at(mm, haddr, pmd, entry); | 733 | set_pmd_at(mm, haddr, pmd, entry); |
735 | pgtable_trans_huge_deposit(mm, pgtable); | 734 | pgtable_trans_huge_deposit(mm, pgtable); |
diff --git a/mm/memory.c b/mm/memory.c index ba94dec5b259..f7a1fba85d14 100644 --- a/mm/memory.c +++ b/mm/memory.c | |||
@@ -3244,6 +3244,11 @@ static int do_anonymous_page(struct mm_struct *mm, struct vm_area_struct *vma, | |||
3244 | page = alloc_zeroed_user_highpage_movable(vma, address); | 3244 | page = alloc_zeroed_user_highpage_movable(vma, address); |
3245 | if (!page) | 3245 | if (!page) |
3246 | goto oom; | 3246 | goto oom; |
3247 | /* | ||
3248 | * The memory barrier inside __SetPageUptodate makes sure that | ||
3249 | * preceeding stores to the page contents become visible before | ||
3250 | * the set_pte_at() write. | ||
3251 | */ | ||
3247 | __SetPageUptodate(page); | 3252 | __SetPageUptodate(page); |
3248 | 3253 | ||
3249 | if (mem_cgroup_newpage_charge(page, mm, GFP_KERNEL)) | 3254 | if (mem_cgroup_newpage_charge(page, mm, GFP_KERNEL)) |