diff options
125 files changed, 5240 insertions, 1219 deletions
diff --git a/Documentation/cgroups/cgroups.txt b/Documentation/cgroups/cgroups.txt index d9014aa0eb68..e33ee74eee77 100644 --- a/Documentation/cgroups/cgroups.txt +++ b/Documentation/cgroups/cgroups.txt | |||
@@ -227,7 +227,6 @@ Each cgroup is represented by a directory in the cgroup file system | |||
227 | containing the following files describing that cgroup: | 227 | containing the following files describing that cgroup: |
228 | 228 | ||
229 | - tasks: list of tasks (by pid) attached to that cgroup | 229 | - tasks: list of tasks (by pid) attached to that cgroup |
230 | - releasable flag: cgroup currently removeable? | ||
231 | - notify_on_release flag: run the release agent on exit? | 230 | - notify_on_release flag: run the release agent on exit? |
232 | - release_agent: the path to use for release notifications (this file | 231 | - release_agent: the path to use for release notifications (this file |
233 | exists in the top cgroup only) | 232 | exists in the top cgroup only) |
@@ -360,7 +359,7 @@ Now you want to do something with this cgroup. | |||
360 | 359 | ||
361 | In this directory you can find several files: | 360 | In this directory you can find several files: |
362 | # ls | 361 | # ls |
363 | notify_on_release releasable tasks | 362 | notify_on_release tasks |
364 | (plus whatever files added by the attached subsystems) | 363 | (plus whatever files added by the attached subsystems) |
365 | 364 | ||
366 | Now attach your shell to this cgroup: | 365 | Now attach your shell to this cgroup: |
@@ -479,7 +478,6 @@ newly-created cgroup if an error occurs after this subsystem's | |||
479 | create() method has been called for the new cgroup). | 478 | create() method has been called for the new cgroup). |
480 | 479 | ||
481 | void pre_destroy(struct cgroup_subsys *ss, struct cgroup *cgrp); | 480 | void pre_destroy(struct cgroup_subsys *ss, struct cgroup *cgrp); |
482 | (cgroup_mutex held by caller) | ||
483 | 481 | ||
484 | Called before checking the reference count on each subsystem. This may | 482 | Called before checking the reference count on each subsystem. This may |
485 | be useful for subsystems which have some extra references even if | 483 | be useful for subsystems which have some extra references even if |
@@ -498,6 +496,7 @@ remain valid while the caller holds cgroup_mutex. | |||
498 | 496 | ||
499 | void attach(struct cgroup_subsys *ss, struct cgroup *cgrp, | 497 | void attach(struct cgroup_subsys *ss, struct cgroup *cgrp, |
500 | struct cgroup *old_cgrp, struct task_struct *task) | 498 | struct cgroup *old_cgrp, struct task_struct *task) |
499 | (cgroup_mutex held by caller) | ||
501 | 500 | ||
502 | Called after the task has been attached to the cgroup, to allow any | 501 | Called after the task has been attached to the cgroup, to allow any |
503 | post-attachment activity that requires memory allocations or blocking. | 502 | post-attachment activity that requires memory allocations or blocking. |
@@ -511,6 +510,7 @@ void exit(struct cgroup_subsys *ss, struct task_struct *task) | |||
511 | Called during task exit. | 510 | Called during task exit. |
512 | 511 | ||
513 | int populate(struct cgroup_subsys *ss, struct cgroup *cgrp) | 512 | int populate(struct cgroup_subsys *ss, struct cgroup *cgrp) |
513 | (cgroup_mutex held by caller) | ||
514 | 514 | ||
515 | Called after creation of a cgroup to allow a subsystem to populate | 515 | Called after creation of a cgroup to allow a subsystem to populate |
516 | the cgroup directory with file entries. The subsystem should make | 516 | the cgroup directory with file entries. The subsystem should make |
@@ -520,6 +520,7 @@ method can return an error code, the error code is currently not | |||
520 | always handled well. | 520 | always handled well. |
521 | 521 | ||
522 | void post_clone(struct cgroup_subsys *ss, struct cgroup *cgrp) | 522 | void post_clone(struct cgroup_subsys *ss, struct cgroup *cgrp) |
523 | (cgroup_mutex held by caller) | ||
523 | 524 | ||
524 | Called at the end of cgroup_clone() to do any paramater | 525 | Called at the end of cgroup_clone() to do any paramater |
525 | initialization which might be required before a task could attach. For | 526 | initialization which might be required before a task could attach. For |
@@ -527,7 +528,7 @@ example in cpusets, no task may attach before 'cpus' and 'mems' are set | |||
527 | up. | 528 | up. |
528 | 529 | ||
529 | void bind(struct cgroup_subsys *ss, struct cgroup *root) | 530 | void bind(struct cgroup_subsys *ss, struct cgroup *root) |
530 | (cgroup_mutex held by caller) | 531 | (cgroup_mutex and ss->hierarchy_mutex held by caller) |
531 | 532 | ||
532 | Called when a cgroup subsystem is rebound to a different hierarchy | 533 | Called when a cgroup subsystem is rebound to a different hierarchy |
533 | and root cgroup. Currently this will only involve movement between | 534 | and root cgroup. Currently this will only involve movement between |
diff --git a/Documentation/controllers/memcg_test.txt b/Documentation/controllers/memcg_test.txt new file mode 100644 index 000000000000..08d4d3ea0d79 --- /dev/null +++ b/Documentation/controllers/memcg_test.txt | |||
@@ -0,0 +1,342 @@ | |||
1 | Memory Resource Controller(Memcg) Implementation Memo. | ||
2 | Last Updated: 2008/12/15 | ||
3 | Base Kernel Version: based on 2.6.28-rc8-mm. | ||
4 | |||
5 | Because VM is getting complex (one of reasons is memcg...), memcg's behavior | ||
6 | is complex. This is a document for memcg's internal behavior. | ||
7 | Please note that implementation details can be changed. | ||
8 | |||
9 | (*) Topics on API should be in Documentation/controllers/memory.txt) | ||
10 | |||
11 | 0. How to record usage ? | ||
12 | 2 objects are used. | ||
13 | |||
14 | page_cgroup ....an object per page. | ||
15 | Allocated at boot or memory hotplug. Freed at memory hot removal. | ||
16 | |||
17 | swap_cgroup ... an entry per swp_entry. | ||
18 | Allocated at swapon(). Freed at swapoff(). | ||
19 | |||
20 | The page_cgroup has USED bit and double count against a page_cgroup never | ||
21 | occurs. swap_cgroup is used only when a charged page is swapped-out. | ||
22 | |||
23 | 1. Charge | ||
24 | |||
25 | a page/swp_entry may be charged (usage += PAGE_SIZE) at | ||
26 | |||
27 | mem_cgroup_newpage_charge() | ||
28 | Called at new page fault and Copy-On-Write. | ||
29 | |||
30 | mem_cgroup_try_charge_swapin() | ||
31 | Called at do_swap_page() (page fault on swap entry) and swapoff. | ||
32 | Followed by charge-commit-cancel protocol. (With swap accounting) | ||
33 | At commit, a charge recorded in swap_cgroup is removed. | ||
34 | |||
35 | mem_cgroup_cache_charge() | ||
36 | Called at add_to_page_cache() | ||
37 | |||
38 | mem_cgroup_cache_charge_swapin() | ||
39 | Called at shmem's swapin. | ||
40 | |||
41 | mem_cgroup_prepare_migration() | ||
42 | Called before migration. "extra" charge is done and followed by | ||
43 | charge-commit-cancel protocol. | ||
44 | At commit, charge against oldpage or newpage will be committed. | ||
45 | |||
46 | 2. Uncharge | ||
47 | a page/swp_entry may be uncharged (usage -= PAGE_SIZE) by | ||
48 | |||
49 | mem_cgroup_uncharge_page() | ||
50 | Called when an anonymous page is fully unmapped. I.e., mapcount goes | ||
51 | to 0. If the page is SwapCache, uncharge is delayed until | ||
52 | mem_cgroup_uncharge_swapcache(). | ||
53 | |||
54 | mem_cgroup_uncharge_cache_page() | ||
55 | Called when a page-cache is deleted from radix-tree. If the page is | ||
56 | SwapCache, uncharge is delayed until mem_cgroup_uncharge_swapcache(). | ||
57 | |||
58 | mem_cgroup_uncharge_swapcache() | ||
59 | Called when SwapCache is removed from radix-tree. The charge itself | ||
60 | is moved to swap_cgroup. (If mem+swap controller is disabled, no | ||
61 | charge to swap occurs.) | ||
62 | |||
63 | mem_cgroup_uncharge_swap() | ||
64 | Called when swp_entry's refcnt goes down to 0. A charge against swap | ||
65 | disappears. | ||
66 | |||
67 | mem_cgroup_end_migration(old, new) | ||
68 | At success of migration old is uncharged (if necessary), a charge | ||
69 | to new page is committed. At failure, charge to old page is committed. | ||
70 | |||
71 | 3. charge-commit-cancel | ||
72 | In some case, we can't know this "charge" is valid or not at charging | ||
73 | (because of races). | ||
74 | To handle such case, there are charge-commit-cancel functions. | ||
75 | mem_cgroup_try_charge_XXX | ||
76 | mem_cgroup_commit_charge_XXX | ||
77 | mem_cgroup_cancel_charge_XXX | ||
78 | these are used in swap-in and migration. | ||
79 | |||
80 | At try_charge(), there are no flags to say "this page is charged". | ||
81 | at this point, usage += PAGE_SIZE. | ||
82 | |||
83 | At commit(), the function checks the page should be charged or not | ||
84 | and set flags or avoid charging.(usage -= PAGE_SIZE) | ||
85 | |||
86 | At cancel(), simply usage -= PAGE_SIZE. | ||
87 | |||
88 | Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y. | ||
89 | |||
90 | 4. Anonymous | ||
91 | Anonymous page is newly allocated at | ||
92 | - page fault into MAP_ANONYMOUS mapping. | ||
93 | - Copy-On-Write. | ||
94 | It is charged right after it's allocated before doing any page table | ||
95 | related operations. Of course, it's uncharged when another page is used | ||
96 | for the fault address. | ||
97 | |||
98 | At freeing anonymous page (by exit() or munmap()), zap_pte() is called | ||
99 | and pages for ptes are freed one by one.(see mm/memory.c). Uncharges | ||
100 | are done at page_remove_rmap() when page_mapcount() goes down to 0. | ||
101 | |||
102 | Another page freeing is by page-reclaim (vmscan.c) and anonymous | ||
103 | pages are swapped out. In this case, the page is marked as | ||
104 | PageSwapCache(). uncharge() routine doesn't uncharge the page marked | ||
105 | as SwapCache(). It's delayed until __delete_from_swap_cache(). | ||
106 | |||
107 | 4.1 Swap-in. | ||
108 | At swap-in, the page is taken from swap-cache. There are 2 cases. | ||
109 | |||
110 | (a) If the SwapCache is newly allocated and read, it has no charges. | ||
111 | (b) If the SwapCache has been mapped by processes, it has been | ||
112 | charged already. | ||
113 | |||
114 | This swap-in is one of the most complicated work. In do_swap_page(), | ||
115 | following events occur when pte is unchanged. | ||
116 | |||
117 | (1) the page (SwapCache) is looked up. | ||
118 | (2) lock_page() | ||
119 | (3) try_charge_swapin() | ||
120 | (4) reuse_swap_page() (may call delete_swap_cache()) | ||
121 | (5) commit_charge_swapin() | ||
122 | (6) swap_free(). | ||
123 | |||
124 | Considering following situation for example. | ||
125 | |||
126 | (A) The page has not been charged before (2) and reuse_swap_page() | ||
127 | doesn't call delete_from_swap_cache(). | ||
128 | (B) The page has not been charged before (2) and reuse_swap_page() | ||
129 | calls delete_from_swap_cache(). | ||
130 | (C) The page has been charged before (2) and reuse_swap_page() doesn't | ||
131 | call delete_from_swap_cache(). | ||
132 | (D) The page has been charged before (2) and reuse_swap_page() calls | ||
133 | delete_from_swap_cache(). | ||
134 | |||
135 | memory.usage/memsw.usage changes to this page/swp_entry will be | ||
136 | Case (A) (B) (C) (D) | ||
137 | Event | ||
138 | Before (2) 0/ 1 0/ 1 1/ 1 1/ 1 | ||
139 | =========================================== | ||
140 | (3) +1/+1 +1/+1 +1/+1 +1/+1 | ||
141 | (4) - 0/ 0 - -1/ 0 | ||
142 | (5) 0/-1 0/ 0 -1/-1 0/ 0 | ||
143 | (6) - 0/-1 - 0/-1 | ||
144 | =========================================== | ||
145 | Result 1/ 1 1/ 1 1/ 1 1/ 1 | ||
146 | |||
147 | In any cases, charges to this page should be 1/ 1. | ||
148 | |||
149 | 4.2 Swap-out. | ||
150 | At swap-out, typical state transition is below. | ||
151 | |||
152 | (a) add to swap cache. (marked as SwapCache) | ||
153 | swp_entry's refcnt += 1. | ||
154 | (b) fully unmapped. | ||
155 | swp_entry's refcnt += # of ptes. | ||
156 | (c) write back to swap. | ||
157 | (d) delete from swap cache. (remove from SwapCache) | ||
158 | swp_entry's refcnt -= 1. | ||
159 | |||
160 | |||
161 | At (b), the page is marked as SwapCache and not uncharged. | ||
162 | At (d), the page is removed from SwapCache and a charge in page_cgroup | ||
163 | is moved to swap_cgroup. | ||
164 | |||
165 | Finally, at task exit, | ||
166 | (e) zap_pte() is called and swp_entry's refcnt -=1 -> 0. | ||
167 | Here, a charge in swap_cgroup disappears. | ||
168 | |||
169 | 5. Page Cache | ||
170 | Page Cache is charged at | ||
171 | - add_to_page_cache_locked(). | ||
172 | |||
173 | uncharged at | ||
174 | - __remove_from_page_cache(). | ||
175 | |||
176 | The logic is very clear. (About migration, see below) | ||
177 | Note: __remove_from_page_cache() is called by remove_from_page_cache() | ||
178 | and __remove_mapping(). | ||
179 | |||
180 | 6. Shmem(tmpfs) Page Cache | ||
181 | Memcg's charge/uncharge have special handlers of shmem. The best way | ||
182 | to understand shmem's page state transition is to read mm/shmem.c. | ||
183 | But brief explanation of the behavior of memcg around shmem will be | ||
184 | helpful to understand the logic. | ||
185 | |||
186 | Shmem's page (just leaf page, not direct/indirect block) can be on | ||
187 | - radix-tree of shmem's inode. | ||
188 | - SwapCache. | ||
189 | - Both on radix-tree and SwapCache. This happens at swap-in | ||
190 | and swap-out, | ||
191 | |||
192 | It's charged when... | ||
193 | - A new page is added to shmem's radix-tree. | ||
194 | - A swp page is read. (move a charge from swap_cgroup to page_cgroup) | ||
195 | It's uncharged when | ||
196 | - A page is removed from radix-tree and not SwapCache. | ||
197 | - When SwapCache is removed, a charge is moved to swap_cgroup. | ||
198 | - When swp_entry's refcnt goes down to 0, a charge in swap_cgroup | ||
199 | disappears. | ||
200 | |||
201 | 7. Page Migration | ||
202 | One of the most complicated functions is page-migration-handler. | ||
203 | Memcg has 2 routines. Assume that we are migrating a page's contents | ||
204 | from OLDPAGE to NEWPAGE. | ||
205 | |||
206 | Usual migration logic is.. | ||
207 | (a) remove the page from LRU. | ||
208 | (b) allocate NEWPAGE (migration target) | ||
209 | (c) lock by lock_page(). | ||
210 | (d) unmap all mappings. | ||
211 | (e-1) If necessary, replace entry in radix-tree. | ||
212 | (e-2) move contents of a page. | ||
213 | (f) map all mappings again. | ||
214 | (g) pushback the page to LRU. | ||
215 | (-) OLDPAGE will be freed. | ||
216 | |||
217 | Before (g), memcg should complete all necessary charge/uncharge to | ||
218 | NEWPAGE/OLDPAGE. | ||
219 | |||
220 | The point is.... | ||
221 | - If OLDPAGE is anonymous, all charges will be dropped at (d) because | ||
222 | try_to_unmap() drops all mapcount and the page will not be | ||
223 | SwapCache. | ||
224 | |||
225 | - If OLDPAGE is SwapCache, charges will be kept at (g) because | ||
226 | __delete_from_swap_cache() isn't called at (e-1) | ||
227 | |||
228 | - If OLDPAGE is page-cache, charges will be kept at (g) because | ||
229 | remove_from_swap_cache() isn't called at (e-1) | ||
230 | |||
231 | memcg provides following hooks. | ||
232 | |||
233 | - mem_cgroup_prepare_migration(OLDPAGE) | ||
234 | Called after (b) to account a charge (usage += PAGE_SIZE) against | ||
235 | memcg which OLDPAGE belongs to. | ||
236 | |||
237 | - mem_cgroup_end_migration(OLDPAGE, NEWPAGE) | ||
238 | Called after (f) before (g). | ||
239 | If OLDPAGE is used, commit OLDPAGE again. If OLDPAGE is already | ||
240 | charged, a charge by prepare_migration() is automatically canceled. | ||
241 | If NEWPAGE is used, commit NEWPAGE and uncharge OLDPAGE. | ||
242 | |||
243 | But zap_pte() (by exit or munmap) can be called while migration, | ||
244 | we have to check if OLDPAGE/NEWPAGE is a valid page after commit(). | ||
245 | |||
246 | 8. LRU | ||
247 | Each memcg has its own private LRU. Now, it's handling is under global | ||
248 | VM's control (means that it's handled under global zone->lru_lock). | ||
249 | Almost all routines around memcg's LRU is called by global LRU's | ||
250 | list management functions under zone->lru_lock(). | ||
251 | |||
252 | A special function is mem_cgroup_isolate_pages(). This scans | ||
253 | memcg's private LRU and call __isolate_lru_page() to extract a page | ||
254 | from LRU. | ||
255 | (By __isolate_lru_page(), the page is removed from both of global and | ||
256 | private LRU.) | ||
257 | |||
258 | |||
259 | 9. Typical Tests. | ||
260 | |||
261 | Tests for racy cases. | ||
262 | |||
263 | 9.1 Small limit to memcg. | ||
264 | When you do test to do racy case, it's good test to set memcg's limit | ||
265 | to be very small rather than GB. Many races found in the test under | ||
266 | xKB or xxMB limits. | ||
267 | (Memory behavior under GB and Memory behavior under MB shows very | ||
268 | different situation.) | ||
269 | |||
270 | 9.2 Shmem | ||
271 | Historically, memcg's shmem handling was poor and we saw some amount | ||
272 | of troubles here. This is because shmem is page-cache but can be | ||
273 | SwapCache. Test with shmem/tmpfs is always good test. | ||
274 | |||
275 | 9.3 Migration | ||
276 | For NUMA, migration is an another special case. To do easy test, cpuset | ||
277 | is useful. Following is a sample script to do migration. | ||
278 | |||
279 | mount -t cgroup -o cpuset none /opt/cpuset | ||
280 | |||
281 | mkdir /opt/cpuset/01 | ||
282 | echo 1 > /opt/cpuset/01/cpuset.cpus | ||
283 | echo 0 > /opt/cpuset/01/cpuset.mems | ||
284 | echo 1 > /opt/cpuset/01/cpuset.memory_migrate | ||
285 | mkdir /opt/cpuset/02 | ||
286 | echo 1 > /opt/cpuset/02/cpuset.cpus | ||
287 | echo 1 > /opt/cpuset/02/cpuset.mems | ||
288 | echo 1 > /opt/cpuset/02/cpuset.memory_migrate | ||
289 | |||
290 | In above set, when you moves a task from 01 to 02, page migration to | ||
291 | node 0 to node 1 will occur. Following is a script to migrate all | ||
292 | under cpuset. | ||
293 | -- | ||
294 | move_task() | ||
295 | { | ||
296 | for pid in $1 | ||
297 | do | ||
298 | /bin/echo $pid >$2/tasks 2>/dev/null | ||
299 | echo -n $pid | ||
300 | echo -n " " | ||
301 | done | ||
302 | echo END | ||
303 | } | ||
304 | |||
305 | G1_TASK=`cat ${G1}/tasks` | ||
306 | G2_TASK=`cat ${G2}/tasks` | ||
307 | move_task "${G1_TASK}" ${G2} & | ||
308 | -- | ||
309 | 9.4 Memory hotplug. | ||
310 | memory hotplug test is one of good test. | ||
311 | to offline memory, do following. | ||
312 | # echo offline > /sys/devices/system/memory/memoryXXX/state | ||
313 | (XXX is the place of memory) | ||
314 | This is an easy way to test page migration, too. | ||
315 | |||
316 | 9.5 mkdir/rmdir | ||
317 | When using hierarchy, mkdir/rmdir test should be done. | ||
318 | Use tests like the following. | ||
319 | |||
320 | echo 1 >/opt/cgroup/01/memory/use_hierarchy | ||
321 | mkdir /opt/cgroup/01/child_a | ||
322 | mkdir /opt/cgroup/01/child_b | ||
323 | |||
324 | set limit to 01. | ||
325 | add limit to 01/child_b | ||
326 | run jobs under child_a and child_b | ||
327 | |||
328 | create/delete following groups at random while jobs are running. | ||
329 | /opt/cgroup/01/child_a/child_aa | ||
330 | /opt/cgroup/01/child_b/child_bb | ||
331 | /opt/cgroup/01/child_c | ||
332 | |||
333 | running new jobs in new group is also good. | ||
334 | |||
335 | 9.6 Mount with other subsystems. | ||
336 | Mounting with other subsystems is a good test because there is a | ||
337 | race and lock dependency with other cgroup subsystems. | ||
338 | |||
339 | example) | ||
340 | # mount -t cgroup none /cgroup -t cpuset,memory,cpu,devices | ||
341 | |||
342 | and do task move, mkdir, rmdir etc...under this. | ||
diff --git a/Documentation/controllers/memory.txt b/Documentation/controllers/memory.txt index 1c07547d3f81..e1501964df1e 100644 --- a/Documentation/controllers/memory.txt +++ b/Documentation/controllers/memory.txt | |||
@@ -137,7 +137,32 @@ behind this approach is that a cgroup that aggressively uses a shared | |||
137 | page will eventually get charged for it (once it is uncharged from | 137 | page will eventually get charged for it (once it is uncharged from |
138 | the cgroup that brought it in -- this will happen on memory pressure). | 138 | the cgroup that brought it in -- this will happen on memory pressure). |
139 | 139 | ||
140 | 2.4 Reclaim | 140 | Exception: If CONFIG_CGROUP_CGROUP_MEM_RES_CTLR_SWAP is not used.. |
141 | When you do swapoff and make swapped-out pages of shmem(tmpfs) to | ||
142 | be backed into memory in force, charges for pages are accounted against the | ||
143 | caller of swapoff rather than the users of shmem. | ||
144 | |||
145 | |||
146 | 2.4 Swap Extension (CONFIG_CGROUP_MEM_RES_CTLR_SWAP) | ||
147 | Swap Extension allows you to record charge for swap. A swapped-in page is | ||
148 | charged back to original page allocator if possible. | ||
149 | |||
150 | When swap is accounted, following files are added. | ||
151 | - memory.memsw.usage_in_bytes. | ||
152 | - memory.memsw.limit_in_bytes. | ||
153 | |||
154 | usage of mem+swap is limited by memsw.limit_in_bytes. | ||
155 | |||
156 | Note: why 'mem+swap' rather than swap. | ||
157 | The global LRU(kswapd) can swap out arbitrary pages. Swap-out means | ||
158 | to move account from memory to swap...there is no change in usage of | ||
159 | mem+swap. | ||
160 | |||
161 | In other words, when we want to limit the usage of swap without affecting | ||
162 | global LRU, mem+swap limit is better than just limiting swap from OS point | ||
163 | of view. | ||
164 | |||
165 | 2.5 Reclaim | ||
141 | 166 | ||
142 | Each cgroup maintains a per cgroup LRU that consists of an active | 167 | Each cgroup maintains a per cgroup LRU that consists of an active |
143 | and inactive list. When a cgroup goes over its limit, we first try | 168 | and inactive list. When a cgroup goes over its limit, we first try |
@@ -207,12 +232,6 @@ exceeded. | |||
207 | The memory.stat file gives accounting information. Now, the number of | 232 | The memory.stat file gives accounting information. Now, the number of |
208 | caches, RSS and Active pages/Inactive pages are shown. | 233 | caches, RSS and Active pages/Inactive pages are shown. |
209 | 234 | ||
210 | The memory.force_empty gives an interface to drop *all* charges by force. | ||
211 | |||
212 | # echo 1 > memory.force_empty | ||
213 | |||
214 | will drop all charges in cgroup. Currently, this is maintained for test. | ||
215 | |||
216 | 4. Testing | 235 | 4. Testing |
217 | 236 | ||
218 | Balbir posted lmbench, AIM9, LTP and vmmstress results [10] and [11]. | 237 | Balbir posted lmbench, AIM9, LTP and vmmstress results [10] and [11]. |
@@ -242,10 +261,106 @@ reclaimed. | |||
242 | 261 | ||
243 | A cgroup can be removed by rmdir, but as discussed in sections 4.1 and 4.2, a | 262 | A cgroup can be removed by rmdir, but as discussed in sections 4.1 and 4.2, a |
244 | cgroup might have some charge associated with it, even though all | 263 | cgroup might have some charge associated with it, even though all |
245 | tasks have migrated away from it. Such charges are automatically dropped at | 264 | tasks have migrated away from it. |
246 | rmdir() if there are no tasks. | 265 | Such charges are freed(at default) or moved to its parent. When moved, |
266 | both of RSS and CACHES are moved to parent. | ||
267 | If both of them are busy, rmdir() returns -EBUSY. See 5.1 Also. | ||
268 | |||
269 | Charges recorded in swap information is not updated at removal of cgroup. | ||
270 | Recorded information is discarded and a cgroup which uses swap (swapcache) | ||
271 | will be charged as a new owner of it. | ||
272 | |||
273 | |||
274 | 5. Misc. interfaces. | ||
275 | |||
276 | 5.1 force_empty | ||
277 | memory.force_empty interface is provided to make cgroup's memory usage empty. | ||
278 | You can use this interface only when the cgroup has no tasks. | ||
279 | When writing anything to this | ||
280 | |||
281 | # echo 0 > memory.force_empty | ||
282 | |||
283 | Almost all pages tracked by this memcg will be unmapped and freed. Some of | ||
284 | pages cannot be freed because it's locked or in-use. Such pages are moved | ||
285 | to parent and this cgroup will be empty. But this may return -EBUSY in | ||
286 | some too busy case. | ||
287 | |||
288 | Typical use case of this interface is that calling this before rmdir(). | ||
289 | Because rmdir() moves all pages to parent, some out-of-use page caches can be | ||
290 | moved to the parent. If you want to avoid that, force_empty will be useful. | ||
291 | |||
292 | 5.2 stat file | ||
293 | memory.stat file includes following statistics (now) | ||
294 | cache - # of pages from page-cache and shmem. | ||
295 | rss - # of pages from anonymous memory. | ||
296 | pgpgin - # of event of charging | ||
297 | pgpgout - # of event of uncharging | ||
298 | active_anon - # of pages on active lru of anon, shmem. | ||
299 | inactive_anon - # of pages on active lru of anon, shmem | ||
300 | active_file - # of pages on active lru of file-cache | ||
301 | inactive_file - # of pages on inactive lru of file cache | ||
302 | unevictable - # of pages cannot be reclaimed.(mlocked etc) | ||
303 | |||
304 | Below is depend on CONFIG_DEBUG_VM. | ||
305 | inactive_ratio - VM inernal parameter. (see mm/page_alloc.c) | ||
306 | recent_rotated_anon - VM internal parameter. (see mm/vmscan.c) | ||
307 | recent_rotated_file - VM internal parameter. (see mm/vmscan.c) | ||
308 | recent_scanned_anon - VM internal parameter. (see mm/vmscan.c) | ||
309 | recent_scanned_file - VM internal parameter. (see mm/vmscan.c) | ||
310 | |||
311 | Memo: | ||
312 | recent_rotated means recent frequency of lru rotation. | ||
313 | recent_scanned means recent # of scans to lru. | ||
314 | showing for better debug please see the code for meanings. | ||
315 | |||
316 | |||
317 | 5.3 swappiness | ||
318 | Similar to /proc/sys/vm/swappiness, but affecting a hierarchy of groups only. | ||
319 | |||
320 | Following cgroup's swapiness can't be changed. | ||
321 | - root cgroup (uses /proc/sys/vm/swappiness). | ||
322 | - a cgroup which uses hierarchy and it has child cgroup. | ||
323 | - a cgroup which uses hierarchy and not the root of hierarchy. | ||
324 | |||
325 | |||
326 | 6. Hierarchy support | ||
327 | |||
328 | The memory controller supports a deep hierarchy and hierarchical accounting. | ||
329 | The hierarchy is created by creating the appropriate cgroups in the | ||
330 | cgroup filesystem. Consider for example, the following cgroup filesystem | ||
331 | hierarchy | ||
332 | |||
333 | root | ||
334 | / | \ | ||
335 | / | \ | ||
336 | a b c | ||
337 | | \ | ||
338 | | \ | ||
339 | d e | ||
340 | |||
341 | In the diagram above, with hierarchical accounting enabled, all memory | ||
342 | usage of e, is accounted to its ancestors up until the root (i.e, c and root), | ||
343 | that has memory.use_hierarchy enabled. If one of the ancestors goes over its | ||
344 | limit, the reclaim algorithm reclaims from the tasks in the ancestor and the | ||
345 | children of the ancestor. | ||
346 | |||
347 | 6.1 Enabling hierarchical accounting and reclaim | ||
348 | |||
349 | The memory controller by default disables the hierarchy feature. Support | ||
350 | can be enabled by writing 1 to memory.use_hierarchy file of the root cgroup | ||
351 | |||
352 | # echo 1 > memory.use_hierarchy | ||
353 | |||
354 | The feature can be disabled by | ||
355 | |||
356 | # echo 0 > memory.use_hierarchy | ||
357 | |||
358 | NOTE1: Enabling/disabling will fail if the cgroup already has other | ||
359 | cgroups created below it. | ||
360 | |||
361 | NOTE2: This feature can be enabled/disabled per subtree. | ||
247 | 362 | ||
248 | 5. TODO | 363 | 7. TODO |
249 | 364 | ||
250 | 1. Add support for accounting huge pages (as a separate controller) | 365 | 1. Add support for accounting huge pages (as a separate controller) |
251 | 2. Make per-cgroup scanner reclaim not-shared pages first | 366 | 2. Make per-cgroup scanner reclaim not-shared pages first |
diff --git a/Documentation/hwmon/abituguru-datasheet b/Documentation/hwmon/abituguru-datasheet index 4d184f2db0ea..d9251efdcec7 100644 --- a/Documentation/hwmon/abituguru-datasheet +++ b/Documentation/hwmon/abituguru-datasheet | |||
@@ -121,7 +121,7 @@ Once all bytes have been read data will hold 0x09, but there is no reason to | |||
121 | test for this. Notice that the number of bytes is bank address dependent see | 121 | test for this. Notice that the number of bytes is bank address dependent see |
122 | above and below. | 122 | above and below. |
123 | 123 | ||
124 | After completing a successfull read it is advised to put the uGuru back in | 124 | After completing a successful read it is advised to put the uGuru back in |
125 | ready mode, so that it is ready for the next read / write cycle. This way | 125 | ready mode, so that it is ready for the next read / write cycle. This way |
126 | if your program / driver is unloaded and later loaded again the detection | 126 | if your program / driver is unloaded and later loaded again the detection |
127 | algorithm described above will still work. | 127 | algorithm described above will still work. |
@@ -141,7 +141,7 @@ don't ask why this is the way it is. | |||
141 | 141 | ||
142 | Once DATA holds 0x01 read CMD it should hold 0xAC now. | 142 | Once DATA holds 0x01 read CMD it should hold 0xAC now. |
143 | 143 | ||
144 | After completing a successfull write it is advised to put the uGuru back in | 144 | After completing a successful write it is advised to put the uGuru back in |
145 | ready mode, so that it is ready for the next read / write cycle. This way | 145 | ready mode, so that it is ready for the next read / write cycle. This way |
146 | if your program / driver is unloaded and later loaded again the detection | 146 | if your program / driver is unloaded and later loaded again the detection |
147 | algorithm described above will still work. | 147 | algorithm described above will still work. |
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 532eacbbed62..fb849020aea9 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt | |||
@@ -1562,6 +1562,9 @@ and is between 256 and 4096 characters. It is defined in the file | |||
1562 | 1562 | ||
1563 | nosoftlockup [KNL] Disable the soft-lockup detector. | 1563 | nosoftlockup [KNL] Disable the soft-lockup detector. |
1564 | 1564 | ||
1565 | noswapaccount [KNL] Disable accounting of swap in memory resource | ||
1566 | controller. (See Documentation/controllers/memory.txt) | ||
1567 | |||
1565 | nosync [HW,M68K] Disables sync negotiation for all devices. | 1568 | nosync [HW,M68K] Disables sync negotiation for all devices. |
1566 | 1569 | ||
1567 | notsc [BUGS=X86-32] Disable Time Stamp Counter | 1570 | notsc [BUGS=X86-32] Disable Time Stamp Counter |
diff --git a/Documentation/scsi/scsi_fc_transport.txt b/Documentation/scsi/scsi_fc_transport.txt index 38d324d62b25..e5b071d46619 100644 --- a/Documentation/scsi/scsi_fc_transport.txt +++ b/Documentation/scsi/scsi_fc_transport.txt | |||
@@ -191,7 +191,7 @@ Vport States: | |||
191 | This is equivalent to a driver "attach" on an adapter, which is | 191 | This is equivalent to a driver "attach" on an adapter, which is |
192 | independent of the adapter's link state. | 192 | independent of the adapter's link state. |
193 | - Instantiation of the vport on the FC link via ELS traffic, etc. | 193 | - Instantiation of the vport on the FC link via ELS traffic, etc. |
194 | This is equivalent to a "link up" and successfull link initialization. | 194 | This is equivalent to a "link up" and successful link initialization. |
195 | Further information can be found in the interfaces section below for | 195 | Further information can be found in the interfaces section below for |
196 | Vport Creation. | 196 | Vport Creation. |
197 | 197 | ||
@@ -320,7 +320,7 @@ Vport Creation: | |||
320 | This is equivalent to a driver "attach" on an adapter, which is | 320 | This is equivalent to a driver "attach" on an adapter, which is |
321 | independent of the adapter's link state. | 321 | independent of the adapter's link state. |
322 | - Instantiation of the vport on the FC link via ELS traffic, etc. | 322 | - Instantiation of the vport on the FC link via ELS traffic, etc. |
323 | This is equivalent to a "link up" and successfull link initialization. | 323 | This is equivalent to a "link up" and successful link initialization. |
324 | 324 | ||
325 | The LLDD's vport_create() function will not synchronously wait for both | 325 | The LLDD's vport_create() function will not synchronously wait for both |
326 | parts to be fully completed before returning. It must validate that the | 326 | parts to be fully completed before returning. It must validate that the |
diff --git a/Documentation/w1/masters/00-INDEX b/Documentation/w1/masters/00-INDEX index 7b0ceaaad7af..d63fa024ac05 100644 --- a/Documentation/w1/masters/00-INDEX +++ b/Documentation/w1/masters/00-INDEX | |||
@@ -4,5 +4,7 @@ ds2482 | |||
4 | - The Maxim/Dallas Semiconductor DS2482 provides 1-wire busses. | 4 | - The Maxim/Dallas Semiconductor DS2482 provides 1-wire busses. |
5 | ds2490 | 5 | ds2490 |
6 | - The Maxim/Dallas Semiconductor DS2490 builds USB <-> W1 bridges. | 6 | - The Maxim/Dallas Semiconductor DS2490 builds USB <-> W1 bridges. |
7 | mxc_w1 | ||
8 | - W1 master controller driver found on Freescale MX2/MX3 SoCs | ||
7 | w1-gpio | 9 | w1-gpio |
8 | - GPIO 1-wire bus master driver. | 10 | - GPIO 1-wire bus master driver. |
diff --git a/Documentation/w1/masters/mxc-w1 b/Documentation/w1/masters/mxc-w1 new file mode 100644 index 000000000000..97f6199a7f39 --- /dev/null +++ b/Documentation/w1/masters/mxc-w1 | |||
@@ -0,0 +1,11 @@ | |||
1 | Kernel driver mxc_w1 | ||
2 | ==================== | ||
3 | |||
4 | Supported chips: | ||
5 | * Freescale MX27, MX31 and probably other i.MX SoCs | ||
6 | Datasheets: | ||
7 | http://www.freescale.com/files/32bit/doc/data_sheet/MCIMX31.pdf?fpsp=1 | ||
8 | http://www.freescale.com/files/dsp/MCIMX27.pdf?fpsp=1 | ||
9 | |||
10 | Author: Originally based on Freescale code, prepared for mainline by | ||
11 | Sascha Hauer <s.hauer@pengutronix.de> | ||
diff --git a/Documentation/w1/w1.netlink b/Documentation/w1/w1.netlink index 3640c7c87d45..804445f745ed 100644 --- a/Documentation/w1/w1.netlink +++ b/Documentation/w1/w1.netlink | |||
@@ -5,69 +5,157 @@ Message types. | |||
5 | ============= | 5 | ============= |
6 | 6 | ||
7 | There are three types of messages between w1 core and userspace: | 7 | There are three types of messages between w1 core and userspace: |
8 | 1. Events. They are generated each time new master or slave device found | 8 | 1. Events. They are generated each time new master or slave device |
9 | either due to automatic or requested search. | 9 | found either due to automatic or requested search. |
10 | 2. Userspace commands. Includes read/write and search/alarm search comamnds. | 10 | 2. Userspace commands. |
11 | 3. Replies to userspace commands. | 11 | 3. Replies to userspace commands. |
12 | 12 | ||
13 | 13 | ||
14 | Protocol. | 14 | Protocol. |
15 | ======== | 15 | ======== |
16 | 16 | ||
17 | [struct cn_msg] - connector header. It's length field is equal to size of the attached data. | 17 | [struct cn_msg] - connector header. |
18 | Its length field is equal to size of the attached data | ||
18 | [struct w1_netlink_msg] - w1 netlink header. | 19 | [struct w1_netlink_msg] - w1 netlink header. |
19 | __u8 type - message type. | 20 | __u8 type - message type. |
20 | W1_SLAVE_ADD/W1_SLAVE_REMOVE - slave add/remove events. | 21 | W1_LIST_MASTERS |
21 | W1_MASTER_ADD/W1_MASTER_REMOVE - master add/remove events. | 22 | list current bus masters |
22 | W1_MASTER_CMD - userspace command for bus master device (search/alarm search). | 23 | W1_SLAVE_ADD/W1_SLAVE_REMOVE |
23 | W1_SLAVE_CMD - userspace command for slave device (read/write/ search/alarm search | 24 | slave add/remove events |
24 | for bus master device where given slave device found). | 25 | W1_MASTER_ADD/W1_MASTER_REMOVE |
26 | master add/remove events | ||
27 | W1_MASTER_CMD | ||
28 | userspace command for bus master | ||
29 | device (search/alarm search) | ||
30 | W1_SLAVE_CMD | ||
31 | userspace command for slave device | ||
32 | (read/write/touch) | ||
25 | __u8 res - reserved | 33 | __u8 res - reserved |
26 | __u16 len - size of attached to this header data. | 34 | __u16 len - size of data attached to this header data |
27 | union { | 35 | union { |
28 | __u8 id; - slave unique device id | 36 | __u8 id[8]; - slave unique device id |
29 | struct w1_mst { | 37 | struct w1_mst { |
30 | __u32 id; - master's id. | 38 | __u32 id; - master's id |
31 | __u32 res; - reserved | 39 | __u32 res; - reserved |
32 | } mst; | 40 | } mst; |
33 | } id; | 41 | } id; |
34 | 42 | ||
35 | [strucrt w1_netlink_cmd] - command for gived master or slave device. | 43 | [struct w1_netlink_cmd] - command for given master or slave device. |
36 | __u8 cmd - command opcode. | 44 | __u8 cmd - command opcode. |
37 | W1_CMD_READ - read command. | 45 | W1_CMD_READ - read command |
38 | W1_CMD_WRITE - write command. | 46 | W1_CMD_WRITE - write command |
39 | W1_CMD_SEARCH - search command. | 47 | W1_CMD_TOUCH - touch command |
40 | W1_CMD_ALARM_SEARCH - alarm search command. | 48 | (write and sample data back to userspace) |
49 | W1_CMD_SEARCH - search command | ||
50 | W1_CMD_ALARM_SEARCH - alarm search command | ||
41 | __u8 res - reserved | 51 | __u8 res - reserved |
42 | __u16 len - length of data for this command. | 52 | __u16 len - length of data for this command |
43 | For read command data must be allocated like for write command. | 53 | For read command data must be allocated like for write command |
44 | __u8 data[0] - data for this command. | 54 | __u8 data[0] - data for this command |
45 | 55 | ||
46 | 56 | ||
47 | Each connector message can include one or more w1_netlink_msg with zero of more attached w1_netlink_cmd messages. | 57 | Each connector message can include one or more w1_netlink_msg with |
58 | zero or more attached w1_netlink_cmd messages. | ||
48 | 59 | ||
49 | For event messages there are no w1_netlink_cmd embedded structures, only connector header | 60 | For event messages there are no w1_netlink_cmd embedded structures, |
50 | and w1_netlink_msg strucutre with "len" field being zero and filled type (one of event types) | 61 | only connector header and w1_netlink_msg strucutre with "len" field |
51 | and id - either 8 bytes of slave unique id in host order, or master's id, which is assigned | 62 | being zero and filled type (one of event types) and id: |
52 | to bus master device when it is added to w1 core. | 63 | either 8 bytes of slave unique id in host order, |
64 | or master's id, which is assigned to bus master device | ||
65 | when it is added to w1 core. | ||
66 | |||
67 | Currently replies to userspace commands are only generated for read | ||
68 | command request. One reply is generated exactly for one w1_netlink_cmd | ||
69 | read request. Replies are not combined when sent - i.e. typical reply | ||
70 | messages looks like the following: | ||
53 | 71 | ||
54 | Currently replies to userspace commands are only generated for read command request. | ||
55 | One reply is generated exactly for one w1_netlink_cmd read request. | ||
56 | Replies are not combined when sent - i.e. typical reply messages looks like the following: | ||
57 | [cn_msg][w1_netlink_msg][w1_netlink_cmd] | 72 | [cn_msg][w1_netlink_msg][w1_netlink_cmd] |
58 | cn_msg.len = sizeof(struct w1_netlink_msg) + sizeof(struct w1_netlink_cmd) + cmd->len; | 73 | cn_msg.len = sizeof(struct w1_netlink_msg) + |
74 | sizeof(struct w1_netlink_cmd) + | ||
75 | cmd->len; | ||
59 | w1_netlink_msg.len = sizeof(struct w1_netlink_cmd) + cmd->len; | 76 | w1_netlink_msg.len = sizeof(struct w1_netlink_cmd) + cmd->len; |
60 | w1_netlink_cmd.len = cmd->len; | 77 | w1_netlink_cmd.len = cmd->len; |
61 | 78 | ||
79 | Replies to W1_LIST_MASTERS should send a message back to the userspace | ||
80 | which will contain list of all registered master ids in the following | ||
81 | format: | ||
82 | |||
83 | cn_msg (CN_W1_IDX.CN_W1_VAL as id, len is equal to sizeof(struct | ||
84 | w1_netlink_msg) plus number of masters multipled by 4) | ||
85 | w1_netlink_msg (type: W1_LIST_MASTERS, len is equal to | ||
86 | number of masters multiplied by 4 (u32 size)) | ||
87 | id0 ... idN | ||
88 | |||
89 | Each message is at most 4k in size, so if number of master devices | ||
90 | exceeds this, it will be split into several messages, | ||
91 | cn.seq will be increased for each one. | ||
92 | |||
93 | W1 search and alarm search commands. | ||
94 | request: | ||
95 | [cn_msg] | ||
96 | [w1_netlink_msg type = W1_MASTER_CMD | ||
97 | id is equal to the bus master id to use for searching] | ||
98 | [w1_netlink_cmd cmd = W1_CMD_SEARCH or W1_CMD_ALARM_SEARCH] | ||
99 | |||
100 | reply: | ||
101 | [cn_msg, ack = 1 and increasing, 0 means the last message, | ||
102 | seq is equal to the request seq] | ||
103 | [w1_netlink_msg type = W1_MASTER_CMD] | ||
104 | [w1_netlink_cmd cmd = W1_CMD_SEARCH or W1_CMD_ALARM_SEARCH | ||
105 | len is equal to number of IDs multiplied by 8] | ||
106 | [64bit-id0 ... 64bit-idN] | ||
107 | Length in each header corresponds to the size of the data behind it, so | ||
108 | w1_netlink_cmd->len = N * 8; where N is number of IDs in this message. | ||
109 | Can be zero. | ||
110 | w1_netlink_msg->len = sizeof(struct w1_netlink_cmd) + N * 8; | ||
111 | cn_msg->len = sizeof(struct w1_netlink_msg) + | ||
112 | sizeof(struct w1_netlink_cmd) + | ||
113 | N*8; | ||
114 | |||
115 | W1 reset command. | ||
116 | [cn_msg] | ||
117 | [w1_netlink_msg type = W1_MASTER_CMD | ||
118 | id is equal to the bus master id to use for searching] | ||
119 | [w1_netlink_cmd cmd = W1_CMD_RESET] | ||
120 | |||
121 | |||
122 | Command status replies. | ||
123 | ====================== | ||
124 | |||
125 | Each command (either root, master or slave with or without w1_netlink_cmd | ||
126 | structure) will be 'acked' by the w1 core. Format of the reply is the same | ||
127 | as request message except that length parameters do not account for data | ||
128 | requested by the user, i.e. read/write/touch IO requests will not contain | ||
129 | data, so w1_netlink_cmd.len will be 0, w1_netlink_msg.len will be size | ||
130 | of the w1_netlink_cmd structure and cn_msg.len will be equal to the sum | ||
131 | of the sizeof(struct w1_netlink_msg) and sizeof(struct w1_netlink_cmd). | ||
132 | If reply is generated for master or root command (which do not have | ||
133 | w1_netlink_cmd attached), reply will contain only cn_msg and w1_netlink_msg | ||
134 | structires. | ||
135 | |||
136 | w1_netlink_msg.status field will carry positive error value | ||
137 | (EINVAL for example) or zero in case of success. | ||
138 | |||
139 | All other fields in every structure will mirror the same parameters in the | ||
140 | request message (except lengths as described above). | ||
141 | |||
142 | Status reply is generated for every w1_netlink_cmd embedded in the | ||
143 | w1_netlink_msg, if there are no w1_netlink_cmd structures, | ||
144 | reply will be generated for the w1_netlink_msg. | ||
145 | |||
146 | All w1_netlink_cmd command structures are handled in every w1_netlink_msg, | ||
147 | even if there were errors, only length mismatch interrupts message processing. | ||
148 | |||
62 | 149 | ||
63 | Operation steps in w1 core when new command is received. | 150 | Operation steps in w1 core when new command is received. |
64 | ======================================================= | 151 | ======================================================= |
65 | 152 | ||
66 | When new message (w1_netlink_msg) is received w1 core detects if it is master of slave request, | 153 | When new message (w1_netlink_msg) is received w1 core detects if it is |
67 | according to w1_netlink_msg.type field. | 154 | master or slave request, according to w1_netlink_msg.type field. |
68 | Then master or slave device is searched for. | 155 | Then master or slave device is searched for. |
69 | When found, master device (requested or those one on where slave device is found) is locked. | 156 | When found, master device (requested or those one on where slave device |
70 | If slave command is requested, then reset/select procedure is started to select given device. | 157 | is found) is locked. If slave command is requested, then reset/select |
158 | procedure is started to select given device. | ||
71 | 159 | ||
72 | Then all requested in w1_netlink_msg operations are performed one by one. | 160 | Then all requested in w1_netlink_msg operations are performed one by one. |
73 | If command requires reply (like read command) it is sent on command completion. | 161 | If command requires reply (like read command) it is sent on command completion. |
@@ -82,8 +170,8 @@ Connector [1] specific documentation. | |||
82 | Each connector message includes two u32 fields as "address". | 170 | Each connector message includes two u32 fields as "address". |
83 | w1 uses CN_W1_IDX and CN_W1_VAL defined in include/linux/connector.h header. | 171 | w1 uses CN_W1_IDX and CN_W1_VAL defined in include/linux/connector.h header. |
84 | Each message also includes sequence and acknowledge numbers. | 172 | Each message also includes sequence and acknowledge numbers. |
85 | Sequence number for event messages is appropriate bus master sequence number increased with | 173 | Sequence number for event messages is appropriate bus master sequence number |
86 | each event message sent "through" this master. | 174 | increased with each event message sent "through" this master. |
87 | Sequence number for userspace requests is set by userspace application. | 175 | Sequence number for userspace requests is set by userspace application. |
88 | Sequence number for reply is the same as was in request, and | 176 | Sequence number for reply is the same as was in request, and |
89 | acknowledge number is set to seq+1. | 177 | acknowledge number is set to seq+1. |
@@ -93,6 +181,6 @@ Additional documantion, source code examples. | |||
93 | ============================================ | 181 | ============================================ |
94 | 182 | ||
95 | 1. Documentation/connector | 183 | 1. Documentation/connector |
96 | 2. http://tservice.net.ru/~s0mbre/archive/w1 | 184 | 2. http://www.ioremap.net/archive/w1 |
97 | This archive includes userspace application w1d.c which | 185 | This archive includes userspace application w1d.c which uses |
98 | uses read/write/search commands for all master/slave devices found on the bus. | 186 | read/write/search commands for all master/slave devices found on the bus. |
diff --git a/MAINTAINERS b/MAINTAINERS index 246878f41cf5..57e0309243cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS | |||
@@ -1360,6 +1360,11 @@ P: Maciej W. Rozycki | |||
1360 | M: macro@linux-mips.org | 1360 | M: macro@linux-mips.org |
1361 | S: Maintained | 1361 | S: Maintained |
1362 | 1362 | ||
1363 | DELL LAPTOP DRIVER | ||
1364 | P: Matthew Garrett | ||
1365 | M: mjg59@srcf.ucam.org | ||
1366 | S: Maintained | ||
1367 | |||
1363 | DELL LAPTOP SMM DRIVER | 1368 | DELL LAPTOP SMM DRIVER |
1364 | P: Massimo Dal Zotto | 1369 | P: Massimo Dal Zotto |
1365 | M: dz@debian.org | 1370 | M: dz@debian.org |
diff --git a/arch/powerpc/platforms/cell/spufs/spufs.h b/arch/powerpc/platforms/cell/spufs/spufs.h index 15c62d3ca129..3bf908e2873a 100644 --- a/arch/powerpc/platforms/cell/spufs/spufs.h +++ b/arch/powerpc/platforms/cell/spufs/spufs.h | |||
@@ -314,7 +314,7 @@ extern char *isolated_loader; | |||
314 | * we need to call spu_release(ctx) before sleeping, and | 314 | * we need to call spu_release(ctx) before sleeping, and |
315 | * then spu_acquire(ctx) when awoken. | 315 | * then spu_acquire(ctx) when awoken. |
316 | * | 316 | * |
317 | * Returns with state_mutex re-acquired when successfull or | 317 | * Returns with state_mutex re-acquired when successful or |
318 | * with -ERESTARTSYS and the state_mutex dropped when interrupted. | 318 | * with -ERESTARTSYS and the state_mutex dropped when interrupted. |
319 | */ | 319 | */ |
320 | 320 | ||
diff --git a/arch/sparc/kernel/sun4m_smp.c b/arch/sparc/kernel/sun4m_smp.c index 4f8d60586b07..8040376c4890 100644 --- a/arch/sparc/kernel/sun4m_smp.c +++ b/arch/sparc/kernel/sun4m_smp.c | |||
@@ -54,7 +54,8 @@ extern int __smp4m_processor_id(void); | |||
54 | #define SMP_PRINTK(x) | 54 | #define SMP_PRINTK(x) |
55 | #endif | 55 | #endif |
56 | 56 | ||
57 | static inline unsigned long swap(volatile unsigned long *ptr, unsigned long val) | 57 | static inline unsigned long |
58 | swap_ulong(volatile unsigned long *ptr, unsigned long val) | ||
58 | { | 59 | { |
59 | __asm__ __volatile__("swap [%1], %0\n\t" : | 60 | __asm__ __volatile__("swap [%1], %0\n\t" : |
60 | "=&r" (val), "=&r" (ptr) : | 61 | "=&r" (val), "=&r" (ptr) : |
@@ -90,7 +91,7 @@ void __cpuinit smp4m_callin(void) | |||
90 | * to call the scheduler code. | 91 | * to call the scheduler code. |
91 | */ | 92 | */ |
92 | /* Allow master to continue. */ | 93 | /* Allow master to continue. */ |
93 | swap(&cpu_callin_map[cpuid], 1); | 94 | swap_ulong(&cpu_callin_map[cpuid], 1); |
94 | 95 | ||
95 | /* XXX: What's up with all the flushes? */ | 96 | /* XXX: What's up with all the flushes? */ |
96 | local_flush_cache_all(); | 97 | local_flush_cache_all(); |
diff --git a/arch/x86/kernel/cpu/cpufreq/longhaul.c b/arch/x86/kernel/cpu/cpufreq/longhaul.c index b0461856acfb..a4cff5d6e380 100644 --- a/arch/x86/kernel/cpu/cpufreq/longhaul.c +++ b/arch/x86/kernel/cpu/cpufreq/longhaul.c | |||
@@ -982,7 +982,7 @@ static int __init longhaul_init(void) | |||
982 | case 10: | 982 | case 10: |
983 | printk(KERN_ERR PFX "Use acpi-cpufreq driver for VIA C7\n"); | 983 | printk(KERN_ERR PFX "Use acpi-cpufreq driver for VIA C7\n"); |
984 | default: | 984 | default: |
985 | ;; | 985 | ; |
986 | } | 986 | } |
987 | 987 | ||
988 | return -ENODEV; | 988 | return -ENODEV; |
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index 088885ed51b9..e1c7611e9144 100644 --- a/drivers/atm/iphase.c +++ b/drivers/atm/iphase.c | |||
@@ -64,7 +64,7 @@ | |||
64 | #include <linux/jiffies.h> | 64 | #include <linux/jiffies.h> |
65 | #include "iphase.h" | 65 | #include "iphase.h" |
66 | #include "suni.h" | 66 | #include "suni.h" |
67 | #define swap(x) (((x & 0xff) << 8) | ((x & 0xff00) >> 8)) | 67 | #define swap_byte_order(x) (((x & 0xff) << 8) | ((x & 0xff00) >> 8)) |
68 | 68 | ||
69 | #define PRIV(dev) ((struct suni_priv *) dev->phy_data) | 69 | #define PRIV(dev) ((struct suni_priv *) dev->phy_data) |
70 | 70 | ||
@@ -1306,7 +1306,7 @@ static void rx_dle_intr(struct atm_dev *dev) | |||
1306 | // get real pkt length pwang_test | 1306 | // get real pkt length pwang_test |
1307 | trailer = (struct cpcs_trailer*)((u_char *)skb->data + | 1307 | trailer = (struct cpcs_trailer*)((u_char *)skb->data + |
1308 | skb->len - sizeof(*trailer)); | 1308 | skb->len - sizeof(*trailer)); |
1309 | length = swap(trailer->length); | 1309 | length = swap_byte_order(trailer->length); |
1310 | if ((length > iadev->rx_buf_sz) || (length > | 1310 | if ((length > iadev->rx_buf_sz) || (length > |
1311 | (skb->len - sizeof(struct cpcs_trailer)))) | 1311 | (skb->len - sizeof(struct cpcs_trailer)))) |
1312 | { | 1312 | { |
@@ -2995,7 +2995,7 @@ static int ia_pkt_tx (struct atm_vcc *vcc, struct sk_buff *skb) { | |||
2995 | skb->len, PCI_DMA_TODEVICE); | 2995 | skb->len, PCI_DMA_TODEVICE); |
2996 | wr_ptr->local_pkt_addr = (buf_desc_ptr->buf_start_hi << 16) | | 2996 | wr_ptr->local_pkt_addr = (buf_desc_ptr->buf_start_hi << 16) | |
2997 | buf_desc_ptr->buf_start_lo; | 2997 | buf_desc_ptr->buf_start_lo; |
2998 | /* wr_ptr->bytes = swap(total_len); didn't seem to affect ?? */ | 2998 | /* wr_ptr->bytes = swap_byte_order(total_len); didn't seem to affect?? */ |
2999 | wr_ptr->bytes = skb->len; | 2999 | wr_ptr->bytes = skb->len; |
3000 | 3000 | ||
3001 | /* hw bug - DLEs of 0x2d, 0x2e, 0x2f cause DMA lockup */ | 3001 | /* hw bug - DLEs of 0x2d, 0x2e, 0x2f cause DMA lockup */ |
diff --git a/drivers/char/pty.c b/drivers/char/pty.c index 112a6ba9a96f..146c97613da0 100644 --- a/drivers/char/pty.c +++ b/drivers/char/pty.c | |||
@@ -32,7 +32,7 @@ | |||
32 | 32 | ||
33 | /* These are global because they are accessed in tty_io.c */ | 33 | /* These are global because they are accessed in tty_io.c */ |
34 | #ifdef CONFIG_UNIX98_PTYS | 34 | #ifdef CONFIG_UNIX98_PTYS |
35 | struct tty_driver *ptm_driver; | 35 | static struct tty_driver *ptm_driver; |
36 | static struct tty_driver *pts_driver; | 36 | static struct tty_driver *pts_driver; |
37 | #endif | 37 | #endif |
38 | 38 | ||
diff --git a/drivers/char/tpm/tpm_nsc.c b/drivers/char/tpm/tpm_nsc.c index ab18c1e7b115..70efba2ee053 100644 --- a/drivers/char/tpm/tpm_nsc.c +++ b/drivers/char/tpm/tpm_nsc.c | |||
@@ -273,12 +273,23 @@ static void tpm_nsc_remove(struct device *dev) | |||
273 | } | 273 | } |
274 | } | 274 | } |
275 | 275 | ||
276 | static struct device_driver nsc_drv = { | 276 | static int tpm_nsc_suspend(struct platform_device *dev, pm_message_t msg) |
277 | .name = "tpm_nsc", | 277 | { |
278 | .bus = &platform_bus_type, | 278 | return tpm_pm_suspend(&dev->dev, msg); |
279 | .owner = THIS_MODULE, | 279 | } |
280 | .suspend = tpm_pm_suspend, | 280 | |
281 | .resume = tpm_pm_resume, | 281 | static int tpm_nsc_resume(struct platform_device *dev) |
282 | { | ||
283 | return tpm_pm_resume(&dev->dev); | ||
284 | } | ||
285 | |||
286 | static struct platform_driver nsc_drv = { | ||
287 | .suspend = tpm_nsc_suspend, | ||
288 | .resume = tpm_nsc_resume, | ||
289 | .driver = { | ||
290 | .name = "tpm_nsc", | ||
291 | .owner = THIS_MODULE, | ||
292 | }, | ||
282 | }; | 293 | }; |
283 | 294 | ||
284 | static int __init init_nsc(void) | 295 | static int __init init_nsc(void) |
@@ -297,7 +308,7 @@ static int __init init_nsc(void) | |||
297 | return -ENODEV; | 308 | return -ENODEV; |
298 | } | 309 | } |
299 | 310 | ||
300 | err = driver_register(&nsc_drv); | 311 | err = platform_driver_register(&nsc_drv); |
301 | if (err) | 312 | if (err) |
302 | return err; | 313 | return err; |
303 | 314 | ||
@@ -308,17 +319,15 @@ static int __init init_nsc(void) | |||
308 | /* enable the DPM module */ | 319 | /* enable the DPM module */ |
309 | tpm_write_index(nscAddrBase, NSC_LDC_INDEX, 0x01); | 320 | tpm_write_index(nscAddrBase, NSC_LDC_INDEX, 0x01); |
310 | 321 | ||
311 | pdev = kzalloc(sizeof(struct platform_device), GFP_KERNEL); | 322 | pdev = platform_device_alloc("tpm_nscl0", -1); |
312 | if (!pdev) { | 323 | if (!pdev) { |
313 | rc = -ENOMEM; | 324 | rc = -ENOMEM; |
314 | goto err_unreg_drv; | 325 | goto err_unreg_drv; |
315 | } | 326 | } |
316 | 327 | ||
317 | pdev->name = "tpm_nscl0"; | ||
318 | pdev->id = -1; | ||
319 | pdev->num_resources = 0; | 328 | pdev->num_resources = 0; |
329 | pdev->dev.driver = &nsc_drv.driver; | ||
320 | pdev->dev.release = tpm_nsc_remove; | 330 | pdev->dev.release = tpm_nsc_remove; |
321 | pdev->dev.driver = &nsc_drv; | ||
322 | 331 | ||
323 | if ((rc = platform_device_register(pdev)) < 0) | 332 | if ((rc = platform_device_register(pdev)) < 0) |
324 | goto err_free_dev; | 333 | goto err_free_dev; |
@@ -377,7 +386,7 @@ err_unreg_dev: | |||
377 | err_free_dev: | 386 | err_free_dev: |
378 | kfree(pdev); | 387 | kfree(pdev); |
379 | err_unreg_drv: | 388 | err_unreg_drv: |
380 | driver_unregister(&nsc_drv); | 389 | platform_driver_unregister(&nsc_drv); |
381 | return rc; | 390 | return rc; |
382 | } | 391 | } |
383 | 392 | ||
@@ -390,7 +399,7 @@ static void __exit cleanup_nsc(void) | |||
390 | pdev = NULL; | 399 | pdev = NULL; |
391 | } | 400 | } |
392 | 401 | ||
393 | driver_unregister(&nsc_drv); | 402 | platform_driver_unregister(&nsc_drv); |
394 | } | 403 | } |
395 | 404 | ||
396 | module_init(init_nsc); | 405 | module_init(init_nsc); |
diff --git a/drivers/char/vt.c b/drivers/char/vt.c index 80014213fb53..7900bd63b36d 100644 --- a/drivers/char/vt.c +++ b/drivers/char/vt.c | |||
@@ -969,8 +969,7 @@ int vc_resize(struct vc_data *vc, unsigned int cols, unsigned int rows) | |||
969 | * Takes the console sem and the called methods then take the tty | 969 | * Takes the console sem and the called methods then take the tty |
970 | * termios_mutex and the tty ctrl_lock in that order. | 970 | * termios_mutex and the tty ctrl_lock in that order. |
971 | */ | 971 | */ |
972 | 972 | static int vt_resize(struct tty_struct *tty, struct winsize *ws) | |
973 | int vt_resize(struct tty_struct *tty, struct winsize *ws) | ||
974 | { | 973 | { |
975 | struct vc_data *vc = tty->driver_data; | 974 | struct vc_data *vc = tty->driver_data; |
976 | int ret; | 975 | int ret; |
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c index 50a071f1c945..777fba48d2d3 100644 --- a/drivers/firmware/dcdbas.c +++ b/drivers/firmware/dcdbas.c | |||
@@ -238,11 +238,11 @@ static ssize_t host_control_on_shutdown_store(struct device *dev, | |||
238 | } | 238 | } |
239 | 239 | ||
240 | /** | 240 | /** |
241 | * smi_request: generate SMI request | 241 | * dcdbas_smi_request: generate SMI request |
242 | * | 242 | * |
243 | * Called with smi_data_lock. | 243 | * Called with smi_data_lock. |
244 | */ | 244 | */ |
245 | static int smi_request(struct smi_cmd *smi_cmd) | 245 | int dcdbas_smi_request(struct smi_cmd *smi_cmd) |
246 | { | 246 | { |
247 | cpumask_t old_mask; | 247 | cpumask_t old_mask; |
248 | int ret = 0; | 248 | int ret = 0; |
@@ -309,14 +309,14 @@ static ssize_t smi_request_store(struct device *dev, | |||
309 | switch (val) { | 309 | switch (val) { |
310 | case 2: | 310 | case 2: |
311 | /* Raw SMI */ | 311 | /* Raw SMI */ |
312 | ret = smi_request(smi_cmd); | 312 | ret = dcdbas_smi_request(smi_cmd); |
313 | if (!ret) | 313 | if (!ret) |
314 | ret = count; | 314 | ret = count; |
315 | break; | 315 | break; |
316 | case 1: | 316 | case 1: |
317 | /* Calling Interface SMI */ | 317 | /* Calling Interface SMI */ |
318 | smi_cmd->ebx = (u32) virt_to_phys(smi_cmd->command_buffer); | 318 | smi_cmd->ebx = (u32) virt_to_phys(smi_cmd->command_buffer); |
319 | ret = smi_request(smi_cmd); | 319 | ret = dcdbas_smi_request(smi_cmd); |
320 | if (!ret) | 320 | if (!ret) |
321 | ret = count; | 321 | ret = count; |
322 | break; | 322 | break; |
@@ -333,6 +333,7 @@ out: | |||
333 | mutex_unlock(&smi_data_lock); | 333 | mutex_unlock(&smi_data_lock); |
334 | return ret; | 334 | return ret; |
335 | } | 335 | } |
336 | EXPORT_SYMBOL(dcdbas_smi_request); | ||
336 | 337 | ||
337 | /** | 338 | /** |
338 | * host_control_smi: generate host control SMI | 339 | * host_control_smi: generate host control SMI |
diff --git a/drivers/firmware/dcdbas.h b/drivers/firmware/dcdbas.h index 87bc3417de27..ca3cb0a54ab6 100644 --- a/drivers/firmware/dcdbas.h +++ b/drivers/firmware/dcdbas.h | |||
@@ -101,5 +101,7 @@ struct apm_cmd { | |||
101 | } __attribute__ ((packed)) parameters; | 101 | } __attribute__ ((packed)) parameters; |
102 | } __attribute__ ((packed)); | 102 | } __attribute__ ((packed)); |
103 | 103 | ||
104 | int dcdbas_smi_request(struct smi_cmd *smi_cmd); | ||
105 | |||
104 | #endif /* _DCDBAS_H_ */ | 106 | #endif /* _DCDBAS_H_ */ |
105 | 107 | ||
diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c index 3bf8ee120d42..261b9aa3f248 100644 --- a/drivers/firmware/memmap.c +++ b/drivers/firmware/memmap.c | |||
@@ -56,9 +56,9 @@ struct memmap_attribute { | |||
56 | ssize_t (*show)(struct firmware_map_entry *entry, char *buf); | 56 | ssize_t (*show)(struct firmware_map_entry *entry, char *buf); |
57 | }; | 57 | }; |
58 | 58 | ||
59 | struct memmap_attribute memmap_start_attr = __ATTR_RO(start); | 59 | static struct memmap_attribute memmap_start_attr = __ATTR_RO(start); |
60 | struct memmap_attribute memmap_end_attr = __ATTR_RO(end); | 60 | static struct memmap_attribute memmap_end_attr = __ATTR_RO(end); |
61 | struct memmap_attribute memmap_type_attr = __ATTR_RO(type); | 61 | static struct memmap_attribute memmap_type_attr = __ATTR_RO(type); |
62 | 62 | ||
63 | /* | 63 | /* |
64 | * These are default attributes that are added for every memmap entry. | 64 | * These are default attributes that are added for every memmap entry. |
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index a812db243477..6ba57e91d7ab 100644 --- a/drivers/infiniband/hw/nes/nes_cm.c +++ b/drivers/infiniband/hw/nes/nes_cm.c | |||
@@ -2705,7 +2705,7 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) | |||
2705 | sizeof(struct ietf_mpa_frame)); | 2705 | sizeof(struct ietf_mpa_frame)); |
2706 | 2706 | ||
2707 | 2707 | ||
2708 | /* notify OF layer that accept event was successfull */ | 2708 | /* notify OF layer that accept event was successful */ |
2709 | cm_id->add_ref(cm_id); | 2709 | cm_id->add_ref(cm_id); |
2710 | 2710 | ||
2711 | cm_event.event = IW_CM_EVENT_ESTABLISHED; | 2711 | cm_event.event = IW_CM_EVENT_ESTABLISHED; |
diff --git a/drivers/isdn/hardware/eicon/debuglib.h b/drivers/isdn/hardware/eicon/debuglib.h index 016410cf2273..8ea587783e14 100644 --- a/drivers/isdn/hardware/eicon/debuglib.h +++ b/drivers/isdn/hardware/eicon/debuglib.h | |||
@@ -235,7 +235,7 @@ typedef void ( * DbgOld) (unsigned short, char *, va_list) ; | |||
235 | typedef void ( * DbgEv) (unsigned short, unsigned long, va_list) ; | 235 | typedef void ( * DbgEv) (unsigned short, unsigned long, va_list) ; |
236 | typedef void ( * DbgIrq) (unsigned short, int, char *, va_list) ; | 236 | typedef void ( * DbgIrq) (unsigned short, int, char *, va_list) ; |
237 | typedef struct _DbgHandle_ | 237 | typedef struct _DbgHandle_ |
238 | { char Registered ; /* driver successfull registered */ | 238 | { char Registered ; /* driver successfully registered */ |
239 | #define DBG_HANDLE_REG_NEW 0x01 /* this (new) structure */ | 239 | #define DBG_HANDLE_REG_NEW 0x01 /* this (new) structure */ |
240 | #define DBG_HANDLE_REG_OLD 0x7f /* old structure (see below) */ | 240 | #define DBG_HANDLE_REG_OLD 0x7f /* old structure (see below) */ |
241 | char Version; /* version of this structure */ | 241 | char Version; /* version of this structure */ |
diff --git a/drivers/isdn/hardware/eicon/os_4bri.c b/drivers/isdn/hardware/eicon/os_4bri.c index 7b4ec3f60dbf..c964b8d91ada 100644 --- a/drivers/isdn/hardware/eicon/os_4bri.c +++ b/drivers/isdn/hardware/eicon/os_4bri.c | |||
@@ -997,7 +997,7 @@ diva_4bri_start_adapter(PISDN_ADAPTER IoAdapter, | |||
997 | diva_xdi_display_adapter_features(IoAdapter->ANum); | 997 | diva_xdi_display_adapter_features(IoAdapter->ANum); |
998 | 998 | ||
999 | for (i = 0; i < IoAdapter->tasks; i++) { | 999 | for (i = 0; i < IoAdapter->tasks; i++) { |
1000 | DBG_LOG(("A(%d) %s adapter successfull started", | 1000 | DBG_LOG(("A(%d) %s adapter successfully started", |
1001 | IoAdapter->QuadroList->QuadroAdapter[i]->ANum, | 1001 | IoAdapter->QuadroList->QuadroAdapter[i]->ANum, |
1002 | (IoAdapter->tasks == 1) ? "BRI 2.0" : "4BRI")) | 1002 | (IoAdapter->tasks == 1) ? "BRI 2.0" : "4BRI")) |
1003 | diva_xdi_didd_register_adapter(IoAdapter->QuadroList->QuadroAdapter[i]->ANum); | 1003 | diva_xdi_didd_register_adapter(IoAdapter->QuadroList->QuadroAdapter[i]->ANum); |
diff --git a/drivers/isdn/hardware/eicon/os_bri.c b/drivers/isdn/hardware/eicon/os_bri.c index f31bba5b16ff..08f01993f46b 100644 --- a/drivers/isdn/hardware/eicon/os_bri.c +++ b/drivers/isdn/hardware/eicon/os_bri.c | |||
@@ -736,7 +736,7 @@ diva_bri_start_adapter(PISDN_ADAPTER IoAdapter, | |||
736 | 736 | ||
737 | IoAdapter->Properties.Features = (word) features; | 737 | IoAdapter->Properties.Features = (word) features; |
738 | diva_xdi_display_adapter_features(IoAdapter->ANum); | 738 | diva_xdi_display_adapter_features(IoAdapter->ANum); |
739 | DBG_LOG(("A(%d) BRI adapter successfull started", IoAdapter->ANum)) | 739 | DBG_LOG(("A(%d) BRI adapter successfully started", IoAdapter->ANum)) |
740 | /* | 740 | /* |
741 | Register with DIDD | 741 | Register with DIDD |
742 | */ | 742 | */ |
diff --git a/drivers/isdn/hardware/eicon/os_pri.c b/drivers/isdn/hardware/eicon/os_pri.c index 903356547b79..5d65405c75f4 100644 --- a/drivers/isdn/hardware/eicon/os_pri.c +++ b/drivers/isdn/hardware/eicon/os_pri.c | |||
@@ -513,7 +513,7 @@ diva_pri_start_adapter(PISDN_ADAPTER IoAdapter, | |||
513 | 513 | ||
514 | diva_xdi_display_adapter_features(IoAdapter->ANum); | 514 | diva_xdi_display_adapter_features(IoAdapter->ANum); |
515 | 515 | ||
516 | DBG_LOG(("A(%d) PRI adapter successfull started", IoAdapter->ANum)) | 516 | DBG_LOG(("A(%d) PRI adapter successfully started", IoAdapter->ANum)) |
517 | /* | 517 | /* |
518 | Register with DIDD | 518 | Register with DIDD |
519 | */ | 519 | */ |
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index fee7304102af..3949a1c73451 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig | |||
@@ -498,6 +498,18 @@ config SGI_GRU_DEBUG | |||
498 | This option enables addition debugging code for the SGI GRU driver. If | 498 | This option enables addition debugging code for the SGI GRU driver. If |
499 | you are unsure, say N. | 499 | you are unsure, say N. |
500 | 500 | ||
501 | config DELL_LAPTOP | ||
502 | tristate "Dell Laptop Extras (EXPERIMENTAL)" | ||
503 | depends on X86 | ||
504 | depends on DCDBAS | ||
505 | depends on EXPERIMENTAL | ||
506 | depends on BACKLIGHT_CLASS_DEVICE | ||
507 | depends on RFKILL | ||
508 | default n | ||
509 | ---help--- | ||
510 | This driver adds support for rfkill and backlight control to Dell | ||
511 | laptops. | ||
512 | |||
501 | source "drivers/misc/c2port/Kconfig" | 513 | source "drivers/misc/c2port/Kconfig" |
502 | 514 | ||
503 | endif # MISC_DEVICES | 515 | endif # MISC_DEVICES |
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 817f7f5ab3bd..5de863a0e395 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile | |||
@@ -18,6 +18,7 @@ obj-$(CONFIG_ICS932S401) += ics932s401.o | |||
18 | obj-$(CONFIG_TC1100_WMI) += tc1100-wmi.o | 18 | obj-$(CONFIG_TC1100_WMI) += tc1100-wmi.o |
19 | obj-$(CONFIG_LKDTM) += lkdtm.o | 19 | obj-$(CONFIG_LKDTM) += lkdtm.o |
20 | obj-$(CONFIG_TIFM_CORE) += tifm_core.o | 20 | obj-$(CONFIG_TIFM_CORE) += tifm_core.o |
21 | obj-$(CONFIG_DELL_LAPTOP) += dell-laptop.o | ||
21 | obj-$(CONFIG_TIFM_7XX1) += tifm_7xx1.o | 22 | obj-$(CONFIG_TIFM_7XX1) += tifm_7xx1.o |
22 | obj-$(CONFIG_PHANTOM) += phantom.o | 23 | obj-$(CONFIG_PHANTOM) += phantom.o |
23 | obj-$(CONFIG_SGI_IOC4) += ioc4.o | 24 | obj-$(CONFIG_SGI_IOC4) += ioc4.o |
diff --git a/drivers/misc/dell-laptop.c b/drivers/misc/dell-laptop.c new file mode 100644 index 000000000000..4d33a2068b7a --- /dev/null +++ b/drivers/misc/dell-laptop.c | |||
@@ -0,0 +1,436 @@ | |||
1 | /* | ||
2 | * Driver for Dell laptop extras | ||
3 | * | ||
4 | * Copyright (c) Red Hat <mjg@redhat.com> | ||
5 | * | ||
6 | * Based on documentation in the libsmbios package, Copyright (C) 2005 Dell | ||
7 | * Inc. | ||
8 | * | ||
9 | * This program is free software; you can redistribute it and/or modify | ||
10 | * it under the terms of the GNU General Public License version 2 as | ||
11 | * published by the Free Software Foundation. | ||
12 | */ | ||
13 | |||
14 | #include <linux/module.h> | ||
15 | #include <linux/kernel.h> | ||
16 | #include <linux/init.h> | ||
17 | #include <linux/platform_device.h> | ||
18 | #include <linux/backlight.h> | ||
19 | #include <linux/err.h> | ||
20 | #include <linux/dmi.h> | ||
21 | #include <linux/io.h> | ||
22 | #include <linux/rfkill.h> | ||
23 | #include <linux/power_supply.h> | ||
24 | #include <linux/acpi.h> | ||
25 | #include "../firmware/dcdbas.h" | ||
26 | |||
27 | #define BRIGHTNESS_TOKEN 0x7d | ||
28 | |||
29 | /* This structure will be modified by the firmware when we enter | ||
30 | * system management mode, hence the volatiles */ | ||
31 | |||
32 | struct calling_interface_buffer { | ||
33 | u16 class; | ||
34 | u16 select; | ||
35 | volatile u32 input[4]; | ||
36 | volatile u32 output[4]; | ||
37 | } __packed; | ||
38 | |||
39 | struct calling_interface_token { | ||
40 | u16 tokenID; | ||
41 | u16 location; | ||
42 | union { | ||
43 | u16 value; | ||
44 | u16 stringlength; | ||
45 | }; | ||
46 | }; | ||
47 | |||
48 | struct calling_interface_structure { | ||
49 | struct dmi_header header; | ||
50 | u16 cmdIOAddress; | ||
51 | u8 cmdIOCode; | ||
52 | u32 supportedCmds; | ||
53 | struct calling_interface_token tokens[]; | ||
54 | } __packed; | ||
55 | |||
56 | static int da_command_address; | ||
57 | static int da_command_code; | ||
58 | static int da_num_tokens; | ||
59 | static struct calling_interface_token *da_tokens; | ||
60 | |||
61 | static struct backlight_device *dell_backlight_device; | ||
62 | static struct rfkill *wifi_rfkill; | ||
63 | static struct rfkill *bluetooth_rfkill; | ||
64 | static struct rfkill *wwan_rfkill; | ||
65 | |||
66 | static const struct dmi_system_id __initdata dell_device_table[] = { | ||
67 | { | ||
68 | .ident = "Dell laptop", | ||
69 | .matches = { | ||
70 | DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), | ||
71 | DMI_MATCH(DMI_CHASSIS_TYPE, "8"), | ||
72 | }, | ||
73 | }, | ||
74 | { } | ||
75 | }; | ||
76 | |||
77 | static void parse_da_table(const struct dmi_header *dm) | ||
78 | { | ||
79 | /* Final token is a terminator, so we don't want to copy it */ | ||
80 | int tokens = (dm->length-11)/sizeof(struct calling_interface_token)-1; | ||
81 | struct calling_interface_structure *table = | ||
82 | container_of(dm, struct calling_interface_structure, header); | ||
83 | |||
84 | /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least | ||
85 | 6 bytes of entry */ | ||
86 | |||
87 | if (dm->length < 17) | ||
88 | return; | ||
89 | |||
90 | da_command_address = table->cmdIOAddress; | ||
91 | da_command_code = table->cmdIOCode; | ||
92 | |||
93 | da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) * | ||
94 | sizeof(struct calling_interface_token), | ||
95 | GFP_KERNEL); | ||
96 | |||
97 | if (!da_tokens) | ||
98 | return; | ||
99 | |||
100 | memcpy(da_tokens+da_num_tokens, table->tokens, | ||
101 | sizeof(struct calling_interface_token) * tokens); | ||
102 | |||
103 | da_num_tokens += tokens; | ||
104 | } | ||
105 | |||
106 | static void find_tokens(const struct dmi_header *dm) | ||
107 | { | ||
108 | switch (dm->type) { | ||
109 | case 0xd4: /* Indexed IO */ | ||
110 | break; | ||
111 | case 0xd5: /* Protected Area Type 1 */ | ||
112 | break; | ||
113 | case 0xd6: /* Protected Area Type 2 */ | ||
114 | break; | ||
115 | case 0xda: /* Calling interface */ | ||
116 | parse_da_table(dm); | ||
117 | break; | ||
118 | } | ||
119 | } | ||
120 | |||
121 | static int find_token_location(int tokenid) | ||
122 | { | ||
123 | int i; | ||
124 | for (i = 0; i < da_num_tokens; i++) { | ||
125 | if (da_tokens[i].tokenID == tokenid) | ||
126 | return da_tokens[i].location; | ||
127 | } | ||
128 | |||
129 | return -1; | ||
130 | } | ||
131 | |||
132 | static struct calling_interface_buffer * | ||
133 | dell_send_request(struct calling_interface_buffer *buffer, int class, | ||
134 | int select) | ||
135 | { | ||
136 | struct smi_cmd command; | ||
137 | |||
138 | command.magic = SMI_CMD_MAGIC; | ||
139 | command.command_address = da_command_address; | ||
140 | command.command_code = da_command_code; | ||
141 | command.ebx = virt_to_phys(buffer); | ||
142 | command.ecx = 0x42534931; | ||
143 | |||
144 | buffer->class = class; | ||
145 | buffer->select = select; | ||
146 | |||
147 | dcdbas_smi_request(&command); | ||
148 | |||
149 | return buffer; | ||
150 | } | ||
151 | |||
152 | /* Derived from information in DellWirelessCtl.cpp: | ||
153 | Class 17, select 11 is radio control. It returns an array of 32-bit values. | ||
154 | |||
155 | result[0]: return code | ||
156 | result[1]: | ||
157 | Bit 0: Hardware switch supported | ||
158 | Bit 1: Wifi locator supported | ||
159 | Bit 2: Wifi is supported | ||
160 | Bit 3: Bluetooth is supported | ||
161 | Bit 4: WWAN is supported | ||
162 | Bit 5: Wireless keyboard supported | ||
163 | Bits 6-7: Reserved | ||
164 | Bit 8: Wifi is installed | ||
165 | Bit 9: Bluetooth is installed | ||
166 | Bit 10: WWAN is installed | ||
167 | Bits 11-15: Reserved | ||
168 | Bit 16: Hardware switch is on | ||
169 | Bit 17: Wifi is blocked | ||
170 | Bit 18: Bluetooth is blocked | ||
171 | Bit 19: WWAN is blocked | ||
172 | Bits 20-31: Reserved | ||
173 | result[2]: NVRAM size in bytes | ||
174 | result[3]: NVRAM format version number | ||
175 | */ | ||
176 | |||
177 | static int dell_rfkill_set(int radio, enum rfkill_state state) | ||
178 | { | ||
179 | struct calling_interface_buffer buffer; | ||
180 | int disable = (state == RFKILL_STATE_UNBLOCKED) ? 0 : 1; | ||
181 | |||
182 | memset(&buffer, 0, sizeof(struct calling_interface_buffer)); | ||
183 | buffer.input[0] = (1 | (radio<<8) | (disable << 16)); | ||
184 | dell_send_request(&buffer, 17, 11); | ||
185 | |||
186 | return 0; | ||
187 | } | ||
188 | |||
189 | static int dell_wifi_set(void *data, enum rfkill_state state) | ||
190 | { | ||
191 | return dell_rfkill_set(1, state); | ||
192 | } | ||
193 | |||
194 | static int dell_bluetooth_set(void *data, enum rfkill_state state) | ||
195 | { | ||
196 | return dell_rfkill_set(2, state); | ||
197 | } | ||
198 | |||
199 | static int dell_wwan_set(void *data, enum rfkill_state state) | ||
200 | { | ||
201 | return dell_rfkill_set(3, state); | ||
202 | } | ||
203 | |||
204 | static int dell_rfkill_get(int bit, enum rfkill_state *state) | ||
205 | { | ||
206 | struct calling_interface_buffer buffer; | ||
207 | int status; | ||
208 | int new_state = RFKILL_STATE_HARD_BLOCKED; | ||
209 | |||
210 | memset(&buffer, 0, sizeof(struct calling_interface_buffer)); | ||
211 | dell_send_request(&buffer, 17, 11); | ||
212 | status = buffer.output[1]; | ||
213 | |||
214 | if (status & (1<<16)) | ||
215 | new_state = RFKILL_STATE_SOFT_BLOCKED; | ||
216 | |||
217 | if (status & (1<<bit)) | ||
218 | *state = new_state; | ||
219 | else | ||
220 | *state = RFKILL_STATE_UNBLOCKED; | ||
221 | |||
222 | return 0; | ||
223 | } | ||
224 | |||
225 | static int dell_wifi_get(void *data, enum rfkill_state *state) | ||
226 | { | ||
227 | return dell_rfkill_get(17, state); | ||
228 | } | ||
229 | |||
230 | static int dell_bluetooth_get(void *data, enum rfkill_state *state) | ||
231 | { | ||
232 | return dell_rfkill_get(18, state); | ||
233 | } | ||
234 | |||
235 | static int dell_wwan_get(void *data, enum rfkill_state *state) | ||
236 | { | ||
237 | return dell_rfkill_get(19, state); | ||
238 | } | ||
239 | |||
240 | static int dell_setup_rfkill(void) | ||
241 | { | ||
242 | struct calling_interface_buffer buffer; | ||
243 | int status; | ||
244 | int ret; | ||
245 | |||
246 | memset(&buffer, 0, sizeof(struct calling_interface_buffer)); | ||
247 | dell_send_request(&buffer, 17, 11); | ||
248 | status = buffer.output[1]; | ||
249 | |||
250 | if ((status & (1<<2|1<<8)) == (1<<2|1<<8)) { | ||
251 | wifi_rfkill = rfkill_allocate(NULL, RFKILL_TYPE_WLAN); | ||
252 | if (!wifi_rfkill) | ||
253 | goto err_wifi; | ||
254 | wifi_rfkill->name = "dell-wifi"; | ||
255 | wifi_rfkill->toggle_radio = dell_wifi_set; | ||
256 | wifi_rfkill->get_state = dell_wifi_get; | ||
257 | ret = rfkill_register(wifi_rfkill); | ||
258 | if (ret) | ||
259 | goto err_wifi; | ||
260 | } | ||
261 | |||
262 | if ((status & (1<<3|1<<9)) == (1<<3|1<<9)) { | ||
263 | bluetooth_rfkill = rfkill_allocate(NULL, RFKILL_TYPE_BLUETOOTH); | ||
264 | if (!bluetooth_rfkill) | ||
265 | goto err_bluetooth; | ||
266 | bluetooth_rfkill->name = "dell-bluetooth"; | ||
267 | bluetooth_rfkill->toggle_radio = dell_bluetooth_set; | ||
268 | bluetooth_rfkill->get_state = dell_bluetooth_get; | ||
269 | ret = rfkill_register(bluetooth_rfkill); | ||
270 | if (ret) | ||
271 | goto err_bluetooth; | ||
272 | } | ||
273 | |||
274 | if ((status & (1<<4|1<<10)) == (1<<4|1<<10)) { | ||
275 | wwan_rfkill = rfkill_allocate(NULL, RFKILL_TYPE_WWAN); | ||
276 | if (!wwan_rfkill) | ||
277 | goto err_wwan; | ||
278 | wwan_rfkill->name = "dell-wwan"; | ||
279 | wwan_rfkill->toggle_radio = dell_wwan_set; | ||
280 | wwan_rfkill->get_state = dell_wwan_get; | ||
281 | ret = rfkill_register(wwan_rfkill); | ||
282 | if (ret) | ||
283 | goto err_wwan; | ||
284 | } | ||
285 | |||
286 | return 0; | ||
287 | err_wwan: | ||
288 | if (wwan_rfkill) | ||
289 | rfkill_free(wwan_rfkill); | ||
290 | if (bluetooth_rfkill) { | ||
291 | rfkill_unregister(bluetooth_rfkill); | ||
292 | bluetooth_rfkill = NULL; | ||
293 | } | ||
294 | err_bluetooth: | ||
295 | if (bluetooth_rfkill) | ||
296 | rfkill_free(bluetooth_rfkill); | ||
297 | if (wifi_rfkill) { | ||
298 | rfkill_unregister(wifi_rfkill); | ||
299 | wifi_rfkill = NULL; | ||
300 | } | ||
301 | err_wifi: | ||
302 | if (wifi_rfkill) | ||
303 | rfkill_free(wifi_rfkill); | ||
304 | |||
305 | return ret; | ||
306 | } | ||
307 | |||
308 | static int dell_send_intensity(struct backlight_device *bd) | ||
309 | { | ||
310 | struct calling_interface_buffer buffer; | ||
311 | |||
312 | memset(&buffer, 0, sizeof(struct calling_interface_buffer)); | ||
313 | buffer.input[0] = find_token_location(BRIGHTNESS_TOKEN); | ||
314 | buffer.input[1] = bd->props.brightness; | ||
315 | |||
316 | if (buffer.input[0] == -1) | ||
317 | return -ENODEV; | ||
318 | |||
319 | if (power_supply_is_system_supplied() > 0) | ||
320 | dell_send_request(&buffer, 1, 2); | ||
321 | else | ||
322 | dell_send_request(&buffer, 1, 1); | ||
323 | |||
324 | return 0; | ||
325 | } | ||
326 | |||
327 | static int dell_get_intensity(struct backlight_device *bd) | ||
328 | { | ||
329 | struct calling_interface_buffer buffer; | ||
330 | |||
331 | memset(&buffer, 0, sizeof(struct calling_interface_buffer)); | ||
332 | buffer.input[0] = find_token_location(BRIGHTNESS_TOKEN); | ||
333 | |||
334 | if (buffer.input[0] == -1) | ||
335 | return -ENODEV; | ||
336 | |||
337 | if (power_supply_is_system_supplied() > 0) | ||
338 | dell_send_request(&buffer, 0, 2); | ||
339 | else | ||
340 | dell_send_request(&buffer, 0, 1); | ||
341 | |||
342 | return buffer.output[1]; | ||
343 | } | ||
344 | |||
345 | static struct backlight_ops dell_ops = { | ||
346 | .get_brightness = dell_get_intensity, | ||
347 | .update_status = dell_send_intensity, | ||
348 | }; | ||
349 | |||
350 | static int __init dell_init(void) | ||
351 | { | ||
352 | struct calling_interface_buffer buffer; | ||
353 | int max_intensity = 0; | ||
354 | int ret; | ||
355 | |||
356 | if (!dmi_check_system(dell_device_table)) | ||
357 | return -ENODEV; | ||
358 | |||
359 | dmi_walk(find_tokens); | ||
360 | |||
361 | if (!da_tokens) { | ||
362 | printk(KERN_INFO "dell-laptop: Unable to find dmi tokens\n"); | ||
363 | return -ENODEV; | ||
364 | } | ||
365 | |||
366 | ret = dell_setup_rfkill(); | ||
367 | |||
368 | if (ret) { | ||
369 | printk(KERN_WARNING "dell-laptop: Unable to setup rfkill\n"); | ||
370 | goto out; | ||
371 | } | ||
372 | |||
373 | #ifdef CONFIG_ACPI | ||
374 | /* In the event of an ACPI backlight being available, don't | ||
375 | * register the platform controller. | ||
376 | */ | ||
377 | if (acpi_video_backlight_support()) | ||
378 | return 0; | ||
379 | #endif | ||
380 | |||
381 | memset(&buffer, 0, sizeof(struct calling_interface_buffer)); | ||
382 | buffer.input[0] = find_token_location(BRIGHTNESS_TOKEN); | ||
383 | |||
384 | if (buffer.input[0] != -1) { | ||
385 | dell_send_request(&buffer, 0, 2); | ||
386 | max_intensity = buffer.output[3]; | ||
387 | } | ||
388 | |||
389 | if (max_intensity) { | ||
390 | dell_backlight_device = backlight_device_register( | ||
391 | "dell_backlight", | ||
392 | NULL, NULL, | ||
393 | &dell_ops); | ||
394 | |||
395 | if (IS_ERR(dell_backlight_device)) { | ||
396 | ret = PTR_ERR(dell_backlight_device); | ||
397 | dell_backlight_device = NULL; | ||
398 | goto out; | ||
399 | } | ||
400 | |||
401 | dell_backlight_device->props.max_brightness = max_intensity; | ||
402 | dell_backlight_device->props.brightness = | ||
403 | dell_get_intensity(dell_backlight_device); | ||
404 | backlight_update_status(dell_backlight_device); | ||
405 | } | ||
406 | |||
407 | return 0; | ||
408 | out: | ||
409 | if (wifi_rfkill) | ||
410 | rfkill_unregister(wifi_rfkill); | ||
411 | if (bluetooth_rfkill) | ||
412 | rfkill_unregister(bluetooth_rfkill); | ||
413 | if (wwan_rfkill) | ||
414 | rfkill_unregister(wwan_rfkill); | ||
415 | kfree(da_tokens); | ||
416 | return ret; | ||
417 | } | ||
418 | |||
419 | static void __exit dell_exit(void) | ||
420 | { | ||
421 | backlight_device_unregister(dell_backlight_device); | ||
422 | if (wifi_rfkill) | ||
423 | rfkill_unregister(wifi_rfkill); | ||
424 | if (bluetooth_rfkill) | ||
425 | rfkill_unregister(bluetooth_rfkill); | ||
426 | if (wwan_rfkill) | ||
427 | rfkill_unregister(wwan_rfkill); | ||
428 | } | ||
429 | |||
430 | module_init(dell_init); | ||
431 | module_exit(dell_exit); | ||
432 | |||
433 | MODULE_AUTHOR("Matthew Garrett <mjg@redhat.com>"); | ||
434 | MODULE_DESCRIPTION("Dell laptop driver"); | ||
435 | MODULE_LICENSE("GPL"); | ||
436 | MODULE_ALIAS("dmi:*svnDellInc.:*:ct8:*"); | ||
diff --git a/drivers/mtd/ubi/kapi.c b/drivers/mtd/ubi/kapi.c index 5d9bcf109c13..4abbe573fa40 100644 --- a/drivers/mtd/ubi/kapi.c +++ b/drivers/mtd/ubi/kapi.c | |||
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(ubi_leb_unmap); | |||
564 | * @dtype: expected data type | 564 | * @dtype: expected data type |
565 | * | 565 | * |
566 | * This function maps an un-mapped logical eraseblock @lnum to a physical | 566 | * This function maps an un-mapped logical eraseblock @lnum to a physical |
567 | * eraseblock. This means, that after a successfull invocation of this | 567 | * eraseblock. This means, that after a successful invocation of this |
568 | * function the logical eraseblock @lnum will be empty (contain only %0xFF | 568 | * function the logical eraseblock @lnum will be empty (contain only %0xFF |
569 | * bytes) and be mapped to a physical eraseblock, even if an unclean reboot | 569 | * bytes) and be mapped to a physical eraseblock, even if an unclean reboot |
570 | * happens. | 570 | * happens. |
diff --git a/drivers/net/wireless/ath5k/dma.c b/drivers/net/wireless/ath5k/dma.c index 7e2b1a67e5da..b65b4feb2d28 100644 --- a/drivers/net/wireless/ath5k/dma.c +++ b/drivers/net/wireless/ath5k/dma.c | |||
@@ -594,7 +594,7 @@ int ath5k_hw_get_isr(struct ath5k_hw *ah, enum ath5k_int *interrupt_mask) | |||
594 | * XXX: BMISS interrupts may occur after association. | 594 | * XXX: BMISS interrupts may occur after association. |
595 | * I found this on 5210 code but it needs testing. If this is | 595 | * I found this on 5210 code but it needs testing. If this is |
596 | * true we should disable them before assoc and re-enable them | 596 | * true we should disable them before assoc and re-enable them |
597 | * after a successfull assoc + some jiffies. | 597 | * after a successful assoc + some jiffies. |
598 | interrupt_mask &= ~AR5K_INT_BMISS; | 598 | interrupt_mask &= ~AR5K_INT_BMISS; |
599 | */ | 599 | */ |
600 | } | 600 | } |
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c index 9caa96a13586..a611ad857983 100644 --- a/drivers/net/wireless/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zd1211rw/zd_mac.c | |||
@@ -287,7 +287,7 @@ static void zd_op_stop(struct ieee80211_hw *hw) | |||
287 | * @skb - a sk-buffer | 287 | * @skb - a sk-buffer |
288 | * @flags: extra flags to set in the TX status info | 288 | * @flags: extra flags to set in the TX status info |
289 | * @ackssi: ACK signal strength | 289 | * @ackssi: ACK signal strength |
290 | * @success - True for successfull transmission of the frame | 290 | * @success - True for successful transmission of the frame |
291 | * | 291 | * |
292 | * This information calls ieee80211_tx_status_irqsafe() if required by the | 292 | * This information calls ieee80211_tx_status_irqsafe() if required by the |
293 | * control information. It copies the control information into the status | 293 | * control information. It copies the control information into the status |
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 162330b9d1dc..7e5155e88ac7 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c | |||
@@ -86,13 +86,11 @@ enum ds_type { | |||
86 | 86 | ||
87 | 87 | ||
88 | struct ds1307 { | 88 | struct ds1307 { |
89 | u8 reg_addr; | ||
90 | u8 regs[11]; | 89 | u8 regs[11]; |
91 | enum ds_type type; | 90 | enum ds_type type; |
92 | unsigned long flags; | 91 | unsigned long flags; |
93 | #define HAS_NVRAM 0 /* bit 0 == sysfs file active */ | 92 | #define HAS_NVRAM 0 /* bit 0 == sysfs file active */ |
94 | #define HAS_ALARM 1 /* bit 1 == irq claimed */ | 93 | #define HAS_ALARM 1 /* bit 1 == irq claimed */ |
95 | struct i2c_msg msg[2]; | ||
96 | struct i2c_client *client; | 94 | struct i2c_client *client; |
97 | struct rtc_device *rtc; | 95 | struct rtc_device *rtc; |
98 | struct work_struct work; | 96 | struct work_struct work; |
@@ -204,13 +202,9 @@ static int ds1307_get_time(struct device *dev, struct rtc_time *t) | |||
204 | int tmp; | 202 | int tmp; |
205 | 203 | ||
206 | /* read the RTC date and time registers all at once */ | 204 | /* read the RTC date and time registers all at once */ |
207 | ds1307->reg_addr = 0; | 205 | tmp = i2c_smbus_read_i2c_block_data(ds1307->client, |
208 | ds1307->msg[1].flags = I2C_M_RD; | 206 | DS1307_REG_SECS, 7, ds1307->regs); |
209 | ds1307->msg[1].len = 7; | 207 | if (tmp != 7) { |
210 | |||
211 | tmp = i2c_transfer(to_i2c_adapter(ds1307->client->dev.parent), | ||
212 | ds1307->msg, 2); | ||
213 | if (tmp != 2) { | ||
214 | dev_err(dev, "%s error %d\n", "read", tmp); | 208 | dev_err(dev, "%s error %d\n", "read", tmp); |
215 | return -EIO; | 209 | return -EIO; |
216 | } | 210 | } |
@@ -257,7 +251,6 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t) | |||
257 | t->tm_hour, t->tm_mday, | 251 | t->tm_hour, t->tm_mday, |
258 | t->tm_mon, t->tm_year, t->tm_wday); | 252 | t->tm_mon, t->tm_year, t->tm_wday); |
259 | 253 | ||
260 | *buf++ = 0; /* first register addr */ | ||
261 | buf[DS1307_REG_SECS] = bin2bcd(t->tm_sec); | 254 | buf[DS1307_REG_SECS] = bin2bcd(t->tm_sec); |
262 | buf[DS1307_REG_MIN] = bin2bcd(t->tm_min); | 255 | buf[DS1307_REG_MIN] = bin2bcd(t->tm_min); |
263 | buf[DS1307_REG_HOUR] = bin2bcd(t->tm_hour); | 256 | buf[DS1307_REG_HOUR] = bin2bcd(t->tm_hour); |
@@ -282,23 +275,19 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t) | |||
282 | break; | 275 | break; |
283 | } | 276 | } |
284 | 277 | ||
285 | ds1307->msg[1].flags = 0; | ||
286 | ds1307->msg[1].len = 8; | ||
287 | |||
288 | dev_dbg(dev, "%s: %02x %02x %02x %02x %02x %02x %02x\n", | 278 | dev_dbg(dev, "%s: %02x %02x %02x %02x %02x %02x %02x\n", |
289 | "write", buf[0], buf[1], buf[2], buf[3], | 279 | "write", buf[0], buf[1], buf[2], buf[3], |
290 | buf[4], buf[5], buf[6]); | 280 | buf[4], buf[5], buf[6]); |
291 | 281 | ||
292 | result = i2c_transfer(to_i2c_adapter(ds1307->client->dev.parent), | 282 | result = i2c_smbus_write_i2c_block_data(ds1307->client, 0, 7, buf); |
293 | &ds1307->msg[1], 1); | 283 | if (result < 0) { |
294 | if (result != 1) { | 284 | dev_err(dev, "%s error %d\n", "write", result); |
295 | dev_err(dev, "%s error %d\n", "write", tmp); | 285 | return result; |
296 | return -EIO; | ||
297 | } | 286 | } |
298 | return 0; | 287 | return 0; |
299 | } | 288 | } |
300 | 289 | ||
301 | static int ds1307_read_alarm(struct device *dev, struct rtc_wkalrm *t) | 290 | static int ds1337_read_alarm(struct device *dev, struct rtc_wkalrm *t) |
302 | { | 291 | { |
303 | struct i2c_client *client = to_i2c_client(dev); | 292 | struct i2c_client *client = to_i2c_client(dev); |
304 | struct ds1307 *ds1307 = i2c_get_clientdata(client); | 293 | struct ds1307 *ds1307 = i2c_get_clientdata(client); |
@@ -308,13 +297,9 @@ static int ds1307_read_alarm(struct device *dev, struct rtc_wkalrm *t) | |||
308 | return -EINVAL; | 297 | return -EINVAL; |
309 | 298 | ||
310 | /* read all ALARM1, ALARM2, and status registers at once */ | 299 | /* read all ALARM1, ALARM2, and status registers at once */ |
311 | ds1307->reg_addr = DS1339_REG_ALARM1_SECS; | 300 | ret = i2c_smbus_read_i2c_block_data(client, |
312 | ds1307->msg[1].flags = I2C_M_RD; | 301 | DS1339_REG_ALARM1_SECS, 9, ds1307->regs); |
313 | ds1307->msg[1].len = 9; | 302 | if (ret != 9) { |
314 | |||
315 | ret = i2c_transfer(to_i2c_adapter(client->dev.parent), | ||
316 | ds1307->msg, 2); | ||
317 | if (ret != 2) { | ||
318 | dev_err(dev, "%s error %d\n", "alarm read", ret); | 303 | dev_err(dev, "%s error %d\n", "alarm read", ret); |
319 | return -EIO; | 304 | return -EIO; |
320 | } | 305 | } |
@@ -353,7 +338,7 @@ static int ds1307_read_alarm(struct device *dev, struct rtc_wkalrm *t) | |||
353 | return 0; | 338 | return 0; |
354 | } | 339 | } |
355 | 340 | ||
356 | static int ds1307_set_alarm(struct device *dev, struct rtc_wkalrm *t) | 341 | static int ds1337_set_alarm(struct device *dev, struct rtc_wkalrm *t) |
357 | { | 342 | { |
358 | struct i2c_client *client = to_i2c_client(dev); | 343 | struct i2c_client *client = to_i2c_client(dev); |
359 | struct ds1307 *ds1307 = i2c_get_clientdata(client); | 344 | struct ds1307 *ds1307 = i2c_get_clientdata(client); |
@@ -371,13 +356,9 @@ static int ds1307_set_alarm(struct device *dev, struct rtc_wkalrm *t) | |||
371 | t->enabled, t->pending); | 356 | t->enabled, t->pending); |
372 | 357 | ||
373 | /* read current status of both alarms and the chip */ | 358 | /* read current status of both alarms and the chip */ |
374 | ds1307->reg_addr = DS1339_REG_ALARM1_SECS; | 359 | ret = i2c_smbus_read_i2c_block_data(client, |
375 | ds1307->msg[1].flags = I2C_M_RD; | 360 | DS1339_REG_ALARM1_SECS, 9, buf); |
376 | ds1307->msg[1].len = 9; | 361 | if (ret != 9) { |
377 | |||
378 | ret = i2c_transfer(to_i2c_adapter(client->dev.parent), | ||
379 | ds1307->msg, 2); | ||
380 | if (ret != 2) { | ||
381 | dev_err(dev, "%s error %d\n", "alarm write", ret); | 362 | dev_err(dev, "%s error %d\n", "alarm write", ret); |
382 | return -EIO; | 363 | return -EIO; |
383 | } | 364 | } |
@@ -392,7 +373,6 @@ static int ds1307_set_alarm(struct device *dev, struct rtc_wkalrm *t) | |||
392 | ds1307->regs[6], control, status); | 373 | ds1307->regs[6], control, status); |
393 | 374 | ||
394 | /* set ALARM1, using 24 hour and day-of-month modes */ | 375 | /* set ALARM1, using 24 hour and day-of-month modes */ |
395 | *buf++ = DS1339_REG_ALARM1_SECS; /* first register addr */ | ||
396 | buf[0] = bin2bcd(t->time.tm_sec); | 376 | buf[0] = bin2bcd(t->time.tm_sec); |
397 | buf[1] = bin2bcd(t->time.tm_min); | 377 | buf[1] = bin2bcd(t->time.tm_min); |
398 | buf[2] = bin2bcd(t->time.tm_hour); | 378 | buf[2] = bin2bcd(t->time.tm_hour); |
@@ -411,14 +391,11 @@ static int ds1307_set_alarm(struct device *dev, struct rtc_wkalrm *t) | |||
411 | } | 391 | } |
412 | buf[8] = status & ~(DS1337_BIT_A1I | DS1337_BIT_A2I); | 392 | buf[8] = status & ~(DS1337_BIT_A1I | DS1337_BIT_A2I); |
413 | 393 | ||
414 | ds1307->msg[1].flags = 0; | 394 | ret = i2c_smbus_write_i2c_block_data(client, |
415 | ds1307->msg[1].len = 10; | 395 | DS1339_REG_ALARM1_SECS, 9, buf); |
416 | 396 | if (ret < 0) { | |
417 | ret = i2c_transfer(to_i2c_adapter(client->dev.parent), | ||
418 | &ds1307->msg[1], 1); | ||
419 | if (ret != 1) { | ||
420 | dev_err(dev, "can't set alarm time\n"); | 397 | dev_err(dev, "can't set alarm time\n"); |
421 | return -EIO; | 398 | return ret; |
422 | } | 399 | } |
423 | 400 | ||
424 | return 0; | 401 | return 0; |
@@ -475,8 +452,8 @@ static int ds1307_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) | |||
475 | static const struct rtc_class_ops ds13xx_rtc_ops = { | 452 | static const struct rtc_class_ops ds13xx_rtc_ops = { |
476 | .read_time = ds1307_get_time, | 453 | .read_time = ds1307_get_time, |
477 | .set_time = ds1307_set_time, | 454 | .set_time = ds1307_set_time, |
478 | .read_alarm = ds1307_read_alarm, | 455 | .read_alarm = ds1337_read_alarm, |
479 | .set_alarm = ds1307_set_alarm, | 456 | .set_alarm = ds1337_set_alarm, |
480 | .ioctl = ds1307_ioctl, | 457 | .ioctl = ds1307_ioctl, |
481 | }; | 458 | }; |
482 | 459 | ||
@@ -490,7 +467,6 @@ ds1307_nvram_read(struct kobject *kobj, struct bin_attribute *attr, | |||
490 | { | 467 | { |
491 | struct i2c_client *client; | 468 | struct i2c_client *client; |
492 | struct ds1307 *ds1307; | 469 | struct ds1307 *ds1307; |
493 | struct i2c_msg msg[2]; | ||
494 | int result; | 470 | int result; |
495 | 471 | ||
496 | client = kobj_to_i2c_client(kobj); | 472 | client = kobj_to_i2c_client(kobj); |
@@ -503,24 +479,10 @@ ds1307_nvram_read(struct kobject *kobj, struct bin_attribute *attr, | |||
503 | if (unlikely(!count)) | 479 | if (unlikely(!count)) |
504 | return count; | 480 | return count; |
505 | 481 | ||
506 | msg[0].addr = client->addr; | 482 | result = i2c_smbus_read_i2c_block_data(client, 8 + off, count, buf); |
507 | msg[0].flags = 0; | 483 | if (result < 0) |
508 | msg[0].len = 1; | ||
509 | msg[0].buf = buf; | ||
510 | |||
511 | buf[0] = 8 + off; | ||
512 | |||
513 | msg[1].addr = client->addr; | ||
514 | msg[1].flags = I2C_M_RD; | ||
515 | msg[1].len = count; | ||
516 | msg[1].buf = buf; | ||
517 | |||
518 | result = i2c_transfer(to_i2c_adapter(client->dev.parent), msg, 2); | ||
519 | if (result != 2) { | ||
520 | dev_err(&client->dev, "%s error %d\n", "nvram read", result); | 484 | dev_err(&client->dev, "%s error %d\n", "nvram read", result); |
521 | return -EIO; | 485 | return result; |
522 | } | ||
523 | return count; | ||
524 | } | 486 | } |
525 | 487 | ||
526 | static ssize_t | 488 | static ssize_t |
@@ -528,8 +490,7 @@ ds1307_nvram_write(struct kobject *kobj, struct bin_attribute *attr, | |||
528 | char *buf, loff_t off, size_t count) | 490 | char *buf, loff_t off, size_t count) |
529 | { | 491 | { |
530 | struct i2c_client *client; | 492 | struct i2c_client *client; |
531 | u8 buffer[NVRAM_SIZE + 1]; | 493 | int result; |
532 | int ret; | ||
533 | 494 | ||
534 | client = kobj_to_i2c_client(kobj); | 495 | client = kobj_to_i2c_client(kobj); |
535 | 496 | ||
@@ -540,11 +501,12 @@ ds1307_nvram_write(struct kobject *kobj, struct bin_attribute *attr, | |||
540 | if (unlikely(!count)) | 501 | if (unlikely(!count)) |
541 | return count; | 502 | return count; |
542 | 503 | ||
543 | buffer[0] = 8 + off; | 504 | result = i2c_smbus_write_i2c_block_data(client, 8 + off, count, buf); |
544 | memcpy(buffer + 1, buf, count); | 505 | if (result < 0) { |
545 | 506 | dev_err(&client->dev, "%s error %d\n", "nvram write", result); | |
546 | ret = i2c_master_send(client, buffer, count + 1); | 507 | return result; |
547 | return (ret < 0) ? ret : (ret - 1); | 508 | } |
509 | return count; | ||
548 | } | 510 | } |
549 | 511 | ||
550 | static struct bin_attribute nvram = { | 512 | static struct bin_attribute nvram = { |
@@ -571,9 +533,11 @@ static int __devinit ds1307_probe(struct i2c_client *client, | |||
571 | const struct chip_desc *chip = &chips[id->driver_data]; | 533 | const struct chip_desc *chip = &chips[id->driver_data]; |
572 | struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); | 534 | struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); |
573 | int want_irq = false; | 535 | int want_irq = false; |
536 | unsigned char *buf; | ||
574 | 537 | ||
575 | if (!i2c_check_functionality(adapter, | 538 | if (!i2c_check_functionality(adapter, |
576 | I2C_FUNC_I2C | I2C_FUNC_SMBUS_WRITE_BYTE_DATA)) | 539 | I2C_FUNC_SMBUS_WRITE_BYTE_DATA | |
540 | I2C_FUNC_SMBUS_I2C_BLOCK)) | ||
577 | return -EIO; | 541 | return -EIO; |
578 | 542 | ||
579 | if (!(ds1307 = kzalloc(sizeof(struct ds1307), GFP_KERNEL))) | 543 | if (!(ds1307 = kzalloc(sizeof(struct ds1307), GFP_KERNEL))) |
@@ -581,18 +545,8 @@ static int __devinit ds1307_probe(struct i2c_client *client, | |||
581 | 545 | ||
582 | ds1307->client = client; | 546 | ds1307->client = client; |
583 | i2c_set_clientdata(client, ds1307); | 547 | i2c_set_clientdata(client, ds1307); |
584 | |||
585 | ds1307->msg[0].addr = client->addr; | ||
586 | ds1307->msg[0].flags = 0; | ||
587 | ds1307->msg[0].len = 1; | ||
588 | ds1307->msg[0].buf = &ds1307->reg_addr; | ||
589 | |||
590 | ds1307->msg[1].addr = client->addr; | ||
591 | ds1307->msg[1].flags = I2C_M_RD; | ||
592 | ds1307->msg[1].len = sizeof(ds1307->regs); | ||
593 | ds1307->msg[1].buf = ds1307->regs; | ||
594 | |||
595 | ds1307->type = id->driver_data; | 548 | ds1307->type = id->driver_data; |
549 | buf = ds1307->regs; | ||
596 | 550 | ||
597 | switch (ds1307->type) { | 551 | switch (ds1307->type) { |
598 | case ds_1337: | 552 | case ds_1337: |
@@ -602,21 +556,15 @@ static int __devinit ds1307_probe(struct i2c_client *client, | |||
602 | INIT_WORK(&ds1307->work, ds1307_work); | 556 | INIT_WORK(&ds1307->work, ds1307_work); |
603 | want_irq = true; | 557 | want_irq = true; |
604 | } | 558 | } |
605 | |||
606 | ds1307->reg_addr = DS1337_REG_CONTROL; | ||
607 | ds1307->msg[1].len = 2; | ||
608 | |||
609 | /* get registers that the "rtc" read below won't read... */ | 559 | /* get registers that the "rtc" read below won't read... */ |
610 | tmp = i2c_transfer(adapter, ds1307->msg, 2); | 560 | tmp = i2c_smbus_read_i2c_block_data(ds1307->client, |
561 | DS1337_REG_CONTROL, 2, buf); | ||
611 | if (tmp != 2) { | 562 | if (tmp != 2) { |
612 | pr_debug("read error %d\n", tmp); | 563 | pr_debug("read error %d\n", tmp); |
613 | err = -EIO; | 564 | err = -EIO; |
614 | goto exit_free; | 565 | goto exit_free; |
615 | } | 566 | } |
616 | 567 | ||
617 | ds1307->reg_addr = 0; | ||
618 | ds1307->msg[1].len = sizeof(ds1307->regs); | ||
619 | |||
620 | /* oscillator off? turn it on, so clock can tick. */ | 568 | /* oscillator off? turn it on, so clock can tick. */ |
621 | if (ds1307->regs[0] & DS1337_BIT_nEOSC) | 569 | if (ds1307->regs[0] & DS1337_BIT_nEOSC) |
622 | ds1307->regs[0] &= ~DS1337_BIT_nEOSC; | 570 | ds1307->regs[0] &= ~DS1337_BIT_nEOSC; |
@@ -647,9 +595,8 @@ static int __devinit ds1307_probe(struct i2c_client *client, | |||
647 | 595 | ||
648 | read_rtc: | 596 | read_rtc: |
649 | /* read RTC registers */ | 597 | /* read RTC registers */ |
650 | 598 | tmp = i2c_smbus_read_i2c_block_data(ds1307->client, 0, 8, buf); | |
651 | tmp = i2c_transfer(adapter, ds1307->msg, 2); | 599 | if (tmp != 8) { |
652 | if (tmp != 2) { | ||
653 | pr_debug("read error %d\n", tmp); | 600 | pr_debug("read error %d\n", tmp); |
654 | err = -EIO; | 601 | err = -EIO; |
655 | goto exit_free; | 602 | goto exit_free; |
@@ -707,22 +654,6 @@ read_rtc: | |||
707 | break; | 654 | break; |
708 | } | 655 | } |
709 | 656 | ||
710 | tmp = ds1307->regs[DS1307_REG_SECS]; | ||
711 | tmp = bcd2bin(tmp & 0x7f); | ||
712 | if (tmp > 60) | ||
713 | goto exit_bad; | ||
714 | tmp = bcd2bin(ds1307->regs[DS1307_REG_MIN] & 0x7f); | ||
715 | if (tmp > 60) | ||
716 | goto exit_bad; | ||
717 | |||
718 | tmp = bcd2bin(ds1307->regs[DS1307_REG_MDAY] & 0x3f); | ||
719 | if (tmp == 0 || tmp > 31) | ||
720 | goto exit_bad; | ||
721 | |||
722 | tmp = bcd2bin(ds1307->regs[DS1307_REG_MONTH] & 0x1f); | ||
723 | if (tmp == 0 || tmp > 12) | ||
724 | goto exit_bad; | ||
725 | |||
726 | tmp = ds1307->regs[DS1307_REG_HOUR]; | 657 | tmp = ds1307->regs[DS1307_REG_HOUR]; |
727 | switch (ds1307->type) { | 658 | switch (ds1307->type) { |
728 | case ds_1340: | 659 | case ds_1340: |
@@ -779,13 +710,6 @@ read_rtc: | |||
779 | 710 | ||
780 | return 0; | 711 | return 0; |
781 | 712 | ||
782 | exit_bad: | ||
783 | dev_dbg(&client->dev, "%s: %02x %02x %02x %02x %02x %02x %02x\n", | ||
784 | "bogus register", | ||
785 | ds1307->regs[0], ds1307->regs[1], | ||
786 | ds1307->regs[2], ds1307->regs[3], | ||
787 | ds1307->regs[4], ds1307->regs[5], | ||
788 | ds1307->regs[6]); | ||
789 | exit_irq: | 713 | exit_irq: |
790 | if (ds1307->rtc) | 714 | if (ds1307->rtc) |
791 | rtc_device_unregister(ds1307->rtc); | 715 | rtc_device_unregister(ds1307->rtc); |
diff --git a/drivers/s390/block/dasd_3990_erp.c b/drivers/s390/block/dasd_3990_erp.c index b8f9c00633f3..d82aad5224f0 100644 --- a/drivers/s390/block/dasd_3990_erp.c +++ b/drivers/s390/block/dasd_3990_erp.c | |||
@@ -2621,7 +2621,7 @@ dasd_3990_erp_action(struct dasd_ccw_req * cqr) | |||
2621 | } | 2621 | } |
2622 | } | 2622 | } |
2623 | 2623 | ||
2624 | /* double-check if current erp/cqr was successfull */ | 2624 | /* double-check if current erp/cqr was successful */ |
2625 | if ((cqr->irb.scsw.cmd.cstat == 0x00) && | 2625 | if ((cqr->irb.scsw.cmd.cstat == 0x00) && |
2626 | (cqr->irb.scsw.cmd.dstat == | 2626 | (cqr->irb.scsw.cmd.dstat == |
2627 | (DEV_STAT_CHN_END | DEV_STAT_DEV_END))) { | 2627 | (DEV_STAT_CHN_END | DEV_STAT_DEV_END))) { |
diff --git a/drivers/s390/block/dasd_int.h b/drivers/s390/block/dasd_int.h index 05a14536c369..4a39084d9c95 100644 --- a/drivers/s390/block/dasd_int.h +++ b/drivers/s390/block/dasd_int.h | |||
@@ -199,7 +199,7 @@ struct dasd_ccw_req { | |||
199 | #define DASD_CQR_ERROR 0x82 /* request is completed with error */ | 199 | #define DASD_CQR_ERROR 0x82 /* request is completed with error */ |
200 | #define DASD_CQR_CLEAR_PENDING 0x83 /* request is clear pending */ | 200 | #define DASD_CQR_CLEAR_PENDING 0x83 /* request is clear pending */ |
201 | #define DASD_CQR_CLEARED 0x84 /* request was cleared */ | 201 | #define DASD_CQR_CLEARED 0x84 /* request was cleared */ |
202 | #define DASD_CQR_SUCCESS 0x85 /* request was successfull */ | 202 | #define DASD_CQR_SUCCESS 0x85 /* request was successful */ |
203 | 203 | ||
204 | 204 | ||
205 | /* per dasd_ccw_req flags */ | 205 | /* per dasd_ccw_req flags */ |
diff --git a/drivers/s390/char/tape_3590.c b/drivers/s390/char/tape_3590.c index 4005c44a404c..71605a179d65 100644 --- a/drivers/s390/char/tape_3590.c +++ b/drivers/s390/char/tape_3590.c | |||
@@ -801,7 +801,7 @@ tape_3590_done(struct tape_device *device, struct tape_request *request) | |||
801 | static inline int | 801 | static inline int |
802 | tape_3590_erp_succeded(struct tape_device *device, struct tape_request *request) | 802 | tape_3590_erp_succeded(struct tape_device *device, struct tape_request *request) |
803 | { | 803 | { |
804 | DBF_EVENT(3, "Error Recovery successfull for %s\n", | 804 | DBF_EVENT(3, "Error Recovery successful for %s\n", |
805 | tape_op_verbose[request->op]); | 805 | tape_op_verbose[request->op]); |
806 | return tape_3590_done(device, request); | 806 | return tape_3590_done(device, request); |
807 | } | 807 | } |
diff --git a/drivers/s390/cio/cio.c b/drivers/s390/cio/cio.c index 06b71823f399..659f8a791656 100644 --- a/drivers/s390/cio/cio.c +++ b/drivers/s390/cio/cio.c | |||
@@ -379,7 +379,7 @@ int cio_commit_config(struct subchannel *sch) | |||
379 | if (ccode < 0) /* -EIO if msch gets a program check. */ | 379 | if (ccode < 0) /* -EIO if msch gets a program check. */ |
380 | return ccode; | 380 | return ccode; |
381 | switch (ccode) { | 381 | switch (ccode) { |
382 | case 0: /* successfull */ | 382 | case 0: /* successful */ |
383 | if (stsch(sch->schid, &schib) || | 383 | if (stsch(sch->schid, &schib) || |
384 | !css_sch_is_valid(&schib)) | 384 | !css_sch_is_valid(&schib)) |
385 | return -ENODEV; | 385 | return -ENODEV; |
diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c index 744f928a59ea..10cb0f8726e5 100644 --- a/drivers/s390/cio/qdio_main.c +++ b/drivers/s390/cio/qdio_main.c | |||
@@ -114,7 +114,7 @@ static inline int qdio_check_ccq(struct qdio_q *q, unsigned int ccq) | |||
114 | * @count: count of buffers to examine | 114 | * @count: count of buffers to examine |
115 | * @auto_ack: automatically acknowledge buffers | 115 | * @auto_ack: automatically acknowledge buffers |
116 | * | 116 | * |
117 | * Returns the number of successfull extracted equal buffer states. | 117 | * Returns the number of successfully extracted equal buffer states. |
118 | * Stops processing if a state is different from the last buffers state. | 118 | * Stops processing if a state is different from the last buffers state. |
119 | */ | 119 | */ |
120 | static int qdio_do_eqbs(struct qdio_q *q, unsigned char *state, | 120 | static int qdio_do_eqbs(struct qdio_q *q, unsigned char *state, |
diff --git a/drivers/w1/masters/Kconfig b/drivers/w1/masters/Kconfig index 90616822cd20..96d2f8e4c275 100644 --- a/drivers/w1/masters/Kconfig +++ b/drivers/w1/masters/Kconfig | |||
@@ -34,6 +34,12 @@ config W1_MASTER_DS2482 | |||
34 | This driver can also be built as a module. If so, the module | 34 | This driver can also be built as a module. If so, the module |
35 | will be called ds2482. | 35 | will be called ds2482. |
36 | 36 | ||
37 | config W1_MASTER_MXC | ||
38 | tristate "Freescale MXC 1-wire busmaster" | ||
39 | depends on W1 && ARCH_MXC | ||
40 | help | ||
41 | Say Y here to enable MXC 1-wire host | ||
42 | |||
37 | config W1_MASTER_DS1WM | 43 | config W1_MASTER_DS1WM |
38 | tristate "Maxim DS1WM 1-wire busmaster" | 44 | tristate "Maxim DS1WM 1-wire busmaster" |
39 | depends on W1 && ARM && HAVE_CLK | 45 | depends on W1 && ARM && HAVE_CLK |
diff --git a/drivers/w1/masters/Makefile b/drivers/w1/masters/Makefile index bc4714a75f3a..c5a3e96fcbab 100644 --- a/drivers/w1/masters/Makefile +++ b/drivers/w1/masters/Makefile | |||
@@ -5,6 +5,8 @@ | |||
5 | obj-$(CONFIG_W1_MASTER_MATROX) += matrox_w1.o | 5 | obj-$(CONFIG_W1_MASTER_MATROX) += matrox_w1.o |
6 | obj-$(CONFIG_W1_MASTER_DS2490) += ds2490.o | 6 | obj-$(CONFIG_W1_MASTER_DS2490) += ds2490.o |
7 | obj-$(CONFIG_W1_MASTER_DS2482) += ds2482.o | 7 | obj-$(CONFIG_W1_MASTER_DS2482) += ds2482.o |
8 | obj-$(CONFIG_W1_MASTER_MXC) += mxc_w1.o | ||
9 | |||
8 | obj-$(CONFIG_W1_MASTER_DS1WM) += ds1wm.o | 10 | obj-$(CONFIG_W1_MASTER_DS1WM) += ds1wm.o |
9 | obj-$(CONFIG_W1_MASTER_GPIO) += w1-gpio.o | 11 | obj-$(CONFIG_W1_MASTER_GPIO) += w1-gpio.o |
10 | obj-$(CONFIG_HDQ_MASTER_OMAP) += omap_hdq.o | 12 | obj-$(CONFIG_HDQ_MASTER_OMAP) += omap_hdq.o |
diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c new file mode 100644 index 000000000000..b9d74d0b353e --- /dev/null +++ b/drivers/w1/masters/mxc_w1.c | |||
@@ -0,0 +1,211 @@ | |||
1 | /* | ||
2 | * Copyright 2005-2008 Freescale Semiconductor, Inc. All Rights Reserved. | ||
3 | * Copyright 2008 Luotao Fu, kernel@pengutronix.de | ||
4 | * | ||
5 | * This program is free software; you can redistribute it and/or | ||
6 | * modify it under the terms of the GNU General Public License | ||
7 | * as published by the Free Software Foundation; either version 2 | ||
8 | * of the License, or (at your option) any later version. | ||
9 | * This program is distributed in the hope that it will be useful, | ||
10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
12 | * GNU General Public License for more details. | ||
13 | * | ||
14 | * You should have received a copy of the GNU General Public License | ||
15 | * along with this program; if not, write to the Free Software | ||
16 | * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
17 | * | ||
18 | */ | ||
19 | |||
20 | #include <linux/module.h> | ||
21 | #include <linux/interrupt.h> | ||
22 | #include <linux/platform_device.h> | ||
23 | #include <linux/clk.h> | ||
24 | #include <linux/delay.h> | ||
25 | #include <linux/io.h> | ||
26 | |||
27 | #include "../w1.h" | ||
28 | #include "../w1_int.h" | ||
29 | #include "../w1_log.h" | ||
30 | |||
31 | /* According to the mx27 Datasheet the reset procedure should take up to about | ||
32 | * 1350us. We set the timeout to 500*100us = 50ms for sure */ | ||
33 | #define MXC_W1_RESET_TIMEOUT 500 | ||
34 | |||
35 | /* | ||
36 | * MXC W1 Register offsets | ||
37 | */ | ||
38 | #define MXC_W1_CONTROL 0x00 | ||
39 | #define MXC_W1_TIME_DIVIDER 0x02 | ||
40 | #define MXC_W1_RESET 0x04 | ||
41 | #define MXC_W1_COMMAND 0x06 | ||
42 | #define MXC_W1_TXRX 0x08 | ||
43 | #define MXC_W1_INTERRUPT 0x0A | ||
44 | #define MXC_W1_INTERRUPT_EN 0x0C | ||
45 | |||
46 | struct mxc_w1_device { | ||
47 | void __iomem *regs; | ||
48 | unsigned int clkdiv; | ||
49 | struct clk *clk; | ||
50 | struct w1_bus_master bus_master; | ||
51 | }; | ||
52 | |||
53 | /* | ||
54 | * this is the low level routine to | ||
55 | * reset the device on the One Wire interface | ||
56 | * on the hardware | ||
57 | */ | ||
58 | static u8 mxc_w1_ds2_reset_bus(void *data) | ||
59 | { | ||
60 | u8 reg_val; | ||
61 | unsigned int timeout_cnt = 0; | ||
62 | struct mxc_w1_device *dev = data; | ||
63 | |||
64 | __raw_writeb(0x80, (dev->regs + MXC_W1_CONTROL)); | ||
65 | |||
66 | while (1) { | ||
67 | reg_val = __raw_readb(dev->regs + MXC_W1_CONTROL); | ||
68 | |||
69 | if (((reg_val >> 7) & 0x1) == 0 || | ||
70 | timeout_cnt > MXC_W1_RESET_TIMEOUT) | ||
71 | break; | ||
72 | else | ||
73 | timeout_cnt++; | ||
74 | |||
75 | udelay(100); | ||
76 | } | ||
77 | return (reg_val >> 7) & 0x1; | ||
78 | } | ||
79 | |||
80 | /* | ||
81 | * this is the low level routine to read/write a bit on the One Wire | ||
82 | * interface on the hardware. It does write 0 if parameter bit is set | ||
83 | * to 0, otherwise a write 1/read. | ||
84 | */ | ||
85 | static u8 mxc_w1_ds2_touch_bit(void *data, u8 bit) | ||
86 | { | ||
87 | struct mxc_w1_device *mdev = data; | ||
88 | void __iomem *ctrl_addr = mdev->regs + MXC_W1_CONTROL; | ||
89 | unsigned int timeout_cnt = 400; /* Takes max. 120us according to | ||
90 | * datasheet. | ||
91 | */ | ||
92 | |||
93 | __raw_writeb((1 << (5 - bit)), ctrl_addr); | ||
94 | |||
95 | while (timeout_cnt--) { | ||
96 | if (!((__raw_readb(ctrl_addr) >> (5 - bit)) & 0x1)) | ||
97 | break; | ||
98 | |||
99 | udelay(1); | ||
100 | } | ||
101 | |||
102 | return ((__raw_readb(ctrl_addr)) >> 3) & 0x1; | ||
103 | } | ||
104 | |||
105 | static int __init mxc_w1_probe(struct platform_device *pdev) | ||
106 | { | ||
107 | struct mxc_w1_device *mdev; | ||
108 | struct resource *res; | ||
109 | int err = 0; | ||
110 | |||
111 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | ||
112 | if (!res) | ||
113 | return -ENODEV; | ||
114 | |||
115 | mdev = kzalloc(sizeof(struct mxc_w1_device), GFP_KERNEL); | ||
116 | if (!mdev) | ||
117 | return -ENOMEM; | ||
118 | |||
119 | mdev->clk = clk_get(&pdev->dev, "owire_clk"); | ||
120 | if (!mdev->clk) { | ||
121 | err = -ENODEV; | ||
122 | goto failed_clk; | ||
123 | } | ||
124 | |||
125 | mdev->clkdiv = (clk_get_rate(mdev->clk) / 1000000) - 1; | ||
126 | |||
127 | res = request_mem_region(res->start, resource_size(res), | ||
128 | "mxc_w1"); | ||
129 | if (!res) { | ||
130 | err = -EBUSY; | ||
131 | goto failed_req; | ||
132 | } | ||
133 | |||
134 | mdev->regs = ioremap(res->start, resource_size(res)); | ||
135 | if (!mdev->regs) { | ||
136 | printk(KERN_ERR "Cannot map frame buffer registers\n"); | ||
137 | goto failed_ioremap; | ||
138 | } | ||
139 | |||
140 | clk_enable(mdev->clk); | ||
141 | __raw_writeb(mdev->clkdiv, mdev->regs + MXC_W1_TIME_DIVIDER); | ||
142 | |||
143 | mdev->bus_master.data = mdev; | ||
144 | mdev->bus_master.reset_bus = mxc_w1_ds2_reset_bus; | ||
145 | mdev->bus_master.touch_bit = mxc_w1_ds2_touch_bit; | ||
146 | |||
147 | err = w1_add_master_device(&mdev->bus_master); | ||
148 | |||
149 | if (err) | ||
150 | goto failed_add; | ||
151 | |||
152 | platform_set_drvdata(pdev, mdev); | ||
153 | return 0; | ||
154 | |||
155 | failed_add: | ||
156 | iounmap(mdev->regs); | ||
157 | failed_ioremap: | ||
158 | release_mem_region(res->start, resource_size(res)); | ||
159 | failed_req: | ||
160 | clk_put(mdev->clk); | ||
161 | failed_clk: | ||
162 | kfree(mdev); | ||
163 | return err; | ||
164 | } | ||
165 | |||
166 | /* | ||
167 | * disassociate the w1 device from the driver | ||
168 | */ | ||
169 | static int mxc_w1_remove(struct platform_device *pdev) | ||
170 | { | ||
171 | struct mxc_w1_device *mdev = platform_get_drvdata(pdev); | ||
172 | struct resource *res; | ||
173 | |||
174 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | ||
175 | |||
176 | w1_remove_master_device(&mdev->bus_master); | ||
177 | |||
178 | iounmap(mdev->regs); | ||
179 | release_mem_region(res->start, resource_size(res)); | ||
180 | clk_disable(mdev->clk); | ||
181 | clk_put(mdev->clk); | ||
182 | |||
183 | platform_set_drvdata(pdev, NULL); | ||
184 | |||
185 | return 0; | ||
186 | } | ||
187 | |||
188 | static struct platform_driver mxc_w1_driver = { | ||
189 | .driver = { | ||
190 | .name = "mxc_w1", | ||
191 | }, | ||
192 | .probe = mxc_w1_probe, | ||
193 | .remove = mxc_w1_remove, | ||
194 | }; | ||
195 | |||
196 | static int __init mxc_w1_init(void) | ||
197 | { | ||
198 | return platform_driver_register(&mxc_w1_driver); | ||
199 | } | ||
200 | |||
201 | static void mxc_w1_exit(void) | ||
202 | { | ||
203 | platform_driver_unregister(&mxc_w1_driver); | ||
204 | } | ||
205 | |||
206 | module_init(mxc_w1_init); | ||
207 | module_exit(mxc_w1_exit); | ||
208 | |||
209 | MODULE_LICENSE("GPL"); | ||
210 | MODULE_AUTHOR("Freescale Semiconductors Inc"); | ||
211 | MODULE_DESCRIPTION("Driver for One-Wire on MXC"); | ||
diff --git a/drivers/w1/w1.h b/drivers/w1/w1.h index 97304bd83ec9..d8a9709f3449 100644 --- a/drivers/w1/w1.h +++ b/drivers/w1/w1.h | |||
@@ -210,6 +210,7 @@ u8 w1_read_8(struct w1_master *); | |||
210 | int w1_reset_bus(struct w1_master *); | 210 | int w1_reset_bus(struct w1_master *); |
211 | u8 w1_calc_crc8(u8 *, int); | 211 | u8 w1_calc_crc8(u8 *, int); |
212 | void w1_write_block(struct w1_master *, const u8 *, int); | 212 | void w1_write_block(struct w1_master *, const u8 *, int); |
213 | void w1_touch_block(struct w1_master *, u8 *, int); | ||
213 | u8 w1_read_block(struct w1_master *, u8 *, int); | 214 | u8 w1_read_block(struct w1_master *, u8 *, int); |
214 | int w1_reset_select_slave(struct w1_slave *sl); | 215 | int w1_reset_select_slave(struct w1_slave *sl); |
215 | void w1_next_pullup(struct w1_master *, int); | 216 | void w1_next_pullup(struct w1_master *, int); |
diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c index 5139c25ca962..442bd8bbd4a5 100644 --- a/drivers/w1/w1_io.c +++ b/drivers/w1/w1_io.c | |||
@@ -238,7 +238,6 @@ EXPORT_SYMBOL_GPL(w1_read_8); | |||
238 | * @param dev the master device | 238 | * @param dev the master device |
239 | * @param buf pointer to the data to write | 239 | * @param buf pointer to the data to write |
240 | * @param len the number of bytes to write | 240 | * @param len the number of bytes to write |
241 | * @return the byte read | ||
242 | */ | 241 | */ |
243 | void w1_write_block(struct w1_master *dev, const u8 *buf, int len) | 242 | void w1_write_block(struct w1_master *dev, const u8 *buf, int len) |
244 | { | 243 | { |
@@ -256,6 +255,31 @@ void w1_write_block(struct w1_master *dev, const u8 *buf, int len) | |||
256 | EXPORT_SYMBOL_GPL(w1_write_block); | 255 | EXPORT_SYMBOL_GPL(w1_write_block); |
257 | 256 | ||
258 | /** | 257 | /** |
258 | * Touches a series of bytes. | ||
259 | * | ||
260 | * @param dev the master device | ||
261 | * @param buf pointer to the data to write | ||
262 | * @param len the number of bytes to write | ||
263 | */ | ||
264 | void w1_touch_block(struct w1_master *dev, u8 *buf, int len) | ||
265 | { | ||
266 | int i, j; | ||
267 | u8 tmp; | ||
268 | |||
269 | for (i = 0; i < len; ++i) { | ||
270 | tmp = 0; | ||
271 | for (j = 0; j < 8; ++j) { | ||
272 | if (j == 7) | ||
273 | w1_pre_write(dev); | ||
274 | tmp |= w1_touch_bit(dev, (buf[i] >> j) & 0x1) << j; | ||
275 | } | ||
276 | |||
277 | buf[i] = tmp; | ||
278 | } | ||
279 | } | ||
280 | EXPORT_SYMBOL_GPL(w1_touch_block); | ||
281 | |||
282 | /** | ||
259 | * Reads a series of bytes. | 283 | * Reads a series of bytes. |
260 | * | 284 | * |
261 | * @param dev the master device | 285 | * @param dev the master device |
diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c index 65c5ebd0787e..fdf72851c574 100644 --- a/drivers/w1/w1_netlink.c +++ b/drivers/w1/w1_netlink.c | |||
@@ -47,21 +47,56 @@ void w1_netlink_send(struct w1_master *dev, struct w1_netlink_msg *msg) | |||
47 | cn_netlink_send(m, 0, GFP_KERNEL); | 47 | cn_netlink_send(m, 0, GFP_KERNEL); |
48 | } | 48 | } |
49 | 49 | ||
50 | static int w1_process_command_master(struct w1_master *dev, struct cn_msg *msg, | 50 | static void w1_send_slave(struct w1_master *dev, u64 rn) |
51 | struct w1_netlink_msg *hdr, struct w1_netlink_cmd *cmd) | 51 | { |
52 | struct cn_msg *msg = dev->priv; | ||
53 | struct w1_netlink_msg *hdr = (struct w1_netlink_msg *)(msg + 1); | ||
54 | struct w1_netlink_cmd *cmd = (struct w1_netlink_cmd *)(hdr + 1); | ||
55 | int avail; | ||
56 | |||
57 | avail = dev->priv_size - cmd->len; | ||
58 | |||
59 | if (avail > 8) { | ||
60 | u64 *data = (void *)(cmd + 1) + cmd->len; | ||
61 | |||
62 | *data = rn; | ||
63 | cmd->len += 8; | ||
64 | hdr->len += 8; | ||
65 | msg->len += 8; | ||
66 | return; | ||
67 | } | ||
68 | |||
69 | msg->ack++; | ||
70 | cn_netlink_send(msg, 0, GFP_KERNEL); | ||
71 | |||
72 | msg->len = sizeof(struct w1_netlink_msg) + sizeof(struct w1_netlink_cmd); | ||
73 | hdr->len = sizeof(struct w1_netlink_cmd); | ||
74 | cmd->len = 0; | ||
75 | } | ||
76 | |||
77 | static int w1_process_search_command(struct w1_master *dev, struct cn_msg *msg, | ||
78 | unsigned int avail) | ||
52 | { | 79 | { |
53 | dev_dbg(&dev->dev, "%s: %s: cmd=%02x, len=%u.\n", | 80 | struct w1_netlink_msg *hdr = (struct w1_netlink_msg *)(msg + 1); |
54 | __func__, dev->name, cmd->cmd, cmd->len); | 81 | struct w1_netlink_cmd *cmd = (struct w1_netlink_cmd *)(hdr + 1); |
82 | int search_type = (cmd->cmd == W1_CMD_ALARM_SEARCH)?W1_ALARM_SEARCH:W1_SEARCH; | ||
55 | 83 | ||
56 | if (cmd->cmd != W1_CMD_SEARCH && cmd->cmd != W1_CMD_ALARM_SEARCH) | 84 | dev->priv = msg; |
57 | return -EINVAL; | 85 | dev->priv_size = avail; |
86 | |||
87 | w1_search_devices(dev, search_type, w1_send_slave); | ||
88 | |||
89 | msg->ack = 0; | ||
90 | cn_netlink_send(msg, 0, GFP_KERNEL); | ||
91 | |||
92 | dev->priv = NULL; | ||
93 | dev->priv_size = 0; | ||
58 | 94 | ||
59 | w1_search_process(dev, (cmd->cmd == W1_CMD_ALARM_SEARCH)?W1_ALARM_SEARCH:W1_SEARCH); | ||
60 | return 0; | 95 | return 0; |
61 | } | 96 | } |
62 | 97 | ||
63 | static int w1_send_read_reply(struct w1_slave *sl, struct cn_msg *msg, | 98 | static int w1_send_read_reply(struct cn_msg *msg, struct w1_netlink_msg *hdr, |
64 | struct w1_netlink_msg *hdr, struct w1_netlink_cmd *cmd) | 99 | struct w1_netlink_cmd *cmd) |
65 | { | 100 | { |
66 | void *data; | 101 | void *data; |
67 | struct w1_netlink_msg *h; | 102 | struct w1_netlink_msg *h; |
@@ -85,7 +120,8 @@ static int w1_send_read_reply(struct w1_slave *sl, struct cn_msg *msg, | |||
85 | memcpy(c, cmd, sizeof(struct w1_netlink_cmd)); | 120 | memcpy(c, cmd, sizeof(struct w1_netlink_cmd)); |
86 | 121 | ||
87 | cm->ack = msg->seq+1; | 122 | cm->ack = msg->seq+1; |
88 | cm->len = sizeof(struct w1_netlink_msg) + sizeof(struct w1_netlink_cmd) + cmd->len; | 123 | cm->len = sizeof(struct w1_netlink_msg) + |
124 | sizeof(struct w1_netlink_cmd) + cmd->len; | ||
89 | 125 | ||
90 | h->len = sizeof(struct w1_netlink_cmd) + cmd->len; | 126 | h->len = sizeof(struct w1_netlink_cmd) + cmd->len; |
91 | 127 | ||
@@ -98,36 +134,178 @@ static int w1_send_read_reply(struct w1_slave *sl, struct cn_msg *msg, | |||
98 | return err; | 134 | return err; |
99 | } | 135 | } |
100 | 136 | ||
101 | static int w1_process_command_slave(struct w1_slave *sl, struct cn_msg *msg, | 137 | static int w1_process_command_io(struct w1_master *dev, struct cn_msg *msg, |
102 | struct w1_netlink_msg *hdr, struct w1_netlink_cmd *cmd) | 138 | struct w1_netlink_msg *hdr, struct w1_netlink_cmd *cmd) |
103 | { | 139 | { |
104 | int err = 0; | 140 | int err = 0; |
105 | 141 | ||
106 | dev_dbg(&sl->master->dev, "%s: %02x.%012llx.%02x: cmd=%02x, len=%u.\n", | 142 | switch (cmd->cmd) { |
107 | __func__, sl->reg_num.family, (unsigned long long)sl->reg_num.id, sl->reg_num.crc, | 143 | case W1_CMD_TOUCH: |
108 | cmd->cmd, cmd->len); | 144 | w1_touch_block(dev, cmd->data, cmd->len); |
145 | w1_send_read_reply(msg, hdr, cmd); | ||
146 | break; | ||
147 | case W1_CMD_READ: | ||
148 | w1_read_block(dev, cmd->data, cmd->len); | ||
149 | w1_send_read_reply(msg, hdr, cmd); | ||
150 | break; | ||
151 | case W1_CMD_WRITE: | ||
152 | w1_write_block(dev, cmd->data, cmd->len); | ||
153 | break; | ||
154 | default: | ||
155 | err = -EINVAL; | ||
156 | break; | ||
157 | } | ||
158 | |||
159 | return err; | ||
160 | } | ||
161 | |||
162 | static int w1_process_command_master(struct w1_master *dev, struct cn_msg *req_msg, | ||
163 | struct w1_netlink_msg *req_hdr, struct w1_netlink_cmd *req_cmd) | ||
164 | { | ||
165 | int err = -EINVAL; | ||
166 | struct cn_msg *msg; | ||
167 | struct w1_netlink_msg *hdr; | ||
168 | struct w1_netlink_cmd *cmd; | ||
169 | |||
170 | msg = kzalloc(PAGE_SIZE, GFP_KERNEL); | ||
171 | if (!msg) | ||
172 | return -ENOMEM; | ||
173 | |||
174 | msg->id = req_msg->id; | ||
175 | msg->seq = req_msg->seq; | ||
176 | msg->ack = 0; | ||
177 | msg->len = sizeof(struct w1_netlink_msg) + sizeof(struct w1_netlink_cmd); | ||
178 | |||
179 | hdr = (struct w1_netlink_msg *)(msg + 1); | ||
180 | cmd = (struct w1_netlink_cmd *)(hdr + 1); | ||
181 | |||
182 | hdr->type = W1_MASTER_CMD; | ||
183 | hdr->id = req_hdr->id; | ||
184 | hdr->len = sizeof(struct w1_netlink_cmd); | ||
185 | |||
186 | cmd->cmd = req_cmd->cmd; | ||
187 | cmd->len = 0; | ||
109 | 188 | ||
110 | switch (cmd->cmd) { | 189 | switch (cmd->cmd) { |
111 | case W1_CMD_READ: | 190 | case W1_CMD_SEARCH: |
112 | w1_read_block(sl->master, cmd->data, cmd->len); | 191 | case W1_CMD_ALARM_SEARCH: |
113 | w1_send_read_reply(sl, msg, hdr, cmd); | 192 | err = w1_process_search_command(dev, msg, |
114 | break; | 193 | PAGE_SIZE - msg->len - sizeof(struct cn_msg)); |
115 | case W1_CMD_WRITE: | 194 | break; |
116 | w1_write_block(sl->master, cmd->data, cmd->len); | 195 | case W1_CMD_READ: |
117 | break; | 196 | case W1_CMD_WRITE: |
118 | case W1_CMD_SEARCH: | 197 | case W1_CMD_TOUCH: |
119 | case W1_CMD_ALARM_SEARCH: | 198 | err = w1_process_command_io(dev, req_msg, req_hdr, req_cmd); |
120 | w1_search_process(sl->master, | 199 | break; |
121 | (cmd->cmd == W1_CMD_ALARM_SEARCH)?W1_ALARM_SEARCH:W1_SEARCH); | 200 | case W1_CMD_RESET: |
122 | break; | 201 | err = w1_reset_bus(dev); |
123 | default: | 202 | break; |
124 | err = -1; | 203 | default: |
125 | break; | 204 | err = -EINVAL; |
205 | break; | ||
126 | } | 206 | } |
127 | 207 | ||
208 | kfree(msg); | ||
128 | return err; | 209 | return err; |
129 | } | 210 | } |
130 | 211 | ||
212 | static int w1_process_command_slave(struct w1_slave *sl, struct cn_msg *msg, | ||
213 | struct w1_netlink_msg *hdr, struct w1_netlink_cmd *cmd) | ||
214 | { | ||
215 | dev_dbg(&sl->master->dev, "%s: %02x.%012llx.%02x: cmd=%02x, len=%u.\n", | ||
216 | __func__, sl->reg_num.family, (unsigned long long)sl->reg_num.id, | ||
217 | sl->reg_num.crc, cmd->cmd, cmd->len); | ||
218 | |||
219 | return w1_process_command_io(sl->master, msg, hdr, cmd); | ||
220 | } | ||
221 | |||
222 | static int w1_process_command_root(struct cn_msg *msg, struct w1_netlink_msg *mcmd) | ||
223 | { | ||
224 | struct w1_master *m; | ||
225 | struct cn_msg *cn; | ||
226 | struct w1_netlink_msg *w; | ||
227 | u32 *id; | ||
228 | |||
229 | if (mcmd->type != W1_LIST_MASTERS) { | ||
230 | printk(KERN_NOTICE "%s: msg: %x.%x, wrong type: %u, len: %u.\n", | ||
231 | __func__, msg->id.idx, msg->id.val, mcmd->type, mcmd->len); | ||
232 | return -EPROTO; | ||
233 | } | ||
234 | |||
235 | cn = kmalloc(PAGE_SIZE, GFP_KERNEL); | ||
236 | if (!cn) | ||
237 | return -ENOMEM; | ||
238 | |||
239 | cn->id.idx = CN_W1_IDX; | ||
240 | cn->id.val = CN_W1_VAL; | ||
241 | |||
242 | cn->seq = msg->seq; | ||
243 | cn->ack = 1; | ||
244 | cn->len = sizeof(struct w1_netlink_msg); | ||
245 | w = (struct w1_netlink_msg *)(cn + 1); | ||
246 | |||
247 | w->type = W1_LIST_MASTERS; | ||
248 | w->status = 0; | ||
249 | w->len = 0; | ||
250 | id = (u32 *)(w + 1); | ||
251 | |||
252 | mutex_lock(&w1_mlock); | ||
253 | list_for_each_entry(m, &w1_masters, w1_master_entry) { | ||
254 | if (cn->len + sizeof(*id) > PAGE_SIZE - sizeof(struct cn_msg)) { | ||
255 | cn_netlink_send(cn, 0, GFP_KERNEL); | ||
256 | cn->ack++; | ||
257 | cn->len = sizeof(struct w1_netlink_msg); | ||
258 | w->len = 0; | ||
259 | id = (u32 *)(w + 1); | ||
260 | } | ||
261 | |||
262 | *id = m->id; | ||
263 | w->len += sizeof(*id); | ||
264 | cn->len += sizeof(*id); | ||
265 | id++; | ||
266 | } | ||
267 | cn->ack = 0; | ||
268 | cn_netlink_send(cn, 0, GFP_KERNEL); | ||
269 | mutex_unlock(&w1_mlock); | ||
270 | |||
271 | kfree(cn); | ||
272 | return 0; | ||
273 | } | ||
274 | |||
275 | static int w1_netlink_send_error(struct cn_msg *rcmsg, struct w1_netlink_msg *rmsg, | ||
276 | struct w1_netlink_cmd *rcmd, int error) | ||
277 | { | ||
278 | struct cn_msg *cmsg; | ||
279 | struct w1_netlink_msg *msg; | ||
280 | struct w1_netlink_cmd *cmd; | ||
281 | |||
282 | cmsg = kzalloc(sizeof(*msg) + sizeof(*cmd) + sizeof(*cmsg), GFP_KERNEL); | ||
283 | if (!cmsg) | ||
284 | return -ENOMEM; | ||
285 | |||
286 | msg = (struct w1_netlink_msg *)(cmsg + 1); | ||
287 | cmd = (struct w1_netlink_cmd *)(msg + 1); | ||
288 | |||
289 | memcpy(cmsg, rcmsg, sizeof(*cmsg)); | ||
290 | cmsg->len = sizeof(*msg); | ||
291 | |||
292 | memcpy(msg, rmsg, sizeof(*msg)); | ||
293 | msg->len = 0; | ||
294 | msg->status = (short)-error; | ||
295 | |||
296 | if (rcmd) { | ||
297 | memcpy(cmd, rcmd, sizeof(*cmd)); | ||
298 | cmd->len = 0; | ||
299 | msg->len += sizeof(*cmd); | ||
300 | cmsg->len += sizeof(*cmd); | ||
301 | } | ||
302 | |||
303 | error = cn_netlink_send(cmsg, 0, GFP_KERNEL); | ||
304 | kfree(cmsg); | ||
305 | |||
306 | return error; | ||
307 | } | ||
308 | |||
131 | static void w1_cn_callback(void *data) | 309 | static void w1_cn_callback(void *data) |
132 | { | 310 | { |
133 | struct cn_msg *msg = data; | 311 | struct cn_msg *msg = data; |
@@ -144,6 +322,7 @@ static void w1_cn_callback(void *data) | |||
144 | 322 | ||
145 | dev = NULL; | 323 | dev = NULL; |
146 | sl = NULL; | 324 | sl = NULL; |
325 | cmd = NULL; | ||
147 | 326 | ||
148 | memcpy(&id, m->id.id, sizeof(id)); | 327 | memcpy(&id, m->id.id, sizeof(id)); |
149 | #if 0 | 328 | #if 0 |
@@ -155,15 +334,15 @@ static void w1_cn_callback(void *data) | |||
155 | break; | 334 | break; |
156 | } | 335 | } |
157 | 336 | ||
158 | if (!mlen) | ||
159 | goto out_cont; | ||
160 | |||
161 | if (m->type == W1_MASTER_CMD) { | 337 | if (m->type == W1_MASTER_CMD) { |
162 | dev = w1_search_master_id(m->id.mst.id); | 338 | dev = w1_search_master_id(m->id.mst.id); |
163 | } else if (m->type == W1_SLAVE_CMD) { | 339 | } else if (m->type == W1_SLAVE_CMD) { |
164 | sl = w1_search_slave(&id); | 340 | sl = w1_search_slave(&id); |
165 | if (sl) | 341 | if (sl) |
166 | dev = sl->master; | 342 | dev = sl->master; |
343 | } else { | ||
344 | err = w1_process_command_root(msg, m); | ||
345 | goto out_cont; | ||
167 | } | 346 | } |
168 | 347 | ||
169 | if (!dev) { | 348 | if (!dev) { |
@@ -171,6 +350,10 @@ static void w1_cn_callback(void *data) | |||
171 | goto out_cont; | 350 | goto out_cont; |
172 | } | 351 | } |
173 | 352 | ||
353 | err = 0; | ||
354 | if (!mlen) | ||
355 | goto out_cont; | ||
356 | |||
174 | mutex_lock(&dev->mutex); | 357 | mutex_lock(&dev->mutex); |
175 | 358 | ||
176 | if (sl && w1_reset_select_slave(sl)) { | 359 | if (sl && w1_reset_select_slave(sl)) { |
@@ -187,9 +370,12 @@ static void w1_cn_callback(void *data) | |||
187 | } | 370 | } |
188 | 371 | ||
189 | if (sl) | 372 | if (sl) |
190 | w1_process_command_slave(sl, msg, m, cmd); | 373 | err = w1_process_command_slave(sl, msg, m, cmd); |
191 | else | 374 | else |
192 | w1_process_command_master(dev, msg, m, cmd); | 375 | err = w1_process_command_master(dev, msg, m, cmd); |
376 | |||
377 | w1_netlink_send_error(msg, m, cmd, err); | ||
378 | err = 0; | ||
193 | 379 | ||
194 | cmd_data += cmd->len + sizeof(struct w1_netlink_cmd); | 380 | cmd_data += cmd->len + sizeof(struct w1_netlink_cmd); |
195 | mlen -= cmd->len + sizeof(struct w1_netlink_cmd); | 381 | mlen -= cmd->len + sizeof(struct w1_netlink_cmd); |
@@ -200,6 +386,8 @@ out_up: | |||
200 | atomic_dec(&sl->refcnt); | 386 | atomic_dec(&sl->refcnt); |
201 | mutex_unlock(&dev->mutex); | 387 | mutex_unlock(&dev->mutex); |
202 | out_cont: | 388 | out_cont: |
389 | if (!cmd || err) | ||
390 | w1_netlink_send_error(msg, m, cmd, err); | ||
203 | msg->len -= sizeof(struct w1_netlink_msg) + m->len; | 391 | msg->len -= sizeof(struct w1_netlink_msg) + m->len; |
204 | m = (struct w1_netlink_msg *)(((u8 *)m) + sizeof(struct w1_netlink_msg) + m->len); | 392 | m = (struct w1_netlink_msg *)(((u8 *)m) + sizeof(struct w1_netlink_msg) + m->len); |
205 | 393 | ||
@@ -209,11 +397,6 @@ out_cont: | |||
209 | if (err == -ENODEV) | 397 | if (err == -ENODEV) |
210 | err = 0; | 398 | err = 0; |
211 | } | 399 | } |
212 | #if 0 | ||
213 | if (err) { | ||
214 | printk("%s: malformed message. Dropping.\n", __func__); | ||
215 | } | ||
216 | #endif | ||
217 | } | 400 | } |
218 | 401 | ||
219 | int w1_init_netlink(void) | 402 | int w1_init_netlink(void) |
diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h index 56122b9e9294..27e950f935b1 100644 --- a/drivers/w1/w1_netlink.h +++ b/drivers/w1/w1_netlink.h | |||
@@ -34,12 +34,13 @@ enum w1_netlink_message_types { | |||
34 | W1_MASTER_REMOVE, | 34 | W1_MASTER_REMOVE, |
35 | W1_MASTER_CMD, | 35 | W1_MASTER_CMD, |
36 | W1_SLAVE_CMD, | 36 | W1_SLAVE_CMD, |
37 | W1_LIST_MASTERS, | ||
37 | }; | 38 | }; |
38 | 39 | ||
39 | struct w1_netlink_msg | 40 | struct w1_netlink_msg |
40 | { | 41 | { |
41 | __u8 type; | 42 | __u8 type; |
42 | __u8 reserved; | 43 | __u8 status; |
43 | __u16 len; | 44 | __u16 len; |
44 | union { | 45 | union { |
45 | __u8 id[8]; | 46 | __u8 id[8]; |
@@ -51,10 +52,15 @@ struct w1_netlink_msg | |||
51 | __u8 data[0]; | 52 | __u8 data[0]; |
52 | }; | 53 | }; |
53 | 54 | ||
54 | #define W1_CMD_READ 0x0 | 55 | enum w1_commands { |
55 | #define W1_CMD_WRITE 0x1 | 56 | W1_CMD_READ = 0, |
56 | #define W1_CMD_SEARCH 0x2 | 57 | W1_CMD_WRITE, |
57 | #define W1_CMD_ALARM_SEARCH 0x3 | 58 | W1_CMD_SEARCH, |
59 | W1_CMD_ALARM_SEARCH, | ||
60 | W1_CMD_TOUCH, | ||
61 | W1_CMD_RESET, | ||
62 | W1_CMD_MAX, | ||
63 | }; | ||
58 | 64 | ||
59 | struct w1_netlink_cmd | 65 | struct w1_netlink_cmd |
60 | { | 66 | { |
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 4b75a16de009..526187c8a12d 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig | |||
@@ -17,3 +17,27 @@ config XEN_SCRUB_PAGES | |||
17 | is not accidentally visible to other domains. Is it more | 17 | is not accidentally visible to other domains. Is it more |
18 | secure, but slightly less efficient. | 18 | secure, but slightly less efficient. |
19 | If in doubt, say yes. | 19 | If in doubt, say yes. |
20 | |||
21 | config XENFS | ||
22 | tristate "Xen filesystem" | ||
23 | depends on XEN | ||
24 | default y | ||
25 | help | ||
26 | The xen filesystem provides a way for domains to share | ||
27 | information with each other and with the hypervisor. | ||
28 | For example, by reading and writing the "xenbus" file, guests | ||
29 | may pass arbitrary information to the initial domain. | ||
30 | If in doubt, say yes. | ||
31 | |||
32 | config XEN_COMPAT_XENFS | ||
33 | bool "Create compatibility mount point /proc/xen" | ||
34 | depends on XENFS | ||
35 | default y | ||
36 | help | ||
37 | The old xenstore userspace tools expect to find "xenbus" | ||
38 | under /proc/xen, but "xenbus" is now found at the root of the | ||
39 | xenfs filesystem. Selecting this causes the kernel to create | ||
40 | the compatibilty mount point /proc/xen if it is running on | ||
41 | a xen platform. | ||
42 | If in doubt, say yes. | ||
43 | |||
diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index d2a8fdf0e191..ff8accc9e103 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile | |||
@@ -1,5 +1,7 @@ | |||
1 | obj-y += grant-table.o features.o events.o manage.o | 1 | obj-y += grant-table.o features.o events.o manage.o |
2 | obj-y += xenbus/ | 2 | obj-y += xenbus/ |
3 | |||
3 | obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o | 4 | obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o |
4 | obj-$(CONFIG_XEN_XENCOMM) += xencomm.o | 5 | obj-$(CONFIG_XEN_XENCOMM) += xencomm.o |
5 | obj-$(CONFIG_XEN_BALLOON) += balloon.o | 6 | obj-$(CONFIG_XEN_BALLOON) += balloon.o |
7 | obj-$(CONFIG_XENFS) += xenfs/ \ No newline at end of file | ||
diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c index 9678b3e98c63..92a1ef80a288 100644 --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c | |||
@@ -136,7 +136,6 @@ EXPORT_SYMBOL_GPL(xenbus_watch_pathfmt); | |||
136 | /** | 136 | /** |
137 | * xenbus_switch_state | 137 | * xenbus_switch_state |
138 | * @dev: xenbus device | 138 | * @dev: xenbus device |
139 | * @xbt: transaction handle | ||
140 | * @state: new state | 139 | * @state: new state |
141 | * | 140 | * |
142 | * Advertise in the store a change of the given driver to the given new_state. | 141 | * Advertise in the store a change of the given driver to the given new_state. |
@@ -267,7 +266,7 @@ EXPORT_SYMBOL_GPL(xenbus_dev_error); | |||
267 | * @fmt: error message format | 266 | * @fmt: error message format |
268 | * | 267 | * |
269 | * Equivalent to xenbus_dev_error(dev, err, fmt, args), followed by | 268 | * Equivalent to xenbus_dev_error(dev, err, fmt, args), followed by |
270 | * xenbus_switch_state(dev, NULL, XenbusStateClosing) to schedule an orderly | 269 | * xenbus_switch_state(dev, XenbusStateClosing) to schedule an orderly |
271 | * closedown of this driver and its peer. | 270 | * closedown of this driver and its peer. |
272 | */ | 271 | */ |
273 | 272 | ||
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index b2a03184a246..773d1cf23283 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c | |||
@@ -40,6 +40,7 @@ | |||
40 | #include <linux/ctype.h> | 40 | #include <linux/ctype.h> |
41 | #include <linux/fcntl.h> | 41 | #include <linux/fcntl.h> |
42 | #include <linux/mm.h> | 42 | #include <linux/mm.h> |
43 | #include <linux/proc_fs.h> | ||
43 | #include <linux/notifier.h> | 44 | #include <linux/notifier.h> |
44 | #include <linux/kthread.h> | 45 | #include <linux/kthread.h> |
45 | #include <linux/mutex.h> | 46 | #include <linux/mutex.h> |
@@ -55,7 +56,10 @@ | |||
55 | #include "xenbus_comms.h" | 56 | #include "xenbus_comms.h" |
56 | #include "xenbus_probe.h" | 57 | #include "xenbus_probe.h" |
57 | 58 | ||
59 | |||
58 | int xen_store_evtchn; | 60 | int xen_store_evtchn; |
61 | EXPORT_SYMBOL(xen_store_evtchn); | ||
62 | |||
59 | struct xenstore_domain_interface *xen_store_interface; | 63 | struct xenstore_domain_interface *xen_store_interface; |
60 | static unsigned long xen_store_mfn; | 64 | static unsigned long xen_store_mfn; |
61 | 65 | ||
@@ -166,6 +170,9 @@ static int read_backend_details(struct xenbus_device *xendev) | |||
166 | return read_otherend_details(xendev, "backend-id", "backend"); | 170 | return read_otherend_details(xendev, "backend-id", "backend"); |
167 | } | 171 | } |
168 | 172 | ||
173 | static struct device_attribute xenbus_dev_attrs[] = { | ||
174 | __ATTR_NULL | ||
175 | }; | ||
169 | 176 | ||
170 | /* Bus type for frontend drivers. */ | 177 | /* Bus type for frontend drivers. */ |
171 | static struct xen_bus_type xenbus_frontend = { | 178 | static struct xen_bus_type xenbus_frontend = { |
@@ -174,12 +181,13 @@ static struct xen_bus_type xenbus_frontend = { | |||
174 | .get_bus_id = frontend_bus_id, | 181 | .get_bus_id = frontend_bus_id, |
175 | .probe = xenbus_probe_frontend, | 182 | .probe = xenbus_probe_frontend, |
176 | .bus = { | 183 | .bus = { |
177 | .name = "xen", | 184 | .name = "xen", |
178 | .match = xenbus_match, | 185 | .match = xenbus_match, |
179 | .uevent = xenbus_uevent, | 186 | .uevent = xenbus_uevent, |
180 | .probe = xenbus_dev_probe, | 187 | .probe = xenbus_dev_probe, |
181 | .remove = xenbus_dev_remove, | 188 | .remove = xenbus_dev_remove, |
182 | .shutdown = xenbus_dev_shutdown, | 189 | .shutdown = xenbus_dev_shutdown, |
190 | .dev_attrs = xenbus_dev_attrs, | ||
183 | }, | 191 | }, |
184 | }; | 192 | }; |
185 | 193 | ||
@@ -852,6 +860,14 @@ static int __init xenbus_probe_init(void) | |||
852 | if (!xen_initial_domain()) | 860 | if (!xen_initial_domain()) |
853 | xenbus_probe(NULL); | 861 | xenbus_probe(NULL); |
854 | 862 | ||
863 | #ifdef CONFIG_XEN_COMPAT_XENFS | ||
864 | /* | ||
865 | * Create xenfs mountpoint in /proc for compatibility with | ||
866 | * utilities that expect to find "xenbus" under "/proc/xen". | ||
867 | */ | ||
868 | proc_mkdir("xen", NULL); | ||
869 | #endif | ||
870 | |||
855 | return 0; | 871 | return 0; |
856 | 872 | ||
857 | out_unreg_back: | 873 | out_unreg_back: |
diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c index 7f2f91c0e11d..e325eab4724d 100644 --- a/drivers/xen/xenbus/xenbus_xs.c +++ b/drivers/xen/xenbus/xenbus_xs.c | |||
@@ -184,6 +184,7 @@ void *xenbus_dev_request_and_reply(struct xsd_sockmsg *msg) | |||
184 | 184 | ||
185 | return ret; | 185 | return ret; |
186 | } | 186 | } |
187 | EXPORT_SYMBOL(xenbus_dev_request_and_reply); | ||
187 | 188 | ||
188 | /* Send message to xs, get kmalloc'ed reply. ERR_PTR() on error. */ | 189 | /* Send message to xs, get kmalloc'ed reply. ERR_PTR() on error. */ |
189 | static void *xs_talkv(struct xenbus_transaction t, | 190 | static void *xs_talkv(struct xenbus_transaction t, |
diff --git a/drivers/xen/xenfs/Makefile b/drivers/xen/xenfs/Makefile new file mode 100644 index 000000000000..25275c3bbdff --- /dev/null +++ b/drivers/xen/xenfs/Makefile | |||
@@ -0,0 +1,3 @@ | |||
1 | obj-$(CONFIG_XENFS) += xenfs.o | ||
2 | |||
3 | xenfs-objs = super.o xenbus.o \ No newline at end of file | ||
diff --git a/drivers/xen/xenfs/super.c b/drivers/xen/xenfs/super.c new file mode 100644 index 000000000000..515741a8e6b8 --- /dev/null +++ b/drivers/xen/xenfs/super.c | |||
@@ -0,0 +1,64 @@ | |||
1 | /* | ||
2 | * xenfs.c - a filesystem for passing info between the a domain and | ||
3 | * the hypervisor. | ||
4 | * | ||
5 | * 2008-10-07 Alex Zeffertt Replaced /proc/xen/xenbus with xenfs filesystem | ||
6 | * and /proc/xen compatibility mount point. | ||
7 | * Turned xenfs into a loadable module. | ||
8 | */ | ||
9 | |||
10 | #include <linux/kernel.h> | ||
11 | #include <linux/errno.h> | ||
12 | #include <linux/module.h> | ||
13 | #include <linux/fs.h> | ||
14 | #include <linux/magic.h> | ||
15 | |||
16 | #include "xenfs.h" | ||
17 | |||
18 | #include <asm/xen/hypervisor.h> | ||
19 | |||
20 | MODULE_DESCRIPTION("Xen filesystem"); | ||
21 | MODULE_LICENSE("GPL"); | ||
22 | |||
23 | static int xenfs_fill_super(struct super_block *sb, void *data, int silent) | ||
24 | { | ||
25 | static struct tree_descr xenfs_files[] = { | ||
26 | [2] = {"xenbus", &xenbus_file_ops, S_IRUSR|S_IWUSR}, | ||
27 | {""}, | ||
28 | }; | ||
29 | |||
30 | return simple_fill_super(sb, XENFS_SUPER_MAGIC, xenfs_files); | ||
31 | } | ||
32 | |||
33 | static int xenfs_get_sb(struct file_system_type *fs_type, | ||
34 | int flags, const char *dev_name, | ||
35 | void *data, struct vfsmount *mnt) | ||
36 | { | ||
37 | return get_sb_single(fs_type, flags, data, xenfs_fill_super, mnt); | ||
38 | } | ||
39 | |||
40 | static struct file_system_type xenfs_type = { | ||
41 | .owner = THIS_MODULE, | ||
42 | .name = "xenfs", | ||
43 | .get_sb = xenfs_get_sb, | ||
44 | .kill_sb = kill_litter_super, | ||
45 | }; | ||
46 | |||
47 | static int __init xenfs_init(void) | ||
48 | { | ||
49 | if (xen_pv_domain()) | ||
50 | return register_filesystem(&xenfs_type); | ||
51 | |||
52 | printk(KERN_INFO "XENFS: not registering filesystem on non-xen platform\n"); | ||
53 | return 0; | ||
54 | } | ||
55 | |||
56 | static void __exit xenfs_exit(void) | ||
57 | { | ||
58 | if (xen_pv_domain()) | ||
59 | unregister_filesystem(&xenfs_type); | ||
60 | } | ||
61 | |||
62 | module_init(xenfs_init); | ||
63 | module_exit(xenfs_exit); | ||
64 | |||
diff --git a/drivers/xen/xenfs/xenbus.c b/drivers/xen/xenfs/xenbus.c new file mode 100644 index 000000000000..875a4c59c594 --- /dev/null +++ b/drivers/xen/xenfs/xenbus.c | |||
@@ -0,0 +1,593 @@ | |||
1 | /* | ||
2 | * Driver giving user-space access to the kernel's xenbus connection | ||
3 | * to xenstore. | ||
4 | * | ||
5 | * Copyright (c) 2005, Christian Limpach | ||
6 | * Copyright (c) 2005, Rusty Russell, IBM Corporation | ||
7 | * | ||
8 | * This program is free software; you can redistribute it and/or | ||
9 | * modify it under the terms of the GNU General Public License version 2 | ||
10 | * as published by the Free Software Foundation; or, when distributed | ||
11 | * separately from the Linux kernel or incorporated into other | ||
12 | * software packages, subject to the following license: | ||
13 | * | ||
14 | * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
15 | * of this source file (the "Software"), to deal in the Software without | ||
16 | * restriction, including without limitation the rights to use, copy, modify, | ||
17 | * merge, publish, distribute, sublicense, and/or sell copies of the Software, | ||
18 | * and to permit persons to whom the Software is furnished to do so, subject to | ||
19 | * the following conditions: | ||
20 | * | ||
21 | * The above copyright notice and this permission notice shall be included in | ||
22 | * all copies or substantial portions of the Software. | ||
23 | * | ||
24 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
25 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
26 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
27 | * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
28 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
29 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS | ||
30 | * IN THE SOFTWARE. | ||
31 | * | ||
32 | * Changes: | ||
33 | * 2008-10-07 Alex Zeffertt Replaced /proc/xen/xenbus with xenfs filesystem | ||
34 | * and /proc/xen compatibility mount point. | ||
35 | * Turned xenfs into a loadable module. | ||
36 | */ | ||
37 | |||
38 | #include <linux/kernel.h> | ||
39 | #include <linux/errno.h> | ||
40 | #include <linux/uio.h> | ||
41 | #include <linux/notifier.h> | ||
42 | #include <linux/wait.h> | ||
43 | #include <linux/fs.h> | ||
44 | #include <linux/poll.h> | ||
45 | #include <linux/mutex.h> | ||
46 | #include <linux/spinlock.h> | ||
47 | #include <linux/mount.h> | ||
48 | #include <linux/pagemap.h> | ||
49 | #include <linux/uaccess.h> | ||
50 | #include <linux/init.h> | ||
51 | #include <linux/namei.h> | ||
52 | #include <linux/string.h> | ||
53 | |||
54 | #include "xenfs.h" | ||
55 | #include "../xenbus/xenbus_comms.h" | ||
56 | |||
57 | #include <xen/xenbus.h> | ||
58 | #include <asm/xen/hypervisor.h> | ||
59 | |||
60 | /* | ||
61 | * An element of a list of outstanding transactions, for which we're | ||
62 | * still waiting a reply. | ||
63 | */ | ||
64 | struct xenbus_transaction_holder { | ||
65 | struct list_head list; | ||
66 | struct xenbus_transaction handle; | ||
67 | }; | ||
68 | |||
69 | /* | ||
70 | * A buffer of data on the queue. | ||
71 | */ | ||
72 | struct read_buffer { | ||
73 | struct list_head list; | ||
74 | unsigned int cons; | ||
75 | unsigned int len; | ||
76 | char msg[]; | ||
77 | }; | ||
78 | |||
79 | struct xenbus_file_priv { | ||
80 | /* | ||
81 | * msgbuffer_mutex is held while partial requests are built up | ||
82 | * and complete requests are acted on. It therefore protects | ||
83 | * the "transactions" and "watches" lists, and the partial | ||
84 | * request length and buffer. | ||
85 | * | ||
86 | * reply_mutex protects the reply being built up to return to | ||
87 | * usermode. It nests inside msgbuffer_mutex but may be held | ||
88 | * alone during a watch callback. | ||
89 | */ | ||
90 | struct mutex msgbuffer_mutex; | ||
91 | |||
92 | /* In-progress transactions */ | ||
93 | struct list_head transactions; | ||
94 | |||
95 | /* Active watches. */ | ||
96 | struct list_head watches; | ||
97 | |||
98 | /* Partial request. */ | ||
99 | unsigned int len; | ||
100 | union { | ||
101 | struct xsd_sockmsg msg; | ||
102 | char buffer[PAGE_SIZE]; | ||
103 | } u; | ||
104 | |||
105 | /* Response queue. */ | ||
106 | struct mutex reply_mutex; | ||
107 | struct list_head read_buffers; | ||
108 | wait_queue_head_t read_waitq; | ||
109 | |||
110 | }; | ||
111 | |||
112 | /* Read out any raw xenbus messages queued up. */ | ||
113 | static ssize_t xenbus_file_read(struct file *filp, | ||
114 | char __user *ubuf, | ||
115 | size_t len, loff_t *ppos) | ||
116 | { | ||
117 | struct xenbus_file_priv *u = filp->private_data; | ||
118 | struct read_buffer *rb; | ||
119 | unsigned i; | ||
120 | int ret; | ||
121 | |||
122 | mutex_lock(&u->reply_mutex); | ||
123 | while (list_empty(&u->read_buffers)) { | ||
124 | mutex_unlock(&u->reply_mutex); | ||
125 | ret = wait_event_interruptible(u->read_waitq, | ||
126 | !list_empty(&u->read_buffers)); | ||
127 | if (ret) | ||
128 | return ret; | ||
129 | mutex_lock(&u->reply_mutex); | ||
130 | } | ||
131 | |||
132 | rb = list_entry(u->read_buffers.next, struct read_buffer, list); | ||
133 | i = 0; | ||
134 | while (i < len) { | ||
135 | unsigned sz = min((unsigned)len - i, rb->len - rb->cons); | ||
136 | |||
137 | ret = copy_to_user(ubuf + i, &rb->msg[rb->cons], sz); | ||
138 | |||
139 | i += sz - ret; | ||
140 | rb->cons += sz - ret; | ||
141 | |||
142 | if (ret != sz) { | ||
143 | if (i == 0) | ||
144 | i = -EFAULT; | ||
145 | goto out; | ||
146 | } | ||
147 | |||
148 | /* Clear out buffer if it has been consumed */ | ||
149 | if (rb->cons == rb->len) { | ||
150 | list_del(&rb->list); | ||
151 | kfree(rb); | ||
152 | if (list_empty(&u->read_buffers)) | ||
153 | break; | ||
154 | rb = list_entry(u->read_buffers.next, | ||
155 | struct read_buffer, list); | ||
156 | } | ||
157 | } | ||
158 | |||
159 | out: | ||
160 | mutex_unlock(&u->reply_mutex); | ||
161 | return i; | ||
162 | } | ||
163 | |||
164 | /* | ||
165 | * Add a buffer to the queue. Caller must hold the appropriate lock | ||
166 | * if the queue is not local. (Commonly the caller will build up | ||
167 | * multiple queued buffers on a temporary local list, and then add it | ||
168 | * to the appropriate list under lock once all the buffers have een | ||
169 | * successfully allocated.) | ||
170 | */ | ||
171 | static int queue_reply(struct list_head *queue, const void *data, size_t len) | ||
172 | { | ||
173 | struct read_buffer *rb; | ||
174 | |||
175 | if (len == 0) | ||
176 | return 0; | ||
177 | |||
178 | rb = kmalloc(sizeof(*rb) + len, GFP_KERNEL); | ||
179 | if (rb == NULL) | ||
180 | return -ENOMEM; | ||
181 | |||
182 | rb->cons = 0; | ||
183 | rb->len = len; | ||
184 | |||
185 | memcpy(rb->msg, data, len); | ||
186 | |||
187 | list_add_tail(&rb->list, queue); | ||
188 | return 0; | ||
189 | } | ||
190 | |||
191 | /* | ||
192 | * Free all the read_buffer s on a list. | ||
193 | * Caller must have sole reference to list. | ||
194 | */ | ||
195 | static void queue_cleanup(struct list_head *list) | ||
196 | { | ||
197 | struct read_buffer *rb; | ||
198 | |||
199 | while (!list_empty(list)) { | ||
200 | rb = list_entry(list->next, struct read_buffer, list); | ||
201 | list_del(list->next); | ||
202 | kfree(rb); | ||
203 | } | ||
204 | } | ||
205 | |||
206 | struct watch_adapter { | ||
207 | struct list_head list; | ||
208 | struct xenbus_watch watch; | ||
209 | struct xenbus_file_priv *dev_data; | ||
210 | char *token; | ||
211 | }; | ||
212 | |||
213 | static void free_watch_adapter(struct watch_adapter *watch) | ||
214 | { | ||
215 | kfree(watch->watch.node); | ||
216 | kfree(watch->token); | ||
217 | kfree(watch); | ||
218 | } | ||
219 | |||
220 | static struct watch_adapter *alloc_watch_adapter(const char *path, | ||
221 | const char *token) | ||
222 | { | ||
223 | struct watch_adapter *watch; | ||
224 | |||
225 | watch = kzalloc(sizeof(*watch), GFP_KERNEL); | ||
226 | if (watch == NULL) | ||
227 | goto out_fail; | ||
228 | |||
229 | watch->watch.node = kstrdup(path, GFP_KERNEL); | ||
230 | if (watch->watch.node == NULL) | ||
231 | goto out_free; | ||
232 | |||
233 | watch->token = kstrdup(token, GFP_KERNEL); | ||
234 | if (watch->token == NULL) | ||
235 | goto out_free; | ||
236 | |||
237 | return watch; | ||
238 | |||
239 | out_free: | ||
240 | free_watch_adapter(watch); | ||
241 | |||
242 | out_fail: | ||
243 | return NULL; | ||
244 | } | ||
245 | |||
246 | static void watch_fired(struct xenbus_watch *watch, | ||
247 | const char **vec, | ||
248 | unsigned int len) | ||
249 | { | ||
250 | struct watch_adapter *adap; | ||
251 | struct xsd_sockmsg hdr; | ||
252 | const char *path, *token; | ||
253 | int path_len, tok_len, body_len, data_len = 0; | ||
254 | int ret; | ||
255 | LIST_HEAD(staging_q); | ||
256 | |||
257 | adap = container_of(watch, struct watch_adapter, watch); | ||
258 | |||
259 | path = vec[XS_WATCH_PATH]; | ||
260 | token = adap->token; | ||
261 | |||
262 | path_len = strlen(path) + 1; | ||
263 | tok_len = strlen(token) + 1; | ||
264 | if (len > 2) | ||
265 | data_len = vec[len] - vec[2] + 1; | ||
266 | body_len = path_len + tok_len + data_len; | ||
267 | |||
268 | hdr.type = XS_WATCH_EVENT; | ||
269 | hdr.len = body_len; | ||
270 | |||
271 | mutex_lock(&adap->dev_data->reply_mutex); | ||
272 | |||
273 | ret = queue_reply(&staging_q, &hdr, sizeof(hdr)); | ||
274 | if (!ret) | ||
275 | ret = queue_reply(&staging_q, path, path_len); | ||
276 | if (!ret) | ||
277 | ret = queue_reply(&staging_q, token, tok_len); | ||
278 | if (!ret && len > 2) | ||
279 | ret = queue_reply(&staging_q, vec[2], data_len); | ||
280 | |||
281 | if (!ret) { | ||
282 | /* success: pass reply list onto watcher */ | ||
283 | list_splice_tail(&staging_q, &adap->dev_data->read_buffers); | ||
284 | wake_up(&adap->dev_data->read_waitq); | ||
285 | } else | ||
286 | queue_cleanup(&staging_q); | ||
287 | |||
288 | mutex_unlock(&adap->dev_data->reply_mutex); | ||
289 | } | ||
290 | |||
291 | static int xenbus_write_transaction(unsigned msg_type, | ||
292 | struct xenbus_file_priv *u) | ||
293 | { | ||
294 | int rc, ret; | ||
295 | void *reply; | ||
296 | struct xenbus_transaction_holder *trans = NULL; | ||
297 | LIST_HEAD(staging_q); | ||
298 | |||
299 | if (msg_type == XS_TRANSACTION_START) { | ||
300 | trans = kmalloc(sizeof(*trans), GFP_KERNEL); | ||
301 | if (!trans) { | ||
302 | rc = -ENOMEM; | ||
303 | goto out; | ||
304 | } | ||
305 | } | ||
306 | |||
307 | reply = xenbus_dev_request_and_reply(&u->u.msg); | ||
308 | if (IS_ERR(reply)) { | ||
309 | kfree(trans); | ||
310 | rc = PTR_ERR(reply); | ||
311 | goto out; | ||
312 | } | ||
313 | |||
314 | if (msg_type == XS_TRANSACTION_START) { | ||
315 | trans->handle.id = simple_strtoul(reply, NULL, 0); | ||
316 | |||
317 | list_add(&trans->list, &u->transactions); | ||
318 | } else if (msg_type == XS_TRANSACTION_END) { | ||
319 | list_for_each_entry(trans, &u->transactions, list) | ||
320 | if (trans->handle.id == u->u.msg.tx_id) | ||
321 | break; | ||
322 | BUG_ON(&trans->list == &u->transactions); | ||
323 | list_del(&trans->list); | ||
324 | |||
325 | kfree(trans); | ||
326 | } | ||
327 | |||
328 | mutex_lock(&u->reply_mutex); | ||
329 | ret = queue_reply(&staging_q, &u->u.msg, sizeof(u->u.msg)); | ||
330 | if (!ret) | ||
331 | ret = queue_reply(&staging_q, reply, u->u.msg.len); | ||
332 | if (!ret) { | ||
333 | list_splice_tail(&staging_q, &u->read_buffers); | ||
334 | wake_up(&u->read_waitq); | ||
335 | } else { | ||
336 | queue_cleanup(&staging_q); | ||
337 | rc = ret; | ||
338 | } | ||
339 | mutex_unlock(&u->reply_mutex); | ||
340 | |||
341 | kfree(reply); | ||
342 | |||
343 | out: | ||
344 | return rc; | ||
345 | } | ||
346 | |||
347 | static int xenbus_write_watch(unsigned msg_type, struct xenbus_file_priv *u) | ||
348 | { | ||
349 | struct watch_adapter *watch, *tmp_watch; | ||
350 | char *path, *token; | ||
351 | int err, rc; | ||
352 | LIST_HEAD(staging_q); | ||
353 | |||
354 | path = u->u.buffer + sizeof(u->u.msg); | ||
355 | token = memchr(path, 0, u->u.msg.len); | ||
356 | if (token == NULL) { | ||
357 | rc = -EILSEQ; | ||
358 | goto out; | ||
359 | } | ||
360 | token++; | ||
361 | |||
362 | if (msg_type == XS_WATCH) { | ||
363 | watch = alloc_watch_adapter(path, token); | ||
364 | if (watch == NULL) { | ||
365 | rc = -ENOMEM; | ||
366 | goto out; | ||
367 | } | ||
368 | |||
369 | watch->watch.callback = watch_fired; | ||
370 | watch->dev_data = u; | ||
371 | |||
372 | err = register_xenbus_watch(&watch->watch); | ||
373 | if (err) { | ||
374 | free_watch_adapter(watch); | ||
375 | rc = err; | ||
376 | goto out; | ||
377 | } | ||
378 | list_add(&watch->list, &u->watches); | ||
379 | } else { | ||
380 | list_for_each_entry_safe(watch, tmp_watch, &u->watches, list) { | ||
381 | if (!strcmp(watch->token, token) && | ||
382 | !strcmp(watch->watch.node, path)) { | ||
383 | unregister_xenbus_watch(&watch->watch); | ||
384 | list_del(&watch->list); | ||
385 | free_watch_adapter(watch); | ||
386 | break; | ||
387 | } | ||
388 | } | ||
389 | } | ||
390 | |||
391 | /* Success. Synthesize a reply to say all is OK. */ | ||
392 | { | ||
393 | struct { | ||
394 | struct xsd_sockmsg hdr; | ||
395 | char body[3]; | ||
396 | } __packed reply = { | ||
397 | { | ||
398 | .type = msg_type, | ||
399 | .len = sizeof(reply.body) | ||
400 | }, | ||
401 | "OK" | ||
402 | }; | ||
403 | |||
404 | mutex_lock(&u->reply_mutex); | ||
405 | rc = queue_reply(&u->read_buffers, &reply, sizeof(reply)); | ||
406 | mutex_unlock(&u->reply_mutex); | ||
407 | } | ||
408 | |||
409 | out: | ||
410 | return rc; | ||
411 | } | ||
412 | |||
413 | static ssize_t xenbus_file_write(struct file *filp, | ||
414 | const char __user *ubuf, | ||
415 | size_t len, loff_t *ppos) | ||
416 | { | ||
417 | struct xenbus_file_priv *u = filp->private_data; | ||
418 | uint32_t msg_type; | ||
419 | int rc = len; | ||
420 | int ret; | ||
421 | LIST_HEAD(staging_q); | ||
422 | |||
423 | /* | ||
424 | * We're expecting usermode to be writing properly formed | ||
425 | * xenbus messages. If they write an incomplete message we | ||
426 | * buffer it up. Once it is complete, we act on it. | ||
427 | */ | ||
428 | |||
429 | /* | ||
430 | * Make sure concurrent writers can't stomp all over each | ||
431 | * other's messages and make a mess of our partial message | ||
432 | * buffer. We don't make any attemppt to stop multiple | ||
433 | * writers from making a mess of each other's incomplete | ||
434 | * messages; we're just trying to guarantee our own internal | ||
435 | * consistency and make sure that single writes are handled | ||
436 | * atomically. | ||
437 | */ | ||
438 | mutex_lock(&u->msgbuffer_mutex); | ||
439 | |||
440 | /* Get this out of the way early to avoid confusion */ | ||
441 | if (len == 0) | ||
442 | goto out; | ||
443 | |||
444 | /* Can't write a xenbus message larger we can buffer */ | ||
445 | if ((len + u->len) > sizeof(u->u.buffer)) { | ||
446 | /* On error, dump existing buffer */ | ||
447 | u->len = 0; | ||
448 | rc = -EINVAL; | ||
449 | goto out; | ||
450 | } | ||
451 | |||
452 | ret = copy_from_user(u->u.buffer + u->len, ubuf, len); | ||
453 | |||
454 | if (ret == len) { | ||
455 | rc = -EFAULT; | ||
456 | goto out; | ||
457 | } | ||
458 | |||
459 | /* Deal with a partial copy. */ | ||
460 | len -= ret; | ||
461 | rc = len; | ||
462 | |||
463 | u->len += len; | ||
464 | |||
465 | /* Return if we haven't got a full message yet */ | ||
466 | if (u->len < sizeof(u->u.msg)) | ||
467 | goto out; /* not even the header yet */ | ||
468 | |||
469 | /* If we're expecting a message that's larger than we can | ||
470 | possibly send, dump what we have and return an error. */ | ||
471 | if ((sizeof(u->u.msg) + u->u.msg.len) > sizeof(u->u.buffer)) { | ||
472 | rc = -E2BIG; | ||
473 | u->len = 0; | ||
474 | goto out; | ||
475 | } | ||
476 | |||
477 | if (u->len < (sizeof(u->u.msg) + u->u.msg.len)) | ||
478 | goto out; /* incomplete data portion */ | ||
479 | |||
480 | /* | ||
481 | * OK, now we have a complete message. Do something with it. | ||
482 | */ | ||
483 | |||
484 | msg_type = u->u.msg.type; | ||
485 | |||
486 | switch (msg_type) { | ||
487 | case XS_TRANSACTION_START: | ||
488 | case XS_TRANSACTION_END: | ||
489 | case XS_DIRECTORY: | ||
490 | case XS_READ: | ||
491 | case XS_GET_PERMS: | ||
492 | case XS_RELEASE: | ||
493 | case XS_GET_DOMAIN_PATH: | ||
494 | case XS_WRITE: | ||
495 | case XS_MKDIR: | ||
496 | case XS_RM: | ||
497 | case XS_SET_PERMS: | ||
498 | /* Send out a transaction */ | ||
499 | ret = xenbus_write_transaction(msg_type, u); | ||
500 | break; | ||
501 | |||
502 | case XS_WATCH: | ||
503 | case XS_UNWATCH: | ||
504 | /* (Un)Ask for some path to be watched for changes */ | ||
505 | ret = xenbus_write_watch(msg_type, u); | ||
506 | break; | ||
507 | |||
508 | default: | ||
509 | ret = -EINVAL; | ||
510 | break; | ||
511 | } | ||
512 | if (ret != 0) | ||
513 | rc = ret; | ||
514 | |||
515 | /* Buffered message consumed */ | ||
516 | u->len = 0; | ||
517 | |||
518 | out: | ||
519 | mutex_unlock(&u->msgbuffer_mutex); | ||
520 | return rc; | ||
521 | } | ||
522 | |||
523 | static int xenbus_file_open(struct inode *inode, struct file *filp) | ||
524 | { | ||
525 | struct xenbus_file_priv *u; | ||
526 | |||
527 | if (xen_store_evtchn == 0) | ||
528 | return -ENOENT; | ||
529 | |||
530 | nonseekable_open(inode, filp); | ||
531 | |||
532 | u = kzalloc(sizeof(*u), GFP_KERNEL); | ||
533 | if (u == NULL) | ||
534 | return -ENOMEM; | ||
535 | |||
536 | INIT_LIST_HEAD(&u->transactions); | ||
537 | INIT_LIST_HEAD(&u->watches); | ||
538 | INIT_LIST_HEAD(&u->read_buffers); | ||
539 | init_waitqueue_head(&u->read_waitq); | ||
540 | |||
541 | mutex_init(&u->reply_mutex); | ||
542 | mutex_init(&u->msgbuffer_mutex); | ||
543 | |||
544 | filp->private_data = u; | ||
545 | |||
546 | return 0; | ||
547 | } | ||
548 | |||
549 | static int xenbus_file_release(struct inode *inode, struct file *filp) | ||
550 | { | ||
551 | struct xenbus_file_priv *u = filp->private_data; | ||
552 | struct xenbus_transaction_holder *trans, *tmp; | ||
553 | struct watch_adapter *watch, *tmp_watch; | ||
554 | |||
555 | /* | ||
556 | * No need for locking here because there are no other users, | ||
557 | * by definition. | ||
558 | */ | ||
559 | |||
560 | list_for_each_entry_safe(trans, tmp, &u->transactions, list) { | ||
561 | xenbus_transaction_end(trans->handle, 1); | ||
562 | list_del(&trans->list); | ||
563 | kfree(trans); | ||
564 | } | ||
565 | |||
566 | list_for_each_entry_safe(watch, tmp_watch, &u->watches, list) { | ||
567 | unregister_xenbus_watch(&watch->watch); | ||
568 | list_del(&watch->list); | ||
569 | free_watch_adapter(watch); | ||
570 | } | ||
571 | |||
572 | kfree(u); | ||
573 | |||
574 | return 0; | ||
575 | } | ||
576 | |||
577 | static unsigned int xenbus_file_poll(struct file *file, poll_table *wait) | ||
578 | { | ||
579 | struct xenbus_file_priv *u = file->private_data; | ||
580 | |||
581 | poll_wait(file, &u->read_waitq, wait); | ||
582 | if (!list_empty(&u->read_buffers)) | ||
583 | return POLLIN | POLLRDNORM; | ||
584 | return 0; | ||
585 | } | ||
586 | |||
587 | const struct file_operations xenbus_file_ops = { | ||
588 | .read = xenbus_file_read, | ||
589 | .write = xenbus_file_write, | ||
590 | .open = xenbus_file_open, | ||
591 | .release = xenbus_file_release, | ||
592 | .poll = xenbus_file_poll, | ||
593 | }; | ||
diff --git a/drivers/xen/xenfs/xenfs.h b/drivers/xen/xenfs/xenfs.h new file mode 100644 index 000000000000..51f08b2d0bf1 --- /dev/null +++ b/drivers/xen/xenfs/xenfs.h | |||
@@ -0,0 +1,6 @@ | |||
1 | #ifndef _XENFS_XENBUS_H | ||
2 | #define _XENFS_XENBUS_H | ||
3 | |||
4 | extern const struct file_operations xenbus_file_ops; | ||
5 | |||
6 | #endif /* _XENFS_XENBUS_H */ | ||
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index c41fa2af7677..e3ff2b9e602f 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c | |||
@@ -152,8 +152,10 @@ create_elf_tables(struct linux_binprm *bprm, struct elfhdr *exec, | |||
152 | elf_addr_t __user *sp; | 152 | elf_addr_t __user *sp; |
153 | elf_addr_t __user *u_platform; | 153 | elf_addr_t __user *u_platform; |
154 | elf_addr_t __user *u_base_platform; | 154 | elf_addr_t __user *u_base_platform; |
155 | elf_addr_t __user *u_rand_bytes; | ||
155 | const char *k_platform = ELF_PLATFORM; | 156 | const char *k_platform = ELF_PLATFORM; |
156 | const char *k_base_platform = ELF_BASE_PLATFORM; | 157 | const char *k_base_platform = ELF_BASE_PLATFORM; |
158 | unsigned char k_rand_bytes[16]; | ||
157 | int items; | 159 | int items; |
158 | elf_addr_t *elf_info; | 160 | elf_addr_t *elf_info; |
159 | int ei_index = 0; | 161 | int ei_index = 0; |
@@ -196,6 +198,15 @@ create_elf_tables(struct linux_binprm *bprm, struct elfhdr *exec, | |||
196 | return -EFAULT; | 198 | return -EFAULT; |
197 | } | 199 | } |
198 | 200 | ||
201 | /* | ||
202 | * Generate 16 random bytes for userspace PRNG seeding. | ||
203 | */ | ||
204 | get_random_bytes(k_rand_bytes, sizeof(k_rand_bytes)); | ||
205 | u_rand_bytes = (elf_addr_t __user *) | ||
206 | STACK_ALLOC(p, sizeof(k_rand_bytes)); | ||
207 | if (__copy_to_user(u_rand_bytes, k_rand_bytes, sizeof(k_rand_bytes))) | ||
208 | return -EFAULT; | ||
209 | |||
199 | /* Create the ELF interpreter info */ | 210 | /* Create the ELF interpreter info */ |
200 | elf_info = (elf_addr_t *)current->mm->saved_auxv; | 211 | elf_info = (elf_addr_t *)current->mm->saved_auxv; |
201 | /* update AT_VECTOR_SIZE_BASE if the number of NEW_AUX_ENT() changes */ | 212 | /* update AT_VECTOR_SIZE_BASE if the number of NEW_AUX_ENT() changes */ |
@@ -228,6 +239,7 @@ create_elf_tables(struct linux_binprm *bprm, struct elfhdr *exec, | |||
228 | NEW_AUX_ENT(AT_GID, cred->gid); | 239 | NEW_AUX_ENT(AT_GID, cred->gid); |
229 | NEW_AUX_ENT(AT_EGID, cred->egid); | 240 | NEW_AUX_ENT(AT_EGID, cred->egid); |
230 | NEW_AUX_ENT(AT_SECURE, security_bprm_secureexec(bprm)); | 241 | NEW_AUX_ENT(AT_SECURE, security_bprm_secureexec(bprm)); |
242 | NEW_AUX_ENT(AT_RANDOM, (elf_addr_t)(unsigned long)u_rand_bytes); | ||
231 | NEW_AUX_ENT(AT_EXECFN, bprm->exec); | 243 | NEW_AUX_ENT(AT_EXECFN, bprm->exec); |
232 | if (k_platform) { | 244 | if (k_platform) { |
233 | NEW_AUX_ENT(AT_PLATFORM, | 245 | NEW_AUX_ENT(AT_PLATFORM, |
diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c index 81b7771c6465..43c96ce29614 100644 --- a/fs/coda/sysctl.c +++ b/fs/coda/sysctl.c | |||
@@ -11,7 +11,9 @@ | |||
11 | 11 | ||
12 | #include "coda_int.h" | 12 | #include "coda_int.h" |
13 | 13 | ||
14 | #ifdef CONFIG_SYSCTL | ||
14 | static struct ctl_table_header *fs_table_header; | 15 | static struct ctl_table_header *fs_table_header; |
16 | #endif | ||
15 | 17 | ||
16 | static ctl_table coda_table[] = { | 18 | static ctl_table coda_table[] = { |
17 | { | 19 | { |
@@ -41,6 +43,7 @@ static ctl_table coda_table[] = { | |||
41 | {} | 43 | {} |
42 | }; | 44 | }; |
43 | 45 | ||
46 | #ifdef CONFIG_SYSCTL | ||
44 | static ctl_table fs_table[] = { | 47 | static ctl_table fs_table[] = { |
45 | { | 48 | { |
46 | .ctl_name = CTL_UNNUMBERED, | 49 | .ctl_name = CTL_UNNUMBERED, |
@@ -50,7 +53,7 @@ static ctl_table fs_table[] = { | |||
50 | }, | 53 | }, |
51 | {} | 54 | {} |
52 | }; | 55 | }; |
53 | 56 | #endif | |
54 | 57 | ||
55 | void coda_sysctl_init(void) | 58 | void coda_sysctl_init(void) |
56 | { | 59 | { |
diff --git a/fs/dcache.c b/fs/dcache.c index e88c23b85a32..4547f66884a0 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
@@ -1567,10 +1567,6 @@ void d_rehash(struct dentry * entry) | |||
1567 | spin_unlock(&dcache_lock); | 1567 | spin_unlock(&dcache_lock); |
1568 | } | 1568 | } |
1569 | 1569 | ||
1570 | #define do_switch(x,y) do { \ | ||
1571 | __typeof__ (x) __tmp = x; \ | ||
1572 | x = y; y = __tmp; } while (0) | ||
1573 | |||
1574 | /* | 1570 | /* |
1575 | * When switching names, the actual string doesn't strictly have to | 1571 | * When switching names, the actual string doesn't strictly have to |
1576 | * be preserved in the target - because we're dropping the target | 1572 | * be preserved in the target - because we're dropping the target |
@@ -1589,7 +1585,7 @@ static void switch_names(struct dentry *dentry, struct dentry *target) | |||
1589 | /* | 1585 | /* |
1590 | * Both external: swap the pointers | 1586 | * Both external: swap the pointers |
1591 | */ | 1587 | */ |
1592 | do_switch(target->d_name.name, dentry->d_name.name); | 1588 | swap(target->d_name.name, dentry->d_name.name); |
1593 | } else { | 1589 | } else { |
1594 | /* | 1590 | /* |
1595 | * dentry:internal, target:external. Steal target's | 1591 | * dentry:internal, target:external. Steal target's |
@@ -1620,7 +1616,7 @@ static void switch_names(struct dentry *dentry, struct dentry *target) | |||
1620 | return; | 1616 | return; |
1621 | } | 1617 | } |
1622 | } | 1618 | } |
1623 | do_switch(dentry->d_name.len, target->d_name.len); | 1619 | swap(dentry->d_name.len, target->d_name.len); |
1624 | } | 1620 | } |
1625 | 1621 | ||
1626 | /* | 1622 | /* |
@@ -1680,7 +1676,7 @@ already_unhashed: | |||
1680 | 1676 | ||
1681 | /* Switch the names.. */ | 1677 | /* Switch the names.. */ |
1682 | switch_names(dentry, target); | 1678 | switch_names(dentry, target); |
1683 | do_switch(dentry->d_name.hash, target->d_name.hash); | 1679 | swap(dentry->d_name.hash, target->d_name.hash); |
1684 | 1680 | ||
1685 | /* ... and switch the parents */ | 1681 | /* ... and switch the parents */ |
1686 | if (IS_ROOT(dentry)) { | 1682 | if (IS_ROOT(dentry)) { |
@@ -1688,7 +1684,7 @@ already_unhashed: | |||
1688 | target->d_parent = target; | 1684 | target->d_parent = target; |
1689 | INIT_LIST_HEAD(&target->d_u.d_child); | 1685 | INIT_LIST_HEAD(&target->d_u.d_child); |
1690 | } else { | 1686 | } else { |
1691 | do_switch(dentry->d_parent, target->d_parent); | 1687 | swap(dentry->d_parent, target->d_parent); |
1692 | 1688 | ||
1693 | /* And add them back to the (new) parent lists */ | 1689 | /* And add them back to the (new) parent lists */ |
1694 | list_add(&target->d_u.d_child, &target->d_parent->d_subdirs); | 1690 | list_add(&target->d_u.d_child, &target->d_parent->d_subdirs); |
@@ -1789,7 +1785,7 @@ static void __d_materialise_dentry(struct dentry *dentry, struct dentry *anon) | |||
1789 | struct dentry *dparent, *aparent; | 1785 | struct dentry *dparent, *aparent; |
1790 | 1786 | ||
1791 | switch_names(dentry, anon); | 1787 | switch_names(dentry, anon); |
1792 | do_switch(dentry->d_name.hash, anon->d_name.hash); | 1788 | swap(dentry->d_name.hash, anon->d_name.hash); |
1793 | 1789 | ||
1794 | dparent = dentry->d_parent; | 1790 | dparent = dentry->d_parent; |
1795 | aparent = anon->d_parent; | 1791 | aparent = anon->d_parent; |
diff --git a/fs/dquot.c b/fs/dquot.c index 61bfff64e5af..48c0571f831d 100644 --- a/fs/dquot.c +++ b/fs/dquot.c | |||
@@ -2090,10 +2090,12 @@ static int do_set_dqblk(struct dquot *dquot, struct if_dqblk *di) | |||
2090 | } | 2090 | } |
2091 | if (di->dqb_valid & QIF_BTIME) { | 2091 | if (di->dqb_valid & QIF_BTIME) { |
2092 | dm->dqb_btime = di->dqb_btime; | 2092 | dm->dqb_btime = di->dqb_btime; |
2093 | check_blim = 1; | ||
2093 | __set_bit(DQ_LASTSET_B + QIF_BTIME_B, &dquot->dq_flags); | 2094 | __set_bit(DQ_LASTSET_B + QIF_BTIME_B, &dquot->dq_flags); |
2094 | } | 2095 | } |
2095 | if (di->dqb_valid & QIF_ITIME) { | 2096 | if (di->dqb_valid & QIF_ITIME) { |
2096 | dm->dqb_itime = di->dqb_itime; | 2097 | dm->dqb_itime = di->dqb_itime; |
2098 | check_ilim = 1; | ||
2097 | __set_bit(DQ_LASTSET_B + QIF_ITIME_B, &dquot->dq_flags); | 2099 | __set_bit(DQ_LASTSET_B + QIF_ITIME_B, &dquot->dq_flags); |
2098 | } | 2100 | } |
2099 | 2101 | ||
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c index c454d5db28a5..66321a877e74 100644 --- a/fs/ext2/ialloc.c +++ b/fs/ext2/ialloc.c | |||
@@ -565,12 +565,8 @@ got: | |||
565 | inode->i_blocks = 0; | 565 | inode->i_blocks = 0; |
566 | inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; | 566 | inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; |
567 | memset(ei->i_data, 0, sizeof(ei->i_data)); | 567 | memset(ei->i_data, 0, sizeof(ei->i_data)); |
568 | ei->i_flags = EXT2_I(dir)->i_flags & ~EXT2_BTREE_FL; | 568 | ei->i_flags = |
569 | if (S_ISLNK(mode)) | 569 | ext2_mask_flags(mode, EXT2_I(dir)->i_flags & EXT2_FL_INHERITED); |
570 | ei->i_flags &= ~(EXT2_IMMUTABLE_FL|EXT2_APPEND_FL); | ||
571 | /* dirsync is only applied to directories */ | ||
572 | if (!S_ISDIR(mode)) | ||
573 | ei->i_flags &= ~EXT2_DIRSYNC_FL; | ||
574 | ei->i_faddr = 0; | 570 | ei->i_faddr = 0; |
575 | ei->i_frag_no = 0; | 571 | ei->i_frag_no = 0; |
576 | ei->i_frag_size = 0; | 572 | ei->i_frag_size = 0; |
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 02b39a5deb74..23fff2f87783 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c | |||
@@ -498,8 +498,6 @@ static int ext2_alloc_branch(struct inode *inode, | |||
498 | * ext2_splice_branch - splice the allocated branch onto inode. | 498 | * ext2_splice_branch - splice the allocated branch onto inode. |
499 | * @inode: owner | 499 | * @inode: owner |
500 | * @block: (logical) number of block we are adding | 500 | * @block: (logical) number of block we are adding |
501 | * @chain: chain of indirect blocks (with a missing link - see | ||
502 | * ext2_alloc_branch) | ||
503 | * @where: location of missing link | 501 | * @where: location of missing link |
504 | * @num: number of indirect blocks we are adding | 502 | * @num: number of indirect blocks we are adding |
505 | * @blks: number of direct blocks we are adding | 503 | * @blks: number of direct blocks we are adding |
diff --git a/fs/ext2/ioctl.c b/fs/ext2/ioctl.c index de876fa793e1..7cb4badef927 100644 --- a/fs/ext2/ioctl.c +++ b/fs/ext2/ioctl.c | |||
@@ -50,8 +50,7 @@ long ext2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
50 | goto setflags_out; | 50 | goto setflags_out; |
51 | } | 51 | } |
52 | 52 | ||
53 | if (!S_ISDIR(inode->i_mode)) | 53 | flags = ext2_mask_flags(inode->i_mode, flags); |
54 | flags &= ~EXT2_DIRSYNC_FL; | ||
55 | 54 | ||
56 | mutex_lock(&inode->i_mutex); | 55 | mutex_lock(&inode->i_mutex); |
57 | /* Is it quota file? Do not allow user to mess with it */ | 56 | /* Is it quota file? Do not allow user to mess with it */ |
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 647cd888ac87..da8bdeaa2e6d 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c | |||
@@ -132,6 +132,7 @@ static void ext2_put_super (struct super_block * sb) | |||
132 | percpu_counter_destroy(&sbi->s_dirs_counter); | 132 | percpu_counter_destroy(&sbi->s_dirs_counter); |
133 | brelse (sbi->s_sbh); | 133 | brelse (sbi->s_sbh); |
134 | sb->s_fs_info = NULL; | 134 | sb->s_fs_info = NULL; |
135 | kfree(sbi->s_blockgroup_lock); | ||
135 | kfree(sbi); | 136 | kfree(sbi); |
136 | 137 | ||
137 | return; | 138 | return; |
@@ -756,6 +757,13 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
756 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); | 757 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); |
757 | if (!sbi) | 758 | if (!sbi) |
758 | return -ENOMEM; | 759 | return -ENOMEM; |
760 | |||
761 | sbi->s_blockgroup_lock = | ||
762 | kzalloc(sizeof(struct blockgroup_lock), GFP_KERNEL); | ||
763 | if (!sbi->s_blockgroup_lock) { | ||
764 | kfree(sbi); | ||
765 | return -ENOMEM; | ||
766 | } | ||
759 | sb->s_fs_info = sbi; | 767 | sb->s_fs_info = sbi; |
760 | sbi->s_sb_block = sb_block; | 768 | sbi->s_sb_block = sb_block; |
761 | 769 | ||
@@ -983,7 +991,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) | |||
983 | printk ("EXT2-fs: not enough memory\n"); | 991 | printk ("EXT2-fs: not enough memory\n"); |
984 | goto failed_mount; | 992 | goto failed_mount; |
985 | } | 993 | } |
986 | bgl_lock_init(&sbi->s_blockgroup_lock); | 994 | bgl_lock_init(sbi->s_blockgroup_lock); |
987 | sbi->s_debts = kcalloc(sbi->s_groups_count, sizeof(*sbi->s_debts), GFP_KERNEL); | 995 | sbi->s_debts = kcalloc(sbi->s_groups_count, sizeof(*sbi->s_debts), GFP_KERNEL); |
988 | if (!sbi->s_debts) { | 996 | if (!sbi->s_debts) { |
989 | printk ("EXT2-fs: not enough memory\n"); | 997 | printk ("EXT2-fs: not enough memory\n"); |
diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c index 5655fbcbd11f..8de6c720e510 100644 --- a/fs/ext3/ialloc.c +++ b/fs/ext3/ialloc.c | |||
@@ -559,12 +559,8 @@ got: | |||
559 | ei->i_dir_start_lookup = 0; | 559 | ei->i_dir_start_lookup = 0; |
560 | ei->i_disksize = 0; | 560 | ei->i_disksize = 0; |
561 | 561 | ||
562 | ei->i_flags = EXT3_I(dir)->i_flags & ~EXT3_INDEX_FL; | 562 | ei->i_flags = |
563 | if (S_ISLNK(mode)) | 563 | ext3_mask_flags(mode, EXT3_I(dir)->i_flags & EXT3_FL_INHERITED); |
564 | ei->i_flags &= ~(EXT3_IMMUTABLE_FL|EXT3_APPEND_FL); | ||
565 | /* dirsync only applies to directories */ | ||
566 | if (!S_ISDIR(mode)) | ||
567 | ei->i_flags &= ~EXT3_DIRSYNC_FL; | ||
568 | #ifdef EXT3_FRAGMENTS | 564 | #ifdef EXT3_FRAGMENTS |
569 | ei->i_faddr = 0; | 565 | ei->i_faddr = 0; |
570 | ei->i_frag_no = 0; | 566 | ei->i_frag_no = 0; |
diff --git a/fs/ext3/ioctl.c b/fs/ext3/ioctl.c index b7394d05ee8e..5e86ce9a86e0 100644 --- a/fs/ext3/ioctl.c +++ b/fs/ext3/ioctl.c | |||
@@ -53,8 +53,7 @@ int ext3_ioctl (struct inode * inode, struct file * filp, unsigned int cmd, | |||
53 | goto flags_out; | 53 | goto flags_out; |
54 | } | 54 | } |
55 | 55 | ||
56 | if (!S_ISDIR(inode->i_mode)) | 56 | flags = ext3_mask_flags(inode->i_mode, flags); |
57 | flags &= ~EXT3_DIRSYNC_FL; | ||
58 | 57 | ||
59 | mutex_lock(&inode->i_mutex); | 58 | mutex_lock(&inode->i_mutex); |
60 | /* Is it quota file? Do not allow user to mess with it */ | 59 | /* Is it quota file? Do not allow user to mess with it */ |
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index 1dd2abe6313e..8d6f965e502c 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c | |||
@@ -74,10 +74,6 @@ static struct buffer_head *ext3_append(handle_t *handle, | |||
74 | #define assert(test) J_ASSERT(test) | 74 | #define assert(test) J_ASSERT(test) |
75 | #endif | 75 | #endif |
76 | 76 | ||
77 | #ifndef swap | ||
78 | #define swap(x, y) do { typeof(x) z = x; x = y; y = z; } while (0) | ||
79 | #endif | ||
80 | |||
81 | #ifdef DX_DEBUG | 77 | #ifdef DX_DEBUG |
82 | #define dxtrace(command) command | 78 | #define dxtrace(command) command |
83 | #else | 79 | #else |
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index c22d01467bd1..01c235bc2054 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -439,6 +439,7 @@ static void ext3_put_super (struct super_block * sb) | |||
439 | ext3_blkdev_remove(sbi); | 439 | ext3_blkdev_remove(sbi); |
440 | } | 440 | } |
441 | sb->s_fs_info = NULL; | 441 | sb->s_fs_info = NULL; |
442 | kfree(sbi->s_blockgroup_lock); | ||
442 | kfree(sbi); | 443 | kfree(sbi); |
443 | return; | 444 | return; |
444 | } | 445 | } |
@@ -1546,6 +1547,13 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
1546 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); | 1547 | sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); |
1547 | if (!sbi) | 1548 | if (!sbi) |
1548 | return -ENOMEM; | 1549 | return -ENOMEM; |
1550 | |||
1551 | sbi->s_blockgroup_lock = | ||
1552 | kzalloc(sizeof(struct blockgroup_lock), GFP_KERNEL); | ||
1553 | if (!sbi->s_blockgroup_lock) { | ||
1554 | kfree(sbi); | ||
1555 | return -ENOMEM; | ||
1556 | } | ||
1549 | sb->s_fs_info = sbi; | 1557 | sb->s_fs_info = sbi; |
1550 | sbi->s_mount_opt = 0; | 1558 | sbi->s_mount_opt = 0; |
1551 | sbi->s_resuid = EXT3_DEF_RESUID; | 1559 | sbi->s_resuid = EXT3_DEF_RESUID; |
@@ -1786,7 +1794,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
1786 | goto failed_mount; | 1794 | goto failed_mount; |
1787 | } | 1795 | } |
1788 | 1796 | ||
1789 | bgl_lock_init(&sbi->s_blockgroup_lock); | 1797 | bgl_lock_init(sbi->s_blockgroup_lock); |
1790 | 1798 | ||
1791 | for (i = 0; i < db_count; i++) { | 1799 | for (i = 0; i < db_count; i++) { |
1792 | block = descriptor_loc(sb, logic_sb_block, i); | 1800 | block = descriptor_loc(sb, logic_sb_block, i); |
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index ea2ce3c0ae66..3f54db31cdc2 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c | |||
@@ -2536,7 +2536,7 @@ static int ext4_ext_convert_to_initialized(handle_t *handle, | |||
2536 | */ | 2536 | */ |
2537 | newdepth = ext_depth(inode); | 2537 | newdepth = ext_depth(inode); |
2538 | /* | 2538 | /* |
2539 | * update the extent length after successfull insert of the | 2539 | * update the extent length after successful insert of the |
2540 | * split extent | 2540 | * split extent |
2541 | */ | 2541 | */ |
2542 | orig_ex.ee_len = cpu_to_le16(ee_len - | 2542 | orig_ex.ee_len = cpu_to_le16(ee_len - |
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 9fd2a5e1be4d..4b8d431d7dff 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
@@ -74,10 +74,6 @@ static struct buffer_head *ext4_append(handle_t *handle, | |||
74 | #define assert(test) J_ASSERT(test) | 74 | #define assert(test) J_ASSERT(test) |
75 | #endif | 75 | #endif |
76 | 76 | ||
77 | #ifndef swap | ||
78 | #define swap(x, y) do { typeof(x) z = x; x = y; y = z; } while (0) | ||
79 | #endif | ||
80 | |||
81 | #ifdef DX_DEBUG | 77 | #ifdef DX_DEBUG |
82 | #define dxtrace(command) command | 78 | #define dxtrace(command) command |
83 | #else | 79 | #else |
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c index 25719d902c51..3fbffb1ea714 100644 --- a/fs/jbd/commit.c +++ b/fs/jbd/commit.c | |||
@@ -306,6 +306,8 @@ void journal_commit_transaction(journal_t *journal) | |||
306 | int flags; | 306 | int flags; |
307 | int err; | 307 | int err; |
308 | unsigned long blocknr; | 308 | unsigned long blocknr; |
309 | ktime_t start_time; | ||
310 | u64 commit_time; | ||
309 | char *tagp = NULL; | 311 | char *tagp = NULL; |
310 | journal_header_t *header; | 312 | journal_header_t *header; |
311 | journal_block_tag_t *tag = NULL; | 313 | journal_block_tag_t *tag = NULL; |
@@ -418,6 +420,7 @@ void journal_commit_transaction(journal_t *journal) | |||
418 | commit_transaction->t_state = T_FLUSH; | 420 | commit_transaction->t_state = T_FLUSH; |
419 | journal->j_committing_transaction = commit_transaction; | 421 | journal->j_committing_transaction = commit_transaction; |
420 | journal->j_running_transaction = NULL; | 422 | journal->j_running_transaction = NULL; |
423 | start_time = ktime_get(); | ||
421 | commit_transaction->t_log_start = journal->j_head; | 424 | commit_transaction->t_log_start = journal->j_head; |
422 | wake_up(&journal->j_wait_transaction_locked); | 425 | wake_up(&journal->j_wait_transaction_locked); |
423 | spin_unlock(&journal->j_state_lock); | 426 | spin_unlock(&journal->j_state_lock); |
@@ -913,6 +916,18 @@ restart_loop: | |||
913 | J_ASSERT(commit_transaction == journal->j_committing_transaction); | 916 | J_ASSERT(commit_transaction == journal->j_committing_transaction); |
914 | journal->j_commit_sequence = commit_transaction->t_tid; | 917 | journal->j_commit_sequence = commit_transaction->t_tid; |
915 | journal->j_committing_transaction = NULL; | 918 | journal->j_committing_transaction = NULL; |
919 | commit_time = ktime_to_ns(ktime_sub(ktime_get(), start_time)); | ||
920 | |||
921 | /* | ||
922 | * weight the commit time higher than the average time so we don't | ||
923 | * react too strongly to vast changes in commit time | ||
924 | */ | ||
925 | if (likely(journal->j_average_commit_time)) | ||
926 | journal->j_average_commit_time = (commit_time*3 + | ||
927 | journal->j_average_commit_time) / 4; | ||
928 | else | ||
929 | journal->j_average_commit_time = commit_time; | ||
930 | |||
916 | spin_unlock(&journal->j_state_lock); | 931 | spin_unlock(&journal->j_state_lock); |
917 | 932 | ||
918 | if (commit_transaction->t_checkpoint_list == NULL && | 933 | if (commit_transaction->t_checkpoint_list == NULL && |
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index 60d4c32c8808..e6a117431277 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c | |||
@@ -25,6 +25,7 @@ | |||
25 | #include <linux/timer.h> | 25 | #include <linux/timer.h> |
26 | #include <linux/mm.h> | 26 | #include <linux/mm.h> |
27 | #include <linux/highmem.h> | 27 | #include <linux/highmem.h> |
28 | #include <linux/hrtimer.h> | ||
28 | 29 | ||
29 | static void __journal_temp_unlink_buffer(struct journal_head *jh); | 30 | static void __journal_temp_unlink_buffer(struct journal_head *jh); |
30 | 31 | ||
@@ -49,6 +50,7 @@ get_transaction(journal_t *journal, transaction_t *transaction) | |||
49 | { | 50 | { |
50 | transaction->t_journal = journal; | 51 | transaction->t_journal = journal; |
51 | transaction->t_state = T_RUNNING; | 52 | transaction->t_state = T_RUNNING; |
53 | transaction->t_start_time = ktime_get(); | ||
52 | transaction->t_tid = journal->j_transaction_sequence++; | 54 | transaction->t_tid = journal->j_transaction_sequence++; |
53 | transaction->t_expires = jiffies + journal->j_commit_interval; | 55 | transaction->t_expires = jiffies + journal->j_commit_interval; |
54 | spin_lock_init(&transaction->t_handle_lock); | 56 | spin_lock_init(&transaction->t_handle_lock); |
@@ -752,7 +754,6 @@ out: | |||
752 | * int journal_get_write_access() - notify intent to modify a buffer for metadata (not data) update. | 754 | * int journal_get_write_access() - notify intent to modify a buffer for metadata (not data) update. |
753 | * @handle: transaction to add buffer modifications to | 755 | * @handle: transaction to add buffer modifications to |
754 | * @bh: bh to be used for metadata writes | 756 | * @bh: bh to be used for metadata writes |
755 | * @credits: variable that will receive credits for the buffer | ||
756 | * | 757 | * |
757 | * Returns an error code or 0 on success. | 758 | * Returns an error code or 0 on success. |
758 | * | 759 | * |
@@ -1370,7 +1371,7 @@ int journal_stop(handle_t *handle) | |||
1370 | { | 1371 | { |
1371 | transaction_t *transaction = handle->h_transaction; | 1372 | transaction_t *transaction = handle->h_transaction; |
1372 | journal_t *journal = transaction->t_journal; | 1373 | journal_t *journal = transaction->t_journal; |
1373 | int old_handle_count, err; | 1374 | int err; |
1374 | pid_t pid; | 1375 | pid_t pid; |
1375 | 1376 | ||
1376 | J_ASSERT(journal_current_handle() == handle); | 1377 | J_ASSERT(journal_current_handle() == handle); |
@@ -1399,6 +1400,17 @@ int journal_stop(handle_t *handle) | |||
1399 | * on IO anyway. Speeds up many-threaded, many-dir operations | 1400 | * on IO anyway. Speeds up many-threaded, many-dir operations |
1400 | * by 30x or more... | 1401 | * by 30x or more... |
1401 | * | 1402 | * |
1403 | * We try and optimize the sleep time against what the underlying disk | ||
1404 | * can do, instead of having a static sleep time. This is usefull for | ||
1405 | * the case where our storage is so fast that it is more optimal to go | ||
1406 | * ahead and force a flush and wait for the transaction to be committed | ||
1407 | * than it is to wait for an arbitrary amount of time for new writers to | ||
1408 | * join the transaction. We acheive this by measuring how long it takes | ||
1409 | * to commit a transaction, and compare it with how long this | ||
1410 | * transaction has been running, and if run time < commit time then we | ||
1411 | * sleep for the delta and commit. This greatly helps super fast disks | ||
1412 | * that would see slowdowns as more threads started doing fsyncs. | ||
1413 | * | ||
1402 | * But don't do this if this process was the most recent one to | 1414 | * But don't do this if this process was the most recent one to |
1403 | * perform a synchronous write. We do this to detect the case where a | 1415 | * perform a synchronous write. We do this to detect the case where a |
1404 | * single process is doing a stream of sync writes. No point in waiting | 1416 | * single process is doing a stream of sync writes. No point in waiting |
@@ -1406,11 +1418,26 @@ int journal_stop(handle_t *handle) | |||
1406 | */ | 1418 | */ |
1407 | pid = current->pid; | 1419 | pid = current->pid; |
1408 | if (handle->h_sync && journal->j_last_sync_writer != pid) { | 1420 | if (handle->h_sync && journal->j_last_sync_writer != pid) { |
1421 | u64 commit_time, trans_time; | ||
1422 | |||
1409 | journal->j_last_sync_writer = pid; | 1423 | journal->j_last_sync_writer = pid; |
1410 | do { | 1424 | |
1411 | old_handle_count = transaction->t_handle_count; | 1425 | spin_lock(&journal->j_state_lock); |
1412 | schedule_timeout_uninterruptible(1); | 1426 | commit_time = journal->j_average_commit_time; |
1413 | } while (old_handle_count != transaction->t_handle_count); | 1427 | spin_unlock(&journal->j_state_lock); |
1428 | |||
1429 | trans_time = ktime_to_ns(ktime_sub(ktime_get(), | ||
1430 | transaction->t_start_time)); | ||
1431 | |||
1432 | commit_time = min_t(u64, commit_time, | ||
1433 | 1000*jiffies_to_usecs(1)); | ||
1434 | |||
1435 | if (trans_time < commit_time) { | ||
1436 | ktime_t expires = ktime_add_ns(ktime_get(), | ||
1437 | commit_time); | ||
1438 | set_current_state(TASK_UNINTERRUPTIBLE); | ||
1439 | schedule_hrtimeout(&expires, HRTIMER_MODE_ABS); | ||
1440 | } | ||
1414 | } | 1441 | } |
1415 | 1442 | ||
1416 | current->journal_info = NULL; | 1443 | current->journal_info = NULL; |
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 54ff4c77aaa3..d861096c9d81 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c | |||
@@ -3868,7 +3868,7 @@ static void ocfs2_split_record(struct inode *inode, | |||
3868 | struct ocfs2_extent_list *left_el = NULL, *right_el, *insert_el, *el; | 3868 | struct ocfs2_extent_list *left_el = NULL, *right_el, *insert_el, *el; |
3869 | struct ocfs2_extent_rec *rec, *tmprec; | 3869 | struct ocfs2_extent_rec *rec, *tmprec; |
3870 | 3870 | ||
3871 | right_el = path_leaf_el(right_path);; | 3871 | right_el = path_leaf_el(right_path); |
3872 | if (left_path) | 3872 | if (left_path) |
3873 | left_el = path_leaf_el(left_path); | 3873 | left_el = path_leaf_el(left_path); |
3874 | 3874 | ||
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index f731ab491795..b0c4cadd4c45 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -1324,7 +1324,7 @@ again: | |||
1324 | goto out; | 1324 | goto out; |
1325 | } | 1325 | } |
1326 | 1326 | ||
1327 | mlog(0, "lock %s, successfull return from ocfs2_dlm_lock\n", | 1327 | mlog(0, "lock %s, successful return from ocfs2_dlm_lock\n", |
1328 | lockres->l_name); | 1328 | lockres->l_name); |
1329 | 1329 | ||
1330 | /* At this point we've gone inside the dlm and need to | 1330 | /* At this point we've gone inside the dlm and need to |
@@ -2951,7 +2951,7 @@ static int ocfs2_drop_lock(struct ocfs2_super *osb, | |||
2951 | ocfs2_dlm_dump_lksb(&lockres->l_lksb); | 2951 | ocfs2_dlm_dump_lksb(&lockres->l_lksb); |
2952 | BUG(); | 2952 | BUG(); |
2953 | } | 2953 | } |
2954 | mlog(0, "lock %s, successfull return from ocfs2_dlm_unlock\n", | 2954 | mlog(0, "lock %s, successful return from ocfs2_dlm_unlock\n", |
2955 | lockres->l_name); | 2955 | lockres->l_name); |
2956 | 2956 | ||
2957 | ocfs2_wait_on_busy_lock(lockres); | 2957 | ocfs2_wait_on_busy_lock(lockres); |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index e8f795f978aa..a5887df2cd8a 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
@@ -1605,7 +1605,7 @@ int ocfs2_change_file_space(struct file *file, unsigned int cmd, | |||
1605 | struct ocfs2_space_resv *sr) | 1605 | struct ocfs2_space_resv *sr) |
1606 | { | 1606 | { |
1607 | struct inode *inode = file->f_path.dentry->d_inode; | 1607 | struct inode *inode = file->f_path.dentry->d_inode; |
1608 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);; | 1608 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); |
1609 | 1609 | ||
1610 | if ((cmd == OCFS2_IOC_RESVSP || cmd == OCFS2_IOC_RESVSP64) && | 1610 | if ((cmd == OCFS2_IOC_RESVSP || cmd == OCFS2_IOC_RESVSP64) && |
1611 | !ocfs2_writes_unwritten_extents(osb)) | 1611 | !ocfs2_writes_unwritten_extents(osb)) |
diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 03ec59504906..5edcc3f92ba7 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c | |||
@@ -47,8 +47,6 @@ static ssize_t read_from_oldmem(char *buf, size_t count, | |||
47 | 47 | ||
48 | offset = (unsigned long)(*ppos % PAGE_SIZE); | 48 | offset = (unsigned long)(*ppos % PAGE_SIZE); |
49 | pfn = (unsigned long)(*ppos / PAGE_SIZE); | 49 | pfn = (unsigned long)(*ppos / PAGE_SIZE); |
50 | if (pfn > saved_max_pfn) | ||
51 | return -EINVAL; | ||
52 | 50 | ||
53 | do { | 51 | do { |
54 | if (count > (PAGE_SIZE - offset)) | 52 | if (count > (PAGE_SIZE - offset)) |
diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c index c97d4c931715..98a232f7196b 100644 --- a/fs/romfs/inode.c +++ b/fs/romfs/inode.c | |||
@@ -490,7 +490,7 @@ static mode_t romfs_modemap[] = | |||
490 | static struct inode * | 490 | static struct inode * |
491 | romfs_iget(struct super_block *sb, unsigned long ino) | 491 | romfs_iget(struct super_block *sb, unsigned long ino) |
492 | { | 492 | { |
493 | int nextfh; | 493 | int nextfh, ret; |
494 | struct romfs_inode ri; | 494 | struct romfs_inode ri; |
495 | struct inode *i; | 495 | struct inode *i; |
496 | 496 | ||
@@ -526,11 +526,11 @@ romfs_iget(struct super_block *sb, unsigned long ino) | |||
526 | i->i_mtime.tv_nsec = i->i_atime.tv_nsec = i->i_ctime.tv_nsec = 0; | 526 | i->i_mtime.tv_nsec = i->i_atime.tv_nsec = i->i_ctime.tv_nsec = 0; |
527 | 527 | ||
528 | /* Precalculate the data offset */ | 528 | /* Precalculate the data offset */ |
529 | ino = romfs_strnlen(i, ino+ROMFH_SIZE, ROMFS_MAXFN); | 529 | ret = romfs_strnlen(i, ino + ROMFH_SIZE, ROMFS_MAXFN); |
530 | if (ino >= 0) | 530 | if (ret >= 0) |
531 | ino = ((ROMFH_SIZE+ino+1+ROMFH_PAD)&ROMFH_MASK); | 531 | ino = (ROMFH_SIZE + ret + 1 + ROMFH_PAD) & ROMFH_MASK; |
532 | else | 532 | else |
533 | ino = 0; | 533 | ino = 0; |
534 | 534 | ||
535 | ROMFS_I(i)->i_metasize = ino; | 535 | ROMFS_I(i)->i_metasize = ino; |
536 | ROMFS_I(i)->i_dataoffset = ino+(i->i_ino&ROMFH_MASK); | 536 | ROMFS_I(i)->i_dataoffset = ino+(i->i_ino&ROMFH_MASK); |
diff --git a/fs/splice.c b/fs/splice.c index 1abab5cee4ba..a54b3e3f10a7 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
@@ -21,6 +21,7 @@ | |||
21 | #include <linux/file.h> | 21 | #include <linux/file.h> |
22 | #include <linux/pagemap.h> | 22 | #include <linux/pagemap.h> |
23 | #include <linux/splice.h> | 23 | #include <linux/splice.h> |
24 | #include <linux/memcontrol.h> | ||
24 | #include <linux/mm_inline.h> | 25 | #include <linux/mm_inline.h> |
25 | #include <linux/swap.h> | 26 | #include <linux/swap.h> |
26 | #include <linux/writeback.h> | 27 | #include <linux/writeback.h> |
diff --git a/fs/super.c b/fs/super.c index cb20744ec789..7d67387496cb 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -458,7 +458,6 @@ void sync_filesystems(int wait) | |||
458 | if (sb->s_flags & MS_RDONLY) | 458 | if (sb->s_flags & MS_RDONLY) |
459 | continue; | 459 | continue; |
460 | sb->s_need_sync_fs = 1; | 460 | sb->s_need_sync_fs = 1; |
461 | async_synchronize_full_special(&sb->s_async_list); | ||
462 | } | 461 | } |
463 | 462 | ||
464 | restart: | 463 | restart: |
@@ -471,6 +470,7 @@ restart: | |||
471 | sb->s_count++; | 470 | sb->s_count++; |
472 | spin_unlock(&sb_lock); | 471 | spin_unlock(&sb_lock); |
473 | down_read(&sb->s_umount); | 472 | down_read(&sb->s_umount); |
473 | async_synchronize_full_special(&sb->s_async_list); | ||
474 | if (sb->s_root && (wait || sb->s_dirt)) | 474 | if (sb->s_root && (wait || sb->s_dirt)) |
475 | sb->s_op->sync_fs(sb, wait); | 475 | sb->s_op->sync_fs(sb, wait); |
476 | up_read(&sb->s_umount); | 476 | up_read(&sb->s_umount); |
diff --git a/include/linux/auxvec.h b/include/linux/auxvec.h index d7afa9dd6635..f3b5d4e3a2ac 100644 --- a/include/linux/auxvec.h +++ b/include/linux/auxvec.h | |||
@@ -23,16 +23,16 @@ | |||
23 | #define AT_PLATFORM 15 /* string identifying CPU for optimizations */ | 23 | #define AT_PLATFORM 15 /* string identifying CPU for optimizations */ |
24 | #define AT_HWCAP 16 /* arch dependent hints at CPU capabilities */ | 24 | #define AT_HWCAP 16 /* arch dependent hints at CPU capabilities */ |
25 | #define AT_CLKTCK 17 /* frequency at which times() increments */ | 25 | #define AT_CLKTCK 17 /* frequency at which times() increments */ |
26 | 26 | /* AT_* values 18 through 22 are reserved */ | |
27 | #define AT_SECURE 23 /* secure mode boolean */ | 27 | #define AT_SECURE 23 /* secure mode boolean */ |
28 | |||
29 | #define AT_BASE_PLATFORM 24 /* string identifying real platform, may | 28 | #define AT_BASE_PLATFORM 24 /* string identifying real platform, may |
30 | * differ from AT_PLATFORM. */ | 29 | * differ from AT_PLATFORM. */ |
30 | #define AT_RANDOM 25 /* address of 16 random bytes */ | ||
31 | 31 | ||
32 | #define AT_EXECFN 31 /* filename of program */ | 32 | #define AT_EXECFN 31 /* filename of program */ |
33 | 33 | ||
34 | #ifdef __KERNEL__ | 34 | #ifdef __KERNEL__ |
35 | #define AT_VECTOR_SIZE_BASE 18 /* NEW_AUX_ENT entries in auxiliary table */ | 35 | #define AT_VECTOR_SIZE_BASE 19 /* NEW_AUX_ENT entries in auxiliary table */ |
36 | /* number of "#define AT_.*" above, minus {AT_NULL, AT_IGNORE, AT_NOTELF} */ | 36 | /* number of "#define AT_.*" above, minus {AT_NULL, AT_IGNORE, AT_NOTELF} */ |
37 | #endif | 37 | #endif |
38 | 38 | ||
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 08b78c09b09a..e267e62827bb 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h | |||
@@ -52,9 +52,9 @@ struct cgroup_subsys_state { | |||
52 | * hierarchy structure */ | 52 | * hierarchy structure */ |
53 | struct cgroup *cgroup; | 53 | struct cgroup *cgroup; |
54 | 54 | ||
55 | /* State maintained by the cgroup system to allow | 55 | /* State maintained by the cgroup system to allow subsystems |
56 | * subsystems to be "busy". Should be accessed via css_get() | 56 | * to be "busy". Should be accessed via css_get(), |
57 | * and css_put() */ | 57 | * css_tryget() and and css_put(). */ |
58 | 58 | ||
59 | atomic_t refcnt; | 59 | atomic_t refcnt; |
60 | 60 | ||
@@ -64,11 +64,14 @@ struct cgroup_subsys_state { | |||
64 | /* bits in struct cgroup_subsys_state flags field */ | 64 | /* bits in struct cgroup_subsys_state flags field */ |
65 | enum { | 65 | enum { |
66 | CSS_ROOT, /* This CSS is the root of the subsystem */ | 66 | CSS_ROOT, /* This CSS is the root of the subsystem */ |
67 | CSS_REMOVED, /* This CSS is dead */ | ||
67 | }; | 68 | }; |
68 | 69 | ||
69 | /* | 70 | /* |
70 | * Call css_get() to hold a reference on the cgroup; | 71 | * Call css_get() to hold a reference on the css; it can be used |
71 | * | 72 | * for a reference obtained via: |
73 | * - an existing ref-counted reference to the css | ||
74 | * - task->cgroups for a locked task | ||
72 | */ | 75 | */ |
73 | 76 | ||
74 | static inline void css_get(struct cgroup_subsys_state *css) | 77 | static inline void css_get(struct cgroup_subsys_state *css) |
@@ -77,9 +80,32 @@ static inline void css_get(struct cgroup_subsys_state *css) | |||
77 | if (!test_bit(CSS_ROOT, &css->flags)) | 80 | if (!test_bit(CSS_ROOT, &css->flags)) |
78 | atomic_inc(&css->refcnt); | 81 | atomic_inc(&css->refcnt); |
79 | } | 82 | } |
83 | |||
84 | static inline bool css_is_removed(struct cgroup_subsys_state *css) | ||
85 | { | ||
86 | return test_bit(CSS_REMOVED, &css->flags); | ||
87 | } | ||
88 | |||
89 | /* | ||
90 | * Call css_tryget() to take a reference on a css if your existing | ||
91 | * (known-valid) reference isn't already ref-counted. Returns false if | ||
92 | * the css has been destroyed. | ||
93 | */ | ||
94 | |||
95 | static inline bool css_tryget(struct cgroup_subsys_state *css) | ||
96 | { | ||
97 | if (test_bit(CSS_ROOT, &css->flags)) | ||
98 | return true; | ||
99 | while (!atomic_inc_not_zero(&css->refcnt)) { | ||
100 | if (test_bit(CSS_REMOVED, &css->flags)) | ||
101 | return false; | ||
102 | } | ||
103 | return true; | ||
104 | } | ||
105 | |||
80 | /* | 106 | /* |
81 | * css_put() should be called to release a reference taken by | 107 | * css_put() should be called to release a reference taken by |
82 | * css_get() | 108 | * css_get() or css_tryget() |
83 | */ | 109 | */ |
84 | 110 | ||
85 | extern void __css_put(struct cgroup_subsys_state *css); | 111 | extern void __css_put(struct cgroup_subsys_state *css); |
@@ -116,7 +142,7 @@ struct cgroup { | |||
116 | struct list_head children; /* my children */ | 142 | struct list_head children; /* my children */ |
117 | 143 | ||
118 | struct cgroup *parent; /* my parent */ | 144 | struct cgroup *parent; /* my parent */ |
119 | struct dentry *dentry; /* cgroup fs entry */ | 145 | struct dentry *dentry; /* cgroup fs entry, RCU protected */ |
120 | 146 | ||
121 | /* Private pointers for each registered subsystem */ | 147 | /* Private pointers for each registered subsystem */ |
122 | struct cgroup_subsys_state *subsys[CGROUP_SUBSYS_COUNT]; | 148 | struct cgroup_subsys_state *subsys[CGROUP_SUBSYS_COUNT]; |
@@ -145,6 +171,9 @@ struct cgroup { | |||
145 | int pids_use_count; | 171 | int pids_use_count; |
146 | /* Length of the current tasks_pids array */ | 172 | /* Length of the current tasks_pids array */ |
147 | int pids_length; | 173 | int pids_length; |
174 | |||
175 | /* For RCU-protected deletion */ | ||
176 | struct rcu_head rcu_head; | ||
148 | }; | 177 | }; |
149 | 178 | ||
150 | /* A css_set is a structure holding pointers to a set of | 179 | /* A css_set is a structure holding pointers to a set of |
@@ -337,9 +366,23 @@ struct cgroup_subsys { | |||
337 | #define MAX_CGROUP_TYPE_NAMELEN 32 | 366 | #define MAX_CGROUP_TYPE_NAMELEN 32 |
338 | const char *name; | 367 | const char *name; |
339 | 368 | ||
340 | /* Protected by RCU */ | 369 | /* |
341 | struct cgroupfs_root *root; | 370 | * Protects sibling/children links of cgroups in this |
371 | * hierarchy, plus protects which hierarchy (or none) the | ||
372 | * subsystem is a part of (i.e. root/sibling). To avoid | ||
373 | * potential deadlocks, the following operations should not be | ||
374 | * undertaken while holding any hierarchy_mutex: | ||
375 | * | ||
376 | * - allocating memory | ||
377 | * - initiating hotplug events | ||
378 | */ | ||
379 | struct mutex hierarchy_mutex; | ||
342 | 380 | ||
381 | /* | ||
382 | * Link to parent, and list entry in parent's children. | ||
383 | * Protected by this->hierarchy_mutex and cgroup_lock() | ||
384 | */ | ||
385 | struct cgroupfs_root *root; | ||
343 | struct list_head sibling; | 386 | struct list_head sibling; |
344 | }; | 387 | }; |
345 | 388 | ||
diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h index 51ea2bdea0f9..90c6074a36ca 100644 --- a/include/linux/cpuset.h +++ b/include/linux/cpuset.h | |||
@@ -20,8 +20,9 @@ extern int number_of_cpusets; /* How many cpusets are defined in system? */ | |||
20 | extern int cpuset_init_early(void); | 20 | extern int cpuset_init_early(void); |
21 | extern int cpuset_init(void); | 21 | extern int cpuset_init(void); |
22 | extern void cpuset_init_smp(void); | 22 | extern void cpuset_init_smp(void); |
23 | extern void cpuset_cpus_allowed(struct task_struct *p, cpumask_t *mask); | 23 | extern void cpuset_cpus_allowed(struct task_struct *p, struct cpumask *mask); |
24 | extern void cpuset_cpus_allowed_locked(struct task_struct *p, cpumask_t *mask); | 24 | extern void cpuset_cpus_allowed_locked(struct task_struct *p, |
25 | struct cpumask *mask); | ||
25 | extern nodemask_t cpuset_mems_allowed(struct task_struct *p); | 26 | extern nodemask_t cpuset_mems_allowed(struct task_struct *p); |
26 | #define cpuset_current_mems_allowed (current->mems_allowed) | 27 | #define cpuset_current_mems_allowed (current->mems_allowed) |
27 | void cpuset_init_current_mems_allowed(void); | 28 | void cpuset_init_current_mems_allowed(void); |
@@ -86,12 +87,13 @@ static inline int cpuset_init_early(void) { return 0; } | |||
86 | static inline int cpuset_init(void) { return 0; } | 87 | static inline int cpuset_init(void) { return 0; } |
87 | static inline void cpuset_init_smp(void) {} | 88 | static inline void cpuset_init_smp(void) {} |
88 | 89 | ||
89 | static inline void cpuset_cpus_allowed(struct task_struct *p, cpumask_t *mask) | 90 | static inline void cpuset_cpus_allowed(struct task_struct *p, |
91 | struct cpumask *mask) | ||
90 | { | 92 | { |
91 | *mask = cpu_possible_map; | 93 | *mask = cpu_possible_map; |
92 | } | 94 | } |
93 | static inline void cpuset_cpus_allowed_locked(struct task_struct *p, | 95 | static inline void cpuset_cpus_allowed_locked(struct task_struct *p, |
94 | cpumask_t *mask) | 96 | struct cpumask *mask) |
95 | { | 97 | { |
96 | *mask = cpu_possible_map; | 98 | *mask = cpu_possible_map; |
97 | } | 99 | } |
diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h index 78c775a83f7c..121720d74e15 100644 --- a/include/linux/ext2_fs.h +++ b/include/linux/ext2_fs.h | |||
@@ -194,6 +194,30 @@ struct ext2_group_desc | |||
194 | #define EXT2_FL_USER_VISIBLE FS_FL_USER_VISIBLE /* User visible flags */ | 194 | #define EXT2_FL_USER_VISIBLE FS_FL_USER_VISIBLE /* User visible flags */ |
195 | #define EXT2_FL_USER_MODIFIABLE FS_FL_USER_MODIFIABLE /* User modifiable flags */ | 195 | #define EXT2_FL_USER_MODIFIABLE FS_FL_USER_MODIFIABLE /* User modifiable flags */ |
196 | 196 | ||
197 | /* Flags that should be inherited by new inodes from their parent. */ | ||
198 | #define EXT2_FL_INHERITED (EXT2_SECRM_FL | EXT2_UNRM_FL | EXT2_COMPR_FL |\ | ||
199 | EXT2_SYNC_FL | EXT2_IMMUTABLE_FL | EXT2_APPEND_FL |\ | ||
200 | EXT2_NODUMP_FL | EXT2_NOATIME_FL | EXT2_COMPRBLK_FL|\ | ||
201 | EXT2_NOCOMP_FL | EXT2_JOURNAL_DATA_FL |\ | ||
202 | EXT2_NOTAIL_FL | EXT2_DIRSYNC_FL) | ||
203 | |||
204 | /* Flags that are appropriate for regular files (all but dir-specific ones). */ | ||
205 | #define EXT2_REG_FLMASK (~(EXT2_DIRSYNC_FL | EXT2_TOPDIR_FL)) | ||
206 | |||
207 | /* Flags that are appropriate for non-directories/regular files. */ | ||
208 | #define EXT2_OTHER_FLMASK (EXT2_NODUMP_FL | EXT2_NOATIME_FL) | ||
209 | |||
210 | /* Mask out flags that are inappropriate for the given type of inode. */ | ||
211 | static inline __u32 ext2_mask_flags(umode_t mode, __u32 flags) | ||
212 | { | ||
213 | if (S_ISDIR(mode)) | ||
214 | return flags; | ||
215 | else if (S_ISREG(mode)) | ||
216 | return flags & EXT2_REG_FLMASK; | ||
217 | else | ||
218 | return flags & EXT2_OTHER_FLMASK; | ||
219 | } | ||
220 | |||
197 | /* | 221 | /* |
198 | * ioctl commands | 222 | * ioctl commands |
199 | */ | 223 | */ |
diff --git a/include/linux/ext2_fs_sb.h b/include/linux/ext2_fs_sb.h index dc541f3653d1..1cdb66367c98 100644 --- a/include/linux/ext2_fs_sb.h +++ b/include/linux/ext2_fs_sb.h | |||
@@ -101,7 +101,7 @@ struct ext2_sb_info { | |||
101 | struct percpu_counter s_freeblocks_counter; | 101 | struct percpu_counter s_freeblocks_counter; |
102 | struct percpu_counter s_freeinodes_counter; | 102 | struct percpu_counter s_freeinodes_counter; |
103 | struct percpu_counter s_dirs_counter; | 103 | struct percpu_counter s_dirs_counter; |
104 | struct blockgroup_lock s_blockgroup_lock; | 104 | struct blockgroup_lock *s_blockgroup_lock; |
105 | /* root of the per fs reservation window tree */ | 105 | /* root of the per fs reservation window tree */ |
106 | spinlock_t s_rsv_window_lock; | 106 | spinlock_t s_rsv_window_lock; |
107 | struct rb_root s_rsv_window_root; | 107 | struct rb_root s_rsv_window_root; |
@@ -111,7 +111,7 @@ struct ext2_sb_info { | |||
111 | static inline spinlock_t * | 111 | static inline spinlock_t * |
112 | sb_bgl_lock(struct ext2_sb_info *sbi, unsigned int block_group) | 112 | sb_bgl_lock(struct ext2_sb_info *sbi, unsigned int block_group) |
113 | { | 113 | { |
114 | return bgl_lock_ptr(&sbi->s_blockgroup_lock, block_group); | 114 | return bgl_lock_ptr(sbi->s_blockgroup_lock, block_group); |
115 | } | 115 | } |
116 | 116 | ||
117 | #endif /* _LINUX_EXT2_FS_SB */ | 117 | #endif /* _LINUX_EXT2_FS_SB */ |
diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h index d14f02918483..d76800f6ecf0 100644 --- a/include/linux/ext3_fs.h +++ b/include/linux/ext3_fs.h | |||
@@ -178,6 +178,30 @@ struct ext3_group_desc | |||
178 | #define EXT3_FL_USER_VISIBLE 0x0003DFFF /* User visible flags */ | 178 | #define EXT3_FL_USER_VISIBLE 0x0003DFFF /* User visible flags */ |
179 | #define EXT3_FL_USER_MODIFIABLE 0x000380FF /* User modifiable flags */ | 179 | #define EXT3_FL_USER_MODIFIABLE 0x000380FF /* User modifiable flags */ |
180 | 180 | ||
181 | /* Flags that should be inherited by new inodes from their parent. */ | ||
182 | #define EXT3_FL_INHERITED (EXT3_SECRM_FL | EXT3_UNRM_FL | EXT3_COMPR_FL |\ | ||
183 | EXT3_SYNC_FL | EXT3_IMMUTABLE_FL | EXT3_APPEND_FL |\ | ||
184 | EXT3_NODUMP_FL | EXT3_NOATIME_FL | EXT3_COMPRBLK_FL|\ | ||
185 | EXT3_NOCOMPR_FL | EXT3_JOURNAL_DATA_FL |\ | ||
186 | EXT3_NOTAIL_FL | EXT3_DIRSYNC_FL) | ||
187 | |||
188 | /* Flags that are appropriate for regular files (all but dir-specific ones). */ | ||
189 | #define EXT3_REG_FLMASK (~(EXT3_DIRSYNC_FL | EXT3_TOPDIR_FL)) | ||
190 | |||
191 | /* Flags that are appropriate for non-directories/regular files. */ | ||
192 | #define EXT3_OTHER_FLMASK (EXT3_NODUMP_FL | EXT3_NOATIME_FL) | ||
193 | |||
194 | /* Mask out flags that are inappropriate for the given type of inode. */ | ||
195 | static inline __u32 ext3_mask_flags(umode_t mode, __u32 flags) | ||
196 | { | ||
197 | if (S_ISDIR(mode)) | ||
198 | return flags; | ||
199 | else if (S_ISREG(mode)) | ||
200 | return flags & EXT3_REG_FLMASK; | ||
201 | else | ||
202 | return flags & EXT3_OTHER_FLMASK; | ||
203 | } | ||
204 | |||
181 | /* | 205 | /* |
182 | * Inode dynamic state flags | 206 | * Inode dynamic state flags |
183 | */ | 207 | */ |
diff --git a/include/linux/ext3_fs_sb.h b/include/linux/ext3_fs_sb.h index e024e38248ff..76fdc0f4b028 100644 --- a/include/linux/ext3_fs_sb.h +++ b/include/linux/ext3_fs_sb.h | |||
@@ -60,7 +60,7 @@ struct ext3_sb_info { | |||
60 | struct percpu_counter s_freeblocks_counter; | 60 | struct percpu_counter s_freeblocks_counter; |
61 | struct percpu_counter s_freeinodes_counter; | 61 | struct percpu_counter s_freeinodes_counter; |
62 | struct percpu_counter s_dirs_counter; | 62 | struct percpu_counter s_dirs_counter; |
63 | struct blockgroup_lock s_blockgroup_lock; | 63 | struct blockgroup_lock *s_blockgroup_lock; |
64 | 64 | ||
65 | /* root of the per fs reservation window tree */ | 65 | /* root of the per fs reservation window tree */ |
66 | spinlock_t s_rsv_window_lock; | 66 | spinlock_t s_rsv_window_lock; |
@@ -86,7 +86,7 @@ struct ext3_sb_info { | |||
86 | static inline spinlock_t * | 86 | static inline spinlock_t * |
87 | sb_bgl_lock(struct ext3_sb_info *sbi, unsigned int block_group) | 87 | sb_bgl_lock(struct ext3_sb_info *sbi, unsigned int block_group) |
88 | { | 88 | { |
89 | return bgl_lock_ptr(&sbi->s_blockgroup_lock, block_group); | 89 | return bgl_lock_ptr(sbi->s_blockgroup_lock, block_group); |
90 | } | 90 | } |
91 | 91 | ||
92 | #endif /* _LINUX_EXT3_FS_SB */ | 92 | #endif /* _LINUX_EXT3_FS_SB */ |
diff --git a/include/linux/jbd.h b/include/linux/jbd.h index 346e2b80be7d..6384b19efe64 100644 --- a/include/linux/jbd.h +++ b/include/linux/jbd.h | |||
@@ -543,6 +543,11 @@ struct transaction_s | |||
543 | unsigned long t_expires; | 543 | unsigned long t_expires; |
544 | 544 | ||
545 | /* | 545 | /* |
546 | * When this transaction started, in nanoseconds [no locking] | ||
547 | */ | ||
548 | ktime_t t_start_time; | ||
549 | |||
550 | /* | ||
546 | * How many handles used this transaction? [t_handle_lock] | 551 | * How many handles used this transaction? [t_handle_lock] |
547 | */ | 552 | */ |
548 | int t_handle_count; | 553 | int t_handle_count; |
@@ -798,9 +803,19 @@ struct journal_s | |||
798 | struct buffer_head **j_wbuf; | 803 | struct buffer_head **j_wbuf; |
799 | int j_wbufsize; | 804 | int j_wbufsize; |
800 | 805 | ||
806 | /* | ||
807 | * this is the pid of the last person to run a synchronous operation | ||
808 | * through the journal. | ||
809 | */ | ||
801 | pid_t j_last_sync_writer; | 810 | pid_t j_last_sync_writer; |
802 | 811 | ||
803 | /* | 812 | /* |
813 | * the average amount of time in nanoseconds it takes to commit a | ||
814 | * transaction to the disk. [j_state_lock] | ||
815 | */ | ||
816 | u64 j_average_commit_time; | ||
817 | |||
818 | /* | ||
804 | * An opaque pointer to fs-private information. ext3 puts its | 819 | * An opaque pointer to fs-private information. ext3 puts its |
805 | * superblock pointer here | 820 | * superblock pointer here |
806 | */ | 821 | */ |
diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 6b8e2027165e..343df9ef2412 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h | |||
@@ -476,6 +476,12 @@ static inline char *pack_hex_byte(char *buf, u8 byte) | |||
476 | __val = __val < __min ? __min: __val; \ | 476 | __val = __val < __min ? __min: __val; \ |
477 | __val > __max ? __max: __val; }) | 477 | __val > __max ? __max: __val; }) |
478 | 478 | ||
479 | |||
480 | /* | ||
481 | * swap - swap value of @a and @b | ||
482 | */ | ||
483 | #define swap(a, b) ({ typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; }) | ||
484 | |||
479 | /** | 485 | /** |
480 | * container_of - cast a member of a structure out to the containing structure | 486 | * container_of - cast a member of a structure out to the containing structure |
481 | * @ptr: the pointer to the member. | 487 | * @ptr: the pointer to the member. |
diff --git a/include/linux/magic.h b/include/linux/magic.h index f7f3fdddbef0..439f6f3cb0c4 100644 --- a/include/linux/magic.h +++ b/include/linux/magic.h | |||
@@ -13,6 +13,7 @@ | |||
13 | #define EFS_SUPER_MAGIC 0x414A53 | 13 | #define EFS_SUPER_MAGIC 0x414A53 |
14 | #define EXT2_SUPER_MAGIC 0xEF53 | 14 | #define EXT2_SUPER_MAGIC 0xEF53 |
15 | #define EXT3_SUPER_MAGIC 0xEF53 | 15 | #define EXT3_SUPER_MAGIC 0xEF53 |
16 | #define XENFS_SUPER_MAGIC 0xabba1974 | ||
16 | #define EXT4_SUPER_MAGIC 0xEF53 | 17 | #define EXT4_SUPER_MAGIC 0xEF53 |
17 | #define HPFS_SUPER_MAGIC 0xf995e849 | 18 | #define HPFS_SUPER_MAGIC 0xf995e849 |
18 | #define ISOFS_SUPER_MAGIC 0x9660 | 19 | #define ISOFS_SUPER_MAGIC 0x9660 |
diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 1fbe14d39521..326f45c86530 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h | |||
@@ -19,22 +19,45 @@ | |||
19 | 19 | ||
20 | #ifndef _LINUX_MEMCONTROL_H | 20 | #ifndef _LINUX_MEMCONTROL_H |
21 | #define _LINUX_MEMCONTROL_H | 21 | #define _LINUX_MEMCONTROL_H |
22 | 22 | #include <linux/cgroup.h> | |
23 | struct mem_cgroup; | 23 | struct mem_cgroup; |
24 | struct page_cgroup; | 24 | struct page_cgroup; |
25 | struct page; | 25 | struct page; |
26 | struct mm_struct; | 26 | struct mm_struct; |
27 | 27 | ||
28 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR | 28 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR |
29 | /* | ||
30 | * All "charge" functions with gfp_mask should use GFP_KERNEL or | ||
31 | * (gfp_mask & GFP_RECLAIM_MASK). In current implementatin, memcg doesn't | ||
32 | * alloc memory but reclaims memory from all available zones. So, "where I want | ||
33 | * memory from" bits of gfp_mask has no meaning. So any bits of that field is | ||
34 | * available but adding a rule is better. charge functions' gfp_mask should | ||
35 | * be set to GFP_KERNEL or gfp_mask & GFP_RECLAIM_MASK for avoiding ambiguous | ||
36 | * codes. | ||
37 | * (Of course, if memcg does memory allocation in future, GFP_KERNEL is sane.) | ||
38 | */ | ||
29 | 39 | ||
30 | extern int mem_cgroup_charge(struct page *page, struct mm_struct *mm, | 40 | extern int mem_cgroup_newpage_charge(struct page *page, struct mm_struct *mm, |
31 | gfp_t gfp_mask); | 41 | gfp_t gfp_mask); |
42 | /* for swap handling */ | ||
43 | extern int mem_cgroup_try_charge_swapin(struct mm_struct *mm, | ||
44 | struct page *page, gfp_t mask, struct mem_cgroup **ptr); | ||
45 | extern void mem_cgroup_commit_charge_swapin(struct page *page, | ||
46 | struct mem_cgroup *ptr); | ||
47 | extern void mem_cgroup_cancel_charge_swapin(struct mem_cgroup *ptr); | ||
48 | |||
32 | extern int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, | 49 | extern int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, |
33 | gfp_t gfp_mask); | 50 | gfp_t gfp_mask); |
34 | extern void mem_cgroup_move_lists(struct page *page, enum lru_list lru); | 51 | extern void mem_cgroup_add_lru_list(struct page *page, enum lru_list lru); |
52 | extern void mem_cgroup_del_lru_list(struct page *page, enum lru_list lru); | ||
53 | extern void mem_cgroup_rotate_lru_list(struct page *page, enum lru_list lru); | ||
54 | extern void mem_cgroup_del_lru(struct page *page); | ||
55 | extern void mem_cgroup_move_lists(struct page *page, | ||
56 | enum lru_list from, enum lru_list to); | ||
35 | extern void mem_cgroup_uncharge_page(struct page *page); | 57 | extern void mem_cgroup_uncharge_page(struct page *page); |
36 | extern void mem_cgroup_uncharge_cache_page(struct page *page); | 58 | extern void mem_cgroup_uncharge_cache_page(struct page *page); |
37 | extern int mem_cgroup_shrink_usage(struct mm_struct *mm, gfp_t gfp_mask); | 59 | extern int mem_cgroup_shrink_usage(struct page *page, |
60 | struct mm_struct *mm, gfp_t gfp_mask); | ||
38 | 61 | ||
39 | extern unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, | 62 | extern unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, |
40 | struct list_head *dst, | 63 | struct list_head *dst, |
@@ -47,12 +70,20 @@ int task_in_mem_cgroup(struct task_struct *task, const struct mem_cgroup *mem); | |||
47 | 70 | ||
48 | extern struct mem_cgroup *mem_cgroup_from_task(struct task_struct *p); | 71 | extern struct mem_cgroup *mem_cgroup_from_task(struct task_struct *p); |
49 | 72 | ||
50 | #define mm_match_cgroup(mm, cgroup) \ | 73 | static inline |
51 | ((cgroup) == mem_cgroup_from_task((mm)->owner)) | 74 | int mm_match_cgroup(const struct mm_struct *mm, const struct mem_cgroup *cgroup) |
75 | { | ||
76 | struct mem_cgroup *mem; | ||
77 | rcu_read_lock(); | ||
78 | mem = mem_cgroup_from_task((mm)->owner); | ||
79 | rcu_read_unlock(); | ||
80 | return cgroup == mem; | ||
81 | } | ||
52 | 82 | ||
53 | extern int | 83 | extern int |
54 | mem_cgroup_prepare_migration(struct page *page, struct page *newpage); | 84 | mem_cgroup_prepare_migration(struct page *page, struct mem_cgroup **ptr); |
55 | extern void mem_cgroup_end_migration(struct page *page); | 85 | extern void mem_cgroup_end_migration(struct mem_cgroup *mem, |
86 | struct page *oldpage, struct page *newpage); | ||
56 | 87 | ||
57 | /* | 88 | /* |
58 | * For memory reclaim. | 89 | * For memory reclaim. |
@@ -65,13 +96,32 @@ extern void mem_cgroup_note_reclaim_priority(struct mem_cgroup *mem, | |||
65 | int priority); | 96 | int priority); |
66 | extern void mem_cgroup_record_reclaim_priority(struct mem_cgroup *mem, | 97 | extern void mem_cgroup_record_reclaim_priority(struct mem_cgroup *mem, |
67 | int priority); | 98 | int priority); |
99 | int mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg); | ||
100 | unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, | ||
101 | struct zone *zone, | ||
102 | enum lru_list lru); | ||
103 | struct zone_reclaim_stat *mem_cgroup_get_reclaim_stat(struct mem_cgroup *memcg, | ||
104 | struct zone *zone); | ||
105 | struct zone_reclaim_stat* | ||
106 | mem_cgroup_get_reclaim_stat_from_page(struct page *page); | ||
68 | 107 | ||
69 | extern long mem_cgroup_calc_reclaim(struct mem_cgroup *mem, struct zone *zone, | 108 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP |
70 | int priority, enum lru_list lru); | 109 | extern int do_swap_account; |
110 | #endif | ||
71 | 111 | ||
112 | static inline bool mem_cgroup_disabled(void) | ||
113 | { | ||
114 | if (mem_cgroup_subsys.disabled) | ||
115 | return true; | ||
116 | return false; | ||
117 | } | ||
118 | |||
119 | extern bool mem_cgroup_oom_called(struct task_struct *task); | ||
72 | 120 | ||
73 | #else /* CONFIG_CGROUP_MEM_RES_CTLR */ | 121 | #else /* CONFIG_CGROUP_MEM_RES_CTLR */ |
74 | static inline int mem_cgroup_charge(struct page *page, | 122 | struct mem_cgroup; |
123 | |||
124 | static inline int mem_cgroup_newpage_charge(struct page *page, | ||
75 | struct mm_struct *mm, gfp_t gfp_mask) | 125 | struct mm_struct *mm, gfp_t gfp_mask) |
76 | { | 126 | { |
77 | return 0; | 127 | return 0; |
@@ -83,6 +133,21 @@ static inline int mem_cgroup_cache_charge(struct page *page, | |||
83 | return 0; | 133 | return 0; |
84 | } | 134 | } |
85 | 135 | ||
136 | static inline int mem_cgroup_try_charge_swapin(struct mm_struct *mm, | ||
137 | struct page *page, gfp_t gfp_mask, struct mem_cgroup **ptr) | ||
138 | { | ||
139 | return 0; | ||
140 | } | ||
141 | |||
142 | static inline void mem_cgroup_commit_charge_swapin(struct page *page, | ||
143 | struct mem_cgroup *ptr) | ||
144 | { | ||
145 | } | ||
146 | |||
147 | static inline void mem_cgroup_cancel_charge_swapin(struct mem_cgroup *ptr) | ||
148 | { | ||
149 | } | ||
150 | |||
86 | static inline void mem_cgroup_uncharge_page(struct page *page) | 151 | static inline void mem_cgroup_uncharge_page(struct page *page) |
87 | { | 152 | { |
88 | } | 153 | } |
@@ -91,12 +156,33 @@ static inline void mem_cgroup_uncharge_cache_page(struct page *page) | |||
91 | { | 156 | { |
92 | } | 157 | } |
93 | 158 | ||
94 | static inline int mem_cgroup_shrink_usage(struct mm_struct *mm, gfp_t gfp_mask) | 159 | static inline int mem_cgroup_shrink_usage(struct page *page, |
160 | struct mm_struct *mm, gfp_t gfp_mask) | ||
95 | { | 161 | { |
96 | return 0; | 162 | return 0; |
97 | } | 163 | } |
98 | 164 | ||
99 | static inline void mem_cgroup_move_lists(struct page *page, bool active) | 165 | static inline void mem_cgroup_add_lru_list(struct page *page, int lru) |
166 | { | ||
167 | } | ||
168 | |||
169 | static inline void mem_cgroup_del_lru_list(struct page *page, int lru) | ||
170 | { | ||
171 | return ; | ||
172 | } | ||
173 | |||
174 | static inline void mem_cgroup_rotate_lru_list(struct page *page, int lru) | ||
175 | { | ||
176 | return ; | ||
177 | } | ||
178 | |||
179 | static inline void mem_cgroup_del_lru(struct page *page) | ||
180 | { | ||
181 | return ; | ||
182 | } | ||
183 | |||
184 | static inline void | ||
185 | mem_cgroup_move_lists(struct page *page, enum lru_list from, enum lru_list to) | ||
100 | { | 186 | { |
101 | } | 187 | } |
102 | 188 | ||
@@ -112,12 +198,14 @@ static inline int task_in_mem_cgroup(struct task_struct *task, | |||
112 | } | 198 | } |
113 | 199 | ||
114 | static inline int | 200 | static inline int |
115 | mem_cgroup_prepare_migration(struct page *page, struct page *newpage) | 201 | mem_cgroup_prepare_migration(struct page *page, struct mem_cgroup **ptr) |
116 | { | 202 | { |
117 | return 0; | 203 | return 0; |
118 | } | 204 | } |
119 | 205 | ||
120 | static inline void mem_cgroup_end_migration(struct page *page) | 206 | static inline void mem_cgroup_end_migration(struct mem_cgroup *mem, |
207 | struct page *oldpage, | ||
208 | struct page *newpage) | ||
121 | { | 209 | { |
122 | } | 210 | } |
123 | 211 | ||
@@ -146,12 +234,42 @@ static inline void mem_cgroup_record_reclaim_priority(struct mem_cgroup *mem, | |||
146 | { | 234 | { |
147 | } | 235 | } |
148 | 236 | ||
149 | static inline long mem_cgroup_calc_reclaim(struct mem_cgroup *mem, | 237 | static inline bool mem_cgroup_disabled(void) |
150 | struct zone *zone, int priority, | 238 | { |
151 | enum lru_list lru) | 239 | return true; |
240 | } | ||
241 | |||
242 | static inline bool mem_cgroup_oom_called(struct task_struct *task) | ||
243 | { | ||
244 | return false; | ||
245 | } | ||
246 | |||
247 | static inline int | ||
248 | mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg) | ||
249 | { | ||
250 | return 1; | ||
251 | } | ||
252 | |||
253 | static inline unsigned long | ||
254 | mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, struct zone *zone, | ||
255 | enum lru_list lru) | ||
152 | { | 256 | { |
153 | return 0; | 257 | return 0; |
154 | } | 258 | } |
259 | |||
260 | |||
261 | static inline struct zone_reclaim_stat* | ||
262 | mem_cgroup_get_reclaim_stat(struct mem_cgroup *memcg, struct zone *zone) | ||
263 | { | ||
264 | return NULL; | ||
265 | } | ||
266 | |||
267 | static inline struct zone_reclaim_stat* | ||
268 | mem_cgroup_get_reclaim_stat_from_page(struct page *page) | ||
269 | { | ||
270 | return NULL; | ||
271 | } | ||
272 | |||
155 | #endif /* CONFIG_CGROUP_MEM_CONT */ | 273 | #endif /* CONFIG_CGROUP_MEM_CONT */ |
156 | 274 | ||
157 | #endif /* _LINUX_MEMCONTROL_H */ | 275 | #endif /* _LINUX_MEMCONTROL_H */ |
diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h index c948350c378e..7fbb97267556 100644 --- a/include/linux/mm_inline.h +++ b/include/linux/mm_inline.h | |||
@@ -28,6 +28,7 @@ add_page_to_lru_list(struct zone *zone, struct page *page, enum lru_list l) | |||
28 | { | 28 | { |
29 | list_add(&page->lru, &zone->lru[l].list); | 29 | list_add(&page->lru, &zone->lru[l].list); |
30 | __inc_zone_state(zone, NR_LRU_BASE + l); | 30 | __inc_zone_state(zone, NR_LRU_BASE + l); |
31 | mem_cgroup_add_lru_list(page, l); | ||
31 | } | 32 | } |
32 | 33 | ||
33 | static inline void | 34 | static inline void |
@@ -35,6 +36,7 @@ del_page_from_lru_list(struct zone *zone, struct page *page, enum lru_list l) | |||
35 | { | 36 | { |
36 | list_del(&page->lru); | 37 | list_del(&page->lru); |
37 | __dec_zone_state(zone, NR_LRU_BASE + l); | 38 | __dec_zone_state(zone, NR_LRU_BASE + l); |
39 | mem_cgroup_del_lru_list(page, l); | ||
38 | } | 40 | } |
39 | 41 | ||
40 | static inline void | 42 | static inline void |
@@ -54,6 +56,7 @@ del_page_from_lru(struct zone *zone, struct page *page) | |||
54 | l += page_is_file_cache(page); | 56 | l += page_is_file_cache(page); |
55 | } | 57 | } |
56 | __dec_zone_state(zone, NR_LRU_BASE + l); | 58 | __dec_zone_state(zone, NR_LRU_BASE + l); |
59 | mem_cgroup_del_lru_list(page, l); | ||
57 | } | 60 | } |
58 | 61 | ||
59 | /** | 62 | /** |
@@ -78,23 +81,4 @@ static inline enum lru_list page_lru(struct page *page) | |||
78 | return lru; | 81 | return lru; |
79 | } | 82 | } |
80 | 83 | ||
81 | /** | ||
82 | * inactive_anon_is_low - check if anonymous pages need to be deactivated | ||
83 | * @zone: zone to check | ||
84 | * | ||
85 | * Returns true if the zone does not have enough inactive anon pages, | ||
86 | * meaning some active anon pages need to be deactivated. | ||
87 | */ | ||
88 | static inline int inactive_anon_is_low(struct zone *zone) | ||
89 | { | ||
90 | unsigned long active, inactive; | ||
91 | |||
92 | active = zone_page_state(zone, NR_ACTIVE_ANON); | ||
93 | inactive = zone_page_state(zone, NR_INACTIVE_ANON); | ||
94 | |||
95 | if (inactive * zone->inactive_ratio < active) | ||
96 | return 1; | ||
97 | |||
98 | return 0; | ||
99 | } | ||
100 | #endif | 84 | #endif |
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 35a7b5e19465..09c14e213b63 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h | |||
@@ -263,6 +263,19 @@ enum zone_type { | |||
263 | #error ZONES_SHIFT -- too many zones configured adjust calculation | 263 | #error ZONES_SHIFT -- too many zones configured adjust calculation |
264 | #endif | 264 | #endif |
265 | 265 | ||
266 | struct zone_reclaim_stat { | ||
267 | /* | ||
268 | * The pageout code in vmscan.c keeps track of how many of the | ||
269 | * mem/swap backed and file backed pages are refeferenced. | ||
270 | * The higher the rotated/scanned ratio, the more valuable | ||
271 | * that cache is. | ||
272 | * | ||
273 | * The anon LRU stats live in [0], file LRU stats in [1] | ||
274 | */ | ||
275 | unsigned long recent_rotated[2]; | ||
276 | unsigned long recent_scanned[2]; | ||
277 | }; | ||
278 | |||
266 | struct zone { | 279 | struct zone { |
267 | /* Fields commonly accessed by the page allocator */ | 280 | /* Fields commonly accessed by the page allocator */ |
268 | unsigned long pages_min, pages_low, pages_high; | 281 | unsigned long pages_min, pages_low, pages_high; |
@@ -315,16 +328,7 @@ struct zone { | |||
315 | unsigned long nr_scan; | 328 | unsigned long nr_scan; |
316 | } lru[NR_LRU_LISTS]; | 329 | } lru[NR_LRU_LISTS]; |
317 | 330 | ||
318 | /* | 331 | struct zone_reclaim_stat reclaim_stat; |
319 | * The pageout code in vmscan.c keeps track of how many of the | ||
320 | * mem/swap backed and file backed pages are refeferenced. | ||
321 | * The higher the rotated/scanned ratio, the more valuable | ||
322 | * that cache is. | ||
323 | * | ||
324 | * The anon LRU stats live in [0], file LRU stats in [1] | ||
325 | */ | ||
326 | unsigned long recent_rotated[2]; | ||
327 | unsigned long recent_scanned[2]; | ||
328 | 332 | ||
329 | unsigned long pages_scanned; /* since last reclaim */ | 333 | unsigned long pages_scanned; /* since last reclaim */ |
330 | unsigned long flags; /* zone flags, see below */ | 334 | unsigned long flags; /* zone flags, see below */ |
diff --git a/include/linux/page_cgroup.h b/include/linux/page_cgroup.h index 1e6d34bfa094..602cc1fdee90 100644 --- a/include/linux/page_cgroup.h +++ b/include/linux/page_cgroup.h | |||
@@ -26,10 +26,6 @@ enum { | |||
26 | PCG_LOCK, /* page cgroup is locked */ | 26 | PCG_LOCK, /* page cgroup is locked */ |
27 | PCG_CACHE, /* charged as cache */ | 27 | PCG_CACHE, /* charged as cache */ |
28 | PCG_USED, /* this object is in use. */ | 28 | PCG_USED, /* this object is in use. */ |
29 | /* flags for LRU placement */ | ||
30 | PCG_ACTIVE, /* page is active in this cgroup */ | ||
31 | PCG_FILE, /* page is file system backed */ | ||
32 | PCG_UNEVICTABLE, /* page is unevictableable */ | ||
33 | }; | 29 | }; |
34 | 30 | ||
35 | #define TESTPCGFLAG(uname, lname) \ | 31 | #define TESTPCGFLAG(uname, lname) \ |
@@ -50,19 +46,6 @@ TESTPCGFLAG(Cache, CACHE) | |||
50 | TESTPCGFLAG(Used, USED) | 46 | TESTPCGFLAG(Used, USED) |
51 | CLEARPCGFLAG(Used, USED) | 47 | CLEARPCGFLAG(Used, USED) |
52 | 48 | ||
53 | /* LRU management flags (from global-lru definition) */ | ||
54 | TESTPCGFLAG(File, FILE) | ||
55 | SETPCGFLAG(File, FILE) | ||
56 | CLEARPCGFLAG(File, FILE) | ||
57 | |||
58 | TESTPCGFLAG(Active, ACTIVE) | ||
59 | SETPCGFLAG(Active, ACTIVE) | ||
60 | CLEARPCGFLAG(Active, ACTIVE) | ||
61 | |||
62 | TESTPCGFLAG(Unevictable, UNEVICTABLE) | ||
63 | SETPCGFLAG(Unevictable, UNEVICTABLE) | ||
64 | CLEARPCGFLAG(Unevictable, UNEVICTABLE) | ||
65 | |||
66 | static inline int page_cgroup_nid(struct page_cgroup *pc) | 49 | static inline int page_cgroup_nid(struct page_cgroup *pc) |
67 | { | 50 | { |
68 | return page_to_nid(pc->page); | 51 | return page_to_nid(pc->page); |
@@ -105,4 +88,39 @@ static inline void page_cgroup_init(void) | |||
105 | } | 88 | } |
106 | 89 | ||
107 | #endif | 90 | #endif |
91 | |||
92 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
93 | #include <linux/swap.h> | ||
94 | extern struct mem_cgroup * | ||
95 | swap_cgroup_record(swp_entry_t ent, struct mem_cgroup *mem); | ||
96 | extern struct mem_cgroup *lookup_swap_cgroup(swp_entry_t ent); | ||
97 | extern int swap_cgroup_swapon(int type, unsigned long max_pages); | ||
98 | extern void swap_cgroup_swapoff(int type); | ||
99 | #else | ||
100 | #include <linux/swap.h> | ||
101 | |||
102 | static inline | ||
103 | struct mem_cgroup *swap_cgroup_record(swp_entry_t ent, struct mem_cgroup *mem) | ||
104 | { | ||
105 | return NULL; | ||
106 | } | ||
107 | |||
108 | static inline | ||
109 | struct mem_cgroup *lookup_swap_cgroup(swp_entry_t ent) | ||
110 | { | ||
111 | return NULL; | ||
112 | } | ||
113 | |||
114 | static inline int | ||
115 | swap_cgroup_swapon(int type, unsigned long max_pages) | ||
116 | { | ||
117 | return 0; | ||
118 | } | ||
119 | |||
120 | static inline void swap_cgroup_swapoff(int type) | ||
121 | { | ||
122 | return; | ||
123 | } | ||
124 | |||
125 | #endif | ||
108 | #endif | 126 | #endif |
diff --git a/include/linux/pid.h b/include/linux/pid.h index bb206c56d1f0..49f1c2f66e95 100644 --- a/include/linux/pid.h +++ b/include/linux/pid.h | |||
@@ -123,6 +123,24 @@ extern struct pid *alloc_pid(struct pid_namespace *ns); | |||
123 | extern void free_pid(struct pid *pid); | 123 | extern void free_pid(struct pid *pid); |
124 | 124 | ||
125 | /* | 125 | /* |
126 | * ns_of_pid() returns the pid namespace in which the specified pid was | ||
127 | * allocated. | ||
128 | * | ||
129 | * NOTE: | ||
130 | * ns_of_pid() is expected to be called for a process (task) that has | ||
131 | * an attached 'struct pid' (see attach_pid(), detach_pid()) i.e @pid | ||
132 | * is expected to be non-NULL. If @pid is NULL, caller should handle | ||
133 | * the resulting NULL pid-ns. | ||
134 | */ | ||
135 | static inline struct pid_namespace *ns_of_pid(struct pid *pid) | ||
136 | { | ||
137 | struct pid_namespace *ns = NULL; | ||
138 | if (pid) | ||
139 | ns = pid->numbers[pid->level].ns; | ||
140 | return ns; | ||
141 | } | ||
142 | |||
143 | /* | ||
126 | * the helpers to get the pid's id seen from different namespaces | 144 | * the helpers to get the pid's id seen from different namespaces |
127 | * | 145 | * |
128 | * pid_nr() : global id, i.e. the id seen from the init namespace; | 146 | * pid_nr() : global id, i.e. the id seen from the init namespace; |
diff --git a/include/linux/pid_namespace.h b/include/linux/pid_namespace.h index d82fe825d62f..38d10326246a 100644 --- a/include/linux/pid_namespace.h +++ b/include/linux/pid_namespace.h | |||
@@ -79,11 +79,7 @@ static inline void zap_pid_ns_processes(struct pid_namespace *ns) | |||
79 | } | 79 | } |
80 | #endif /* CONFIG_PID_NS */ | 80 | #endif /* CONFIG_PID_NS */ |
81 | 81 | ||
82 | static inline struct pid_namespace *task_active_pid_ns(struct task_struct *tsk) | 82 | extern struct pid_namespace *task_active_pid_ns(struct task_struct *tsk); |
83 | { | ||
84 | return tsk->nsproxy->pid_ns; | ||
85 | } | ||
86 | |||
87 | void pidhash_init(void); | 83 | void pidhash_init(void); |
88 | void pidmap_init(void); | 84 | void pidmap_init(void); |
89 | 85 | ||
diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h index 271c1c2c9f6f..dede0a2cfc45 100644 --- a/include/linux/res_counter.h +++ b/include/linux/res_counter.h | |||
@@ -43,6 +43,10 @@ struct res_counter { | |||
43 | * the routines below consider this to be IRQ-safe | 43 | * the routines below consider this to be IRQ-safe |
44 | */ | 44 | */ |
45 | spinlock_t lock; | 45 | spinlock_t lock; |
46 | /* | ||
47 | * Parent counter, used for hierarchial resource accounting | ||
48 | */ | ||
49 | struct res_counter *parent; | ||
46 | }; | 50 | }; |
47 | 51 | ||
48 | /** | 52 | /** |
@@ -87,7 +91,7 @@ enum { | |||
87 | * helpers for accounting | 91 | * helpers for accounting |
88 | */ | 92 | */ |
89 | 93 | ||
90 | void res_counter_init(struct res_counter *counter); | 94 | void res_counter_init(struct res_counter *counter, struct res_counter *parent); |
91 | 95 | ||
92 | /* | 96 | /* |
93 | * charge - try to consume more resource. | 97 | * charge - try to consume more resource. |
@@ -103,7 +107,7 @@ void res_counter_init(struct res_counter *counter); | |||
103 | int __must_check res_counter_charge_locked(struct res_counter *counter, | 107 | int __must_check res_counter_charge_locked(struct res_counter *counter, |
104 | unsigned long val); | 108 | unsigned long val); |
105 | int __must_check res_counter_charge(struct res_counter *counter, | 109 | int __must_check res_counter_charge(struct res_counter *counter, |
106 | unsigned long val); | 110 | unsigned long val, struct res_counter **limit_fail_at); |
107 | 111 | ||
108 | /* | 112 | /* |
109 | * uncharge - tell that some portion of the resource is released | 113 | * uncharge - tell that some portion of the resource is released |
diff --git a/include/linux/swap.h b/include/linux/swap.h index 91dee50fe260..d30215578877 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h | |||
@@ -214,7 +214,8 @@ static inline void lru_cache_add_active_file(struct page *page) | |||
214 | extern unsigned long try_to_free_pages(struct zonelist *zonelist, int order, | 214 | extern unsigned long try_to_free_pages(struct zonelist *zonelist, int order, |
215 | gfp_t gfp_mask); | 215 | gfp_t gfp_mask); |
216 | extern unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *mem, | 216 | extern unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *mem, |
217 | gfp_t gfp_mask); | 217 | gfp_t gfp_mask, bool noswap, |
218 | unsigned int swappiness); | ||
218 | extern int __isolate_lru_page(struct page *page, int mode, int file); | 219 | extern int __isolate_lru_page(struct page *page, int mode, int file); |
219 | extern unsigned long shrink_all_memory(unsigned long nr_pages); | 220 | extern unsigned long shrink_all_memory(unsigned long nr_pages); |
220 | extern int vm_swappiness; | 221 | extern int vm_swappiness; |
@@ -333,6 +334,22 @@ static inline void disable_swap_token(void) | |||
333 | put_swap_token(swap_token_mm); | 334 | put_swap_token(swap_token_mm); |
334 | } | 335 | } |
335 | 336 | ||
337 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR | ||
338 | extern void mem_cgroup_uncharge_swapcache(struct page *page, swp_entry_t ent); | ||
339 | #else | ||
340 | static inline void | ||
341 | mem_cgroup_uncharge_swapcache(struct page *page, swp_entry_t ent) | ||
342 | { | ||
343 | } | ||
344 | #endif | ||
345 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
346 | extern void mem_cgroup_uncharge_swap(swp_entry_t ent); | ||
347 | #else | ||
348 | static inline void mem_cgroup_uncharge_swap(swp_entry_t ent) | ||
349 | { | ||
350 | } | ||
351 | #endif | ||
352 | |||
336 | #else /* CONFIG_SWAP */ | 353 | #else /* CONFIG_SWAP */ |
337 | 354 | ||
338 | #define nr_swap_pages 0L | 355 | #define nr_swap_pages 0L |
@@ -409,6 +426,12 @@ static inline swp_entry_t get_swap_page(void) | |||
409 | #define has_swap_token(x) 0 | 426 | #define has_swap_token(x) 0 |
410 | #define disable_swap_token() do { } while(0) | 427 | #define disable_swap_token() do { } while(0) |
411 | 428 | ||
429 | static inline int mem_cgroup_cache_charge_swapin(struct page *page, | ||
430 | struct mm_struct *mm, gfp_t mask, bool locked) | ||
431 | { | ||
432 | return 0; | ||
433 | } | ||
434 | |||
412 | #endif /* CONFIG_SWAP */ | 435 | #endif /* CONFIG_SWAP */ |
413 | #endif /* __KERNEL__*/ | 436 | #endif /* __KERNEL__*/ |
414 | #endif /* _LINUX_SWAP_H */ | 437 | #endif /* _LINUX_SWAP_H */ |
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index 6369d89c25d5..f87f9614844d 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h | |||
@@ -136,8 +136,6 @@ struct xenbus_transaction | |||
136 | /* Nil transaction ID. */ | 136 | /* Nil transaction ID. */ |
137 | #define XBT_NIL ((struct xenbus_transaction) { 0 }) | 137 | #define XBT_NIL ((struct xenbus_transaction) { 0 }) |
138 | 138 | ||
139 | int __init xenbus_dev_init(void); | ||
140 | |||
141 | char **xenbus_directory(struct xenbus_transaction t, | 139 | char **xenbus_directory(struct xenbus_transaction t, |
142 | const char *dir, const char *node, unsigned int *num); | 140 | const char *dir, const char *node, unsigned int *num); |
143 | void *xenbus_read(struct xenbus_transaction t, | 141 | void *xenbus_read(struct xenbus_transaction t, |
diff --git a/init/Kconfig b/init/Kconfig index e7893b1d3e42..a724a149bf3f 100644 --- a/init/Kconfig +++ b/init/Kconfig | |||
@@ -271,59 +271,6 @@ config LOG_BUF_SHIFT | |||
271 | 13 => 8 KB | 271 | 13 => 8 KB |
272 | 12 => 4 KB | 272 | 12 => 4 KB |
273 | 273 | ||
274 | config CGROUPS | ||
275 | bool "Control Group support" | ||
276 | help | ||
277 | This option will let you use process cgroup subsystems | ||
278 | such as Cpusets | ||
279 | |||
280 | Say N if unsure. | ||
281 | |||
282 | config CGROUP_DEBUG | ||
283 | bool "Example debug cgroup subsystem" | ||
284 | depends on CGROUPS | ||
285 | default n | ||
286 | help | ||
287 | This option enables a simple cgroup subsystem that | ||
288 | exports useful debugging information about the cgroups | ||
289 | framework | ||
290 | |||
291 | Say N if unsure | ||
292 | |||
293 | config CGROUP_NS | ||
294 | bool "Namespace cgroup subsystem" | ||
295 | depends on CGROUPS | ||
296 | help | ||
297 | Provides a simple namespace cgroup subsystem to | ||
298 | provide hierarchical naming of sets of namespaces, | ||
299 | for instance virtual servers and checkpoint/restart | ||
300 | jobs. | ||
301 | |||
302 | config CGROUP_FREEZER | ||
303 | bool "control group freezer subsystem" | ||
304 | depends on CGROUPS | ||
305 | help | ||
306 | Provides a way to freeze and unfreeze all tasks in a | ||
307 | cgroup. | ||
308 | |||
309 | config CGROUP_DEVICE | ||
310 | bool "Device controller for cgroups" | ||
311 | depends on CGROUPS && EXPERIMENTAL | ||
312 | help | ||
313 | Provides a cgroup implementing whitelists for devices which | ||
314 | a process in the cgroup can mknod or open. | ||
315 | |||
316 | config CPUSETS | ||
317 | bool "Cpuset support" | ||
318 | depends on SMP && CGROUPS | ||
319 | help | ||
320 | This option will let you create and manage CPUSETs which | ||
321 | allow dynamically partitioning a system into sets of CPUs and | ||
322 | Memory Nodes and assigning tasks to run only within those sets. | ||
323 | This is primarily useful on large SMP or NUMA systems. | ||
324 | |||
325 | Say N if unsure. | ||
326 | |||
327 | # | 274 | # |
328 | # Architectures with an unreliable sched_clock() should select this: | 275 | # Architectures with an unreliable sched_clock() should select this: |
329 | # | 276 | # |
@@ -337,6 +284,8 @@ config GROUP_SCHED | |||
337 | help | 284 | help |
338 | This feature lets CPU scheduler recognize task groups and control CPU | 285 | This feature lets CPU scheduler recognize task groups and control CPU |
339 | bandwidth allocation to such task groups. | 286 | bandwidth allocation to such task groups. |
287 | In order to create a group from arbitrary set of processes, use | ||
288 | CONFIG_CGROUPS. (See Control Group support.) | ||
340 | 289 | ||
341 | config FAIR_GROUP_SCHED | 290 | config FAIR_GROUP_SCHED |
342 | bool "Group scheduling for SCHED_OTHER" | 291 | bool "Group scheduling for SCHED_OTHER" |
@@ -379,6 +328,66 @@ config CGROUP_SCHED | |||
379 | 328 | ||
380 | endchoice | 329 | endchoice |
381 | 330 | ||
331 | menu "Control Group support" | ||
332 | config CGROUPS | ||
333 | bool "Control Group support" | ||
334 | help | ||
335 | This option add support for grouping sets of processes together, for | ||
336 | use with process control subsystems such as Cpusets, CFS, memory | ||
337 | controls or device isolation. | ||
338 | See | ||
339 | - Documentation/cpusets.txt (Cpusets) | ||
340 | - Documentation/scheduler/sched-design-CFS.txt (CFS) | ||
341 | - Documentation/cgroups/ (features for grouping, isolation) | ||
342 | - Documentation/controllers/ (features for resource control) | ||
343 | |||
344 | Say N if unsure. | ||
345 | |||
346 | config CGROUP_DEBUG | ||
347 | bool "Example debug cgroup subsystem" | ||
348 | depends on CGROUPS | ||
349 | default n | ||
350 | help | ||
351 | This option enables a simple cgroup subsystem that | ||
352 | exports useful debugging information about the cgroups | ||
353 | framework | ||
354 | |||
355 | Say N if unsure | ||
356 | |||
357 | config CGROUP_NS | ||
358 | bool "Namespace cgroup subsystem" | ||
359 | depends on CGROUPS | ||
360 | help | ||
361 | Provides a simple namespace cgroup subsystem to | ||
362 | provide hierarchical naming of sets of namespaces, | ||
363 | for instance virtual servers and checkpoint/restart | ||
364 | jobs. | ||
365 | |||
366 | config CGROUP_FREEZER | ||
367 | bool "control group freezer subsystem" | ||
368 | depends on CGROUPS | ||
369 | help | ||
370 | Provides a way to freeze and unfreeze all tasks in a | ||
371 | cgroup. | ||
372 | |||
373 | config CGROUP_DEVICE | ||
374 | bool "Device controller for cgroups" | ||
375 | depends on CGROUPS && EXPERIMENTAL | ||
376 | help | ||
377 | Provides a cgroup implementing whitelists for devices which | ||
378 | a process in the cgroup can mknod or open. | ||
379 | |||
380 | config CPUSETS | ||
381 | bool "Cpuset support" | ||
382 | depends on SMP && CGROUPS | ||
383 | help | ||
384 | This option will let you create and manage CPUSETs which | ||
385 | allow dynamically partitioning a system into sets of CPUs and | ||
386 | Memory Nodes and assigning tasks to run only within those sets. | ||
387 | This is primarily useful on large SMP or NUMA systems. | ||
388 | |||
389 | Say N if unsure. | ||
390 | |||
382 | config CGROUP_CPUACCT | 391 | config CGROUP_CPUACCT |
383 | bool "Simple CPU accounting cgroup subsystem" | 392 | bool "Simple CPU accounting cgroup subsystem" |
384 | depends on CGROUPS | 393 | depends on CGROUPS |
@@ -393,9 +402,6 @@ config RESOURCE_COUNTERS | |||
393 | infrastructure that works with cgroups | 402 | infrastructure that works with cgroups |
394 | depends on CGROUPS | 403 | depends on CGROUPS |
395 | 404 | ||
396 | config MM_OWNER | ||
397 | bool | ||
398 | |||
399 | config CGROUP_MEM_RES_CTLR | 405 | config CGROUP_MEM_RES_CTLR |
400 | bool "Memory Resource Controller for Control Groups" | 406 | bool "Memory Resource Controller for Control Groups" |
401 | depends on CGROUPS && RESOURCE_COUNTERS | 407 | depends on CGROUPS && RESOURCE_COUNTERS |
@@ -414,11 +420,33 @@ config CGROUP_MEM_RES_CTLR | |||
414 | sure you need the memory resource controller. Even when you enable | 420 | sure you need the memory resource controller. Even when you enable |
415 | this, you can set "cgroup_disable=memory" at your boot option to | 421 | this, you can set "cgroup_disable=memory" at your boot option to |
416 | disable memory resource controller and you can avoid overheads. | 422 | disable memory resource controller and you can avoid overheads. |
417 | (and lose benefits of memory resource contoller) | 423 | (and lose benefits of memory resource controller) |
418 | 424 | ||
419 | This config option also selects MM_OWNER config option, which | 425 | This config option also selects MM_OWNER config option, which |
420 | could in turn add some fork/exit overhead. | 426 | could in turn add some fork/exit overhead. |
421 | 427 | ||
428 | config MM_OWNER | ||
429 | bool | ||
430 | |||
431 | config CGROUP_MEM_RES_CTLR_SWAP | ||
432 | bool "Memory Resource Controller Swap Extension(EXPERIMENTAL)" | ||
433 | depends on CGROUP_MEM_RES_CTLR && SWAP && EXPERIMENTAL | ||
434 | help | ||
435 | Add swap management feature to memory resource controller. When you | ||
436 | enable this, you can limit mem+swap usage per cgroup. In other words, | ||
437 | when you disable this, memory resource controller has no cares to | ||
438 | usage of swap...a process can exhaust all of the swap. This extension | ||
439 | is useful when you want to avoid exhaustion swap but this itself | ||
440 | adds more overheads and consumes memory for remembering information. | ||
441 | Especially if you use 32bit system or small memory system, please | ||
442 | be careful about enabling this. When memory resource controller | ||
443 | is disabled by boot option, this will be automatically disabled and | ||
444 | there will be no overhead from this. Even when you set this config=y, | ||
445 | if boot option "noswapaccount" is set, swap will not be accounted. | ||
446 | |||
447 | |||
448 | endmenu | ||
449 | |||
422 | config SYSFS_DEPRECATED | 450 | config SYSFS_DEPRECATED |
423 | bool | 451 | bool |
424 | 452 | ||
diff --git a/ipc/mqueue.c b/ipc/mqueue.c index eddb6247a553..23fdb8492b8e 100644 --- a/ipc/mqueue.c +++ b/ipc/mqueue.c | |||
@@ -505,7 +505,8 @@ static void __do_notify(struct mqueue_inode_info *info) | |||
505 | sig_i.si_errno = 0; | 505 | sig_i.si_errno = 0; |
506 | sig_i.si_code = SI_MESGQ; | 506 | sig_i.si_code = SI_MESGQ; |
507 | sig_i.si_value = info->notify.sigev_value; | 507 | sig_i.si_value = info->notify.sigev_value; |
508 | sig_i.si_pid = task_tgid_vnr(current); | 508 | sig_i.si_pid = task_tgid_nr_ns(current, |
509 | ns_of_pid(info->notify_owner)); | ||
509 | sig_i.si_uid = current_uid(); | 510 | sig_i.si_uid = current_uid(); |
510 | 511 | ||
511 | kill_pid_info(info->notify.sigev_signo, | 512 | kill_pid_info(info->notify.sigev_signo, |
diff --git a/kernel/cgroup.c b/kernel/cgroup.c index f221446aa02d..c29831076e7a 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c | |||
@@ -84,7 +84,7 @@ struct cgroupfs_root { | |||
84 | /* Tracks how many cgroups are currently defined in hierarchy.*/ | 84 | /* Tracks how many cgroups are currently defined in hierarchy.*/ |
85 | int number_of_cgroups; | 85 | int number_of_cgroups; |
86 | 86 | ||
87 | /* A list running through the mounted hierarchies */ | 87 | /* A list running through the active hierarchies */ |
88 | struct list_head root_list; | 88 | struct list_head root_list; |
89 | 89 | ||
90 | /* Hierarchy-specific flags */ | 90 | /* Hierarchy-specific flags */ |
@@ -148,8 +148,8 @@ static int notify_on_release(const struct cgroup *cgrp) | |||
148 | #define for_each_subsys(_root, _ss) \ | 148 | #define for_each_subsys(_root, _ss) \ |
149 | list_for_each_entry(_ss, &_root->subsys_list, sibling) | 149 | list_for_each_entry(_ss, &_root->subsys_list, sibling) |
150 | 150 | ||
151 | /* for_each_root() allows you to iterate across the active hierarchies */ | 151 | /* for_each_active_root() allows you to iterate across the active hierarchies */ |
152 | #define for_each_root(_root) \ | 152 | #define for_each_active_root(_root) \ |
153 | list_for_each_entry(_root, &roots, root_list) | 153 | list_for_each_entry(_root, &roots, root_list) |
154 | 154 | ||
155 | /* the list of cgroups eligible for automatic release. Protected by | 155 | /* the list of cgroups eligible for automatic release. Protected by |
@@ -271,7 +271,7 @@ static void __put_css_set(struct css_set *cg, int taskexit) | |||
271 | 271 | ||
272 | rcu_read_lock(); | 272 | rcu_read_lock(); |
273 | for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) { | 273 | for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) { |
274 | struct cgroup *cgrp = cg->subsys[i]->cgroup; | 274 | struct cgroup *cgrp = rcu_dereference(cg->subsys[i]->cgroup); |
275 | if (atomic_dec_and_test(&cgrp->count) && | 275 | if (atomic_dec_and_test(&cgrp->count) && |
276 | notify_on_release(cgrp)) { | 276 | notify_on_release(cgrp)) { |
277 | if (taskexit) | 277 | if (taskexit) |
@@ -384,6 +384,25 @@ static int allocate_cg_links(int count, struct list_head *tmp) | |||
384 | return 0; | 384 | return 0; |
385 | } | 385 | } |
386 | 386 | ||
387 | /** | ||
388 | * link_css_set - a helper function to link a css_set to a cgroup | ||
389 | * @tmp_cg_links: cg_cgroup_link objects allocated by allocate_cg_links() | ||
390 | * @cg: the css_set to be linked | ||
391 | * @cgrp: the destination cgroup | ||
392 | */ | ||
393 | static void link_css_set(struct list_head *tmp_cg_links, | ||
394 | struct css_set *cg, struct cgroup *cgrp) | ||
395 | { | ||
396 | struct cg_cgroup_link *link; | ||
397 | |||
398 | BUG_ON(list_empty(tmp_cg_links)); | ||
399 | link = list_first_entry(tmp_cg_links, struct cg_cgroup_link, | ||
400 | cgrp_link_list); | ||
401 | link->cg = cg; | ||
402 | list_move(&link->cgrp_link_list, &cgrp->css_sets); | ||
403 | list_add(&link->cg_link_list, &cg->cg_links); | ||
404 | } | ||
405 | |||
387 | /* | 406 | /* |
388 | * find_css_set() takes an existing cgroup group and a | 407 | * find_css_set() takes an existing cgroup group and a |
389 | * cgroup object, and returns a css_set object that's | 408 | * cgroup object, and returns a css_set object that's |
@@ -399,7 +418,6 @@ static struct css_set *find_css_set( | |||
399 | int i; | 418 | int i; |
400 | 419 | ||
401 | struct list_head tmp_cg_links; | 420 | struct list_head tmp_cg_links; |
402 | struct cg_cgroup_link *link; | ||
403 | 421 | ||
404 | struct hlist_head *hhead; | 422 | struct hlist_head *hhead; |
405 | 423 | ||
@@ -444,26 +462,11 @@ static struct css_set *find_css_set( | |||
444 | * only do it for the first subsystem in each | 462 | * only do it for the first subsystem in each |
445 | * hierarchy | 463 | * hierarchy |
446 | */ | 464 | */ |
447 | if (ss->root->subsys_list.next == &ss->sibling) { | 465 | if (ss->root->subsys_list.next == &ss->sibling) |
448 | BUG_ON(list_empty(&tmp_cg_links)); | 466 | link_css_set(&tmp_cg_links, res, cgrp); |
449 | link = list_entry(tmp_cg_links.next, | ||
450 | struct cg_cgroup_link, | ||
451 | cgrp_link_list); | ||
452 | list_del(&link->cgrp_link_list); | ||
453 | list_add(&link->cgrp_link_list, &cgrp->css_sets); | ||
454 | link->cg = res; | ||
455 | list_add(&link->cg_link_list, &res->cg_links); | ||
456 | } | ||
457 | } | ||
458 | if (list_empty(&rootnode.subsys_list)) { | ||
459 | link = list_entry(tmp_cg_links.next, | ||
460 | struct cg_cgroup_link, | ||
461 | cgrp_link_list); | ||
462 | list_del(&link->cgrp_link_list); | ||
463 | list_add(&link->cgrp_link_list, &dummytop->css_sets); | ||
464 | link->cg = res; | ||
465 | list_add(&link->cg_link_list, &res->cg_links); | ||
466 | } | 467 | } |
468 | if (list_empty(&rootnode.subsys_list)) | ||
469 | link_css_set(&tmp_cg_links, res, dummytop); | ||
467 | 470 | ||
468 | BUG_ON(!list_empty(&tmp_cg_links)); | 471 | BUG_ON(!list_empty(&tmp_cg_links)); |
469 | 472 | ||
@@ -586,11 +589,18 @@ static void cgroup_call_pre_destroy(struct cgroup *cgrp) | |||
586 | { | 589 | { |
587 | struct cgroup_subsys *ss; | 590 | struct cgroup_subsys *ss; |
588 | for_each_subsys(cgrp->root, ss) | 591 | for_each_subsys(cgrp->root, ss) |
589 | if (ss->pre_destroy && cgrp->subsys[ss->subsys_id]) | 592 | if (ss->pre_destroy) |
590 | ss->pre_destroy(ss, cgrp); | 593 | ss->pre_destroy(ss, cgrp); |
591 | return; | 594 | return; |
592 | } | 595 | } |
593 | 596 | ||
597 | static void free_cgroup_rcu(struct rcu_head *obj) | ||
598 | { | ||
599 | struct cgroup *cgrp = container_of(obj, struct cgroup, rcu_head); | ||
600 | |||
601 | kfree(cgrp); | ||
602 | } | ||
603 | |||
594 | static void cgroup_diput(struct dentry *dentry, struct inode *inode) | 604 | static void cgroup_diput(struct dentry *dentry, struct inode *inode) |
595 | { | 605 | { |
596 | /* is dentry a directory ? if so, kfree() associated cgroup */ | 606 | /* is dentry a directory ? if so, kfree() associated cgroup */ |
@@ -610,19 +620,19 @@ static void cgroup_diput(struct dentry *dentry, struct inode *inode) | |||
610 | /* | 620 | /* |
611 | * Release the subsystem state objects. | 621 | * Release the subsystem state objects. |
612 | */ | 622 | */ |
613 | for_each_subsys(cgrp->root, ss) { | 623 | for_each_subsys(cgrp->root, ss) |
614 | if (cgrp->subsys[ss->subsys_id]) | 624 | ss->destroy(ss, cgrp); |
615 | ss->destroy(ss, cgrp); | ||
616 | } | ||
617 | 625 | ||
618 | cgrp->root->number_of_cgroups--; | 626 | cgrp->root->number_of_cgroups--; |
619 | mutex_unlock(&cgroup_mutex); | 627 | mutex_unlock(&cgroup_mutex); |
620 | 628 | ||
621 | /* Drop the active superblock reference that we took when we | 629 | /* |
622 | * created the cgroup */ | 630 | * Drop the active superblock reference that we took when we |
631 | * created the cgroup | ||
632 | */ | ||
623 | deactivate_super(cgrp->root->sb); | 633 | deactivate_super(cgrp->root->sb); |
624 | 634 | ||
625 | kfree(cgrp); | 635 | call_rcu(&cgrp->rcu_head, free_cgroup_rcu); |
626 | } | 636 | } |
627 | iput(inode); | 637 | iput(inode); |
628 | } | 638 | } |
@@ -712,23 +722,26 @@ static int rebind_subsystems(struct cgroupfs_root *root, | |||
712 | BUG_ON(cgrp->subsys[i]); | 722 | BUG_ON(cgrp->subsys[i]); |
713 | BUG_ON(!dummytop->subsys[i]); | 723 | BUG_ON(!dummytop->subsys[i]); |
714 | BUG_ON(dummytop->subsys[i]->cgroup != dummytop); | 724 | BUG_ON(dummytop->subsys[i]->cgroup != dummytop); |
725 | mutex_lock(&ss->hierarchy_mutex); | ||
715 | cgrp->subsys[i] = dummytop->subsys[i]; | 726 | cgrp->subsys[i] = dummytop->subsys[i]; |
716 | cgrp->subsys[i]->cgroup = cgrp; | 727 | cgrp->subsys[i]->cgroup = cgrp; |
717 | list_add(&ss->sibling, &root->subsys_list); | 728 | list_move(&ss->sibling, &root->subsys_list); |
718 | rcu_assign_pointer(ss->root, root); | 729 | ss->root = root; |
719 | if (ss->bind) | 730 | if (ss->bind) |
720 | ss->bind(ss, cgrp); | 731 | ss->bind(ss, cgrp); |
721 | 732 | mutex_unlock(&ss->hierarchy_mutex); | |
722 | } else if (bit & removed_bits) { | 733 | } else if (bit & removed_bits) { |
723 | /* We're removing this subsystem */ | 734 | /* We're removing this subsystem */ |
724 | BUG_ON(cgrp->subsys[i] != dummytop->subsys[i]); | 735 | BUG_ON(cgrp->subsys[i] != dummytop->subsys[i]); |
725 | BUG_ON(cgrp->subsys[i]->cgroup != cgrp); | 736 | BUG_ON(cgrp->subsys[i]->cgroup != cgrp); |
737 | mutex_lock(&ss->hierarchy_mutex); | ||
726 | if (ss->bind) | 738 | if (ss->bind) |
727 | ss->bind(ss, dummytop); | 739 | ss->bind(ss, dummytop); |
728 | dummytop->subsys[i]->cgroup = dummytop; | 740 | dummytop->subsys[i]->cgroup = dummytop; |
729 | cgrp->subsys[i] = NULL; | 741 | cgrp->subsys[i] = NULL; |
730 | rcu_assign_pointer(subsys[i]->root, &rootnode); | 742 | subsys[i]->root = &rootnode; |
731 | list_del(&ss->sibling); | 743 | list_move(&ss->sibling, &rootnode.subsys_list); |
744 | mutex_unlock(&ss->hierarchy_mutex); | ||
732 | } else if (bit & final_bits) { | 745 | } else if (bit & final_bits) { |
733 | /* Subsystem state should already exist */ | 746 | /* Subsystem state should already exist */ |
734 | BUG_ON(!cgrp->subsys[i]); | 747 | BUG_ON(!cgrp->subsys[i]); |
@@ -990,7 +1003,7 @@ static int cgroup_get_sb(struct file_system_type *fs_type, | |||
990 | root = NULL; | 1003 | root = NULL; |
991 | } else { | 1004 | } else { |
992 | /* New superblock */ | 1005 | /* New superblock */ |
993 | struct cgroup *cgrp = &root->top_cgroup; | 1006 | struct cgroup *root_cgrp = &root->top_cgroup; |
994 | struct inode *inode; | 1007 | struct inode *inode; |
995 | int i; | 1008 | int i; |
996 | 1009 | ||
@@ -1031,7 +1044,7 @@ static int cgroup_get_sb(struct file_system_type *fs_type, | |||
1031 | list_add(&root->root_list, &roots); | 1044 | list_add(&root->root_list, &roots); |
1032 | root_count++; | 1045 | root_count++; |
1033 | 1046 | ||
1034 | sb->s_root->d_fsdata = &root->top_cgroup; | 1047 | sb->s_root->d_fsdata = root_cgrp; |
1035 | root->top_cgroup.dentry = sb->s_root; | 1048 | root->top_cgroup.dentry = sb->s_root; |
1036 | 1049 | ||
1037 | /* Link the top cgroup in this hierarchy into all | 1050 | /* Link the top cgroup in this hierarchy into all |
@@ -1042,29 +1055,18 @@ static int cgroup_get_sb(struct file_system_type *fs_type, | |||
1042 | struct hlist_node *node; | 1055 | struct hlist_node *node; |
1043 | struct css_set *cg; | 1056 | struct css_set *cg; |
1044 | 1057 | ||
1045 | hlist_for_each_entry(cg, node, hhead, hlist) { | 1058 | hlist_for_each_entry(cg, node, hhead, hlist) |
1046 | struct cg_cgroup_link *link; | 1059 | link_css_set(&tmp_cg_links, cg, root_cgrp); |
1047 | |||
1048 | BUG_ON(list_empty(&tmp_cg_links)); | ||
1049 | link = list_entry(tmp_cg_links.next, | ||
1050 | struct cg_cgroup_link, | ||
1051 | cgrp_link_list); | ||
1052 | list_del(&link->cgrp_link_list); | ||
1053 | link->cg = cg; | ||
1054 | list_add(&link->cgrp_link_list, | ||
1055 | &root->top_cgroup.css_sets); | ||
1056 | list_add(&link->cg_link_list, &cg->cg_links); | ||
1057 | } | ||
1058 | } | 1060 | } |
1059 | write_unlock(&css_set_lock); | 1061 | write_unlock(&css_set_lock); |
1060 | 1062 | ||
1061 | free_cg_links(&tmp_cg_links); | 1063 | free_cg_links(&tmp_cg_links); |
1062 | 1064 | ||
1063 | BUG_ON(!list_empty(&cgrp->sibling)); | 1065 | BUG_ON(!list_empty(&root_cgrp->sibling)); |
1064 | BUG_ON(!list_empty(&cgrp->children)); | 1066 | BUG_ON(!list_empty(&root_cgrp->children)); |
1065 | BUG_ON(root->number_of_cgroups != 1); | 1067 | BUG_ON(root->number_of_cgroups != 1); |
1066 | 1068 | ||
1067 | cgroup_populate_dir(cgrp); | 1069 | cgroup_populate_dir(root_cgrp); |
1068 | mutex_unlock(&inode->i_mutex); | 1070 | mutex_unlock(&inode->i_mutex); |
1069 | mutex_unlock(&cgroup_mutex); | 1071 | mutex_unlock(&cgroup_mutex); |
1070 | } | 1072 | } |
@@ -1113,10 +1115,9 @@ static void cgroup_kill_sb(struct super_block *sb) { | |||
1113 | } | 1115 | } |
1114 | write_unlock(&css_set_lock); | 1116 | write_unlock(&css_set_lock); |
1115 | 1117 | ||
1116 | if (!list_empty(&root->root_list)) { | 1118 | list_del(&root->root_list); |
1117 | list_del(&root->root_list); | 1119 | root_count--; |
1118 | root_count--; | 1120 | |
1119 | } | ||
1120 | mutex_unlock(&cgroup_mutex); | 1121 | mutex_unlock(&cgroup_mutex); |
1121 | 1122 | ||
1122 | kfree(root); | 1123 | kfree(root); |
@@ -1145,14 +1146,16 @@ static inline struct cftype *__d_cft(struct dentry *dentry) | |||
1145 | * @buf: the buffer to write the path into | 1146 | * @buf: the buffer to write the path into |
1146 | * @buflen: the length of the buffer | 1147 | * @buflen: the length of the buffer |
1147 | * | 1148 | * |
1148 | * Called with cgroup_mutex held. Writes path of cgroup into buf. | 1149 | * Called with cgroup_mutex held or else with an RCU-protected cgroup |
1149 | * Returns 0 on success, -errno on error. | 1150 | * reference. Writes path of cgroup into buf. Returns 0 on success, |
1151 | * -errno on error. | ||
1150 | */ | 1152 | */ |
1151 | int cgroup_path(const struct cgroup *cgrp, char *buf, int buflen) | 1153 | int cgroup_path(const struct cgroup *cgrp, char *buf, int buflen) |
1152 | { | 1154 | { |
1153 | char *start; | 1155 | char *start; |
1156 | struct dentry *dentry = rcu_dereference(cgrp->dentry); | ||
1154 | 1157 | ||
1155 | if (cgrp == dummytop) { | 1158 | if (!dentry || cgrp == dummytop) { |
1156 | /* | 1159 | /* |
1157 | * Inactive subsystems have no dentry for their root | 1160 | * Inactive subsystems have no dentry for their root |
1158 | * cgroup | 1161 | * cgroup |
@@ -1165,13 +1168,14 @@ int cgroup_path(const struct cgroup *cgrp, char *buf, int buflen) | |||
1165 | 1168 | ||
1166 | *--start = '\0'; | 1169 | *--start = '\0'; |
1167 | for (;;) { | 1170 | for (;;) { |
1168 | int len = cgrp->dentry->d_name.len; | 1171 | int len = dentry->d_name.len; |
1169 | if ((start -= len) < buf) | 1172 | if ((start -= len) < buf) |
1170 | return -ENAMETOOLONG; | 1173 | return -ENAMETOOLONG; |
1171 | memcpy(start, cgrp->dentry->d_name.name, len); | 1174 | memcpy(start, cgrp->dentry->d_name.name, len); |
1172 | cgrp = cgrp->parent; | 1175 | cgrp = cgrp->parent; |
1173 | if (!cgrp) | 1176 | if (!cgrp) |
1174 | break; | 1177 | break; |
1178 | dentry = rcu_dereference(cgrp->dentry); | ||
1175 | if (!cgrp->parent) | 1179 | if (!cgrp->parent) |
1176 | continue; | 1180 | continue; |
1177 | if (--start < buf) | 1181 | if (--start < buf) |
@@ -1216,7 +1220,7 @@ int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk) | |||
1216 | int retval = 0; | 1220 | int retval = 0; |
1217 | struct cgroup_subsys *ss; | 1221 | struct cgroup_subsys *ss; |
1218 | struct cgroup *oldcgrp; | 1222 | struct cgroup *oldcgrp; |
1219 | struct css_set *cg = tsk->cgroups; | 1223 | struct css_set *cg; |
1220 | struct css_set *newcg; | 1224 | struct css_set *newcg; |
1221 | struct cgroupfs_root *root = cgrp->root; | 1225 | struct cgroupfs_root *root = cgrp->root; |
1222 | int subsys_id; | 1226 | int subsys_id; |
@@ -1236,11 +1240,16 @@ int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk) | |||
1236 | } | 1240 | } |
1237 | } | 1241 | } |
1238 | 1242 | ||
1243 | task_lock(tsk); | ||
1244 | cg = tsk->cgroups; | ||
1245 | get_css_set(cg); | ||
1246 | task_unlock(tsk); | ||
1239 | /* | 1247 | /* |
1240 | * Locate or allocate a new css_set for this task, | 1248 | * Locate or allocate a new css_set for this task, |
1241 | * based on its final set of cgroups | 1249 | * based on its final set of cgroups |
1242 | */ | 1250 | */ |
1243 | newcg = find_css_set(cg, cgrp); | 1251 | newcg = find_css_set(cg, cgrp); |
1252 | put_css_set(cg); | ||
1244 | if (!newcg) | 1253 | if (!newcg) |
1245 | return -ENOMEM; | 1254 | return -ENOMEM; |
1246 | 1255 | ||
@@ -1445,7 +1454,7 @@ static ssize_t cgroup_file_write(struct file *file, const char __user *buf, | |||
1445 | struct cftype *cft = __d_cft(file->f_dentry); | 1454 | struct cftype *cft = __d_cft(file->f_dentry); |
1446 | struct cgroup *cgrp = __d_cgrp(file->f_dentry->d_parent); | 1455 | struct cgroup *cgrp = __d_cgrp(file->f_dentry->d_parent); |
1447 | 1456 | ||
1448 | if (!cft || cgroup_is_removed(cgrp)) | 1457 | if (cgroup_is_removed(cgrp)) |
1449 | return -ENODEV; | 1458 | return -ENODEV; |
1450 | if (cft->write) | 1459 | if (cft->write) |
1451 | return cft->write(cgrp, cft, file, buf, nbytes, ppos); | 1460 | return cft->write(cgrp, cft, file, buf, nbytes, ppos); |
@@ -1490,7 +1499,7 @@ static ssize_t cgroup_file_read(struct file *file, char __user *buf, | |||
1490 | struct cftype *cft = __d_cft(file->f_dentry); | 1499 | struct cftype *cft = __d_cft(file->f_dentry); |
1491 | struct cgroup *cgrp = __d_cgrp(file->f_dentry->d_parent); | 1500 | struct cgroup *cgrp = __d_cgrp(file->f_dentry->d_parent); |
1492 | 1501 | ||
1493 | if (!cft || cgroup_is_removed(cgrp)) | 1502 | if (cgroup_is_removed(cgrp)) |
1494 | return -ENODEV; | 1503 | return -ENODEV; |
1495 | 1504 | ||
1496 | if (cft->read) | 1505 | if (cft->read) |
@@ -1554,10 +1563,8 @@ static int cgroup_file_open(struct inode *inode, struct file *file) | |||
1554 | err = generic_file_open(inode, file); | 1563 | err = generic_file_open(inode, file); |
1555 | if (err) | 1564 | if (err) |
1556 | return err; | 1565 | return err; |
1557 | |||
1558 | cft = __d_cft(file->f_dentry); | 1566 | cft = __d_cft(file->f_dentry); |
1559 | if (!cft) | 1567 | |
1560 | return -ENODEV; | ||
1561 | if (cft->read_map || cft->read_seq_string) { | 1568 | if (cft->read_map || cft->read_seq_string) { |
1562 | struct cgroup_seqfile_state *state = | 1569 | struct cgroup_seqfile_state *state = |
1563 | kzalloc(sizeof(*state), GFP_USER); | 1570 | kzalloc(sizeof(*state), GFP_USER); |
@@ -1671,7 +1678,7 @@ static int cgroup_create_dir(struct cgroup *cgrp, struct dentry *dentry, | |||
1671 | if (!error) { | 1678 | if (!error) { |
1672 | dentry->d_fsdata = cgrp; | 1679 | dentry->d_fsdata = cgrp; |
1673 | inc_nlink(parent->d_inode); | 1680 | inc_nlink(parent->d_inode); |
1674 | cgrp->dentry = dentry; | 1681 | rcu_assign_pointer(cgrp->dentry, dentry); |
1675 | dget(dentry); | 1682 | dget(dentry); |
1676 | } | 1683 | } |
1677 | dput(dentry); | 1684 | dput(dentry); |
@@ -1812,6 +1819,7 @@ struct task_struct *cgroup_iter_next(struct cgroup *cgrp, | |||
1812 | { | 1819 | { |
1813 | struct task_struct *res; | 1820 | struct task_struct *res; |
1814 | struct list_head *l = it->task; | 1821 | struct list_head *l = it->task; |
1822 | struct cg_cgroup_link *link; | ||
1815 | 1823 | ||
1816 | /* If the iterator cg is NULL, we have no tasks */ | 1824 | /* If the iterator cg is NULL, we have no tasks */ |
1817 | if (!it->cg_link) | 1825 | if (!it->cg_link) |
@@ -1819,7 +1827,8 @@ struct task_struct *cgroup_iter_next(struct cgroup *cgrp, | |||
1819 | res = list_entry(l, struct task_struct, cg_list); | 1827 | res = list_entry(l, struct task_struct, cg_list); |
1820 | /* Advance iterator to find next entry */ | 1828 | /* Advance iterator to find next entry */ |
1821 | l = l->next; | 1829 | l = l->next; |
1822 | if (l == &res->cgroups->tasks) { | 1830 | link = list_entry(it->cg_link, struct cg_cgroup_link, cgrp_link_list); |
1831 | if (l == &link->cg->tasks) { | ||
1823 | /* We reached the end of this task list - move on to | 1832 | /* We reached the end of this task list - move on to |
1824 | * the next cg_cgroup_link */ | 1833 | * the next cg_cgroup_link */ |
1825 | cgroup_advance_iter(cgrp, it); | 1834 | cgroup_advance_iter(cgrp, it); |
@@ -2013,14 +2022,16 @@ int cgroup_scan_tasks(struct cgroup_scanner *scan) | |||
2013 | */ | 2022 | */ |
2014 | static int pid_array_load(pid_t *pidarray, int npids, struct cgroup *cgrp) | 2023 | static int pid_array_load(pid_t *pidarray, int npids, struct cgroup *cgrp) |
2015 | { | 2024 | { |
2016 | int n = 0; | 2025 | int n = 0, pid; |
2017 | struct cgroup_iter it; | 2026 | struct cgroup_iter it; |
2018 | struct task_struct *tsk; | 2027 | struct task_struct *tsk; |
2019 | cgroup_iter_start(cgrp, &it); | 2028 | cgroup_iter_start(cgrp, &it); |
2020 | while ((tsk = cgroup_iter_next(cgrp, &it))) { | 2029 | while ((tsk = cgroup_iter_next(cgrp, &it))) { |
2021 | if (unlikely(n == npids)) | 2030 | if (unlikely(n == npids)) |
2022 | break; | 2031 | break; |
2023 | pidarray[n++] = task_pid_vnr(tsk); | 2032 | pid = task_pid_vnr(tsk); |
2033 | if (pid > 0) | ||
2034 | pidarray[n++] = pid; | ||
2024 | } | 2035 | } |
2025 | cgroup_iter_end(cgrp, &it); | 2036 | cgroup_iter_end(cgrp, &it); |
2026 | return n; | 2037 | return n; |
@@ -2052,7 +2063,6 @@ int cgroupstats_build(struct cgroupstats *stats, struct dentry *dentry) | |||
2052 | 2063 | ||
2053 | ret = 0; | 2064 | ret = 0; |
2054 | cgrp = dentry->d_fsdata; | 2065 | cgrp = dentry->d_fsdata; |
2055 | rcu_read_lock(); | ||
2056 | 2066 | ||
2057 | cgroup_iter_start(cgrp, &it); | 2067 | cgroup_iter_start(cgrp, &it); |
2058 | while ((tsk = cgroup_iter_next(cgrp, &it))) { | 2068 | while ((tsk = cgroup_iter_next(cgrp, &it))) { |
@@ -2077,7 +2087,6 @@ int cgroupstats_build(struct cgroupstats *stats, struct dentry *dentry) | |||
2077 | } | 2087 | } |
2078 | cgroup_iter_end(cgrp, &it); | 2088 | cgroup_iter_end(cgrp, &it); |
2079 | 2089 | ||
2080 | rcu_read_unlock(); | ||
2081 | err: | 2090 | err: |
2082 | return ret; | 2091 | return ret; |
2083 | } | 2092 | } |
@@ -2324,7 +2333,7 @@ static void init_cgroup_css(struct cgroup_subsys_state *css, | |||
2324 | struct cgroup *cgrp) | 2333 | struct cgroup *cgrp) |
2325 | { | 2334 | { |
2326 | css->cgroup = cgrp; | 2335 | css->cgroup = cgrp; |
2327 | atomic_set(&css->refcnt, 0); | 2336 | atomic_set(&css->refcnt, 1); |
2328 | css->flags = 0; | 2337 | css->flags = 0; |
2329 | if (cgrp == dummytop) | 2338 | if (cgrp == dummytop) |
2330 | set_bit(CSS_ROOT, &css->flags); | 2339 | set_bit(CSS_ROOT, &css->flags); |
@@ -2332,6 +2341,29 @@ static void init_cgroup_css(struct cgroup_subsys_state *css, | |||
2332 | cgrp->subsys[ss->subsys_id] = css; | 2341 | cgrp->subsys[ss->subsys_id] = css; |
2333 | } | 2342 | } |
2334 | 2343 | ||
2344 | static void cgroup_lock_hierarchy(struct cgroupfs_root *root) | ||
2345 | { | ||
2346 | /* We need to take each hierarchy_mutex in a consistent order */ | ||
2347 | int i; | ||
2348 | |||
2349 | for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) { | ||
2350 | struct cgroup_subsys *ss = subsys[i]; | ||
2351 | if (ss->root == root) | ||
2352 | mutex_lock_nested(&ss->hierarchy_mutex, i); | ||
2353 | } | ||
2354 | } | ||
2355 | |||
2356 | static void cgroup_unlock_hierarchy(struct cgroupfs_root *root) | ||
2357 | { | ||
2358 | int i; | ||
2359 | |||
2360 | for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) { | ||
2361 | struct cgroup_subsys *ss = subsys[i]; | ||
2362 | if (ss->root == root) | ||
2363 | mutex_unlock(&ss->hierarchy_mutex); | ||
2364 | } | ||
2365 | } | ||
2366 | |||
2335 | /* | 2367 | /* |
2336 | * cgroup_create - create a cgroup | 2368 | * cgroup_create - create a cgroup |
2337 | * @parent: cgroup that will be parent of the new cgroup | 2369 | * @parent: cgroup that will be parent of the new cgroup |
@@ -2380,7 +2412,9 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry, | |||
2380 | init_cgroup_css(css, ss, cgrp); | 2412 | init_cgroup_css(css, ss, cgrp); |
2381 | } | 2413 | } |
2382 | 2414 | ||
2415 | cgroup_lock_hierarchy(root); | ||
2383 | list_add(&cgrp->sibling, &cgrp->parent->children); | 2416 | list_add(&cgrp->sibling, &cgrp->parent->children); |
2417 | cgroup_unlock_hierarchy(root); | ||
2384 | root->number_of_cgroups++; | 2418 | root->number_of_cgroups++; |
2385 | 2419 | ||
2386 | err = cgroup_create_dir(cgrp, dentry, mode); | 2420 | err = cgroup_create_dir(cgrp, dentry, mode); |
@@ -2431,7 +2465,7 @@ static int cgroup_has_css_refs(struct cgroup *cgrp) | |||
2431 | { | 2465 | { |
2432 | /* Check the reference count on each subsystem. Since we | 2466 | /* Check the reference count on each subsystem. Since we |
2433 | * already established that there are no tasks in the | 2467 | * already established that there are no tasks in the |
2434 | * cgroup, if the css refcount is also 0, then there should | 2468 | * cgroup, if the css refcount is also 1, then there should |
2435 | * be no outstanding references, so the subsystem is safe to | 2469 | * be no outstanding references, so the subsystem is safe to |
2436 | * destroy. We scan across all subsystems rather than using | 2470 | * destroy. We scan across all subsystems rather than using |
2437 | * the per-hierarchy linked list of mounted subsystems since | 2471 | * the per-hierarchy linked list of mounted subsystems since |
@@ -2452,19 +2486,67 @@ static int cgroup_has_css_refs(struct cgroup *cgrp) | |||
2452 | * matter, since it can only happen if the cgroup | 2486 | * matter, since it can only happen if the cgroup |
2453 | * has been deleted and hence no longer needs the | 2487 | * has been deleted and hence no longer needs the |
2454 | * release agent to be called anyway. */ | 2488 | * release agent to be called anyway. */ |
2455 | if (css && atomic_read(&css->refcnt)) | 2489 | if (css && (atomic_read(&css->refcnt) > 1)) |
2456 | return 1; | 2490 | return 1; |
2457 | } | 2491 | } |
2458 | return 0; | 2492 | return 0; |
2459 | } | 2493 | } |
2460 | 2494 | ||
2495 | /* | ||
2496 | * Atomically mark all (or else none) of the cgroup's CSS objects as | ||
2497 | * CSS_REMOVED. Return true on success, or false if the cgroup has | ||
2498 | * busy subsystems. Call with cgroup_mutex held | ||
2499 | */ | ||
2500 | |||
2501 | static int cgroup_clear_css_refs(struct cgroup *cgrp) | ||
2502 | { | ||
2503 | struct cgroup_subsys *ss; | ||
2504 | unsigned long flags; | ||
2505 | bool failed = false; | ||
2506 | local_irq_save(flags); | ||
2507 | for_each_subsys(cgrp->root, ss) { | ||
2508 | struct cgroup_subsys_state *css = cgrp->subsys[ss->subsys_id]; | ||
2509 | int refcnt; | ||
2510 | do { | ||
2511 | /* We can only remove a CSS with a refcnt==1 */ | ||
2512 | refcnt = atomic_read(&css->refcnt); | ||
2513 | if (refcnt > 1) { | ||
2514 | failed = true; | ||
2515 | goto done; | ||
2516 | } | ||
2517 | BUG_ON(!refcnt); | ||
2518 | /* | ||
2519 | * Drop the refcnt to 0 while we check other | ||
2520 | * subsystems. This will cause any racing | ||
2521 | * css_tryget() to spin until we set the | ||
2522 | * CSS_REMOVED bits or abort | ||
2523 | */ | ||
2524 | } while (atomic_cmpxchg(&css->refcnt, refcnt, 0) != refcnt); | ||
2525 | } | ||
2526 | done: | ||
2527 | for_each_subsys(cgrp->root, ss) { | ||
2528 | struct cgroup_subsys_state *css = cgrp->subsys[ss->subsys_id]; | ||
2529 | if (failed) { | ||
2530 | /* | ||
2531 | * Restore old refcnt if we previously managed | ||
2532 | * to clear it from 1 to 0 | ||
2533 | */ | ||
2534 | if (!atomic_read(&css->refcnt)) | ||
2535 | atomic_set(&css->refcnt, 1); | ||
2536 | } else { | ||
2537 | /* Commit the fact that the CSS is removed */ | ||
2538 | set_bit(CSS_REMOVED, &css->flags); | ||
2539 | } | ||
2540 | } | ||
2541 | local_irq_restore(flags); | ||
2542 | return !failed; | ||
2543 | } | ||
2544 | |||
2461 | static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry) | 2545 | static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry) |
2462 | { | 2546 | { |
2463 | struct cgroup *cgrp = dentry->d_fsdata; | 2547 | struct cgroup *cgrp = dentry->d_fsdata; |
2464 | struct dentry *d; | 2548 | struct dentry *d; |
2465 | struct cgroup *parent; | 2549 | struct cgroup *parent; |
2466 | struct super_block *sb; | ||
2467 | struct cgroupfs_root *root; | ||
2468 | 2550 | ||
2469 | /* the vfs holds both inode->i_mutex already */ | 2551 | /* the vfs holds both inode->i_mutex already */ |
2470 | 2552 | ||
@@ -2487,12 +2569,10 @@ static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry) | |||
2487 | 2569 | ||
2488 | mutex_lock(&cgroup_mutex); | 2570 | mutex_lock(&cgroup_mutex); |
2489 | parent = cgrp->parent; | 2571 | parent = cgrp->parent; |
2490 | root = cgrp->root; | ||
2491 | sb = root->sb; | ||
2492 | 2572 | ||
2493 | if (atomic_read(&cgrp->count) | 2573 | if (atomic_read(&cgrp->count) |
2494 | || !list_empty(&cgrp->children) | 2574 | || !list_empty(&cgrp->children) |
2495 | || cgroup_has_css_refs(cgrp)) { | 2575 | || !cgroup_clear_css_refs(cgrp)) { |
2496 | mutex_unlock(&cgroup_mutex); | 2576 | mutex_unlock(&cgroup_mutex); |
2497 | return -EBUSY; | 2577 | return -EBUSY; |
2498 | } | 2578 | } |
@@ -2502,8 +2582,12 @@ static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry) | |||
2502 | if (!list_empty(&cgrp->release_list)) | 2582 | if (!list_empty(&cgrp->release_list)) |
2503 | list_del(&cgrp->release_list); | 2583 | list_del(&cgrp->release_list); |
2504 | spin_unlock(&release_list_lock); | 2584 | spin_unlock(&release_list_lock); |
2505 | /* delete my sibling from parent->children */ | 2585 | |
2586 | cgroup_lock_hierarchy(cgrp->root); | ||
2587 | /* delete this cgroup from parent->children */ | ||
2506 | list_del(&cgrp->sibling); | 2588 | list_del(&cgrp->sibling); |
2589 | cgroup_unlock_hierarchy(cgrp->root); | ||
2590 | |||
2507 | spin_lock(&cgrp->dentry->d_lock); | 2591 | spin_lock(&cgrp->dentry->d_lock); |
2508 | d = dget(cgrp->dentry); | 2592 | d = dget(cgrp->dentry); |
2509 | spin_unlock(&d->d_lock); | 2593 | spin_unlock(&d->d_lock); |
@@ -2525,6 +2609,7 @@ static void __init cgroup_init_subsys(struct cgroup_subsys *ss) | |||
2525 | printk(KERN_INFO "Initializing cgroup subsys %s\n", ss->name); | 2609 | printk(KERN_INFO "Initializing cgroup subsys %s\n", ss->name); |
2526 | 2610 | ||
2527 | /* Create the top cgroup state for this subsystem */ | 2611 | /* Create the top cgroup state for this subsystem */ |
2612 | list_add(&ss->sibling, &rootnode.subsys_list); | ||
2528 | ss->root = &rootnode; | 2613 | ss->root = &rootnode; |
2529 | css = ss->create(ss, dummytop); | 2614 | css = ss->create(ss, dummytop); |
2530 | /* We don't handle early failures gracefully */ | 2615 | /* We don't handle early failures gracefully */ |
@@ -2544,6 +2629,7 @@ static void __init cgroup_init_subsys(struct cgroup_subsys *ss) | |||
2544 | * need to invoke fork callbacks here. */ | 2629 | * need to invoke fork callbacks here. */ |
2545 | BUG_ON(!list_empty(&init_task.tasks)); | 2630 | BUG_ON(!list_empty(&init_task.tasks)); |
2546 | 2631 | ||
2632 | mutex_init(&ss->hierarchy_mutex); | ||
2547 | ss->active = 1; | 2633 | ss->active = 1; |
2548 | } | 2634 | } |
2549 | 2635 | ||
@@ -2562,7 +2648,6 @@ int __init cgroup_init_early(void) | |||
2562 | INIT_HLIST_NODE(&init_css_set.hlist); | 2648 | INIT_HLIST_NODE(&init_css_set.hlist); |
2563 | css_set_count = 1; | 2649 | css_set_count = 1; |
2564 | init_cgroup_root(&rootnode); | 2650 | init_cgroup_root(&rootnode); |
2565 | list_add(&rootnode.root_list, &roots); | ||
2566 | root_count = 1; | 2651 | root_count = 1; |
2567 | init_task.cgroups = &init_css_set; | 2652 | init_task.cgroups = &init_css_set; |
2568 | 2653 | ||
@@ -2669,15 +2754,12 @@ static int proc_cgroup_show(struct seq_file *m, void *v) | |||
2669 | 2754 | ||
2670 | mutex_lock(&cgroup_mutex); | 2755 | mutex_lock(&cgroup_mutex); |
2671 | 2756 | ||
2672 | for_each_root(root) { | 2757 | for_each_active_root(root) { |
2673 | struct cgroup_subsys *ss; | 2758 | struct cgroup_subsys *ss; |
2674 | struct cgroup *cgrp; | 2759 | struct cgroup *cgrp; |
2675 | int subsys_id; | 2760 | int subsys_id; |
2676 | int count = 0; | 2761 | int count = 0; |
2677 | 2762 | ||
2678 | /* Skip this hierarchy if it has no active subsystems */ | ||
2679 | if (!root->actual_subsys_bits) | ||
2680 | continue; | ||
2681 | seq_printf(m, "%lu:", root->subsys_bits); | 2763 | seq_printf(m, "%lu:", root->subsys_bits); |
2682 | for_each_subsys(root, ss) | 2764 | for_each_subsys(root, ss) |
2683 | seq_printf(m, "%s%s", count++ ? "," : "", ss->name); | 2765 | seq_printf(m, "%s%s", count++ ? "," : "", ss->name); |
@@ -2800,8 +2882,10 @@ void cgroup_post_fork(struct task_struct *child) | |||
2800 | { | 2882 | { |
2801 | if (use_task_css_set_links) { | 2883 | if (use_task_css_set_links) { |
2802 | write_lock(&css_set_lock); | 2884 | write_lock(&css_set_lock); |
2885 | task_lock(child); | ||
2803 | if (list_empty(&child->cg_list)) | 2886 | if (list_empty(&child->cg_list)) |
2804 | list_add(&child->cg_list, &child->cgroups->tasks); | 2887 | list_add(&child->cg_list, &child->cgroups->tasks); |
2888 | task_unlock(child); | ||
2805 | write_unlock(&css_set_lock); | 2889 | write_unlock(&css_set_lock); |
2806 | } | 2890 | } |
2807 | } | 2891 | } |
@@ -2907,6 +2991,7 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys, | |||
2907 | mutex_unlock(&cgroup_mutex); | 2991 | mutex_unlock(&cgroup_mutex); |
2908 | return 0; | 2992 | return 0; |
2909 | } | 2993 | } |
2994 | task_lock(tsk); | ||
2910 | cg = tsk->cgroups; | 2995 | cg = tsk->cgroups; |
2911 | parent = task_cgroup(tsk, subsys->subsys_id); | 2996 | parent = task_cgroup(tsk, subsys->subsys_id); |
2912 | 2997 | ||
@@ -2919,6 +3004,7 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys, | |||
2919 | 3004 | ||
2920 | /* Keep the cgroup alive */ | 3005 | /* Keep the cgroup alive */ |
2921 | get_css_set(cg); | 3006 | get_css_set(cg); |
3007 | task_unlock(tsk); | ||
2922 | mutex_unlock(&cgroup_mutex); | 3008 | mutex_unlock(&cgroup_mutex); |
2923 | 3009 | ||
2924 | /* Now do the VFS work to create a cgroup */ | 3010 | /* Now do the VFS work to create a cgroup */ |
@@ -2937,7 +3023,7 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys, | |||
2937 | } | 3023 | } |
2938 | 3024 | ||
2939 | /* Create the cgroup directory, which also creates the cgroup */ | 3025 | /* Create the cgroup directory, which also creates the cgroup */ |
2940 | ret = vfs_mkdir(inode, dentry, S_IFDIR | 0755); | 3026 | ret = vfs_mkdir(inode, dentry, 0755); |
2941 | child = __d_cgrp(dentry); | 3027 | child = __d_cgrp(dentry); |
2942 | dput(dentry); | 3028 | dput(dentry); |
2943 | if (ret) { | 3029 | if (ret) { |
@@ -2947,13 +3033,6 @@ int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *subsys, | |||
2947 | goto out_release; | 3033 | goto out_release; |
2948 | } | 3034 | } |
2949 | 3035 | ||
2950 | if (!child) { | ||
2951 | printk(KERN_INFO | ||
2952 | "Couldn't find new cgroup %s\n", nodename); | ||
2953 | ret = -ENOMEM; | ||
2954 | goto out_release; | ||
2955 | } | ||
2956 | |||
2957 | /* The cgroup now exists. Retake cgroup_mutex and check | 3036 | /* The cgroup now exists. Retake cgroup_mutex and check |
2958 | * that we're still in the same state that we thought we | 3037 | * that we're still in the same state that we thought we |
2959 | * were. */ | 3038 | * were. */ |
@@ -3049,7 +3128,8 @@ void __css_put(struct cgroup_subsys_state *css) | |||
3049 | { | 3128 | { |
3050 | struct cgroup *cgrp = css->cgroup; | 3129 | struct cgroup *cgrp = css->cgroup; |
3051 | rcu_read_lock(); | 3130 | rcu_read_lock(); |
3052 | if (atomic_dec_and_test(&css->refcnt) && notify_on_release(cgrp)) { | 3131 | if ((atomic_dec_return(&css->refcnt) == 1) && |
3132 | notify_on_release(cgrp)) { | ||
3053 | set_bit(CGRP_RELEASABLE, &cgrp->flags); | 3133 | set_bit(CGRP_RELEASABLE, &cgrp->flags); |
3054 | check_for_release(cgrp); | 3134 | check_for_release(cgrp); |
3055 | } | 3135 | } |
diff --git a/kernel/cpuset.c b/kernel/cpuset.c index 345ace5117de..647c77a88fcb 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c | |||
@@ -84,7 +84,7 @@ struct cpuset { | |||
84 | struct cgroup_subsys_state css; | 84 | struct cgroup_subsys_state css; |
85 | 85 | ||
86 | unsigned long flags; /* "unsigned long" so bitops work */ | 86 | unsigned long flags; /* "unsigned long" so bitops work */ |
87 | cpumask_t cpus_allowed; /* CPUs allowed to tasks in cpuset */ | 87 | cpumask_var_t cpus_allowed; /* CPUs allowed to tasks in cpuset */ |
88 | nodemask_t mems_allowed; /* Memory Nodes allowed to tasks */ | 88 | nodemask_t mems_allowed; /* Memory Nodes allowed to tasks */ |
89 | 89 | ||
90 | struct cpuset *parent; /* my parent */ | 90 | struct cpuset *parent; /* my parent */ |
@@ -195,8 +195,6 @@ static int cpuset_mems_generation; | |||
195 | 195 | ||
196 | static struct cpuset top_cpuset = { | 196 | static struct cpuset top_cpuset = { |
197 | .flags = ((1 << CS_CPU_EXCLUSIVE) | (1 << CS_MEM_EXCLUSIVE)), | 197 | .flags = ((1 << CS_CPU_EXCLUSIVE) | (1 << CS_MEM_EXCLUSIVE)), |
198 | .cpus_allowed = CPU_MASK_ALL, | ||
199 | .mems_allowed = NODE_MASK_ALL, | ||
200 | }; | 198 | }; |
201 | 199 | ||
202 | /* | 200 | /* |
@@ -278,7 +276,7 @@ static struct file_system_type cpuset_fs_type = { | |||
278 | }; | 276 | }; |
279 | 277 | ||
280 | /* | 278 | /* |
281 | * Return in *pmask the portion of a cpusets's cpus_allowed that | 279 | * Return in pmask the portion of a cpusets's cpus_allowed that |
282 | * are online. If none are online, walk up the cpuset hierarchy | 280 | * are online. If none are online, walk up the cpuset hierarchy |
283 | * until we find one that does have some online cpus. If we get | 281 | * until we find one that does have some online cpus. If we get |
284 | * all the way to the top and still haven't found any online cpus, | 282 | * all the way to the top and still haven't found any online cpus, |
@@ -291,15 +289,16 @@ static struct file_system_type cpuset_fs_type = { | |||
291 | * Call with callback_mutex held. | 289 | * Call with callback_mutex held. |
292 | */ | 290 | */ |
293 | 291 | ||
294 | static void guarantee_online_cpus(const struct cpuset *cs, cpumask_t *pmask) | 292 | static void guarantee_online_cpus(const struct cpuset *cs, |
293 | struct cpumask *pmask) | ||
295 | { | 294 | { |
296 | while (cs && !cpus_intersects(cs->cpus_allowed, cpu_online_map)) | 295 | while (cs && !cpumask_intersects(cs->cpus_allowed, cpu_online_mask)) |
297 | cs = cs->parent; | 296 | cs = cs->parent; |
298 | if (cs) | 297 | if (cs) |
299 | cpus_and(*pmask, cs->cpus_allowed, cpu_online_map); | 298 | cpumask_and(pmask, cs->cpus_allowed, cpu_online_mask); |
300 | else | 299 | else |
301 | *pmask = cpu_online_map; | 300 | cpumask_copy(pmask, cpu_online_mask); |
302 | BUG_ON(!cpus_intersects(*pmask, cpu_online_map)); | 301 | BUG_ON(!cpumask_intersects(pmask, cpu_online_mask)); |
303 | } | 302 | } |
304 | 303 | ||
305 | /* | 304 | /* |
@@ -375,14 +374,9 @@ void cpuset_update_task_memory_state(void) | |||
375 | struct task_struct *tsk = current; | 374 | struct task_struct *tsk = current; |
376 | struct cpuset *cs; | 375 | struct cpuset *cs; |
377 | 376 | ||
378 | if (task_cs(tsk) == &top_cpuset) { | 377 | rcu_read_lock(); |
379 | /* Don't need rcu for top_cpuset. It's never freed. */ | 378 | my_cpusets_mem_gen = task_cs(tsk)->mems_generation; |
380 | my_cpusets_mem_gen = top_cpuset.mems_generation; | 379 | rcu_read_unlock(); |
381 | } else { | ||
382 | rcu_read_lock(); | ||
383 | my_cpusets_mem_gen = task_cs(tsk)->mems_generation; | ||
384 | rcu_read_unlock(); | ||
385 | } | ||
386 | 380 | ||
387 | if (my_cpusets_mem_gen != tsk->cpuset_mems_generation) { | 381 | if (my_cpusets_mem_gen != tsk->cpuset_mems_generation) { |
388 | mutex_lock(&callback_mutex); | 382 | mutex_lock(&callback_mutex); |
@@ -414,12 +408,43 @@ void cpuset_update_task_memory_state(void) | |||
414 | 408 | ||
415 | static int is_cpuset_subset(const struct cpuset *p, const struct cpuset *q) | 409 | static int is_cpuset_subset(const struct cpuset *p, const struct cpuset *q) |
416 | { | 410 | { |
417 | return cpus_subset(p->cpus_allowed, q->cpus_allowed) && | 411 | return cpumask_subset(p->cpus_allowed, q->cpus_allowed) && |
418 | nodes_subset(p->mems_allowed, q->mems_allowed) && | 412 | nodes_subset(p->mems_allowed, q->mems_allowed) && |
419 | is_cpu_exclusive(p) <= is_cpu_exclusive(q) && | 413 | is_cpu_exclusive(p) <= is_cpu_exclusive(q) && |
420 | is_mem_exclusive(p) <= is_mem_exclusive(q); | 414 | is_mem_exclusive(p) <= is_mem_exclusive(q); |
421 | } | 415 | } |
422 | 416 | ||
417 | /** | ||
418 | * alloc_trial_cpuset - allocate a trial cpuset | ||
419 | * @cs: the cpuset that the trial cpuset duplicates | ||
420 | */ | ||
421 | static struct cpuset *alloc_trial_cpuset(const struct cpuset *cs) | ||
422 | { | ||
423 | struct cpuset *trial; | ||
424 | |||
425 | trial = kmemdup(cs, sizeof(*cs), GFP_KERNEL); | ||
426 | if (!trial) | ||
427 | return NULL; | ||
428 | |||
429 | if (!alloc_cpumask_var(&trial->cpus_allowed, GFP_KERNEL)) { | ||
430 | kfree(trial); | ||
431 | return NULL; | ||
432 | } | ||
433 | cpumask_copy(trial->cpus_allowed, cs->cpus_allowed); | ||
434 | |||
435 | return trial; | ||
436 | } | ||
437 | |||
438 | /** | ||
439 | * free_trial_cpuset - free the trial cpuset | ||
440 | * @trial: the trial cpuset to be freed | ||
441 | */ | ||
442 | static void free_trial_cpuset(struct cpuset *trial) | ||
443 | { | ||
444 | free_cpumask_var(trial->cpus_allowed); | ||
445 | kfree(trial); | ||
446 | } | ||
447 | |||
423 | /* | 448 | /* |
424 | * validate_change() - Used to validate that any proposed cpuset change | 449 | * validate_change() - Used to validate that any proposed cpuset change |
425 | * follows the structural rules for cpusets. | 450 | * follows the structural rules for cpusets. |
@@ -469,7 +494,7 @@ static int validate_change(const struct cpuset *cur, const struct cpuset *trial) | |||
469 | c = cgroup_cs(cont); | 494 | c = cgroup_cs(cont); |
470 | if ((is_cpu_exclusive(trial) || is_cpu_exclusive(c)) && | 495 | if ((is_cpu_exclusive(trial) || is_cpu_exclusive(c)) && |
471 | c != cur && | 496 | c != cur && |
472 | cpus_intersects(trial->cpus_allowed, c->cpus_allowed)) | 497 | cpumask_intersects(trial->cpus_allowed, c->cpus_allowed)) |
473 | return -EINVAL; | 498 | return -EINVAL; |
474 | if ((is_mem_exclusive(trial) || is_mem_exclusive(c)) && | 499 | if ((is_mem_exclusive(trial) || is_mem_exclusive(c)) && |
475 | c != cur && | 500 | c != cur && |
@@ -479,7 +504,7 @@ static int validate_change(const struct cpuset *cur, const struct cpuset *trial) | |||
479 | 504 | ||
480 | /* Cpusets with tasks can't have empty cpus_allowed or mems_allowed */ | 505 | /* Cpusets with tasks can't have empty cpus_allowed or mems_allowed */ |
481 | if (cgroup_task_count(cur->css.cgroup)) { | 506 | if (cgroup_task_count(cur->css.cgroup)) { |
482 | if (cpus_empty(trial->cpus_allowed) || | 507 | if (cpumask_empty(trial->cpus_allowed) || |
483 | nodes_empty(trial->mems_allowed)) { | 508 | nodes_empty(trial->mems_allowed)) { |
484 | return -ENOSPC; | 509 | return -ENOSPC; |
485 | } | 510 | } |
@@ -494,7 +519,7 @@ static int validate_change(const struct cpuset *cur, const struct cpuset *trial) | |||
494 | */ | 519 | */ |
495 | static int cpusets_overlap(struct cpuset *a, struct cpuset *b) | 520 | static int cpusets_overlap(struct cpuset *a, struct cpuset *b) |
496 | { | 521 | { |
497 | return cpus_intersects(a->cpus_allowed, b->cpus_allowed); | 522 | return cpumask_intersects(a->cpus_allowed, b->cpus_allowed); |
498 | } | 523 | } |
499 | 524 | ||
500 | static void | 525 | static void |
@@ -519,7 +544,7 @@ update_domain_attr_tree(struct sched_domain_attr *dattr, struct cpuset *c) | |||
519 | cp = list_first_entry(&q, struct cpuset, stack_list); | 544 | cp = list_first_entry(&q, struct cpuset, stack_list); |
520 | list_del(q.next); | 545 | list_del(q.next); |
521 | 546 | ||
522 | if (cpus_empty(cp->cpus_allowed)) | 547 | if (cpumask_empty(cp->cpus_allowed)) |
523 | continue; | 548 | continue; |
524 | 549 | ||
525 | if (is_sched_load_balance(cp)) | 550 | if (is_sched_load_balance(cp)) |
@@ -586,7 +611,8 @@ update_domain_attr_tree(struct sched_domain_attr *dattr, struct cpuset *c) | |||
586 | * element of the partition (one sched domain) to be passed to | 611 | * element of the partition (one sched domain) to be passed to |
587 | * partition_sched_domains(). | 612 | * partition_sched_domains(). |
588 | */ | 613 | */ |
589 | static int generate_sched_domains(cpumask_t **domains, | 614 | /* FIXME: see the FIXME in partition_sched_domains() */ |
615 | static int generate_sched_domains(struct cpumask **domains, | ||
590 | struct sched_domain_attr **attributes) | 616 | struct sched_domain_attr **attributes) |
591 | { | 617 | { |
592 | LIST_HEAD(q); /* queue of cpusets to be scanned */ | 618 | LIST_HEAD(q); /* queue of cpusets to be scanned */ |
@@ -594,10 +620,10 @@ static int generate_sched_domains(cpumask_t **domains, | |||
594 | struct cpuset **csa; /* array of all cpuset ptrs */ | 620 | struct cpuset **csa; /* array of all cpuset ptrs */ |
595 | int csn; /* how many cpuset ptrs in csa so far */ | 621 | int csn; /* how many cpuset ptrs in csa so far */ |
596 | int i, j, k; /* indices for partition finding loops */ | 622 | int i, j, k; /* indices for partition finding loops */ |
597 | cpumask_t *doms; /* resulting partition; i.e. sched domains */ | 623 | struct cpumask *doms; /* resulting partition; i.e. sched domains */ |
598 | struct sched_domain_attr *dattr; /* attributes for custom domains */ | 624 | struct sched_domain_attr *dattr; /* attributes for custom domains */ |
599 | int ndoms = 0; /* number of sched domains in result */ | 625 | int ndoms = 0; /* number of sched domains in result */ |
600 | int nslot; /* next empty doms[] cpumask_t slot */ | 626 | int nslot; /* next empty doms[] struct cpumask slot */ |
601 | 627 | ||
602 | doms = NULL; | 628 | doms = NULL; |
603 | dattr = NULL; | 629 | dattr = NULL; |
@@ -605,7 +631,7 @@ static int generate_sched_domains(cpumask_t **domains, | |||
605 | 631 | ||
606 | /* Special case for the 99% of systems with one, full, sched domain */ | 632 | /* Special case for the 99% of systems with one, full, sched domain */ |
607 | if (is_sched_load_balance(&top_cpuset)) { | 633 | if (is_sched_load_balance(&top_cpuset)) { |
608 | doms = kmalloc(sizeof(cpumask_t), GFP_KERNEL); | 634 | doms = kmalloc(cpumask_size(), GFP_KERNEL); |
609 | if (!doms) | 635 | if (!doms) |
610 | goto done; | 636 | goto done; |
611 | 637 | ||
@@ -614,7 +640,7 @@ static int generate_sched_domains(cpumask_t **domains, | |||
614 | *dattr = SD_ATTR_INIT; | 640 | *dattr = SD_ATTR_INIT; |
615 | update_domain_attr_tree(dattr, &top_cpuset); | 641 | update_domain_attr_tree(dattr, &top_cpuset); |
616 | } | 642 | } |
617 | *doms = top_cpuset.cpus_allowed; | 643 | cpumask_copy(doms, top_cpuset.cpus_allowed); |
618 | 644 | ||
619 | ndoms = 1; | 645 | ndoms = 1; |
620 | goto done; | 646 | goto done; |
@@ -633,7 +659,7 @@ static int generate_sched_domains(cpumask_t **domains, | |||
633 | cp = list_first_entry(&q, struct cpuset, stack_list); | 659 | cp = list_first_entry(&q, struct cpuset, stack_list); |
634 | list_del(q.next); | 660 | list_del(q.next); |
635 | 661 | ||
636 | if (cpus_empty(cp->cpus_allowed)) | 662 | if (cpumask_empty(cp->cpus_allowed)) |
637 | continue; | 663 | continue; |
638 | 664 | ||
639 | /* | 665 | /* |
@@ -684,7 +710,7 @@ restart: | |||
684 | * Now we know how many domains to create. | 710 | * Now we know how many domains to create. |
685 | * Convert <csn, csa> to <ndoms, doms> and populate cpu masks. | 711 | * Convert <csn, csa> to <ndoms, doms> and populate cpu masks. |
686 | */ | 712 | */ |
687 | doms = kmalloc(ndoms * sizeof(cpumask_t), GFP_KERNEL); | 713 | doms = kmalloc(ndoms * cpumask_size(), GFP_KERNEL); |
688 | if (!doms) | 714 | if (!doms) |
689 | goto done; | 715 | goto done; |
690 | 716 | ||
@@ -696,7 +722,7 @@ restart: | |||
696 | 722 | ||
697 | for (nslot = 0, i = 0; i < csn; i++) { | 723 | for (nslot = 0, i = 0; i < csn; i++) { |
698 | struct cpuset *a = csa[i]; | 724 | struct cpuset *a = csa[i]; |
699 | cpumask_t *dp; | 725 | struct cpumask *dp; |
700 | int apn = a->pn; | 726 | int apn = a->pn; |
701 | 727 | ||
702 | if (apn < 0) { | 728 | if (apn < 0) { |
@@ -719,14 +745,14 @@ restart: | |||
719 | continue; | 745 | continue; |
720 | } | 746 | } |
721 | 747 | ||
722 | cpus_clear(*dp); | 748 | cpumask_clear(dp); |
723 | if (dattr) | 749 | if (dattr) |
724 | *(dattr + nslot) = SD_ATTR_INIT; | 750 | *(dattr + nslot) = SD_ATTR_INIT; |
725 | for (j = i; j < csn; j++) { | 751 | for (j = i; j < csn; j++) { |
726 | struct cpuset *b = csa[j]; | 752 | struct cpuset *b = csa[j]; |
727 | 753 | ||
728 | if (apn == b->pn) { | 754 | if (apn == b->pn) { |
729 | cpus_or(*dp, *dp, b->cpus_allowed); | 755 | cpumask_or(dp, dp, b->cpus_allowed); |
730 | if (dattr) | 756 | if (dattr) |
731 | update_domain_attr_tree(dattr + nslot, b); | 757 | update_domain_attr_tree(dattr + nslot, b); |
732 | 758 | ||
@@ -766,7 +792,7 @@ done: | |||
766 | static void do_rebuild_sched_domains(struct work_struct *unused) | 792 | static void do_rebuild_sched_domains(struct work_struct *unused) |
767 | { | 793 | { |
768 | struct sched_domain_attr *attr; | 794 | struct sched_domain_attr *attr; |
769 | cpumask_t *doms; | 795 | struct cpumask *doms; |
770 | int ndoms; | 796 | int ndoms; |
771 | 797 | ||
772 | get_online_cpus(); | 798 | get_online_cpus(); |
@@ -835,7 +861,7 @@ void rebuild_sched_domains(void) | |||
835 | static int cpuset_test_cpumask(struct task_struct *tsk, | 861 | static int cpuset_test_cpumask(struct task_struct *tsk, |
836 | struct cgroup_scanner *scan) | 862 | struct cgroup_scanner *scan) |
837 | { | 863 | { |
838 | return !cpus_equal(tsk->cpus_allowed, | 864 | return !cpumask_equal(&tsk->cpus_allowed, |
839 | (cgroup_cs(scan->cg))->cpus_allowed); | 865 | (cgroup_cs(scan->cg))->cpus_allowed); |
840 | } | 866 | } |
841 | 867 | ||
@@ -853,7 +879,7 @@ static int cpuset_test_cpumask(struct task_struct *tsk, | |||
853 | static void cpuset_change_cpumask(struct task_struct *tsk, | 879 | static void cpuset_change_cpumask(struct task_struct *tsk, |
854 | struct cgroup_scanner *scan) | 880 | struct cgroup_scanner *scan) |
855 | { | 881 | { |
856 | set_cpus_allowed_ptr(tsk, &((cgroup_cs(scan->cg))->cpus_allowed)); | 882 | set_cpus_allowed_ptr(tsk, ((cgroup_cs(scan->cg))->cpus_allowed)); |
857 | } | 883 | } |
858 | 884 | ||
859 | /** | 885 | /** |
@@ -885,10 +911,10 @@ static void update_tasks_cpumask(struct cpuset *cs, struct ptr_heap *heap) | |||
885 | * @cs: the cpuset to consider | 911 | * @cs: the cpuset to consider |
886 | * @buf: buffer of cpu numbers written to this cpuset | 912 | * @buf: buffer of cpu numbers written to this cpuset |
887 | */ | 913 | */ |
888 | static int update_cpumask(struct cpuset *cs, const char *buf) | 914 | static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs, |
915 | const char *buf) | ||
889 | { | 916 | { |
890 | struct ptr_heap heap; | 917 | struct ptr_heap heap; |
891 | struct cpuset trialcs; | ||
892 | int retval; | 918 | int retval; |
893 | int is_load_balanced; | 919 | int is_load_balanced; |
894 | 920 | ||
@@ -896,8 +922,6 @@ static int update_cpumask(struct cpuset *cs, const char *buf) | |||
896 | if (cs == &top_cpuset) | 922 | if (cs == &top_cpuset) |
897 | return -EACCES; | 923 | return -EACCES; |
898 | 924 | ||
899 | trialcs = *cs; | ||
900 | |||
901 | /* | 925 | /* |
902 | * An empty cpus_allowed is ok only if the cpuset has no tasks. | 926 | * An empty cpus_allowed is ok only if the cpuset has no tasks. |
903 | * Since cpulist_parse() fails on an empty mask, we special case | 927 | * Since cpulist_parse() fails on an empty mask, we special case |
@@ -905,31 +929,31 @@ static int update_cpumask(struct cpuset *cs, const char *buf) | |||
905 | * with tasks have cpus. | 929 | * with tasks have cpus. |
906 | */ | 930 | */ |
907 | if (!*buf) { | 931 | if (!*buf) { |
908 | cpus_clear(trialcs.cpus_allowed); | 932 | cpumask_clear(trialcs->cpus_allowed); |
909 | } else { | 933 | } else { |
910 | retval = cpulist_parse(buf, &trialcs.cpus_allowed); | 934 | retval = cpulist_parse(buf, trialcs->cpus_allowed); |
911 | if (retval < 0) | 935 | if (retval < 0) |
912 | return retval; | 936 | return retval; |
913 | 937 | ||
914 | if (!cpus_subset(trialcs.cpus_allowed, cpu_online_map)) | 938 | if (!cpumask_subset(trialcs->cpus_allowed, cpu_online_mask)) |
915 | return -EINVAL; | 939 | return -EINVAL; |
916 | } | 940 | } |
917 | retval = validate_change(cs, &trialcs); | 941 | retval = validate_change(cs, trialcs); |
918 | if (retval < 0) | 942 | if (retval < 0) |
919 | return retval; | 943 | return retval; |
920 | 944 | ||
921 | /* Nothing to do if the cpus didn't change */ | 945 | /* Nothing to do if the cpus didn't change */ |
922 | if (cpus_equal(cs->cpus_allowed, trialcs.cpus_allowed)) | 946 | if (cpumask_equal(cs->cpus_allowed, trialcs->cpus_allowed)) |
923 | return 0; | 947 | return 0; |
924 | 948 | ||
925 | retval = heap_init(&heap, PAGE_SIZE, GFP_KERNEL, NULL); | 949 | retval = heap_init(&heap, PAGE_SIZE, GFP_KERNEL, NULL); |
926 | if (retval) | 950 | if (retval) |
927 | return retval; | 951 | return retval; |
928 | 952 | ||
929 | is_load_balanced = is_sched_load_balance(&trialcs); | 953 | is_load_balanced = is_sched_load_balance(trialcs); |
930 | 954 | ||
931 | mutex_lock(&callback_mutex); | 955 | mutex_lock(&callback_mutex); |
932 | cs->cpus_allowed = trialcs.cpus_allowed; | 956 | cpumask_copy(cs->cpus_allowed, trialcs->cpus_allowed); |
933 | mutex_unlock(&callback_mutex); | 957 | mutex_unlock(&callback_mutex); |
934 | 958 | ||
935 | /* | 959 | /* |
@@ -1017,7 +1041,7 @@ static int update_tasks_nodemask(struct cpuset *cs, const nodemask_t *oldmem) | |||
1017 | cpuset_being_rebound = cs; /* causes mpol_dup() rebind */ | 1041 | cpuset_being_rebound = cs; /* causes mpol_dup() rebind */ |
1018 | 1042 | ||
1019 | fudge = 10; /* spare mmarray[] slots */ | 1043 | fudge = 10; /* spare mmarray[] slots */ |
1020 | fudge += cpus_weight(cs->cpus_allowed); /* imagine one fork-bomb/cpu */ | 1044 | fudge += cpumask_weight(cs->cpus_allowed);/* imagine 1 fork-bomb/cpu */ |
1021 | retval = -ENOMEM; | 1045 | retval = -ENOMEM; |
1022 | 1046 | ||
1023 | /* | 1047 | /* |
@@ -1104,9 +1128,9 @@ done: | |||
1104 | * lock each such tasks mm->mmap_sem, scan its vma's and rebind | 1128 | * lock each such tasks mm->mmap_sem, scan its vma's and rebind |
1105 | * their mempolicies to the cpusets new mems_allowed. | 1129 | * their mempolicies to the cpusets new mems_allowed. |
1106 | */ | 1130 | */ |
1107 | static int update_nodemask(struct cpuset *cs, const char *buf) | 1131 | static int update_nodemask(struct cpuset *cs, struct cpuset *trialcs, |
1132 | const char *buf) | ||
1108 | { | 1133 | { |
1109 | struct cpuset trialcs; | ||
1110 | nodemask_t oldmem; | 1134 | nodemask_t oldmem; |
1111 | int retval; | 1135 | int retval; |
1112 | 1136 | ||
@@ -1117,8 +1141,6 @@ static int update_nodemask(struct cpuset *cs, const char *buf) | |||
1117 | if (cs == &top_cpuset) | 1141 | if (cs == &top_cpuset) |
1118 | return -EACCES; | 1142 | return -EACCES; |
1119 | 1143 | ||
1120 | trialcs = *cs; | ||
1121 | |||
1122 | /* | 1144 | /* |
1123 | * An empty mems_allowed is ok iff there are no tasks in the cpuset. | 1145 | * An empty mems_allowed is ok iff there are no tasks in the cpuset. |
1124 | * Since nodelist_parse() fails on an empty mask, we special case | 1146 | * Since nodelist_parse() fails on an empty mask, we special case |
@@ -1126,27 +1148,27 @@ static int update_nodemask(struct cpuset *cs, const char *buf) | |||
1126 | * with tasks have memory. | 1148 | * with tasks have memory. |
1127 | */ | 1149 | */ |
1128 | if (!*buf) { | 1150 | if (!*buf) { |
1129 | nodes_clear(trialcs.mems_allowed); | 1151 | nodes_clear(trialcs->mems_allowed); |
1130 | } else { | 1152 | } else { |
1131 | retval = nodelist_parse(buf, trialcs.mems_allowed); | 1153 | retval = nodelist_parse(buf, trialcs->mems_allowed); |
1132 | if (retval < 0) | 1154 | if (retval < 0) |
1133 | goto done; | 1155 | goto done; |
1134 | 1156 | ||
1135 | if (!nodes_subset(trialcs.mems_allowed, | 1157 | if (!nodes_subset(trialcs->mems_allowed, |
1136 | node_states[N_HIGH_MEMORY])) | 1158 | node_states[N_HIGH_MEMORY])) |
1137 | return -EINVAL; | 1159 | return -EINVAL; |
1138 | } | 1160 | } |
1139 | oldmem = cs->mems_allowed; | 1161 | oldmem = cs->mems_allowed; |
1140 | if (nodes_equal(oldmem, trialcs.mems_allowed)) { | 1162 | if (nodes_equal(oldmem, trialcs->mems_allowed)) { |
1141 | retval = 0; /* Too easy - nothing to do */ | 1163 | retval = 0; /* Too easy - nothing to do */ |
1142 | goto done; | 1164 | goto done; |
1143 | } | 1165 | } |
1144 | retval = validate_change(cs, &trialcs); | 1166 | retval = validate_change(cs, trialcs); |
1145 | if (retval < 0) | 1167 | if (retval < 0) |
1146 | goto done; | 1168 | goto done; |
1147 | 1169 | ||
1148 | mutex_lock(&callback_mutex); | 1170 | mutex_lock(&callback_mutex); |
1149 | cs->mems_allowed = trialcs.mems_allowed; | 1171 | cs->mems_allowed = trialcs->mems_allowed; |
1150 | cs->mems_generation = cpuset_mems_generation++; | 1172 | cs->mems_generation = cpuset_mems_generation++; |
1151 | mutex_unlock(&callback_mutex); | 1173 | mutex_unlock(&callback_mutex); |
1152 | 1174 | ||
@@ -1167,7 +1189,8 @@ static int update_relax_domain_level(struct cpuset *cs, s64 val) | |||
1167 | 1189 | ||
1168 | if (val != cs->relax_domain_level) { | 1190 | if (val != cs->relax_domain_level) { |
1169 | cs->relax_domain_level = val; | 1191 | cs->relax_domain_level = val; |
1170 | if (!cpus_empty(cs->cpus_allowed) && is_sched_load_balance(cs)) | 1192 | if (!cpumask_empty(cs->cpus_allowed) && |
1193 | is_sched_load_balance(cs)) | ||
1171 | async_rebuild_sched_domains(); | 1194 | async_rebuild_sched_domains(); |
1172 | } | 1195 | } |
1173 | 1196 | ||
@@ -1186,31 +1209,36 @@ static int update_relax_domain_level(struct cpuset *cs, s64 val) | |||
1186 | static int update_flag(cpuset_flagbits_t bit, struct cpuset *cs, | 1209 | static int update_flag(cpuset_flagbits_t bit, struct cpuset *cs, |
1187 | int turning_on) | 1210 | int turning_on) |
1188 | { | 1211 | { |
1189 | struct cpuset trialcs; | 1212 | struct cpuset *trialcs; |
1190 | int err; | 1213 | int err; |
1191 | int balance_flag_changed; | 1214 | int balance_flag_changed; |
1192 | 1215 | ||
1193 | trialcs = *cs; | 1216 | trialcs = alloc_trial_cpuset(cs); |
1217 | if (!trialcs) | ||
1218 | return -ENOMEM; | ||
1219 | |||
1194 | if (turning_on) | 1220 | if (turning_on) |
1195 | set_bit(bit, &trialcs.flags); | 1221 | set_bit(bit, &trialcs->flags); |
1196 | else | 1222 | else |
1197 | clear_bit(bit, &trialcs.flags); | 1223 | clear_bit(bit, &trialcs->flags); |
1198 | 1224 | ||
1199 | err = validate_change(cs, &trialcs); | 1225 | err = validate_change(cs, trialcs); |
1200 | if (err < 0) | 1226 | if (err < 0) |
1201 | return err; | 1227 | goto out; |
1202 | 1228 | ||
1203 | balance_flag_changed = (is_sched_load_balance(cs) != | 1229 | balance_flag_changed = (is_sched_load_balance(cs) != |
1204 | is_sched_load_balance(&trialcs)); | 1230 | is_sched_load_balance(trialcs)); |
1205 | 1231 | ||
1206 | mutex_lock(&callback_mutex); | 1232 | mutex_lock(&callback_mutex); |
1207 | cs->flags = trialcs.flags; | 1233 | cs->flags = trialcs->flags; |
1208 | mutex_unlock(&callback_mutex); | 1234 | mutex_unlock(&callback_mutex); |
1209 | 1235 | ||
1210 | if (!cpus_empty(trialcs.cpus_allowed) && balance_flag_changed) | 1236 | if (!cpumask_empty(trialcs->cpus_allowed) && balance_flag_changed) |
1211 | async_rebuild_sched_domains(); | 1237 | async_rebuild_sched_domains(); |
1212 | 1238 | ||
1213 | return 0; | 1239 | out: |
1240 | free_trial_cpuset(trialcs); | ||
1241 | return err; | ||
1214 | } | 1242 | } |
1215 | 1243 | ||
1216 | /* | 1244 | /* |
@@ -1311,42 +1339,47 @@ static int fmeter_getrate(struct fmeter *fmp) | |||
1311 | return val; | 1339 | return val; |
1312 | } | 1340 | } |
1313 | 1341 | ||
1342 | /* Protected by cgroup_lock */ | ||
1343 | static cpumask_var_t cpus_attach; | ||
1344 | |||
1314 | /* Called by cgroups to determine if a cpuset is usable; cgroup_mutex held */ | 1345 | /* Called by cgroups to determine if a cpuset is usable; cgroup_mutex held */ |
1315 | static int cpuset_can_attach(struct cgroup_subsys *ss, | 1346 | static int cpuset_can_attach(struct cgroup_subsys *ss, |
1316 | struct cgroup *cont, struct task_struct *tsk) | 1347 | struct cgroup *cont, struct task_struct *tsk) |
1317 | { | 1348 | { |
1318 | struct cpuset *cs = cgroup_cs(cont); | 1349 | struct cpuset *cs = cgroup_cs(cont); |
1350 | int ret = 0; | ||
1319 | 1351 | ||
1320 | if (cpus_empty(cs->cpus_allowed) || nodes_empty(cs->mems_allowed)) | 1352 | if (cpumask_empty(cs->cpus_allowed) || nodes_empty(cs->mems_allowed)) |
1321 | return -ENOSPC; | 1353 | return -ENOSPC; |
1322 | if (tsk->flags & PF_THREAD_BOUND) { | ||
1323 | cpumask_t mask; | ||
1324 | 1354 | ||
1355 | if (tsk->flags & PF_THREAD_BOUND) { | ||
1325 | mutex_lock(&callback_mutex); | 1356 | mutex_lock(&callback_mutex); |
1326 | mask = cs->cpus_allowed; | 1357 | if (!cpumask_equal(&tsk->cpus_allowed, cs->cpus_allowed)) |
1358 | ret = -EINVAL; | ||
1327 | mutex_unlock(&callback_mutex); | 1359 | mutex_unlock(&callback_mutex); |
1328 | if (!cpus_equal(tsk->cpus_allowed, mask)) | ||
1329 | return -EINVAL; | ||
1330 | } | 1360 | } |
1331 | 1361 | ||
1332 | return security_task_setscheduler(tsk, 0, NULL); | 1362 | return ret < 0 ? ret : security_task_setscheduler(tsk, 0, NULL); |
1333 | } | 1363 | } |
1334 | 1364 | ||
1335 | static void cpuset_attach(struct cgroup_subsys *ss, | 1365 | static void cpuset_attach(struct cgroup_subsys *ss, |
1336 | struct cgroup *cont, struct cgroup *oldcont, | 1366 | struct cgroup *cont, struct cgroup *oldcont, |
1337 | struct task_struct *tsk) | 1367 | struct task_struct *tsk) |
1338 | { | 1368 | { |
1339 | cpumask_t cpus; | ||
1340 | nodemask_t from, to; | 1369 | nodemask_t from, to; |
1341 | struct mm_struct *mm; | 1370 | struct mm_struct *mm; |
1342 | struct cpuset *cs = cgroup_cs(cont); | 1371 | struct cpuset *cs = cgroup_cs(cont); |
1343 | struct cpuset *oldcs = cgroup_cs(oldcont); | 1372 | struct cpuset *oldcs = cgroup_cs(oldcont); |
1344 | int err; | 1373 | int err; |
1345 | 1374 | ||
1346 | mutex_lock(&callback_mutex); | 1375 | if (cs == &top_cpuset) { |
1347 | guarantee_online_cpus(cs, &cpus); | 1376 | cpumask_copy(cpus_attach, cpu_possible_mask); |
1348 | err = set_cpus_allowed_ptr(tsk, &cpus); | 1377 | } else { |
1349 | mutex_unlock(&callback_mutex); | 1378 | mutex_lock(&callback_mutex); |
1379 | guarantee_online_cpus(cs, cpus_attach); | ||
1380 | mutex_unlock(&callback_mutex); | ||
1381 | } | ||
1382 | err = set_cpus_allowed_ptr(tsk, cpus_attach); | ||
1350 | if (err) | 1383 | if (err) |
1351 | return; | 1384 | return; |
1352 | 1385 | ||
@@ -1359,7 +1392,6 @@ static void cpuset_attach(struct cgroup_subsys *ss, | |||
1359 | cpuset_migrate_mm(mm, &from, &to); | 1392 | cpuset_migrate_mm(mm, &from, &to); |
1360 | mmput(mm); | 1393 | mmput(mm); |
1361 | } | 1394 | } |
1362 | |||
1363 | } | 1395 | } |
1364 | 1396 | ||
1365 | /* The various types of files and directories in a cpuset file system */ | 1397 | /* The various types of files and directories in a cpuset file system */ |
@@ -1454,21 +1486,29 @@ static int cpuset_write_resmask(struct cgroup *cgrp, struct cftype *cft, | |||
1454 | const char *buf) | 1486 | const char *buf) |
1455 | { | 1487 | { |
1456 | int retval = 0; | 1488 | int retval = 0; |
1489 | struct cpuset *cs = cgroup_cs(cgrp); | ||
1490 | struct cpuset *trialcs; | ||
1457 | 1491 | ||
1458 | if (!cgroup_lock_live_group(cgrp)) | 1492 | if (!cgroup_lock_live_group(cgrp)) |
1459 | return -ENODEV; | 1493 | return -ENODEV; |
1460 | 1494 | ||
1495 | trialcs = alloc_trial_cpuset(cs); | ||
1496 | if (!trialcs) | ||
1497 | return -ENOMEM; | ||
1498 | |||
1461 | switch (cft->private) { | 1499 | switch (cft->private) { |
1462 | case FILE_CPULIST: | 1500 | case FILE_CPULIST: |
1463 | retval = update_cpumask(cgroup_cs(cgrp), buf); | 1501 | retval = update_cpumask(cs, trialcs, buf); |
1464 | break; | 1502 | break; |
1465 | case FILE_MEMLIST: | 1503 | case FILE_MEMLIST: |
1466 | retval = update_nodemask(cgroup_cs(cgrp), buf); | 1504 | retval = update_nodemask(cs, trialcs, buf); |
1467 | break; | 1505 | break; |
1468 | default: | 1506 | default: |
1469 | retval = -EINVAL; | 1507 | retval = -EINVAL; |
1470 | break; | 1508 | break; |
1471 | } | 1509 | } |
1510 | |||
1511 | free_trial_cpuset(trialcs); | ||
1472 | cgroup_unlock(); | 1512 | cgroup_unlock(); |
1473 | return retval; | 1513 | return retval; |
1474 | } | 1514 | } |
@@ -1487,13 +1527,13 @@ static int cpuset_write_resmask(struct cgroup *cgrp, struct cftype *cft, | |||
1487 | 1527 | ||
1488 | static int cpuset_sprintf_cpulist(char *page, struct cpuset *cs) | 1528 | static int cpuset_sprintf_cpulist(char *page, struct cpuset *cs) |
1489 | { | 1529 | { |
1490 | cpumask_t mask; | 1530 | int ret; |
1491 | 1531 | ||
1492 | mutex_lock(&callback_mutex); | 1532 | mutex_lock(&callback_mutex); |
1493 | mask = cs->cpus_allowed; | 1533 | ret = cpulist_scnprintf(page, PAGE_SIZE, cs->cpus_allowed); |
1494 | mutex_unlock(&callback_mutex); | 1534 | mutex_unlock(&callback_mutex); |
1495 | 1535 | ||
1496 | return cpulist_scnprintf(page, PAGE_SIZE, &mask); | 1536 | return ret; |
1497 | } | 1537 | } |
1498 | 1538 | ||
1499 | static int cpuset_sprintf_memlist(char *page, struct cpuset *cs) | 1539 | static int cpuset_sprintf_memlist(char *page, struct cpuset *cs) |
@@ -1729,7 +1769,7 @@ static void cpuset_post_clone(struct cgroup_subsys *ss, | |||
1729 | parent_cs = cgroup_cs(parent); | 1769 | parent_cs = cgroup_cs(parent); |
1730 | 1770 | ||
1731 | cs->mems_allowed = parent_cs->mems_allowed; | 1771 | cs->mems_allowed = parent_cs->mems_allowed; |
1732 | cs->cpus_allowed = parent_cs->cpus_allowed; | 1772 | cpumask_copy(cs->cpus_allowed, parent_cs->cpus_allowed); |
1733 | return; | 1773 | return; |
1734 | } | 1774 | } |
1735 | 1775 | ||
@@ -1755,6 +1795,10 @@ static struct cgroup_subsys_state *cpuset_create( | |||
1755 | cs = kmalloc(sizeof(*cs), GFP_KERNEL); | 1795 | cs = kmalloc(sizeof(*cs), GFP_KERNEL); |
1756 | if (!cs) | 1796 | if (!cs) |
1757 | return ERR_PTR(-ENOMEM); | 1797 | return ERR_PTR(-ENOMEM); |
1798 | if (!alloc_cpumask_var(&cs->cpus_allowed, GFP_KERNEL)) { | ||
1799 | kfree(cs); | ||
1800 | return ERR_PTR(-ENOMEM); | ||
1801 | } | ||
1758 | 1802 | ||
1759 | cpuset_update_task_memory_state(); | 1803 | cpuset_update_task_memory_state(); |
1760 | cs->flags = 0; | 1804 | cs->flags = 0; |
@@ -1763,7 +1807,7 @@ static struct cgroup_subsys_state *cpuset_create( | |||
1763 | if (is_spread_slab(parent)) | 1807 | if (is_spread_slab(parent)) |
1764 | set_bit(CS_SPREAD_SLAB, &cs->flags); | 1808 | set_bit(CS_SPREAD_SLAB, &cs->flags); |
1765 | set_bit(CS_SCHED_LOAD_BALANCE, &cs->flags); | 1809 | set_bit(CS_SCHED_LOAD_BALANCE, &cs->flags); |
1766 | cpus_clear(cs->cpus_allowed); | 1810 | cpumask_clear(cs->cpus_allowed); |
1767 | nodes_clear(cs->mems_allowed); | 1811 | nodes_clear(cs->mems_allowed); |
1768 | cs->mems_generation = cpuset_mems_generation++; | 1812 | cs->mems_generation = cpuset_mems_generation++; |
1769 | fmeter_init(&cs->fmeter); | 1813 | fmeter_init(&cs->fmeter); |
@@ -1790,6 +1834,7 @@ static void cpuset_destroy(struct cgroup_subsys *ss, struct cgroup *cont) | |||
1790 | update_flag(CS_SCHED_LOAD_BALANCE, cs, 0); | 1834 | update_flag(CS_SCHED_LOAD_BALANCE, cs, 0); |
1791 | 1835 | ||
1792 | number_of_cpusets--; | 1836 | number_of_cpusets--; |
1837 | free_cpumask_var(cs->cpus_allowed); | ||
1793 | kfree(cs); | 1838 | kfree(cs); |
1794 | } | 1839 | } |
1795 | 1840 | ||
@@ -1813,6 +1858,8 @@ struct cgroup_subsys cpuset_subsys = { | |||
1813 | 1858 | ||
1814 | int __init cpuset_init_early(void) | 1859 | int __init cpuset_init_early(void) |
1815 | { | 1860 | { |
1861 | alloc_bootmem_cpumask_var(&top_cpuset.cpus_allowed); | ||
1862 | |||
1816 | top_cpuset.mems_generation = cpuset_mems_generation++; | 1863 | top_cpuset.mems_generation = cpuset_mems_generation++; |
1817 | return 0; | 1864 | return 0; |
1818 | } | 1865 | } |
@@ -1828,7 +1875,7 @@ int __init cpuset_init(void) | |||
1828 | { | 1875 | { |
1829 | int err = 0; | 1876 | int err = 0; |
1830 | 1877 | ||
1831 | cpus_setall(top_cpuset.cpus_allowed); | 1878 | cpumask_setall(top_cpuset.cpus_allowed); |
1832 | nodes_setall(top_cpuset.mems_allowed); | 1879 | nodes_setall(top_cpuset.mems_allowed); |
1833 | 1880 | ||
1834 | fmeter_init(&top_cpuset.fmeter); | 1881 | fmeter_init(&top_cpuset.fmeter); |
@@ -1840,6 +1887,9 @@ int __init cpuset_init(void) | |||
1840 | if (err < 0) | 1887 | if (err < 0) |
1841 | return err; | 1888 | return err; |
1842 | 1889 | ||
1890 | if (!alloc_cpumask_var(&cpus_attach, GFP_KERNEL)) | ||
1891 | BUG(); | ||
1892 | |||
1843 | number_of_cpusets = 1; | 1893 | number_of_cpusets = 1; |
1844 | return 0; | 1894 | return 0; |
1845 | } | 1895 | } |
@@ -1914,7 +1964,7 @@ static void remove_tasks_in_empty_cpuset(struct cpuset *cs) | |||
1914 | * has online cpus, so can't be empty). | 1964 | * has online cpus, so can't be empty). |
1915 | */ | 1965 | */ |
1916 | parent = cs->parent; | 1966 | parent = cs->parent; |
1917 | while (cpus_empty(parent->cpus_allowed) || | 1967 | while (cpumask_empty(parent->cpus_allowed) || |
1918 | nodes_empty(parent->mems_allowed)) | 1968 | nodes_empty(parent->mems_allowed)) |
1919 | parent = parent->parent; | 1969 | parent = parent->parent; |
1920 | 1970 | ||
@@ -1955,7 +2005,7 @@ static void scan_for_empty_cpusets(struct cpuset *root) | |||
1955 | } | 2005 | } |
1956 | 2006 | ||
1957 | /* Continue past cpusets with all cpus, mems online */ | 2007 | /* Continue past cpusets with all cpus, mems online */ |
1958 | if (cpus_subset(cp->cpus_allowed, cpu_online_map) && | 2008 | if (cpumask_subset(cp->cpus_allowed, cpu_online_mask) && |
1959 | nodes_subset(cp->mems_allowed, node_states[N_HIGH_MEMORY])) | 2009 | nodes_subset(cp->mems_allowed, node_states[N_HIGH_MEMORY])) |
1960 | continue; | 2010 | continue; |
1961 | 2011 | ||
@@ -1963,13 +2013,14 @@ static void scan_for_empty_cpusets(struct cpuset *root) | |||
1963 | 2013 | ||
1964 | /* Remove offline cpus and mems from this cpuset. */ | 2014 | /* Remove offline cpus and mems from this cpuset. */ |
1965 | mutex_lock(&callback_mutex); | 2015 | mutex_lock(&callback_mutex); |
1966 | cpus_and(cp->cpus_allowed, cp->cpus_allowed, cpu_online_map); | 2016 | cpumask_and(cp->cpus_allowed, cp->cpus_allowed, |
2017 | cpu_online_mask); | ||
1967 | nodes_and(cp->mems_allowed, cp->mems_allowed, | 2018 | nodes_and(cp->mems_allowed, cp->mems_allowed, |
1968 | node_states[N_HIGH_MEMORY]); | 2019 | node_states[N_HIGH_MEMORY]); |
1969 | mutex_unlock(&callback_mutex); | 2020 | mutex_unlock(&callback_mutex); |
1970 | 2021 | ||
1971 | /* Move tasks from the empty cpuset to a parent */ | 2022 | /* Move tasks from the empty cpuset to a parent */ |
1972 | if (cpus_empty(cp->cpus_allowed) || | 2023 | if (cpumask_empty(cp->cpus_allowed) || |
1973 | nodes_empty(cp->mems_allowed)) | 2024 | nodes_empty(cp->mems_allowed)) |
1974 | remove_tasks_in_empty_cpuset(cp); | 2025 | remove_tasks_in_empty_cpuset(cp); |
1975 | else { | 2026 | else { |
@@ -1995,7 +2046,7 @@ static int cpuset_track_online_cpus(struct notifier_block *unused_nb, | |||
1995 | unsigned long phase, void *unused_cpu) | 2046 | unsigned long phase, void *unused_cpu) |
1996 | { | 2047 | { |
1997 | struct sched_domain_attr *attr; | 2048 | struct sched_domain_attr *attr; |
1998 | cpumask_t *doms; | 2049 | struct cpumask *doms; |
1999 | int ndoms; | 2050 | int ndoms; |
2000 | 2051 | ||
2001 | switch (phase) { | 2052 | switch (phase) { |
@@ -2010,7 +2061,7 @@ static int cpuset_track_online_cpus(struct notifier_block *unused_nb, | |||
2010 | } | 2061 | } |
2011 | 2062 | ||
2012 | cgroup_lock(); | 2063 | cgroup_lock(); |
2013 | top_cpuset.cpus_allowed = cpu_online_map; | 2064 | cpumask_copy(top_cpuset.cpus_allowed, cpu_online_mask); |
2014 | scan_for_empty_cpusets(&top_cpuset); | 2065 | scan_for_empty_cpusets(&top_cpuset); |
2015 | ndoms = generate_sched_domains(&doms, &attr); | 2066 | ndoms = generate_sched_domains(&doms, &attr); |
2016 | cgroup_unlock(); | 2067 | cgroup_unlock(); |
@@ -2055,7 +2106,7 @@ static int cpuset_track_online_nodes(struct notifier_block *self, | |||
2055 | 2106 | ||
2056 | void __init cpuset_init_smp(void) | 2107 | void __init cpuset_init_smp(void) |
2057 | { | 2108 | { |
2058 | top_cpuset.cpus_allowed = cpu_online_map; | 2109 | cpumask_copy(top_cpuset.cpus_allowed, cpu_online_mask); |
2059 | top_cpuset.mems_allowed = node_states[N_HIGH_MEMORY]; | 2110 | top_cpuset.mems_allowed = node_states[N_HIGH_MEMORY]; |
2060 | 2111 | ||
2061 | hotcpu_notifier(cpuset_track_online_cpus, 0); | 2112 | hotcpu_notifier(cpuset_track_online_cpus, 0); |
@@ -2065,15 +2116,15 @@ void __init cpuset_init_smp(void) | |||
2065 | /** | 2116 | /** |
2066 | * cpuset_cpus_allowed - return cpus_allowed mask from a tasks cpuset. | 2117 | * cpuset_cpus_allowed - return cpus_allowed mask from a tasks cpuset. |
2067 | * @tsk: pointer to task_struct from which to obtain cpuset->cpus_allowed. | 2118 | * @tsk: pointer to task_struct from which to obtain cpuset->cpus_allowed. |
2068 | * @pmask: pointer to cpumask_t variable to receive cpus_allowed set. | 2119 | * @pmask: pointer to struct cpumask variable to receive cpus_allowed set. |
2069 | * | 2120 | * |
2070 | * Description: Returns the cpumask_t cpus_allowed of the cpuset | 2121 | * Description: Returns the cpumask_var_t cpus_allowed of the cpuset |
2071 | * attached to the specified @tsk. Guaranteed to return some non-empty | 2122 | * attached to the specified @tsk. Guaranteed to return some non-empty |
2072 | * subset of cpu_online_map, even if this means going outside the | 2123 | * subset of cpu_online_map, even if this means going outside the |
2073 | * tasks cpuset. | 2124 | * tasks cpuset. |
2074 | **/ | 2125 | **/ |
2075 | 2126 | ||
2076 | void cpuset_cpus_allowed(struct task_struct *tsk, cpumask_t *pmask) | 2127 | void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask) |
2077 | { | 2128 | { |
2078 | mutex_lock(&callback_mutex); | 2129 | mutex_lock(&callback_mutex); |
2079 | cpuset_cpus_allowed_locked(tsk, pmask); | 2130 | cpuset_cpus_allowed_locked(tsk, pmask); |
@@ -2084,7 +2135,7 @@ void cpuset_cpus_allowed(struct task_struct *tsk, cpumask_t *pmask) | |||
2084 | * cpuset_cpus_allowed_locked - return cpus_allowed mask from a tasks cpuset. | 2135 | * cpuset_cpus_allowed_locked - return cpus_allowed mask from a tasks cpuset. |
2085 | * Must be called with callback_mutex held. | 2136 | * Must be called with callback_mutex held. |
2086 | **/ | 2137 | **/ |
2087 | void cpuset_cpus_allowed_locked(struct task_struct *tsk, cpumask_t *pmask) | 2138 | void cpuset_cpus_allowed_locked(struct task_struct *tsk, struct cpumask *pmask) |
2088 | { | 2139 | { |
2089 | task_lock(tsk); | 2140 | task_lock(tsk); |
2090 | guarantee_online_cpus(task_cs(tsk), pmask); | 2141 | guarantee_online_cpus(task_cs(tsk), pmask); |
diff --git a/kernel/fork.c b/kernel/fork.c index 7b8f2a78be3d..4018308048cf 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
@@ -1126,12 +1126,12 @@ static struct task_struct *copy_process(unsigned long clone_flags, | |||
1126 | 1126 | ||
1127 | if (pid != &init_struct_pid) { | 1127 | if (pid != &init_struct_pid) { |
1128 | retval = -ENOMEM; | 1128 | retval = -ENOMEM; |
1129 | pid = alloc_pid(task_active_pid_ns(p)); | 1129 | pid = alloc_pid(p->nsproxy->pid_ns); |
1130 | if (!pid) | 1130 | if (!pid) |
1131 | goto bad_fork_cleanup_io; | 1131 | goto bad_fork_cleanup_io; |
1132 | 1132 | ||
1133 | if (clone_flags & CLONE_NEWPID) { | 1133 | if (clone_flags & CLONE_NEWPID) { |
1134 | retval = pid_ns_prepare_proc(task_active_pid_ns(p)); | 1134 | retval = pid_ns_prepare_proc(p->nsproxy->pid_ns); |
1135 | if (retval < 0) | 1135 | if (retval < 0) |
1136 | goto bad_fork_free_pid; | 1136 | goto bad_fork_free_pid; |
1137 | } | 1137 | } |
diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c index 43c2111cd54d..78bc3fdac0d2 100644 --- a/kernel/ns_cgroup.c +++ b/kernel/ns_cgroup.c | |||
@@ -13,7 +13,6 @@ | |||
13 | 13 | ||
14 | struct ns_cgroup { | 14 | struct ns_cgroup { |
15 | struct cgroup_subsys_state css; | 15 | struct cgroup_subsys_state css; |
16 | spinlock_t lock; | ||
17 | }; | 16 | }; |
18 | 17 | ||
19 | struct cgroup_subsys ns_subsys; | 18 | struct cgroup_subsys ns_subsys; |
@@ -84,7 +83,6 @@ static struct cgroup_subsys_state *ns_create(struct cgroup_subsys *ss, | |||
84 | ns_cgroup = kzalloc(sizeof(*ns_cgroup), GFP_KERNEL); | 83 | ns_cgroup = kzalloc(sizeof(*ns_cgroup), GFP_KERNEL); |
85 | if (!ns_cgroup) | 84 | if (!ns_cgroup) |
86 | return ERR_PTR(-ENOMEM); | 85 | return ERR_PTR(-ENOMEM); |
87 | spin_lock_init(&ns_cgroup->lock); | ||
88 | return &ns_cgroup->css; | 86 | return &ns_cgroup->css; |
89 | } | 87 | } |
90 | 88 | ||
diff --git a/kernel/pid.c b/kernel/pid.c index af9224cdd6c0..1b3586fe753a 100644 --- a/kernel/pid.c +++ b/kernel/pid.c | |||
@@ -474,6 +474,12 @@ pid_t task_session_nr_ns(struct task_struct *tsk, struct pid_namespace *ns) | |||
474 | } | 474 | } |
475 | EXPORT_SYMBOL(task_session_nr_ns); | 475 | EXPORT_SYMBOL(task_session_nr_ns); |
476 | 476 | ||
477 | struct pid_namespace *task_active_pid_ns(struct task_struct *tsk) | ||
478 | { | ||
479 | return ns_of_pid(task_pid(tsk)); | ||
480 | } | ||
481 | EXPORT_SYMBOL_GPL(task_active_pid_ns); | ||
482 | |||
477 | /* | 483 | /* |
478 | * Used by proc to find the first pid that is greater than or equal to nr. | 484 | * Used by proc to find the first pid that is greater than or equal to nr. |
479 | * | 485 | * |
diff --git a/kernel/res_counter.c b/kernel/res_counter.c index f275c8eca772..bf8e7534c803 100644 --- a/kernel/res_counter.c +++ b/kernel/res_counter.c | |||
@@ -15,10 +15,11 @@ | |||
15 | #include <linux/uaccess.h> | 15 | #include <linux/uaccess.h> |
16 | #include <linux/mm.h> | 16 | #include <linux/mm.h> |
17 | 17 | ||
18 | void res_counter_init(struct res_counter *counter) | 18 | void res_counter_init(struct res_counter *counter, struct res_counter *parent) |
19 | { | 19 | { |
20 | spin_lock_init(&counter->lock); | 20 | spin_lock_init(&counter->lock); |
21 | counter->limit = (unsigned long long)LLONG_MAX; | 21 | counter->limit = (unsigned long long)LLONG_MAX; |
22 | counter->parent = parent; | ||
22 | } | 23 | } |
23 | 24 | ||
24 | int res_counter_charge_locked(struct res_counter *counter, unsigned long val) | 25 | int res_counter_charge_locked(struct res_counter *counter, unsigned long val) |
@@ -34,14 +35,34 @@ int res_counter_charge_locked(struct res_counter *counter, unsigned long val) | |||
34 | return 0; | 35 | return 0; |
35 | } | 36 | } |
36 | 37 | ||
37 | int res_counter_charge(struct res_counter *counter, unsigned long val) | 38 | int res_counter_charge(struct res_counter *counter, unsigned long val, |
39 | struct res_counter **limit_fail_at) | ||
38 | { | 40 | { |
39 | int ret; | 41 | int ret; |
40 | unsigned long flags; | 42 | unsigned long flags; |
41 | 43 | struct res_counter *c, *u; | |
42 | spin_lock_irqsave(&counter->lock, flags); | 44 | |
43 | ret = res_counter_charge_locked(counter, val); | 45 | *limit_fail_at = NULL; |
44 | spin_unlock_irqrestore(&counter->lock, flags); | 46 | local_irq_save(flags); |
47 | for (c = counter; c != NULL; c = c->parent) { | ||
48 | spin_lock(&c->lock); | ||
49 | ret = res_counter_charge_locked(c, val); | ||
50 | spin_unlock(&c->lock); | ||
51 | if (ret < 0) { | ||
52 | *limit_fail_at = c; | ||
53 | goto undo; | ||
54 | } | ||
55 | } | ||
56 | ret = 0; | ||
57 | goto done; | ||
58 | undo: | ||
59 | for (u = counter; u != c; u = u->parent) { | ||
60 | spin_lock(&u->lock); | ||
61 | res_counter_uncharge_locked(u, val); | ||
62 | spin_unlock(&u->lock); | ||
63 | } | ||
64 | done: | ||
65 | local_irq_restore(flags); | ||
45 | return ret; | 66 | return ret; |
46 | } | 67 | } |
47 | 68 | ||
@@ -56,10 +77,15 @@ void res_counter_uncharge_locked(struct res_counter *counter, unsigned long val) | |||
56 | void res_counter_uncharge(struct res_counter *counter, unsigned long val) | 77 | void res_counter_uncharge(struct res_counter *counter, unsigned long val) |
57 | { | 78 | { |
58 | unsigned long flags; | 79 | unsigned long flags; |
80 | struct res_counter *c; | ||
59 | 81 | ||
60 | spin_lock_irqsave(&counter->lock, flags); | 82 | local_irq_save(flags); |
61 | res_counter_uncharge_locked(counter, val); | 83 | for (c = counter; c != NULL; c = c->parent) { |
62 | spin_unlock_irqrestore(&counter->lock, flags); | 84 | spin_lock(&c->lock); |
85 | res_counter_uncharge_locked(c, val); | ||
86 | spin_unlock(&c->lock); | ||
87 | } | ||
88 | local_irq_restore(flags); | ||
63 | } | 89 | } |
64 | 90 | ||
65 | 91 | ||
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index e0c0b4bc3f08..8e1352c75557 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c | |||
@@ -1617,8 +1617,6 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued) | |||
1617 | } | 1617 | } |
1618 | } | 1618 | } |
1619 | 1619 | ||
1620 | #define swap(a, b) do { typeof(a) tmp = (a); (a) = (b); (b) = tmp; } while (0) | ||
1621 | |||
1622 | /* | 1620 | /* |
1623 | * Share the fairness runtime between parent and child, thus the | 1621 | * Share the fairness runtime between parent and child, thus the |
1624 | * total amount of pressure for CPU stays equal - new tasks | 1622 | * total amount of pressure for CPU stays equal - new tasks |
diff --git a/lib/sort.c b/lib/sort.c index 6abbaf3d5858..926d00429ed2 100644 --- a/lib/sort.c +++ b/lib/sort.c | |||
@@ -32,11 +32,11 @@ static void generic_swap(void *a, void *b, int size) | |||
32 | * @base: pointer to data to sort | 32 | * @base: pointer to data to sort |
33 | * @num: number of elements | 33 | * @num: number of elements |
34 | * @size: size of each element | 34 | * @size: size of each element |
35 | * @cmp: pointer to comparison function | 35 | * @cmp_func: pointer to comparison function |
36 | * @swap: pointer to swap function or NULL | 36 | * @swap_func: pointer to swap function or NULL |
37 | * | 37 | * |
38 | * This function does a heapsort on the given array. You may provide a | 38 | * This function does a heapsort on the given array. You may provide a |
39 | * swap function optimized to your element type. | 39 | * swap_func function optimized to your element type. |
40 | * | 40 | * |
41 | * Sorting time is O(n log n) both on average and worst-case. While | 41 | * Sorting time is O(n log n) both on average and worst-case. While |
42 | * qsort is about 20% faster on average, it suffers from exploitable | 42 | * qsort is about 20% faster on average, it suffers from exploitable |
@@ -45,37 +45,39 @@ static void generic_swap(void *a, void *b, int size) | |||
45 | */ | 45 | */ |
46 | 46 | ||
47 | void sort(void *base, size_t num, size_t size, | 47 | void sort(void *base, size_t num, size_t size, |
48 | int (*cmp)(const void *, const void *), | 48 | int (*cmp_func)(const void *, const void *), |
49 | void (*swap)(void *, void *, int size)) | 49 | void (*swap_func)(void *, void *, int size)) |
50 | { | 50 | { |
51 | /* pre-scale counters for performance */ | 51 | /* pre-scale counters for performance */ |
52 | int i = (num/2 - 1) * size, n = num * size, c, r; | 52 | int i = (num/2 - 1) * size, n = num * size, c, r; |
53 | 53 | ||
54 | if (!swap) | 54 | if (!swap_func) |
55 | swap = (size == 4 ? u32_swap : generic_swap); | 55 | swap_func = (size == 4 ? u32_swap : generic_swap); |
56 | 56 | ||
57 | /* heapify */ | 57 | /* heapify */ |
58 | for ( ; i >= 0; i -= size) { | 58 | for ( ; i >= 0; i -= size) { |
59 | for (r = i; r * 2 + size < n; r = c) { | 59 | for (r = i; r * 2 + size < n; r = c) { |
60 | c = r * 2 + size; | 60 | c = r * 2 + size; |
61 | if (c < n - size && cmp(base + c, base + c + size) < 0) | 61 | if (c < n - size && |
62 | cmp_func(base + c, base + c + size) < 0) | ||
62 | c += size; | 63 | c += size; |
63 | if (cmp(base + r, base + c) >= 0) | 64 | if (cmp_func(base + r, base + c) >= 0) |
64 | break; | 65 | break; |
65 | swap(base + r, base + c, size); | 66 | swap_func(base + r, base + c, size); |
66 | } | 67 | } |
67 | } | 68 | } |
68 | 69 | ||
69 | /* sort */ | 70 | /* sort */ |
70 | for (i = n - size; i > 0; i -= size) { | 71 | for (i = n - size; i > 0; i -= size) { |
71 | swap(base, base + i, size); | 72 | swap_func(base, base + i, size); |
72 | for (r = 0; r * 2 + size < i; r = c) { | 73 | for (r = 0; r * 2 + size < i; r = c) { |
73 | c = r * 2 + size; | 74 | c = r * 2 + size; |
74 | if (c < i - size && cmp(base + c, base + c + size) < 0) | 75 | if (c < i - size && |
76 | cmp_func(base + c, base + c + size) < 0) | ||
75 | c += size; | 77 | c += size; |
76 | if (cmp(base + r, base + c) >= 0) | 78 | if (cmp_func(base + r, base + c) >= 0) |
77 | break; | 79 | break; |
78 | swap(base + r, base + c, size); | 80 | swap_func(base + r, base + c, size); |
79 | } | 81 | } |
80 | } | 82 | } |
81 | } | 83 | } |
diff --git a/mm/filemap.c b/mm/filemap.c index 2f55a1e2baf7..ceba0bd03662 100644 --- a/mm/filemap.c +++ b/mm/filemap.c | |||
@@ -460,7 +460,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping, | |||
460 | VM_BUG_ON(!PageLocked(page)); | 460 | VM_BUG_ON(!PageLocked(page)); |
461 | 461 | ||
462 | error = mem_cgroup_cache_charge(page, current->mm, | 462 | error = mem_cgroup_cache_charge(page, current->mm, |
463 | gfp_mask & ~__GFP_HIGHMEM); | 463 | gfp_mask & GFP_RECLAIM_MASK); |
464 | if (error) | 464 | if (error) |
465 | goto out; | 465 | goto out; |
466 | 466 | ||
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 51ee96545579..e2996b80601f 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c | |||
@@ -21,11 +21,13 @@ | |||
21 | #include <linux/memcontrol.h> | 21 | #include <linux/memcontrol.h> |
22 | #include <linux/cgroup.h> | 22 | #include <linux/cgroup.h> |
23 | #include <linux/mm.h> | 23 | #include <linux/mm.h> |
24 | #include <linux/pagemap.h> | ||
24 | #include <linux/smp.h> | 25 | #include <linux/smp.h> |
25 | #include <linux/page-flags.h> | 26 | #include <linux/page-flags.h> |
26 | #include <linux/backing-dev.h> | 27 | #include <linux/backing-dev.h> |
27 | #include <linux/bit_spinlock.h> | 28 | #include <linux/bit_spinlock.h> |
28 | #include <linux/rcupdate.h> | 29 | #include <linux/rcupdate.h> |
30 | #include <linux/mutex.h> | ||
29 | #include <linux/slab.h> | 31 | #include <linux/slab.h> |
30 | #include <linux/swap.h> | 32 | #include <linux/swap.h> |
31 | #include <linux/spinlock.h> | 33 | #include <linux/spinlock.h> |
@@ -34,12 +36,23 @@ | |||
34 | #include <linux/vmalloc.h> | 36 | #include <linux/vmalloc.h> |
35 | #include <linux/mm_inline.h> | 37 | #include <linux/mm_inline.h> |
36 | #include <linux/page_cgroup.h> | 38 | #include <linux/page_cgroup.h> |
39 | #include "internal.h" | ||
37 | 40 | ||
38 | #include <asm/uaccess.h> | 41 | #include <asm/uaccess.h> |
39 | 42 | ||
40 | struct cgroup_subsys mem_cgroup_subsys __read_mostly; | 43 | struct cgroup_subsys mem_cgroup_subsys __read_mostly; |
41 | #define MEM_CGROUP_RECLAIM_RETRIES 5 | 44 | #define MEM_CGROUP_RECLAIM_RETRIES 5 |
42 | 45 | ||
46 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
47 | /* Turned on only when memory cgroup is enabled && really_do_swap_account = 0 */ | ||
48 | int do_swap_account __read_mostly; | ||
49 | static int really_do_swap_account __initdata = 1; /* for remember boot option*/ | ||
50 | #else | ||
51 | #define do_swap_account (0) | ||
52 | #endif | ||
53 | |||
54 | static DEFINE_MUTEX(memcg_tasklist); /* can be hold under cgroup_mutex */ | ||
55 | |||
43 | /* | 56 | /* |
44 | * Statistics for memory cgroup. | 57 | * Statistics for memory cgroup. |
45 | */ | 58 | */ |
@@ -60,7 +73,7 @@ struct mem_cgroup_stat_cpu { | |||
60 | } ____cacheline_aligned_in_smp; | 73 | } ____cacheline_aligned_in_smp; |
61 | 74 | ||
62 | struct mem_cgroup_stat { | 75 | struct mem_cgroup_stat { |
63 | struct mem_cgroup_stat_cpu cpustat[NR_CPUS]; | 76 | struct mem_cgroup_stat_cpu cpustat[0]; |
64 | }; | 77 | }; |
65 | 78 | ||
66 | /* | 79 | /* |
@@ -89,9 +102,10 @@ struct mem_cgroup_per_zone { | |||
89 | /* | 102 | /* |
90 | * spin_lock to protect the per cgroup LRU | 103 | * spin_lock to protect the per cgroup LRU |
91 | */ | 104 | */ |
92 | spinlock_t lru_lock; | ||
93 | struct list_head lists[NR_LRU_LISTS]; | 105 | struct list_head lists[NR_LRU_LISTS]; |
94 | unsigned long count[NR_LRU_LISTS]; | 106 | unsigned long count[NR_LRU_LISTS]; |
107 | |||
108 | struct zone_reclaim_stat reclaim_stat; | ||
95 | }; | 109 | }; |
96 | /* Macro for accessing counter */ | 110 | /* Macro for accessing counter */ |
97 | #define MEM_CGROUP_ZSTAT(mz, idx) ((mz)->count[(idx)]) | 111 | #define MEM_CGROUP_ZSTAT(mz, idx) ((mz)->count[(idx)]) |
@@ -122,44 +136,73 @@ struct mem_cgroup { | |||
122 | */ | 136 | */ |
123 | struct res_counter res; | 137 | struct res_counter res; |
124 | /* | 138 | /* |
139 | * the counter to account for mem+swap usage. | ||
140 | */ | ||
141 | struct res_counter memsw; | ||
142 | /* | ||
125 | * Per cgroup active and inactive list, similar to the | 143 | * Per cgroup active and inactive list, similar to the |
126 | * per zone LRU lists. | 144 | * per zone LRU lists. |
127 | */ | 145 | */ |
128 | struct mem_cgroup_lru_info info; | 146 | struct mem_cgroup_lru_info info; |
129 | 147 | ||
148 | /* | ||
149 | protect against reclaim related member. | ||
150 | */ | ||
151 | spinlock_t reclaim_param_lock; | ||
152 | |||
130 | int prev_priority; /* for recording reclaim priority */ | 153 | int prev_priority; /* for recording reclaim priority */ |
154 | |||
155 | /* | ||
156 | * While reclaiming in a hiearchy, we cache the last child we | ||
157 | * reclaimed from. Protected by hierarchy_mutex | ||
158 | */ | ||
159 | struct mem_cgroup *last_scanned_child; | ||
131 | /* | 160 | /* |
132 | * statistics. | 161 | * Should the accounting and control be hierarchical, per subtree? |
162 | */ | ||
163 | bool use_hierarchy; | ||
164 | unsigned long last_oom_jiffies; | ||
165 | atomic_t refcnt; | ||
166 | |||
167 | unsigned int swappiness; | ||
168 | |||
169 | /* | ||
170 | * statistics. This must be placed at the end of memcg. | ||
133 | */ | 171 | */ |
134 | struct mem_cgroup_stat stat; | 172 | struct mem_cgroup_stat stat; |
135 | }; | 173 | }; |
136 | static struct mem_cgroup init_mem_cgroup; | ||
137 | 174 | ||
138 | enum charge_type { | 175 | enum charge_type { |
139 | MEM_CGROUP_CHARGE_TYPE_CACHE = 0, | 176 | MEM_CGROUP_CHARGE_TYPE_CACHE = 0, |
140 | MEM_CGROUP_CHARGE_TYPE_MAPPED, | 177 | MEM_CGROUP_CHARGE_TYPE_MAPPED, |
141 | MEM_CGROUP_CHARGE_TYPE_SHMEM, /* used by page migration of shmem */ | 178 | MEM_CGROUP_CHARGE_TYPE_SHMEM, /* used by page migration of shmem */ |
142 | MEM_CGROUP_CHARGE_TYPE_FORCE, /* used by force_empty */ | 179 | MEM_CGROUP_CHARGE_TYPE_FORCE, /* used by force_empty */ |
180 | MEM_CGROUP_CHARGE_TYPE_SWAPOUT, /* for accounting swapcache */ | ||
143 | NR_CHARGE_TYPE, | 181 | NR_CHARGE_TYPE, |
144 | }; | 182 | }; |
145 | 183 | ||
146 | /* only for here (for easy reading.) */ | 184 | /* only for here (for easy reading.) */ |
147 | #define PCGF_CACHE (1UL << PCG_CACHE) | 185 | #define PCGF_CACHE (1UL << PCG_CACHE) |
148 | #define PCGF_USED (1UL << PCG_USED) | 186 | #define PCGF_USED (1UL << PCG_USED) |
149 | #define PCGF_ACTIVE (1UL << PCG_ACTIVE) | ||
150 | #define PCGF_LOCK (1UL << PCG_LOCK) | 187 | #define PCGF_LOCK (1UL << PCG_LOCK) |
151 | #define PCGF_FILE (1UL << PCG_FILE) | ||
152 | static const unsigned long | 188 | static const unsigned long |
153 | pcg_default_flags[NR_CHARGE_TYPE] = { | 189 | pcg_default_flags[NR_CHARGE_TYPE] = { |
154 | PCGF_CACHE | PCGF_FILE | PCGF_USED | PCGF_LOCK, /* File Cache */ | 190 | PCGF_CACHE | PCGF_USED | PCGF_LOCK, /* File Cache */ |
155 | PCGF_ACTIVE | PCGF_USED | PCGF_LOCK, /* Anon */ | 191 | PCGF_USED | PCGF_LOCK, /* Anon */ |
156 | PCGF_ACTIVE | PCGF_CACHE | PCGF_USED | PCGF_LOCK, /* Shmem */ | 192 | PCGF_CACHE | PCGF_USED | PCGF_LOCK, /* Shmem */ |
157 | 0, /* FORCE */ | 193 | 0, /* FORCE */ |
158 | }; | 194 | }; |
159 | 195 | ||
160 | /* | 196 | /* for encoding cft->private value on file */ |
161 | * Always modified under lru lock. Then, not necessary to preempt_disable() | 197 | #define _MEM (0) |
162 | */ | 198 | #define _MEMSWAP (1) |
199 | #define MEMFILE_PRIVATE(x, val) (((x) << 16) | (val)) | ||
200 | #define MEMFILE_TYPE(val) (((val) >> 16) & 0xffff) | ||
201 | #define MEMFILE_ATTR(val) ((val) & 0xffff) | ||
202 | |||
203 | static void mem_cgroup_get(struct mem_cgroup *mem); | ||
204 | static void mem_cgroup_put(struct mem_cgroup *mem); | ||
205 | |||
163 | static void mem_cgroup_charge_statistics(struct mem_cgroup *mem, | 206 | static void mem_cgroup_charge_statistics(struct mem_cgroup *mem, |
164 | struct page_cgroup *pc, | 207 | struct page_cgroup *pc, |
165 | bool charge) | 208 | bool charge) |
@@ -167,10 +210,9 @@ static void mem_cgroup_charge_statistics(struct mem_cgroup *mem, | |||
167 | int val = (charge)? 1 : -1; | 210 | int val = (charge)? 1 : -1; |
168 | struct mem_cgroup_stat *stat = &mem->stat; | 211 | struct mem_cgroup_stat *stat = &mem->stat; |
169 | struct mem_cgroup_stat_cpu *cpustat; | 212 | struct mem_cgroup_stat_cpu *cpustat; |
213 | int cpu = get_cpu(); | ||
170 | 214 | ||
171 | VM_BUG_ON(!irqs_disabled()); | 215 | cpustat = &stat->cpustat[cpu]; |
172 | |||
173 | cpustat = &stat->cpustat[smp_processor_id()]; | ||
174 | if (PageCgroupCache(pc)) | 216 | if (PageCgroupCache(pc)) |
175 | __mem_cgroup_stat_add_safe(cpustat, MEM_CGROUP_STAT_CACHE, val); | 217 | __mem_cgroup_stat_add_safe(cpustat, MEM_CGROUP_STAT_CACHE, val); |
176 | else | 218 | else |
@@ -182,6 +224,7 @@ static void mem_cgroup_charge_statistics(struct mem_cgroup *mem, | |||
182 | else | 224 | else |
183 | __mem_cgroup_stat_add_safe(cpustat, | 225 | __mem_cgroup_stat_add_safe(cpustat, |
184 | MEM_CGROUP_STAT_PGPGOUT_COUNT, 1); | 226 | MEM_CGROUP_STAT_PGPGOUT_COUNT, 1); |
227 | put_cpu(); | ||
185 | } | 228 | } |
186 | 229 | ||
187 | static struct mem_cgroup_per_zone * | 230 | static struct mem_cgroup_per_zone * |
@@ -197,6 +240,9 @@ page_cgroup_zoneinfo(struct page_cgroup *pc) | |||
197 | int nid = page_cgroup_nid(pc); | 240 | int nid = page_cgroup_nid(pc); |
198 | int zid = page_cgroup_zid(pc); | 241 | int zid = page_cgroup_zid(pc); |
199 | 242 | ||
243 | if (!mem) | ||
244 | return NULL; | ||
245 | |||
200 | return mem_cgroup_zoneinfo(mem, nid, zid); | 246 | return mem_cgroup_zoneinfo(mem, nid, zid); |
201 | } | 247 | } |
202 | 248 | ||
@@ -236,77 +282,152 @@ struct mem_cgroup *mem_cgroup_from_task(struct task_struct *p) | |||
236 | struct mem_cgroup, css); | 282 | struct mem_cgroup, css); |
237 | } | 283 | } |
238 | 284 | ||
239 | static void __mem_cgroup_remove_list(struct mem_cgroup_per_zone *mz, | 285 | static struct mem_cgroup *try_get_mem_cgroup_from_mm(struct mm_struct *mm) |
240 | struct page_cgroup *pc) | ||
241 | { | 286 | { |
242 | int lru = LRU_BASE; | 287 | struct mem_cgroup *mem = NULL; |
288 | /* | ||
289 | * Because we have no locks, mm->owner's may be being moved to other | ||
290 | * cgroup. We use css_tryget() here even if this looks | ||
291 | * pessimistic (rather than adding locks here). | ||
292 | */ | ||
293 | rcu_read_lock(); | ||
294 | do { | ||
295 | mem = mem_cgroup_from_task(rcu_dereference(mm->owner)); | ||
296 | if (unlikely(!mem)) | ||
297 | break; | ||
298 | } while (!css_tryget(&mem->css)); | ||
299 | rcu_read_unlock(); | ||
300 | return mem; | ||
301 | } | ||
243 | 302 | ||
244 | if (PageCgroupUnevictable(pc)) | 303 | static bool mem_cgroup_is_obsolete(struct mem_cgroup *mem) |
245 | lru = LRU_UNEVICTABLE; | 304 | { |
246 | else { | 305 | if (!mem) |
247 | if (PageCgroupActive(pc)) | 306 | return true; |
248 | lru += LRU_ACTIVE; | 307 | return css_is_removed(&mem->css); |
249 | if (PageCgroupFile(pc)) | 308 | } |
250 | lru += LRU_FILE; | ||
251 | } | ||
252 | 309 | ||
253 | MEM_CGROUP_ZSTAT(mz, lru) -= 1; | 310 | /* |
311 | * Following LRU functions are allowed to be used without PCG_LOCK. | ||
312 | * Operations are called by routine of global LRU independently from memcg. | ||
313 | * What we have to take care of here is validness of pc->mem_cgroup. | ||
314 | * | ||
315 | * Changes to pc->mem_cgroup happens when | ||
316 | * 1. charge | ||
317 | * 2. moving account | ||
318 | * In typical case, "charge" is done before add-to-lru. Exception is SwapCache. | ||
319 | * It is added to LRU before charge. | ||
320 | * If PCG_USED bit is not set, page_cgroup is not added to this private LRU. | ||
321 | * When moving account, the page is not on LRU. It's isolated. | ||
322 | */ | ||
254 | 323 | ||
255 | mem_cgroup_charge_statistics(pc->mem_cgroup, pc, false); | 324 | void mem_cgroup_del_lru_list(struct page *page, enum lru_list lru) |
256 | list_del(&pc->lru); | 325 | { |
326 | struct page_cgroup *pc; | ||
327 | struct mem_cgroup *mem; | ||
328 | struct mem_cgroup_per_zone *mz; | ||
329 | |||
330 | if (mem_cgroup_disabled()) | ||
331 | return; | ||
332 | pc = lookup_page_cgroup(page); | ||
333 | /* can happen while we handle swapcache. */ | ||
334 | if (list_empty(&pc->lru) || !pc->mem_cgroup) | ||
335 | return; | ||
336 | /* | ||
337 | * We don't check PCG_USED bit. It's cleared when the "page" is finally | ||
338 | * removed from global LRU. | ||
339 | */ | ||
340 | mz = page_cgroup_zoneinfo(pc); | ||
341 | mem = pc->mem_cgroup; | ||
342 | MEM_CGROUP_ZSTAT(mz, lru) -= 1; | ||
343 | list_del_init(&pc->lru); | ||
344 | return; | ||
257 | } | 345 | } |
258 | 346 | ||
259 | static void __mem_cgroup_add_list(struct mem_cgroup_per_zone *mz, | 347 | void mem_cgroup_del_lru(struct page *page) |
260 | struct page_cgroup *pc) | ||
261 | { | 348 | { |
262 | int lru = LRU_BASE; | 349 | mem_cgroup_del_lru_list(page, page_lru(page)); |
350 | } | ||
263 | 351 | ||
264 | if (PageCgroupUnevictable(pc)) | 352 | void mem_cgroup_rotate_lru_list(struct page *page, enum lru_list lru) |
265 | lru = LRU_UNEVICTABLE; | 353 | { |
266 | else { | 354 | struct mem_cgroup_per_zone *mz; |
267 | if (PageCgroupActive(pc)) | 355 | struct page_cgroup *pc; |
268 | lru += LRU_ACTIVE; | ||
269 | if (PageCgroupFile(pc)) | ||
270 | lru += LRU_FILE; | ||
271 | } | ||
272 | 356 | ||
273 | MEM_CGROUP_ZSTAT(mz, lru) += 1; | 357 | if (mem_cgroup_disabled()) |
274 | list_add(&pc->lru, &mz->lists[lru]); | 358 | return; |
275 | 359 | ||
276 | mem_cgroup_charge_statistics(pc->mem_cgroup, pc, true); | 360 | pc = lookup_page_cgroup(page); |
361 | smp_rmb(); | ||
362 | /* unused page is not rotated. */ | ||
363 | if (!PageCgroupUsed(pc)) | ||
364 | return; | ||
365 | mz = page_cgroup_zoneinfo(pc); | ||
366 | list_move(&pc->lru, &mz->lists[lru]); | ||
277 | } | 367 | } |
278 | 368 | ||
279 | static void __mem_cgroup_move_lists(struct page_cgroup *pc, enum lru_list lru) | 369 | void mem_cgroup_add_lru_list(struct page *page, enum lru_list lru) |
280 | { | 370 | { |
281 | struct mem_cgroup_per_zone *mz = page_cgroup_zoneinfo(pc); | 371 | struct page_cgroup *pc; |
282 | int active = PageCgroupActive(pc); | 372 | struct mem_cgroup_per_zone *mz; |
283 | int file = PageCgroupFile(pc); | ||
284 | int unevictable = PageCgroupUnevictable(pc); | ||
285 | enum lru_list from = unevictable ? LRU_UNEVICTABLE : | ||
286 | (LRU_FILE * !!file + !!active); | ||
287 | 373 | ||
288 | if (lru == from) | 374 | if (mem_cgroup_disabled()) |
375 | return; | ||
376 | pc = lookup_page_cgroup(page); | ||
377 | /* barrier to sync with "charge" */ | ||
378 | smp_rmb(); | ||
379 | if (!PageCgroupUsed(pc)) | ||
289 | return; | 380 | return; |
290 | 381 | ||
291 | MEM_CGROUP_ZSTAT(mz, from) -= 1; | 382 | mz = page_cgroup_zoneinfo(pc); |
383 | MEM_CGROUP_ZSTAT(mz, lru) += 1; | ||
384 | list_add(&pc->lru, &mz->lists[lru]); | ||
385 | } | ||
386 | |||
387 | /* | ||
388 | * At handling SwapCache, pc->mem_cgroup may be changed while it's linked to | ||
389 | * lru because the page may.be reused after it's fully uncharged (because of | ||
390 | * SwapCache behavior).To handle that, unlink page_cgroup from LRU when charge | ||
391 | * it again. This function is only used to charge SwapCache. It's done under | ||
392 | * lock_page and expected that zone->lru_lock is never held. | ||
393 | */ | ||
394 | static void mem_cgroup_lru_del_before_commit_swapcache(struct page *page) | ||
395 | { | ||
396 | unsigned long flags; | ||
397 | struct zone *zone = page_zone(page); | ||
398 | struct page_cgroup *pc = lookup_page_cgroup(page); | ||
399 | |||
400 | spin_lock_irqsave(&zone->lru_lock, flags); | ||
292 | /* | 401 | /* |
293 | * However this is done under mz->lru_lock, another flags, which | 402 | * Forget old LRU when this page_cgroup is *not* used. This Used bit |
294 | * are not related to LRU, will be modified from out-of-lock. | 403 | * is guarded by lock_page() because the page is SwapCache. |
295 | * We have to use atomic set/clear flags. | ||
296 | */ | 404 | */ |
297 | if (is_unevictable_lru(lru)) { | 405 | if (!PageCgroupUsed(pc)) |
298 | ClearPageCgroupActive(pc); | 406 | mem_cgroup_del_lru_list(page, page_lru(page)); |
299 | SetPageCgroupUnevictable(pc); | 407 | spin_unlock_irqrestore(&zone->lru_lock, flags); |
300 | } else { | 408 | } |
301 | if (is_active_lru(lru)) | ||
302 | SetPageCgroupActive(pc); | ||
303 | else | ||
304 | ClearPageCgroupActive(pc); | ||
305 | ClearPageCgroupUnevictable(pc); | ||
306 | } | ||
307 | 409 | ||
308 | MEM_CGROUP_ZSTAT(mz, lru) += 1; | 410 | static void mem_cgroup_lru_add_after_commit_swapcache(struct page *page) |
309 | list_move(&pc->lru, &mz->lists[lru]); | 411 | { |
412 | unsigned long flags; | ||
413 | struct zone *zone = page_zone(page); | ||
414 | struct page_cgroup *pc = lookup_page_cgroup(page); | ||
415 | |||
416 | spin_lock_irqsave(&zone->lru_lock, flags); | ||
417 | /* link when the page is linked to LRU but page_cgroup isn't */ | ||
418 | if (PageLRU(page) && list_empty(&pc->lru)) | ||
419 | mem_cgroup_add_lru_list(page, page_lru(page)); | ||
420 | spin_unlock_irqrestore(&zone->lru_lock, flags); | ||
421 | } | ||
422 | |||
423 | |||
424 | void mem_cgroup_move_lists(struct page *page, | ||
425 | enum lru_list from, enum lru_list to) | ||
426 | { | ||
427 | if (mem_cgroup_disabled()) | ||
428 | return; | ||
429 | mem_cgroup_del_lru_list(page, from); | ||
430 | mem_cgroup_add_lru_list(page, to); | ||
310 | } | 431 | } |
311 | 432 | ||
312 | int task_in_mem_cgroup(struct task_struct *task, const struct mem_cgroup *mem) | 433 | int task_in_mem_cgroup(struct task_struct *task, const struct mem_cgroup *mem) |
@@ -320,37 +441,6 @@ int task_in_mem_cgroup(struct task_struct *task, const struct mem_cgroup *mem) | |||
320 | } | 441 | } |
321 | 442 | ||
322 | /* | 443 | /* |
323 | * This routine assumes that the appropriate zone's lru lock is already held | ||
324 | */ | ||
325 | void mem_cgroup_move_lists(struct page *page, enum lru_list lru) | ||
326 | { | ||
327 | struct page_cgroup *pc; | ||
328 | struct mem_cgroup_per_zone *mz; | ||
329 | unsigned long flags; | ||
330 | |||
331 | if (mem_cgroup_subsys.disabled) | ||
332 | return; | ||
333 | |||
334 | /* | ||
335 | * We cannot lock_page_cgroup while holding zone's lru_lock, | ||
336 | * because other holders of lock_page_cgroup can be interrupted | ||
337 | * with an attempt to rotate_reclaimable_page. But we cannot | ||
338 | * safely get to page_cgroup without it, so just try_lock it: | ||
339 | * mem_cgroup_isolate_pages allows for page left on wrong list. | ||
340 | */ | ||
341 | pc = lookup_page_cgroup(page); | ||
342 | if (!trylock_page_cgroup(pc)) | ||
343 | return; | ||
344 | if (pc && PageCgroupUsed(pc)) { | ||
345 | mz = page_cgroup_zoneinfo(pc); | ||
346 | spin_lock_irqsave(&mz->lru_lock, flags); | ||
347 | __mem_cgroup_move_lists(pc, lru); | ||
348 | spin_unlock_irqrestore(&mz->lru_lock, flags); | ||
349 | } | ||
350 | unlock_page_cgroup(pc); | ||
351 | } | ||
352 | |||
353 | /* | ||
354 | * Calculate mapped_ratio under memory controller. This will be used in | 444 | * Calculate mapped_ratio under memory controller. This will be used in |
355 | * vmscan.c for deteremining we have to reclaim mapped pages. | 445 | * vmscan.c for deteremining we have to reclaim mapped pages. |
356 | */ | 446 | */ |
@@ -372,39 +462,108 @@ int mem_cgroup_calc_mapped_ratio(struct mem_cgroup *mem) | |||
372 | */ | 462 | */ |
373 | int mem_cgroup_get_reclaim_priority(struct mem_cgroup *mem) | 463 | int mem_cgroup_get_reclaim_priority(struct mem_cgroup *mem) |
374 | { | 464 | { |
375 | return mem->prev_priority; | 465 | int prev_priority; |
466 | |||
467 | spin_lock(&mem->reclaim_param_lock); | ||
468 | prev_priority = mem->prev_priority; | ||
469 | spin_unlock(&mem->reclaim_param_lock); | ||
470 | |||
471 | return prev_priority; | ||
376 | } | 472 | } |
377 | 473 | ||
378 | void mem_cgroup_note_reclaim_priority(struct mem_cgroup *mem, int priority) | 474 | void mem_cgroup_note_reclaim_priority(struct mem_cgroup *mem, int priority) |
379 | { | 475 | { |
476 | spin_lock(&mem->reclaim_param_lock); | ||
380 | if (priority < mem->prev_priority) | 477 | if (priority < mem->prev_priority) |
381 | mem->prev_priority = priority; | 478 | mem->prev_priority = priority; |
479 | spin_unlock(&mem->reclaim_param_lock); | ||
382 | } | 480 | } |
383 | 481 | ||
384 | void mem_cgroup_record_reclaim_priority(struct mem_cgroup *mem, int priority) | 482 | void mem_cgroup_record_reclaim_priority(struct mem_cgroup *mem, int priority) |
385 | { | 483 | { |
484 | spin_lock(&mem->reclaim_param_lock); | ||
386 | mem->prev_priority = priority; | 485 | mem->prev_priority = priority; |
486 | spin_unlock(&mem->reclaim_param_lock); | ||
387 | } | 487 | } |
388 | 488 | ||
389 | /* | 489 | static int calc_inactive_ratio(struct mem_cgroup *memcg, unsigned long *present_pages) |
390 | * Calculate # of pages to be scanned in this priority/zone. | 490 | { |
391 | * See also vmscan.c | 491 | unsigned long active; |
392 | * | 492 | unsigned long inactive; |
393 | * priority starts from "DEF_PRIORITY" and decremented in each loop. | 493 | unsigned long gb; |
394 | * (see include/linux/mmzone.h) | 494 | unsigned long inactive_ratio; |
395 | */ | 495 | |
496 | inactive = mem_cgroup_get_all_zonestat(memcg, LRU_INACTIVE_ANON); | ||
497 | active = mem_cgroup_get_all_zonestat(memcg, LRU_ACTIVE_ANON); | ||
498 | |||
499 | gb = (inactive + active) >> (30 - PAGE_SHIFT); | ||
500 | if (gb) | ||
501 | inactive_ratio = int_sqrt(10 * gb); | ||
502 | else | ||
503 | inactive_ratio = 1; | ||
504 | |||
505 | if (present_pages) { | ||
506 | present_pages[0] = inactive; | ||
507 | present_pages[1] = active; | ||
508 | } | ||
509 | |||
510 | return inactive_ratio; | ||
511 | } | ||
512 | |||
513 | int mem_cgroup_inactive_anon_is_low(struct mem_cgroup *memcg) | ||
514 | { | ||
515 | unsigned long active; | ||
516 | unsigned long inactive; | ||
517 | unsigned long present_pages[2]; | ||
518 | unsigned long inactive_ratio; | ||
396 | 519 | ||
397 | long mem_cgroup_calc_reclaim(struct mem_cgroup *mem, struct zone *zone, | 520 | inactive_ratio = calc_inactive_ratio(memcg, present_pages); |
398 | int priority, enum lru_list lru) | 521 | |
522 | inactive = present_pages[0]; | ||
523 | active = present_pages[1]; | ||
524 | |||
525 | if (inactive * inactive_ratio < active) | ||
526 | return 1; | ||
527 | |||
528 | return 0; | ||
529 | } | ||
530 | |||
531 | unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, | ||
532 | struct zone *zone, | ||
533 | enum lru_list lru) | ||
399 | { | 534 | { |
400 | long nr_pages; | ||
401 | int nid = zone->zone_pgdat->node_id; | 535 | int nid = zone->zone_pgdat->node_id; |
402 | int zid = zone_idx(zone); | 536 | int zid = zone_idx(zone); |
403 | struct mem_cgroup_per_zone *mz = mem_cgroup_zoneinfo(mem, nid, zid); | 537 | struct mem_cgroup_per_zone *mz = mem_cgroup_zoneinfo(memcg, nid, zid); |
404 | 538 | ||
405 | nr_pages = MEM_CGROUP_ZSTAT(mz, lru); | 539 | return MEM_CGROUP_ZSTAT(mz, lru); |
540 | } | ||
406 | 541 | ||
407 | return (nr_pages >> priority); | 542 | struct zone_reclaim_stat *mem_cgroup_get_reclaim_stat(struct mem_cgroup *memcg, |
543 | struct zone *zone) | ||
544 | { | ||
545 | int nid = zone->zone_pgdat->node_id; | ||
546 | int zid = zone_idx(zone); | ||
547 | struct mem_cgroup_per_zone *mz = mem_cgroup_zoneinfo(memcg, nid, zid); | ||
548 | |||
549 | return &mz->reclaim_stat; | ||
550 | } | ||
551 | |||
552 | struct zone_reclaim_stat * | ||
553 | mem_cgroup_get_reclaim_stat_from_page(struct page *page) | ||
554 | { | ||
555 | struct page_cgroup *pc; | ||
556 | struct mem_cgroup_per_zone *mz; | ||
557 | |||
558 | if (mem_cgroup_disabled()) | ||
559 | return NULL; | ||
560 | |||
561 | pc = lookup_page_cgroup(page); | ||
562 | mz = page_cgroup_zoneinfo(pc); | ||
563 | if (!mz) | ||
564 | return NULL; | ||
565 | |||
566 | return &mz->reclaim_stat; | ||
408 | } | 567 | } |
409 | 568 | ||
410 | unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, | 569 | unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, |
@@ -429,95 +588,281 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, | |||
429 | mz = mem_cgroup_zoneinfo(mem_cont, nid, zid); | 588 | mz = mem_cgroup_zoneinfo(mem_cont, nid, zid); |
430 | src = &mz->lists[lru]; | 589 | src = &mz->lists[lru]; |
431 | 590 | ||
432 | spin_lock(&mz->lru_lock); | ||
433 | scan = 0; | 591 | scan = 0; |
434 | list_for_each_entry_safe_reverse(pc, tmp, src, lru) { | 592 | list_for_each_entry_safe_reverse(pc, tmp, src, lru) { |
435 | if (scan >= nr_to_scan) | 593 | if (scan >= nr_to_scan) |
436 | break; | 594 | break; |
595 | |||
596 | page = pc->page; | ||
437 | if (unlikely(!PageCgroupUsed(pc))) | 597 | if (unlikely(!PageCgroupUsed(pc))) |
438 | continue; | 598 | continue; |
439 | page = pc->page; | ||
440 | |||
441 | if (unlikely(!PageLRU(page))) | 599 | if (unlikely(!PageLRU(page))) |
442 | continue; | 600 | continue; |
443 | 601 | ||
444 | /* | ||
445 | * TODO: play better with lumpy reclaim, grabbing anything. | ||
446 | */ | ||
447 | if (PageUnevictable(page) || | ||
448 | (PageActive(page) && !active) || | ||
449 | (!PageActive(page) && active)) { | ||
450 | __mem_cgroup_move_lists(pc, page_lru(page)); | ||
451 | continue; | ||
452 | } | ||
453 | |||
454 | scan++; | 602 | scan++; |
455 | list_move(&pc->lru, &pc_list); | ||
456 | |||
457 | if (__isolate_lru_page(page, mode, file) == 0) { | 603 | if (__isolate_lru_page(page, mode, file) == 0) { |
458 | list_move(&page->lru, dst); | 604 | list_move(&page->lru, dst); |
459 | nr_taken++; | 605 | nr_taken++; |
460 | } | 606 | } |
461 | } | 607 | } |
462 | 608 | ||
463 | list_splice(&pc_list, src); | ||
464 | spin_unlock(&mz->lru_lock); | ||
465 | |||
466 | *scanned = scan; | 609 | *scanned = scan; |
467 | return nr_taken; | 610 | return nr_taken; |
468 | } | 611 | } |
469 | 612 | ||
613 | #define mem_cgroup_from_res_counter(counter, member) \ | ||
614 | container_of(counter, struct mem_cgroup, member) | ||
615 | |||
470 | /* | 616 | /* |
471 | * Charge the memory controller for page usage. | 617 | * This routine finds the DFS walk successor. This routine should be |
472 | * Return | 618 | * called with hierarchy_mutex held |
473 | * 0 if the charge was successful | ||
474 | * < 0 if the cgroup is over its limit | ||
475 | */ | 619 | */ |
476 | static int mem_cgroup_charge_common(struct page *page, struct mm_struct *mm, | 620 | static struct mem_cgroup * |
477 | gfp_t gfp_mask, enum charge_type ctype, | 621 | mem_cgroup_get_next_node(struct mem_cgroup *curr, struct mem_cgroup *root_mem) |
478 | struct mem_cgroup *memcg) | ||
479 | { | 622 | { |
623 | struct cgroup *cgroup, *curr_cgroup, *root_cgroup; | ||
624 | |||
625 | curr_cgroup = curr->css.cgroup; | ||
626 | root_cgroup = root_mem->css.cgroup; | ||
627 | |||
628 | if (!list_empty(&curr_cgroup->children)) { | ||
629 | /* | ||
630 | * Walk down to children | ||
631 | */ | ||
632 | mem_cgroup_put(curr); | ||
633 | cgroup = list_entry(curr_cgroup->children.next, | ||
634 | struct cgroup, sibling); | ||
635 | curr = mem_cgroup_from_cont(cgroup); | ||
636 | mem_cgroup_get(curr); | ||
637 | goto done; | ||
638 | } | ||
639 | |||
640 | visit_parent: | ||
641 | if (curr_cgroup == root_cgroup) { | ||
642 | mem_cgroup_put(curr); | ||
643 | curr = root_mem; | ||
644 | mem_cgroup_get(curr); | ||
645 | goto done; | ||
646 | } | ||
647 | |||
648 | /* | ||
649 | * Goto next sibling | ||
650 | */ | ||
651 | if (curr_cgroup->sibling.next != &curr_cgroup->parent->children) { | ||
652 | mem_cgroup_put(curr); | ||
653 | cgroup = list_entry(curr_cgroup->sibling.next, struct cgroup, | ||
654 | sibling); | ||
655 | curr = mem_cgroup_from_cont(cgroup); | ||
656 | mem_cgroup_get(curr); | ||
657 | goto done; | ||
658 | } | ||
659 | |||
660 | /* | ||
661 | * Go up to next parent and next parent's sibling if need be | ||
662 | */ | ||
663 | curr_cgroup = curr_cgroup->parent; | ||
664 | goto visit_parent; | ||
665 | |||
666 | done: | ||
667 | root_mem->last_scanned_child = curr; | ||
668 | return curr; | ||
669 | } | ||
670 | |||
671 | /* | ||
672 | * Visit the first child (need not be the first child as per the ordering | ||
673 | * of the cgroup list, since we track last_scanned_child) of @mem and use | ||
674 | * that to reclaim free pages from. | ||
675 | */ | ||
676 | static struct mem_cgroup * | ||
677 | mem_cgroup_get_first_node(struct mem_cgroup *root_mem) | ||
678 | { | ||
679 | struct cgroup *cgroup; | ||
680 | struct mem_cgroup *ret; | ||
681 | bool obsolete; | ||
682 | |||
683 | obsolete = mem_cgroup_is_obsolete(root_mem->last_scanned_child); | ||
684 | |||
685 | /* | ||
686 | * Scan all children under the mem_cgroup mem | ||
687 | */ | ||
688 | mutex_lock(&mem_cgroup_subsys.hierarchy_mutex); | ||
689 | if (list_empty(&root_mem->css.cgroup->children)) { | ||
690 | ret = root_mem; | ||
691 | goto done; | ||
692 | } | ||
693 | |||
694 | if (!root_mem->last_scanned_child || obsolete) { | ||
695 | |||
696 | if (obsolete && root_mem->last_scanned_child) | ||
697 | mem_cgroup_put(root_mem->last_scanned_child); | ||
698 | |||
699 | cgroup = list_first_entry(&root_mem->css.cgroup->children, | ||
700 | struct cgroup, sibling); | ||
701 | ret = mem_cgroup_from_cont(cgroup); | ||
702 | mem_cgroup_get(ret); | ||
703 | } else | ||
704 | ret = mem_cgroup_get_next_node(root_mem->last_scanned_child, | ||
705 | root_mem); | ||
706 | |||
707 | done: | ||
708 | root_mem->last_scanned_child = ret; | ||
709 | mutex_unlock(&mem_cgroup_subsys.hierarchy_mutex); | ||
710 | return ret; | ||
711 | } | ||
712 | |||
713 | static bool mem_cgroup_check_under_limit(struct mem_cgroup *mem) | ||
714 | { | ||
715 | if (do_swap_account) { | ||
716 | if (res_counter_check_under_limit(&mem->res) && | ||
717 | res_counter_check_under_limit(&mem->memsw)) | ||
718 | return true; | ||
719 | } else | ||
720 | if (res_counter_check_under_limit(&mem->res)) | ||
721 | return true; | ||
722 | return false; | ||
723 | } | ||
724 | |||
725 | static unsigned int get_swappiness(struct mem_cgroup *memcg) | ||
726 | { | ||
727 | struct cgroup *cgrp = memcg->css.cgroup; | ||
728 | unsigned int swappiness; | ||
729 | |||
730 | /* root ? */ | ||
731 | if (cgrp->parent == NULL) | ||
732 | return vm_swappiness; | ||
733 | |||
734 | spin_lock(&memcg->reclaim_param_lock); | ||
735 | swappiness = memcg->swappiness; | ||
736 | spin_unlock(&memcg->reclaim_param_lock); | ||
737 | |||
738 | return swappiness; | ||
739 | } | ||
740 | |||
741 | /* | ||
742 | * Dance down the hierarchy if needed to reclaim memory. We remember the | ||
743 | * last child we reclaimed from, so that we don't end up penalizing | ||
744 | * one child extensively based on its position in the children list. | ||
745 | * | ||
746 | * root_mem is the original ancestor that we've been reclaim from. | ||
747 | */ | ||
748 | static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem, | ||
749 | gfp_t gfp_mask, bool noswap) | ||
750 | { | ||
751 | struct mem_cgroup *next_mem; | ||
752 | int ret = 0; | ||
753 | |||
754 | /* | ||
755 | * Reclaim unconditionally and don't check for return value. | ||
756 | * We need to reclaim in the current group and down the tree. | ||
757 | * One might think about checking for children before reclaiming, | ||
758 | * but there might be left over accounting, even after children | ||
759 | * have left. | ||
760 | */ | ||
761 | ret = try_to_free_mem_cgroup_pages(root_mem, gfp_mask, noswap, | ||
762 | get_swappiness(root_mem)); | ||
763 | if (mem_cgroup_check_under_limit(root_mem)) | ||
764 | return 0; | ||
765 | if (!root_mem->use_hierarchy) | ||
766 | return ret; | ||
767 | |||
768 | next_mem = mem_cgroup_get_first_node(root_mem); | ||
769 | |||
770 | while (next_mem != root_mem) { | ||
771 | if (mem_cgroup_is_obsolete(next_mem)) { | ||
772 | mem_cgroup_put(next_mem); | ||
773 | next_mem = mem_cgroup_get_first_node(root_mem); | ||
774 | continue; | ||
775 | } | ||
776 | ret = try_to_free_mem_cgroup_pages(next_mem, gfp_mask, noswap, | ||
777 | get_swappiness(next_mem)); | ||
778 | if (mem_cgroup_check_under_limit(root_mem)) | ||
779 | return 0; | ||
780 | mutex_lock(&mem_cgroup_subsys.hierarchy_mutex); | ||
781 | next_mem = mem_cgroup_get_next_node(next_mem, root_mem); | ||
782 | mutex_unlock(&mem_cgroup_subsys.hierarchy_mutex); | ||
783 | } | ||
784 | return ret; | ||
785 | } | ||
786 | |||
787 | bool mem_cgroup_oom_called(struct task_struct *task) | ||
788 | { | ||
789 | bool ret = false; | ||
480 | struct mem_cgroup *mem; | 790 | struct mem_cgroup *mem; |
481 | struct page_cgroup *pc; | 791 | struct mm_struct *mm; |
482 | unsigned long nr_retries = MEM_CGROUP_RECLAIM_RETRIES; | ||
483 | struct mem_cgroup_per_zone *mz; | ||
484 | unsigned long flags; | ||
485 | 792 | ||
486 | pc = lookup_page_cgroup(page); | 793 | rcu_read_lock(); |
487 | /* can happen at boot */ | 794 | mm = task->mm; |
488 | if (unlikely(!pc)) | 795 | if (!mm) |
796 | mm = &init_mm; | ||
797 | mem = mem_cgroup_from_task(rcu_dereference(mm->owner)); | ||
798 | if (mem && time_before(jiffies, mem->last_oom_jiffies + HZ/10)) | ||
799 | ret = true; | ||
800 | rcu_read_unlock(); | ||
801 | return ret; | ||
802 | } | ||
803 | /* | ||
804 | * Unlike exported interface, "oom" parameter is added. if oom==true, | ||
805 | * oom-killer can be invoked. | ||
806 | */ | ||
807 | static int __mem_cgroup_try_charge(struct mm_struct *mm, | ||
808 | gfp_t gfp_mask, struct mem_cgroup **memcg, | ||
809 | bool oom) | ||
810 | { | ||
811 | struct mem_cgroup *mem, *mem_over_limit; | ||
812 | int nr_retries = MEM_CGROUP_RECLAIM_RETRIES; | ||
813 | struct res_counter *fail_res; | ||
814 | |||
815 | if (unlikely(test_thread_flag(TIF_MEMDIE))) { | ||
816 | /* Don't account this! */ | ||
817 | *memcg = NULL; | ||
489 | return 0; | 818 | return 0; |
490 | prefetchw(pc); | 819 | } |
820 | |||
491 | /* | 821 | /* |
492 | * We always charge the cgroup the mm_struct belongs to. | 822 | * We always charge the cgroup the mm_struct belongs to. |
493 | * The mm_struct's mem_cgroup changes on task migration if the | 823 | * The mm_struct's mem_cgroup changes on task migration if the |
494 | * thread group leader migrates. It's possible that mm is not | 824 | * thread group leader migrates. It's possible that mm is not |
495 | * set, if so charge the init_mm (happens for pagecache usage). | 825 | * set, if so charge the init_mm (happens for pagecache usage). |
496 | */ | 826 | */ |
497 | 827 | mem = *memcg; | |
498 | if (likely(!memcg)) { | 828 | if (likely(!mem)) { |
499 | rcu_read_lock(); | 829 | mem = try_get_mem_cgroup_from_mm(mm); |
500 | mem = mem_cgroup_from_task(rcu_dereference(mm->owner)); | 830 | *memcg = mem; |
501 | if (unlikely(!mem)) { | ||
502 | rcu_read_unlock(); | ||
503 | return 0; | ||
504 | } | ||
505 | /* | ||
506 | * For every charge from the cgroup, increment reference count | ||
507 | */ | ||
508 | css_get(&mem->css); | ||
509 | rcu_read_unlock(); | ||
510 | } else { | 831 | } else { |
511 | mem = memcg; | 832 | css_get(&mem->css); |
512 | css_get(&memcg->css); | ||
513 | } | 833 | } |
834 | if (unlikely(!mem)) | ||
835 | return 0; | ||
836 | |||
837 | VM_BUG_ON(mem_cgroup_is_obsolete(mem)); | ||
838 | |||
839 | while (1) { | ||
840 | int ret; | ||
841 | bool noswap = false; | ||
842 | |||
843 | ret = res_counter_charge(&mem->res, PAGE_SIZE, &fail_res); | ||
844 | if (likely(!ret)) { | ||
845 | if (!do_swap_account) | ||
846 | break; | ||
847 | ret = res_counter_charge(&mem->memsw, PAGE_SIZE, | ||
848 | &fail_res); | ||
849 | if (likely(!ret)) | ||
850 | break; | ||
851 | /* mem+swap counter fails */ | ||
852 | res_counter_uncharge(&mem->res, PAGE_SIZE); | ||
853 | noswap = true; | ||
854 | mem_over_limit = mem_cgroup_from_res_counter(fail_res, | ||
855 | memsw); | ||
856 | } else | ||
857 | /* mem counter fails */ | ||
858 | mem_over_limit = mem_cgroup_from_res_counter(fail_res, | ||
859 | res); | ||
514 | 860 | ||
515 | while (unlikely(res_counter_charge(&mem->res, PAGE_SIZE))) { | ||
516 | if (!(gfp_mask & __GFP_WAIT)) | 861 | if (!(gfp_mask & __GFP_WAIT)) |
517 | goto out; | 862 | goto nomem; |
518 | 863 | ||
519 | if (try_to_free_mem_cgroup_pages(mem, gfp_mask)) | 864 | ret = mem_cgroup_hierarchical_reclaim(mem_over_limit, gfp_mask, |
520 | continue; | 865 | noswap); |
521 | 866 | ||
522 | /* | 867 | /* |
523 | * try_to_free_mem_cgroup_pages() might not give us a full | 868 | * try_to_free_mem_cgroup_pages() might not give us a full |
@@ -525,49 +870,214 @@ static int mem_cgroup_charge_common(struct page *page, struct mm_struct *mm, | |||
525 | * moved to swap cache or just unmapped from the cgroup. | 870 | * moved to swap cache or just unmapped from the cgroup. |
526 | * Check the limit again to see if the reclaim reduced the | 871 | * Check the limit again to see if the reclaim reduced the |
527 | * current usage of the cgroup before giving up | 872 | * current usage of the cgroup before giving up |
873 | * | ||
528 | */ | 874 | */ |
529 | if (res_counter_check_under_limit(&mem->res)) | 875 | if (mem_cgroup_check_under_limit(mem_over_limit)) |
530 | continue; | 876 | continue; |
531 | 877 | ||
532 | if (!nr_retries--) { | 878 | if (!nr_retries--) { |
533 | mem_cgroup_out_of_memory(mem, gfp_mask); | 879 | if (oom) { |
534 | goto out; | 880 | mutex_lock(&memcg_tasklist); |
881 | mem_cgroup_out_of_memory(mem_over_limit, gfp_mask); | ||
882 | mutex_unlock(&memcg_tasklist); | ||
883 | mem_over_limit->last_oom_jiffies = jiffies; | ||
884 | } | ||
885 | goto nomem; | ||
535 | } | 886 | } |
536 | } | 887 | } |
888 | return 0; | ||
889 | nomem: | ||
890 | css_put(&mem->css); | ||
891 | return -ENOMEM; | ||
892 | } | ||
537 | 893 | ||
894 | static struct mem_cgroup *try_get_mem_cgroup_from_swapcache(struct page *page) | ||
895 | { | ||
896 | struct mem_cgroup *mem; | ||
897 | swp_entry_t ent; | ||
898 | |||
899 | if (!PageSwapCache(page)) | ||
900 | return NULL; | ||
901 | |||
902 | ent.val = page_private(page); | ||
903 | mem = lookup_swap_cgroup(ent); | ||
904 | if (!mem) | ||
905 | return NULL; | ||
906 | if (!css_tryget(&mem->css)) | ||
907 | return NULL; | ||
908 | return mem; | ||
909 | } | ||
910 | |||
911 | /* | ||
912 | * commit a charge got by __mem_cgroup_try_charge() and makes page_cgroup to be | ||
913 | * USED state. If already USED, uncharge and return. | ||
914 | */ | ||
915 | |||
916 | static void __mem_cgroup_commit_charge(struct mem_cgroup *mem, | ||
917 | struct page_cgroup *pc, | ||
918 | enum charge_type ctype) | ||
919 | { | ||
920 | /* try_charge() can return NULL to *memcg, taking care of it. */ | ||
921 | if (!mem) | ||
922 | return; | ||
538 | 923 | ||
539 | lock_page_cgroup(pc); | 924 | lock_page_cgroup(pc); |
540 | if (unlikely(PageCgroupUsed(pc))) { | 925 | if (unlikely(PageCgroupUsed(pc))) { |
541 | unlock_page_cgroup(pc); | 926 | unlock_page_cgroup(pc); |
542 | res_counter_uncharge(&mem->res, PAGE_SIZE); | 927 | res_counter_uncharge(&mem->res, PAGE_SIZE); |
928 | if (do_swap_account) | ||
929 | res_counter_uncharge(&mem->memsw, PAGE_SIZE); | ||
543 | css_put(&mem->css); | 930 | css_put(&mem->css); |
544 | 931 | return; | |
545 | goto done; | ||
546 | } | 932 | } |
547 | pc->mem_cgroup = mem; | 933 | pc->mem_cgroup = mem; |
548 | /* | 934 | smp_wmb(); |
549 | * If a page is accounted as a page cache, insert to inactive list. | ||
550 | * If anon, insert to active list. | ||
551 | */ | ||
552 | pc->flags = pcg_default_flags[ctype]; | 935 | pc->flags = pcg_default_flags[ctype]; |
553 | 936 | ||
554 | mz = page_cgroup_zoneinfo(pc); | 937 | mem_cgroup_charge_statistics(mem, pc, true); |
555 | 938 | ||
556 | spin_lock_irqsave(&mz->lru_lock, flags); | ||
557 | __mem_cgroup_add_list(mz, pc); | ||
558 | spin_unlock_irqrestore(&mz->lru_lock, flags); | ||
559 | unlock_page_cgroup(pc); | 939 | unlock_page_cgroup(pc); |
940 | } | ||
560 | 941 | ||
561 | done: | 942 | /** |
562 | return 0; | 943 | * mem_cgroup_move_account - move account of the page |
944 | * @pc: page_cgroup of the page. | ||
945 | * @from: mem_cgroup which the page is moved from. | ||
946 | * @to: mem_cgroup which the page is moved to. @from != @to. | ||
947 | * | ||
948 | * The caller must confirm following. | ||
949 | * - page is not on LRU (isolate_page() is useful.) | ||
950 | * | ||
951 | * returns 0 at success, | ||
952 | * returns -EBUSY when lock is busy or "pc" is unstable. | ||
953 | * | ||
954 | * This function does "uncharge" from old cgroup but doesn't do "charge" to | ||
955 | * new cgroup. It should be done by a caller. | ||
956 | */ | ||
957 | |||
958 | static int mem_cgroup_move_account(struct page_cgroup *pc, | ||
959 | struct mem_cgroup *from, struct mem_cgroup *to) | ||
960 | { | ||
961 | struct mem_cgroup_per_zone *from_mz, *to_mz; | ||
962 | int nid, zid; | ||
963 | int ret = -EBUSY; | ||
964 | |||
965 | VM_BUG_ON(from == to); | ||
966 | VM_BUG_ON(PageLRU(pc->page)); | ||
967 | |||
968 | nid = page_cgroup_nid(pc); | ||
969 | zid = page_cgroup_zid(pc); | ||
970 | from_mz = mem_cgroup_zoneinfo(from, nid, zid); | ||
971 | to_mz = mem_cgroup_zoneinfo(to, nid, zid); | ||
972 | |||
973 | if (!trylock_page_cgroup(pc)) | ||
974 | return ret; | ||
975 | |||
976 | if (!PageCgroupUsed(pc)) | ||
977 | goto out; | ||
978 | |||
979 | if (pc->mem_cgroup != from) | ||
980 | goto out; | ||
981 | |||
982 | css_put(&from->css); | ||
983 | res_counter_uncharge(&from->res, PAGE_SIZE); | ||
984 | mem_cgroup_charge_statistics(from, pc, false); | ||
985 | if (do_swap_account) | ||
986 | res_counter_uncharge(&from->memsw, PAGE_SIZE); | ||
987 | pc->mem_cgroup = to; | ||
988 | mem_cgroup_charge_statistics(to, pc, true); | ||
989 | css_get(&to->css); | ||
990 | ret = 0; | ||
563 | out: | 991 | out: |
564 | css_put(&mem->css); | 992 | unlock_page_cgroup(pc); |
565 | return -ENOMEM; | 993 | return ret; |
994 | } | ||
995 | |||
996 | /* | ||
997 | * move charges to its parent. | ||
998 | */ | ||
999 | |||
1000 | static int mem_cgroup_move_parent(struct page_cgroup *pc, | ||
1001 | struct mem_cgroup *child, | ||
1002 | gfp_t gfp_mask) | ||
1003 | { | ||
1004 | struct page *page = pc->page; | ||
1005 | struct cgroup *cg = child->css.cgroup; | ||
1006 | struct cgroup *pcg = cg->parent; | ||
1007 | struct mem_cgroup *parent; | ||
1008 | int ret; | ||
1009 | |||
1010 | /* Is ROOT ? */ | ||
1011 | if (!pcg) | ||
1012 | return -EINVAL; | ||
1013 | |||
1014 | |||
1015 | parent = mem_cgroup_from_cont(pcg); | ||
1016 | |||
1017 | |||
1018 | ret = __mem_cgroup_try_charge(NULL, gfp_mask, &parent, false); | ||
1019 | if (ret || !parent) | ||
1020 | return ret; | ||
1021 | |||
1022 | if (!get_page_unless_zero(page)) | ||
1023 | return -EBUSY; | ||
1024 | |||
1025 | ret = isolate_lru_page(page); | ||
1026 | |||
1027 | if (ret) | ||
1028 | goto cancel; | ||
1029 | |||
1030 | ret = mem_cgroup_move_account(pc, child, parent); | ||
1031 | |||
1032 | /* drop extra refcnt by try_charge() (move_account increment one) */ | ||
1033 | css_put(&parent->css); | ||
1034 | putback_lru_page(page); | ||
1035 | if (!ret) { | ||
1036 | put_page(page); | ||
1037 | return 0; | ||
1038 | } | ||
1039 | /* uncharge if move fails */ | ||
1040 | cancel: | ||
1041 | res_counter_uncharge(&parent->res, PAGE_SIZE); | ||
1042 | if (do_swap_account) | ||
1043 | res_counter_uncharge(&parent->memsw, PAGE_SIZE); | ||
1044 | put_page(page); | ||
1045 | return ret; | ||
1046 | } | ||
1047 | |||
1048 | /* | ||
1049 | * Charge the memory controller for page usage. | ||
1050 | * Return | ||
1051 | * 0 if the charge was successful | ||
1052 | * < 0 if the cgroup is over its limit | ||
1053 | */ | ||
1054 | static int mem_cgroup_charge_common(struct page *page, struct mm_struct *mm, | ||
1055 | gfp_t gfp_mask, enum charge_type ctype, | ||
1056 | struct mem_cgroup *memcg) | ||
1057 | { | ||
1058 | struct mem_cgroup *mem; | ||
1059 | struct page_cgroup *pc; | ||
1060 | int ret; | ||
1061 | |||
1062 | pc = lookup_page_cgroup(page); | ||
1063 | /* can happen at boot */ | ||
1064 | if (unlikely(!pc)) | ||
1065 | return 0; | ||
1066 | prefetchw(pc); | ||
1067 | |||
1068 | mem = memcg; | ||
1069 | ret = __mem_cgroup_try_charge(mm, gfp_mask, &mem, true); | ||
1070 | if (ret || !mem) | ||
1071 | return ret; | ||
1072 | |||
1073 | __mem_cgroup_commit_charge(mem, pc, ctype); | ||
1074 | return 0; | ||
566 | } | 1075 | } |
567 | 1076 | ||
568 | int mem_cgroup_charge(struct page *page, struct mm_struct *mm, gfp_t gfp_mask) | 1077 | int mem_cgroup_newpage_charge(struct page *page, |
1078 | struct mm_struct *mm, gfp_t gfp_mask) | ||
569 | { | 1079 | { |
570 | if (mem_cgroup_subsys.disabled) | 1080 | if (mem_cgroup_disabled()) |
571 | return 0; | 1081 | return 0; |
572 | if (PageCompound(page)) | 1082 | if (PageCompound(page)) |
573 | return 0; | 1083 | return 0; |
@@ -589,7 +1099,10 @@ int mem_cgroup_charge(struct page *page, struct mm_struct *mm, gfp_t gfp_mask) | |||
589 | int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, | 1099 | int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, |
590 | gfp_t gfp_mask) | 1100 | gfp_t gfp_mask) |
591 | { | 1101 | { |
592 | if (mem_cgroup_subsys.disabled) | 1102 | struct mem_cgroup *mem = NULL; |
1103 | int ret; | ||
1104 | |||
1105 | if (mem_cgroup_disabled()) | ||
593 | return 0; | 1106 | return 0; |
594 | if (PageCompound(page)) | 1107 | if (PageCompound(page)) |
595 | return 0; | 1108 | return 0; |
@@ -601,6 +1114,8 @@ int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, | |||
601 | * For GFP_NOWAIT case, the page may be pre-charged before calling | 1114 | * For GFP_NOWAIT case, the page may be pre-charged before calling |
602 | * add_to_page_cache(). (See shmem.c) check it here and avoid to call | 1115 | * add_to_page_cache(). (See shmem.c) check it here and avoid to call |
603 | * charge twice. (It works but has to pay a bit larger cost.) | 1116 | * charge twice. (It works but has to pay a bit larger cost.) |
1117 | * And when the page is SwapCache, it should take swap information | ||
1118 | * into account. This is under lock_page() now. | ||
604 | */ | 1119 | */ |
605 | if (!(gfp_mask & __GFP_WAIT)) { | 1120 | if (!(gfp_mask & __GFP_WAIT)) { |
606 | struct page_cgroup *pc; | 1121 | struct page_cgroup *pc; |
@@ -617,58 +1132,198 @@ int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, | |||
617 | unlock_page_cgroup(pc); | 1132 | unlock_page_cgroup(pc); |
618 | } | 1133 | } |
619 | 1134 | ||
620 | if (unlikely(!mm)) | 1135 | if (do_swap_account && PageSwapCache(page)) { |
1136 | mem = try_get_mem_cgroup_from_swapcache(page); | ||
1137 | if (mem) | ||
1138 | mm = NULL; | ||
1139 | else | ||
1140 | mem = NULL; | ||
1141 | /* SwapCache may be still linked to LRU now. */ | ||
1142 | mem_cgroup_lru_del_before_commit_swapcache(page); | ||
1143 | } | ||
1144 | |||
1145 | if (unlikely(!mm && !mem)) | ||
621 | mm = &init_mm; | 1146 | mm = &init_mm; |
622 | 1147 | ||
623 | if (page_is_file_cache(page)) | 1148 | if (page_is_file_cache(page)) |
624 | return mem_cgroup_charge_common(page, mm, gfp_mask, | 1149 | return mem_cgroup_charge_common(page, mm, gfp_mask, |
625 | MEM_CGROUP_CHARGE_TYPE_CACHE, NULL); | 1150 | MEM_CGROUP_CHARGE_TYPE_CACHE, NULL); |
626 | else | 1151 | |
627 | return mem_cgroup_charge_common(page, mm, gfp_mask, | 1152 | ret = mem_cgroup_charge_common(page, mm, gfp_mask, |
628 | MEM_CGROUP_CHARGE_TYPE_SHMEM, NULL); | 1153 | MEM_CGROUP_CHARGE_TYPE_SHMEM, mem); |
1154 | if (mem) | ||
1155 | css_put(&mem->css); | ||
1156 | if (PageSwapCache(page)) | ||
1157 | mem_cgroup_lru_add_after_commit_swapcache(page); | ||
1158 | |||
1159 | if (do_swap_account && !ret && PageSwapCache(page)) { | ||
1160 | swp_entry_t ent = {.val = page_private(page)}; | ||
1161 | /* avoid double counting */ | ||
1162 | mem = swap_cgroup_record(ent, NULL); | ||
1163 | if (mem) { | ||
1164 | res_counter_uncharge(&mem->memsw, PAGE_SIZE); | ||
1165 | mem_cgroup_put(mem); | ||
1166 | } | ||
1167 | } | ||
1168 | return ret; | ||
1169 | } | ||
1170 | |||
1171 | /* | ||
1172 | * While swap-in, try_charge -> commit or cancel, the page is locked. | ||
1173 | * And when try_charge() successfully returns, one refcnt to memcg without | ||
1174 | * struct page_cgroup is aquired. This refcnt will be cumsumed by | ||
1175 | * "commit()" or removed by "cancel()" | ||
1176 | */ | ||
1177 | int mem_cgroup_try_charge_swapin(struct mm_struct *mm, | ||
1178 | struct page *page, | ||
1179 | gfp_t mask, struct mem_cgroup **ptr) | ||
1180 | { | ||
1181 | struct mem_cgroup *mem; | ||
1182 | int ret; | ||
1183 | |||
1184 | if (mem_cgroup_disabled()) | ||
1185 | return 0; | ||
1186 | |||
1187 | if (!do_swap_account) | ||
1188 | goto charge_cur_mm; | ||
1189 | /* | ||
1190 | * A racing thread's fault, or swapoff, may have already updated | ||
1191 | * the pte, and even removed page from swap cache: return success | ||
1192 | * to go on to do_swap_page()'s pte_same() test, which should fail. | ||
1193 | */ | ||
1194 | if (!PageSwapCache(page)) | ||
1195 | return 0; | ||
1196 | mem = try_get_mem_cgroup_from_swapcache(page); | ||
1197 | if (!mem) | ||
1198 | goto charge_cur_mm; | ||
1199 | *ptr = mem; | ||
1200 | ret = __mem_cgroup_try_charge(NULL, mask, ptr, true); | ||
1201 | /* drop extra refcnt from tryget */ | ||
1202 | css_put(&mem->css); | ||
1203 | return ret; | ||
1204 | charge_cur_mm: | ||
1205 | if (unlikely(!mm)) | ||
1206 | mm = &init_mm; | ||
1207 | return __mem_cgroup_try_charge(mm, mask, ptr, true); | ||
1208 | } | ||
1209 | |||
1210 | void mem_cgroup_commit_charge_swapin(struct page *page, struct mem_cgroup *ptr) | ||
1211 | { | ||
1212 | struct page_cgroup *pc; | ||
1213 | |||
1214 | if (mem_cgroup_disabled()) | ||
1215 | return; | ||
1216 | if (!ptr) | ||
1217 | return; | ||
1218 | pc = lookup_page_cgroup(page); | ||
1219 | mem_cgroup_lru_del_before_commit_swapcache(page); | ||
1220 | __mem_cgroup_commit_charge(ptr, pc, MEM_CGROUP_CHARGE_TYPE_MAPPED); | ||
1221 | mem_cgroup_lru_add_after_commit_swapcache(page); | ||
1222 | /* | ||
1223 | * Now swap is on-memory. This means this page may be | ||
1224 | * counted both as mem and swap....double count. | ||
1225 | * Fix it by uncharging from memsw. Basically, this SwapCache is stable | ||
1226 | * under lock_page(). But in do_swap_page()::memory.c, reuse_swap_page() | ||
1227 | * may call delete_from_swap_cache() before reach here. | ||
1228 | */ | ||
1229 | if (do_swap_account && PageSwapCache(page)) { | ||
1230 | swp_entry_t ent = {.val = page_private(page)}; | ||
1231 | struct mem_cgroup *memcg; | ||
1232 | memcg = swap_cgroup_record(ent, NULL); | ||
1233 | if (memcg) { | ||
1234 | res_counter_uncharge(&memcg->memsw, PAGE_SIZE); | ||
1235 | mem_cgroup_put(memcg); | ||
1236 | } | ||
1237 | |||
1238 | } | ||
1239 | /* add this page(page_cgroup) to the LRU we want. */ | ||
1240 | |||
629 | } | 1241 | } |
630 | 1242 | ||
1243 | void mem_cgroup_cancel_charge_swapin(struct mem_cgroup *mem) | ||
1244 | { | ||
1245 | if (mem_cgroup_disabled()) | ||
1246 | return; | ||
1247 | if (!mem) | ||
1248 | return; | ||
1249 | res_counter_uncharge(&mem->res, PAGE_SIZE); | ||
1250 | if (do_swap_account) | ||
1251 | res_counter_uncharge(&mem->memsw, PAGE_SIZE); | ||
1252 | css_put(&mem->css); | ||
1253 | } | ||
1254 | |||
1255 | |||
631 | /* | 1256 | /* |
632 | * uncharge if !page_mapped(page) | 1257 | * uncharge if !page_mapped(page) |
633 | */ | 1258 | */ |
634 | static void | 1259 | static struct mem_cgroup * |
635 | __mem_cgroup_uncharge_common(struct page *page, enum charge_type ctype) | 1260 | __mem_cgroup_uncharge_common(struct page *page, enum charge_type ctype) |
636 | { | 1261 | { |
637 | struct page_cgroup *pc; | 1262 | struct page_cgroup *pc; |
638 | struct mem_cgroup *mem; | 1263 | struct mem_cgroup *mem = NULL; |
639 | struct mem_cgroup_per_zone *mz; | 1264 | struct mem_cgroup_per_zone *mz; |
640 | unsigned long flags; | ||
641 | 1265 | ||
642 | if (mem_cgroup_subsys.disabled) | 1266 | if (mem_cgroup_disabled()) |
643 | return; | 1267 | return NULL; |
1268 | |||
1269 | if (PageSwapCache(page)) | ||
1270 | return NULL; | ||
644 | 1271 | ||
645 | /* | 1272 | /* |
646 | * Check if our page_cgroup is valid | 1273 | * Check if our page_cgroup is valid |
647 | */ | 1274 | */ |
648 | pc = lookup_page_cgroup(page); | 1275 | pc = lookup_page_cgroup(page); |
649 | if (unlikely(!pc || !PageCgroupUsed(pc))) | 1276 | if (unlikely(!pc || !PageCgroupUsed(pc))) |
650 | return; | 1277 | return NULL; |
651 | 1278 | ||
652 | lock_page_cgroup(pc); | 1279 | lock_page_cgroup(pc); |
653 | if ((ctype == MEM_CGROUP_CHARGE_TYPE_MAPPED && page_mapped(page)) | 1280 | |
654 | || !PageCgroupUsed(pc)) { | 1281 | mem = pc->mem_cgroup; |
655 | /* This happens at race in zap_pte_range() and do_swap_page()*/ | 1282 | |
656 | unlock_page_cgroup(pc); | 1283 | if (!PageCgroupUsed(pc)) |
657 | return; | 1284 | goto unlock_out; |
1285 | |||
1286 | switch (ctype) { | ||
1287 | case MEM_CGROUP_CHARGE_TYPE_MAPPED: | ||
1288 | if (page_mapped(page)) | ||
1289 | goto unlock_out; | ||
1290 | break; | ||
1291 | case MEM_CGROUP_CHARGE_TYPE_SWAPOUT: | ||
1292 | if (!PageAnon(page)) { /* Shared memory */ | ||
1293 | if (page->mapping && !page_is_file_cache(page)) | ||
1294 | goto unlock_out; | ||
1295 | } else if (page_mapped(page)) /* Anon */ | ||
1296 | goto unlock_out; | ||
1297 | break; | ||
1298 | default: | ||
1299 | break; | ||
658 | } | 1300 | } |
1301 | |||
1302 | res_counter_uncharge(&mem->res, PAGE_SIZE); | ||
1303 | if (do_swap_account && (ctype != MEM_CGROUP_CHARGE_TYPE_SWAPOUT)) | ||
1304 | res_counter_uncharge(&mem->memsw, PAGE_SIZE); | ||
1305 | |||
1306 | mem_cgroup_charge_statistics(mem, pc, false); | ||
659 | ClearPageCgroupUsed(pc); | 1307 | ClearPageCgroupUsed(pc); |
660 | mem = pc->mem_cgroup; | 1308 | /* |
1309 | * pc->mem_cgroup is not cleared here. It will be accessed when it's | ||
1310 | * freed from LRU. This is safe because uncharged page is expected not | ||
1311 | * to be reused (freed soon). Exception is SwapCache, it's handled by | ||
1312 | * special functions. | ||
1313 | */ | ||
661 | 1314 | ||
662 | mz = page_cgroup_zoneinfo(pc); | 1315 | mz = page_cgroup_zoneinfo(pc); |
663 | spin_lock_irqsave(&mz->lru_lock, flags); | ||
664 | __mem_cgroup_remove_list(mz, pc); | ||
665 | spin_unlock_irqrestore(&mz->lru_lock, flags); | ||
666 | unlock_page_cgroup(pc); | 1316 | unlock_page_cgroup(pc); |
667 | 1317 | ||
668 | res_counter_uncharge(&mem->res, PAGE_SIZE); | 1318 | /* at swapout, this memcg will be accessed to record to swap */ |
669 | css_put(&mem->css); | 1319 | if (ctype != MEM_CGROUP_CHARGE_TYPE_SWAPOUT) |
1320 | css_put(&mem->css); | ||
670 | 1321 | ||
671 | return; | 1322 | return mem; |
1323 | |||
1324 | unlock_out: | ||
1325 | unlock_page_cgroup(pc); | ||
1326 | return NULL; | ||
672 | } | 1327 | } |
673 | 1328 | ||
674 | void mem_cgroup_uncharge_page(struct page *page) | 1329 | void mem_cgroup_uncharge_page(struct page *page) |
@@ -689,16 +1344,55 @@ void mem_cgroup_uncharge_cache_page(struct page *page) | |||
689 | } | 1344 | } |
690 | 1345 | ||
691 | /* | 1346 | /* |
692 | * Before starting migration, account against new page. | 1347 | * called from __delete_from_swap_cache() and drop "page" account. |
1348 | * memcg information is recorded to swap_cgroup of "ent" | ||
1349 | */ | ||
1350 | void mem_cgroup_uncharge_swapcache(struct page *page, swp_entry_t ent) | ||
1351 | { | ||
1352 | struct mem_cgroup *memcg; | ||
1353 | |||
1354 | memcg = __mem_cgroup_uncharge_common(page, | ||
1355 | MEM_CGROUP_CHARGE_TYPE_SWAPOUT); | ||
1356 | /* record memcg information */ | ||
1357 | if (do_swap_account && memcg) { | ||
1358 | swap_cgroup_record(ent, memcg); | ||
1359 | mem_cgroup_get(memcg); | ||
1360 | } | ||
1361 | if (memcg) | ||
1362 | css_put(&memcg->css); | ||
1363 | } | ||
1364 | |||
1365 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
1366 | /* | ||
1367 | * called from swap_entry_free(). remove record in swap_cgroup and | ||
1368 | * uncharge "memsw" account. | ||
693 | */ | 1369 | */ |
694 | int mem_cgroup_prepare_migration(struct page *page, struct page *newpage) | 1370 | void mem_cgroup_uncharge_swap(swp_entry_t ent) |
1371 | { | ||
1372 | struct mem_cgroup *memcg; | ||
1373 | |||
1374 | if (!do_swap_account) | ||
1375 | return; | ||
1376 | |||
1377 | memcg = swap_cgroup_record(ent, NULL); | ||
1378 | if (memcg) { | ||
1379 | res_counter_uncharge(&memcg->memsw, PAGE_SIZE); | ||
1380 | mem_cgroup_put(memcg); | ||
1381 | } | ||
1382 | } | ||
1383 | #endif | ||
1384 | |||
1385 | /* | ||
1386 | * Before starting migration, account PAGE_SIZE to mem_cgroup that the old | ||
1387 | * page belongs to. | ||
1388 | */ | ||
1389 | int mem_cgroup_prepare_migration(struct page *page, struct mem_cgroup **ptr) | ||
695 | { | 1390 | { |
696 | struct page_cgroup *pc; | 1391 | struct page_cgroup *pc; |
697 | struct mem_cgroup *mem = NULL; | 1392 | struct mem_cgroup *mem = NULL; |
698 | enum charge_type ctype = MEM_CGROUP_CHARGE_TYPE_MAPPED; | ||
699 | int ret = 0; | 1393 | int ret = 0; |
700 | 1394 | ||
701 | if (mem_cgroup_subsys.disabled) | 1395 | if (mem_cgroup_disabled()) |
702 | return 0; | 1396 | return 0; |
703 | 1397 | ||
704 | pc = lookup_page_cgroup(page); | 1398 | pc = lookup_page_cgroup(page); |
@@ -706,41 +1400,67 @@ int mem_cgroup_prepare_migration(struct page *page, struct page *newpage) | |||
706 | if (PageCgroupUsed(pc)) { | 1400 | if (PageCgroupUsed(pc)) { |
707 | mem = pc->mem_cgroup; | 1401 | mem = pc->mem_cgroup; |
708 | css_get(&mem->css); | 1402 | css_get(&mem->css); |
709 | if (PageCgroupCache(pc)) { | ||
710 | if (page_is_file_cache(page)) | ||
711 | ctype = MEM_CGROUP_CHARGE_TYPE_CACHE; | ||
712 | else | ||
713 | ctype = MEM_CGROUP_CHARGE_TYPE_SHMEM; | ||
714 | } | ||
715 | } | 1403 | } |
716 | unlock_page_cgroup(pc); | 1404 | unlock_page_cgroup(pc); |
1405 | |||
717 | if (mem) { | 1406 | if (mem) { |
718 | ret = mem_cgroup_charge_common(newpage, NULL, GFP_KERNEL, | 1407 | ret = __mem_cgroup_try_charge(NULL, GFP_KERNEL, &mem, false); |
719 | ctype, mem); | ||
720 | css_put(&mem->css); | 1408 | css_put(&mem->css); |
721 | } | 1409 | } |
1410 | *ptr = mem; | ||
722 | return ret; | 1411 | return ret; |
723 | } | 1412 | } |
724 | 1413 | ||
725 | /* remove redundant charge if migration failed*/ | 1414 | /* remove redundant charge if migration failed*/ |
726 | void mem_cgroup_end_migration(struct page *newpage) | 1415 | void mem_cgroup_end_migration(struct mem_cgroup *mem, |
1416 | struct page *oldpage, struct page *newpage) | ||
727 | { | 1417 | { |
1418 | struct page *target, *unused; | ||
1419 | struct page_cgroup *pc; | ||
1420 | enum charge_type ctype; | ||
1421 | |||
1422 | if (!mem) | ||
1423 | return; | ||
1424 | |||
1425 | /* at migration success, oldpage->mapping is NULL. */ | ||
1426 | if (oldpage->mapping) { | ||
1427 | target = oldpage; | ||
1428 | unused = NULL; | ||
1429 | } else { | ||
1430 | target = newpage; | ||
1431 | unused = oldpage; | ||
1432 | } | ||
1433 | |||
1434 | if (PageAnon(target)) | ||
1435 | ctype = MEM_CGROUP_CHARGE_TYPE_MAPPED; | ||
1436 | else if (page_is_file_cache(target)) | ||
1437 | ctype = MEM_CGROUP_CHARGE_TYPE_CACHE; | ||
1438 | else | ||
1439 | ctype = MEM_CGROUP_CHARGE_TYPE_SHMEM; | ||
1440 | |||
1441 | /* unused page is not on radix-tree now. */ | ||
1442 | if (unused) | ||
1443 | __mem_cgroup_uncharge_common(unused, ctype); | ||
1444 | |||
1445 | pc = lookup_page_cgroup(target); | ||
728 | /* | 1446 | /* |
729 | * At success, page->mapping is not NULL. | 1447 | * __mem_cgroup_commit_charge() check PCG_USED bit of page_cgroup. |
730 | * special rollback care is necessary when | 1448 | * So, double-counting is effectively avoided. |
731 | * 1. at migration failure. (newpage->mapping is cleared in this case) | ||
732 | * 2. the newpage was moved but not remapped again because the task | ||
733 | * exits and the newpage is obsolete. In this case, the new page | ||
734 | * may be a swapcache. So, we just call mem_cgroup_uncharge_page() | ||
735 | * always for avoiding mess. The page_cgroup will be removed if | ||
736 | * unnecessary. File cache pages is still on radix-tree. Don't | ||
737 | * care it. | ||
738 | */ | 1449 | */ |
739 | if (!newpage->mapping) | 1450 | __mem_cgroup_commit_charge(mem, pc, ctype); |
740 | __mem_cgroup_uncharge_common(newpage, | 1451 | |
741 | MEM_CGROUP_CHARGE_TYPE_FORCE); | 1452 | /* |
742 | else if (PageAnon(newpage)) | 1453 | * Both of oldpage and newpage are still under lock_page(). |
743 | mem_cgroup_uncharge_page(newpage); | 1454 | * Then, we don't have to care about race in radix-tree. |
1455 | * But we have to be careful that this page is unmapped or not. | ||
1456 | * | ||
1457 | * There is a case for !page_mapped(). At the start of | ||
1458 | * migration, oldpage was mapped. But now, it's zapped. | ||
1459 | * But we know *target* page is not freed/reused under us. | ||
1460 | * mem_cgroup_uncharge_page() does all necessary checks. | ||
1461 | */ | ||
1462 | if (ctype == MEM_CGROUP_CHARGE_TYPE_MAPPED) | ||
1463 | mem_cgroup_uncharge_page(target); | ||
744 | } | 1464 | } |
745 | 1465 | ||
746 | /* | 1466 | /* |
@@ -748,29 +1468,26 @@ void mem_cgroup_end_migration(struct page *newpage) | |||
748 | * This is typically used for page reclaiming for shmem for reducing side | 1468 | * This is typically used for page reclaiming for shmem for reducing side |
749 | * effect of page allocation from shmem, which is used by some mem_cgroup. | 1469 | * effect of page allocation from shmem, which is used by some mem_cgroup. |
750 | */ | 1470 | */ |
751 | int mem_cgroup_shrink_usage(struct mm_struct *mm, gfp_t gfp_mask) | 1471 | int mem_cgroup_shrink_usage(struct page *page, |
1472 | struct mm_struct *mm, | ||
1473 | gfp_t gfp_mask) | ||
752 | { | 1474 | { |
753 | struct mem_cgroup *mem; | 1475 | struct mem_cgroup *mem = NULL; |
754 | int progress = 0; | 1476 | int progress = 0; |
755 | int retry = MEM_CGROUP_RECLAIM_RETRIES; | 1477 | int retry = MEM_CGROUP_RECLAIM_RETRIES; |
756 | 1478 | ||
757 | if (mem_cgroup_subsys.disabled) | 1479 | if (mem_cgroup_disabled()) |
758 | return 0; | 1480 | return 0; |
759 | if (!mm) | 1481 | if (page) |
1482 | mem = try_get_mem_cgroup_from_swapcache(page); | ||
1483 | if (!mem && mm) | ||
1484 | mem = try_get_mem_cgroup_from_mm(mm); | ||
1485 | if (unlikely(!mem)) | ||
760 | return 0; | 1486 | return 0; |
761 | 1487 | ||
762 | rcu_read_lock(); | ||
763 | mem = mem_cgroup_from_task(rcu_dereference(mm->owner)); | ||
764 | if (unlikely(!mem)) { | ||
765 | rcu_read_unlock(); | ||
766 | return 0; | ||
767 | } | ||
768 | css_get(&mem->css); | ||
769 | rcu_read_unlock(); | ||
770 | |||
771 | do { | 1488 | do { |
772 | progress = try_to_free_mem_cgroup_pages(mem, gfp_mask); | 1489 | progress = mem_cgroup_hierarchical_reclaim(mem, gfp_mask, true); |
773 | progress += res_counter_check_under_limit(&mem->res); | 1490 | progress += mem_cgroup_check_under_limit(mem); |
774 | } while (!progress && --retry); | 1491 | } while (!progress && --retry); |
775 | 1492 | ||
776 | css_put(&mem->css); | 1493 | css_put(&mem->css); |
@@ -779,117 +1496,295 @@ int mem_cgroup_shrink_usage(struct mm_struct *mm, gfp_t gfp_mask) | |||
779 | return 0; | 1496 | return 0; |
780 | } | 1497 | } |
781 | 1498 | ||
1499 | static DEFINE_MUTEX(set_limit_mutex); | ||
1500 | |||
782 | static int mem_cgroup_resize_limit(struct mem_cgroup *memcg, | 1501 | static int mem_cgroup_resize_limit(struct mem_cgroup *memcg, |
783 | unsigned long long val) | 1502 | unsigned long long val) |
784 | { | 1503 | { |
785 | 1504 | ||
786 | int retry_count = MEM_CGROUP_RECLAIM_RETRIES; | 1505 | int retry_count = MEM_CGROUP_RECLAIM_RETRIES; |
787 | int progress; | 1506 | int progress; |
1507 | u64 memswlimit; | ||
788 | int ret = 0; | 1508 | int ret = 0; |
789 | 1509 | ||
790 | while (res_counter_set_limit(&memcg->res, val)) { | 1510 | while (retry_count) { |
791 | if (signal_pending(current)) { | 1511 | if (signal_pending(current)) { |
792 | ret = -EINTR; | 1512 | ret = -EINTR; |
793 | break; | 1513 | break; |
794 | } | 1514 | } |
795 | if (!retry_count) { | 1515 | /* |
796 | ret = -EBUSY; | 1516 | * Rather than hide all in some function, I do this in |
1517 | * open coded manner. You see what this really does. | ||
1518 | * We have to guarantee mem->res.limit < mem->memsw.limit. | ||
1519 | */ | ||
1520 | mutex_lock(&set_limit_mutex); | ||
1521 | memswlimit = res_counter_read_u64(&memcg->memsw, RES_LIMIT); | ||
1522 | if (memswlimit < val) { | ||
1523 | ret = -EINVAL; | ||
1524 | mutex_unlock(&set_limit_mutex); | ||
797 | break; | 1525 | break; |
798 | } | 1526 | } |
799 | progress = try_to_free_mem_cgroup_pages(memcg, GFP_KERNEL); | 1527 | ret = res_counter_set_limit(&memcg->res, val); |
800 | if (!progress) | 1528 | mutex_unlock(&set_limit_mutex); |
801 | retry_count--; | 1529 | |
1530 | if (!ret) | ||
1531 | break; | ||
1532 | |||
1533 | progress = mem_cgroup_hierarchical_reclaim(memcg, GFP_KERNEL, | ||
1534 | false); | ||
1535 | if (!progress) retry_count--; | ||
802 | } | 1536 | } |
1537 | |||
803 | return ret; | 1538 | return ret; |
804 | } | 1539 | } |
805 | 1540 | ||
1541 | int mem_cgroup_resize_memsw_limit(struct mem_cgroup *memcg, | ||
1542 | unsigned long long val) | ||
1543 | { | ||
1544 | int retry_count = MEM_CGROUP_RECLAIM_RETRIES; | ||
1545 | u64 memlimit, oldusage, curusage; | ||
1546 | int ret; | ||
1547 | |||
1548 | if (!do_swap_account) | ||
1549 | return -EINVAL; | ||
1550 | |||
1551 | while (retry_count) { | ||
1552 | if (signal_pending(current)) { | ||
1553 | ret = -EINTR; | ||
1554 | break; | ||
1555 | } | ||
1556 | /* | ||
1557 | * Rather than hide all in some function, I do this in | ||
1558 | * open coded manner. You see what this really does. | ||
1559 | * We have to guarantee mem->res.limit < mem->memsw.limit. | ||
1560 | */ | ||
1561 | mutex_lock(&set_limit_mutex); | ||
1562 | memlimit = res_counter_read_u64(&memcg->res, RES_LIMIT); | ||
1563 | if (memlimit > val) { | ||
1564 | ret = -EINVAL; | ||
1565 | mutex_unlock(&set_limit_mutex); | ||
1566 | break; | ||
1567 | } | ||
1568 | ret = res_counter_set_limit(&memcg->memsw, val); | ||
1569 | mutex_unlock(&set_limit_mutex); | ||
1570 | |||
1571 | if (!ret) | ||
1572 | break; | ||
1573 | |||
1574 | oldusage = res_counter_read_u64(&memcg->memsw, RES_USAGE); | ||
1575 | mem_cgroup_hierarchical_reclaim(memcg, GFP_KERNEL, true); | ||
1576 | curusage = res_counter_read_u64(&memcg->memsw, RES_USAGE); | ||
1577 | if (curusage >= oldusage) | ||
1578 | retry_count--; | ||
1579 | } | ||
1580 | return ret; | ||
1581 | } | ||
806 | 1582 | ||
807 | /* | 1583 | /* |
808 | * This routine traverse page_cgroup in given list and drop them all. | 1584 | * This routine traverse page_cgroup in given list and drop them all. |
809 | * *And* this routine doesn't reclaim page itself, just removes page_cgroup. | 1585 | * *And* this routine doesn't reclaim page itself, just removes page_cgroup. |
810 | */ | 1586 | */ |
811 | #define FORCE_UNCHARGE_BATCH (128) | 1587 | static int mem_cgroup_force_empty_list(struct mem_cgroup *mem, |
812 | static void mem_cgroup_force_empty_list(struct mem_cgroup *mem, | 1588 | int node, int zid, enum lru_list lru) |
813 | struct mem_cgroup_per_zone *mz, | ||
814 | enum lru_list lru) | ||
815 | { | 1589 | { |
816 | struct page_cgroup *pc; | 1590 | struct zone *zone; |
817 | struct page *page; | 1591 | struct mem_cgroup_per_zone *mz; |
818 | int count = FORCE_UNCHARGE_BATCH; | 1592 | struct page_cgroup *pc, *busy; |
819 | unsigned long flags; | 1593 | unsigned long flags, loop; |
820 | struct list_head *list; | 1594 | struct list_head *list; |
1595 | int ret = 0; | ||
821 | 1596 | ||
1597 | zone = &NODE_DATA(node)->node_zones[zid]; | ||
1598 | mz = mem_cgroup_zoneinfo(mem, node, zid); | ||
822 | list = &mz->lists[lru]; | 1599 | list = &mz->lists[lru]; |
823 | 1600 | ||
824 | spin_lock_irqsave(&mz->lru_lock, flags); | 1601 | loop = MEM_CGROUP_ZSTAT(mz, lru); |
825 | while (!list_empty(list)) { | 1602 | /* give some margin against EBUSY etc...*/ |
826 | pc = list_entry(list->prev, struct page_cgroup, lru); | 1603 | loop += 256; |
827 | page = pc->page; | 1604 | busy = NULL; |
828 | if (!PageCgroupUsed(pc)) | 1605 | while (loop--) { |
829 | break; | 1606 | ret = 0; |
830 | get_page(page); | 1607 | spin_lock_irqsave(&zone->lru_lock, flags); |
831 | spin_unlock_irqrestore(&mz->lru_lock, flags); | 1608 | if (list_empty(list)) { |
832 | /* | 1609 | spin_unlock_irqrestore(&zone->lru_lock, flags); |
833 | * Check if this page is on LRU. !LRU page can be found | ||
834 | * if it's under page migration. | ||
835 | */ | ||
836 | if (PageLRU(page)) { | ||
837 | __mem_cgroup_uncharge_common(page, | ||
838 | MEM_CGROUP_CHARGE_TYPE_FORCE); | ||
839 | put_page(page); | ||
840 | if (--count <= 0) { | ||
841 | count = FORCE_UNCHARGE_BATCH; | ||
842 | cond_resched(); | ||
843 | } | ||
844 | } else { | ||
845 | spin_lock_irqsave(&mz->lru_lock, flags); | ||
846 | break; | 1610 | break; |
847 | } | 1611 | } |
848 | spin_lock_irqsave(&mz->lru_lock, flags); | 1612 | pc = list_entry(list->prev, struct page_cgroup, lru); |
1613 | if (busy == pc) { | ||
1614 | list_move(&pc->lru, list); | ||
1615 | busy = 0; | ||
1616 | spin_unlock_irqrestore(&zone->lru_lock, flags); | ||
1617 | continue; | ||
1618 | } | ||
1619 | spin_unlock_irqrestore(&zone->lru_lock, flags); | ||
1620 | |||
1621 | ret = mem_cgroup_move_parent(pc, mem, GFP_KERNEL); | ||
1622 | if (ret == -ENOMEM) | ||
1623 | break; | ||
1624 | |||
1625 | if (ret == -EBUSY || ret == -EINVAL) { | ||
1626 | /* found lock contention or "pc" is obsolete. */ | ||
1627 | busy = pc; | ||
1628 | cond_resched(); | ||
1629 | } else | ||
1630 | busy = NULL; | ||
849 | } | 1631 | } |
850 | spin_unlock_irqrestore(&mz->lru_lock, flags); | 1632 | |
1633 | if (!ret && !list_empty(list)) | ||
1634 | return -EBUSY; | ||
1635 | return ret; | ||
851 | } | 1636 | } |
852 | 1637 | ||
853 | /* | 1638 | /* |
854 | * make mem_cgroup's charge to be 0 if there is no task. | 1639 | * make mem_cgroup's charge to be 0 if there is no task. |
855 | * This enables deleting this mem_cgroup. | 1640 | * This enables deleting this mem_cgroup. |
856 | */ | 1641 | */ |
857 | static int mem_cgroup_force_empty(struct mem_cgroup *mem) | 1642 | static int mem_cgroup_force_empty(struct mem_cgroup *mem, bool free_all) |
858 | { | 1643 | { |
859 | int ret = -EBUSY; | 1644 | int ret; |
860 | int node, zid; | 1645 | int node, zid, shrink; |
1646 | int nr_retries = MEM_CGROUP_RECLAIM_RETRIES; | ||
1647 | struct cgroup *cgrp = mem->css.cgroup; | ||
861 | 1648 | ||
862 | css_get(&mem->css); | 1649 | css_get(&mem->css); |
863 | /* | 1650 | |
864 | * page reclaim code (kswapd etc..) will move pages between | 1651 | shrink = 0; |
865 | * active_list <-> inactive_list while we don't take a lock. | 1652 | /* should free all ? */ |
866 | * So, we have to do loop here until all lists are empty. | 1653 | if (free_all) |
867 | */ | 1654 | goto try_to_free; |
1655 | move_account: | ||
868 | while (mem->res.usage > 0) { | 1656 | while (mem->res.usage > 0) { |
869 | if (atomic_read(&mem->css.cgroup->count) > 0) | 1657 | ret = -EBUSY; |
1658 | if (cgroup_task_count(cgrp) || !list_empty(&cgrp->children)) | ||
1659 | goto out; | ||
1660 | ret = -EINTR; | ||
1661 | if (signal_pending(current)) | ||
870 | goto out; | 1662 | goto out; |
871 | /* This is for making all *used* pages to be on LRU. */ | 1663 | /* This is for making all *used* pages to be on LRU. */ |
872 | lru_add_drain_all(); | 1664 | lru_add_drain_all(); |
873 | for_each_node_state(node, N_POSSIBLE) | 1665 | ret = 0; |
874 | for (zid = 0; zid < MAX_NR_ZONES; zid++) { | 1666 | for_each_node_state(node, N_POSSIBLE) { |
875 | struct mem_cgroup_per_zone *mz; | 1667 | for (zid = 0; !ret && zid < MAX_NR_ZONES; zid++) { |
876 | enum lru_list l; | 1668 | enum lru_list l; |
877 | mz = mem_cgroup_zoneinfo(mem, node, zid); | 1669 | for_each_lru(l) { |
878 | for_each_lru(l) | 1670 | ret = mem_cgroup_force_empty_list(mem, |
879 | mem_cgroup_force_empty_list(mem, mz, l); | 1671 | node, zid, l); |
1672 | if (ret) | ||
1673 | break; | ||
1674 | } | ||
880 | } | 1675 | } |
1676 | if (ret) | ||
1677 | break; | ||
1678 | } | ||
1679 | /* it seems parent cgroup doesn't have enough mem */ | ||
1680 | if (ret == -ENOMEM) | ||
1681 | goto try_to_free; | ||
881 | cond_resched(); | 1682 | cond_resched(); |
882 | } | 1683 | } |
883 | ret = 0; | 1684 | ret = 0; |
884 | out: | 1685 | out: |
885 | css_put(&mem->css); | 1686 | css_put(&mem->css); |
886 | return ret; | 1687 | return ret; |
1688 | |||
1689 | try_to_free: | ||
1690 | /* returns EBUSY if there is a task or if we come here twice. */ | ||
1691 | if (cgroup_task_count(cgrp) || !list_empty(&cgrp->children) || shrink) { | ||
1692 | ret = -EBUSY; | ||
1693 | goto out; | ||
1694 | } | ||
1695 | /* we call try-to-free pages for make this cgroup empty */ | ||
1696 | lru_add_drain_all(); | ||
1697 | /* try to free all pages in this cgroup */ | ||
1698 | shrink = 1; | ||
1699 | while (nr_retries && mem->res.usage > 0) { | ||
1700 | int progress; | ||
1701 | |||
1702 | if (signal_pending(current)) { | ||
1703 | ret = -EINTR; | ||
1704 | goto out; | ||
1705 | } | ||
1706 | progress = try_to_free_mem_cgroup_pages(mem, GFP_KERNEL, | ||
1707 | false, get_swappiness(mem)); | ||
1708 | if (!progress) { | ||
1709 | nr_retries--; | ||
1710 | /* maybe some writeback is necessary */ | ||
1711 | congestion_wait(WRITE, HZ/10); | ||
1712 | } | ||
1713 | |||
1714 | } | ||
1715 | lru_add_drain(); | ||
1716 | /* try move_account...there may be some *locked* pages. */ | ||
1717 | if (mem->res.usage) | ||
1718 | goto move_account; | ||
1719 | ret = 0; | ||
1720 | goto out; | ||
1721 | } | ||
1722 | |||
1723 | int mem_cgroup_force_empty_write(struct cgroup *cont, unsigned int event) | ||
1724 | { | ||
1725 | return mem_cgroup_force_empty(mem_cgroup_from_cont(cont), true); | ||
1726 | } | ||
1727 | |||
1728 | |||
1729 | static u64 mem_cgroup_hierarchy_read(struct cgroup *cont, struct cftype *cft) | ||
1730 | { | ||
1731 | return mem_cgroup_from_cont(cont)->use_hierarchy; | ||
1732 | } | ||
1733 | |||
1734 | static int mem_cgroup_hierarchy_write(struct cgroup *cont, struct cftype *cft, | ||
1735 | u64 val) | ||
1736 | { | ||
1737 | int retval = 0; | ||
1738 | struct mem_cgroup *mem = mem_cgroup_from_cont(cont); | ||
1739 | struct cgroup *parent = cont->parent; | ||
1740 | struct mem_cgroup *parent_mem = NULL; | ||
1741 | |||
1742 | if (parent) | ||
1743 | parent_mem = mem_cgroup_from_cont(parent); | ||
1744 | |||
1745 | cgroup_lock(); | ||
1746 | /* | ||
1747 | * If parent's use_hiearchy is set, we can't make any modifications | ||
1748 | * in the child subtrees. If it is unset, then the change can | ||
1749 | * occur, provided the current cgroup has no children. | ||
1750 | * | ||
1751 | * For the root cgroup, parent_mem is NULL, we allow value to be | ||
1752 | * set if there are no children. | ||
1753 | */ | ||
1754 | if ((!parent_mem || !parent_mem->use_hierarchy) && | ||
1755 | (val == 1 || val == 0)) { | ||
1756 | if (list_empty(&cont->children)) | ||
1757 | mem->use_hierarchy = val; | ||
1758 | else | ||
1759 | retval = -EBUSY; | ||
1760 | } else | ||
1761 | retval = -EINVAL; | ||
1762 | cgroup_unlock(); | ||
1763 | |||
1764 | return retval; | ||
887 | } | 1765 | } |
888 | 1766 | ||
889 | static u64 mem_cgroup_read(struct cgroup *cont, struct cftype *cft) | 1767 | static u64 mem_cgroup_read(struct cgroup *cont, struct cftype *cft) |
890 | { | 1768 | { |
891 | return res_counter_read_u64(&mem_cgroup_from_cont(cont)->res, | 1769 | struct mem_cgroup *mem = mem_cgroup_from_cont(cont); |
892 | cft->private); | 1770 | u64 val = 0; |
1771 | int type, name; | ||
1772 | |||
1773 | type = MEMFILE_TYPE(cft->private); | ||
1774 | name = MEMFILE_ATTR(cft->private); | ||
1775 | switch (type) { | ||
1776 | case _MEM: | ||
1777 | val = res_counter_read_u64(&mem->res, name); | ||
1778 | break; | ||
1779 | case _MEMSWAP: | ||
1780 | if (do_swap_account) | ||
1781 | val = res_counter_read_u64(&mem->memsw, name); | ||
1782 | break; | ||
1783 | default: | ||
1784 | BUG(); | ||
1785 | break; | ||
1786 | } | ||
1787 | return val; | ||
893 | } | 1788 | } |
894 | /* | 1789 | /* |
895 | * The user of this function is... | 1790 | * The user of this function is... |
@@ -899,15 +1794,22 @@ static int mem_cgroup_write(struct cgroup *cont, struct cftype *cft, | |||
899 | const char *buffer) | 1794 | const char *buffer) |
900 | { | 1795 | { |
901 | struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); | 1796 | struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); |
1797 | int type, name; | ||
902 | unsigned long long val; | 1798 | unsigned long long val; |
903 | int ret; | 1799 | int ret; |
904 | 1800 | ||
905 | switch (cft->private) { | 1801 | type = MEMFILE_TYPE(cft->private); |
1802 | name = MEMFILE_ATTR(cft->private); | ||
1803 | switch (name) { | ||
906 | case RES_LIMIT: | 1804 | case RES_LIMIT: |
907 | /* This function does all necessary parse...reuse it */ | 1805 | /* This function does all necessary parse...reuse it */ |
908 | ret = res_counter_memparse_write_strategy(buffer, &val); | 1806 | ret = res_counter_memparse_write_strategy(buffer, &val); |
909 | if (!ret) | 1807 | if (ret) |
1808 | break; | ||
1809 | if (type == _MEM) | ||
910 | ret = mem_cgroup_resize_limit(memcg, val); | 1810 | ret = mem_cgroup_resize_limit(memcg, val); |
1811 | else | ||
1812 | ret = mem_cgroup_resize_memsw_limit(memcg, val); | ||
911 | break; | 1813 | break; |
912 | default: | 1814 | default: |
913 | ret = -EINVAL; /* should be BUG() ? */ | 1815 | ret = -EINVAL; /* should be BUG() ? */ |
@@ -916,27 +1818,59 @@ static int mem_cgroup_write(struct cgroup *cont, struct cftype *cft, | |||
916 | return ret; | 1818 | return ret; |
917 | } | 1819 | } |
918 | 1820 | ||
1821 | static void memcg_get_hierarchical_limit(struct mem_cgroup *memcg, | ||
1822 | unsigned long long *mem_limit, unsigned long long *memsw_limit) | ||
1823 | { | ||
1824 | struct cgroup *cgroup; | ||
1825 | unsigned long long min_limit, min_memsw_limit, tmp; | ||
1826 | |||
1827 | min_limit = res_counter_read_u64(&memcg->res, RES_LIMIT); | ||
1828 | min_memsw_limit = res_counter_read_u64(&memcg->memsw, RES_LIMIT); | ||
1829 | cgroup = memcg->css.cgroup; | ||
1830 | if (!memcg->use_hierarchy) | ||
1831 | goto out; | ||
1832 | |||
1833 | while (cgroup->parent) { | ||
1834 | cgroup = cgroup->parent; | ||
1835 | memcg = mem_cgroup_from_cont(cgroup); | ||
1836 | if (!memcg->use_hierarchy) | ||
1837 | break; | ||
1838 | tmp = res_counter_read_u64(&memcg->res, RES_LIMIT); | ||
1839 | min_limit = min(min_limit, tmp); | ||
1840 | tmp = res_counter_read_u64(&memcg->memsw, RES_LIMIT); | ||
1841 | min_memsw_limit = min(min_memsw_limit, tmp); | ||
1842 | } | ||
1843 | out: | ||
1844 | *mem_limit = min_limit; | ||
1845 | *memsw_limit = min_memsw_limit; | ||
1846 | return; | ||
1847 | } | ||
1848 | |||
919 | static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) | 1849 | static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) |
920 | { | 1850 | { |
921 | struct mem_cgroup *mem; | 1851 | struct mem_cgroup *mem; |
1852 | int type, name; | ||
922 | 1853 | ||
923 | mem = mem_cgroup_from_cont(cont); | 1854 | mem = mem_cgroup_from_cont(cont); |
924 | switch (event) { | 1855 | type = MEMFILE_TYPE(event); |
1856 | name = MEMFILE_ATTR(event); | ||
1857 | switch (name) { | ||
925 | case RES_MAX_USAGE: | 1858 | case RES_MAX_USAGE: |
926 | res_counter_reset_max(&mem->res); | 1859 | if (type == _MEM) |
1860 | res_counter_reset_max(&mem->res); | ||
1861 | else | ||
1862 | res_counter_reset_max(&mem->memsw); | ||
927 | break; | 1863 | break; |
928 | case RES_FAILCNT: | 1864 | case RES_FAILCNT: |
929 | res_counter_reset_failcnt(&mem->res); | 1865 | if (type == _MEM) |
1866 | res_counter_reset_failcnt(&mem->res); | ||
1867 | else | ||
1868 | res_counter_reset_failcnt(&mem->memsw); | ||
930 | break; | 1869 | break; |
931 | } | 1870 | } |
932 | return 0; | 1871 | return 0; |
933 | } | 1872 | } |
934 | 1873 | ||
935 | static int mem_force_empty_write(struct cgroup *cont, unsigned int event) | ||
936 | { | ||
937 | return mem_cgroup_force_empty(mem_cgroup_from_cont(cont)); | ||
938 | } | ||
939 | |||
940 | static const struct mem_cgroup_stat_desc { | 1874 | static const struct mem_cgroup_stat_desc { |
941 | const char *msg; | 1875 | const char *msg; |
942 | u64 unit; | 1876 | u64 unit; |
@@ -985,43 +1919,163 @@ static int mem_control_stat_show(struct cgroup *cont, struct cftype *cft, | |||
985 | cb->fill(cb, "unevictable", unevictable * PAGE_SIZE); | 1919 | cb->fill(cb, "unevictable", unevictable * PAGE_SIZE); |
986 | 1920 | ||
987 | } | 1921 | } |
1922 | { | ||
1923 | unsigned long long limit, memsw_limit; | ||
1924 | memcg_get_hierarchical_limit(mem_cont, &limit, &memsw_limit); | ||
1925 | cb->fill(cb, "hierarchical_memory_limit", limit); | ||
1926 | if (do_swap_account) | ||
1927 | cb->fill(cb, "hierarchical_memsw_limit", memsw_limit); | ||
1928 | } | ||
1929 | |||
1930 | #ifdef CONFIG_DEBUG_VM | ||
1931 | cb->fill(cb, "inactive_ratio", calc_inactive_ratio(mem_cont, NULL)); | ||
1932 | |||
1933 | { | ||
1934 | int nid, zid; | ||
1935 | struct mem_cgroup_per_zone *mz; | ||
1936 | unsigned long recent_rotated[2] = {0, 0}; | ||
1937 | unsigned long recent_scanned[2] = {0, 0}; | ||
1938 | |||
1939 | for_each_online_node(nid) | ||
1940 | for (zid = 0; zid < MAX_NR_ZONES; zid++) { | ||
1941 | mz = mem_cgroup_zoneinfo(mem_cont, nid, zid); | ||
1942 | |||
1943 | recent_rotated[0] += | ||
1944 | mz->reclaim_stat.recent_rotated[0]; | ||
1945 | recent_rotated[1] += | ||
1946 | mz->reclaim_stat.recent_rotated[1]; | ||
1947 | recent_scanned[0] += | ||
1948 | mz->reclaim_stat.recent_scanned[0]; | ||
1949 | recent_scanned[1] += | ||
1950 | mz->reclaim_stat.recent_scanned[1]; | ||
1951 | } | ||
1952 | cb->fill(cb, "recent_rotated_anon", recent_rotated[0]); | ||
1953 | cb->fill(cb, "recent_rotated_file", recent_rotated[1]); | ||
1954 | cb->fill(cb, "recent_scanned_anon", recent_scanned[0]); | ||
1955 | cb->fill(cb, "recent_scanned_file", recent_scanned[1]); | ||
1956 | } | ||
1957 | #endif | ||
1958 | |||
1959 | return 0; | ||
1960 | } | ||
1961 | |||
1962 | static u64 mem_cgroup_swappiness_read(struct cgroup *cgrp, struct cftype *cft) | ||
1963 | { | ||
1964 | struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); | ||
1965 | |||
1966 | return get_swappiness(memcg); | ||
1967 | } | ||
1968 | |||
1969 | static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, | ||
1970 | u64 val) | ||
1971 | { | ||
1972 | struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); | ||
1973 | struct mem_cgroup *parent; | ||
1974 | if (val > 100) | ||
1975 | return -EINVAL; | ||
1976 | |||
1977 | if (cgrp->parent == NULL) | ||
1978 | return -EINVAL; | ||
1979 | |||
1980 | parent = mem_cgroup_from_cont(cgrp->parent); | ||
1981 | /* If under hierarchy, only empty-root can set this value */ | ||
1982 | if ((parent->use_hierarchy) || | ||
1983 | (memcg->use_hierarchy && !list_empty(&cgrp->children))) | ||
1984 | return -EINVAL; | ||
1985 | |||
1986 | spin_lock(&memcg->reclaim_param_lock); | ||
1987 | memcg->swappiness = val; | ||
1988 | spin_unlock(&memcg->reclaim_param_lock); | ||
1989 | |||
988 | return 0; | 1990 | return 0; |
989 | } | 1991 | } |
990 | 1992 | ||
1993 | |||
991 | static struct cftype mem_cgroup_files[] = { | 1994 | static struct cftype mem_cgroup_files[] = { |
992 | { | 1995 | { |
993 | .name = "usage_in_bytes", | 1996 | .name = "usage_in_bytes", |
994 | .private = RES_USAGE, | 1997 | .private = MEMFILE_PRIVATE(_MEM, RES_USAGE), |
995 | .read_u64 = mem_cgroup_read, | 1998 | .read_u64 = mem_cgroup_read, |
996 | }, | 1999 | }, |
997 | { | 2000 | { |
998 | .name = "max_usage_in_bytes", | 2001 | .name = "max_usage_in_bytes", |
999 | .private = RES_MAX_USAGE, | 2002 | .private = MEMFILE_PRIVATE(_MEM, RES_MAX_USAGE), |
1000 | .trigger = mem_cgroup_reset, | 2003 | .trigger = mem_cgroup_reset, |
1001 | .read_u64 = mem_cgroup_read, | 2004 | .read_u64 = mem_cgroup_read, |
1002 | }, | 2005 | }, |
1003 | { | 2006 | { |
1004 | .name = "limit_in_bytes", | 2007 | .name = "limit_in_bytes", |
1005 | .private = RES_LIMIT, | 2008 | .private = MEMFILE_PRIVATE(_MEM, RES_LIMIT), |
1006 | .write_string = mem_cgroup_write, | 2009 | .write_string = mem_cgroup_write, |
1007 | .read_u64 = mem_cgroup_read, | 2010 | .read_u64 = mem_cgroup_read, |
1008 | }, | 2011 | }, |
1009 | { | 2012 | { |
1010 | .name = "failcnt", | 2013 | .name = "failcnt", |
1011 | .private = RES_FAILCNT, | 2014 | .private = MEMFILE_PRIVATE(_MEM, RES_FAILCNT), |
1012 | .trigger = mem_cgroup_reset, | 2015 | .trigger = mem_cgroup_reset, |
1013 | .read_u64 = mem_cgroup_read, | 2016 | .read_u64 = mem_cgroup_read, |
1014 | }, | 2017 | }, |
1015 | { | 2018 | { |
2019 | .name = "stat", | ||
2020 | .read_map = mem_control_stat_show, | ||
2021 | }, | ||
2022 | { | ||
1016 | .name = "force_empty", | 2023 | .name = "force_empty", |
1017 | .trigger = mem_force_empty_write, | 2024 | .trigger = mem_cgroup_force_empty_write, |
1018 | }, | 2025 | }, |
1019 | { | 2026 | { |
1020 | .name = "stat", | 2027 | .name = "use_hierarchy", |
1021 | .read_map = mem_control_stat_show, | 2028 | .write_u64 = mem_cgroup_hierarchy_write, |
2029 | .read_u64 = mem_cgroup_hierarchy_read, | ||
2030 | }, | ||
2031 | { | ||
2032 | .name = "swappiness", | ||
2033 | .read_u64 = mem_cgroup_swappiness_read, | ||
2034 | .write_u64 = mem_cgroup_swappiness_write, | ||
1022 | }, | 2035 | }, |
1023 | }; | 2036 | }; |
1024 | 2037 | ||
2038 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
2039 | static struct cftype memsw_cgroup_files[] = { | ||
2040 | { | ||
2041 | .name = "memsw.usage_in_bytes", | ||
2042 | .private = MEMFILE_PRIVATE(_MEMSWAP, RES_USAGE), | ||
2043 | .read_u64 = mem_cgroup_read, | ||
2044 | }, | ||
2045 | { | ||
2046 | .name = "memsw.max_usage_in_bytes", | ||
2047 | .private = MEMFILE_PRIVATE(_MEMSWAP, RES_MAX_USAGE), | ||
2048 | .trigger = mem_cgroup_reset, | ||
2049 | .read_u64 = mem_cgroup_read, | ||
2050 | }, | ||
2051 | { | ||
2052 | .name = "memsw.limit_in_bytes", | ||
2053 | .private = MEMFILE_PRIVATE(_MEMSWAP, RES_LIMIT), | ||
2054 | .write_string = mem_cgroup_write, | ||
2055 | .read_u64 = mem_cgroup_read, | ||
2056 | }, | ||
2057 | { | ||
2058 | .name = "memsw.failcnt", | ||
2059 | .private = MEMFILE_PRIVATE(_MEMSWAP, RES_FAILCNT), | ||
2060 | .trigger = mem_cgroup_reset, | ||
2061 | .read_u64 = mem_cgroup_read, | ||
2062 | }, | ||
2063 | }; | ||
2064 | |||
2065 | static int register_memsw_files(struct cgroup *cont, struct cgroup_subsys *ss) | ||
2066 | { | ||
2067 | if (!do_swap_account) | ||
2068 | return 0; | ||
2069 | return cgroup_add_files(cont, ss, memsw_cgroup_files, | ||
2070 | ARRAY_SIZE(memsw_cgroup_files)); | ||
2071 | }; | ||
2072 | #else | ||
2073 | static int register_memsw_files(struct cgroup *cont, struct cgroup_subsys *ss) | ||
2074 | { | ||
2075 | return 0; | ||
2076 | } | ||
2077 | #endif | ||
2078 | |||
1025 | static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) | 2079 | static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) |
1026 | { | 2080 | { |
1027 | struct mem_cgroup_per_node *pn; | 2081 | struct mem_cgroup_per_node *pn; |
@@ -1047,7 +2101,6 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) | |||
1047 | 2101 | ||
1048 | for (zone = 0; zone < MAX_NR_ZONES; zone++) { | 2102 | for (zone = 0; zone < MAX_NR_ZONES; zone++) { |
1049 | mz = &pn->zoneinfo[zone]; | 2103 | mz = &pn->zoneinfo[zone]; |
1050 | spin_lock_init(&mz->lru_lock); | ||
1051 | for_each_lru(l) | 2104 | for_each_lru(l) |
1052 | INIT_LIST_HEAD(&mz->lists[l]); | 2105 | INIT_LIST_HEAD(&mz->lists[l]); |
1053 | } | 2106 | } |
@@ -1059,55 +2112,113 @@ static void free_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) | |||
1059 | kfree(mem->info.nodeinfo[node]); | 2112 | kfree(mem->info.nodeinfo[node]); |
1060 | } | 2113 | } |
1061 | 2114 | ||
2115 | static int mem_cgroup_size(void) | ||
2116 | { | ||
2117 | int cpustat_size = nr_cpu_ids * sizeof(struct mem_cgroup_stat_cpu); | ||
2118 | return sizeof(struct mem_cgroup) + cpustat_size; | ||
2119 | } | ||
2120 | |||
1062 | static struct mem_cgroup *mem_cgroup_alloc(void) | 2121 | static struct mem_cgroup *mem_cgroup_alloc(void) |
1063 | { | 2122 | { |
1064 | struct mem_cgroup *mem; | 2123 | struct mem_cgroup *mem; |
2124 | int size = mem_cgroup_size(); | ||
1065 | 2125 | ||
1066 | if (sizeof(*mem) < PAGE_SIZE) | 2126 | if (size < PAGE_SIZE) |
1067 | mem = kmalloc(sizeof(*mem), GFP_KERNEL); | 2127 | mem = kmalloc(size, GFP_KERNEL); |
1068 | else | 2128 | else |
1069 | mem = vmalloc(sizeof(*mem)); | 2129 | mem = vmalloc(size); |
1070 | 2130 | ||
1071 | if (mem) | 2131 | if (mem) |
1072 | memset(mem, 0, sizeof(*mem)); | 2132 | memset(mem, 0, size); |
1073 | return mem; | 2133 | return mem; |
1074 | } | 2134 | } |
1075 | 2135 | ||
1076 | static void mem_cgroup_free(struct mem_cgroup *mem) | 2136 | /* |
2137 | * At destroying mem_cgroup, references from swap_cgroup can remain. | ||
2138 | * (scanning all at force_empty is too costly...) | ||
2139 | * | ||
2140 | * Instead of clearing all references at force_empty, we remember | ||
2141 | * the number of reference from swap_cgroup and free mem_cgroup when | ||
2142 | * it goes down to 0. | ||
2143 | * | ||
2144 | * Removal of cgroup itself succeeds regardless of refs from swap. | ||
2145 | */ | ||
2146 | |||
2147 | static void __mem_cgroup_free(struct mem_cgroup *mem) | ||
1077 | { | 2148 | { |
1078 | if (sizeof(*mem) < PAGE_SIZE) | 2149 | int node; |
2150 | |||
2151 | for_each_node_state(node, N_POSSIBLE) | ||
2152 | free_mem_cgroup_per_zone_info(mem, node); | ||
2153 | |||
2154 | if (mem_cgroup_size() < PAGE_SIZE) | ||
1079 | kfree(mem); | 2155 | kfree(mem); |
1080 | else | 2156 | else |
1081 | vfree(mem); | 2157 | vfree(mem); |
1082 | } | 2158 | } |
1083 | 2159 | ||
2160 | static void mem_cgroup_get(struct mem_cgroup *mem) | ||
2161 | { | ||
2162 | atomic_inc(&mem->refcnt); | ||
2163 | } | ||
2164 | |||
2165 | static void mem_cgroup_put(struct mem_cgroup *mem) | ||
2166 | { | ||
2167 | if (atomic_dec_and_test(&mem->refcnt)) | ||
2168 | __mem_cgroup_free(mem); | ||
2169 | } | ||
2170 | |||
2171 | |||
2172 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
2173 | static void __init enable_swap_cgroup(void) | ||
2174 | { | ||
2175 | if (!mem_cgroup_disabled() && really_do_swap_account) | ||
2176 | do_swap_account = 1; | ||
2177 | } | ||
2178 | #else | ||
2179 | static void __init enable_swap_cgroup(void) | ||
2180 | { | ||
2181 | } | ||
2182 | #endif | ||
1084 | 2183 | ||
1085 | static struct cgroup_subsys_state * | 2184 | static struct cgroup_subsys_state * |
1086 | mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont) | 2185 | mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont) |
1087 | { | 2186 | { |
1088 | struct mem_cgroup *mem; | 2187 | struct mem_cgroup *mem, *parent; |
1089 | int node; | 2188 | int node; |
1090 | 2189 | ||
1091 | if (unlikely((cont->parent) == NULL)) { | 2190 | mem = mem_cgroup_alloc(); |
1092 | mem = &init_mem_cgroup; | 2191 | if (!mem) |
1093 | } else { | 2192 | return ERR_PTR(-ENOMEM); |
1094 | mem = mem_cgroup_alloc(); | ||
1095 | if (!mem) | ||
1096 | return ERR_PTR(-ENOMEM); | ||
1097 | } | ||
1098 | |||
1099 | res_counter_init(&mem->res); | ||
1100 | 2193 | ||
1101 | for_each_node_state(node, N_POSSIBLE) | 2194 | for_each_node_state(node, N_POSSIBLE) |
1102 | if (alloc_mem_cgroup_per_zone_info(mem, node)) | 2195 | if (alloc_mem_cgroup_per_zone_info(mem, node)) |
1103 | goto free_out; | 2196 | goto free_out; |
2197 | /* root ? */ | ||
2198 | if (cont->parent == NULL) { | ||
2199 | enable_swap_cgroup(); | ||
2200 | parent = NULL; | ||
2201 | } else { | ||
2202 | parent = mem_cgroup_from_cont(cont->parent); | ||
2203 | mem->use_hierarchy = parent->use_hierarchy; | ||
2204 | } | ||
1104 | 2205 | ||
2206 | if (parent && parent->use_hierarchy) { | ||
2207 | res_counter_init(&mem->res, &parent->res); | ||
2208 | res_counter_init(&mem->memsw, &parent->memsw); | ||
2209 | } else { | ||
2210 | res_counter_init(&mem->res, NULL); | ||
2211 | res_counter_init(&mem->memsw, NULL); | ||
2212 | } | ||
2213 | mem->last_scanned_child = NULL; | ||
2214 | spin_lock_init(&mem->reclaim_param_lock); | ||
2215 | |||
2216 | if (parent) | ||
2217 | mem->swappiness = get_swappiness(parent); | ||
2218 | atomic_set(&mem->refcnt, 1); | ||
1105 | return &mem->css; | 2219 | return &mem->css; |
1106 | free_out: | 2220 | free_out: |
1107 | for_each_node_state(node, N_POSSIBLE) | 2221 | __mem_cgroup_free(mem); |
1108 | free_mem_cgroup_per_zone_info(mem, node); | ||
1109 | if (cont->parent != NULL) | ||
1110 | mem_cgroup_free(mem); | ||
1111 | return ERR_PTR(-ENOMEM); | 2222 | return ERR_PTR(-ENOMEM); |
1112 | } | 2223 | } |
1113 | 2224 | ||
@@ -1115,26 +2226,26 @@ static void mem_cgroup_pre_destroy(struct cgroup_subsys *ss, | |||
1115 | struct cgroup *cont) | 2226 | struct cgroup *cont) |
1116 | { | 2227 | { |
1117 | struct mem_cgroup *mem = mem_cgroup_from_cont(cont); | 2228 | struct mem_cgroup *mem = mem_cgroup_from_cont(cont); |
1118 | mem_cgroup_force_empty(mem); | 2229 | mem_cgroup_force_empty(mem, false); |
1119 | } | 2230 | } |
1120 | 2231 | ||
1121 | static void mem_cgroup_destroy(struct cgroup_subsys *ss, | 2232 | static void mem_cgroup_destroy(struct cgroup_subsys *ss, |
1122 | struct cgroup *cont) | 2233 | struct cgroup *cont) |
1123 | { | 2234 | { |
1124 | int node; | 2235 | mem_cgroup_put(mem_cgroup_from_cont(cont)); |
1125 | struct mem_cgroup *mem = mem_cgroup_from_cont(cont); | ||
1126 | |||
1127 | for_each_node_state(node, N_POSSIBLE) | ||
1128 | free_mem_cgroup_per_zone_info(mem, node); | ||
1129 | |||
1130 | mem_cgroup_free(mem_cgroup_from_cont(cont)); | ||
1131 | } | 2236 | } |
1132 | 2237 | ||
1133 | static int mem_cgroup_populate(struct cgroup_subsys *ss, | 2238 | static int mem_cgroup_populate(struct cgroup_subsys *ss, |
1134 | struct cgroup *cont) | 2239 | struct cgroup *cont) |
1135 | { | 2240 | { |
1136 | return cgroup_add_files(cont, ss, mem_cgroup_files, | 2241 | int ret; |
1137 | ARRAY_SIZE(mem_cgroup_files)); | 2242 | |
2243 | ret = cgroup_add_files(cont, ss, mem_cgroup_files, | ||
2244 | ARRAY_SIZE(mem_cgroup_files)); | ||
2245 | |||
2246 | if (!ret) | ||
2247 | ret = register_memsw_files(cont, ss); | ||
2248 | return ret; | ||
1138 | } | 2249 | } |
1139 | 2250 | ||
1140 | static void mem_cgroup_move_task(struct cgroup_subsys *ss, | 2251 | static void mem_cgroup_move_task(struct cgroup_subsys *ss, |
@@ -1142,25 +2253,12 @@ static void mem_cgroup_move_task(struct cgroup_subsys *ss, | |||
1142 | struct cgroup *old_cont, | 2253 | struct cgroup *old_cont, |
1143 | struct task_struct *p) | 2254 | struct task_struct *p) |
1144 | { | 2255 | { |
1145 | struct mm_struct *mm; | 2256 | mutex_lock(&memcg_tasklist); |
1146 | struct mem_cgroup *mem, *old_mem; | ||
1147 | |||
1148 | mm = get_task_mm(p); | ||
1149 | if (mm == NULL) | ||
1150 | return; | ||
1151 | |||
1152 | mem = mem_cgroup_from_cont(cont); | ||
1153 | old_mem = mem_cgroup_from_cont(old_cont); | ||
1154 | |||
1155 | /* | 2257 | /* |
1156 | * Only thread group leaders are allowed to migrate, the mm_struct is | 2258 | * FIXME: It's better to move charges of this process from old |
1157 | * in effect owned by the leader | 2259 | * memcg to new memcg. But it's just on TODO-List now. |
1158 | */ | 2260 | */ |
1159 | if (!thread_group_leader(p)) | 2261 | mutex_unlock(&memcg_tasklist); |
1160 | goto out; | ||
1161 | |||
1162 | out: | ||
1163 | mmput(mm); | ||
1164 | } | 2262 | } |
1165 | 2263 | ||
1166 | struct cgroup_subsys mem_cgroup_subsys = { | 2264 | struct cgroup_subsys mem_cgroup_subsys = { |
@@ -1173,3 +2271,13 @@ struct cgroup_subsys mem_cgroup_subsys = { | |||
1173 | .attach = mem_cgroup_move_task, | 2271 | .attach = mem_cgroup_move_task, |
1174 | .early_init = 0, | 2272 | .early_init = 0, |
1175 | }; | 2273 | }; |
2274 | |||
2275 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
2276 | |||
2277 | static int __init disable_swap_account(char *s) | ||
2278 | { | ||
2279 | really_do_swap_account = 0; | ||
2280 | return 1; | ||
2281 | } | ||
2282 | __setup("noswapaccount", disable_swap_account); | ||
2283 | #endif | ||
diff --git a/mm/memory.c b/mm/memory.c index 3f8fa06b963b..e009ce870859 100644 --- a/mm/memory.c +++ b/mm/memory.c | |||
@@ -2000,7 +2000,7 @@ gotten: | |||
2000 | cow_user_page(new_page, old_page, address, vma); | 2000 | cow_user_page(new_page, old_page, address, vma); |
2001 | __SetPageUptodate(new_page); | 2001 | __SetPageUptodate(new_page); |
2002 | 2002 | ||
2003 | if (mem_cgroup_charge(new_page, mm, GFP_KERNEL)) | 2003 | if (mem_cgroup_newpage_charge(new_page, mm, GFP_KERNEL)) |
2004 | goto oom_free_new; | 2004 | goto oom_free_new; |
2005 | 2005 | ||
2006 | /* | 2006 | /* |
@@ -2392,6 +2392,7 @@ static int do_swap_page(struct mm_struct *mm, struct vm_area_struct *vma, | |||
2392 | struct page *page; | 2392 | struct page *page; |
2393 | swp_entry_t entry; | 2393 | swp_entry_t entry; |
2394 | pte_t pte; | 2394 | pte_t pte; |
2395 | struct mem_cgroup *ptr = NULL; | ||
2395 | int ret = 0; | 2396 | int ret = 0; |
2396 | 2397 | ||
2397 | if (!pte_unmap_same(mm, pmd, page_table, orig_pte)) | 2398 | if (!pte_unmap_same(mm, pmd, page_table, orig_pte)) |
@@ -2430,7 +2431,7 @@ static int do_swap_page(struct mm_struct *mm, struct vm_area_struct *vma, | |||
2430 | lock_page(page); | 2431 | lock_page(page); |
2431 | delayacct_clear_flag(DELAYACCT_PF_SWAPIN); | 2432 | delayacct_clear_flag(DELAYACCT_PF_SWAPIN); |
2432 | 2433 | ||
2433 | if (mem_cgroup_charge(page, mm, GFP_KERNEL)) { | 2434 | if (mem_cgroup_try_charge_swapin(mm, page, GFP_KERNEL, &ptr)) { |
2434 | ret = VM_FAULT_OOM; | 2435 | ret = VM_FAULT_OOM; |
2435 | unlock_page(page); | 2436 | unlock_page(page); |
2436 | goto out; | 2437 | goto out; |
@@ -2448,7 +2449,19 @@ static int do_swap_page(struct mm_struct *mm, struct vm_area_struct *vma, | |||
2448 | goto out_nomap; | 2449 | goto out_nomap; |
2449 | } | 2450 | } |
2450 | 2451 | ||
2451 | /* The page isn't present yet, go ahead with the fault. */ | 2452 | /* |
2453 | * The page isn't present yet, go ahead with the fault. | ||
2454 | * | ||
2455 | * Be careful about the sequence of operations here. | ||
2456 | * To get its accounting right, reuse_swap_page() must be called | ||
2457 | * while the page is counted on swap but not yet in mapcount i.e. | ||
2458 | * before page_add_anon_rmap() and swap_free(); try_to_free_swap() | ||
2459 | * must be called after the swap_free(), or it will never succeed. | ||
2460 | * Because delete_from_swap_page() may be called by reuse_swap_page(), | ||
2461 | * mem_cgroup_commit_charge_swapin() may not be able to find swp_entry | ||
2462 | * in page->private. In this case, a record in swap_cgroup is silently | ||
2463 | * discarded at swap_free(). | ||
2464 | */ | ||
2452 | 2465 | ||
2453 | inc_mm_counter(mm, anon_rss); | 2466 | inc_mm_counter(mm, anon_rss); |
2454 | pte = mk_pte(page, vma->vm_page_prot); | 2467 | pte = mk_pte(page, vma->vm_page_prot); |
@@ -2456,10 +2469,11 @@ static int do_swap_page(struct mm_struct *mm, struct vm_area_struct *vma, | |||
2456 | pte = maybe_mkwrite(pte_mkdirty(pte), vma); | 2469 | pte = maybe_mkwrite(pte_mkdirty(pte), vma); |
2457 | write_access = 0; | 2470 | write_access = 0; |
2458 | } | 2471 | } |
2459 | |||
2460 | flush_icache_page(vma, page); | 2472 | flush_icache_page(vma, page); |
2461 | set_pte_at(mm, address, page_table, pte); | 2473 | set_pte_at(mm, address, page_table, pte); |
2462 | page_add_anon_rmap(page, vma, address); | 2474 | page_add_anon_rmap(page, vma, address); |
2475 | /* It's better to call commit-charge after rmap is established */ | ||
2476 | mem_cgroup_commit_charge_swapin(page, ptr); | ||
2463 | 2477 | ||
2464 | swap_free(entry); | 2478 | swap_free(entry); |
2465 | if (vm_swap_full() || (vma->vm_flags & VM_LOCKED) || PageMlocked(page)) | 2479 | if (vm_swap_full() || (vma->vm_flags & VM_LOCKED) || PageMlocked(page)) |
@@ -2480,7 +2494,7 @@ unlock: | |||
2480 | out: | 2494 | out: |
2481 | return ret; | 2495 | return ret; |
2482 | out_nomap: | 2496 | out_nomap: |
2483 | mem_cgroup_uncharge_page(page); | 2497 | mem_cgroup_cancel_charge_swapin(ptr); |
2484 | pte_unmap_unlock(page_table, ptl); | 2498 | pte_unmap_unlock(page_table, ptl); |
2485 | unlock_page(page); | 2499 | unlock_page(page); |
2486 | page_cache_release(page); | 2500 | page_cache_release(page); |
@@ -2510,7 +2524,7 @@ static int do_anonymous_page(struct mm_struct *mm, struct vm_area_struct *vma, | |||
2510 | goto oom; | 2524 | goto oom; |
2511 | __SetPageUptodate(page); | 2525 | __SetPageUptodate(page); |
2512 | 2526 | ||
2513 | if (mem_cgroup_charge(page, mm, GFP_KERNEL)) | 2527 | if (mem_cgroup_newpage_charge(page, mm, GFP_KERNEL)) |
2514 | goto oom_free_page; | 2528 | goto oom_free_page; |
2515 | 2529 | ||
2516 | entry = mk_pte(page, vma->vm_page_prot); | 2530 | entry = mk_pte(page, vma->vm_page_prot); |
@@ -2601,7 +2615,7 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma, | |||
2601 | ret = VM_FAULT_OOM; | 2615 | ret = VM_FAULT_OOM; |
2602 | goto out; | 2616 | goto out; |
2603 | } | 2617 | } |
2604 | if (mem_cgroup_charge(page, mm, GFP_KERNEL)) { | 2618 | if (mem_cgroup_newpage_charge(page, mm, GFP_KERNEL)) { |
2605 | ret = VM_FAULT_OOM; | 2619 | ret = VM_FAULT_OOM; |
2606 | page_cache_release(page); | 2620 | page_cache_release(page); |
2607 | goto out; | 2621 | goto out; |
diff --git a/mm/migrate.c b/mm/migrate.c index 55373983c9c6..a30ea5fcf9f1 100644 --- a/mm/migrate.c +++ b/mm/migrate.c | |||
@@ -121,20 +121,6 @@ static void remove_migration_pte(struct vm_area_struct *vma, | |||
121 | if (!is_migration_entry(entry) || migration_entry_to_page(entry) != old) | 121 | if (!is_migration_entry(entry) || migration_entry_to_page(entry) != old) |
122 | goto out; | 122 | goto out; |
123 | 123 | ||
124 | /* | ||
125 | * Yes, ignore the return value from a GFP_ATOMIC mem_cgroup_charge. | ||
126 | * Failure is not an option here: we're now expected to remove every | ||
127 | * migration pte, and will cause crashes otherwise. Normally this | ||
128 | * is not an issue: mem_cgroup_prepare_migration bumped up the old | ||
129 | * page_cgroup count for safety, that's now attached to the new page, | ||
130 | * so this charge should just be another incrementation of the count, | ||
131 | * to keep in balance with rmap.c's mem_cgroup_uncharging. But if | ||
132 | * there's been a force_empty, those reference counts may no longer | ||
133 | * be reliable, and this charge can actually fail: oh well, we don't | ||
134 | * make the situation any worse by proceeding as if it had succeeded. | ||
135 | */ | ||
136 | mem_cgroup_charge(new, mm, GFP_ATOMIC); | ||
137 | |||
138 | get_page(new); | 124 | get_page(new); |
139 | pte = pte_mkold(mk_pte(new, vma->vm_page_prot)); | 125 | pte = pte_mkold(mk_pte(new, vma->vm_page_prot)); |
140 | if (is_write_migration_entry(entry)) | 126 | if (is_write_migration_entry(entry)) |
@@ -378,9 +364,6 @@ static void migrate_page_copy(struct page *newpage, struct page *page) | |||
378 | anon = PageAnon(page); | 364 | anon = PageAnon(page); |
379 | page->mapping = NULL; | 365 | page->mapping = NULL; |
380 | 366 | ||
381 | if (!anon) /* This page was removed from radix-tree. */ | ||
382 | mem_cgroup_uncharge_cache_page(page); | ||
383 | |||
384 | /* | 367 | /* |
385 | * If any waiters have accumulated on the new page then | 368 | * If any waiters have accumulated on the new page then |
386 | * wake them up. | 369 | * wake them up. |
@@ -614,6 +597,7 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private, | |||
614 | struct page *newpage = get_new_page(page, private, &result); | 597 | struct page *newpage = get_new_page(page, private, &result); |
615 | int rcu_locked = 0; | 598 | int rcu_locked = 0; |
616 | int charge = 0; | 599 | int charge = 0; |
600 | struct mem_cgroup *mem; | ||
617 | 601 | ||
618 | if (!newpage) | 602 | if (!newpage) |
619 | return -ENOMEM; | 603 | return -ENOMEM; |
@@ -623,24 +607,26 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private, | |||
623 | goto move_newpage; | 607 | goto move_newpage; |
624 | } | 608 | } |
625 | 609 | ||
626 | charge = mem_cgroup_prepare_migration(page, newpage); | ||
627 | if (charge == -ENOMEM) { | ||
628 | rc = -ENOMEM; | ||
629 | goto move_newpage; | ||
630 | } | ||
631 | /* prepare cgroup just returns 0 or -ENOMEM */ | 610 | /* prepare cgroup just returns 0 or -ENOMEM */ |
632 | BUG_ON(charge); | ||
633 | |||
634 | rc = -EAGAIN; | 611 | rc = -EAGAIN; |
612 | |||
635 | if (!trylock_page(page)) { | 613 | if (!trylock_page(page)) { |
636 | if (!force) | 614 | if (!force) |
637 | goto move_newpage; | 615 | goto move_newpage; |
638 | lock_page(page); | 616 | lock_page(page); |
639 | } | 617 | } |
640 | 618 | ||
619 | /* charge against new page */ | ||
620 | charge = mem_cgroup_prepare_migration(page, &mem); | ||
621 | if (charge == -ENOMEM) { | ||
622 | rc = -ENOMEM; | ||
623 | goto unlock; | ||
624 | } | ||
625 | BUG_ON(charge); | ||
626 | |||
641 | if (PageWriteback(page)) { | 627 | if (PageWriteback(page)) { |
642 | if (!force) | 628 | if (!force) |
643 | goto unlock; | 629 | goto uncharge; |
644 | wait_on_page_writeback(page); | 630 | wait_on_page_writeback(page); |
645 | } | 631 | } |
646 | /* | 632 | /* |
@@ -693,7 +679,9 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private, | |||
693 | rcu_unlock: | 679 | rcu_unlock: |
694 | if (rcu_locked) | 680 | if (rcu_locked) |
695 | rcu_read_unlock(); | 681 | rcu_read_unlock(); |
696 | 682 | uncharge: | |
683 | if (!charge) | ||
684 | mem_cgroup_end_migration(mem, page, newpage); | ||
697 | unlock: | 685 | unlock: |
698 | unlock_page(page); | 686 | unlock_page(page); |
699 | 687 | ||
@@ -709,8 +697,6 @@ unlock: | |||
709 | } | 697 | } |
710 | 698 | ||
711 | move_newpage: | 699 | move_newpage: |
712 | if (!charge) | ||
713 | mem_cgroup_end_migration(newpage); | ||
714 | 700 | ||
715 | /* | 701 | /* |
716 | * Move the new page to the LRU. If migration was not successful | 702 | * Move the new page to the LRU. If migration was not successful |
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 6b9e758c98a5..40ba05061a4f 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c | |||
@@ -429,7 +429,6 @@ void mem_cgroup_out_of_memory(struct mem_cgroup *mem, gfp_t gfp_mask) | |||
429 | unsigned long points = 0; | 429 | unsigned long points = 0; |
430 | struct task_struct *p; | 430 | struct task_struct *p; |
431 | 431 | ||
432 | cgroup_lock(); | ||
433 | read_lock(&tasklist_lock); | 432 | read_lock(&tasklist_lock); |
434 | retry: | 433 | retry: |
435 | p = select_bad_process(&points, mem); | 434 | p = select_bad_process(&points, mem); |
@@ -444,7 +443,6 @@ retry: | |||
444 | goto retry; | 443 | goto retry; |
445 | out: | 444 | out: |
446 | read_unlock(&tasklist_lock); | 445 | read_unlock(&tasklist_lock); |
447 | cgroup_unlock(); | ||
448 | } | 446 | } |
449 | #endif | 447 | #endif |
450 | 448 | ||
@@ -560,6 +558,13 @@ void pagefault_out_of_memory(void) | |||
560 | /* Got some memory back in the last second. */ | 558 | /* Got some memory back in the last second. */ |
561 | return; | 559 | return; |
562 | 560 | ||
561 | /* | ||
562 | * If this is from memcg, oom-killer is already invoked. | ||
563 | * and not worth to go system-wide-oom. | ||
564 | */ | ||
565 | if (mem_cgroup_oom_called(current)) | ||
566 | goto rest_and_return; | ||
567 | |||
563 | if (sysctl_panic_on_oom) | 568 | if (sysctl_panic_on_oom) |
564 | panic("out of memory from page fault. panic_on_oom is selected.\n"); | 569 | panic("out of memory from page fault. panic_on_oom is selected.\n"); |
565 | 570 | ||
@@ -571,6 +576,7 @@ void pagefault_out_of_memory(void) | |||
571 | * Give "p" a good chance of killing itself before we | 576 | * Give "p" a good chance of killing itself before we |
572 | * retry to allocate memory. | 577 | * retry to allocate memory. |
573 | */ | 578 | */ |
579 | rest_and_return: | ||
574 | if (!test_thread_flag(TIF_MEMDIE)) | 580 | if (!test_thread_flag(TIF_MEMDIE)) |
575 | schedule_timeout_uninterruptible(1); | 581 | schedule_timeout_uninterruptible(1); |
576 | } | 582 | } |
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7bf22e045318..5675b3073854 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
@@ -3523,10 +3523,10 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat, | |||
3523 | INIT_LIST_HEAD(&zone->lru[l].list); | 3523 | INIT_LIST_HEAD(&zone->lru[l].list); |
3524 | zone->lru[l].nr_scan = 0; | 3524 | zone->lru[l].nr_scan = 0; |
3525 | } | 3525 | } |
3526 | zone->recent_rotated[0] = 0; | 3526 | zone->reclaim_stat.recent_rotated[0] = 0; |
3527 | zone->recent_rotated[1] = 0; | 3527 | zone->reclaim_stat.recent_rotated[1] = 0; |
3528 | zone->recent_scanned[0] = 0; | 3528 | zone->reclaim_stat.recent_scanned[0] = 0; |
3529 | zone->recent_scanned[1] = 0; | 3529 | zone->reclaim_stat.recent_scanned[1] = 0; |
3530 | zap_zone_vm_stats(zone); | 3530 | zap_zone_vm_stats(zone); |
3531 | zone->flags = 0; | 3531 | zone->flags = 0; |
3532 | if (!size) | 3532 | if (!size) |
diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c index d6507a660ed6..7006a11350c8 100644 --- a/mm/page_cgroup.c +++ b/mm/page_cgroup.c | |||
@@ -8,6 +8,7 @@ | |||
8 | #include <linux/memory.h> | 8 | #include <linux/memory.h> |
9 | #include <linux/vmalloc.h> | 9 | #include <linux/vmalloc.h> |
10 | #include <linux/cgroup.h> | 10 | #include <linux/cgroup.h> |
11 | #include <linux/swapops.h> | ||
11 | 12 | ||
12 | static void __meminit | 13 | static void __meminit |
13 | __init_page_cgroup(struct page_cgroup *pc, unsigned long pfn) | 14 | __init_page_cgroup(struct page_cgroup *pc, unsigned long pfn) |
@@ -15,6 +16,7 @@ __init_page_cgroup(struct page_cgroup *pc, unsigned long pfn) | |||
15 | pc->flags = 0; | 16 | pc->flags = 0; |
16 | pc->mem_cgroup = NULL; | 17 | pc->mem_cgroup = NULL; |
17 | pc->page = pfn_to_page(pfn); | 18 | pc->page = pfn_to_page(pfn); |
19 | INIT_LIST_HEAD(&pc->lru); | ||
18 | } | 20 | } |
19 | static unsigned long total_usage; | 21 | static unsigned long total_usage; |
20 | 22 | ||
@@ -72,7 +74,7 @@ void __init page_cgroup_init(void) | |||
72 | 74 | ||
73 | int nid, fail; | 75 | int nid, fail; |
74 | 76 | ||
75 | if (mem_cgroup_subsys.disabled) | 77 | if (mem_cgroup_disabled()) |
76 | return; | 78 | return; |
77 | 79 | ||
78 | for_each_online_node(nid) { | 80 | for_each_online_node(nid) { |
@@ -103,13 +105,11 @@ struct page_cgroup *lookup_page_cgroup(struct page *page) | |||
103 | /* __alloc_bootmem...() is protected by !slab_available() */ | 105 | /* __alloc_bootmem...() is protected by !slab_available() */ |
104 | static int __init_refok init_section_page_cgroup(unsigned long pfn) | 106 | static int __init_refok init_section_page_cgroup(unsigned long pfn) |
105 | { | 107 | { |
106 | struct mem_section *section; | 108 | struct mem_section *section = __pfn_to_section(pfn); |
107 | struct page_cgroup *base, *pc; | 109 | struct page_cgroup *base, *pc; |
108 | unsigned long table_size; | 110 | unsigned long table_size; |
109 | int nid, index; | 111 | int nid, index; |
110 | 112 | ||
111 | section = __pfn_to_section(pfn); | ||
112 | |||
113 | if (!section->page_cgroup) { | 113 | if (!section->page_cgroup) { |
114 | nid = page_to_nid(pfn_to_page(pfn)); | 114 | nid = page_to_nid(pfn_to_page(pfn)); |
115 | table_size = sizeof(struct page_cgroup) * PAGES_PER_SECTION; | 115 | table_size = sizeof(struct page_cgroup) * PAGES_PER_SECTION; |
@@ -145,7 +145,6 @@ static int __init_refok init_section_page_cgroup(unsigned long pfn) | |||
145 | __init_page_cgroup(pc, pfn + index); | 145 | __init_page_cgroup(pc, pfn + index); |
146 | } | 146 | } |
147 | 147 | ||
148 | section = __pfn_to_section(pfn); | ||
149 | section->page_cgroup = base - pfn; | 148 | section->page_cgroup = base - pfn; |
150 | total_usage += table_size; | 149 | total_usage += table_size; |
151 | return 0; | 150 | return 0; |
@@ -248,7 +247,7 @@ void __init page_cgroup_init(void) | |||
248 | unsigned long pfn; | 247 | unsigned long pfn; |
249 | int fail = 0; | 248 | int fail = 0; |
250 | 249 | ||
251 | if (mem_cgroup_subsys.disabled) | 250 | if (mem_cgroup_disabled()) |
252 | return; | 251 | return; |
253 | 252 | ||
254 | for (pfn = 0; !fail && pfn < max_pfn; pfn += PAGES_PER_SECTION) { | 253 | for (pfn = 0; !fail && pfn < max_pfn; pfn += PAGES_PER_SECTION) { |
@@ -273,3 +272,199 @@ void __meminit pgdat_page_cgroup_init(struct pglist_data *pgdat) | |||
273 | } | 272 | } |
274 | 273 | ||
275 | #endif | 274 | #endif |
275 | |||
276 | |||
277 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP | ||
278 | |||
279 | static DEFINE_MUTEX(swap_cgroup_mutex); | ||
280 | struct swap_cgroup_ctrl { | ||
281 | struct page **map; | ||
282 | unsigned long length; | ||
283 | }; | ||
284 | |||
285 | struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES]; | ||
286 | |||
287 | /* | ||
288 | * This 8bytes seems big..maybe we can reduce this when we can use "id" for | ||
289 | * cgroup rather than pointer. | ||
290 | */ | ||
291 | struct swap_cgroup { | ||
292 | struct mem_cgroup *val; | ||
293 | }; | ||
294 | #define SC_PER_PAGE (PAGE_SIZE/sizeof(struct swap_cgroup)) | ||
295 | #define SC_POS_MASK (SC_PER_PAGE - 1) | ||
296 | |||
297 | /* | ||
298 | * SwapCgroup implements "lookup" and "exchange" operations. | ||
299 | * In typical usage, this swap_cgroup is accessed via memcg's charge/uncharge | ||
300 | * against SwapCache. At swap_free(), this is accessed directly from swap. | ||
301 | * | ||
302 | * This means, | ||
303 | * - we have no race in "exchange" when we're accessed via SwapCache because | ||
304 | * SwapCache(and its swp_entry) is under lock. | ||
305 | * - When called via swap_free(), there is no user of this entry and no race. | ||
306 | * Then, we don't need lock around "exchange". | ||
307 | * | ||
308 | * TODO: we can push these buffers out to HIGHMEM. | ||
309 | */ | ||
310 | |||
311 | /* | ||
312 | * allocate buffer for swap_cgroup. | ||
313 | */ | ||
314 | static int swap_cgroup_prepare(int type) | ||
315 | { | ||
316 | struct page *page; | ||
317 | struct swap_cgroup_ctrl *ctrl; | ||
318 | unsigned long idx, max; | ||
319 | |||
320 | if (!do_swap_account) | ||
321 | return 0; | ||
322 | ctrl = &swap_cgroup_ctrl[type]; | ||
323 | |||
324 | for (idx = 0; idx < ctrl->length; idx++) { | ||
325 | page = alloc_page(GFP_KERNEL | __GFP_ZERO); | ||
326 | if (!page) | ||
327 | goto not_enough_page; | ||
328 | ctrl->map[idx] = page; | ||
329 | } | ||
330 | return 0; | ||
331 | not_enough_page: | ||
332 | max = idx; | ||
333 | for (idx = 0; idx < max; idx++) | ||
334 | __free_page(ctrl->map[idx]); | ||
335 | |||
336 | return -ENOMEM; | ||
337 | } | ||
338 | |||
339 | /** | ||
340 | * swap_cgroup_record - record mem_cgroup for this swp_entry. | ||
341 | * @ent: swap entry to be recorded into | ||
342 | * @mem: mem_cgroup to be recorded | ||
343 | * | ||
344 | * Returns old value at success, NULL at failure. | ||
345 | * (Of course, old value can be NULL.) | ||
346 | */ | ||
347 | struct mem_cgroup *swap_cgroup_record(swp_entry_t ent, struct mem_cgroup *mem) | ||
348 | { | ||
349 | int type = swp_type(ent); | ||
350 | unsigned long offset = swp_offset(ent); | ||
351 | unsigned long idx = offset / SC_PER_PAGE; | ||
352 | unsigned long pos = offset & SC_POS_MASK; | ||
353 | struct swap_cgroup_ctrl *ctrl; | ||
354 | struct page *mappage; | ||
355 | struct swap_cgroup *sc; | ||
356 | struct mem_cgroup *old; | ||
357 | |||
358 | if (!do_swap_account) | ||
359 | return NULL; | ||
360 | |||
361 | ctrl = &swap_cgroup_ctrl[type]; | ||
362 | |||
363 | mappage = ctrl->map[idx]; | ||
364 | sc = page_address(mappage); | ||
365 | sc += pos; | ||
366 | old = sc->val; | ||
367 | sc->val = mem; | ||
368 | |||
369 | return old; | ||
370 | } | ||
371 | |||
372 | /** | ||
373 | * lookup_swap_cgroup - lookup mem_cgroup tied to swap entry | ||
374 | * @ent: swap entry to be looked up. | ||
375 | * | ||
376 | * Returns pointer to mem_cgroup at success. NULL at failure. | ||
377 | */ | ||
378 | struct mem_cgroup *lookup_swap_cgroup(swp_entry_t ent) | ||
379 | { | ||
380 | int type = swp_type(ent); | ||
381 | unsigned long offset = swp_offset(ent); | ||
382 | unsigned long idx = offset / SC_PER_PAGE; | ||
383 | unsigned long pos = offset & SC_POS_MASK; | ||
384 | struct swap_cgroup_ctrl *ctrl; | ||
385 | struct page *mappage; | ||
386 | struct swap_cgroup *sc; | ||
387 | struct mem_cgroup *ret; | ||
388 | |||
389 | if (!do_swap_account) | ||
390 | return NULL; | ||
391 | |||
392 | ctrl = &swap_cgroup_ctrl[type]; | ||
393 | mappage = ctrl->map[idx]; | ||
394 | sc = page_address(mappage); | ||
395 | sc += pos; | ||
396 | ret = sc->val; | ||
397 | return ret; | ||
398 | } | ||
399 | |||
400 | int swap_cgroup_swapon(int type, unsigned long max_pages) | ||
401 | { | ||
402 | void *array; | ||
403 | unsigned long array_size; | ||
404 | unsigned long length; | ||
405 | struct swap_cgroup_ctrl *ctrl; | ||
406 | |||
407 | if (!do_swap_account) | ||
408 | return 0; | ||
409 | |||
410 | length = ((max_pages/SC_PER_PAGE) + 1); | ||
411 | array_size = length * sizeof(void *); | ||
412 | |||
413 | array = vmalloc(array_size); | ||
414 | if (!array) | ||
415 | goto nomem; | ||
416 | |||
417 | memset(array, 0, array_size); | ||
418 | ctrl = &swap_cgroup_ctrl[type]; | ||
419 | mutex_lock(&swap_cgroup_mutex); | ||
420 | ctrl->length = length; | ||
421 | ctrl->map = array; | ||
422 | if (swap_cgroup_prepare(type)) { | ||
423 | /* memory shortage */ | ||
424 | ctrl->map = NULL; | ||
425 | ctrl->length = 0; | ||
426 | vfree(array); | ||
427 | mutex_unlock(&swap_cgroup_mutex); | ||
428 | goto nomem; | ||
429 | } | ||
430 | mutex_unlock(&swap_cgroup_mutex); | ||
431 | |||
432 | printk(KERN_INFO | ||
433 | "swap_cgroup: uses %ld bytes of vmalloc for pointer array space" | ||
434 | " and %ld bytes to hold mem_cgroup pointers on swap\n", | ||
435 | array_size, length * PAGE_SIZE); | ||
436 | printk(KERN_INFO | ||
437 | "swap_cgroup can be disabled by noswapaccount boot option.\n"); | ||
438 | |||
439 | return 0; | ||
440 | nomem: | ||
441 | printk(KERN_INFO "couldn't allocate enough memory for swap_cgroup.\n"); | ||
442 | printk(KERN_INFO | ||
443 | "swap_cgroup can be disabled by noswapaccount boot option\n"); | ||
444 | return -ENOMEM; | ||
445 | } | ||
446 | |||
447 | void swap_cgroup_swapoff(int type) | ||
448 | { | ||
449 | int i; | ||
450 | struct swap_cgroup_ctrl *ctrl; | ||
451 | |||
452 | if (!do_swap_account) | ||
453 | return; | ||
454 | |||
455 | mutex_lock(&swap_cgroup_mutex); | ||
456 | ctrl = &swap_cgroup_ctrl[type]; | ||
457 | if (ctrl->map) { | ||
458 | for (i = 0; i < ctrl->length; i++) { | ||
459 | struct page *page = ctrl->map[i]; | ||
460 | if (page) | ||
461 | __free_page(page); | ||
462 | } | ||
463 | vfree(ctrl->map); | ||
464 | ctrl->map = NULL; | ||
465 | ctrl->length = 0; | ||
466 | } | ||
467 | mutex_unlock(&swap_cgroup_mutex); | ||
468 | } | ||
469 | |||
470 | #endif | ||
diff --git a/mm/shmem.c b/mm/shmem.c index 5941f9801363..5d0de96c9789 100644 --- a/mm/shmem.c +++ b/mm/shmem.c | |||
@@ -928,7 +928,11 @@ found: | |||
928 | error = 1; | 928 | error = 1; |
929 | if (!inode) | 929 | if (!inode) |
930 | goto out; | 930 | goto out; |
931 | /* Precharge page using GFP_KERNEL while we can wait */ | 931 | /* |
932 | * Charge page using GFP_KERNEL while we can wait. | ||
933 | * Charged back to the user(not to caller) when swap account is used. | ||
934 | * add_to_page_cache() will be called with GFP_NOWAIT. | ||
935 | */ | ||
932 | error = mem_cgroup_cache_charge(page, current->mm, GFP_KERNEL); | 936 | error = mem_cgroup_cache_charge(page, current->mm, GFP_KERNEL); |
933 | if (error) | 937 | if (error) |
934 | goto out; | 938 | goto out; |
@@ -1320,15 +1324,19 @@ repeat: | |||
1320 | } else { | 1324 | } else { |
1321 | shmem_swp_unmap(entry); | 1325 | shmem_swp_unmap(entry); |
1322 | spin_unlock(&info->lock); | 1326 | spin_unlock(&info->lock); |
1323 | unlock_page(swappage); | ||
1324 | page_cache_release(swappage); | ||
1325 | if (error == -ENOMEM) { | 1327 | if (error == -ENOMEM) { |
1326 | /* allow reclaim from this memory cgroup */ | 1328 | /* allow reclaim from this memory cgroup */ |
1327 | error = mem_cgroup_shrink_usage(current->mm, | 1329 | error = mem_cgroup_shrink_usage(swappage, |
1330 | current->mm, | ||
1328 | gfp); | 1331 | gfp); |
1329 | if (error) | 1332 | if (error) { |
1333 | unlock_page(swappage); | ||
1334 | page_cache_release(swappage); | ||
1330 | goto failed; | 1335 | goto failed; |
1336 | } | ||
1331 | } | 1337 | } |
1338 | unlock_page(swappage); | ||
1339 | page_cache_release(swappage); | ||
1332 | goto repeat; | 1340 | goto repeat; |
1333 | } | 1341 | } |
1334 | } else if (sgp == SGP_READ && !filepage) { | 1342 | } else if (sgp == SGP_READ && !filepage) { |
@@ -1379,7 +1387,7 @@ repeat: | |||
1379 | 1387 | ||
1380 | /* Precharge page while we can wait, compensate after */ | 1388 | /* Precharge page while we can wait, compensate after */ |
1381 | error = mem_cgroup_cache_charge(filepage, current->mm, | 1389 | error = mem_cgroup_cache_charge(filepage, current->mm, |
1382 | gfp & ~__GFP_HIGHMEM); | 1390 | GFP_KERNEL); |
1383 | if (error) { | 1391 | if (error) { |
1384 | page_cache_release(filepage); | 1392 | page_cache_release(filepage); |
1385 | shmem_unacct_blocks(info->flags, 1); | 1393 | shmem_unacct_blocks(info->flags, 1); |
@@ -151,6 +151,26 @@ void rotate_reclaimable_page(struct page *page) | |||
151 | } | 151 | } |
152 | } | 152 | } |
153 | 153 | ||
154 | static void update_page_reclaim_stat(struct zone *zone, struct page *page, | ||
155 | int file, int rotated) | ||
156 | { | ||
157 | struct zone_reclaim_stat *reclaim_stat = &zone->reclaim_stat; | ||
158 | struct zone_reclaim_stat *memcg_reclaim_stat; | ||
159 | |||
160 | memcg_reclaim_stat = mem_cgroup_get_reclaim_stat_from_page(page); | ||
161 | |||
162 | reclaim_stat->recent_scanned[file]++; | ||
163 | if (rotated) | ||
164 | reclaim_stat->recent_rotated[file]++; | ||
165 | |||
166 | if (!memcg_reclaim_stat) | ||
167 | return; | ||
168 | |||
169 | memcg_reclaim_stat->recent_scanned[file]++; | ||
170 | if (rotated) | ||
171 | memcg_reclaim_stat->recent_rotated[file]++; | ||
172 | } | ||
173 | |||
154 | /* | 174 | /* |
155 | * FIXME: speed this up? | 175 | * FIXME: speed this up? |
156 | */ | 176 | */ |
@@ -168,10 +188,8 @@ void activate_page(struct page *page) | |||
168 | lru += LRU_ACTIVE; | 188 | lru += LRU_ACTIVE; |
169 | add_page_to_lru_list(zone, page, lru); | 189 | add_page_to_lru_list(zone, page, lru); |
170 | __count_vm_event(PGACTIVATE); | 190 | __count_vm_event(PGACTIVATE); |
171 | mem_cgroup_move_lists(page, lru); | ||
172 | 191 | ||
173 | zone->recent_rotated[!!file]++; | 192 | update_page_reclaim_stat(zone, page, !!file, 1); |
174 | zone->recent_scanned[!!file]++; | ||
175 | } | 193 | } |
176 | spin_unlock_irq(&zone->lru_lock); | 194 | spin_unlock_irq(&zone->lru_lock); |
177 | } | 195 | } |
@@ -386,12 +404,14 @@ void ____pagevec_lru_add(struct pagevec *pvec, enum lru_list lru) | |||
386 | { | 404 | { |
387 | int i; | 405 | int i; |
388 | struct zone *zone = NULL; | 406 | struct zone *zone = NULL; |
407 | |||
389 | VM_BUG_ON(is_unevictable_lru(lru)); | 408 | VM_BUG_ON(is_unevictable_lru(lru)); |
390 | 409 | ||
391 | for (i = 0; i < pagevec_count(pvec); i++) { | 410 | for (i = 0; i < pagevec_count(pvec); i++) { |
392 | struct page *page = pvec->pages[i]; | 411 | struct page *page = pvec->pages[i]; |
393 | struct zone *pagezone = page_zone(page); | 412 | struct zone *pagezone = page_zone(page); |
394 | int file; | 413 | int file; |
414 | int active; | ||
395 | 415 | ||
396 | if (pagezone != zone) { | 416 | if (pagezone != zone) { |
397 | if (zone) | 417 | if (zone) |
@@ -403,12 +423,11 @@ void ____pagevec_lru_add(struct pagevec *pvec, enum lru_list lru) | |||
403 | VM_BUG_ON(PageUnevictable(page)); | 423 | VM_BUG_ON(PageUnevictable(page)); |
404 | VM_BUG_ON(PageLRU(page)); | 424 | VM_BUG_ON(PageLRU(page)); |
405 | SetPageLRU(page); | 425 | SetPageLRU(page); |
426 | active = is_active_lru(lru); | ||
406 | file = is_file_lru(lru); | 427 | file = is_file_lru(lru); |
407 | zone->recent_scanned[file]++; | 428 | if (active) |
408 | if (is_active_lru(lru)) { | ||
409 | SetPageActive(page); | 429 | SetPageActive(page); |
410 | zone->recent_rotated[file]++; | 430 | update_page_reclaim_stat(zone, page, file, active); |
411 | } | ||
412 | add_page_to_lru_list(zone, page, lru); | 431 | add_page_to_lru_list(zone, page, lru); |
413 | } | 432 | } |
414 | if (zone) | 433 | if (zone) |
diff --git a/mm/swap_state.c b/mm/swap_state.c index 81c825f67a7f..3ecea98ecb45 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c | |||
@@ -17,6 +17,7 @@ | |||
17 | #include <linux/backing-dev.h> | 17 | #include <linux/backing-dev.h> |
18 | #include <linux/pagevec.h> | 18 | #include <linux/pagevec.h> |
19 | #include <linux/migrate.h> | 19 | #include <linux/migrate.h> |
20 | #include <linux/page_cgroup.h> | ||
20 | 21 | ||
21 | #include <asm/pgtable.h> | 22 | #include <asm/pgtable.h> |
22 | 23 | ||
@@ -108,6 +109,8 @@ int add_to_swap_cache(struct page *page, swp_entry_t entry, gfp_t gfp_mask) | |||
108 | */ | 109 | */ |
109 | void __delete_from_swap_cache(struct page *page) | 110 | void __delete_from_swap_cache(struct page *page) |
110 | { | 111 | { |
112 | swp_entry_t ent = {.val = page_private(page)}; | ||
113 | |||
111 | VM_BUG_ON(!PageLocked(page)); | 114 | VM_BUG_ON(!PageLocked(page)); |
112 | VM_BUG_ON(!PageSwapCache(page)); | 115 | VM_BUG_ON(!PageSwapCache(page)); |
113 | VM_BUG_ON(PageWriteback(page)); | 116 | VM_BUG_ON(PageWriteback(page)); |
@@ -118,6 +121,7 @@ void __delete_from_swap_cache(struct page *page) | |||
118 | total_swapcache_pages--; | 121 | total_swapcache_pages--; |
119 | __dec_zone_page_state(page, NR_FILE_PAGES); | 122 | __dec_zone_page_state(page, NR_FILE_PAGES); |
120 | INC_CACHE_INFO(del_total); | 123 | INC_CACHE_INFO(del_total); |
124 | mem_cgroup_uncharge_swapcache(page, ent); | ||
121 | } | 125 | } |
122 | 126 | ||
123 | /** | 127 | /** |
diff --git a/mm/swapfile.c b/mm/swapfile.c index eec5ca758a23..da422c47e2ee 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c | |||
@@ -33,6 +33,7 @@ | |||
33 | #include <asm/pgtable.h> | 33 | #include <asm/pgtable.h> |
34 | #include <asm/tlbflush.h> | 34 | #include <asm/tlbflush.h> |
35 | #include <linux/swapops.h> | 35 | #include <linux/swapops.h> |
36 | #include <linux/page_cgroup.h> | ||
36 | 37 | ||
37 | static DEFINE_SPINLOCK(swap_lock); | 38 | static DEFINE_SPINLOCK(swap_lock); |
38 | static unsigned int nr_swapfiles; | 39 | static unsigned int nr_swapfiles; |
@@ -470,8 +471,9 @@ out: | |||
470 | return NULL; | 471 | return NULL; |
471 | } | 472 | } |
472 | 473 | ||
473 | static int swap_entry_free(struct swap_info_struct *p, unsigned long offset) | 474 | static int swap_entry_free(struct swap_info_struct *p, swp_entry_t ent) |
474 | { | 475 | { |
476 | unsigned long offset = swp_offset(ent); | ||
475 | int count = p->swap_map[offset]; | 477 | int count = p->swap_map[offset]; |
476 | 478 | ||
477 | if (count < SWAP_MAP_MAX) { | 479 | if (count < SWAP_MAP_MAX) { |
@@ -486,6 +488,7 @@ static int swap_entry_free(struct swap_info_struct *p, unsigned long offset) | |||
486 | swap_list.next = p - swap_info; | 488 | swap_list.next = p - swap_info; |
487 | nr_swap_pages++; | 489 | nr_swap_pages++; |
488 | p->inuse_pages--; | 490 | p->inuse_pages--; |
491 | mem_cgroup_uncharge_swap(ent); | ||
489 | } | 492 | } |
490 | } | 493 | } |
491 | return count; | 494 | return count; |
@@ -501,7 +504,7 @@ void swap_free(swp_entry_t entry) | |||
501 | 504 | ||
502 | p = swap_info_get(entry); | 505 | p = swap_info_get(entry); |
503 | if (p) { | 506 | if (p) { |
504 | swap_entry_free(p, swp_offset(entry)); | 507 | swap_entry_free(p, entry); |
505 | spin_unlock(&swap_lock); | 508 | spin_unlock(&swap_lock); |
506 | } | 509 | } |
507 | } | 510 | } |
@@ -581,7 +584,7 @@ int free_swap_and_cache(swp_entry_t entry) | |||
581 | 584 | ||
582 | p = swap_info_get(entry); | 585 | p = swap_info_get(entry); |
583 | if (p) { | 586 | if (p) { |
584 | if (swap_entry_free(p, swp_offset(entry)) == 1) { | 587 | if (swap_entry_free(p, entry) == 1) { |
585 | page = find_get_page(&swapper_space, entry.val); | 588 | page = find_get_page(&swapper_space, entry.val); |
586 | if (page && !trylock_page(page)) { | 589 | if (page && !trylock_page(page)) { |
587 | page_cache_release(page); | 590 | page_cache_release(page); |
@@ -690,17 +693,18 @@ unsigned int count_swap_pages(int type, int free) | |||
690 | static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, | 693 | static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, |
691 | unsigned long addr, swp_entry_t entry, struct page *page) | 694 | unsigned long addr, swp_entry_t entry, struct page *page) |
692 | { | 695 | { |
696 | struct mem_cgroup *ptr = NULL; | ||
693 | spinlock_t *ptl; | 697 | spinlock_t *ptl; |
694 | pte_t *pte; | 698 | pte_t *pte; |
695 | int ret = 1; | 699 | int ret = 1; |
696 | 700 | ||
697 | if (mem_cgroup_charge(page, vma->vm_mm, GFP_KERNEL)) | 701 | if (mem_cgroup_try_charge_swapin(vma->vm_mm, page, GFP_KERNEL, &ptr)) |
698 | ret = -ENOMEM; | 702 | ret = -ENOMEM; |
699 | 703 | ||
700 | pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); | 704 | pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); |
701 | if (unlikely(!pte_same(*pte, swp_entry_to_pte(entry)))) { | 705 | if (unlikely(!pte_same(*pte, swp_entry_to_pte(entry)))) { |
702 | if (ret > 0) | 706 | if (ret > 0) |
703 | mem_cgroup_uncharge_page(page); | 707 | mem_cgroup_cancel_charge_swapin(ptr); |
704 | ret = 0; | 708 | ret = 0; |
705 | goto out; | 709 | goto out; |
706 | } | 710 | } |
@@ -710,6 +714,7 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, | |||
710 | set_pte_at(vma->vm_mm, addr, pte, | 714 | set_pte_at(vma->vm_mm, addr, pte, |
711 | pte_mkold(mk_pte(page, vma->vm_page_prot))); | 715 | pte_mkold(mk_pte(page, vma->vm_page_prot))); |
712 | page_add_anon_rmap(page, vma, addr); | 716 | page_add_anon_rmap(page, vma, addr); |
717 | mem_cgroup_commit_charge_swapin(page, ptr); | ||
713 | swap_free(entry); | 718 | swap_free(entry); |
714 | /* | 719 | /* |
715 | * Move the page to the active list so it is not | 720 | * Move the page to the active list so it is not |
@@ -1492,6 +1497,9 @@ asmlinkage long sys_swapoff(const char __user * specialfile) | |||
1492 | spin_unlock(&swap_lock); | 1497 | spin_unlock(&swap_lock); |
1493 | mutex_unlock(&swapon_mutex); | 1498 | mutex_unlock(&swapon_mutex); |
1494 | vfree(swap_map); | 1499 | vfree(swap_map); |
1500 | /* Destroy swap account informatin */ | ||
1501 | swap_cgroup_swapoff(type); | ||
1502 | |||
1495 | inode = mapping->host; | 1503 | inode = mapping->host; |
1496 | if (S_ISBLK(inode->i_mode)) { | 1504 | if (S_ISBLK(inode->i_mode)) { |
1497 | struct block_device *bdev = I_BDEV(inode); | 1505 | struct block_device *bdev = I_BDEV(inode); |
@@ -1809,6 +1817,11 @@ asmlinkage long sys_swapon(const char __user * specialfile, int swap_flags) | |||
1809 | } | 1817 | } |
1810 | swap_map[page_nr] = SWAP_MAP_BAD; | 1818 | swap_map[page_nr] = SWAP_MAP_BAD; |
1811 | } | 1819 | } |
1820 | |||
1821 | error = swap_cgroup_swapon(type, maxpages); | ||
1822 | if (error) | ||
1823 | goto bad_swap; | ||
1824 | |||
1812 | nr_good_pages = swap_header->info.last_page - | 1825 | nr_good_pages = swap_header->info.last_page - |
1813 | swap_header->info.nr_badpages - | 1826 | swap_header->info.nr_badpages - |
1814 | 1 /* header page */; | 1827 | 1 /* header page */; |
@@ -1880,6 +1893,7 @@ bad_swap: | |||
1880 | bd_release(bdev); | 1893 | bd_release(bdev); |
1881 | } | 1894 | } |
1882 | destroy_swap_extents(p); | 1895 | destroy_swap_extents(p); |
1896 | swap_cgroup_swapoff(type); | ||
1883 | bad_swap_2: | 1897 | bad_swap_2: |
1884 | spin_lock(&swap_lock); | 1898 | spin_lock(&swap_lock); |
1885 | p->swap_file = NULL; | 1899 | p->swap_file = NULL; |
diff --git a/mm/vmscan.c b/mm/vmscan.c index b07c48b09a93..9a27c44aa327 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c | |||
@@ -125,11 +125,30 @@ static LIST_HEAD(shrinker_list); | |||
125 | static DECLARE_RWSEM(shrinker_rwsem); | 125 | static DECLARE_RWSEM(shrinker_rwsem); |
126 | 126 | ||
127 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR | 127 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR |
128 | #define scan_global_lru(sc) (!(sc)->mem_cgroup) | 128 | #define scanning_global_lru(sc) (!(sc)->mem_cgroup) |
129 | #else | 129 | #else |
130 | #define scan_global_lru(sc) (1) | 130 | #define scanning_global_lru(sc) (1) |
131 | #endif | 131 | #endif |
132 | 132 | ||
133 | static struct zone_reclaim_stat *get_reclaim_stat(struct zone *zone, | ||
134 | struct scan_control *sc) | ||
135 | { | ||
136 | if (!scanning_global_lru(sc)) | ||
137 | return mem_cgroup_get_reclaim_stat(sc->mem_cgroup, zone); | ||
138 | |||
139 | return &zone->reclaim_stat; | ||
140 | } | ||
141 | |||
142 | static unsigned long zone_nr_pages(struct zone *zone, struct scan_control *sc, | ||
143 | enum lru_list lru) | ||
144 | { | ||
145 | if (!scanning_global_lru(sc)) | ||
146 | return mem_cgroup_zone_nr_pages(sc->mem_cgroup, zone, lru); | ||
147 | |||
148 | return zone_page_state(zone, NR_LRU_BASE + lru); | ||
149 | } | ||
150 | |||
151 | |||
133 | /* | 152 | /* |
134 | * Add a shrinker callback to be called from the vm | 153 | * Add a shrinker callback to be called from the vm |
135 | */ | 154 | */ |
@@ -512,7 +531,6 @@ redo: | |||
512 | lru = LRU_UNEVICTABLE; | 531 | lru = LRU_UNEVICTABLE; |
513 | add_page_to_unevictable_list(page); | 532 | add_page_to_unevictable_list(page); |
514 | } | 533 | } |
515 | mem_cgroup_move_lists(page, lru); | ||
516 | 534 | ||
517 | /* | 535 | /* |
518 | * page's status can change while we move it among lru. If an evictable | 536 | * page's status can change while we move it among lru. If an evictable |
@@ -547,7 +565,6 @@ void putback_lru_page(struct page *page) | |||
547 | 565 | ||
548 | lru = !!TestClearPageActive(page) + page_is_file_cache(page); | 566 | lru = !!TestClearPageActive(page) + page_is_file_cache(page); |
549 | lru_cache_add_lru(page, lru); | 567 | lru_cache_add_lru(page, lru); |
550 | mem_cgroup_move_lists(page, lru); | ||
551 | put_page(page); | 568 | put_page(page); |
552 | } | 569 | } |
553 | #endif /* CONFIG_UNEVICTABLE_LRU */ | 570 | #endif /* CONFIG_UNEVICTABLE_LRU */ |
@@ -813,6 +830,7 @@ int __isolate_lru_page(struct page *page, int mode, int file) | |||
813 | return ret; | 830 | return ret; |
814 | 831 | ||
815 | ret = -EBUSY; | 832 | ret = -EBUSY; |
833 | |||
816 | if (likely(get_page_unless_zero(page))) { | 834 | if (likely(get_page_unless_zero(page))) { |
817 | /* | 835 | /* |
818 | * Be careful not to clear PageLRU until after we're | 836 | * Be careful not to clear PageLRU until after we're |
@@ -821,6 +839,7 @@ int __isolate_lru_page(struct page *page, int mode, int file) | |||
821 | */ | 839 | */ |
822 | ClearPageLRU(page); | 840 | ClearPageLRU(page); |
823 | ret = 0; | 841 | ret = 0; |
842 | mem_cgroup_del_lru(page); | ||
824 | } | 843 | } |
825 | 844 | ||
826 | return ret; | 845 | return ret; |
@@ -1029,6 +1048,7 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, | |||
1029 | struct pagevec pvec; | 1048 | struct pagevec pvec; |
1030 | unsigned long nr_scanned = 0; | 1049 | unsigned long nr_scanned = 0; |
1031 | unsigned long nr_reclaimed = 0; | 1050 | unsigned long nr_reclaimed = 0; |
1051 | struct zone_reclaim_stat *reclaim_stat = get_reclaim_stat(zone, sc); | ||
1032 | 1052 | ||
1033 | pagevec_init(&pvec, 1); | 1053 | pagevec_init(&pvec, 1); |
1034 | 1054 | ||
@@ -1070,13 +1090,14 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, | |||
1070 | __mod_zone_page_state(zone, NR_INACTIVE_ANON, | 1090 | __mod_zone_page_state(zone, NR_INACTIVE_ANON, |
1071 | -count[LRU_INACTIVE_ANON]); | 1091 | -count[LRU_INACTIVE_ANON]); |
1072 | 1092 | ||
1073 | if (scan_global_lru(sc)) { | 1093 | if (scanning_global_lru(sc)) |
1074 | zone->pages_scanned += nr_scan; | 1094 | zone->pages_scanned += nr_scan; |
1075 | zone->recent_scanned[0] += count[LRU_INACTIVE_ANON]; | 1095 | |
1076 | zone->recent_scanned[0] += count[LRU_ACTIVE_ANON]; | 1096 | reclaim_stat->recent_scanned[0] += count[LRU_INACTIVE_ANON]; |
1077 | zone->recent_scanned[1] += count[LRU_INACTIVE_FILE]; | 1097 | reclaim_stat->recent_scanned[0] += count[LRU_ACTIVE_ANON]; |
1078 | zone->recent_scanned[1] += count[LRU_ACTIVE_FILE]; | 1098 | reclaim_stat->recent_scanned[1] += count[LRU_INACTIVE_FILE]; |
1079 | } | 1099 | reclaim_stat->recent_scanned[1] += count[LRU_ACTIVE_FILE]; |
1100 | |||
1080 | spin_unlock_irq(&zone->lru_lock); | 1101 | spin_unlock_irq(&zone->lru_lock); |
1081 | 1102 | ||
1082 | nr_scanned += nr_scan; | 1103 | nr_scanned += nr_scan; |
@@ -1108,7 +1129,7 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, | |||
1108 | if (current_is_kswapd()) { | 1129 | if (current_is_kswapd()) { |
1109 | __count_zone_vm_events(PGSCAN_KSWAPD, zone, nr_scan); | 1130 | __count_zone_vm_events(PGSCAN_KSWAPD, zone, nr_scan); |
1110 | __count_vm_events(KSWAPD_STEAL, nr_freed); | 1131 | __count_vm_events(KSWAPD_STEAL, nr_freed); |
1111 | } else if (scan_global_lru(sc)) | 1132 | } else if (scanning_global_lru(sc)) |
1112 | __count_zone_vm_events(PGSCAN_DIRECT, zone, nr_scan); | 1133 | __count_zone_vm_events(PGSCAN_DIRECT, zone, nr_scan); |
1113 | 1134 | ||
1114 | __count_zone_vm_events(PGSTEAL, zone, nr_freed); | 1135 | __count_zone_vm_events(PGSTEAL, zone, nr_freed); |
@@ -1134,10 +1155,9 @@ static unsigned long shrink_inactive_list(unsigned long max_scan, | |||
1134 | SetPageLRU(page); | 1155 | SetPageLRU(page); |
1135 | lru = page_lru(page); | 1156 | lru = page_lru(page); |
1136 | add_page_to_lru_list(zone, page, lru); | 1157 | add_page_to_lru_list(zone, page, lru); |
1137 | mem_cgroup_move_lists(page, lru); | 1158 | if (PageActive(page)) { |
1138 | if (PageActive(page) && scan_global_lru(sc)) { | ||
1139 | int file = !!page_is_file_cache(page); | 1159 | int file = !!page_is_file_cache(page); |
1140 | zone->recent_rotated[file]++; | 1160 | reclaim_stat->recent_rotated[file]++; |
1141 | } | 1161 | } |
1142 | if (!pagevec_add(&pvec, page)) { | 1162 | if (!pagevec_add(&pvec, page)) { |
1143 | spin_unlock_irq(&zone->lru_lock); | 1163 | spin_unlock_irq(&zone->lru_lock); |
@@ -1197,6 +1217,7 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone, | |||
1197 | struct page *page; | 1217 | struct page *page; |
1198 | struct pagevec pvec; | 1218 | struct pagevec pvec; |
1199 | enum lru_list lru; | 1219 | enum lru_list lru; |
1220 | struct zone_reclaim_stat *reclaim_stat = get_reclaim_stat(zone, sc); | ||
1200 | 1221 | ||
1201 | lru_add_drain(); | 1222 | lru_add_drain(); |
1202 | spin_lock_irq(&zone->lru_lock); | 1223 | spin_lock_irq(&zone->lru_lock); |
@@ -1207,10 +1228,10 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone, | |||
1207 | * zone->pages_scanned is used for detect zone's oom | 1228 | * zone->pages_scanned is used for detect zone's oom |
1208 | * mem_cgroup remembers nr_scan by itself. | 1229 | * mem_cgroup remembers nr_scan by itself. |
1209 | */ | 1230 | */ |
1210 | if (scan_global_lru(sc)) { | 1231 | if (scanning_global_lru(sc)) { |
1211 | zone->pages_scanned += pgscanned; | 1232 | zone->pages_scanned += pgscanned; |
1212 | zone->recent_scanned[!!file] += pgmoved; | ||
1213 | } | 1233 | } |
1234 | reclaim_stat->recent_scanned[!!file] += pgmoved; | ||
1214 | 1235 | ||
1215 | if (file) | 1236 | if (file) |
1216 | __mod_zone_page_state(zone, NR_ACTIVE_FILE, -pgmoved); | 1237 | __mod_zone_page_state(zone, NR_ACTIVE_FILE, -pgmoved); |
@@ -1251,8 +1272,7 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone, | |||
1251 | * This helps balance scan pressure between file and anonymous | 1272 | * This helps balance scan pressure between file and anonymous |
1252 | * pages in get_scan_ratio. | 1273 | * pages in get_scan_ratio. |
1253 | */ | 1274 | */ |
1254 | if (scan_global_lru(sc)) | 1275 | reclaim_stat->recent_rotated[!!file] += pgmoved; |
1255 | zone->recent_rotated[!!file] += pgmoved; | ||
1256 | 1276 | ||
1257 | while (!list_empty(&l_inactive)) { | 1277 | while (!list_empty(&l_inactive)) { |
1258 | page = lru_to_page(&l_inactive); | 1278 | page = lru_to_page(&l_inactive); |
@@ -1263,7 +1283,7 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone, | |||
1263 | ClearPageActive(page); | 1283 | ClearPageActive(page); |
1264 | 1284 | ||
1265 | list_move(&page->lru, &zone->lru[lru].list); | 1285 | list_move(&page->lru, &zone->lru[lru].list); |
1266 | mem_cgroup_move_lists(page, lru); | 1286 | mem_cgroup_add_lru_list(page, lru); |
1267 | pgmoved++; | 1287 | pgmoved++; |
1268 | if (!pagevec_add(&pvec, page)) { | 1288 | if (!pagevec_add(&pvec, page)) { |
1269 | __mod_zone_page_state(zone, NR_LRU_BASE + lru, pgmoved); | 1289 | __mod_zone_page_state(zone, NR_LRU_BASE + lru, pgmoved); |
@@ -1292,6 +1312,38 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone, | |||
1292 | pagevec_release(&pvec); | 1312 | pagevec_release(&pvec); |
1293 | } | 1313 | } |
1294 | 1314 | ||
1315 | static int inactive_anon_is_low_global(struct zone *zone) | ||
1316 | { | ||
1317 | unsigned long active, inactive; | ||
1318 | |||
1319 | active = zone_page_state(zone, NR_ACTIVE_ANON); | ||
1320 | inactive = zone_page_state(zone, NR_INACTIVE_ANON); | ||
1321 | |||
1322 | if (inactive * zone->inactive_ratio < active) | ||
1323 | return 1; | ||
1324 | |||
1325 | return 0; | ||
1326 | } | ||
1327 | |||
1328 | /** | ||
1329 | * inactive_anon_is_low - check if anonymous pages need to be deactivated | ||
1330 | * @zone: zone to check | ||
1331 | * @sc: scan control of this context | ||
1332 | * | ||
1333 | * Returns true if the zone does not have enough inactive anon pages, | ||
1334 | * meaning some active anon pages need to be deactivated. | ||
1335 | */ | ||
1336 | static int inactive_anon_is_low(struct zone *zone, struct scan_control *sc) | ||
1337 | { | ||
1338 | int low; | ||
1339 | |||
1340 | if (scanning_global_lru(sc)) | ||
1341 | low = inactive_anon_is_low_global(zone); | ||
1342 | else | ||
1343 | low = mem_cgroup_inactive_anon_is_low(sc->mem_cgroup); | ||
1344 | return low; | ||
1345 | } | ||
1346 | |||
1295 | static unsigned long shrink_list(enum lru_list lru, unsigned long nr_to_scan, | 1347 | static unsigned long shrink_list(enum lru_list lru, unsigned long nr_to_scan, |
1296 | struct zone *zone, struct scan_control *sc, int priority) | 1348 | struct zone *zone, struct scan_control *sc, int priority) |
1297 | { | 1349 | { |
@@ -1302,8 +1354,7 @@ static unsigned long shrink_list(enum lru_list lru, unsigned long nr_to_scan, | |||
1302 | return 0; | 1354 | return 0; |
1303 | } | 1355 | } |
1304 | 1356 | ||
1305 | if (lru == LRU_ACTIVE_ANON && | 1357 | if (lru == LRU_ACTIVE_ANON && inactive_anon_is_low(zone, sc)) { |
1306 | (!scan_global_lru(sc) || inactive_anon_is_low(zone))) { | ||
1307 | shrink_active_list(nr_to_scan, zone, sc, priority, file); | 1358 | shrink_active_list(nr_to_scan, zone, sc, priority, file); |
1308 | return 0; | 1359 | return 0; |
1309 | } | 1360 | } |
@@ -1325,6 +1376,7 @@ static void get_scan_ratio(struct zone *zone, struct scan_control *sc, | |||
1325 | unsigned long anon, file, free; | 1376 | unsigned long anon, file, free; |
1326 | unsigned long anon_prio, file_prio; | 1377 | unsigned long anon_prio, file_prio; |
1327 | unsigned long ap, fp; | 1378 | unsigned long ap, fp; |
1379 | struct zone_reclaim_stat *reclaim_stat = get_reclaim_stat(zone, sc); | ||
1328 | 1380 | ||
1329 | /* If we have no swap space, do not bother scanning anon pages. */ | 1381 | /* If we have no swap space, do not bother scanning anon pages. */ |
1330 | if (nr_swap_pages <= 0) { | 1382 | if (nr_swap_pages <= 0) { |
@@ -1333,17 +1385,20 @@ static void get_scan_ratio(struct zone *zone, struct scan_control *sc, | |||
1333 | return; | 1385 | return; |
1334 | } | 1386 | } |
1335 | 1387 | ||
1336 | anon = zone_page_state(zone, NR_ACTIVE_ANON) + | 1388 | anon = zone_nr_pages(zone, sc, LRU_ACTIVE_ANON) + |
1337 | zone_page_state(zone, NR_INACTIVE_ANON); | 1389 | zone_nr_pages(zone, sc, LRU_INACTIVE_ANON); |
1338 | file = zone_page_state(zone, NR_ACTIVE_FILE) + | 1390 | file = zone_nr_pages(zone, sc, LRU_ACTIVE_FILE) + |
1339 | zone_page_state(zone, NR_INACTIVE_FILE); | 1391 | zone_nr_pages(zone, sc, LRU_INACTIVE_FILE); |
1340 | free = zone_page_state(zone, NR_FREE_PAGES); | 1392 | |
1341 | 1393 | if (scanning_global_lru(sc)) { | |
1342 | /* If we have very few page cache pages, force-scan anon pages. */ | 1394 | free = zone_page_state(zone, NR_FREE_PAGES); |
1343 | if (unlikely(file + free <= zone->pages_high)) { | 1395 | /* If we have very few page cache pages, |
1344 | percent[0] = 100; | 1396 | force-scan anon pages. */ |
1345 | percent[1] = 0; | 1397 | if (unlikely(file + free <= zone->pages_high)) { |
1346 | return; | 1398 | percent[0] = 100; |
1399 | percent[1] = 0; | ||
1400 | return; | ||
1401 | } | ||
1347 | } | 1402 | } |
1348 | 1403 | ||
1349 | /* | 1404 | /* |
@@ -1357,17 +1412,17 @@ static void get_scan_ratio(struct zone *zone, struct scan_control *sc, | |||
1357 | * | 1412 | * |
1358 | * anon in [0], file in [1] | 1413 | * anon in [0], file in [1] |
1359 | */ | 1414 | */ |
1360 | if (unlikely(zone->recent_scanned[0] > anon / 4)) { | 1415 | if (unlikely(reclaim_stat->recent_scanned[0] > anon / 4)) { |
1361 | spin_lock_irq(&zone->lru_lock); | 1416 | spin_lock_irq(&zone->lru_lock); |
1362 | zone->recent_scanned[0] /= 2; | 1417 | reclaim_stat->recent_scanned[0] /= 2; |
1363 | zone->recent_rotated[0] /= 2; | 1418 | reclaim_stat->recent_rotated[0] /= 2; |
1364 | spin_unlock_irq(&zone->lru_lock); | 1419 | spin_unlock_irq(&zone->lru_lock); |
1365 | } | 1420 | } |
1366 | 1421 | ||
1367 | if (unlikely(zone->recent_scanned[1] > file / 4)) { | 1422 | if (unlikely(reclaim_stat->recent_scanned[1] > file / 4)) { |
1368 | spin_lock_irq(&zone->lru_lock); | 1423 | spin_lock_irq(&zone->lru_lock); |
1369 | zone->recent_scanned[1] /= 2; | 1424 | reclaim_stat->recent_scanned[1] /= 2; |
1370 | zone->recent_rotated[1] /= 2; | 1425 | reclaim_stat->recent_rotated[1] /= 2; |
1371 | spin_unlock_irq(&zone->lru_lock); | 1426 | spin_unlock_irq(&zone->lru_lock); |
1372 | } | 1427 | } |
1373 | 1428 | ||
@@ -1383,11 +1438,11 @@ static void get_scan_ratio(struct zone *zone, struct scan_control *sc, | |||
1383 | * proportional to the fraction of recently scanned pages on | 1438 | * proportional to the fraction of recently scanned pages on |
1384 | * each list that were recently referenced and in active use. | 1439 | * each list that were recently referenced and in active use. |
1385 | */ | 1440 | */ |
1386 | ap = (anon_prio + 1) * (zone->recent_scanned[0] + 1); | 1441 | ap = (anon_prio + 1) * (reclaim_stat->recent_scanned[0] + 1); |
1387 | ap /= zone->recent_rotated[0] + 1; | 1442 | ap /= reclaim_stat->recent_rotated[0] + 1; |
1388 | 1443 | ||
1389 | fp = (file_prio + 1) * (zone->recent_scanned[1] + 1); | 1444 | fp = (file_prio + 1) * (reclaim_stat->recent_scanned[1] + 1); |
1390 | fp /= zone->recent_rotated[1] + 1; | 1445 | fp /= reclaim_stat->recent_rotated[1] + 1; |
1391 | 1446 | ||
1392 | /* Normalize to percentages */ | 1447 | /* Normalize to percentages */ |
1393 | percent[0] = 100 * ap / (ap + fp + 1); | 1448 | percent[0] = 100 * ap / (ap + fp + 1); |
@@ -1411,30 +1466,23 @@ static void shrink_zone(int priority, struct zone *zone, | |||
1411 | get_scan_ratio(zone, sc, percent); | 1466 | get_scan_ratio(zone, sc, percent); |
1412 | 1467 | ||
1413 | for_each_evictable_lru(l) { | 1468 | for_each_evictable_lru(l) { |
1414 | if (scan_global_lru(sc)) { | 1469 | int file = is_file_lru(l); |
1415 | int file = is_file_lru(l); | 1470 | int scan; |
1416 | int scan; | 1471 | |
1417 | 1472 | scan = zone_page_state(zone, NR_LRU_BASE + l); | |
1418 | scan = zone_page_state(zone, NR_LRU_BASE + l); | 1473 | if (priority) { |
1419 | if (priority) { | 1474 | scan >>= priority; |
1420 | scan >>= priority; | 1475 | scan = (scan * percent[file]) / 100; |
1421 | scan = (scan * percent[file]) / 100; | 1476 | } |
1422 | } | 1477 | if (scanning_global_lru(sc)) { |
1423 | zone->lru[l].nr_scan += scan; | 1478 | zone->lru[l].nr_scan += scan; |
1424 | nr[l] = zone->lru[l].nr_scan; | 1479 | nr[l] = zone->lru[l].nr_scan; |
1425 | if (nr[l] >= swap_cluster_max) | 1480 | if (nr[l] >= swap_cluster_max) |
1426 | zone->lru[l].nr_scan = 0; | 1481 | zone->lru[l].nr_scan = 0; |
1427 | else | 1482 | else |
1428 | nr[l] = 0; | 1483 | nr[l] = 0; |
1429 | } else { | 1484 | } else |
1430 | /* | 1485 | nr[l] = scan; |
1431 | * This reclaim occurs not because zone memory shortage | ||
1432 | * but because memory controller hits its limit. | ||
1433 | * Don't modify zone reclaim related data. | ||
1434 | */ | ||
1435 | nr[l] = mem_cgroup_calc_reclaim(sc->mem_cgroup, zone, | ||
1436 | priority, l); | ||
1437 | } | ||
1438 | } | 1486 | } |
1439 | 1487 | ||
1440 | while (nr[LRU_INACTIVE_ANON] || nr[LRU_ACTIVE_FILE] || | 1488 | while (nr[LRU_INACTIVE_ANON] || nr[LRU_ACTIVE_FILE] || |
@@ -1467,9 +1515,7 @@ static void shrink_zone(int priority, struct zone *zone, | |||
1467 | * Even if we did not try to evict anon pages at all, we want to | 1515 | * Even if we did not try to evict anon pages at all, we want to |
1468 | * rebalance the anon lru active/inactive ratio. | 1516 | * rebalance the anon lru active/inactive ratio. |
1469 | */ | 1517 | */ |
1470 | if (!scan_global_lru(sc) || inactive_anon_is_low(zone)) | 1518 | if (inactive_anon_is_low(zone, sc)) |
1471 | shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); | ||
1472 | else if (!scan_global_lru(sc)) | ||
1473 | shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); | 1519 | shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); |
1474 | 1520 | ||
1475 | throttle_vm_writeout(sc->gfp_mask); | 1521 | throttle_vm_writeout(sc->gfp_mask); |
@@ -1504,7 +1550,7 @@ static void shrink_zones(int priority, struct zonelist *zonelist, | |||
1504 | * Take care memory controller reclaiming has small influence | 1550 | * Take care memory controller reclaiming has small influence |
1505 | * to global LRU. | 1551 | * to global LRU. |
1506 | */ | 1552 | */ |
1507 | if (scan_global_lru(sc)) { | 1553 | if (scanning_global_lru(sc)) { |
1508 | if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) | 1554 | if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) |
1509 | continue; | 1555 | continue; |
1510 | note_zone_scanning_priority(zone, priority); | 1556 | note_zone_scanning_priority(zone, priority); |
@@ -1557,12 +1603,12 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, | |||
1557 | 1603 | ||
1558 | delayacct_freepages_start(); | 1604 | delayacct_freepages_start(); |
1559 | 1605 | ||
1560 | if (scan_global_lru(sc)) | 1606 | if (scanning_global_lru(sc)) |
1561 | count_vm_event(ALLOCSTALL); | 1607 | count_vm_event(ALLOCSTALL); |
1562 | /* | 1608 | /* |
1563 | * mem_cgroup will not do shrink_slab. | 1609 | * mem_cgroup will not do shrink_slab. |
1564 | */ | 1610 | */ |
1565 | if (scan_global_lru(sc)) { | 1611 | if (scanning_global_lru(sc)) { |
1566 | for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) { | 1612 | for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) { |
1567 | 1613 | ||
1568 | if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) | 1614 | if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) |
@@ -1581,7 +1627,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, | |||
1581 | * Don't shrink slabs when reclaiming memory from | 1627 | * Don't shrink slabs when reclaiming memory from |
1582 | * over limit cgroups | 1628 | * over limit cgroups |
1583 | */ | 1629 | */ |
1584 | if (scan_global_lru(sc)) { | 1630 | if (scanning_global_lru(sc)) { |
1585 | shrink_slab(sc->nr_scanned, sc->gfp_mask, lru_pages); | 1631 | shrink_slab(sc->nr_scanned, sc->gfp_mask, lru_pages); |
1586 | if (reclaim_state) { | 1632 | if (reclaim_state) { |
1587 | sc->nr_reclaimed += reclaim_state->reclaimed_slab; | 1633 | sc->nr_reclaimed += reclaim_state->reclaimed_slab; |
@@ -1612,7 +1658,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, | |||
1612 | congestion_wait(WRITE, HZ/10); | 1658 | congestion_wait(WRITE, HZ/10); |
1613 | } | 1659 | } |
1614 | /* top priority shrink_zones still had more to do? don't OOM, then */ | 1660 | /* top priority shrink_zones still had more to do? don't OOM, then */ |
1615 | if (!sc->all_unreclaimable && scan_global_lru(sc)) | 1661 | if (!sc->all_unreclaimable && scanning_global_lru(sc)) |
1616 | ret = sc->nr_reclaimed; | 1662 | ret = sc->nr_reclaimed; |
1617 | out: | 1663 | out: |
1618 | /* | 1664 | /* |
@@ -1625,7 +1671,7 @@ out: | |||
1625 | if (priority < 0) | 1671 | if (priority < 0) |
1626 | priority = 0; | 1672 | priority = 0; |
1627 | 1673 | ||
1628 | if (scan_global_lru(sc)) { | 1674 | if (scanning_global_lru(sc)) { |
1629 | for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) { | 1675 | for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) { |
1630 | 1676 | ||
1631 | if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) | 1677 | if (!cpuset_zone_allowed_hardwall(zone, GFP_KERNEL)) |
@@ -1661,19 +1707,24 @@ unsigned long try_to_free_pages(struct zonelist *zonelist, int order, | |||
1661 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR | 1707 | #ifdef CONFIG_CGROUP_MEM_RES_CTLR |
1662 | 1708 | ||
1663 | unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *mem_cont, | 1709 | unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *mem_cont, |
1664 | gfp_t gfp_mask) | 1710 | gfp_t gfp_mask, |
1711 | bool noswap, | ||
1712 | unsigned int swappiness) | ||
1665 | { | 1713 | { |
1666 | struct scan_control sc = { | 1714 | struct scan_control sc = { |
1667 | .may_writepage = !laptop_mode, | 1715 | .may_writepage = !laptop_mode, |
1668 | .may_swap = 1, | 1716 | .may_swap = 1, |
1669 | .swap_cluster_max = SWAP_CLUSTER_MAX, | 1717 | .swap_cluster_max = SWAP_CLUSTER_MAX, |
1670 | .swappiness = vm_swappiness, | 1718 | .swappiness = swappiness, |
1671 | .order = 0, | 1719 | .order = 0, |
1672 | .mem_cgroup = mem_cont, | 1720 | .mem_cgroup = mem_cont, |
1673 | .isolate_pages = mem_cgroup_isolate_pages, | 1721 | .isolate_pages = mem_cgroup_isolate_pages, |
1674 | }; | 1722 | }; |
1675 | struct zonelist *zonelist; | 1723 | struct zonelist *zonelist; |
1676 | 1724 | ||
1725 | if (noswap) | ||
1726 | sc.may_swap = 0; | ||
1727 | |||
1677 | sc.gfp_mask = (gfp_mask & GFP_RECLAIM_MASK) | | 1728 | sc.gfp_mask = (gfp_mask & GFP_RECLAIM_MASK) | |
1678 | (GFP_HIGHUSER_MOVABLE & ~GFP_RECLAIM_MASK); | 1729 | (GFP_HIGHUSER_MOVABLE & ~GFP_RECLAIM_MASK); |
1679 | zonelist = NODE_DATA(numa_node_id())->node_zonelists; | 1730 | zonelist = NODE_DATA(numa_node_id())->node_zonelists; |
@@ -1761,7 +1812,7 @@ loop_again: | |||
1761 | * Do some background aging of the anon list, to give | 1812 | * Do some background aging of the anon list, to give |
1762 | * pages a chance to be referenced before reclaiming. | 1813 | * pages a chance to be referenced before reclaiming. |
1763 | */ | 1814 | */ |
1764 | if (inactive_anon_is_low(zone)) | 1815 | if (inactive_anon_is_low(zone, &sc)) |
1765 | shrink_active_list(SWAP_CLUSTER_MAX, zone, | 1816 | shrink_active_list(SWAP_CLUSTER_MAX, zone, |
1766 | &sc, priority, 0); | 1817 | &sc, priority, 0); |
1767 | 1818 | ||
@@ -2404,6 +2455,7 @@ retry: | |||
2404 | 2455 | ||
2405 | __dec_zone_state(zone, NR_UNEVICTABLE); | 2456 | __dec_zone_state(zone, NR_UNEVICTABLE); |
2406 | list_move(&page->lru, &zone->lru[l].list); | 2457 | list_move(&page->lru, &zone->lru[l].list); |
2458 | mem_cgroup_move_lists(page, LRU_UNEVICTABLE, l); | ||
2407 | __inc_zone_state(zone, NR_INACTIVE_ANON + l); | 2459 | __inc_zone_state(zone, NR_INACTIVE_ANON + l); |
2408 | __count_vm_event(UNEVICTABLE_PGRESCUED); | 2460 | __count_vm_event(UNEVICTABLE_PGRESCUED); |
2409 | } else { | 2461 | } else { |
@@ -2412,6 +2464,7 @@ retry: | |||
2412 | */ | 2464 | */ |
2413 | SetPageUnevictable(page); | 2465 | SetPageUnevictable(page); |
2414 | list_move(&page->lru, &zone->lru[LRU_UNEVICTABLE].list); | 2466 | list_move(&page->lru, &zone->lru[LRU_UNEVICTABLE].list); |
2467 | mem_cgroup_rotate_lru_list(page, LRU_UNEVICTABLE); | ||
2415 | if (page_evictable(page, NULL)) | 2468 | if (page_evictable(page, NULL)) |
2416 | goto retry; | 2469 | goto retry; |
2417 | } | 2470 | } |
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 76f06b94ab9f..c4a59824ac2c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c | |||
@@ -2752,7 +2752,7 @@ int __init ip6_route_init(void) | |||
2752 | kmem_cache_create("ip6_dst_cache", sizeof(struct rt6_info), 0, | 2752 | kmem_cache_create("ip6_dst_cache", sizeof(struct rt6_info), 0, |
2753 | SLAB_HWCACHE_ALIGN, NULL); | 2753 | SLAB_HWCACHE_ALIGN, NULL); |
2754 | if (!ip6_dst_ops_template.kmem_cachep) | 2754 | if (!ip6_dst_ops_template.kmem_cachep) |
2755 | goto out;; | 2755 | goto out; |
2756 | 2756 | ||
2757 | ret = register_pernet_subsys(&ip6_route_net_ops); | 2757 | ret = register_pernet_subsys(&ip6_route_net_ops); |
2758 | if (ret) | 2758 | if (ret) |
diff --git a/net/ipv6/sysctl_net_ipv6.c b/net/ipv6/sysctl_net_ipv6.c index 9048fe7e7ea7..a031034720b4 100644 --- a/net/ipv6/sysctl_net_ipv6.c +++ b/net/ipv6/sysctl_net_ipv6.c | |||
@@ -128,7 +128,7 @@ static struct ctl_table_header *ip6_header; | |||
128 | 128 | ||
129 | int ipv6_sysctl_register(void) | 129 | int ipv6_sysctl_register(void) |
130 | { | 130 | { |
131 | int err = -ENOMEM;; | 131 | int err = -ENOMEM; |
132 | 132 | ||
133 | ip6_header = register_net_sysctl_rotable(net_ipv6_ctl_path, ipv6_table); | 133 | ip6_header = register_net_sysctl_rotable(net_ipv6_ctl_path, ipv6_table); |
134 | if (ip6_header == NULL) | 134 | if (ip6_header == NULL) |
diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c index f3965df00559..33133d27b539 100644 --- a/net/sched/sch_sfq.c +++ b/net/sched/sch_sfq.c | |||
@@ -435,7 +435,7 @@ static int sfq_init(struct Qdisc *sch, struct nlattr *opt) | |||
435 | int i; | 435 | int i; |
436 | 436 | ||
437 | q->perturb_timer.function = sfq_perturbation; | 437 | q->perturb_timer.function = sfq_perturbation; |
438 | q->perturb_timer.data = (unsigned long)sch;; | 438 | q->perturb_timer.data = (unsigned long)sch; |
439 | init_timer_deferrable(&q->perturb_timer); | 439 | init_timer_deferrable(&q->perturb_timer); |
440 | 440 | ||
441 | for (i = 0; i < SFQ_HASH_DIVISOR; i++) | 441 | for (i = 0; i < SFQ_HASH_DIVISOR; i++) |
diff --git a/net/sctp/auth.c b/net/sctp/auth.c index 20c576f530fa..56935bbc1496 100644 --- a/net/sctp/auth.c +++ b/net/sctp/auth.c | |||
@@ -489,7 +489,7 @@ int sctp_auth_init_hmacs(struct sctp_endpoint *ep, gfp_t gfp) | |||
489 | return 0; | 489 | return 0; |
490 | 490 | ||
491 | out_err: | 491 | out_err: |
492 | /* Clean up any successfull allocations */ | 492 | /* Clean up any successful allocations */ |
493 | sctp_auth_destroy_hmacs(ep->auth_hmacs); | 493 | sctp_auth_destroy_hmacs(ep->auth_hmacs); |
494 | return -ENOMEM; | 494 | return -ENOMEM; |
495 | } | 495 | } |
diff --git a/security/device_cgroup.c b/security/device_cgroup.c index 5ba78701adc3..3aacd0fe7179 100644 --- a/security/device_cgroup.c +++ b/security/device_cgroup.c | |||
@@ -513,11 +513,14 @@ int devcgroup_inode_mknod(int mode, dev_t dev) | |||
513 | struct dev_cgroup *dev_cgroup; | 513 | struct dev_cgroup *dev_cgroup; |
514 | struct dev_whitelist_item *wh; | 514 | struct dev_whitelist_item *wh; |
515 | 515 | ||
516 | if (!S_ISBLK(mode) && !S_ISCHR(mode)) | ||
517 | return 0; | ||
518 | |||
516 | rcu_read_lock(); | 519 | rcu_read_lock(); |
517 | 520 | ||
518 | dev_cgroup = task_devcgroup(current); | 521 | dev_cgroup = task_devcgroup(current); |
519 | 522 | ||
520 | list_for_each_entry(wh, &dev_cgroup->whitelist, list) { | 523 | list_for_each_entry_rcu(wh, &dev_cgroup->whitelist, list) { |
521 | if (wh->type & DEV_ALL) | 524 | if (wh->type & DEV_ALL) |
522 | goto acc_check; | 525 | goto acc_check; |
523 | if ((wh->type & DEV_BLOCK) && !S_ISBLK(mode)) | 526 | if ((wh->type & DEV_BLOCK) && !S_ISBLK(mode)) |
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index bf107a389ac1..71e2b914363e 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c | |||
@@ -569,7 +569,7 @@ static ssize_t smk_write_cipso(struct file *file, const char __user *buf, | |||
569 | if (skp == NULL) | 569 | if (skp == NULL) |
570 | goto out; | 570 | goto out; |
571 | 571 | ||
572 | rule += SMK_LABELLEN;; | 572 | rule += SMK_LABELLEN; |
573 | ret = sscanf(rule, "%d", &maplevel); | 573 | ret = sscanf(rule, "%d", &maplevel); |
574 | if (ret != 1 || maplevel > SMACK_CIPSO_MAXLEVEL) | 574 | if (ret != 1 || maplevel > SMACK_CIPSO_MAXLEVEL) |
575 | goto out; | 575 | goto out; |
diff --git a/sound/soc/au1x/dbdma2.c b/sound/soc/au1x/dbdma2.c index 74c823d60f91..bc8d654576c0 100644 --- a/sound/soc/au1x/dbdma2.c +++ b/sound/soc/au1x/dbdma2.c | |||
@@ -187,7 +187,7 @@ static int au1x_pcm_dbdma_realloc(struct au1xpsc_audio_dmadata *pcd, | |||
187 | au1x_pcm_dmatx_cb, (void *)pcd); | 187 | au1x_pcm_dmatx_cb, (void *)pcd); |
188 | 188 | ||
189 | if (!pcd->ddma_chan) | 189 | if (!pcd->ddma_chan) |
190 | return -ENOMEM;; | 190 | return -ENOMEM; |
191 | 191 | ||
192 | au1xxx_dbdma_set_devwidth(pcd->ddma_chan, msbits); | 192 | au1xxx_dbdma_set_devwidth(pcd->ddma_chan, msbits); |
193 | au1xxx_dbdma_ring_alloc(pcd->ddma_chan, 2); | 193 | au1xxx_dbdma_ring_alloc(pcd->ddma_chan, 2); |
diff --git a/sound/soc/davinci/davinci-pcm.c b/sound/soc/davinci/davinci-pcm.c index 74abc9b4f1cc..366049d8578c 100644 --- a/sound/soc/davinci/davinci-pcm.c +++ b/sound/soc/davinci/davinci-pcm.c | |||
@@ -212,7 +212,7 @@ davinci_pcm_pointer(struct snd_pcm_substream *substream) | |||
212 | if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) | 212 | if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) |
213 | count = src - runtime->dma_addr; | 213 | count = src - runtime->dma_addr; |
214 | else | 214 | else |
215 | count = dst - runtime->dma_addr;; | 215 | count = dst - runtime->dma_addr; |
216 | 216 | ||
217 | spin_unlock(&prtd->lock); | 217 | spin_unlock(&prtd->lock); |
218 | 218 | ||