diff options
41 files changed, 484 insertions, 989 deletions
diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig index aa0e0c9f74c5..8982c0932438 100644 --- a/drivers/ide/Kconfig +++ b/drivers/ide/Kconfig | |||
@@ -1074,22 +1074,6 @@ endif | |||
1074 | config BLK_DEV_IDEDMA | 1074 | config BLK_DEV_IDEDMA |
1075 | def_bool BLK_DEV_IDEDMA_PCI || BLK_DEV_IDEDMA_PMAC || BLK_DEV_IDEDMA_ICS || BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA | 1075 | def_bool BLK_DEV_IDEDMA_PCI || BLK_DEV_IDEDMA_PMAC || BLK_DEV_IDEDMA_ICS || BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA |
1076 | 1076 | ||
1077 | config IDEDMA_IVB | ||
1078 | bool "IGNORE word93 Validation BITS" | ||
1079 | depends on BLK_DEV_IDEDMA_PCI || BLK_DEV_IDEDMA_PMAC || BLK_DEV_IDEDMA_ICS | ||
1080 | ---help--- | ||
1081 | There are unclear terms in ATA-4 and ATA-5 standards how certain | ||
1082 | hardware (an 80c ribbon) should be detected. Different interpretations | ||
1083 | of the standards have been released in hardware. This causes problems: | ||
1084 | for example, a host with Ultra Mode 4 (or higher) will not run | ||
1085 | in that mode with an 80c ribbon. | ||
1086 | |||
1087 | If you are experiencing compatibility or performance problems, you | ||
1088 | MAY try to answer Y here. However, it does not necessarily solve | ||
1089 | any of your problems, it could even cause more of them. | ||
1090 | |||
1091 | It is normally safe to answer Y; however, the default is N. | ||
1092 | |||
1093 | endif | 1077 | endif |
1094 | 1078 | ||
1095 | config BLK_DEV_HD_ONLY | 1079 | config BLK_DEV_HD_ONLY |
diff --git a/drivers/ide/arm/icside.c b/drivers/ide/arm/icside.c index 7912a471f10d..bd1f5b670378 100644 --- a/drivers/ide/arm/icside.c +++ b/drivers/ide/arm/icside.c | |||
@@ -248,7 +248,7 @@ static void icside_build_sglist(ide_drive_t *drive, struct request *rq) | |||
248 | * MW1 80 50 50 150 C | 248 | * MW1 80 50 50 150 C |
249 | * MW2 70 25 25 120 C | 249 | * MW2 70 25 25 120 C |
250 | */ | 250 | */ |
251 | static int icside_set_speed(ide_drive_t *drive, const u8 xfer_mode) | 251 | static void icside_set_dma_mode(ide_drive_t *drive, const u8 xfer_mode) |
252 | { | 252 | { |
253 | int cycle_time, use_dma_info = 0; | 253 | int cycle_time, use_dma_info = 0; |
254 | 254 | ||
@@ -273,7 +273,7 @@ static int icside_set_speed(ide_drive_t *drive, const u8 xfer_mode) | |||
273 | cycle_time = 480; | 273 | cycle_time = 480; |
274 | break; | 274 | break; |
275 | default: | 275 | default: |
276 | return 1; | 276 | return; |
277 | } | 277 | } |
278 | 278 | ||
279 | /* | 279 | /* |
@@ -287,8 +287,6 @@ static int icside_set_speed(ide_drive_t *drive, const u8 xfer_mode) | |||
287 | 287 | ||
288 | printk("%s: %s selected (peak %dMB/s)\n", drive->name, | 288 | printk("%s: %s selected (peak %dMB/s)\n", drive->name, |
289 | ide_xfer_verbose(xfer_mode), 2000 / drive->drive_data); | 289 | ide_xfer_verbose(xfer_mode), 2000 / drive->drive_data); |
290 | |||
291 | return ide_config_drive_speed(drive, xfer_mode); | ||
292 | } | 290 | } |
293 | 291 | ||
294 | static void icside_dma_host_off(ide_drive_t *drive) | 292 | static void icside_dma_host_off(ide_drive_t *drive) |
@@ -313,41 +311,10 @@ static int icside_dma_on(ide_drive_t *drive) | |||
313 | 311 | ||
314 | static int icside_dma_check(ide_drive_t *drive) | 312 | static int icside_dma_check(ide_drive_t *drive) |
315 | { | 313 | { |
316 | struct hd_driveid *id = drive->id; | 314 | if (ide_tune_dma(drive)) |
317 | ide_hwif_t *hwif = HWIF(drive); | 315 | return 0; |
318 | int xfer_mode = 0; | ||
319 | |||
320 | if (!(id->capability & 1) || !hwif->autodma) | ||
321 | goto out; | ||
322 | |||
323 | /* | ||
324 | * Consult the list of known "bad" drives | ||
325 | */ | ||
326 | if (__ide_dma_bad_drive(drive)) | ||
327 | goto out; | ||
328 | |||
329 | /* | ||
330 | * Enable DMA on any drive that has multiword DMA | ||
331 | */ | ||
332 | if (id->field_valid & 2) { | ||
333 | xfer_mode = ide_max_dma_mode(drive); | ||
334 | goto out; | ||
335 | } | ||
336 | |||
337 | /* | ||
338 | * Consult the list of known "good" drives | ||
339 | */ | ||
340 | if (__ide_dma_good_drive(drive)) { | ||
341 | if (id->eide_dma_time > 150) | ||
342 | goto out; | ||
343 | xfer_mode = XFER_MW_DMA_1; | ||
344 | } | ||
345 | |||
346 | out: | ||
347 | if (xfer_mode == 0) | ||
348 | return -1; | ||
349 | 316 | ||
350 | return icside_set_speed(drive, xfer_mode) ? -1 : 0; | 317 | return -1; |
351 | } | 318 | } |
352 | 319 | ||
353 | static int icside_dma_end(ide_drive_t *drive) | 320 | static int icside_dma_end(ide_drive_t *drive) |
@@ -464,7 +431,7 @@ static void icside_dma_init(ide_hwif_t *hwif) | |||
464 | 431 | ||
465 | hwif->dmatable_cpu = NULL; | 432 | hwif->dmatable_cpu = NULL; |
466 | hwif->dmatable_dma = 0; | 433 | hwif->dmatable_dma = 0; |
467 | hwif->speedproc = icside_set_speed; | 434 | hwif->set_dma_mode = icside_set_dma_mode; |
468 | hwif->autodma = 1; | 435 | hwif->autodma = 1; |
469 | 436 | ||
470 | hwif->ide_dma_check = icside_dma_check; | 437 | hwif->ide_dma_check = icside_dma_check; |
diff --git a/drivers/ide/cris/ide-cris.c b/drivers/ide/cris/ide-cris.c index 4bb42b30bfc0..2b4d2a0ae5c2 100644 --- a/drivers/ide/cris/ide-cris.c +++ b/drivers/ide/cris/ide-cris.c | |||
@@ -716,11 +716,9 @@ static void cris_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
716 | } | 716 | } |
717 | 717 | ||
718 | cris_ide_set_speed(TYPE_PIO, setup, strobe, hold); | 718 | cris_ide_set_speed(TYPE_PIO, setup, strobe, hold); |
719 | |||
720 | (void)ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
721 | } | 719 | } |
722 | 720 | ||
723 | static int speed_cris_ide(ide_drive_t *drive, const u8 speed) | 721 | static void cris_set_dma_mode(ide_drive_t *drive, const u8 speed) |
724 | { | 722 | { |
725 | int cyc = 0, dvs = 0, strobe = 0, hold = 0; | 723 | int cyc = 0, dvs = 0, strobe = 0, hold = 0; |
726 | 724 | ||
@@ -759,8 +757,6 @@ static int speed_cris_ide(ide_drive_t *drive, const u8 speed) | |||
759 | cris_ide_set_speed(TYPE_UDMA, cyc, dvs, 0); | 757 | cris_ide_set_speed(TYPE_UDMA, cyc, dvs, 0); |
760 | else | 758 | else |
761 | cris_ide_set_speed(TYPE_DMA, 0, strobe, hold); | 759 | cris_ide_set_speed(TYPE_DMA, 0, strobe, hold); |
762 | |||
763 | return ide_config_drive_speed(drive, speed); | ||
764 | } | 760 | } |
765 | 761 | ||
766 | void __init | 762 | void __init |
@@ -791,7 +787,7 @@ init_e100_ide (void) | |||
791 | hwif->mmio = 1; | 787 | hwif->mmio = 1; |
792 | hwif->chipset = ide_etrax100; | 788 | hwif->chipset = ide_etrax100; |
793 | hwif->set_pio_mode = &cris_set_pio_mode; | 789 | hwif->set_pio_mode = &cris_set_pio_mode; |
794 | hwif->speedproc = &speed_cris_ide; | 790 | hwif->set_dma_mode = &cris_set_dma_mode; |
795 | hwif->ata_input_data = &cris_ide_input_data; | 791 | hwif->ata_input_data = &cris_ide_input_data; |
796 | hwif->ata_output_data = &cris_ide_output_data; | 792 | hwif->ata_output_data = &cris_ide_output_data; |
797 | hwif->atapi_input_bytes = &cris_atapi_input_bytes; | 793 | hwif->atapi_input_bytes = &cris_atapi_input_bytes; |
diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c index 6bff81a58bf3..1d5f6823101c 100644 --- a/drivers/ide/ide-acpi.c +++ b/drivers/ide/ide-acpi.c | |||
@@ -649,7 +649,6 @@ void ide_acpi_set_state(ide_hwif_t *hwif, int on) | |||
649 | if (!on) | 649 | if (!on) |
650 | acpi_bus_set_power(hwif->acpidata->obj_handle, ACPI_STATE_D3); | 650 | acpi_bus_set_power(hwif->acpidata->obj_handle, ACPI_STATE_D3); |
651 | } | 651 | } |
652 | EXPORT_SYMBOL_GPL(ide_acpi_set_state); | ||
653 | 652 | ||
654 | /** | 653 | /** |
655 | * ide_acpi_init - initialize the ACPI link for an IDE interface | 654 | * ide_acpi_init - initialize the ACPI link for an IDE interface |
diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c index 6000c08f51ba..b453211ee0fc 100644 --- a/drivers/ide/ide-dma.c +++ b/drivers/ide/ide-dma.c | |||
@@ -169,6 +169,11 @@ ide_startstop_t ide_dma_intr (ide_drive_t *drive) | |||
169 | 169 | ||
170 | EXPORT_SYMBOL_GPL(ide_dma_intr); | 170 | EXPORT_SYMBOL_GPL(ide_dma_intr); |
171 | 171 | ||
172 | static int ide_dma_good_drive(ide_drive_t *drive) | ||
173 | { | ||
174 | return ide_in_drive_list(drive->id, drive_whitelist); | ||
175 | } | ||
176 | |||
172 | #ifdef CONFIG_BLK_DEV_IDEDMA_PCI | 177 | #ifdef CONFIG_BLK_DEV_IDEDMA_PCI |
173 | /** | 178 | /** |
174 | * ide_build_sglist - map IDE scatter gather for DMA I/O | 179 | * ide_build_sglist - map IDE scatter gather for DMA I/O |
@@ -357,7 +362,7 @@ static int config_drive_for_dma (ide_drive_t *drive) | |||
357 | return 0; | 362 | return 0; |
358 | 363 | ||
359 | /* Consult the list of known "good" drives */ | 364 | /* Consult the list of known "good" drives */ |
360 | if (__ide_dma_good_drive(drive)) | 365 | if (ide_dma_good_drive(drive)) |
361 | return 0; | 366 | return 0; |
362 | } | 367 | } |
363 | 368 | ||
@@ -639,14 +644,6 @@ int __ide_dma_bad_drive (ide_drive_t *drive) | |||
639 | 644 | ||
640 | EXPORT_SYMBOL(__ide_dma_bad_drive); | 645 | EXPORT_SYMBOL(__ide_dma_bad_drive); |
641 | 646 | ||
642 | int __ide_dma_good_drive (ide_drive_t *drive) | ||
643 | { | ||
644 | struct hd_driveid *id = drive->id; | ||
645 | return ide_in_drive_list(id, drive_whitelist); | ||
646 | } | ||
647 | |||
648 | EXPORT_SYMBOL(__ide_dma_good_drive); | ||
649 | |||
650 | static const u8 xfer_mode_bases[] = { | 647 | static const u8 xfer_mode_bases[] = { |
651 | XFER_UDMA_0, | 648 | XFER_UDMA_0, |
652 | XFER_MW_DMA_0, | 649 | XFER_MW_DMA_0, |
@@ -746,6 +743,14 @@ u8 ide_find_dma_mode(ide_drive_t *drive, u8 req_mode) | |||
746 | } | 743 | } |
747 | } | 744 | } |
748 | 745 | ||
746 | if (hwif->chipset == ide_acorn && mode == 0) { | ||
747 | /* | ||
748 | * is this correct? | ||
749 | */ | ||
750 | if (ide_dma_good_drive(drive) && drive->id->eide_dma_time < 150) | ||
751 | mode = XFER_MW_DMA_1; | ||
752 | } | ||
753 | |||
749 | printk(KERN_DEBUG "%s: selected mode 0x%x\n", drive->name, mode); | 754 | printk(KERN_DEBUG "%s: selected mode 0x%x\n", drive->name, mode); |
750 | 755 | ||
751 | return min(mode, req_mode); | 756 | return min(mode, req_mode); |
@@ -769,7 +774,10 @@ int ide_tune_dma(ide_drive_t *drive) | |||
769 | if (!speed) | 774 | if (!speed) |
770 | return 0; | 775 | return 0; |
771 | 776 | ||
772 | if (drive->hwif->speedproc(drive, speed)) | 777 | if (drive->hwif->host_flags & IDE_HFLAG_NO_SET_MODE) |
778 | return 0; | ||
779 | |||
780 | if (ide_set_dma_mode(drive, speed)) | ||
773 | return 0; | 781 | return 0; |
774 | 782 | ||
775 | return 1; | 783 | return 1; |
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index 9560a8f4a86c..4cece930114c 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c | |||
@@ -836,9 +836,17 @@ static ide_startstop_t do_special (ide_drive_t *drive) | |||
836 | if (set_pio_mode_abuse(drive->hwif, req_pio)) { | 836 | if (set_pio_mode_abuse(drive->hwif, req_pio)) { |
837 | if (hwif->set_pio_mode) | 837 | if (hwif->set_pio_mode) |
838 | hwif->set_pio_mode(drive, req_pio); | 838 | hwif->set_pio_mode(drive, req_pio); |
839 | } else | 839 | } else { |
840 | int keep_dma = drive->using_dma; | ||
841 | |||
840 | ide_set_pio(drive, req_pio); | 842 | ide_set_pio(drive, req_pio); |
841 | 843 | ||
844 | if (hwif->host_flags & IDE_HFLAG_SET_PIO_MODE_KEEP_DMA) { | ||
845 | if (keep_dma) | ||
846 | hwif->ide_dma_on(drive); | ||
847 | } | ||
848 | } | ||
849 | |||
842 | return ide_stopped; | 850 | return ide_stopped; |
843 | } else { | 851 | } else { |
844 | if (drive->media == ide_disk) | 852 | if (drive->media == ide_disk) |
diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c index cf0678b61161..aa738833bed5 100644 --- a/drivers/ide/ide-iops.c +++ b/drivers/ide/ide-iops.c | |||
@@ -473,57 +473,22 @@ int drive_is_ready (ide_drive_t *drive) | |||
473 | EXPORT_SYMBOL(drive_is_ready); | 473 | EXPORT_SYMBOL(drive_is_ready); |
474 | 474 | ||
475 | /* | 475 | /* |
476 | * Global for All, and taken from ide-pmac.c. Can be called | ||
477 | * with spinlock held & IRQs disabled, so don't schedule ! | ||
478 | */ | ||
479 | int wait_for_ready (ide_drive_t *drive, int timeout) | ||
480 | { | ||
481 | ide_hwif_t *hwif = HWIF(drive); | ||
482 | u8 stat = 0; | ||
483 | |||
484 | while(--timeout) { | ||
485 | stat = hwif->INB(IDE_STATUS_REG); | ||
486 | if (!(stat & BUSY_STAT)) { | ||
487 | if (drive->ready_stat == 0) | ||
488 | break; | ||
489 | else if ((stat & drive->ready_stat)||(stat & ERR_STAT)) | ||
490 | break; | ||
491 | } | ||
492 | mdelay(1); | ||
493 | } | ||
494 | if ((stat & ERR_STAT) || timeout <= 0) { | ||
495 | if (stat & ERR_STAT) { | ||
496 | printk(KERN_ERR "%s: wait_for_ready, " | ||
497 | "error status: %x\n", drive->name, stat); | ||
498 | } | ||
499 | return 1; | ||
500 | } | ||
501 | return 0; | ||
502 | } | ||
503 | |||
504 | /* | ||
505 | * This routine busy-waits for the drive status to be not "busy". | 476 | * This routine busy-waits for the drive status to be not "busy". |
506 | * It then checks the status for all of the "good" bits and none | 477 | * It then checks the status for all of the "good" bits and none |
507 | * of the "bad" bits, and if all is okay it returns 0. All other | 478 | * of the "bad" bits, and if all is okay it returns 0. All other |
508 | * cases return 1 after invoking ide_error() -- caller should just return. | 479 | * cases return error -- caller may then invoke ide_error(). |
509 | * | 480 | * |
510 | * This routine should get fixed to not hog the cpu during extra long waits.. | 481 | * This routine should get fixed to not hog the cpu during extra long waits.. |
511 | * That could be done by busy-waiting for the first jiffy or two, and then | 482 | * That could be done by busy-waiting for the first jiffy or two, and then |
512 | * setting a timer to wake up at half second intervals thereafter, | 483 | * setting a timer to wake up at half second intervals thereafter, |
513 | * until timeout is achieved, before timing out. | 484 | * until timeout is achieved, before timing out. |
514 | */ | 485 | */ |
515 | int ide_wait_stat (ide_startstop_t *startstop, ide_drive_t *drive, u8 good, u8 bad, unsigned long timeout) | 486 | static int __ide_wait_stat(ide_drive_t *drive, u8 good, u8 bad, unsigned long timeout, u8 *rstat) |
516 | { | 487 | { |
517 | ide_hwif_t *hwif = HWIF(drive); | 488 | ide_hwif_t *hwif = drive->hwif; |
518 | u8 stat; | ||
519 | int i; | ||
520 | unsigned long flags; | 489 | unsigned long flags; |
521 | 490 | int i; | |
522 | /* bail early if we've exceeded max_failures */ | 491 | u8 stat; |
523 | if (drive->max_failures && (drive->failures > drive->max_failures)) { | ||
524 | *startstop = ide_stopped; | ||
525 | return 1; | ||
526 | } | ||
527 | 492 | ||
528 | udelay(1); /* spec allows drive 400ns to assert "BUSY" */ | 493 | udelay(1); /* spec allows drive 400ns to assert "BUSY" */ |
529 | if ((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) { | 494 | if ((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) { |
@@ -541,8 +506,8 @@ int ide_wait_stat (ide_startstop_t *startstop, ide_drive_t *drive, u8 good, u8 b | |||
541 | break; | 506 | break; |
542 | 507 | ||
543 | local_irq_restore(flags); | 508 | local_irq_restore(flags); |
544 | *startstop = ide_error(drive, "status timeout", stat); | 509 | *rstat = stat; |
545 | return 1; | 510 | return -EBUSY; |
546 | } | 511 | } |
547 | } | 512 | } |
548 | local_irq_restore(flags); | 513 | local_irq_restore(flags); |
@@ -556,11 +521,39 @@ int ide_wait_stat (ide_startstop_t *startstop, ide_drive_t *drive, u8 good, u8 b | |||
556 | */ | 521 | */ |
557 | for (i = 0; i < 10; i++) { | 522 | for (i = 0; i < 10; i++) { |
558 | udelay(1); | 523 | udelay(1); |
559 | if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), good, bad)) | 524 | if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), good, bad)) { |
525 | *rstat = stat; | ||
560 | return 0; | 526 | return 0; |
527 | } | ||
561 | } | 528 | } |
562 | *startstop = ide_error(drive, "status error", stat); | 529 | *rstat = stat; |
563 | return 1; | 530 | return -EFAULT; |
531 | } | ||
532 | |||
533 | /* | ||
534 | * In case of error returns error value after doing "*startstop = ide_error()". | ||
535 | * The caller should return the updated value of "startstop" in this case, | ||
536 | * "startstop" is unchanged when the function returns 0. | ||
537 | */ | ||
538 | int ide_wait_stat(ide_startstop_t *startstop, ide_drive_t *drive, u8 good, u8 bad, unsigned long timeout) | ||
539 | { | ||
540 | int err; | ||
541 | u8 stat; | ||
542 | |||
543 | /* bail early if we've exceeded max_failures */ | ||
544 | if (drive->max_failures && (drive->failures > drive->max_failures)) { | ||
545 | *startstop = ide_stopped; | ||
546 | return 1; | ||
547 | } | ||
548 | |||
549 | err = __ide_wait_stat(drive, good, bad, timeout, &stat); | ||
550 | |||
551 | if (err) { | ||
552 | char *s = (err == -EBUSY) ? "status timeout" : "status error"; | ||
553 | *startstop = ide_error(drive, s, stat); | ||
554 | } | ||
555 | |||
556 | return err; | ||
564 | } | 557 | } |
565 | 558 | ||
566 | EXPORT_SYMBOL(ide_wait_stat); | 559 | EXPORT_SYMBOL(ide_wait_stat); |
@@ -620,15 +613,10 @@ u8 eighty_ninty_three (ide_drive_t *drive) | |||
620 | 613 | ||
621 | /* | 614 | /* |
622 | * FIXME: | 615 | * FIXME: |
623 | * - change master/slave IDENTIFY order | ||
624 | * - force bit13 (80c cable present) check also for !ivb devices | 616 | * - force bit13 (80c cable present) check also for !ivb devices |
625 | * (unless the slave device is pre-ATA3) | 617 | * (unless the slave device is pre-ATA3) |
626 | */ | 618 | */ |
627 | #ifndef CONFIG_IDEDMA_IVB | ||
628 | if ((id->hw_config & 0x4000) || (ivb && (id->hw_config & 0x2000))) | 619 | if ((id->hw_config & 0x4000) || (ivb && (id->hw_config & 0x2000))) |
629 | #else | ||
630 | if (id->hw_config & 0x6000) | ||
631 | #endif | ||
632 | return 1; | 620 | return 1; |
633 | 621 | ||
634 | no_80w: | 622 | no_80w: |
@@ -778,15 +766,10 @@ int ide_driveid_update (ide_drive_t *drive) | |||
778 | #endif | 766 | #endif |
779 | } | 767 | } |
780 | 768 | ||
781 | /* | 769 | int ide_config_drive_speed(ide_drive_t *drive, u8 speed) |
782 | * Similar to ide_wait_stat(), except it never calls ide_error internally. | ||
783 | * | ||
784 | * const char *msg == consider adding for verbose errors. | ||
785 | */ | ||
786 | int ide_config_drive_speed (ide_drive_t *drive, u8 speed) | ||
787 | { | 770 | { |
788 | ide_hwif_t *hwif = HWIF(drive); | 771 | ide_hwif_t *hwif = drive->hwif; |
789 | int i, error = 1; | 772 | int error; |
790 | u8 stat; | 773 | u8 stat; |
791 | 774 | ||
792 | // while (HWGROUP(drive)->busy) | 775 | // while (HWGROUP(drive)->busy) |
@@ -826,35 +809,10 @@ int ide_config_drive_speed (ide_drive_t *drive, u8 speed) | |||
826 | hwif->OUTBSYNC(drive, WIN_SETFEATURES, IDE_COMMAND_REG); | 809 | hwif->OUTBSYNC(drive, WIN_SETFEATURES, IDE_COMMAND_REG); |
827 | if ((IDE_CONTROL_REG) && (drive->quirk_list == 2)) | 810 | if ((IDE_CONTROL_REG) && (drive->quirk_list == 2)) |
828 | hwif->OUTB(drive->ctl, IDE_CONTROL_REG); | 811 | hwif->OUTB(drive->ctl, IDE_CONTROL_REG); |
829 | udelay(1); | ||
830 | /* | ||
831 | * Wait for drive to become non-BUSY | ||
832 | */ | ||
833 | if ((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) { | ||
834 | unsigned long flags, timeout; | ||
835 | local_irq_set(flags); | ||
836 | timeout = jiffies + WAIT_CMD; | ||
837 | while ((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) { | ||
838 | if (time_after(jiffies, timeout)) | ||
839 | break; | ||
840 | } | ||
841 | local_irq_restore(flags); | ||
842 | } | ||
843 | 812 | ||
844 | /* | 813 | error = __ide_wait_stat(drive, drive->ready_stat, |
845 | * Allow status to settle, then read it again. | 814 | BUSY_STAT|DRQ_STAT|ERR_STAT, |
846 | * A few rare drives vastly violate the 400ns spec here, | 815 | WAIT_CMD, &stat); |
847 | * so we'll wait up to 10usec for a "good" status | ||
848 | * rather than expensively fail things immediately. | ||
849 | * This fix courtesy of Matthew Faupel & Niccolo Rigacci. | ||
850 | */ | ||
851 | for (i = 0; i < 10; i++) { | ||
852 | udelay(1); | ||
853 | if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), drive->ready_stat, BUSY_STAT|DRQ_STAT|ERR_STAT)) { | ||
854 | error = 0; | ||
855 | break; | ||
856 | } | ||
857 | } | ||
858 | 816 | ||
859 | SELECT_MASK(drive, 0); | 817 | SELECT_MASK(drive, 0); |
860 | 818 | ||
@@ -899,9 +857,6 @@ int ide_config_drive_speed (ide_drive_t *drive, u8 speed) | |||
899 | return error; | 857 | return error; |
900 | } | 858 | } |
901 | 859 | ||
902 | EXPORT_SYMBOL(ide_config_drive_speed); | ||
903 | |||
904 | |||
905 | /* | 860 | /* |
906 | * This should get invoked any time we exit the driver to | 861 | * This should get invoked any time we exit the driver to |
907 | * wait for an interrupt response from a drive. handler() points | 862 | * wait for an interrupt response from a drive. handler() points |
diff --git a/drivers/ide/ide-lib.c b/drivers/ide/ide-lib.c index d97390c0543b..0e2562f0f74e 100644 --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c | |||
@@ -349,7 +349,7 @@ void ide_set_pio(ide_drive_t *drive, u8 req_pio) | |||
349 | drive->name, host_pio, req_pio, | 349 | drive->name, host_pio, req_pio, |
350 | req_pio == 255 ? "(auto-tune)" : "", pio); | 350 | req_pio == 255 ? "(auto-tune)" : "", pio); |
351 | 351 | ||
352 | hwif->set_pio_mode(drive, pio); | 352 | (void)ide_set_pio_mode(drive, XFER_PIO_0 + pio); |
353 | } | 353 | } |
354 | 354 | ||
355 | EXPORT_SYMBOL_GPL(ide_set_pio); | 355 | EXPORT_SYMBOL_GPL(ide_set_pio); |
@@ -378,39 +378,83 @@ void ide_toggle_bounce(ide_drive_t *drive, int on) | |||
378 | blk_queue_bounce_limit(drive->queue, addr); | 378 | blk_queue_bounce_limit(drive->queue, addr); |
379 | } | 379 | } |
380 | 380 | ||
381 | int ide_set_pio_mode(ide_drive_t *drive, const u8 mode) | ||
382 | { | ||
383 | ide_hwif_t *hwif = drive->hwif; | ||
384 | |||
385 | if (hwif->set_pio_mode == NULL) | ||
386 | return -1; | ||
387 | |||
388 | /* | ||
389 | * TODO: temporary hack for some legacy host drivers that didn't | ||
390 | * set transfer mode on the device in ->set_pio_mode method... | ||
391 | */ | ||
392 | if (hwif->set_dma_mode == NULL) { | ||
393 | hwif->set_pio_mode(drive, mode - XFER_PIO_0); | ||
394 | return 0; | ||
395 | } | ||
396 | |||
397 | if (hwif->host_flags & IDE_HFLAG_POST_SET_MODE) { | ||
398 | if (ide_config_drive_speed(drive, mode)) | ||
399 | return -1; | ||
400 | hwif->set_pio_mode(drive, mode - XFER_PIO_0); | ||
401 | return 0; | ||
402 | } else { | ||
403 | hwif->set_pio_mode(drive, mode - XFER_PIO_0); | ||
404 | return ide_config_drive_speed(drive, mode); | ||
405 | } | ||
406 | } | ||
407 | |||
408 | int ide_set_dma_mode(ide_drive_t *drive, const u8 mode) | ||
409 | { | ||
410 | ide_hwif_t *hwif = drive->hwif; | ||
411 | |||
412 | if (hwif->set_dma_mode == NULL) | ||
413 | return -1; | ||
414 | |||
415 | if (hwif->host_flags & IDE_HFLAG_POST_SET_MODE) { | ||
416 | if (ide_config_drive_speed(drive, mode)) | ||
417 | return -1; | ||
418 | hwif->set_dma_mode(drive, mode); | ||
419 | return 0; | ||
420 | } else { | ||
421 | hwif->set_dma_mode(drive, mode); | ||
422 | return ide_config_drive_speed(drive, mode); | ||
423 | } | ||
424 | } | ||
425 | |||
426 | EXPORT_SYMBOL_GPL(ide_set_dma_mode); | ||
427 | |||
381 | /** | 428 | /** |
382 | * ide_set_xfer_rate - set transfer rate | 429 | * ide_set_xfer_rate - set transfer rate |
383 | * @drive: drive to set | 430 | * @drive: drive to set |
384 | * @speed: speed to attempt to set | 431 | * @rate: speed to attempt to set |
385 | * | 432 | * |
386 | * General helper for setting the speed of an IDE device. This | 433 | * General helper for setting the speed of an IDE device. This |
387 | * function knows about user enforced limits from the configuration | 434 | * function knows about user enforced limits from the configuration |
388 | * which speedproc() does not. High level drivers should never | 435 | * which ->set_pio_mode/->set_dma_mode does not. |
389 | * invoke speedproc() directly. | ||
390 | */ | 436 | */ |
391 | 437 | ||
392 | int ide_set_xfer_rate(ide_drive_t *drive, u8 rate) | 438 | int ide_set_xfer_rate(ide_drive_t *drive, u8 rate) |
393 | { | 439 | { |
394 | ide_hwif_t *hwif = drive->hwif; | 440 | ide_hwif_t *hwif = drive->hwif; |
395 | 441 | ||
396 | if (hwif->speedproc == NULL) | 442 | if (hwif->set_dma_mode == NULL) |
397 | return -1; | 443 | return -1; |
398 | 444 | ||
399 | rate = ide_rate_filter(drive, rate); | 445 | rate = ide_rate_filter(drive, rate); |
400 | 446 | ||
401 | if (rate >= XFER_PIO_0 && rate <= XFER_PIO_5) { | 447 | if (rate >= XFER_PIO_0 && rate <= XFER_PIO_5) |
402 | if (hwif->set_pio_mode) | 448 | return ide_set_pio_mode(drive, rate); |
403 | hwif->set_pio_mode(drive, rate - XFER_PIO_0); | ||
404 | 449 | ||
405 | /* | 450 | /* |
406 | * FIXME: this is incorrect to return zero here but | 451 | * TODO: transfer modes 0x00-0x07 passed from the user-space are |
407 | * since all users of ide_set_xfer_rate() ignore | 452 | * currently handled here which needs fixing (please note that such |
408 | * the return value it is not a problem currently | 453 | * case could happen iff the transfer mode has already been set on |
409 | */ | 454 | * the device by ide-proc.c::set_xfer_rate()). |
410 | return 0; | 455 | */ |
411 | } | ||
412 | 456 | ||
413 | return hwif->speedproc(drive, rate); | 457 | return ide_set_dma_mode(drive, rate); |
414 | } | 458 | } |
415 | 459 | ||
416 | static void ide_dump_opcode(ide_drive_t *drive) | 460 | static void ide_dump_opcode(ide_drive_t *drive) |
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index b4c9f63a3854..d1011712601c 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c | |||
@@ -719,9 +719,9 @@ EXPORT_SYMBOL_GPL(ide_undecoded_slave); | |||
719 | */ | 719 | */ |
720 | static void probe_hwif(ide_hwif_t *hwif, void (*fixup)(ide_hwif_t *hwif)) | 720 | static void probe_hwif(ide_hwif_t *hwif, void (*fixup)(ide_hwif_t *hwif)) |
721 | { | 721 | { |
722 | unsigned int unit; | ||
723 | unsigned long flags; | 722 | unsigned long flags; |
724 | unsigned int irqd; | 723 | unsigned int irqd; |
724 | int unit; | ||
725 | 725 | ||
726 | if (hwif->noprobe) | 726 | if (hwif->noprobe) |
727 | return; | 727 | return; |
@@ -777,10 +777,9 @@ static void probe_hwif(ide_hwif_t *hwif, void (*fixup)(ide_hwif_t *hwif)) | |||
777 | printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name); | 777 | printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name); |
778 | 778 | ||
779 | /* | 779 | /* |
780 | * Second drive should only exist if first drive was found, | 780 | * Need to probe slave device first to make it release PDIAG-. |
781 | * but a lot of cdrom drives are configured as single slaves. | ||
782 | */ | 781 | */ |
783 | for (unit = 0; unit < MAX_DRIVES; ++unit) { | 782 | for (unit = MAX_DRIVES - 1; unit >= 0; unit--) { |
784 | ide_drive_t *drive = &hwif->drives[unit]; | 783 | ide_drive_t *drive = &hwif->drives[unit]; |
785 | drive->dn = (hwif->channel ? 2 : 0) + unit; | 784 | drive->dn = (hwif->channel ? 2 : 0) + unit; |
786 | (void) probe_for_drive(drive); | 785 | (void) probe_for_drive(drive); |
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c index a96a8b1b3539..5c0e4078b5cb 100644 --- a/drivers/ide/ide.c +++ b/drivers/ide/ide.c | |||
@@ -397,7 +397,7 @@ static void ide_hwif_restore(ide_hwif_t *hwif, ide_hwif_t *tmp_hwif) | |||
397 | #endif | 397 | #endif |
398 | 398 | ||
399 | hwif->set_pio_mode = tmp_hwif->set_pio_mode; | 399 | hwif->set_pio_mode = tmp_hwif->set_pio_mode; |
400 | hwif->speedproc = tmp_hwif->speedproc; | 400 | hwif->set_dma_mode = tmp_hwif->set_dma_mode; |
401 | hwif->mdma_filter = tmp_hwif->mdma_filter; | 401 | hwif->mdma_filter = tmp_hwif->mdma_filter; |
402 | hwif->udma_filter = tmp_hwif->udma_filter; | 402 | hwif->udma_filter = tmp_hwif->udma_filter; |
403 | hwif->selectproc = tmp_hwif->selectproc; | 403 | hwif->selectproc = tmp_hwif->selectproc; |
diff --git a/drivers/ide/legacy/ide_platform.c b/drivers/ide/legacy/ide_platform.c index ccfb9893a467..b992b2b91fe2 100644 --- a/drivers/ide/legacy/ide_platform.c +++ b/drivers/ide/legacy/ide_platform.c | |||
@@ -65,7 +65,7 @@ found: | |||
65 | hwif->hw.irq = hwif->irq = irq; | 65 | hwif->hw.irq = hwif->irq = irq; |
66 | 66 | ||
67 | hwif->hw.dma = NO_DMA; | 67 | hwif->hw.dma = NO_DMA; |
68 | hwif->hw.chipset = ide_generic; | 68 | hwif->chipset = hwif->hw.chipset = ide_generic; |
69 | 69 | ||
70 | if (mmio) { | 70 | if (mmio) { |
71 | hwif->mmio = 1; | 71 | hwif->mmio = 1; |
diff --git a/drivers/ide/mips/au1xxx-ide.c b/drivers/ide/mips/au1xxx-ide.c index 85819ae20602..aebde49365d1 100644 --- a/drivers/ide/mips/au1xxx-ide.c +++ b/drivers/ide/mips/au1xxx-ide.c | |||
@@ -101,12 +101,7 @@ void auide_outsw(unsigned long port, void *addr, u32 count) | |||
101 | 101 | ||
102 | static void au1xxx_set_pio_mode(ide_drive_t *drive, const u8 pio) | 102 | static void au1xxx_set_pio_mode(ide_drive_t *drive, const u8 pio) |
103 | { | 103 | { |
104 | int mem_sttime; | 104 | int mem_sttime = 0, mem_stcfg = au_readl(MEM_STCFG2); |
105 | int mem_stcfg; | ||
106 | u8 speed; | ||
107 | |||
108 | mem_sttime = 0; | ||
109 | mem_stcfg = au_readl(MEM_STCFG2); | ||
110 | 105 | ||
111 | /* set pio mode! */ | 106 | /* set pio mode! */ |
112 | switch(pio) { | 107 | switch(pio) { |
@@ -164,18 +159,11 @@ static void au1xxx_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
164 | 159 | ||
165 | au_writel(mem_sttime,MEM_STTIME2); | 160 | au_writel(mem_sttime,MEM_STTIME2); |
166 | au_writel(mem_stcfg,MEM_STCFG2); | 161 | au_writel(mem_stcfg,MEM_STCFG2); |
167 | |||
168 | speed = pio + XFER_PIO_0; | ||
169 | ide_config_drive_speed(drive, speed); | ||
170 | } | 162 | } |
171 | 163 | ||
172 | static int auide_tune_chipset(ide_drive_t *drive, const u8 speed) | 164 | static void auide_set_dma_mode(ide_drive_t *drive, const u8 speed) |
173 | { | 165 | { |
174 | int mem_sttime; | 166 | int mem_sttime = 0, mem_stcfg = au_readl(MEM_STCFG2); |
175 | int mem_stcfg; | ||
176 | |||
177 | mem_sttime = 0; | ||
178 | mem_stcfg = au_readl(MEM_STCFG2); | ||
179 | 167 | ||
180 | switch(speed) { | 168 | switch(speed) { |
181 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA | 169 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA |
@@ -211,16 +199,11 @@ static int auide_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
211 | break; | 199 | break; |
212 | #endif | 200 | #endif |
213 | default: | 201 | default: |
214 | return 1; | 202 | return; |
215 | } | 203 | } |
216 | 204 | ||
217 | if (ide_config_drive_speed(drive, speed)) | ||
218 | return 1; | ||
219 | |||
220 | au_writel(mem_sttime,MEM_STTIME2); | 205 | au_writel(mem_sttime,MEM_STTIME2); |
221 | au_writel(mem_stcfg,MEM_STCFG2); | 206 | au_writel(mem_stcfg,MEM_STCFG2); |
222 | |||
223 | return 0; | ||
224 | } | 207 | } |
225 | 208 | ||
226 | /* | 209 | /* |
@@ -682,6 +665,7 @@ static int au_ide_probe(struct device *dev) | |||
682 | #endif | 665 | #endif |
683 | 666 | ||
684 | hwif->pio_mask = ATA_PIO4; | 667 | hwif->pio_mask = ATA_PIO4; |
668 | hwif->host_flags = IDE_HFLAG_POST_SET_MODE; | ||
685 | 669 | ||
686 | hwif->noprobe = 0; | 670 | hwif->noprobe = 0; |
687 | hwif->drives[0].unmask = 1; | 671 | hwif->drives[0].unmask = 1; |
@@ -702,7 +686,7 @@ static int au_ide_probe(struct device *dev) | |||
702 | #endif | 686 | #endif |
703 | 687 | ||
704 | hwif->set_pio_mode = &au1xxx_set_pio_mode; | 688 | hwif->set_pio_mode = &au1xxx_set_pio_mode; |
705 | hwif->speedproc = &auide_tune_chipset; | 689 | hwif->set_dma_mode = &auide_set_dma_mode; |
706 | 690 | ||
707 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA | 691 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA |
708 | hwif->dma_off_quietly = &auide_dma_off_quietly; | 692 | hwif->dma_off_quietly = &auide_dma_off_quietly; |
diff --git a/drivers/ide/pci/aec62xx.c b/drivers/ide/pci/aec62xx.c index 0d5f62c5dfae..d6cb2d5143c8 100644 --- a/drivers/ide/pci/aec62xx.c +++ b/drivers/ide/pci/aec62xx.c | |||
@@ -87,7 +87,7 @@ static u8 pci_bus_clock_list_ultra (u8 speed, struct chipset_bus_clock_list_entr | |||
87 | return chipset_table->ultra_settings; | 87 | return chipset_table->ultra_settings; |
88 | } | 88 | } |
89 | 89 | ||
90 | static int aec6210_tune_chipset(ide_drive_t *drive, const u8 speed) | 90 | static void aec6210_set_mode(ide_drive_t *drive, const u8 speed) |
91 | { | 91 | { |
92 | ide_hwif_t *hwif = HWIF(drive); | 92 | ide_hwif_t *hwif = HWIF(drive); |
93 | struct pci_dev *dev = hwif->pci_dev; | 93 | struct pci_dev *dev = hwif->pci_dev; |
@@ -111,10 +111,9 @@ static int aec6210_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
111 | tmp2 = ((ultra_conf << (2*drive->dn)) | (tmp1 & ~(3 << (2*drive->dn)))); | 111 | tmp2 = ((ultra_conf << (2*drive->dn)) | (tmp1 & ~(3 << (2*drive->dn)))); |
112 | pci_write_config_byte(dev, 0x54, tmp2); | 112 | pci_write_config_byte(dev, 0x54, tmp2); |
113 | local_irq_restore(flags); | 113 | local_irq_restore(flags); |
114 | return(ide_config_drive_speed(drive, speed)); | ||
115 | } | 114 | } |
116 | 115 | ||
117 | static int aec6260_tune_chipset(ide_drive_t *drive, const u8 speed) | 116 | static void aec6260_set_mode(ide_drive_t *drive, const u8 speed) |
118 | { | 117 | { |
119 | ide_hwif_t *hwif = HWIF(drive); | 118 | ide_hwif_t *hwif = HWIF(drive); |
120 | struct pci_dev *dev = hwif->pci_dev; | 119 | struct pci_dev *dev = hwif->pci_dev; |
@@ -135,12 +134,11 @@ static int aec6260_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
135 | tmp2 = ((ultra_conf << (4*unit)) | (tmp1 & ~(7 << (4*unit)))); | 134 | tmp2 = ((ultra_conf << (4*unit)) | (tmp1 & ~(7 << (4*unit)))); |
136 | pci_write_config_byte(dev, (0x44|hwif->channel), tmp2); | 135 | pci_write_config_byte(dev, (0x44|hwif->channel), tmp2); |
137 | local_irq_restore(flags); | 136 | local_irq_restore(flags); |
138 | return(ide_config_drive_speed(drive, speed)); | ||
139 | } | 137 | } |
140 | 138 | ||
141 | static void aec_set_pio_mode(ide_drive_t *drive, const u8 pio) | 139 | static void aec_set_pio_mode(ide_drive_t *drive, const u8 pio) |
142 | { | 140 | { |
143 | (void) HWIF(drive)->speedproc(drive, pio + XFER_PIO_0); | 141 | drive->hwif->set_dma_mode(drive, pio + XFER_PIO_0); |
144 | } | 142 | } |
145 | 143 | ||
146 | static int aec62xx_config_drive_xfer_rate (ide_drive_t *drive) | 144 | static int aec62xx_config_drive_xfer_rate (ide_drive_t *drive) |
@@ -205,9 +203,9 @@ static void __devinit init_hwif_aec62xx(ide_hwif_t *hwif) | |||
205 | if (dev->device == PCI_DEVICE_ID_ARTOP_ATP850UF) { | 203 | if (dev->device == PCI_DEVICE_ID_ARTOP_ATP850UF) { |
206 | if(hwif->mate) | 204 | if(hwif->mate) |
207 | hwif->mate->serialized = hwif->serialized = 1; | 205 | hwif->mate->serialized = hwif->serialized = 1; |
208 | hwif->speedproc = &aec6210_tune_chipset; | 206 | hwif->set_dma_mode = &aec6210_set_mode; |
209 | } else | 207 | } else |
210 | hwif->speedproc = &aec6260_tune_chipset; | 208 | hwif->set_dma_mode = &aec6260_set_mode; |
211 | 209 | ||
212 | if (!hwif->dma_base) { | 210 | if (!hwif->dma_base) { |
213 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; | 211 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; |
diff --git a/drivers/ide/pci/alim15x3.c b/drivers/ide/pci/alim15x3.c index d04b966b4347..0b83443bf250 100644 --- a/drivers/ide/pci/alim15x3.c +++ b/drivers/ide/pci/alim15x3.c | |||
@@ -283,14 +283,14 @@ static int ali_get_info (char *buffer, char **addr, off_t offset, int count) | |||
283 | #endif /* defined(DISPLAY_ALI_TIMINGS) && defined(CONFIG_IDE_PROC_FS) */ | 283 | #endif /* defined(DISPLAY_ALI_TIMINGS) && defined(CONFIG_IDE_PROC_FS) */ |
284 | 284 | ||
285 | /** | 285 | /** |
286 | * ali_tune_pio - set host controller for PIO mode | 286 | * ali_set_pio_mode - set host controller for PIO mode |
287 | * @drive: drive | 287 | * @drive: drive |
288 | * @pio: PIO mode number | 288 | * @pio: PIO mode number |
289 | * | 289 | * |
290 | * Program the controller for the given PIO mode. | 290 | * Program the controller for the given PIO mode. |
291 | */ | 291 | */ |
292 | 292 | ||
293 | static void ali_tune_pio(ide_drive_t *drive, const u8 pio) | 293 | static void ali_set_pio_mode(ide_drive_t *drive, const u8 pio) |
294 | { | 294 | { |
295 | ide_hwif_t *hwif = HWIF(drive); | 295 | ide_hwif_t *hwif = HWIF(drive); |
296 | struct pci_dev *dev = hwif->pci_dev; | 296 | struct pci_dev *dev = hwif->pci_dev; |
@@ -358,21 +358,6 @@ static void ali_tune_pio(ide_drive_t *drive, const u8 pio) | |||
358 | } | 358 | } |
359 | 359 | ||
360 | /** | 360 | /** |
361 | * ali_set_pio_mode - set up drive for PIO mode | ||
362 | * @drive: drive to tune | ||
363 | * @pio: desired mode | ||
364 | * | ||
365 | * Program the controller with the desired PIO timing for the given drive. | ||
366 | * Then set up the drive itself. | ||
367 | */ | ||
368 | |||
369 | static void ali_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
370 | { | ||
371 | ali_tune_pio(drive, pio); | ||
372 | (void) ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
373 | } | ||
374 | |||
375 | /** | ||
376 | * ali_udma_filter - compute UDMA mask | 361 | * ali_udma_filter - compute UDMA mask |
377 | * @drive: IDE device | 362 | * @drive: IDE device |
378 | * | 363 | * |
@@ -401,15 +386,14 @@ static u8 ali_udma_filter(ide_drive_t *drive) | |||
401 | } | 386 | } |
402 | 387 | ||
403 | /** | 388 | /** |
404 | * ali15x3_tune_chipset - set up chipset/drive for new speed | 389 | * ali_set_dma_mode - set host controller for DMA mode |
405 | * @drive: drive to configure for | 390 | * @drive: drive |
406 | * @speed: desired speed | 391 | * @speed: DMA mode |
407 | * | 392 | * |
408 | * Configure the hardware for the desired IDE transfer mode. | 393 | * Configure the hardware for the desired IDE transfer mode. |
409 | * We also do the needed drive configuration through helpers | ||
410 | */ | 394 | */ |
411 | 395 | ||
412 | static int ali15x3_tune_chipset(ide_drive_t *drive, const u8 speed) | 396 | static void ali_set_dma_mode(ide_drive_t *drive, const u8 speed) |
413 | { | 397 | { |
414 | ide_hwif_t *hwif = HWIF(drive); | 398 | ide_hwif_t *hwif = HWIF(drive); |
415 | struct pci_dev *dev = hwif->pci_dev; | 399 | struct pci_dev *dev = hwif->pci_dev; |
@@ -419,7 +403,7 @@ static int ali15x3_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
419 | int m5229_udma = (hwif->channel) ? 0x57 : 0x56; | 403 | int m5229_udma = (hwif->channel) ? 0x57 : 0x56; |
420 | 404 | ||
421 | if (speed < XFER_PIO_0) | 405 | if (speed < XFER_PIO_0) |
422 | return 1; | 406 | return; |
423 | 407 | ||
424 | if (speed == XFER_UDMA_6) | 408 | if (speed == XFER_UDMA_6) |
425 | speed1 = 0x47; | 409 | speed1 = 0x47; |
@@ -450,7 +434,6 @@ static int ali15x3_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
450 | pci_write_config_byte(dev, 0x4b, tmpbyte); | 434 | pci_write_config_byte(dev, 0x4b, tmpbyte); |
451 | } | 435 | } |
452 | } | 436 | } |
453 | return (ide_config_drive_speed(drive, speed)); | ||
454 | } | 437 | } |
455 | 438 | ||
456 | /** | 439 | /** |
@@ -699,7 +682,7 @@ static void __devinit init_hwif_common_ali15x3 (ide_hwif_t *hwif) | |||
699 | { | 682 | { |
700 | hwif->autodma = 0; | 683 | hwif->autodma = 0; |
701 | hwif->set_pio_mode = &ali_set_pio_mode; | 684 | hwif->set_pio_mode = &ali_set_pio_mode; |
702 | hwif->speedproc = &ali15x3_tune_chipset; | 685 | hwif->set_dma_mode = &ali_set_dma_mode; |
703 | hwif->udma_filter = &ali_udma_filter; | 686 | hwif->udma_filter = &ali_udma_filter; |
704 | 687 | ||
705 | /* don't use LBA48 DMA on ALi devices before rev 0xC5 */ | 688 | /* don't use LBA48 DMA on ALi devices before rev 0xC5 */ |
@@ -711,6 +694,10 @@ static void __devinit init_hwif_common_ali15x3 (ide_hwif_t *hwif) | |||
711 | return; | 694 | return; |
712 | } | 695 | } |
713 | 696 | ||
697 | /* | ||
698 | * check in ->init_dma guarantees m5229_revision >= 0x20 here | ||
699 | */ | ||
700 | |||
714 | if (m5229_revision > 0x20) | 701 | if (m5229_revision > 0x20) |
715 | hwif->atapi_dma = 1; | 702 | hwif->atapi_dma = 1; |
716 | 703 | ||
@@ -728,18 +715,15 @@ static void __devinit init_hwif_common_ali15x3 (ide_hwif_t *hwif) | |||
728 | hwif->mwdma_mask = 0x07; | 715 | hwif->mwdma_mask = 0x07; |
729 | hwif->swdma_mask = 0x07; | 716 | hwif->swdma_mask = 0x07; |
730 | 717 | ||
731 | if (m5229_revision >= 0x20) { | 718 | hwif->ide_dma_check = &ali15x3_config_drive_for_dma; |
732 | /* | 719 | hwif->dma_setup = &ali15x3_dma_setup; |
733 | * M1543C or newer for DMAing | 720 | |
734 | */ | 721 | if (hwif->cbl != ATA_CBL_PATA40_SHORT) |
735 | hwif->ide_dma_check = &ali15x3_config_drive_for_dma; | 722 | hwif->cbl = ata66_ali15x3(hwif); |
736 | hwif->dma_setup = &ali15x3_dma_setup; | 723 | |
737 | if (!noautodma) | 724 | if (!noautodma) |
738 | hwif->autodma = 1; | 725 | hwif->autodma = 1; |
739 | 726 | ||
740 | if (hwif->cbl != ATA_CBL_PATA40_SHORT) | ||
741 | hwif->cbl = ata66_ali15x3(hwif); | ||
742 | } | ||
743 | hwif->drives[0].autodma = hwif->autodma; | 727 | hwif->drives[0].autodma = hwif->autodma; |
744 | hwif->drives[1].autodma = hwif->autodma; | 728 | hwif->drives[1].autodma = hwif->autodma; |
745 | } | 729 | } |
diff --git a/drivers/ide/pci/amd74xx.c b/drivers/ide/pci/amd74xx.c index 513205e52ad2..6ff4089a2379 100644 --- a/drivers/ide/pci/amd74xx.c +++ b/drivers/ide/pci/amd74xx.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Version 2.22 | 2 | * Version 2.23 |
3 | * | 3 | * |
4 | * AMD 755/756/766/8111 and nVidia nForce/2/2s/3/3s/CK804/MCP04 | 4 | * AMD 755/756/766/8111 and nVidia nForce/2/2s/3/3s/CK804/MCP04 |
5 | * IDE driver for Linux. | 5 | * IDE driver for Linux. |
@@ -229,20 +229,16 @@ static void amd_set_speed(struct pci_dev *dev, unsigned char dn, struct ide_timi | |||
229 | } | 229 | } |
230 | 230 | ||
231 | /* | 231 | /* |
232 | * amd_set_drive() computes timing values configures the drive and | 232 | * amd_set_drive() computes timing values and configures the chipset |
233 | * the chipset to a desired transfer mode. It also can be called | 233 | * to a desired transfer mode. It also can be called by upper layers. |
234 | * by upper layers. | ||
235 | */ | 234 | */ |
236 | 235 | ||
237 | static int amd_set_drive(ide_drive_t *drive, const u8 speed) | 236 | static void amd_set_drive(ide_drive_t *drive, const u8 speed) |
238 | { | 237 | { |
239 | ide_drive_t *peer = HWIF(drive)->drives + (~drive->dn & 1); | 238 | ide_drive_t *peer = HWIF(drive)->drives + (~drive->dn & 1); |
240 | struct ide_timing t, p; | 239 | struct ide_timing t, p; |
241 | int T, UT; | 240 | int T, UT; |
242 | 241 | ||
243 | if (speed != XFER_PIO_SLOW) | ||
244 | ide_config_drive_speed(drive, speed); | ||
245 | |||
246 | T = 1000000000 / amd_clock; | 242 | T = 1000000000 / amd_clock; |
247 | UT = (amd_config->udma_mask == ATA_UDMA2) ? T : (T / 2); | 243 | UT = (amd_config->udma_mask == ATA_UDMA2) ? T : (T / 2); |
248 | 244 | ||
@@ -257,12 +253,6 @@ static int amd_set_drive(ide_drive_t *drive, const u8 speed) | |||
257 | if (speed == XFER_UDMA_6 && amd_clock <= 33333) t.udma = 15; | 253 | if (speed == XFER_UDMA_6 && amd_clock <= 33333) t.udma = 15; |
258 | 254 | ||
259 | amd_set_speed(HWIF(drive)->pci_dev, drive->dn, &t); | 255 | amd_set_speed(HWIF(drive)->pci_dev, drive->dn, &t); |
260 | |||
261 | if (!drive->init_speed) | ||
262 | drive->init_speed = speed; | ||
263 | drive->current_speed = speed; | ||
264 | |||
265 | return 0; | ||
266 | } | 256 | } |
267 | 257 | ||
268 | /* | 258 | /* |
@@ -399,7 +389,7 @@ static void __devinit init_hwif_amd74xx(ide_hwif_t *hwif) | |||
399 | hwif->autodma = 0; | 389 | hwif->autodma = 0; |
400 | 390 | ||
401 | hwif->set_pio_mode = &amd_set_pio_mode; | 391 | hwif->set_pio_mode = &amd_set_pio_mode; |
402 | hwif->speedproc = &amd_set_drive; | 392 | hwif->set_dma_mode = &amd_set_drive; |
403 | 393 | ||
404 | for (i = 0; i < 2; i++) { | 394 | for (i = 0; i < 2; i++) { |
405 | hwif->drives[i].io_32bit = 1; | 395 | hwif->drives[i].io_32bit = 1; |
@@ -441,7 +431,8 @@ static void __devinit init_hwif_amd74xx(ide_hwif_t *hwif) | |||
441 | .enablebits = {{0x40,0x02,0x02}, {0x40,0x01,0x01}}, \ | 431 | .enablebits = {{0x40,0x02,0x02}, {0x40,0x01,0x01}}, \ |
442 | .bootable = ON_BOARD, \ | 432 | .bootable = ON_BOARD, \ |
443 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST \ | 433 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST \ |
444 | | IDE_HFLAG_PIO_NO_DOWNGRADE, \ | 434 | | IDE_HFLAG_PIO_NO_DOWNGRADE \ |
435 | | IDE_HFLAG_POST_SET_MODE, \ | ||
445 | .pio_mask = ATA_PIO5, \ | 436 | .pio_mask = ATA_PIO5, \ |
446 | } | 437 | } |
447 | 438 | ||
@@ -454,7 +445,8 @@ static void __devinit init_hwif_amd74xx(ide_hwif_t *hwif) | |||
454 | .enablebits = {{0x50,0x02,0x02}, {0x50,0x01,0x01}}, \ | 445 | .enablebits = {{0x50,0x02,0x02}, {0x50,0x01,0x01}}, \ |
455 | .bootable = ON_BOARD, \ | 446 | .bootable = ON_BOARD, \ |
456 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST \ | 447 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST \ |
457 | | IDE_HFLAG_PIO_NO_DOWNGRADE, \ | 448 | | IDE_HFLAG_PIO_NO_DOWNGRADE \ |
449 | | IDE_HFLAG_POST_SET_MODE, \ | ||
458 | .pio_mask = ATA_PIO5, \ | 450 | .pio_mask = ATA_PIO5, \ |
459 | } | 451 | } |
460 | 452 | ||
diff --git a/drivers/ide/pci/atiixp.c b/drivers/ide/pci/atiixp.c index 178876a3afca..0eb97f021d39 100644 --- a/drivers/ide/pci/atiixp.c +++ b/drivers/ide/pci/atiixp.c | |||
@@ -122,14 +122,14 @@ static void atiixp_dma_host_off(ide_drive_t *drive) | |||
122 | } | 122 | } |
123 | 123 | ||
124 | /** | 124 | /** |
125 | * atiixp_tune_pio - tune a drive attached to a ATIIXP | 125 | * atiixp_set_pio_mode - set host controller for PIO mode |
126 | * @drive: drive to tune | 126 | * @drive: drive |
127 | * @pio: desired PIO mode | 127 | * @pio: PIO mode number |
128 | * | 128 | * |
129 | * Set the interface PIO mode. | 129 | * Set the interface PIO mode. |
130 | */ | 130 | */ |
131 | 131 | ||
132 | static void atiixp_tune_pio(ide_drive_t *drive, u8 pio) | 132 | static void atiixp_set_pio_mode(ide_drive_t *drive, const u8 pio) |
133 | { | 133 | { |
134 | struct pci_dev *dev = drive->hwif->pci_dev; | 134 | struct pci_dev *dev = drive->hwif->pci_dev; |
135 | unsigned long flags; | 135 | unsigned long flags; |
@@ -153,23 +153,16 @@ static void atiixp_tune_pio(ide_drive_t *drive, u8 pio) | |||
153 | spin_unlock_irqrestore(&atiixp_lock, flags); | 153 | spin_unlock_irqrestore(&atiixp_lock, flags); |
154 | } | 154 | } |
155 | 155 | ||
156 | static void atiixp_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
157 | { | ||
158 | atiixp_tune_pio(drive, pio); | ||
159 | (void)ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
160 | } | ||
161 | |||
162 | /** | 156 | /** |
163 | * atiixp_tune_chipset - tune a ATIIXP interface | 157 | * atiixp_set_dma_mode - set host controller for DMA mode |
164 | * @drive: IDE drive to tune | 158 | * @drive: drive |
165 | * @speed: speed to configure | 159 | * @speed: DMA mode |
166 | * | 160 | * |
167 | * Set a ATIIXP interface channel to the desired speeds. This involves | 161 | * Set a ATIIXP host controller to the desired DMA mode. This involves |
168 | * requires the right timing data into the ATIIXP configuration space | 162 | * programming the right timing data into the PCI configuration space. |
169 | * then setting the drive parameters appropriately | ||
170 | */ | 163 | */ |
171 | 164 | ||
172 | static int atiixp_speedproc(ide_drive_t *drive, const u8 speed) | 165 | static void atiixp_set_dma_mode(ide_drive_t *drive, const u8 speed) |
173 | { | 166 | { |
174 | struct pci_dev *dev = drive->hwif->pci_dev; | 167 | struct pci_dev *dev = drive->hwif->pci_dev; |
175 | unsigned long flags; | 168 | unsigned long flags; |
@@ -204,9 +197,7 @@ static int atiixp_speedproc(ide_drive_t *drive, const u8 speed) | |||
204 | else | 197 | else |
205 | pio = speed - XFER_PIO_0; | 198 | pio = speed - XFER_PIO_0; |
206 | 199 | ||
207 | atiixp_tune_pio(drive, pio); | 200 | atiixp_set_pio_mode(drive, pio); |
208 | |||
209 | return ide_config_drive_speed(drive, speed); | ||
210 | } | 201 | } |
211 | 202 | ||
212 | /** | 203 | /** |
@@ -249,7 +240,7 @@ static void __devinit init_hwif_atiixp(ide_hwif_t *hwif) | |||
249 | 240 | ||
250 | hwif->autodma = 0; | 241 | hwif->autodma = 0; |
251 | hwif->set_pio_mode = &atiixp_set_pio_mode; | 242 | hwif->set_pio_mode = &atiixp_set_pio_mode; |
252 | hwif->speedproc = &atiixp_speedproc; | 243 | hwif->set_dma_mode = &atiixp_set_dma_mode; |
253 | hwif->drives[0].autotune = 1; | 244 | hwif->drives[0].autotune = 1; |
254 | hwif->drives[1].autotune = 1; | 245 | hwif->drives[1].autotune = 1; |
255 | 246 | ||
diff --git a/drivers/ide/pci/cmd64x.c b/drivers/ide/pci/cmd64x.c index 0b568c60f926..d50f15e34b80 100644 --- a/drivers/ide/pci/cmd64x.c +++ b/drivers/ide/pci/cmd64x.c | |||
@@ -280,10 +280,9 @@ static void cmd64x_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
280 | return; | 280 | return; |
281 | 281 | ||
282 | cmd64x_tune_pio(drive, pio); | 282 | cmd64x_tune_pio(drive, pio); |
283 | (void) ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
284 | } | 283 | } |
285 | 284 | ||
286 | static int cmd64x_tune_chipset(ide_drive_t *drive, const u8 speed) | 285 | static void cmd64x_set_dma_mode(ide_drive_t *drive, const u8 speed) |
287 | { | 286 | { |
288 | ide_hwif_t *hwif = HWIF(drive); | 287 | ide_hwif_t *hwif = HWIF(drive); |
289 | struct pci_dev *dev = hwif->pci_dev; | 288 | struct pci_dev *dev = hwif->pci_dev; |
@@ -324,13 +323,11 @@ static int cmd64x_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
324 | program_cycle_times(drive, 480, 215); | 323 | program_cycle_times(drive, 480, 215); |
325 | break; | 324 | break; |
326 | default: | 325 | default: |
327 | return 1; | 326 | return; |
328 | } | 327 | } |
329 | 328 | ||
330 | if (speed >= XFER_SW_DMA_0) | 329 | if (speed >= XFER_SW_DMA_0) |
331 | (void) pci_write_config_byte(dev, pciU, regU); | 330 | (void) pci_write_config_byte(dev, pciU, regU); |
332 | |||
333 | return ide_config_drive_speed(drive, speed); | ||
334 | } | 331 | } |
335 | 332 | ||
336 | static int cmd64x_config_drive_for_dma (ide_drive_t *drive) | 333 | static int cmd64x_config_drive_for_dma (ide_drive_t *drive) |
@@ -524,7 +521,7 @@ static void __devinit init_hwif_cmd64x(ide_hwif_t *hwif) | |||
524 | pci_read_config_byte(dev, PCI_REVISION_ID, &rev); | 521 | pci_read_config_byte(dev, PCI_REVISION_ID, &rev); |
525 | 522 | ||
526 | hwif->set_pio_mode = &cmd64x_set_pio_mode; | 523 | hwif->set_pio_mode = &cmd64x_set_pio_mode; |
527 | hwif->speedproc = &cmd64x_tune_chipset; | 524 | hwif->set_dma_mode = &cmd64x_set_dma_mode; |
528 | 525 | ||
529 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; | 526 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; |
530 | 527 | ||
diff --git a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c index 1217d2a747fb..fbce90048aec 100644 --- a/drivers/ide/pci/cs5520.c +++ b/drivers/ide/pci/cs5520.c | |||
@@ -96,22 +96,13 @@ static void cs5520_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
96 | reg = inb(hwif->dma_base + 0x02 + 8*controller); | 96 | reg = inb(hwif->dma_base + 0x02 + 8*controller); |
97 | reg |= 1<<((drive->dn&1)+5); | 97 | reg |= 1<<((drive->dn&1)+5); |
98 | outb(reg, hwif->dma_base + 0x02 + 8*controller); | 98 | outb(reg, hwif->dma_base + 0x02 + 8*controller); |
99 | |||
100 | (void)ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
101 | } | 99 | } |
102 | 100 | ||
103 | static int cs5520_tune_chipset(ide_drive_t *drive, const u8 speed) | 101 | static void cs5520_set_dma_mode(ide_drive_t *drive, const u8 speed) |
104 | { | 102 | { |
105 | printk(KERN_ERR "cs55x0: bad ide timing.\n"); | 103 | printk(KERN_ERR "cs55x0: bad ide timing.\n"); |
106 | 104 | ||
107 | cs5520_set_pio_mode(drive, 0); | 105 | cs5520_set_pio_mode(drive, 0); |
108 | |||
109 | /* | ||
110 | * FIXME: this is incorrect to return zero here but | ||
111 | * since all users of ide_set_xfer_rate() ignore | ||
112 | * the return value it is not a problem currently | ||
113 | */ | ||
114 | return 0; | ||
115 | } | 106 | } |
116 | 107 | ||
117 | static int cs5520_config_drive_xfer_rate(ide_drive_t *drive) | 108 | static int cs5520_config_drive_xfer_rate(ide_drive_t *drive) |
@@ -150,26 +141,25 @@ static int cs5520_dma_on(ide_drive_t *drive) | |||
150 | static void __devinit init_hwif_cs5520(ide_hwif_t *hwif) | 141 | static void __devinit init_hwif_cs5520(ide_hwif_t *hwif) |
151 | { | 142 | { |
152 | hwif->set_pio_mode = &cs5520_set_pio_mode; | 143 | hwif->set_pio_mode = &cs5520_set_pio_mode; |
153 | hwif->speedproc = &cs5520_tune_chipset; | 144 | hwif->set_dma_mode = &cs5520_set_dma_mode; |
154 | hwif->ide_dma_check = &cs5520_config_drive_xfer_rate; | ||
155 | hwif->ide_dma_on = &cs5520_dma_on; | ||
156 | 145 | ||
157 | if(!noautodma) | 146 | if (hwif->dma_base == 0) { |
158 | hwif->autodma = 1; | 147 | hwif->drives[1].autotune = hwif->drives[0].autotune = 1; |
159 | |||
160 | if(!hwif->dma_base) | ||
161 | { | ||
162 | hwif->drives[0].autotune = 1; | ||
163 | hwif->drives[1].autotune = 1; | ||
164 | return; | 148 | return; |
165 | } | 149 | } |
166 | 150 | ||
151 | hwif->ide_dma_check = &cs5520_config_drive_xfer_rate; | ||
152 | hwif->ide_dma_on = &cs5520_dma_on; | ||
153 | |||
167 | /* ATAPI is harder so leave it for now */ | 154 | /* ATAPI is harder so leave it for now */ |
168 | hwif->atapi_dma = 0; | 155 | hwif->atapi_dma = 0; |
169 | hwif->ultra_mask = 0; | 156 | hwif->ultra_mask = 0; |
170 | hwif->swdma_mask = 0; | 157 | hwif->swdma_mask = 0; |
171 | hwif->mwdma_mask = 0; | 158 | hwif->mwdma_mask = 0; |
172 | 159 | ||
160 | if (!noautodma) | ||
161 | hwif->autodma = 1; | ||
162 | |||
173 | hwif->drives[0].autodma = hwif->autodma; | 163 | hwif->drives[0].autodma = hwif->autodma; |
174 | hwif->drives[1].autodma = hwif->autodma; | 164 | hwif->drives[1].autodma = hwif->autodma; |
175 | } | 165 | } |
diff --git a/drivers/ide/pci/cs5530.c b/drivers/ide/pci/cs5530.c index 741507b4cd93..e4121577cef0 100644 --- a/drivers/ide/pci/cs5530.c +++ b/drivers/ide/pci/cs5530.c | |||
@@ -30,22 +30,6 @@ | |||
30 | #include <asm/io.h> | 30 | #include <asm/io.h> |
31 | #include <asm/irq.h> | 31 | #include <asm/irq.h> |
32 | 32 | ||
33 | /** | ||
34 | * cs5530_xfer_set_mode - set a new transfer mode at the drive | ||
35 | * @drive: drive to tune | ||
36 | * @mode: new mode | ||
37 | * | ||
38 | * Logging wrapper to the IDE driver speed configuration. This can | ||
39 | * probably go away now. | ||
40 | */ | ||
41 | |||
42 | static int cs5530_set_xfer_mode (ide_drive_t *drive, u8 mode) | ||
43 | { | ||
44 | printk(KERN_DEBUG "%s: cs5530_set_xfer_mode(%s)\n", | ||
45 | drive->name, ide_xfer_verbose(mode)); | ||
46 | return (ide_config_drive_speed(drive, mode)); | ||
47 | } | ||
48 | |||
49 | /* | 33 | /* |
50 | * Here are the standard PIO mode 0-4 timings for each "format". | 34 | * Here are the standard PIO mode 0-4 timings for each "format". |
51 | * Format-0 uses fast data reg timings, with slower command reg timings. | 35 | * Format-0 uses fast data reg timings, with slower command reg timings. |
@@ -62,20 +46,12 @@ static unsigned int cs5530_pio_timings[2][5] = { | |||
62 | #define CS5530_BAD_PIO(timings) (((timings)&~0x80000000)==0x0000e132) | 46 | #define CS5530_BAD_PIO(timings) (((timings)&~0x80000000)==0x0000e132) |
63 | #define CS5530_BASEREG(hwif) (((hwif)->dma_base & ~0xf) + ((hwif)->channel ? 0x30 : 0x20)) | 47 | #define CS5530_BASEREG(hwif) (((hwif)->dma_base & ~0xf) + ((hwif)->channel ? 0x30 : 0x20)) |
64 | 48 | ||
65 | static void cs5530_tunepio(ide_drive_t *drive, u8 pio) | ||
66 | { | ||
67 | unsigned long basereg = CS5530_BASEREG(drive->hwif); | ||
68 | unsigned int format = (inl(basereg + 4) >> 31) & 1; | ||
69 | |||
70 | outl(cs5530_pio_timings[format][pio], basereg + ((drive->dn & 1)<<3)); | ||
71 | } | ||
72 | |||
73 | /** | 49 | /** |
74 | * cs5530_set_pio_mode - set PIO mode | 50 | * cs5530_set_pio_mode - set host controller for PIO mode |
75 | * @drive: drive | 51 | * @drive: drive |
76 | * @pio: PIO mode number | 52 | * @pio: PIO mode number |
77 | * | 53 | * |
78 | * Handles setting of PIO mode for both the chipset and drive. | 54 | * Handles setting of PIO mode for the chipset. |
79 | * | 55 | * |
80 | * The init_hwif_cs5530() routine guarantees that all drives | 56 | * The init_hwif_cs5530() routine guarantees that all drives |
81 | * will have valid default PIO timings set up before we get here. | 57 | * will have valid default PIO timings set up before we get here. |
@@ -83,8 +59,10 @@ static void cs5530_tunepio(ide_drive_t *drive, u8 pio) | |||
83 | 59 | ||
84 | static void cs5530_set_pio_mode(ide_drive_t *drive, const u8 pio) | 60 | static void cs5530_set_pio_mode(ide_drive_t *drive, const u8 pio) |
85 | { | 61 | { |
86 | if (cs5530_set_xfer_mode(drive, XFER_PIO_0 + pio) == 0) | 62 | unsigned long basereg = CS5530_BASEREG(drive->hwif); |
87 | cs5530_tunepio(drive, pio); | 63 | unsigned int format = (inl(basereg + 4) >> 31) & 1; |
64 | |||
65 | outl(cs5530_pio_timings[format][pio], basereg + ((drive->dn & 1)<<3)); | ||
88 | } | 66 | } |
89 | 67 | ||
90 | /** | 68 | /** |
@@ -142,20 +120,11 @@ static int cs5530_config_dma(ide_drive_t *drive) | |||
142 | return 1; | 120 | return 1; |
143 | } | 121 | } |
144 | 122 | ||
145 | static int cs5530_tune_chipset(ide_drive_t *drive, const u8 mode) | 123 | static void cs5530_set_dma_mode(ide_drive_t *drive, const u8 mode) |
146 | { | 124 | { |
147 | unsigned long basereg; | 125 | unsigned long basereg; |
148 | unsigned int reg, timings = 0; | 126 | unsigned int reg, timings = 0; |
149 | 127 | ||
150 | /* | ||
151 | * Tell the drive to switch to the new mode; abort on failure. | ||
152 | */ | ||
153 | if (cs5530_set_xfer_mode(drive, mode)) | ||
154 | return 1; /* failure */ | ||
155 | |||
156 | /* | ||
157 | * Now tune the chipset to match the drive: | ||
158 | */ | ||
159 | switch (mode) { | 128 | switch (mode) { |
160 | case XFER_UDMA_0: timings = 0x00921250; break; | 129 | case XFER_UDMA_0: timings = 0x00921250; break; |
161 | case XFER_UDMA_1: timings = 0x00911140; break; | 130 | case XFER_UDMA_1: timings = 0x00911140; break; |
@@ -180,8 +149,6 @@ static int cs5530_tune_chipset(ide_drive_t *drive, const u8 mode) | |||
180 | outl(reg, basereg + 4); /* write drive0 config register */ | 149 | outl(reg, basereg + 4); /* write drive0 config register */ |
181 | outl(timings, basereg + 12); /* write drive1 config register */ | 150 | outl(timings, basereg + 12); /* write drive1 config register */ |
182 | } | 151 | } |
183 | |||
184 | return 0; /* success */ | ||
185 | } | 152 | } |
186 | 153 | ||
187 | /** | 154 | /** |
@@ -299,7 +266,7 @@ static void __devinit init_hwif_cs5530 (ide_hwif_t *hwif) | |||
299 | hwif->serialized = hwif->mate->serialized = 1; | 266 | hwif->serialized = hwif->mate->serialized = 1; |
300 | 267 | ||
301 | hwif->set_pio_mode = &cs5530_set_pio_mode; | 268 | hwif->set_pio_mode = &cs5530_set_pio_mode; |
302 | hwif->speedproc = &cs5530_tune_chipset; | 269 | hwif->set_dma_mode = &cs5530_set_dma_mode; |
303 | 270 | ||
304 | basereg = CS5530_BASEREG(hwif); | 271 | basereg = CS5530_BASEREG(hwif); |
305 | d0_timings = inl(basereg + 0); | 272 | d0_timings = inl(basereg + 0); |
@@ -340,6 +307,7 @@ static ide_pci_device_t cs5530_chipset __devinitdata = { | |||
340 | .autodma = AUTODMA, | 307 | .autodma = AUTODMA, |
341 | .bootable = ON_BOARD, | 308 | .bootable = ON_BOARD, |
342 | .pio_mask = ATA_PIO4, | 309 | .pio_mask = ATA_PIO4, |
310 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
343 | }; | 311 | }; |
344 | 312 | ||
345 | static int __devinit cs5530_init_one(struct pci_dev *dev, const struct pci_device_id *id) | 313 | static int __devinit cs5530_init_one(struct pci_dev *dev, const struct pci_device_id *id) |
diff --git a/drivers/ide/pci/cs5535.c b/drivers/ide/pci/cs5535.c index 383b7eccbcbb..257865778f92 100644 --- a/drivers/ide/pci/cs5535.c +++ b/drivers/ide/pci/cs5535.c | |||
@@ -131,24 +131,21 @@ static void cs5535_set_speed(ide_drive_t *drive, const u8 speed) | |||
131 | } | 131 | } |
132 | } | 132 | } |
133 | 133 | ||
134 | /**** | 134 | /** |
135 | * cs5535_set_drive - Configure the drive to the new speed | 135 | * cs5535_set_dma_mode - set host controller for DMA mode |
136 | * @drive: Drive to set up | 136 | * @drive: drive |
137 | * @speed: desired speed | 137 | * @speed: DMA mode |
138 | * | 138 | * |
139 | * cs5535_set_drive() configures the drive and the chipset to a | 139 | * Programs the chipset for DMA mode. |
140 | * new speed. It also can be called by upper layers. | ||
141 | */ | 140 | */ |
142 | static int cs5535_set_drive(ide_drive_t *drive, u8 speed) | 141 | |
142 | static void cs5535_set_dma_mode(ide_drive_t *drive, const u8 speed) | ||
143 | { | 143 | { |
144 | ide_config_drive_speed(drive, speed); | ||
145 | cs5535_set_speed(drive, speed); | 144 | cs5535_set_speed(drive, speed); |
146 | |||
147 | return 0; | ||
148 | } | 145 | } |
149 | 146 | ||
150 | /** | 147 | /** |
151 | * cs5535_set_pio_mode - PIO setup | 148 | * cs5535_set_pio_mode - set host controller for PIO mode |
152 | * @drive: drive | 149 | * @drive: drive |
153 | * @pio: PIO mode number | 150 | * @pio: PIO mode number |
154 | * | 151 | * |
@@ -157,7 +154,6 @@ static int cs5535_set_drive(ide_drive_t *drive, u8 speed) | |||
157 | 154 | ||
158 | static void cs5535_set_pio_mode(ide_drive_t *drive, const u8 pio) | 155 | static void cs5535_set_pio_mode(ide_drive_t *drive, const u8 pio) |
159 | { | 156 | { |
160 | ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
161 | cs5535_set_speed(drive, XFER_PIO_0 + pio); | 157 | cs5535_set_speed(drive, XFER_PIO_0 + pio); |
162 | } | 158 | } |
163 | 159 | ||
@@ -194,12 +190,16 @@ static u8 __devinit cs5535_cable_detect(struct pci_dev *dev) | |||
194 | */ | 190 | */ |
195 | static void __devinit init_hwif_cs5535(ide_hwif_t *hwif) | 191 | static void __devinit init_hwif_cs5535(ide_hwif_t *hwif) |
196 | { | 192 | { |
197 | int i; | ||
198 | |||
199 | hwif->autodma = 0; | 193 | hwif->autodma = 0; |
200 | 194 | ||
201 | hwif->set_pio_mode = &cs5535_set_pio_mode; | 195 | hwif->set_pio_mode = &cs5535_set_pio_mode; |
202 | hwif->speedproc = &cs5535_set_drive; | 196 | hwif->set_dma_mode = &cs5535_set_dma_mode; |
197 | |||
198 | hwif->drives[1].autotune = hwif->drives[0].autotune = 1; | ||
199 | |||
200 | if (hwif->dma_base == 0) | ||
201 | return; | ||
202 | |||
203 | hwif->ide_dma_check = &cs5535_dma_check; | 203 | hwif->ide_dma_check = &cs5535_dma_check; |
204 | 204 | ||
205 | hwif->atapi_dma = 1; | 205 | hwif->atapi_dma = 1; |
@@ -211,11 +211,7 @@ static void __devinit init_hwif_cs5535(ide_hwif_t *hwif) | |||
211 | if (!noautodma) | 211 | if (!noautodma) |
212 | hwif->autodma = 1; | 212 | hwif->autodma = 1; |
213 | 213 | ||
214 | /* just setting autotune and not worrying about bios timings */ | 214 | hwif->drives[1].autodma = hwif->drives[0].autodma = hwif->autodma; |
215 | for (i = 0; i < 2; i++) { | ||
216 | hwif->drives[i].autotune = 1; | ||
217 | hwif->drives[i].autodma = hwif->autodma; | ||
218 | } | ||
219 | } | 215 | } |
220 | 216 | ||
221 | static ide_pci_device_t cs5535_chipset __devinitdata = { | 217 | static ide_pci_device_t cs5535_chipset __devinitdata = { |
@@ -223,7 +219,7 @@ static ide_pci_device_t cs5535_chipset __devinitdata = { | |||
223 | .init_hwif = init_hwif_cs5535, | 219 | .init_hwif = init_hwif_cs5535, |
224 | .autodma = AUTODMA, | 220 | .autodma = AUTODMA, |
225 | .bootable = ON_BOARD, | 221 | .bootable = ON_BOARD, |
226 | .host_flags = IDE_HFLAG_SINGLE, | 222 | .host_flags = IDE_HFLAG_SINGLE | IDE_HFLAG_POST_SET_MODE, |
227 | .pio_mask = ATA_PIO4, | 223 | .pio_mask = ATA_PIO4, |
228 | }; | 224 | }; |
229 | 225 | ||
diff --git a/drivers/ide/pci/hpt34x.c b/drivers/ide/pci/hpt34x.c index a1bb10188fe5..218852aaf22a 100644 --- a/drivers/ide/pci/hpt34x.c +++ b/drivers/ide/pci/hpt34x.c | |||
@@ -43,7 +43,7 @@ | |||
43 | 43 | ||
44 | #define HPT343_DEBUG_DRIVE_INFO 0 | 44 | #define HPT343_DEBUG_DRIVE_INFO 0 |
45 | 45 | ||
46 | static int hpt34x_tune_chipset(ide_drive_t *drive, const u8 speed) | 46 | static void hpt34x_set_mode(ide_drive_t *drive, const u8 speed) |
47 | { | 47 | { |
48 | struct pci_dev *dev = HWIF(drive)->pci_dev; | 48 | struct pci_dev *dev = HWIF(drive)->pci_dev; |
49 | u32 reg1= 0, tmp1 = 0, reg2 = 0, tmp2 = 0; | 49 | u32 reg1= 0, tmp1 = 0, reg2 = 0, tmp2 = 0; |
@@ -73,13 +73,11 @@ static int hpt34x_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
73 | drive->dn, reg1, tmp1, reg2, tmp2, | 73 | drive->dn, reg1, tmp1, reg2, tmp2, |
74 | hi_speed, lo_speed); | 74 | hi_speed, lo_speed); |
75 | #endif /* HPT343_DEBUG_DRIVE_INFO */ | 75 | #endif /* HPT343_DEBUG_DRIVE_INFO */ |
76 | |||
77 | return(ide_config_drive_speed(drive, speed)); | ||
78 | } | 76 | } |
79 | 77 | ||
80 | static void hpt34x_set_pio_mode(ide_drive_t *drive, const u8 pio) | 78 | static void hpt34x_set_pio_mode(ide_drive_t *drive, const u8 pio) |
81 | { | 79 | { |
82 | (void) hpt34x_tune_chipset(drive, (XFER_PIO_0 + pio)); | 80 | hpt34x_set_mode(drive, XFER_PIO_0 + pio); |
83 | } | 81 | } |
84 | 82 | ||
85 | static int hpt34x_config_drive_xfer_rate (ide_drive_t *drive) | 83 | static int hpt34x_config_drive_xfer_rate (ide_drive_t *drive) |
@@ -145,7 +143,8 @@ static void __devinit init_hwif_hpt34x(ide_hwif_t *hwif) | |||
145 | hwif->autodma = 0; | 143 | hwif->autodma = 0; |
146 | 144 | ||
147 | hwif->set_pio_mode = &hpt34x_set_pio_mode; | 145 | hwif->set_pio_mode = &hpt34x_set_pio_mode; |
148 | hwif->speedproc = &hpt34x_tune_chipset; | 146 | hwif->set_dma_mode = &hpt34x_set_mode; |
147 | |||
149 | hwif->drives[0].autotune = 1; | 148 | hwif->drives[0].autotune = 1; |
150 | hwif->drives[1].autotune = 1; | 149 | hwif->drives[1].autotune = 1; |
151 | 150 | ||
diff --git a/drivers/ide/pci/hpt366.c b/drivers/ide/pci/hpt366.c index 0e7d3b60d43c..8812a9bb032f 100644 --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c | |||
@@ -600,7 +600,7 @@ static u32 get_speed_setting(u8 speed, struct hpt_info *info) | |||
600 | return (*info->settings)[i]; | 600 | return (*info->settings)[i]; |
601 | } | 601 | } |
602 | 602 | ||
603 | static int hpt36x_tune_chipset(ide_drive_t *drive, const u8 speed) | 603 | static void hpt36x_set_mode(ide_drive_t *drive, const u8 speed) |
604 | { | 604 | { |
605 | ide_hwif_t *hwif = HWIF(drive); | 605 | ide_hwif_t *hwif = HWIF(drive); |
606 | struct pci_dev *dev = hwif->pci_dev; | 606 | struct pci_dev *dev = hwif->pci_dev; |
@@ -623,11 +623,9 @@ static int hpt36x_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
623 | new_itr &= ~0xc0000000; | 623 | new_itr &= ~0xc0000000; |
624 | 624 | ||
625 | pci_write_config_dword(dev, itr_addr, new_itr); | 625 | pci_write_config_dword(dev, itr_addr, new_itr); |
626 | |||
627 | return ide_config_drive_speed(drive, speed); | ||
628 | } | 626 | } |
629 | 627 | ||
630 | static int hpt37x_tune_chipset(ide_drive_t *drive, const u8 speed) | 628 | static void hpt37x_set_mode(ide_drive_t *drive, const u8 speed) |
631 | { | 629 | { |
632 | ide_hwif_t *hwif = HWIF(drive); | 630 | ide_hwif_t *hwif = HWIF(drive); |
633 | struct pci_dev *dev = hwif->pci_dev; | 631 | struct pci_dev *dev = hwif->pci_dev; |
@@ -647,24 +645,22 @@ static int hpt37x_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
647 | if (speed < XFER_MW_DMA_0) | 645 | if (speed < XFER_MW_DMA_0) |
648 | new_itr &= ~0x80000000; /* Disable on-chip PIO FIFO/buffer */ | 646 | new_itr &= ~0x80000000; /* Disable on-chip PIO FIFO/buffer */ |
649 | pci_write_config_dword(dev, itr_addr, new_itr); | 647 | pci_write_config_dword(dev, itr_addr, new_itr); |
650 | |||
651 | return ide_config_drive_speed(drive, speed); | ||
652 | } | 648 | } |
653 | 649 | ||
654 | static int hpt3xx_tune_chipset(ide_drive_t *drive, u8 speed) | 650 | static void hpt3xx_set_mode(ide_drive_t *drive, const u8 speed) |
655 | { | 651 | { |
656 | ide_hwif_t *hwif = HWIF(drive); | 652 | ide_hwif_t *hwif = HWIF(drive); |
657 | struct hpt_info *info = pci_get_drvdata(hwif->pci_dev); | 653 | struct hpt_info *info = pci_get_drvdata(hwif->pci_dev); |
658 | 654 | ||
659 | if (info->chip_type >= HPT370) | 655 | if (info->chip_type >= HPT370) |
660 | return hpt37x_tune_chipset(drive, speed); | 656 | hpt37x_set_mode(drive, speed); |
661 | else /* hpt368: hpt_minimum_revision(dev, 2) */ | 657 | else /* hpt368: hpt_minimum_revision(dev, 2) */ |
662 | return hpt36x_tune_chipset(drive, speed); | 658 | hpt36x_set_mode(drive, speed); |
663 | } | 659 | } |
664 | 660 | ||
665 | static void hpt3xx_set_pio_mode(ide_drive_t *drive, const u8 pio) | 661 | static void hpt3xx_set_pio_mode(ide_drive_t *drive, const u8 pio) |
666 | { | 662 | { |
667 | (void) hpt3xx_tune_chipset (drive, XFER_PIO_0 + pio); | 663 | hpt3xx_set_mode(drive, XFER_PIO_0 + pio); |
668 | } | 664 | } |
669 | 665 | ||
670 | static int hpt3xx_quirkproc(ide_drive_t *drive) | 666 | static int hpt3xx_quirkproc(ide_drive_t *drive) |
@@ -1257,7 +1253,7 @@ static void __devinit init_hwif_hpt366(ide_hwif_t *hwif) | |||
1257 | hwif->select_data = hwif->channel ? 0x54 : 0x50; | 1253 | hwif->select_data = hwif->channel ? 0x54 : 0x50; |
1258 | 1254 | ||
1259 | hwif->set_pio_mode = &hpt3xx_set_pio_mode; | 1255 | hwif->set_pio_mode = &hpt3xx_set_pio_mode; |
1260 | hwif->speedproc = &hpt3xx_tune_chipset; | 1256 | hwif->set_dma_mode = &hpt3xx_set_mode; |
1261 | hwif->quirkproc = &hpt3xx_quirkproc; | 1257 | hwif->quirkproc = &hpt3xx_quirkproc; |
1262 | hwif->intrproc = &hpt3xx_intrproc; | 1258 | hwif->intrproc = &hpt3xx_intrproc; |
1263 | hwif->maskproc = &hpt3xx_maskproc; | 1259 | hwif->maskproc = &hpt3xx_maskproc; |
diff --git a/drivers/ide/pci/it8213.c b/drivers/ide/pci/it8213.c index 76e91ff9420b..ecf4ce078dce 100644 --- a/drivers/ide/pci/it8213.c +++ b/drivers/ide/pci/it8213.c | |||
@@ -48,15 +48,15 @@ static u8 it8213_dma_2_pio (u8 xfer_rate) { | |||
48 | } | 48 | } |
49 | } | 49 | } |
50 | 50 | ||
51 | /* | 51 | /** |
52 | * it8213_tune_pio - tune a drive | 52 | * it8213_set_pio_mode - set host controller for PIO mode |
53 | * @drive: drive to tune | 53 | * @drive: drive |
54 | * @pio: desired PIO mode | 54 | * @pio: PIO mode number |
55 | * | 55 | * |
56 | * Set the interface PIO mode. | 56 | * Set the interface PIO mode. |
57 | */ | 57 | */ |
58 | 58 | ||
59 | static void it8213_tune_pio(ide_drive_t *drive, const u8 pio) | 59 | static void it8213_set_pio_mode(ide_drive_t *drive, const u8 pio) |
60 | { | 60 | { |
61 | ide_hwif_t *hwif = HWIF(drive); | 61 | ide_hwif_t *hwif = HWIF(drive); |
62 | struct pci_dev *dev = hwif->pci_dev; | 62 | struct pci_dev *dev = hwif->pci_dev; |
@@ -105,21 +105,15 @@ static void it8213_tune_pio(ide_drive_t *drive, const u8 pio) | |||
105 | spin_unlock_irqrestore(&tune_lock, flags); | 105 | spin_unlock_irqrestore(&tune_lock, flags); |
106 | } | 106 | } |
107 | 107 | ||
108 | static void it8213_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
109 | { | ||
110 | it8213_tune_pio(drive, pio); | ||
111 | ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
112 | } | ||
113 | |||
114 | /** | 108 | /** |
115 | * it8213_tune_chipset - set controller timings | 109 | * it8213_set_dma_mode - set host controller for DMA mode |
116 | * @drive: Drive to set up | 110 | * @drive: drive |
117 | * @speed: speed we want to achieve | 111 | * @speed: DMA mode |
118 | * | 112 | * |
119 | * Tune the ITE chipset for the desired mode. | 113 | * Tune the ITE chipset for the DMA mode. |
120 | */ | 114 | */ |
121 | 115 | ||
122 | static int it8213_tune_chipset(ide_drive_t *drive, const u8 speed) | 116 | static void it8213_set_dma_mode(ide_drive_t *drive, const u8 speed) |
123 | { | 117 | { |
124 | ide_hwif_t *hwif = HWIF(drive); | 118 | ide_hwif_t *hwif = HWIF(drive); |
125 | struct pci_dev *dev = hwif->pci_dev; | 119 | struct pci_dev *dev = hwif->pci_dev; |
@@ -152,7 +146,7 @@ static int it8213_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
152 | case XFER_SW_DMA_2: | 146 | case XFER_SW_DMA_2: |
153 | break; | 147 | break; |
154 | default: | 148 | default: |
155 | return -1; | 149 | return; |
156 | } | 150 | } |
157 | 151 | ||
158 | if (speed >= XFER_UDMA_0) { | 152 | if (speed >= XFER_UDMA_0) { |
@@ -182,9 +176,7 @@ static int it8213_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
182 | pci_write_config_byte(dev, 0x55, (u8) reg55 & ~w_flag); | 176 | pci_write_config_byte(dev, 0x55, (u8) reg55 & ~w_flag); |
183 | } | 177 | } |
184 | 178 | ||
185 | it8213_tune_pio(drive, it8213_dma_2_pio(speed)); | 179 | it8213_set_pio_mode(drive, it8213_dma_2_pio(speed)); |
186 | |||
187 | return ide_config_drive_speed(drive, speed); | ||
188 | } | 180 | } |
189 | 181 | ||
190 | /** | 182 | /** |
@@ -220,7 +212,7 @@ static void __devinit init_hwif_it8213(ide_hwif_t *hwif) | |||
220 | { | 212 | { |
221 | u8 reg42h = 0; | 213 | u8 reg42h = 0; |
222 | 214 | ||
223 | hwif->speedproc = &it8213_tune_chipset; | 215 | hwif->set_dma_mode = &it8213_set_dma_mode; |
224 | hwif->set_pio_mode = &it8213_set_pio_mode; | 216 | hwif->set_pio_mode = &it8213_set_pio_mode; |
225 | 217 | ||
226 | hwif->autodma = 0; | 218 | hwif->autodma = 0; |
diff --git a/drivers/ide/pci/it821x.c b/drivers/ide/pci/it821x.c index 758a98230cc5..1b69d82478c6 100644 --- a/drivers/ide/pci/it821x.c +++ b/drivers/ide/pci/it821x.c | |||
@@ -229,24 +229,24 @@ static void it821x_clock_strategy(ide_drive_t *drive) | |||
229 | } | 229 | } |
230 | 230 | ||
231 | /** | 231 | /** |
232 | * it821x_tunepio - tune a drive | 232 | * it821x_set_pio_mode - set host controller for PIO mode |
233 | * @drive: drive to tune | 233 | * @drive: drive |
234 | * @pio: the desired PIO mode | 234 | * @pio: PIO mode number |
235 | * | 235 | * |
236 | * Try to tune the drive/host to the desired PIO mode taking into | 236 | * Tune the host to the desired PIO mode taking into the consideration |
237 | * the consideration the maximum PIO mode supported by the other | 237 | * the maximum PIO mode supported by the other device on the cable. |
238 | * device on the cable. | ||
239 | */ | 238 | */ |
240 | 239 | ||
241 | static int it821x_tunepio(ide_drive_t *drive, u8 set_pio) | 240 | static void it821x_set_pio_mode(ide_drive_t *drive, const u8 pio) |
242 | { | 241 | { |
243 | ide_hwif_t *hwif = drive->hwif; | 242 | ide_hwif_t *hwif = drive->hwif; |
244 | struct it821x_dev *itdev = ide_get_hwifdata(hwif); | 243 | struct it821x_dev *itdev = ide_get_hwifdata(hwif); |
245 | int unit = drive->select.b.unit; | 244 | int unit = drive->select.b.unit; |
246 | ide_drive_t *pair = &hwif->drives[1 - unit]; | 245 | ide_drive_t *pair = &hwif->drives[1 - unit]; |
246 | u8 set_pio = pio; | ||
247 | 247 | ||
248 | /* Spec says 89 ref driver uses 88 */ | 248 | /* Spec says 89 ref driver uses 88 */ |
249 | static u16 pio[] = { 0xAA88, 0xA382, 0xA181, 0x3332, 0x3121 }; | 249 | static u16 pio_timings[]= { 0xAA88, 0xA382, 0xA181, 0x3332, 0x3121 }; |
250 | static u8 pio_want[] = { ATA_66, ATA_66, ATA_66, ATA_66, ATA_ANY }; | 250 | static u8 pio_want[] = { ATA_66, ATA_66, ATA_66, ATA_66, ATA_ANY }; |
251 | 251 | ||
252 | /* | 252 | /* |
@@ -261,22 +261,12 @@ static int it821x_tunepio(ide_drive_t *drive, u8 set_pio) | |||
261 | set_pio = pair_pio; | 261 | set_pio = pair_pio; |
262 | } | 262 | } |
263 | 263 | ||
264 | if (itdev->smart) | ||
265 | return 0; | ||
266 | |||
267 | /* We prefer 66Mhz clock for PIO 0-3, don't care for PIO4 */ | 264 | /* We prefer 66Mhz clock for PIO 0-3, don't care for PIO4 */ |
268 | itdev->want[unit][1] = pio_want[set_pio]; | 265 | itdev->want[unit][1] = pio_want[set_pio]; |
269 | itdev->want[unit][0] = 1; /* PIO is lowest priority */ | 266 | itdev->want[unit][0] = 1; /* PIO is lowest priority */ |
270 | itdev->pio[unit] = pio[set_pio]; | 267 | itdev->pio[unit] = pio_timings[set_pio]; |
271 | it821x_clock_strategy(drive); | 268 | it821x_clock_strategy(drive); |
272 | it821x_program(drive, itdev->pio[unit]); | 269 | it821x_program(drive, itdev->pio[unit]); |
273 | |||
274 | return ide_config_drive_speed(drive, XFER_PIO_0 + set_pio); | ||
275 | } | ||
276 | |||
277 | static void it821x_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
278 | { | ||
279 | (void)it821x_tunepio(drive, pio); | ||
280 | } | 270 | } |
281 | 271 | ||
282 | /** | 272 | /** |
@@ -405,47 +395,24 @@ static int it821x_dma_end(ide_drive_t *drive) | |||
405 | } | 395 | } |
406 | 396 | ||
407 | /** | 397 | /** |
408 | * it821x_tune_chipset - set controller timings | 398 | * it821x_set_dma_mode - set host controller for DMA mode |
409 | * @drive: Drive to set up | 399 | * @drive: drive |
410 | * @speed: speed we want to achieve | 400 | * @speed: DMA mode |
411 | * | 401 | * |
412 | * Tune the ITE chipset for the desired mode. | 402 | * Tune the ITE chipset for the desired DMA mode. |
413 | */ | 403 | */ |
414 | 404 | ||
415 | static int it821x_tune_chipset(ide_drive_t *drive, const u8 speed) | 405 | static void it821x_set_dma_mode(ide_drive_t *drive, const u8 speed) |
416 | { | 406 | { |
417 | 407 | /* | |
418 | ide_hwif_t *hwif = drive->hwif; | 408 | * MWDMA tuning is really hard because our MWDMA and PIO |
419 | struct it821x_dev *itdev = ide_get_hwifdata(hwif); | 409 | * timings are kept in the same place. We can switch in the |
420 | 410 | * host dma on/off callbacks. | |
421 | if (itdev->smart == 0) { | 411 | */ |
422 | switch (speed) { | 412 | if (speed >= XFER_UDMA_0 && speed <= XFER_UDMA_6) |
423 | /* MWDMA tuning is really hard because our MWDMA and PIO | 413 | it821x_tune_udma(drive, speed - XFER_UDMA_0); |
424 | timings are kept in the same place. We can switch in the | 414 | else if (speed >= XFER_MW_DMA_0 && speed <= XFER_MW_DMA_2) |
425 | host dma on/off callbacks */ | 415 | it821x_tune_mwdma(drive, speed - XFER_MW_DMA_0); |
426 | case XFER_MW_DMA_2: | ||
427 | case XFER_MW_DMA_1: | ||
428 | case XFER_MW_DMA_0: | ||
429 | it821x_tune_mwdma(drive, (speed - XFER_MW_DMA_0)); | ||
430 | break; | ||
431 | case XFER_UDMA_6: | ||
432 | case XFER_UDMA_5: | ||
433 | case XFER_UDMA_4: | ||
434 | case XFER_UDMA_3: | ||
435 | case XFER_UDMA_2: | ||
436 | case XFER_UDMA_1: | ||
437 | case XFER_UDMA_0: | ||
438 | it821x_tune_udma(drive, (speed - XFER_UDMA_0)); | ||
439 | break; | ||
440 | default: | ||
441 | return 1; | ||
442 | } | ||
443 | |||
444 | return ide_config_drive_speed(drive, speed); | ||
445 | } | ||
446 | |||
447 | /* don't touch anything in the smart mode */ | ||
448 | return 0; | ||
449 | } | 416 | } |
450 | 417 | ||
451 | /** | 418 | /** |
@@ -629,14 +596,15 @@ static void __devinit init_hwif_it821x(ide_hwif_t *hwif) | |||
629 | printk(KERN_WARNING "it821x: Revision 0x10, workarounds activated.\n"); | 596 | printk(KERN_WARNING "it821x: Revision 0x10, workarounds activated.\n"); |
630 | } | 597 | } |
631 | 598 | ||
632 | hwif->speedproc = &it821x_tune_chipset; | 599 | if (idev->smart == 0) { |
633 | hwif->set_pio_mode = &it821x_set_pio_mode; | 600 | hwif->set_pio_mode = &it821x_set_pio_mode; |
601 | hwif->set_dma_mode = &it821x_set_dma_mode; | ||
634 | 602 | ||
635 | /* MWDMA/PIO clock switching for pass through mode */ | 603 | /* MWDMA/PIO clock switching for pass through mode */ |
636 | if(!idev->smart) { | ||
637 | hwif->dma_start = &it821x_dma_start; | 604 | hwif->dma_start = &it821x_dma_start; |
638 | hwif->ide_dma_end = &it821x_dma_end; | 605 | hwif->ide_dma_end = &it821x_dma_end; |
639 | } | 606 | } else |
607 | hwif->host_flags |= IDE_HFLAG_NO_SET_MODE; | ||
640 | 608 | ||
641 | hwif->drives[0].autotune = 1; | 609 | hwif->drives[0].autotune = 1; |
642 | hwif->drives[1].autotune = 1; | 610 | hwif->drives[1].autotune = 1; |
diff --git a/drivers/ide/pci/jmicron.c b/drivers/ide/pci/jmicron.c index d379fbaf6743..582b4cae2b53 100644 --- a/drivers/ide/pci/jmicron.c +++ b/drivers/ide/pci/jmicron.c | |||
@@ -85,21 +85,18 @@ static u8 __devinit ata66_jmicron(ide_hwif_t *hwif) | |||
85 | 85 | ||
86 | static void jmicron_set_pio_mode(ide_drive_t *drive, const u8 pio) | 86 | static void jmicron_set_pio_mode(ide_drive_t *drive, const u8 pio) |
87 | { | 87 | { |
88 | ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
89 | } | 88 | } |
90 | 89 | ||
91 | /** | 90 | /** |
92 | * jmicron_tune_chipset - set controller timings | 91 | * jmicron_set_dma_mode - set host controller for DMA mode |
93 | * @drive: Drive to set up | 92 | * @drive: drive |
94 | * @speed: speed we want to achieve | 93 | * @mode: DMA mode |
95 | * | 94 | * |
96 | * As the JMicron snoops for timings all we actually need to do is | 95 | * As the JMicron snoops for timings we don't need to do anything here. |
97 | * set the transfer mode on the device. | ||
98 | */ | 96 | */ |
99 | 97 | ||
100 | static int jmicron_tune_chipset(ide_drive_t *drive, const u8 speed) | 98 | static void jmicron_set_dma_mode(ide_drive_t *drive, const u8 mode) |
101 | { | 99 | { |
102 | return ide_config_drive_speed(drive, speed); | ||
103 | } | 100 | } |
104 | 101 | ||
105 | /** | 102 | /** |
@@ -129,8 +126,8 @@ static int jmicron_config_drive_for_dma (ide_drive_t *drive) | |||
129 | 126 | ||
130 | static void __devinit init_hwif_jmicron(ide_hwif_t *hwif) | 127 | static void __devinit init_hwif_jmicron(ide_hwif_t *hwif) |
131 | { | 128 | { |
132 | hwif->speedproc = &jmicron_tune_chipset; | ||
133 | hwif->set_pio_mode = &jmicron_set_pio_mode; | 129 | hwif->set_pio_mode = &jmicron_set_pio_mode; |
130 | hwif->set_dma_mode = &jmicron_set_dma_mode; | ||
134 | 131 | ||
135 | hwif->drives[0].autotune = 1; | 132 | hwif->drives[0].autotune = 1; |
136 | hwif->drives[1].autotune = 1; | 133 | hwif->drives[1].autotune = 1; |
diff --git a/drivers/ide/pci/pdc202xx_new.c b/drivers/ide/pci/pdc202xx_new.c index 5fb1eedc8194..ad0bdcb0c02b 100644 --- a/drivers/ide/pci/pdc202xx_new.c +++ b/drivers/ide/pci/pdc202xx_new.c | |||
@@ -146,19 +146,16 @@ static struct udma_timing { | |||
146 | { 0x1a, 0x01, 0xcb }, /* UDMA mode 6 */ | 146 | { 0x1a, 0x01, 0xcb }, /* UDMA mode 6 */ |
147 | }; | 147 | }; |
148 | 148 | ||
149 | static int pdcnew_tune_chipset(ide_drive_t *drive, const u8 speed) | 149 | static void pdcnew_set_mode(ide_drive_t *drive, const u8 speed) |
150 | { | 150 | { |
151 | ide_hwif_t *hwif = HWIF(drive); | 151 | ide_hwif_t *hwif = HWIF(drive); |
152 | u8 adj = (drive->dn & 1) ? 0x08 : 0x00; | 152 | u8 adj = (drive->dn & 1) ? 0x08 : 0x00; |
153 | int err; | ||
154 | 153 | ||
155 | /* | 154 | /* |
156 | * Issue SETFEATURES_XFER to the drive first. PDC202xx hardware will | 155 | * IDE core issues SETFEATURES_XFER to the drive first (thanks to |
156 | * IDE_HFLAG_POST_SET_MODE in ->host_flags). PDC202xx hardware will | ||
157 | * automatically set the timing registers based on 100 MHz PLL output. | 157 | * automatically set the timing registers based on 100 MHz PLL output. |
158 | */ | 158 | * |
159 | err = ide_config_drive_speed(drive, speed); | ||
160 | |||
161 | /* | ||
162 | * As we set up the PLL to output 133 MHz for UltraDMA/133 capable | 159 | * As we set up the PLL to output 133 MHz for UltraDMA/133 capable |
163 | * chips, we must override the default register settings... | 160 | * chips, we must override the default register settings... |
164 | */ | 161 | */ |
@@ -211,13 +208,11 @@ static int pdcnew_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
211 | 208 | ||
212 | set_indexed_reg(hwif, 0x10 + adj, tmp & 0x7f); | 209 | set_indexed_reg(hwif, 0x10 + adj, tmp & 0x7f); |
213 | } | 210 | } |
214 | |||
215 | return err; | ||
216 | } | 211 | } |
217 | 212 | ||
218 | static void pdcnew_set_pio_mode(ide_drive_t *drive, const u8 pio) | 213 | static void pdcnew_set_pio_mode(ide_drive_t *drive, const u8 pio) |
219 | { | 214 | { |
220 | (void)pdcnew_tune_chipset(drive, XFER_PIO_0 + pio); | 215 | pdcnew_set_mode(drive, XFER_PIO_0 + pio); |
221 | } | 216 | } |
222 | 217 | ||
223 | static u8 pdcnew_cable_detect(ide_hwif_t *hwif) | 218 | static u8 pdcnew_cable_detect(ide_hwif_t *hwif) |
@@ -490,9 +485,9 @@ static void __devinit init_hwif_pdc202new(ide_hwif_t *hwif) | |||
490 | hwif->autodma = 0; | 485 | hwif->autodma = 0; |
491 | 486 | ||
492 | hwif->set_pio_mode = &pdcnew_set_pio_mode; | 487 | hwif->set_pio_mode = &pdcnew_set_pio_mode; |
488 | hwif->set_dma_mode = &pdcnew_set_mode; | ||
493 | 489 | ||
494 | hwif->quirkproc = &pdcnew_quirkproc; | 490 | hwif->quirkproc = &pdcnew_quirkproc; |
495 | hwif->speedproc = &pdcnew_tune_chipset; | ||
496 | hwif->resetproc = &pdcnew_reset; | 491 | hwif->resetproc = &pdcnew_reset; |
497 | 492 | ||
498 | hwif->err_stops_fifo = 1; | 493 | hwif->err_stops_fifo = 1; |
@@ -583,6 +578,7 @@ static ide_pci_device_t pdcnew_chipsets[] __devinitdata = { | |||
583 | .bootable = OFF_BOARD, | 578 | .bootable = OFF_BOARD, |
584 | .pio_mask = ATA_PIO4, | 579 | .pio_mask = ATA_PIO4, |
585 | .udma_mask = 0x3f, /* udma0-5 */ | 580 | .udma_mask = 0x3f, /* udma0-5 */ |
581 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
586 | },{ /* 1 */ | 582 | },{ /* 1 */ |
587 | .name = "PDC20269", | 583 | .name = "PDC20269", |
588 | .init_setup = init_setup_pdcnew, | 584 | .init_setup = init_setup_pdcnew, |
@@ -592,6 +588,7 @@ static ide_pci_device_t pdcnew_chipsets[] __devinitdata = { | |||
592 | .bootable = OFF_BOARD, | 588 | .bootable = OFF_BOARD, |
593 | .pio_mask = ATA_PIO4, | 589 | .pio_mask = ATA_PIO4, |
594 | .udma_mask = 0x7f, /* udma0-6*/ | 590 | .udma_mask = 0x7f, /* udma0-6*/ |
591 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
595 | },{ /* 2 */ | 592 | },{ /* 2 */ |
596 | .name = "PDC20270", | 593 | .name = "PDC20270", |
597 | .init_setup = init_setup_pdc20270, | 594 | .init_setup = init_setup_pdc20270, |
@@ -601,6 +598,7 @@ static ide_pci_device_t pdcnew_chipsets[] __devinitdata = { | |||
601 | .bootable = OFF_BOARD, | 598 | .bootable = OFF_BOARD, |
602 | .pio_mask = ATA_PIO4, | 599 | .pio_mask = ATA_PIO4, |
603 | .udma_mask = 0x3f, /* udma0-5 */ | 600 | .udma_mask = 0x3f, /* udma0-5 */ |
601 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
604 | },{ /* 3 */ | 602 | },{ /* 3 */ |
605 | .name = "PDC20271", | 603 | .name = "PDC20271", |
606 | .init_setup = init_setup_pdcnew, | 604 | .init_setup = init_setup_pdcnew, |
@@ -610,6 +608,7 @@ static ide_pci_device_t pdcnew_chipsets[] __devinitdata = { | |||
610 | .bootable = OFF_BOARD, | 608 | .bootable = OFF_BOARD, |
611 | .pio_mask = ATA_PIO4, | 609 | .pio_mask = ATA_PIO4, |
612 | .udma_mask = 0x7f, /* udma0-6*/ | 610 | .udma_mask = 0x7f, /* udma0-6*/ |
611 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
613 | },{ /* 4 */ | 612 | },{ /* 4 */ |
614 | .name = "PDC20275", | 613 | .name = "PDC20275", |
615 | .init_setup = init_setup_pdcnew, | 614 | .init_setup = init_setup_pdcnew, |
@@ -619,6 +618,7 @@ static ide_pci_device_t pdcnew_chipsets[] __devinitdata = { | |||
619 | .bootable = OFF_BOARD, | 618 | .bootable = OFF_BOARD, |
620 | .pio_mask = ATA_PIO4, | 619 | .pio_mask = ATA_PIO4, |
621 | .udma_mask = 0x7f, /* udma0-6*/ | 620 | .udma_mask = 0x7f, /* udma0-6*/ |
621 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
622 | },{ /* 5 */ | 622 | },{ /* 5 */ |
623 | .name = "PDC20276", | 623 | .name = "PDC20276", |
624 | .init_setup = init_setup_pdc20276, | 624 | .init_setup = init_setup_pdc20276, |
@@ -628,6 +628,7 @@ static ide_pci_device_t pdcnew_chipsets[] __devinitdata = { | |||
628 | .bootable = OFF_BOARD, | 628 | .bootable = OFF_BOARD, |
629 | .pio_mask = ATA_PIO4, | 629 | .pio_mask = ATA_PIO4, |
630 | .udma_mask = 0x7f, /* udma0-6*/ | 630 | .udma_mask = 0x7f, /* udma0-6*/ |
631 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
631 | },{ /* 6 */ | 632 | },{ /* 6 */ |
632 | .name = "PDC20277", | 633 | .name = "PDC20277", |
633 | .init_setup = init_setup_pdcnew, | 634 | .init_setup = init_setup_pdcnew, |
@@ -637,6 +638,7 @@ static ide_pci_device_t pdcnew_chipsets[] __devinitdata = { | |||
637 | .bootable = OFF_BOARD, | 638 | .bootable = OFF_BOARD, |
638 | .pio_mask = ATA_PIO4, | 639 | .pio_mask = ATA_PIO4, |
639 | .udma_mask = 0x7f, /* udma0-6*/ | 640 | .udma_mask = 0x7f, /* udma0-6*/ |
641 | .host_flags = IDE_HFLAG_POST_SET_MODE, | ||
640 | } | 642 | } |
641 | }; | 643 | }; |
642 | 644 | ||
diff --git a/drivers/ide/pci/pdc202xx_old.c b/drivers/ide/pci/pdc202xx_old.c index b578307fad51..8c3e8cf36ec9 100644 --- a/drivers/ide/pci/pdc202xx_old.c +++ b/drivers/ide/pci/pdc202xx_old.c | |||
@@ -63,7 +63,7 @@ static const char *pdc_quirk_drives[] = { | |||
63 | 63 | ||
64 | static void pdc_old_disable_66MHz_clock(ide_hwif_t *); | 64 | static void pdc_old_disable_66MHz_clock(ide_hwif_t *); |
65 | 65 | ||
66 | static int pdc202xx_tune_chipset(ide_drive_t *drive, const u8 speed) | 66 | static void pdc202xx_set_mode(ide_drive_t *drive, const u8 speed) |
67 | { | 67 | { |
68 | ide_hwif_t *hwif = HWIF(drive); | 68 | ide_hwif_t *hwif = HWIF(drive); |
69 | struct pci_dev *dev = hwif->pci_dev; | 69 | struct pci_dev *dev = hwif->pci_dev; |
@@ -138,13 +138,11 @@ static int pdc202xx_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
138 | pci_read_config_dword(dev, drive_pci, &drive_conf); | 138 | pci_read_config_dword(dev, drive_pci, &drive_conf); |
139 | printk("0x%08x\n", drive_conf); | 139 | printk("0x%08x\n", drive_conf); |
140 | #endif | 140 | #endif |
141 | |||
142 | return ide_config_drive_speed(drive, speed); | ||
143 | } | 141 | } |
144 | 142 | ||
145 | static void pdc202xx_set_pio_mode(ide_drive_t *drive, const u8 pio) | 143 | static void pdc202xx_set_pio_mode(ide_drive_t *drive, const u8 pio) |
146 | { | 144 | { |
147 | pdc202xx_tune_chipset(drive, XFER_PIO_0 + pio); | 145 | pdc202xx_set_mode(drive, XFER_PIO_0 + pio); |
148 | } | 146 | } |
149 | 147 | ||
150 | static u8 pdc202xx_old_cable_detect (ide_hwif_t *hwif) | 148 | static u8 pdc202xx_old_cable_detect (ide_hwif_t *hwif) |
@@ -330,14 +328,13 @@ static void __devinit init_hwif_pdc202xx(ide_hwif_t *hwif) | |||
330 | hwif->autodma = 0; | 328 | hwif->autodma = 0; |
331 | 329 | ||
332 | hwif->set_pio_mode = &pdc202xx_set_pio_mode; | 330 | hwif->set_pio_mode = &pdc202xx_set_pio_mode; |
331 | hwif->set_dma_mode = &pdc202xx_set_mode; | ||
333 | 332 | ||
334 | hwif->quirkproc = &pdc202xx_quirkproc; | 333 | hwif->quirkproc = &pdc202xx_quirkproc; |
335 | 334 | ||
336 | if (hwif->pci_dev->device != PCI_DEVICE_ID_PROMISE_20246) | 335 | if (hwif->pci_dev->device != PCI_DEVICE_ID_PROMISE_20246) |
337 | hwif->resetproc = &pdc202xx_reset; | 336 | hwif->resetproc = &pdc202xx_reset; |
338 | 337 | ||
339 | hwif->speedproc = &pdc202xx_tune_chipset; | ||
340 | |||
341 | hwif->err_stops_fifo = 1; | 338 | hwif->err_stops_fifo = 1; |
342 | 339 | ||
343 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; | 340 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; |
diff --git a/drivers/ide/pci/piix.c b/drivers/ide/pci/piix.c index fd8214a7ab98..38c91ba6497b 100644 --- a/drivers/ide/pci/piix.c +++ b/drivers/ide/pci/piix.c | |||
@@ -137,13 +137,14 @@ static u8 piix_dma_2_pio (u8 xfer_rate) { | |||
137 | } | 137 | } |
138 | 138 | ||
139 | /** | 139 | /** |
140 | * piix_tune_pio - tune PIIX for PIO mode | 140 | * piix_set_pio_mode - set host controller for PIO mode |
141 | * @drive: drive to tune | 141 | * @drive: drive |
142 | * @pio: desired PIO mode | 142 | * @pio: PIO mode number |
143 | * | 143 | * |
144 | * Set the interface PIO mode based upon the settings done by AMI BIOS. | 144 | * Set the interface PIO mode based upon the settings done by AMI BIOS. |
145 | */ | 145 | */ |
146 | static void piix_tune_pio (ide_drive_t *drive, u8 pio) | 146 | |
147 | static void piix_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
147 | { | 148 | { |
148 | ide_hwif_t *hwif = HWIF(drive); | 149 | ide_hwif_t *hwif = HWIF(drive); |
149 | struct pci_dev *dev = hwif->pci_dev; | 150 | struct pci_dev *dev = hwif->pci_dev; |
@@ -204,31 +205,15 @@ static void piix_tune_pio (ide_drive_t *drive, u8 pio) | |||
204 | } | 205 | } |
205 | 206 | ||
206 | /** | 207 | /** |
207 | * piix_set_pio_mode - set PIO mode | 208 | * piix_set_dma_mode - set host controller for DMA mode |
208 | * @drive: drive to tune | 209 | * @drive: drive |
209 | * @pio: desired PIO mode | 210 | * @speed: DMA mode |
210 | * | ||
211 | * Set the drive's PIO mode (might be useful if drive is not registered | ||
212 | * in CMOS for any reason). | ||
213 | */ | ||
214 | |||
215 | static void piix_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
216 | { | ||
217 | piix_tune_pio(drive, pio); | ||
218 | (void) ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
219 | } | ||
220 | |||
221 | /** | ||
222 | * piix_tune_chipset - tune a PIIX interface | ||
223 | * @drive: IDE drive to tune | ||
224 | * @speed: speed to configure | ||
225 | * | 211 | * |
226 | * Set a PIIX interface channel to the desired speeds. This involves | 212 | * Set a PIIX host controller to the desired DMA mode. This involves |
227 | * requires the right timing data into the PIIX configuration space | 213 | * programming the right timing data into the PCI configuration space. |
228 | * then setting the drive parameters appropriately | ||
229 | */ | 214 | */ |
230 | 215 | ||
231 | static int piix_tune_chipset(ide_drive_t *drive, const u8 speed) | 216 | static void piix_set_dma_mode(ide_drive_t *drive, const u8 speed) |
232 | { | 217 | { |
233 | ide_hwif_t *hwif = HWIF(drive); | 218 | ide_hwif_t *hwif = HWIF(drive); |
234 | struct pci_dev *dev = hwif->pci_dev; | 219 | struct pci_dev *dev = hwif->pci_dev; |
@@ -259,7 +244,7 @@ static int piix_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
259 | case XFER_MW_DMA_2: | 244 | case XFER_MW_DMA_2: |
260 | case XFER_MW_DMA_1: | 245 | case XFER_MW_DMA_1: |
261 | case XFER_SW_DMA_2: break; | 246 | case XFER_SW_DMA_2: break; |
262 | default: return -1; | 247 | default: return; |
263 | } | 248 | } |
264 | 249 | ||
265 | if (speed >= XFER_UDMA_0) { | 250 | if (speed >= XFER_UDMA_0) { |
@@ -288,9 +273,7 @@ static int piix_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
288 | pci_write_config_byte(dev, 0x55, (u8) reg55 & ~w_flag); | 273 | pci_write_config_byte(dev, 0x55, (u8) reg55 & ~w_flag); |
289 | } | 274 | } |
290 | 275 | ||
291 | piix_tune_pio(drive, piix_dma_2_pio(speed)); | 276 | piix_set_pio_mode(drive, piix_dma_2_pio(speed)); |
292 | |||
293 | return ide_config_drive_speed(drive, speed); | ||
294 | } | 277 | } |
295 | 278 | ||
296 | /** | 279 | /** |
@@ -448,7 +431,8 @@ static void __devinit init_hwif_piix(ide_hwif_t *hwif) | |||
448 | hwif->autodma = 0; | 431 | hwif->autodma = 0; |
449 | 432 | ||
450 | hwif->set_pio_mode = &piix_set_pio_mode; | 433 | hwif->set_pio_mode = &piix_set_pio_mode; |
451 | hwif->speedproc = &piix_tune_chipset; | 434 | hwif->set_dma_mode = &piix_set_dma_mode; |
435 | |||
452 | hwif->drives[0].autotune = 1; | 436 | hwif->drives[0].autotune = 1; |
453 | hwif->drives[1].autotune = 1; | 437 | hwif->drives[1].autotune = 1; |
454 | 438 | ||
diff --git a/drivers/ide/pci/sc1200.c b/drivers/ide/pci/sc1200.c index 79ecab689489..ee0e3f554d9a 100644 --- a/drivers/ide/pci/sc1200.c +++ b/drivers/ide/pci/sc1200.c | |||
@@ -68,17 +68,6 @@ static unsigned short sc1200_get_pci_clock (void) | |||
68 | return pci_clock; | 68 | return pci_clock; |
69 | } | 69 | } |
70 | 70 | ||
71 | extern char *ide_xfer_verbose (byte xfer_rate); | ||
72 | |||
73 | /* | ||
74 | * Set a new transfer mode at the drive | ||
75 | */ | ||
76 | static int sc1200_set_xfer_mode (ide_drive_t *drive, byte mode) | ||
77 | { | ||
78 | printk("%s: sc1200_set_xfer_mode(%s)\n", drive->name, ide_xfer_verbose(mode)); | ||
79 | return ide_config_drive_speed(drive, mode); | ||
80 | } | ||
81 | |||
82 | /* | 71 | /* |
83 | * Here are the standard PIO mode 0-4 timings for each "format". | 72 | * Here are the standard PIO mode 0-4 timings for each "format". |
84 | * Format-0 uses fast data reg timings, with slower command reg timings. | 73 | * Format-0 uses fast data reg timings, with slower command reg timings. |
@@ -138,7 +127,7 @@ out: | |||
138 | return mask; | 127 | return mask; |
139 | } | 128 | } |
140 | 129 | ||
141 | static int sc1200_tune_chipset(ide_drive_t *drive, const u8 mode) | 130 | static void sc1200_set_dma_mode(ide_drive_t *drive, const u8 mode) |
142 | { | 131 | { |
143 | ide_hwif_t *hwif = HWIF(drive); | 132 | ide_hwif_t *hwif = HWIF(drive); |
144 | int unit = drive->select.b.unit; | 133 | int unit = drive->select.b.unit; |
@@ -146,17 +135,9 @@ static int sc1200_tune_chipset(ide_drive_t *drive, const u8 mode) | |||
146 | unsigned short pci_clock; | 135 | unsigned short pci_clock; |
147 | unsigned int basereg = hwif->channel ? 0x50 : 0x40; | 136 | unsigned int basereg = hwif->channel ? 0x50 : 0x40; |
148 | 137 | ||
149 | /* | ||
150 | * Tell the drive to switch to the new mode; abort on failure. | ||
151 | */ | ||
152 | if (sc1200_set_xfer_mode(drive, mode)) | ||
153 | return 1; /* failure */ | ||
154 | |||
155 | pci_clock = sc1200_get_pci_clock(); | 138 | pci_clock = sc1200_get_pci_clock(); |
156 | 139 | ||
157 | /* | 140 | /* |
158 | * Now tune the chipset to match the drive: | ||
159 | * | ||
160 | * Note that each DMA mode has several timings associated with it. | 141 | * Note that each DMA mode has several timings associated with it. |
161 | * The correct timing depends on the fast PCI clock freq. | 142 | * The correct timing depends on the fast PCI clock freq. |
162 | */ | 143 | */ |
@@ -216,8 +197,6 @@ static int sc1200_tune_chipset(ide_drive_t *drive, const u8 mode) | |||
216 | } else { | 197 | } else { |
217 | pci_write_config_dword(hwif->pci_dev, basereg+12, timings); | 198 | pci_write_config_dword(hwif->pci_dev, basereg+12, timings); |
218 | } | 199 | } |
219 | |||
220 | return 0; /* success */ | ||
221 | } | 200 | } |
222 | 201 | ||
223 | /* | 202 | /* |
@@ -286,13 +265,12 @@ static void sc1200_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
286 | if (mode != -1) { | 265 | if (mode != -1) { |
287 | printk("SC1200: %s: changing (U)DMA mode\n", drive->name); | 266 | printk("SC1200: %s: changing (U)DMA mode\n", drive->name); |
288 | hwif->dma_off_quietly(drive); | 267 | hwif->dma_off_quietly(drive); |
289 | if (sc1200_tune_chipset(drive, mode) == 0) | 268 | if (ide_set_dma_mode(drive, mode) == 0) |
290 | hwif->dma_host_on(drive); | 269 | hwif->dma_host_on(drive); |
291 | return; | 270 | return; |
292 | } | 271 | } |
293 | 272 | ||
294 | if (sc1200_set_xfer_mode(drive, XFER_PIO_0 + pio) == 0) | 273 | sc1200_tunepio(drive, pio); |
295 | sc1200_tunepio(drive, pio); | ||
296 | } | 274 | } |
297 | 275 | ||
298 | #ifdef CONFIG_PM | 276 | #ifdef CONFIG_PM |
@@ -400,16 +378,20 @@ static void __devinit init_hwif_sc1200 (ide_hwif_t *hwif) | |||
400 | if (hwif->mate) | 378 | if (hwif->mate) |
401 | hwif->serialized = hwif->mate->serialized = 1; | 379 | hwif->serialized = hwif->mate->serialized = 1; |
402 | hwif->autodma = 0; | 380 | hwif->autodma = 0; |
403 | if (hwif->dma_base) { | 381 | |
404 | hwif->udma_filter = sc1200_udma_filter; | 382 | hwif->set_pio_mode = &sc1200_set_pio_mode; |
405 | hwif->ide_dma_check = &sc1200_config_dma; | 383 | hwif->set_dma_mode = &sc1200_set_dma_mode; |
406 | hwif->ide_dma_end = &sc1200_ide_dma_end; | 384 | |
407 | if (!noautodma) | 385 | if (hwif->dma_base == 0) |
408 | hwif->autodma = 1; | 386 | return; |
409 | 387 | ||
410 | hwif->set_pio_mode = &sc1200_set_pio_mode; | 388 | hwif->udma_filter = sc1200_udma_filter; |
411 | hwif->speedproc = &sc1200_tune_chipset; | 389 | hwif->ide_dma_check = &sc1200_config_dma; |
412 | } | 390 | hwif->ide_dma_end = &sc1200_ide_dma_end; |
391 | |||
392 | if (!noautodma) | ||
393 | hwif->autodma = 1; | ||
394 | |||
413 | hwif->atapi_dma = 1; | 395 | hwif->atapi_dma = 1; |
414 | hwif->ultra_mask = 0x07; | 396 | hwif->ultra_mask = 0x07; |
415 | hwif->mwdma_mask = 0x07; | 397 | hwif->mwdma_mask = 0x07; |
@@ -423,7 +405,7 @@ static ide_pci_device_t sc1200_chipset __devinitdata = { | |||
423 | .init_hwif = init_hwif_sc1200, | 405 | .init_hwif = init_hwif_sc1200, |
424 | .autodma = AUTODMA, | 406 | .autodma = AUTODMA, |
425 | .bootable = ON_BOARD, | 407 | .bootable = ON_BOARD, |
426 | .host_flags = IDE_HFLAG_ABUSE_DMA_MODES, | 408 | .host_flags = IDE_HFLAG_ABUSE_DMA_MODES | IDE_HFLAG_POST_SET_MODE, |
427 | .pio_mask = ATA_PIO4, | 409 | .pio_mask = ATA_PIO4, |
428 | }; | 410 | }; |
429 | 411 | ||
diff --git a/drivers/ide/pci/scc_pata.c b/drivers/ide/pci/scc_pata.c index 66a526e0ece4..67f06dd11b34 100644 --- a/drivers/ide/pci/scc_pata.c +++ b/drivers/ide/pci/scc_pata.c | |||
@@ -190,15 +190,15 @@ scc_ide_outsl(unsigned long port, void *addr, u32 count) | |||
190 | } | 190 | } |
191 | 191 | ||
192 | /** | 192 | /** |
193 | * scc_tune_pio - tune a drive PIO mode | 193 | * scc_set_pio_mode - set host controller for PIO mode |
194 | * @drive: drive to tune | 194 | * @drive: drive |
195 | * @mode_wanted: the target operating mode | 195 | * @pio: PIO mode number |
196 | * | 196 | * |
197 | * Load the timing settings for this device mode into the | 197 | * Load the timing settings for this device mode into the |
198 | * controller. | 198 | * controller. |
199 | */ | 199 | */ |
200 | 200 | ||
201 | static void scc_tune_pio(ide_drive_t *drive, const u8 pio) | 201 | static void scc_set_pio_mode(ide_drive_t *drive, const u8 pio) |
202 | { | 202 | { |
203 | ide_hwif_t *hwif = HWIF(drive); | 203 | ide_hwif_t *hwif = HWIF(drive); |
204 | struct scc_ports *ports = ide_get_hwifdata(hwif); | 204 | struct scc_ports *ports = ide_get_hwifdata(hwif); |
@@ -221,22 +221,16 @@ static void scc_tune_pio(ide_drive_t *drive, const u8 pio) | |||
221 | out_be32((void __iomem *)pioct_port, reg); | 221 | out_be32((void __iomem *)pioct_port, reg); |
222 | } | 222 | } |
223 | 223 | ||
224 | static void scc_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
225 | { | ||
226 | scc_tune_pio(drive, pio); | ||
227 | ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
228 | } | ||
229 | |||
230 | /** | 224 | /** |
231 | * scc_tune_chipset - tune a drive DMA mode | 225 | * scc_set_dma_mode - set host controller for DMA mode |
232 | * @drive: Drive to set up | 226 | * @drive: drive |
233 | * @speed: speed we want to achieve | 227 | * @speed: DMA mode |
234 | * | 228 | * |
235 | * Load the timing settings for this device mode into the | 229 | * Load the timing settings for this device mode into the |
236 | * controller. | 230 | * controller. |
237 | */ | 231 | */ |
238 | 232 | ||
239 | static int scc_tune_chipset(ide_drive_t *drive, const u8 speed) | 233 | static void scc_set_dma_mode(ide_drive_t *drive, const u8 speed) |
240 | { | 234 | { |
241 | ide_hwif_t *hwif = HWIF(drive); | 235 | ide_hwif_t *hwif = HWIF(drive); |
242 | struct scc_ports *ports = ide_get_hwifdata(hwif); | 236 | struct scc_ports *ports = ide_get_hwifdata(hwif); |
@@ -271,7 +265,7 @@ static int scc_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
271 | idx = speed - XFER_UDMA_0; | 265 | idx = speed - XFER_UDMA_0; |
272 | break; | 266 | break; |
273 | default: | 267 | default: |
274 | return 1; | 268 | return; |
275 | } | 269 | } |
276 | 270 | ||
277 | jcactsel = JCACTSELtbl[offset][idx]; | 271 | jcactsel = JCACTSELtbl[offset][idx]; |
@@ -287,8 +281,6 @@ static int scc_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
287 | } | 281 | } |
288 | reg = JCTSStbl[offset][idx] << 16 | JCENVTtbl[offset][idx]; | 282 | reg = JCTSStbl[offset][idx] << 16 | JCENVTtbl[offset][idx]; |
289 | out_be32((void __iomem *)udenvt_port, reg); | 283 | out_be32((void __iomem *)udenvt_port, reg); |
290 | |||
291 | return ide_config_drive_speed(drive, speed); | ||
292 | } | 284 | } |
293 | 285 | ||
294 | /** | 286 | /** |
@@ -708,8 +700,8 @@ static void __devinit init_hwif_scc(ide_hwif_t *hwif) | |||
708 | 700 | ||
709 | hwif->dma_setup = scc_dma_setup; | 701 | hwif->dma_setup = scc_dma_setup; |
710 | hwif->ide_dma_end = scc_ide_dma_end; | 702 | hwif->ide_dma_end = scc_ide_dma_end; |
711 | hwif->speedproc = scc_tune_chipset; | ||
712 | hwif->set_pio_mode = scc_set_pio_mode; | 703 | hwif->set_pio_mode = scc_set_pio_mode; |
704 | hwif->set_dma_mode = scc_set_dma_mode; | ||
713 | hwif->ide_dma_check = scc_config_drive_for_dma; | 705 | hwif->ide_dma_check = scc_config_drive_for_dma; |
714 | hwif->ide_dma_test_irq = scc_dma_test_irq; | 706 | hwif->ide_dma_test_irq = scc_dma_test_irq; |
715 | hwif->udma_filter = scc_udma_filter; | 707 | hwif->udma_filter = scc_udma_filter; |
diff --git a/drivers/ide/pci/serverworks.c b/drivers/ide/pci/serverworks.c index 0351cf210427..49ec0ac64a4b 100644 --- a/drivers/ide/pci/serverworks.c +++ b/drivers/ide/pci/serverworks.c | |||
@@ -124,7 +124,7 @@ static u8 svwks_csb_check (struct pci_dev *dev) | |||
124 | return 0; | 124 | return 0; |
125 | } | 125 | } |
126 | 126 | ||
127 | static void svwks_tune_pio(ide_drive_t *drive, const u8 pio) | 127 | static void svwks_set_pio_mode(ide_drive_t *drive, const u8 pio) |
128 | { | 128 | { |
129 | static const u8 pio_modes[] = { 0x5d, 0x47, 0x34, 0x22, 0x20 }; | 129 | static const u8 pio_modes[] = { 0x5d, 0x47, 0x34, 0x22, 0x20 }; |
130 | static const u8 drive_pci[] = { 0x41, 0x40, 0x43, 0x42 }; | 130 | static const u8 drive_pci[] = { 0x41, 0x40, 0x43, 0x42 }; |
@@ -145,7 +145,7 @@ static void svwks_tune_pio(ide_drive_t *drive, const u8 pio) | |||
145 | } | 145 | } |
146 | } | 146 | } |
147 | 147 | ||
148 | static int svwks_tune_chipset(ide_drive_t *drive, const u8 speed) | 148 | static void svwks_set_dma_mode(ide_drive_t *drive, const u8 speed) |
149 | { | 149 | { |
150 | static const u8 udma_modes[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 }; | 150 | static const u8 udma_modes[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 }; |
151 | static const u8 dma_modes[] = { 0x77, 0x21, 0x20 }; | 151 | static const u8 dma_modes[] = { 0x77, 0x21, 0x20 }; |
@@ -193,14 +193,6 @@ static int svwks_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
193 | pci_write_config_byte(dev, drive_pci2[drive->dn], dma_timing); | 193 | pci_write_config_byte(dev, drive_pci2[drive->dn], dma_timing); |
194 | pci_write_config_byte(dev, (0x56|hwif->channel), ultra_timing); | 194 | pci_write_config_byte(dev, (0x56|hwif->channel), ultra_timing); |
195 | pci_write_config_byte(dev, 0x54, ultra_enable); | 195 | pci_write_config_byte(dev, 0x54, ultra_enable); |
196 | |||
197 | return (ide_config_drive_speed(drive, speed)); | ||
198 | } | ||
199 | |||
200 | static void svwks_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
201 | { | ||
202 | svwks_tune_pio(drive, pio); | ||
203 | (void)ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
204 | } | 196 | } |
205 | 197 | ||
206 | static int svwks_config_drive_xfer_rate (ide_drive_t *drive) | 198 | static int svwks_config_drive_xfer_rate (ide_drive_t *drive) |
@@ -384,7 +376,7 @@ static void __devinit init_hwif_svwks (ide_hwif_t *hwif) | |||
384 | hwif->irq = hwif->channel ? 15 : 14; | 376 | hwif->irq = hwif->channel ? 15 : 14; |
385 | 377 | ||
386 | hwif->set_pio_mode = &svwks_set_pio_mode; | 378 | hwif->set_pio_mode = &svwks_set_pio_mode; |
387 | hwif->speedproc = &svwks_tune_chipset; | 379 | hwif->set_dma_mode = &svwks_set_dma_mode; |
388 | hwif->udma_filter = &svwks_udma_filter; | 380 | hwif->udma_filter = &svwks_udma_filter; |
389 | 381 | ||
390 | hwif->atapi_dma = 1; | 382 | hwif->atapi_dma = 1; |
diff --git a/drivers/ide/pci/sgiioc4.c b/drivers/ide/pci/sgiioc4.c index c292e1de1d56..85ffaaa39b1b 100644 --- a/drivers/ide/pci/sgiioc4.c +++ b/drivers/ide/pci/sgiioc4.c | |||
@@ -291,12 +291,8 @@ static void sgiioc4_dma_off_quietly(ide_drive_t *drive) | |||
291 | drive->hwif->dma_host_off(drive); | 291 | drive->hwif->dma_host_off(drive); |
292 | } | 292 | } |
293 | 293 | ||
294 | static int sgiioc4_speedproc(ide_drive_t *drive, const u8 speed) | 294 | static void sgiioc4_set_dma_mode(ide_drive_t *drive, const u8 speed) |
295 | { | 295 | { |
296 | if (speed != XFER_MW_DMA_2) | ||
297 | return 1; | ||
298 | |||
299 | return ide_config_drive_speed(drive, speed); | ||
300 | } | 296 | } |
301 | 297 | ||
302 | static int sgiioc4_ide_dma_check(ide_drive_t *drive) | 298 | static int sgiioc4_ide_dma_check(ide_drive_t *drive) |
@@ -591,11 +587,9 @@ static void __devinit | |||
591 | ide_init_sgiioc4(ide_hwif_t * hwif) | 587 | ide_init_sgiioc4(ide_hwif_t * hwif) |
592 | { | 588 | { |
593 | hwif->mmio = 1; | 589 | hwif->mmio = 1; |
594 | hwif->atapi_dma = 1; | ||
595 | hwif->mwdma_mask = 0x04; | ||
596 | hwif->pio_mask = 0x00; | 590 | hwif->pio_mask = 0x00; |
597 | hwif->set_pio_mode = NULL; /* Sets timing for PIO mode */ | 591 | hwif->set_pio_mode = NULL; /* Sets timing for PIO mode */ |
598 | hwif->speedproc = &sgiioc4_speedproc; | 592 | hwif->set_dma_mode = &sgiioc4_set_dma_mode; |
599 | hwif->selectproc = NULL;/* Use the default routine to select drive */ | 593 | hwif->selectproc = NULL;/* Use the default routine to select drive */ |
600 | hwif->reset_poll = NULL;/* No HBA specific reset_poll needed */ | 594 | hwif->reset_poll = NULL;/* No HBA specific reset_poll needed */ |
601 | hwif->pre_reset = NULL; /* No HBA specific pre_set needed */ | 595 | hwif->pre_reset = NULL; /* No HBA specific pre_set needed */ |
@@ -606,6 +600,14 @@ ide_init_sgiioc4(ide_hwif_t * hwif) | |||
606 | hwif->quirkproc = NULL; | 600 | hwif->quirkproc = NULL; |
607 | hwif->busproc = NULL; | 601 | hwif->busproc = NULL; |
608 | 602 | ||
603 | hwif->INB = &sgiioc4_INB; | ||
604 | |||
605 | if (hwif->dma_base == 0) | ||
606 | return; | ||
607 | |||
608 | hwif->atapi_dma = 1; | ||
609 | hwif->mwdma_mask = 0x04; | ||
610 | |||
609 | hwif->dma_setup = &sgiioc4_ide_dma_setup; | 611 | hwif->dma_setup = &sgiioc4_ide_dma_setup; |
610 | hwif->dma_start = &sgiioc4_ide_dma_start; | 612 | hwif->dma_start = &sgiioc4_ide_dma_start; |
611 | hwif->ide_dma_end = &sgiioc4_ide_dma_end; | 613 | hwif->ide_dma_end = &sgiioc4_ide_dma_end; |
@@ -617,8 +619,6 @@ ide_init_sgiioc4(ide_hwif_t * hwif) | |||
617 | hwif->dma_host_off = &sgiioc4_dma_host_off; | 619 | hwif->dma_host_off = &sgiioc4_dma_host_off; |
618 | hwif->dma_lost_irq = &sgiioc4_dma_lost_irq; | 620 | hwif->dma_lost_irq = &sgiioc4_dma_lost_irq; |
619 | hwif->dma_timeout = &ide_dma_timeout; | 621 | hwif->dma_timeout = &ide_dma_timeout; |
620 | |||
621 | hwif->INB = &sgiioc4_INB; | ||
622 | } | 622 | } |
623 | 623 | ||
624 | static int __devinit | 624 | static int __devinit |
@@ -688,8 +688,6 @@ sgiioc4_ide_setup_pci_device(struct pci_dev *dev) | |||
688 | /* Initializing chipset IRQ Registers */ | 688 | /* Initializing chipset IRQ Registers */ |
689 | writel(0x03, (void __iomem *)(irqport + IOC4_INTR_SET * 4)); | 689 | writel(0x03, (void __iomem *)(irqport + IOC4_INTR_SET * 4)); |
690 | 690 | ||
691 | ide_init_sgiioc4(hwif); | ||
692 | |||
693 | hwif->autodma = 0; | 691 | hwif->autodma = 0; |
694 | 692 | ||
695 | if (dma_base && ide_dma_sgiioc4(hwif, dma_base) == 0) { | 693 | if (dma_base && ide_dma_sgiioc4(hwif, dma_base) == 0) { |
@@ -699,6 +697,8 @@ sgiioc4_ide_setup_pci_device(struct pci_dev *dev) | |||
699 | printk(KERN_INFO "%s: %s Bus-Master DMA disabled\n", | 697 | printk(KERN_INFO "%s: %s Bus-Master DMA disabled\n", |
700 | hwif->name, DRV_NAME); | 698 | hwif->name, DRV_NAME); |
701 | 699 | ||
700 | ide_init_sgiioc4(hwif); | ||
701 | |||
702 | if (probe_hwif_init(hwif)) | 702 | if (probe_hwif_init(hwif)) |
703 | return -EIO; | 703 | return -EIO; |
704 | 704 | ||
diff --git a/drivers/ide/pci/siimage.c b/drivers/ide/pci/siimage.c index 5d1e5e52a044..ce7784996d12 100644 --- a/drivers/ide/pci/siimage.c +++ b/drivers/ide/pci/siimage.c | |||
@@ -165,16 +165,16 @@ out: | |||
165 | } | 165 | } |
166 | 166 | ||
167 | /** | 167 | /** |
168 | * sil_tune_pio - tune a drive | 168 | * sil_set_pio_mode - set host controller for PIO mode |
169 | * @drive: drive to tune | 169 | * @drive: drive |
170 | * @pio: the desired PIO mode | 170 | * @pio: PIO mode number |
171 | * | 171 | * |
172 | * Load the timing settings for this device mode into the | 172 | * Load the timing settings for this device mode into the |
173 | * controller. If we are in PIO mode 3 or 4 turn on IORDY | 173 | * controller. If we are in PIO mode 3 or 4 turn on IORDY |
174 | * monitoring (bit 9). The TF timing is bits 31:16 | 174 | * monitoring (bit 9). The TF timing is bits 31:16 |
175 | */ | 175 | */ |
176 | 176 | ||
177 | static void sil_tune_pio(ide_drive_t *drive, u8 pio) | 177 | static void sil_set_pio_mode(ide_drive_t *drive, u8 pio) |
178 | { | 178 | { |
179 | const u16 tf_speed[] = { 0x328a, 0x2283, 0x1281, 0x10c3, 0x10c1 }; | 179 | const u16 tf_speed[] = { 0x328a, 0x2283, 0x1281, 0x10c3, 0x10c1 }; |
180 | const u16 data_speed[] = { 0x328a, 0x2283, 0x1104, 0x10c3, 0x10c1 }; | 180 | const u16 data_speed[] = { 0x328a, 0x2283, 0x1104, 0x10c3, 0x10c1 }; |
@@ -234,21 +234,15 @@ static void sil_tune_pio(ide_drive_t *drive, u8 pio) | |||
234 | } | 234 | } |
235 | } | 235 | } |
236 | 236 | ||
237 | static void sil_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
238 | { | ||
239 | sil_tune_pio(drive, pio); | ||
240 | (void)ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
241 | } | ||
242 | |||
243 | /** | 237 | /** |
244 | * siimage_tune_chipset - set controller timings | 238 | * sil_set_dma_mode - set host controller for DMA mode |
245 | * @drive: Drive to set up | 239 | * @drive: drive |
246 | * @speed: speed we want to achieve | 240 | * @speed: DMA mode |
247 | * | 241 | * |
248 | * Tune the SII chipset for the desired mode. | 242 | * Tune the SiI chipset for the desired DMA mode. |
249 | */ | 243 | */ |
250 | 244 | ||
251 | static int siimage_tune_chipset(ide_drive_t *drive, const u8 speed) | 245 | static void sil_set_dma_mode(ide_drive_t *drive, const u8 speed) |
252 | { | 246 | { |
253 | u8 ultra6[] = { 0x0F, 0x0B, 0x07, 0x05, 0x03, 0x02, 0x01 }; | 247 | u8 ultra6[] = { 0x0F, 0x0B, 0x07, 0x05, 0x03, 0x02, 0x01 }; |
254 | u8 ultra5[] = { 0x0C, 0x07, 0x05, 0x04, 0x02, 0x01 }; | 248 | u8 ultra5[] = { 0x0C, 0x07, 0x05, 0x04, 0x02, 0x01 }; |
@@ -303,7 +297,7 @@ static int siimage_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
303 | mode |= ((unit) ? 0x30 : 0x03); | 297 | mode |= ((unit) ? 0x30 : 0x03); |
304 | break; | 298 | break; |
305 | default: | 299 | default: |
306 | return 1; | 300 | return; |
307 | } | 301 | } |
308 | 302 | ||
309 | if (hwif->mmio) { | 303 | if (hwif->mmio) { |
@@ -315,7 +309,6 @@ static int siimage_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
315 | pci_write_config_word(hwif->pci_dev, ma, multi); | 309 | pci_write_config_word(hwif->pci_dev, ma, multi); |
316 | pci_write_config_word(hwif->pci_dev, ua, ultra); | 310 | pci_write_config_word(hwif->pci_dev, ua, ultra); |
317 | } | 311 | } |
318 | return (ide_config_drive_speed(drive, speed)); | ||
319 | } | 312 | } |
320 | 313 | ||
321 | /** | 314 | /** |
@@ -904,8 +897,8 @@ static void __devinit init_hwif_siimage(ide_hwif_t *hwif) | |||
904 | hwif->autodma = 0; | 897 | hwif->autodma = 0; |
905 | 898 | ||
906 | hwif->resetproc = &siimage_reset; | 899 | hwif->resetproc = &siimage_reset; |
907 | hwif->speedproc = &siimage_tune_chipset; | ||
908 | hwif->set_pio_mode = &sil_set_pio_mode; | 900 | hwif->set_pio_mode = &sil_set_pio_mode; |
901 | hwif->set_dma_mode = &sil_set_dma_mode; | ||
909 | hwif->reset_poll = &siimage_reset_poll; | 902 | hwif->reset_poll = &siimage_reset_poll; |
910 | hwif->pre_reset = &siimage_pre_reset; | 903 | hwif->pre_reset = &siimage_pre_reset; |
911 | hwif->udma_filter = &sil_udma_filter; | 904 | hwif->udma_filter = &sil_udma_filter; |
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c index 3e18899de631..b375ee53d66d 100644 --- a/drivers/ide/pci/sis5513.c +++ b/drivers/ide/pci/sis5513.c | |||
@@ -451,7 +451,7 @@ static void config_drive_art_rwp (ide_drive_t *drive) | |||
451 | } | 451 | } |
452 | 452 | ||
453 | /* Set per-drive active and recovery time */ | 453 | /* Set per-drive active and recovery time */ |
454 | static void config_art_rwp_pio (ide_drive_t *drive, u8 pio) | 454 | static void sis_set_pio_mode(ide_drive_t *drive, const u8 pio) |
455 | { | 455 | { |
456 | ide_hwif_t *hwif = HWIF(drive); | 456 | ide_hwif_t *hwif = HWIF(drive); |
457 | struct pci_dev *dev = hwif->pci_dev; | 457 | struct pci_dev *dev = hwif->pci_dev; |
@@ -519,20 +519,14 @@ static void config_art_rwp_pio (ide_drive_t *drive, u8 pio) | |||
519 | } | 519 | } |
520 | } | 520 | } |
521 | 521 | ||
522 | static void sis_set_pio_mode(ide_drive_t *drive, const u8 pio) | 522 | static void sis_set_dma_mode(ide_drive_t *drive, const u8 speed) |
523 | { | ||
524 | config_art_rwp_pio(drive, pio); | ||
525 | (void)ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
526 | } | ||
527 | |||
528 | static int sis5513_tune_chipset(ide_drive_t *drive, const u8 speed) | ||
529 | { | 523 | { |
530 | ide_hwif_t *hwif = HWIF(drive); | 524 | ide_hwif_t *hwif = HWIF(drive); |
531 | struct pci_dev *dev = hwif->pci_dev; | 525 | struct pci_dev *dev = hwif->pci_dev; |
532 | u32 regdw; | 526 | u32 regdw; |
533 | u8 drive_pci, reg; | 527 | u8 drive_pci, reg; |
534 | 528 | ||
535 | /* See config_art_rwp_pio for drive pci config registers */ | 529 | /* See sis_set_pio_mode() for drive PCI config registers */ |
536 | drive_pci = 0x40; | 530 | drive_pci = 0x40; |
537 | if (chipset_family >= ATA_133) { | 531 | if (chipset_family >= ATA_133) { |
538 | u32 reg54h; | 532 | u32 reg54h; |
@@ -600,8 +594,6 @@ static int sis5513_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
600 | BUG(); | 594 | BUG(); |
601 | break; | 595 | break; |
602 | } | 596 | } |
603 | |||
604 | return ide_config_drive_speed(drive, speed); | ||
605 | } | 597 | } |
606 | 598 | ||
607 | static int sis5513_config_xfer_rate(ide_drive_t *drive) | 599 | static int sis5513_config_xfer_rate(ide_drive_t *drive) |
@@ -841,7 +833,7 @@ static void __devinit init_hwif_sis5513 (ide_hwif_t *hwif) | |||
841 | hwif->irq = hwif->channel ? 15 : 14; | 833 | hwif->irq = hwif->channel ? 15 : 14; |
842 | 834 | ||
843 | hwif->set_pio_mode = &sis_set_pio_mode; | 835 | hwif->set_pio_mode = &sis_set_pio_mode; |
844 | hwif->speedproc = &sis5513_tune_chipset; | 836 | hwif->set_dma_mode = &sis_set_dma_mode; |
845 | 837 | ||
846 | if (chipset_family >= ATA_133) | 838 | if (chipset_family >= ATA_133) |
847 | hwif->udma_filter = sis5513_ata133_udma_filter; | 839 | hwif->udma_filter = sis5513_ata133_udma_filter; |
diff --git a/drivers/ide/pci/sl82c105.c b/drivers/ide/pci/sl82c105.c index f492318ba797..2ef26e3f7be4 100644 --- a/drivers/ide/pci/sl82c105.c +++ b/drivers/ide/pci/sl82c105.c | |||
@@ -75,7 +75,7 @@ static unsigned int get_pio_timings(ide_drive_t *drive, u8 pio) | |||
75 | /* | 75 | /* |
76 | * Configure the chipset for PIO mode. | 76 | * Configure the chipset for PIO mode. |
77 | */ | 77 | */ |
78 | static void sl82c105_tune_pio(ide_drive_t *drive, const u8 pio) | 78 | static void sl82c105_set_pio_mode(ide_drive_t *drive, const u8 pio) |
79 | { | 79 | { |
80 | struct pci_dev *dev = HWIF(drive)->pci_dev; | 80 | struct pci_dev *dev = HWIF(drive)->pci_dev; |
81 | int reg = 0x44 + drive->dn * 4; | 81 | int reg = 0x44 + drive->dn * 4; |
@@ -105,9 +105,9 @@ static void sl82c105_tune_pio(ide_drive_t *drive, const u8 pio) | |||
105 | } | 105 | } |
106 | 106 | ||
107 | /* | 107 | /* |
108 | * Configure the drive and chipset for a new transfer speed. | 108 | * Configure the chipset for DMA mode. |
109 | */ | 109 | */ |
110 | static int sl82c105_tune_chipset(ide_drive_t *drive, const u8 speed) | 110 | static void sl82c105_set_dma_mode(ide_drive_t *drive, const u8 speed) |
111 | { | 111 | { |
112 | static u16 mwdma_timings[] = {0x0707, 0x0201, 0x0200}; | 112 | static u16 mwdma_timings[] = {0x0707, 0x0201, 0x0200}; |
113 | u16 drv_ctrl; | 113 | u16 drv_ctrl; |
@@ -140,10 +140,8 @@ static int sl82c105_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
140 | } | 140 | } |
141 | break; | 141 | break; |
142 | default: | 142 | default: |
143 | return -1; | 143 | return; |
144 | } | 144 | } |
145 | |||
146 | return ide_config_drive_speed(drive, speed); | ||
147 | } | 145 | } |
148 | 146 | ||
149 | /* | 147 | /* |
@@ -306,17 +304,6 @@ static void sl82c105_resetproc(ide_drive_t *drive) | |||
306 | pci_read_config_dword(dev, 0x40, &val); | 304 | pci_read_config_dword(dev, 0x40, &val); |
307 | pci_set_drvdata(dev, (void *)val); | 305 | pci_set_drvdata(dev, (void *)val); |
308 | } | 306 | } |
309 | |||
310 | /* | ||
311 | * We only deal with PIO mode here - DMA mode 'using_dma' is not | ||
312 | * initialised at the point that this function is called. | ||
313 | */ | ||
314 | static void sl82c105_set_pio_mode(ide_drive_t *drive, const u8 pio) | ||
315 | { | ||
316 | sl82c105_tune_pio(drive, pio); | ||
317 | |||
318 | (void) ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
319 | } | ||
320 | 307 | ||
321 | /* | 308 | /* |
322 | * Return the revision of the Winbond bridge | 309 | * Return the revision of the Winbond bridge |
@@ -383,7 +370,7 @@ static void __devinit init_hwif_sl82c105(ide_hwif_t *hwif) | |||
383 | DBG(("init_hwif_sl82c105(hwif: ide%d)\n", hwif->index)); | 370 | DBG(("init_hwif_sl82c105(hwif: ide%d)\n", hwif->index)); |
384 | 371 | ||
385 | hwif->set_pio_mode = &sl82c105_set_pio_mode; | 372 | hwif->set_pio_mode = &sl82c105_set_pio_mode; |
386 | hwif->speedproc = &sl82c105_tune_chipset; | 373 | hwif->set_dma_mode = &sl82c105_set_dma_mode; |
387 | hwif->selectproc = &sl82c105_selectproc; | 374 | hwif->selectproc = &sl82c105_selectproc; |
388 | hwif->resetproc = &sl82c105_resetproc; | 375 | hwif->resetproc = &sl82c105_resetproc; |
389 | 376 | ||
diff --git a/drivers/ide/pci/slc90e66.c b/drivers/ide/pci/slc90e66.c index ae8e91324577..ebac87f7200a 100644 --- a/drivers/ide/pci/slc90e66.c +++ b/drivers/ide/pci/slc90e66.c | |||
@@ -42,7 +42,7 @@ static u8 slc90e66_dma_2_pio (u8 xfer_rate) { | |||
42 | } | 42 | } |
43 | } | 43 | } |
44 | 44 | ||
45 | static void slc90e66_tune_pio (ide_drive_t *drive, u8 pio) | 45 | static void slc90e66_set_pio_mode(ide_drive_t *drive, const u8 pio) |
46 | { | 46 | { |
47 | ide_hwif_t *hwif = HWIF(drive); | 47 | ide_hwif_t *hwif = HWIF(drive); |
48 | struct pci_dev *dev = hwif->pci_dev; | 48 | struct pci_dev *dev = hwif->pci_dev; |
@@ -95,13 +95,7 @@ static void slc90e66_tune_pio (ide_drive_t *drive, u8 pio) | |||
95 | spin_unlock_irqrestore(&ide_lock, flags); | 95 | spin_unlock_irqrestore(&ide_lock, flags); |
96 | } | 96 | } |
97 | 97 | ||
98 | static void slc90e66_set_pio_mode(ide_drive_t *drive, const u8 pio) | 98 | static void slc90e66_set_dma_mode(ide_drive_t *drive, const u8 speed) |
99 | { | ||
100 | slc90e66_tune_pio(drive, pio); | ||
101 | (void) ide_config_drive_speed(drive, XFER_PIO_0 + pio); | ||
102 | } | ||
103 | |||
104 | static int slc90e66_tune_chipset(ide_drive_t *drive, const u8 speed) | ||
105 | { | 99 | { |
106 | ide_hwif_t *hwif = HWIF(drive); | 100 | ide_hwif_t *hwif = HWIF(drive); |
107 | struct pci_dev *dev = hwif->pci_dev; | 101 | struct pci_dev *dev = hwif->pci_dev; |
@@ -125,7 +119,7 @@ static int slc90e66_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
125 | case XFER_MW_DMA_2: | 119 | case XFER_MW_DMA_2: |
126 | case XFER_MW_DMA_1: | 120 | case XFER_MW_DMA_1: |
127 | case XFER_SW_DMA_2: break; | 121 | case XFER_SW_DMA_2: break; |
128 | default: return -1; | 122 | default: return; |
129 | } | 123 | } |
130 | 124 | ||
131 | if (speed >= XFER_UDMA_0) { | 125 | if (speed >= XFER_UDMA_0) { |
@@ -144,9 +138,7 @@ static int slc90e66_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
144 | pci_write_config_word(dev, 0x4a, reg4a & ~a_speed); | 138 | pci_write_config_word(dev, 0x4a, reg4a & ~a_speed); |
145 | } | 139 | } |
146 | 140 | ||
147 | slc90e66_tune_pio(drive, slc90e66_dma_2_pio(speed)); | 141 | slc90e66_set_pio_mode(drive, slc90e66_dma_2_pio(speed)); |
148 | |||
149 | return ide_config_drive_speed(drive, speed); | ||
150 | } | 142 | } |
151 | 143 | ||
152 | static int slc90e66_config_drive_xfer_rate (ide_drive_t *drive) | 144 | static int slc90e66_config_drive_xfer_rate (ide_drive_t *drive) |
@@ -172,8 +164,8 @@ static void __devinit init_hwif_slc90e66 (ide_hwif_t *hwif) | |||
172 | if (!hwif->irq) | 164 | if (!hwif->irq) |
173 | hwif->irq = hwif->channel ? 15 : 14; | 165 | hwif->irq = hwif->channel ? 15 : 14; |
174 | 166 | ||
175 | hwif->speedproc = &slc90e66_tune_chipset; | ||
176 | hwif->set_pio_mode = &slc90e66_set_pio_mode; | 167 | hwif->set_pio_mode = &slc90e66_set_pio_mode; |
168 | hwif->set_dma_mode = &slc90e66_set_dma_mode; | ||
177 | 169 | ||
178 | pci_read_config_byte(hwif->pci_dev, 0x47, ®47); | 170 | pci_read_config_byte(hwif->pci_dev, 0x47, ®47); |
179 | 171 | ||
diff --git a/drivers/ide/pci/tc86c001.c b/drivers/ide/pci/tc86c001.c index e23b9cfb6eb4..840415d68d38 100644 --- a/drivers/ide/pci/tc86c001.c +++ b/drivers/ide/pci/tc86c001.c | |||
@@ -13,7 +13,7 @@ | |||
13 | #include <linux/pci.h> | 13 | #include <linux/pci.h> |
14 | #include <linux/ide.h> | 14 | #include <linux/ide.h> |
15 | 15 | ||
16 | static int tc86c001_tune_chipset(ide_drive_t *drive, const u8 speed) | 16 | static void tc86c001_set_mode(ide_drive_t *drive, const u8 speed) |
17 | { | 17 | { |
18 | ide_hwif_t *hwif = HWIF(drive); | 18 | ide_hwif_t *hwif = HWIF(drive); |
19 | unsigned long scr_port = hwif->config_data + (drive->dn ? 0x02 : 0x00); | 19 | unsigned long scr_port = hwif->config_data + (drive->dn ? 0x02 : 0x00); |
@@ -39,13 +39,11 @@ static int tc86c001_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
39 | scr &= (speed < XFER_MW_DMA_0) ? 0xf8ff : 0xff0f; | 39 | scr &= (speed < XFER_MW_DMA_0) ? 0xf8ff : 0xff0f; |
40 | scr |= mode; | 40 | scr |= mode; |
41 | outw(scr, scr_port); | 41 | outw(scr, scr_port); |
42 | |||
43 | return ide_config_drive_speed(drive, speed); | ||
44 | } | 42 | } |
45 | 43 | ||
46 | static void tc86c001_set_pio_mode(ide_drive_t *drive, const u8 pio) | 44 | static void tc86c001_set_pio_mode(ide_drive_t *drive, const u8 pio) |
47 | { | 45 | { |
48 | (void) tc86c001_tune_chipset(drive, XFER_PIO_0 + pio); | 46 | tc86c001_set_mode(drive, XFER_PIO_0 + pio); |
49 | } | 47 | } |
50 | 48 | ||
51 | /* | 49 | /* |
@@ -193,7 +191,8 @@ static void __devinit init_hwif_tc86c001(ide_hwif_t *hwif) | |||
193 | hwif->config_data = sc_base; | 191 | hwif->config_data = sc_base; |
194 | 192 | ||
195 | hwif->set_pio_mode = &tc86c001_set_pio_mode; | 193 | hwif->set_pio_mode = &tc86c001_set_pio_mode; |
196 | hwif->speedproc = &tc86c001_tune_chipset; | 194 | hwif->set_dma_mode = &tc86c001_set_mode; |
195 | |||
197 | hwif->busproc = &tc86c001_busproc; | 196 | hwif->busproc = &tc86c001_busproc; |
198 | 197 | ||
199 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; | 198 | hwif->drives[0].autotune = hwif->drives[1].autotune = 1; |
diff --git a/drivers/ide/pci/triflex.c b/drivers/ide/pci/triflex.c index c3ff066eea5a..54e411d4e56c 100644 --- a/drivers/ide/pci/triflex.c +++ b/drivers/ide/pci/triflex.c | |||
@@ -40,7 +40,7 @@ | |||
40 | #include <linux/ide.h> | 40 | #include <linux/ide.h> |
41 | #include <linux/init.h> | 41 | #include <linux/init.h> |
42 | 42 | ||
43 | static int triflex_tune_chipset(ide_drive_t *drive, const u8 speed) | 43 | static void triflex_set_mode(ide_drive_t *drive, const u8 speed) |
44 | { | 44 | { |
45 | ide_hwif_t *hwif = HWIF(drive); | 45 | ide_hwif_t *hwif = HWIF(drive); |
46 | struct pci_dev *dev = hwif->pci_dev; | 46 | struct pci_dev *dev = hwif->pci_dev; |
@@ -82,20 +82,18 @@ static int triflex_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
82 | timing = 0x0808; | 82 | timing = 0x0808; |
83 | break; | 83 | break; |
84 | default: | 84 | default: |
85 | return -1; | 85 | return; |
86 | } | 86 | } |
87 | 87 | ||
88 | triflex_timings &= ~(0xFFFF << (16 * unit)); | 88 | triflex_timings &= ~(0xFFFF << (16 * unit)); |
89 | triflex_timings |= (timing << (16 * unit)); | 89 | triflex_timings |= (timing << (16 * unit)); |
90 | 90 | ||
91 | pci_write_config_dword(dev, channel_offset, triflex_timings); | 91 | pci_write_config_dword(dev, channel_offset, triflex_timings); |
92 | |||
93 | return (ide_config_drive_speed(drive, speed)); | ||
94 | } | 92 | } |
95 | 93 | ||
96 | static void triflex_set_pio_mode(ide_drive_t *drive, const u8 pio) | 94 | static void triflex_set_pio_mode(ide_drive_t *drive, const u8 pio) |
97 | { | 95 | { |
98 | (void)triflex_tune_chipset(drive, XFER_PIO_0 + pio); | 96 | triflex_set_mode(drive, XFER_PIO_0 + pio); |
99 | } | 97 | } |
100 | 98 | ||
101 | static int triflex_config_drive_xfer_rate(ide_drive_t *drive) | 99 | static int triflex_config_drive_xfer_rate(ide_drive_t *drive) |
@@ -111,7 +109,7 @@ static int triflex_config_drive_xfer_rate(ide_drive_t *drive) | |||
111 | static void __devinit init_hwif_triflex(ide_hwif_t *hwif) | 109 | static void __devinit init_hwif_triflex(ide_hwif_t *hwif) |
112 | { | 110 | { |
113 | hwif->set_pio_mode = &triflex_set_pio_mode; | 111 | hwif->set_pio_mode = &triflex_set_pio_mode; |
114 | hwif->speedproc = &triflex_tune_chipset; | 112 | hwif->set_dma_mode = &triflex_set_mode; |
115 | 113 | ||
116 | if (hwif->dma_base == 0) | 114 | if (hwif->dma_base == 0) |
117 | return; | 115 | return; |
diff --git a/drivers/ide/pci/via82cxxx.c b/drivers/ide/pci/via82cxxx.c index 378feb491ec4..479e49661032 100644 --- a/drivers/ide/pci/via82cxxx.c +++ b/drivers/ide/pci/via82cxxx.c | |||
@@ -1,6 +1,6 @@ | |||
1 | /* | 1 | /* |
2 | * | 2 | * |
3 | * Version 3.48 | 3 | * Version 3.49 |
4 | * | 4 | * |
5 | * VIA IDE driver for Linux. Supported southbridges: | 5 | * VIA IDE driver for Linux. Supported southbridges: |
6 | * | 6 | * |
@@ -153,21 +153,17 @@ static void via_set_speed(ide_hwif_t *hwif, u8 dn, struct ide_timing *timing) | |||
153 | * @drive: Drive to set up | 153 | * @drive: Drive to set up |
154 | * @speed: desired speed | 154 | * @speed: desired speed |
155 | * | 155 | * |
156 | * via_set_drive() computes timing values configures the drive and | 156 | * via_set_drive() computes timing values configures the chipset to |
157 | * the chipset to a desired transfer mode. It also can be called | 157 | * a desired transfer mode. It also can be called by upper layers. |
158 | * by upper layers. | ||
159 | */ | 158 | */ |
160 | 159 | ||
161 | static int via_set_drive(ide_drive_t *drive, const u8 speed) | 160 | static void via_set_drive(ide_drive_t *drive, const u8 speed) |
162 | { | 161 | { |
163 | ide_drive_t *peer = HWIF(drive)->drives + (~drive->dn & 1); | 162 | ide_drive_t *peer = HWIF(drive)->drives + (~drive->dn & 1); |
164 | struct via82cxxx_dev *vdev = pci_get_drvdata(drive->hwif->pci_dev); | 163 | struct via82cxxx_dev *vdev = pci_get_drvdata(drive->hwif->pci_dev); |
165 | struct ide_timing t, p; | 164 | struct ide_timing t, p; |
166 | unsigned int T, UT; | 165 | unsigned int T, UT; |
167 | 166 | ||
168 | if (speed != XFER_PIO_SLOW) | ||
169 | ide_config_drive_speed(drive, speed); | ||
170 | |||
171 | T = 1000000000 / via_clock; | 167 | T = 1000000000 / via_clock; |
172 | 168 | ||
173 | switch (vdev->via_config->udma_mask) { | 169 | switch (vdev->via_config->udma_mask) { |
@@ -186,16 +182,10 @@ static int via_set_drive(ide_drive_t *drive, const u8 speed) | |||
186 | } | 182 | } |
187 | 183 | ||
188 | via_set_speed(HWIF(drive), drive->dn, &t); | 184 | via_set_speed(HWIF(drive), drive->dn, &t); |
189 | |||
190 | if (!drive->init_speed) | ||
191 | drive->init_speed = speed; | ||
192 | drive->current_speed = speed; | ||
193 | |||
194 | return 0; | ||
195 | } | 185 | } |
196 | 186 | ||
197 | /** | 187 | /** |
198 | * via_set_pio_mode - PIO setup | 188 | * via_set_pio_mode - set host controller for PIO mode |
199 | * @drive: drive | 189 | * @drive: drive |
200 | * @pio: PIO mode number | 190 | * @pio: PIO mode number |
201 | * | 191 | * |
@@ -456,8 +446,7 @@ static void __devinit init_hwif_via82cxxx(ide_hwif_t *hwif) | |||
456 | hwif->autodma = 0; | 446 | hwif->autodma = 0; |
457 | 447 | ||
458 | hwif->set_pio_mode = &via_set_pio_mode; | 448 | hwif->set_pio_mode = &via_set_pio_mode; |
459 | hwif->speedproc = &via_set_drive; | 449 | hwif->set_dma_mode = &via_set_drive; |
460 | |||
461 | 450 | ||
462 | #ifdef CONFIG_PPC_CHRP | 451 | #ifdef CONFIG_PPC_CHRP |
463 | if(machine_is(chrp) && _chrp_type == _CHRP_Pegasos) { | 452 | if(machine_is(chrp) && _chrp_type == _CHRP_Pegasos) { |
@@ -500,7 +489,8 @@ static ide_pci_device_t via82cxxx_chipsets[] __devinitdata = { | |||
500 | .enablebits = {{0x40,0x02,0x02}, {0x40,0x01,0x01}}, | 489 | .enablebits = {{0x40,0x02,0x02}, {0x40,0x01,0x01}}, |
501 | .bootable = ON_BOARD, | 490 | .bootable = ON_BOARD, |
502 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST | 491 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST |
503 | | IDE_HFLAG_PIO_NO_DOWNGRADE, | 492 | | IDE_HFLAG_PIO_NO_DOWNGRADE |
493 | | IDE_HFLAG_POST_SET_MODE, | ||
504 | .pio_mask = ATA_PIO5, | 494 | .pio_mask = ATA_PIO5, |
505 | },{ /* 1 */ | 495 | },{ /* 1 */ |
506 | .name = "VP_IDE", | 496 | .name = "VP_IDE", |
@@ -510,7 +500,8 @@ static ide_pci_device_t via82cxxx_chipsets[] __devinitdata = { | |||
510 | .enablebits = {{0x00,0x00,0x00}, {0x00,0x00,0x00}}, | 500 | .enablebits = {{0x00,0x00,0x00}, {0x00,0x00,0x00}}, |
511 | .bootable = ON_BOARD, | 501 | .bootable = ON_BOARD, |
512 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST | 502 | .host_flags = IDE_HFLAG_PIO_NO_BLACKLIST |
513 | | IDE_HFLAG_PIO_NO_DOWNGRADE, | 503 | | IDE_HFLAG_PIO_NO_DOWNGRADE |
504 | | IDE_HFLAG_POST_SET_MODE, | ||
514 | .pio_mask = ATA_PIO5, | 505 | .pio_mask = ATA_PIO5, |
515 | } | 506 | } |
516 | }; | 507 | }; |
diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c index f759a5397865..7d8873839e21 100644 --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide/ppc/pmac.c | |||
@@ -392,6 +392,7 @@ kauai_lookup_timing(struct kauai_timing* table, int cycle_time) | |||
392 | for (i=0; table[i].cycle_time; i++) | 392 | for (i=0; table[i].cycle_time; i++) |
393 | if (cycle_time > table[i+1].cycle_time) | 393 | if (cycle_time > table[i+1].cycle_time) |
394 | return table[i].timing_reg; | 394 | return table[i].timing_reg; |
395 | BUG(); | ||
395 | return 0; | 396 | return 0; |
396 | } | 397 | } |
397 | 398 | ||
@@ -529,97 +530,12 @@ pmac_outbsync(ide_drive_t *drive, u8 value, unsigned long port) | |||
529 | } | 530 | } |
530 | 531 | ||
531 | /* | 532 | /* |
532 | * Send the SET_FEATURE IDE command to the drive and update drive->id with | ||
533 | * the new state. We currently don't use the generic routine as it used to | ||
534 | * cause various trouble, especially with older mediabays. | ||
535 | * This code is sometimes triggering a spurrious interrupt though, I need | ||
536 | * to sort that out sooner or later and see if I can finally get the | ||
537 | * common version to work properly in all cases | ||
538 | */ | ||
539 | static int | ||
540 | pmac_ide_do_setfeature(ide_drive_t *drive, u8 command) | ||
541 | { | ||
542 | ide_hwif_t *hwif = HWIF(drive); | ||
543 | int result = 1; | ||
544 | |||
545 | disable_irq_nosync(hwif->irq); | ||
546 | udelay(1); | ||
547 | SELECT_DRIVE(drive); | ||
548 | SELECT_MASK(drive, 0); | ||
549 | udelay(1); | ||
550 | /* Get rid of pending error state */ | ||
551 | (void) hwif->INB(IDE_STATUS_REG); | ||
552 | /* Timeout bumped for some powerbooks */ | ||
553 | if (wait_for_ready(drive, 2000)) { | ||
554 | /* Timeout bumped for some powerbooks */ | ||
555 | printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready " | ||
556 | "before SET_FEATURE!\n", drive->name); | ||
557 | goto out; | ||
558 | } | ||
559 | udelay(10); | ||
560 | hwif->OUTB(drive->ctl | 2, IDE_CONTROL_REG); | ||
561 | hwif->OUTB(command, IDE_NSECTOR_REG); | ||
562 | hwif->OUTB(SETFEATURES_XFER, IDE_FEATURE_REG); | ||
563 | hwif->OUTBSYNC(drive, WIN_SETFEATURES, IDE_COMMAND_REG); | ||
564 | udelay(1); | ||
565 | /* Timeout bumped for some powerbooks */ | ||
566 | result = wait_for_ready(drive, 2000); | ||
567 | hwif->OUTB(drive->ctl, IDE_CONTROL_REG); | ||
568 | if (result) | ||
569 | printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready " | ||
570 | "after SET_FEATURE !\n", drive->name); | ||
571 | out: | ||
572 | SELECT_MASK(drive, 0); | ||
573 | if (result == 0) { | ||
574 | drive->id->dma_ultra &= ~0xFF00; | ||
575 | drive->id->dma_mword &= ~0x0F00; | ||
576 | drive->id->dma_1word &= ~0x0F00; | ||
577 | switch(command) { | ||
578 | case XFER_UDMA_7: | ||
579 | drive->id->dma_ultra |= 0x8080; break; | ||
580 | case XFER_UDMA_6: | ||
581 | drive->id->dma_ultra |= 0x4040; break; | ||
582 | case XFER_UDMA_5: | ||
583 | drive->id->dma_ultra |= 0x2020; break; | ||
584 | case XFER_UDMA_4: | ||
585 | drive->id->dma_ultra |= 0x1010; break; | ||
586 | case XFER_UDMA_3: | ||
587 | drive->id->dma_ultra |= 0x0808; break; | ||
588 | case XFER_UDMA_2: | ||
589 | drive->id->dma_ultra |= 0x0404; break; | ||
590 | case XFER_UDMA_1: | ||
591 | drive->id->dma_ultra |= 0x0202; break; | ||
592 | case XFER_UDMA_0: | ||
593 | drive->id->dma_ultra |= 0x0101; break; | ||
594 | case XFER_MW_DMA_2: | ||
595 | drive->id->dma_mword |= 0x0404; break; | ||
596 | case XFER_MW_DMA_1: | ||
597 | drive->id->dma_mword |= 0x0202; break; | ||
598 | case XFER_MW_DMA_0: | ||
599 | drive->id->dma_mword |= 0x0101; break; | ||
600 | case XFER_SW_DMA_2: | ||
601 | drive->id->dma_1word |= 0x0404; break; | ||
602 | case XFER_SW_DMA_1: | ||
603 | drive->id->dma_1word |= 0x0202; break; | ||
604 | case XFER_SW_DMA_0: | ||
605 | drive->id->dma_1word |= 0x0101; break; | ||
606 | default: break; | ||
607 | } | ||
608 | if (!drive->init_speed) | ||
609 | drive->init_speed = command; | ||
610 | drive->current_speed = command; | ||
611 | } | ||
612 | enable_irq(hwif->irq); | ||
613 | return result; | ||
614 | } | ||
615 | |||
616 | /* | ||
617 | * Old tuning functions (called on hdparm -p), sets up drive PIO timings | 533 | * Old tuning functions (called on hdparm -p), sets up drive PIO timings |
618 | */ | 534 | */ |
619 | static void | 535 | static void |
620 | pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio) | 536 | pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio) |
621 | { | 537 | { |
622 | u32 *timings; | 538 | u32 *timings, t; |
623 | unsigned accessTicks, recTicks; | 539 | unsigned accessTicks, recTicks; |
624 | unsigned accessTime, recTime; | 540 | unsigned accessTime, recTime; |
625 | pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)HWIF(drive)->hwif_data; | 541 | pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)HWIF(drive)->hwif_data; |
@@ -630,6 +546,7 @@ pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
630 | 546 | ||
631 | /* which drive is it ? */ | 547 | /* which drive is it ? */ |
632 | timings = &pmif->timings[drive->select.b.unit & 0x01]; | 548 | timings = &pmif->timings[drive->select.b.unit & 0x01]; |
549 | t = *timings; | ||
633 | 550 | ||
634 | cycle_time = ide_pio_cycle_time(drive, pio); | 551 | cycle_time = ide_pio_cycle_time(drive, pio); |
635 | 552 | ||
@@ -637,18 +554,14 @@ pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
637 | case controller_sh_ata6: { | 554 | case controller_sh_ata6: { |
638 | /* 133Mhz cell */ | 555 | /* 133Mhz cell */ |
639 | u32 tr = kauai_lookup_timing(shasta_pio_timings, cycle_time); | 556 | u32 tr = kauai_lookup_timing(shasta_pio_timings, cycle_time); |
640 | if (tr == 0) | 557 | t = (t & ~TR_133_PIOREG_PIO_MASK) | tr; |
641 | return; | ||
642 | *timings = ((*timings) & ~TR_133_PIOREG_PIO_MASK) | tr; | ||
643 | break; | 558 | break; |
644 | } | 559 | } |
645 | case controller_un_ata6: | 560 | case controller_un_ata6: |
646 | case controller_k2_ata6: { | 561 | case controller_k2_ata6: { |
647 | /* 100Mhz cell */ | 562 | /* 100Mhz cell */ |
648 | u32 tr = kauai_lookup_timing(kauai_pio_timings, cycle_time); | 563 | u32 tr = kauai_lookup_timing(kauai_pio_timings, cycle_time); |
649 | if (tr == 0) | 564 | t = (t & ~TR_100_PIOREG_PIO_MASK) | tr; |
650 | return; | ||
651 | *timings = ((*timings) & ~TR_100_PIOREG_PIO_MASK) | tr; | ||
652 | break; | 565 | break; |
653 | } | 566 | } |
654 | case controller_kl_ata4: | 567 | case controller_kl_ata4: |
@@ -662,9 +575,9 @@ pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
662 | accessTicks = min(accessTicks, 0x1fU); | 575 | accessTicks = min(accessTicks, 0x1fU); |
663 | recTicks = SYSCLK_TICKS_66(recTime); | 576 | recTicks = SYSCLK_TICKS_66(recTime); |
664 | recTicks = min(recTicks, 0x1fU); | 577 | recTicks = min(recTicks, 0x1fU); |
665 | *timings = ((*timings) & ~TR_66_PIO_MASK) | | 578 | t = (t & ~TR_66_PIO_MASK) | |
666 | (accessTicks << TR_66_PIO_ACCESS_SHIFT) | | 579 | (accessTicks << TR_66_PIO_ACCESS_SHIFT) | |
667 | (recTicks << TR_66_PIO_RECOVERY_SHIFT); | 580 | (recTicks << TR_66_PIO_RECOVERY_SHIFT); |
668 | break; | 581 | break; |
669 | default: { | 582 | default: { |
670 | /* 33Mhz cell */ | 583 | /* 33Mhz cell */ |
@@ -684,11 +597,11 @@ pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
684 | recTicks--; /* guess, but it's only for PIO0, so... */ | 597 | recTicks--; /* guess, but it's only for PIO0, so... */ |
685 | ebit = 1; | 598 | ebit = 1; |
686 | } | 599 | } |
687 | *timings = ((*timings) & ~TR_33_PIO_MASK) | | 600 | t = (t & ~TR_33_PIO_MASK) | |
688 | (accessTicks << TR_33_PIO_ACCESS_SHIFT) | | 601 | (accessTicks << TR_33_PIO_ACCESS_SHIFT) | |
689 | (recTicks << TR_33_PIO_RECOVERY_SHIFT); | 602 | (recTicks << TR_33_PIO_RECOVERY_SHIFT); |
690 | if (ebit) | 603 | if (ebit) |
691 | *timings |= TR_33_PIO_E; | 604 | t |= TR_33_PIO_E; |
692 | break; | 605 | break; |
693 | } | 606 | } |
694 | } | 607 | } |
@@ -698,9 +611,7 @@ pmac_ide_set_pio_mode(ide_drive_t *drive, const u8 pio) | |||
698 | drive->name, pio, *timings); | 611 | drive->name, pio, *timings); |
699 | #endif | 612 | #endif |
700 | 613 | ||
701 | if (pmac_ide_do_setfeature(drive, XFER_PIO_0 + pio)) | 614 | *timings = t; |
702 | return; | ||
703 | |||
704 | pmac_ide_do_update_timings(drive); | 615 | pmac_ide_do_update_timings(drive); |
705 | } | 616 | } |
706 | 617 | ||
@@ -746,8 +657,6 @@ set_timings_udma_ata6(u32 *pio_timings, u32 *ultra_timings, u8 speed) | |||
746 | if (speed > XFER_UDMA_5 || t == NULL) | 657 | if (speed > XFER_UDMA_5 || t == NULL) |
747 | return 1; | 658 | return 1; |
748 | tr = kauai_lookup_timing(kauai_udma_timings, (int)t->udma); | 659 | tr = kauai_lookup_timing(kauai_udma_timings, (int)t->udma); |
749 | if (tr == 0) | ||
750 | return 1; | ||
751 | *ultra_timings = ((*ultra_timings) & ~TR_100_UDMAREG_UDMA_MASK) | tr; | 660 | *ultra_timings = ((*ultra_timings) & ~TR_100_UDMAREG_UDMA_MASK) | tr; |
752 | *ultra_timings = (*ultra_timings) | TR_100_UDMAREG_UDMA_EN; | 661 | *ultra_timings = (*ultra_timings) | TR_100_UDMAREG_UDMA_EN; |
753 | 662 | ||
@@ -766,8 +675,6 @@ set_timings_udma_shasta(u32 *pio_timings, u32 *ultra_timings, u8 speed) | |||
766 | if (speed > XFER_UDMA_6 || t == NULL) | 675 | if (speed > XFER_UDMA_6 || t == NULL) |
767 | return 1; | 676 | return 1; |
768 | tr = kauai_lookup_timing(shasta_udma133_timings, (int)t->udma); | 677 | tr = kauai_lookup_timing(shasta_udma133_timings, (int)t->udma); |
769 | if (tr == 0) | ||
770 | return 1; | ||
771 | *ultra_timings = ((*ultra_timings) & ~TR_133_UDMAREG_UDMA_MASK) | tr; | 678 | *ultra_timings = ((*ultra_timings) & ~TR_133_UDMAREG_UDMA_MASK) | tr; |
772 | *ultra_timings = (*ultra_timings) | TR_133_UDMAREG_UDMA_EN; | 679 | *ultra_timings = (*ultra_timings) | TR_133_UDMAREG_UDMA_EN; |
773 | 680 | ||
@@ -777,12 +684,13 @@ set_timings_udma_shasta(u32 *pio_timings, u32 *ultra_timings, u8 speed) | |||
777 | /* | 684 | /* |
778 | * Calculate MDMA timings for all cells | 685 | * Calculate MDMA timings for all cells |
779 | */ | 686 | */ |
780 | static int | 687 | static void |
781 | set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, | 688 | set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, |
782 | u8 speed, int drive_cycle_time) | 689 | u8 speed) |
783 | { | 690 | { |
784 | int cycleTime, accessTime = 0, recTime = 0; | 691 | int cycleTime, accessTime = 0, recTime = 0; |
785 | unsigned accessTicks, recTicks; | 692 | unsigned accessTicks, recTicks; |
693 | struct hd_driveid *id = drive->id; | ||
786 | struct mdma_timings_t* tm = NULL; | 694 | struct mdma_timings_t* tm = NULL; |
787 | int i; | 695 | int i; |
788 | 696 | ||
@@ -792,11 +700,14 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, | |||
792 | case 1: cycleTime = 150; break; | 700 | case 1: cycleTime = 150; break; |
793 | case 2: cycleTime = 120; break; | 701 | case 2: cycleTime = 120; break; |
794 | default: | 702 | default: |
795 | return 1; | 703 | BUG(); |
704 | break; | ||
796 | } | 705 | } |
797 | /* Adjust for drive */ | 706 | |
798 | if (drive_cycle_time && drive_cycle_time > cycleTime) | 707 | /* Check if drive provides explicit DMA cycle time */ |
799 | cycleTime = drive_cycle_time; | 708 | if ((id->field_valid & 2) && id->eide_dma_time) |
709 | cycleTime = max_t(int, id->eide_dma_time, cycleTime); | ||
710 | |||
800 | /* OHare limits according to some old Apple sources */ | 711 | /* OHare limits according to some old Apple sources */ |
801 | if ((intf_type == controller_ohare) && (cycleTime < 150)) | 712 | if ((intf_type == controller_ohare) && (cycleTime < 150)) |
802 | cycleTime = 150; | 713 | cycleTime = 150; |
@@ -824,8 +735,6 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, | |||
824 | break; | 735 | break; |
825 | i++; | 736 | i++; |
826 | } | 737 | } |
827 | if (i < 0) | ||
828 | return 1; | ||
829 | cycleTime = tm[i].cycleTime; | 738 | cycleTime = tm[i].cycleTime; |
830 | accessTime = tm[i].accessTime; | 739 | accessTime = tm[i].accessTime; |
831 | recTime = tm[i].recoveryTime; | 740 | recTime = tm[i].recoveryTime; |
@@ -839,8 +748,6 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, | |||
839 | case controller_sh_ata6: { | 748 | case controller_sh_ata6: { |
840 | /* 133Mhz cell */ | 749 | /* 133Mhz cell */ |
841 | u32 tr = kauai_lookup_timing(shasta_mdma_timings, cycleTime); | 750 | u32 tr = kauai_lookup_timing(shasta_mdma_timings, cycleTime); |
842 | if (tr == 0) | ||
843 | return 1; | ||
844 | *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr; | 751 | *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr; |
845 | *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN; | 752 | *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN; |
846 | } | 753 | } |
@@ -848,8 +755,6 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, | |||
848 | case controller_k2_ata6: { | 755 | case controller_k2_ata6: { |
849 | /* 100Mhz cell */ | 756 | /* 100Mhz cell */ |
850 | u32 tr = kauai_lookup_timing(kauai_mdma_timings, cycleTime); | 757 | u32 tr = kauai_lookup_timing(kauai_mdma_timings, cycleTime); |
851 | if (tr == 0) | ||
852 | return 1; | ||
853 | *timings = ((*timings) & ~TR_100_PIOREG_MDMA_MASK) | tr; | 758 | *timings = ((*timings) & ~TR_100_PIOREG_MDMA_MASK) | tr; |
854 | *timings2 = (*timings2) & ~TR_100_UDMAREG_UDMA_EN; | 759 | *timings2 = (*timings2) & ~TR_100_UDMAREG_UDMA_EN; |
855 | } | 760 | } |
@@ -911,30 +816,23 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, | |||
911 | printk(KERN_ERR "%s: Set MDMA timing for mode %d, reg: 0x%08x\n", | 816 | printk(KERN_ERR "%s: Set MDMA timing for mode %d, reg: 0x%08x\n", |
912 | drive->name, speed & 0xf, *timings); | 817 | drive->name, speed & 0xf, *timings); |
913 | #endif | 818 | #endif |
914 | return 0; | ||
915 | } | 819 | } |
916 | #endif /* #ifdef CONFIG_BLK_DEV_IDEDMA_PMAC */ | 820 | #endif /* #ifdef CONFIG_BLK_DEV_IDEDMA_PMAC */ |
917 | 821 | ||
918 | /* | 822 | static void pmac_ide_set_dma_mode(ide_drive_t *drive, const u8 speed) |
919 | * Speedproc. This function is called by the core to set any of the standard | ||
920 | * DMA timing (MDMA or UDMA) to both the drive and the controller. | ||
921 | * You may notice we don't use this function on normal "dma check" operation, | ||
922 | * our dedicated function is more precise as it uses the drive provided | ||
923 | * cycle time value. We should probably fix this one to deal with that too... | ||
924 | */ | ||
925 | static int pmac_ide_tune_chipset(ide_drive_t *drive, const u8 speed) | ||
926 | { | 823 | { |
927 | int unit = (drive->select.b.unit & 0x01); | 824 | int unit = (drive->select.b.unit & 0x01); |
928 | int ret = 0; | 825 | int ret = 0; |
929 | pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)HWIF(drive)->hwif_data; | 826 | pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)HWIF(drive)->hwif_data; |
930 | u32 *timings, *timings2; | 827 | u32 *timings, *timings2, tl[2]; |
931 | 828 | ||
932 | if (pmif == NULL) | ||
933 | return 1; | ||
934 | |||
935 | timings = &pmif->timings[unit]; | 829 | timings = &pmif->timings[unit]; |
936 | timings2 = &pmif->timings[unit+2]; | 830 | timings2 = &pmif->timings[unit+2]; |
937 | 831 | ||
832 | /* Copy timings to local image */ | ||
833 | tl[0] = *timings; | ||
834 | tl[1] = *timings2; | ||
835 | |||
938 | switch(speed) { | 836 | switch(speed) { |
939 | #ifdef CONFIG_BLK_DEV_IDEDMA_PMAC | 837 | #ifdef CONFIG_BLK_DEV_IDEDMA_PMAC |
940 | case XFER_UDMA_6: | 838 | case XFER_UDMA_6: |
@@ -945,38 +843,36 @@ static int pmac_ide_tune_chipset(ide_drive_t *drive, const u8 speed) | |||
945 | case XFER_UDMA_1: | 843 | case XFER_UDMA_1: |
946 | case XFER_UDMA_0: | 844 | case XFER_UDMA_0: |
947 | if (pmif->kind == controller_kl_ata4) | 845 | if (pmif->kind == controller_kl_ata4) |
948 | ret = set_timings_udma_ata4(timings, speed); | 846 | ret = set_timings_udma_ata4(&tl[0], speed); |
949 | else if (pmif->kind == controller_un_ata6 | 847 | else if (pmif->kind == controller_un_ata6 |
950 | || pmif->kind == controller_k2_ata6) | 848 | || pmif->kind == controller_k2_ata6) |
951 | ret = set_timings_udma_ata6(timings, timings2, speed); | 849 | ret = set_timings_udma_ata6(&tl[0], &tl[1], speed); |
952 | else if (pmif->kind == controller_sh_ata6) | 850 | else if (pmif->kind == controller_sh_ata6) |
953 | ret = set_timings_udma_shasta(timings, timings2, speed); | 851 | ret = set_timings_udma_shasta(&tl[0], &tl[1], speed); |
954 | else | 852 | else |
955 | ret = 1; | 853 | ret = 1; |
956 | break; | 854 | break; |
957 | case XFER_MW_DMA_2: | 855 | case XFER_MW_DMA_2: |
958 | case XFER_MW_DMA_1: | 856 | case XFER_MW_DMA_1: |
959 | case XFER_MW_DMA_0: | 857 | case XFER_MW_DMA_0: |
960 | ret = set_timings_mdma(drive, pmif->kind, timings, timings2, speed, 0); | 858 | set_timings_mdma(drive, pmif->kind, &tl[0], &tl[1], speed); |
961 | break; | 859 | break; |
962 | case XFER_SW_DMA_2: | 860 | case XFER_SW_DMA_2: |
963 | case XFER_SW_DMA_1: | 861 | case XFER_SW_DMA_1: |
964 | case XFER_SW_DMA_0: | 862 | case XFER_SW_DMA_0: |
965 | return 1; | 863 | return; |
966 | #endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */ | 864 | #endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */ |
967 | default: | 865 | default: |
968 | ret = 1; | 866 | ret = 1; |
969 | } | 867 | } |
970 | if (ret) | 868 | if (ret) |
971 | return ret; | 869 | return; |
972 | 870 | ||
973 | ret = pmac_ide_do_setfeature(drive, speed); | 871 | /* Apply timings to controller */ |
974 | if (ret) | 872 | *timings = tl[0]; |
975 | return ret; | 873 | *timings2 = tl[1]; |
976 | |||
977 | pmac_ide_do_update_timings(drive); | ||
978 | 874 | ||
979 | return 0; | 875 | pmac_ide_do_update_timings(drive); |
980 | } | 876 | } |
981 | 877 | ||
982 | /* | 878 | /* |
@@ -1236,6 +1132,10 @@ pmac_ide_setup_device(pmac_ide_hwif_t *pmif, ide_hwif_t *hwif) | |||
1236 | hwif->cbl = pmif->cable_80 ? ATA_CBL_PATA80 : ATA_CBL_PATA40; | 1132 | hwif->cbl = pmif->cable_80 ? ATA_CBL_PATA80 : ATA_CBL_PATA40; |
1237 | hwif->drives[0].unmask = 1; | 1133 | hwif->drives[0].unmask = 1; |
1238 | hwif->drives[1].unmask = 1; | 1134 | hwif->drives[1].unmask = 1; |
1135 | hwif->drives[0].autotune = IDE_TUNE_AUTO; | ||
1136 | hwif->drives[1].autotune = IDE_TUNE_AUTO; | ||
1137 | hwif->host_flags = IDE_HFLAG_SET_PIO_MODE_KEEP_DMA | | ||
1138 | IDE_HFLAG_POST_SET_MODE; | ||
1239 | hwif->pio_mask = ATA_PIO4; | 1139 | hwif->pio_mask = ATA_PIO4; |
1240 | hwif->set_pio_mode = pmac_ide_set_pio_mode; | 1140 | hwif->set_pio_mode = pmac_ide_set_pio_mode; |
1241 | if (pmif->kind == controller_un_ata6 | 1141 | if (pmif->kind == controller_un_ata6 |
@@ -1244,7 +1144,7 @@ pmac_ide_setup_device(pmac_ide_hwif_t *pmif, ide_hwif_t *hwif) | |||
1244 | hwif->selectproc = pmac_ide_kauai_selectproc; | 1144 | hwif->selectproc = pmac_ide_kauai_selectproc; |
1245 | else | 1145 | else |
1246 | hwif->selectproc = pmac_ide_selectproc; | 1146 | hwif->selectproc = pmac_ide_selectproc; |
1247 | hwif->speedproc = pmac_ide_tune_chipset; | 1147 | hwif->set_dma_mode = pmac_ide_set_dma_mode; |
1248 | 1148 | ||
1249 | printk(KERN_INFO "ide%d: Found Apple %s controller, bus ID %d%s, irq %d\n", | 1149 | printk(KERN_INFO "ide%d: Found Apple %s controller, bus ID %d%s, irq %d\n", |
1250 | hwif->index, model_name[pmif->kind], pmif->aapl_bus_id, | 1150 | hwif->index, model_name[pmif->kind], pmif->aapl_bus_id, |
@@ -1679,138 +1579,16 @@ pmac_ide_destroy_dmatable (ide_drive_t *drive) | |||
1679 | } | 1579 | } |
1680 | 1580 | ||
1681 | /* | 1581 | /* |
1682 | * Pick up best MDMA timing for the drive and apply it | ||
1683 | */ | ||
1684 | static int | ||
1685 | pmac_ide_mdma_enable(ide_drive_t *drive, u16 mode) | ||
1686 | { | ||
1687 | ide_hwif_t *hwif = HWIF(drive); | ||
1688 | pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)hwif->hwif_data; | ||
1689 | int drive_cycle_time; | ||
1690 | struct hd_driveid *id = drive->id; | ||
1691 | u32 *timings, *timings2; | ||
1692 | u32 timing_local[2]; | ||
1693 | int ret; | ||
1694 | |||
1695 | /* which drive is it ? */ | ||
1696 | timings = &pmif->timings[drive->select.b.unit & 0x01]; | ||
1697 | timings2 = &pmif->timings[(drive->select.b.unit & 0x01) + 2]; | ||
1698 | |||
1699 | /* Check if drive provide explicit cycle time */ | ||
1700 | if ((id->field_valid & 2) && (id->eide_dma_time)) | ||
1701 | drive_cycle_time = id->eide_dma_time; | ||
1702 | else | ||
1703 | drive_cycle_time = 0; | ||
1704 | |||
1705 | /* Copy timings to local image */ | ||
1706 | timing_local[0] = *timings; | ||
1707 | timing_local[1] = *timings2; | ||
1708 | |||
1709 | /* Calculate controller timings */ | ||
1710 | ret = set_timings_mdma( drive, pmif->kind, | ||
1711 | &timing_local[0], | ||
1712 | &timing_local[1], | ||
1713 | mode, | ||
1714 | drive_cycle_time); | ||
1715 | if (ret) | ||
1716 | return 0; | ||
1717 | |||
1718 | /* Set feature on drive */ | ||
1719 | printk(KERN_INFO "%s: Enabling MultiWord DMA %d\n", drive->name, mode & 0xf); | ||
1720 | ret = pmac_ide_do_setfeature(drive, mode); | ||
1721 | if (ret) { | ||
1722 | printk(KERN_WARNING "%s: Failed !\n", drive->name); | ||
1723 | return 0; | ||
1724 | } | ||
1725 | |||
1726 | /* Apply timings to controller */ | ||
1727 | *timings = timing_local[0]; | ||
1728 | *timings2 = timing_local[1]; | ||
1729 | |||
1730 | return 1; | ||
1731 | } | ||
1732 | |||
1733 | /* | ||
1734 | * Pick up best UDMA timing for the drive and apply it | ||
1735 | */ | ||
1736 | static int | ||
1737 | pmac_ide_udma_enable(ide_drive_t *drive, u16 mode) | ||
1738 | { | ||
1739 | ide_hwif_t *hwif = HWIF(drive); | ||
1740 | pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)hwif->hwif_data; | ||
1741 | u32 *timings, *timings2; | ||
1742 | u32 timing_local[2]; | ||
1743 | int ret; | ||
1744 | |||
1745 | /* which drive is it ? */ | ||
1746 | timings = &pmif->timings[drive->select.b.unit & 0x01]; | ||
1747 | timings2 = &pmif->timings[(drive->select.b.unit & 0x01) + 2]; | ||
1748 | |||
1749 | /* Copy timings to local image */ | ||
1750 | timing_local[0] = *timings; | ||
1751 | timing_local[1] = *timings2; | ||
1752 | |||
1753 | /* Calculate timings for interface */ | ||
1754 | if (pmif->kind == controller_un_ata6 | ||
1755 | || pmif->kind == controller_k2_ata6) | ||
1756 | ret = set_timings_udma_ata6( &timing_local[0], | ||
1757 | &timing_local[1], | ||
1758 | mode); | ||
1759 | else if (pmif->kind == controller_sh_ata6) | ||
1760 | ret = set_timings_udma_shasta( &timing_local[0], | ||
1761 | &timing_local[1], | ||
1762 | mode); | ||
1763 | else | ||
1764 | ret = set_timings_udma_ata4(&timing_local[0], mode); | ||
1765 | if (ret) | ||
1766 | return 0; | ||
1767 | |||
1768 | /* Set feature on drive */ | ||
1769 | printk(KERN_INFO "%s: Enabling Ultra DMA %d\n", drive->name, mode & 0x0f); | ||
1770 | ret = pmac_ide_do_setfeature(drive, mode); | ||
1771 | if (ret) { | ||
1772 | printk(KERN_WARNING "%s: Failed !\n", drive->name); | ||
1773 | return 0; | ||
1774 | } | ||
1775 | |||
1776 | /* Apply timings to controller */ | ||
1777 | *timings = timing_local[0]; | ||
1778 | *timings2 = timing_local[1]; | ||
1779 | |||
1780 | return 1; | ||
1781 | } | ||
1782 | |||
1783 | /* | ||
1784 | * Check what is the best DMA timing setting for the drive and | 1582 | * Check what is the best DMA timing setting for the drive and |
1785 | * call appropriate functions to apply it. | 1583 | * call appropriate functions to apply it. |
1786 | */ | 1584 | */ |
1787 | static int | 1585 | static int |
1788 | pmac_ide_dma_check(ide_drive_t *drive) | 1586 | pmac_ide_dma_check(ide_drive_t *drive) |
1789 | { | 1587 | { |
1790 | struct hd_driveid *id = drive->id; | 1588 | if (ide_tune_dma(drive)) |
1791 | ide_hwif_t *hwif = HWIF(drive); | 1589 | return 0; |
1792 | int enable = 1; | 1590 | |
1793 | drive->using_dma = 0; | 1591 | return -1; |
1794 | |||
1795 | if (drive->media == ide_floppy) | ||
1796 | enable = 0; | ||
1797 | if (((id->capability & 1) == 0) && !__ide_dma_good_drive(drive)) | ||
1798 | enable = 0; | ||
1799 | if (__ide_dma_bad_drive(drive)) | ||
1800 | enable = 0; | ||
1801 | |||
1802 | if (enable) { | ||
1803 | u8 mode = ide_max_dma_mode(drive); | ||
1804 | |||
1805 | if (mode >= XFER_UDMA_0) | ||
1806 | drive->using_dma = pmac_ide_udma_enable(drive, mode); | ||
1807 | else if (mode >= XFER_MW_DMA_0) | ||
1808 | drive->using_dma = pmac_ide_mdma_enable(drive, mode); | ||
1809 | hwif->OUTB(0, IDE_CONTROL_REG); | ||
1810 | /* Apply settings to controller */ | ||
1811 | pmac_ide_do_update_timings(drive); | ||
1812 | } | ||
1813 | return 0; | ||
1814 | } | 1592 | } |
1815 | 1593 | ||
1816 | /* | 1594 | /* |
@@ -2044,7 +1822,10 @@ pmac_ide_setup_dma(pmac_ide_hwif_t *pmif, ide_hwif_t *hwif) | |||
2044 | hwif->mwdma_mask = 0x07; | 1822 | hwif->mwdma_mask = 0x07; |
2045 | hwif->swdma_mask = 0x00; | 1823 | hwif->swdma_mask = 0x00; |
2046 | break; | 1824 | break; |
2047 | } | 1825 | } |
1826 | |||
1827 | hwif->autodma = 1; | ||
1828 | hwif->drives[1].autodma = hwif->drives[0].autodma = hwif->autodma; | ||
2048 | } | 1829 | } |
2049 | 1830 | ||
2050 | #endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */ | 1831 | #endif /* CONFIG_BLK_DEV_IDEDMA_PMAC */ |
diff --git a/include/linux/ide.h b/include/linux/ide.h index 85d448b4abec..02a27e8cbad2 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h | |||
@@ -681,7 +681,7 @@ typedef struct hwif_s { | |||
681 | u8 straight8; /* Alan's straight 8 check */ | 681 | u8 straight8; /* Alan's straight 8 check */ |
682 | u8 bus_state; /* power state of the IDE bus */ | 682 | u8 bus_state; /* power state of the IDE bus */ |
683 | 683 | ||
684 | u8 host_flags; | 684 | u16 host_flags; |
685 | 685 | ||
686 | u8 pio_mask; | 686 | u8 pio_mask; |
687 | 687 | ||
@@ -702,10 +702,10 @@ typedef struct hwif_s { | |||
702 | #if 0 | 702 | #if 0 |
703 | ide_hwif_ops_t *hwifops; | 703 | ide_hwif_ops_t *hwifops; |
704 | #else | 704 | #else |
705 | /* routine to set PIO mode for drives */ | 705 | /* routine to program host for PIO mode */ |
706 | void (*set_pio_mode)(ide_drive_t *, const u8); | 706 | void (*set_pio_mode)(ide_drive_t *, const u8); |
707 | /* routine to retune DMA modes for drives */ | 707 | /* routine to program host for DMA mode */ |
708 | int (*speedproc)(ide_drive_t *, const u8); | 708 | void (*set_dma_mode)(ide_drive_t *, const u8); |
709 | /* tweaks hardware to select drive */ | 709 | /* tweaks hardware to select drive */ |
710 | void (*selectproc)(ide_drive_t *); | 710 | void (*selectproc)(ide_drive_t *); |
711 | /* chipset polling based on hba specifics */ | 711 | /* chipset polling based on hba specifics */ |
@@ -1079,16 +1079,7 @@ extern void ide_fix_driveid(struct hd_driveid *); | |||
1079 | */ | 1079 | */ |
1080 | extern void ide_fixstring(u8 *, const int, const int); | 1080 | extern void ide_fixstring(u8 *, const int, const int); |
1081 | 1081 | ||
1082 | /* | 1082 | int ide_wait_stat(ide_startstop_t *, ide_drive_t *, u8, u8, unsigned long); |
1083 | * This routine busy-waits for the drive status to be not "busy". | ||
1084 | * It then checks the status for all of the "good" bits and none | ||
1085 | * of the "bad" bits, and if all is okay it returns 0. All other | ||
1086 | * cases return 1 after doing "*startstop = ide_error()", and the | ||
1087 | * caller should return the updated value of "startstop" in this case. | ||
1088 | * "startstop" is unchanged when the function returns 0; | ||
1089 | * (startstop, drive, good, bad, timeout) | ||
1090 | */ | ||
1091 | extern int ide_wait_stat(ide_startstop_t *, ide_drive_t *, u8, u8, unsigned long); | ||
1092 | 1083 | ||
1093 | /* | 1084 | /* |
1094 | * Start a reset operation for an IDE interface. | 1085 | * Start a reset operation for an IDE interface. |
@@ -1162,7 +1153,6 @@ extern void SELECT_MASK(ide_drive_t *, int); | |||
1162 | extern void QUIRK_LIST(ide_drive_t *); | 1153 | extern void QUIRK_LIST(ide_drive_t *); |
1163 | 1154 | ||
1164 | extern int drive_is_ready(ide_drive_t *); | 1155 | extern int drive_is_ready(ide_drive_t *); |
1165 | extern int wait_for_ready(ide_drive_t *, int /* timeout */); | ||
1166 | 1156 | ||
1167 | /* | 1157 | /* |
1168 | * taskfile io for disks for now...and builds request from ide_ioctl | 1158 | * taskfile io for disks for now...and builds request from ide_ioctl |
@@ -1262,6 +1252,15 @@ enum { | |||
1262 | IDE_HFLAG_ABUSE_FAST_DEVSEL = (1 << 5), | 1252 | IDE_HFLAG_ABUSE_FAST_DEVSEL = (1 << 5), |
1263 | /* use 100-102 and 200-202 PIO values to set DMA modes */ | 1253 | /* use 100-102 and 200-202 PIO values to set DMA modes */ |
1264 | IDE_HFLAG_ABUSE_DMA_MODES = (1 << 6), | 1254 | IDE_HFLAG_ABUSE_DMA_MODES = (1 << 6), |
1255 | /* | ||
1256 | * keep DMA setting when programming PIO mode, may be used only | ||
1257 | * for hosts which have separate PIO and DMA timings (ie. PMAC) | ||
1258 | */ | ||
1259 | IDE_HFLAG_SET_PIO_MODE_KEEP_DMA = (1 << 7), | ||
1260 | /* program host for the transfer mode after programming device */ | ||
1261 | IDE_HFLAG_POST_SET_MODE = (1 << 8), | ||
1262 | /* don't program host/device for the transfer mode ("smart" hosts) */ | ||
1263 | IDE_HFLAG_NO_SET_MODE = (1 << 9), | ||
1265 | }; | 1264 | }; |
1266 | 1265 | ||
1267 | typedef struct ide_pci_device_s { | 1266 | typedef struct ide_pci_device_s { |
@@ -1278,7 +1277,7 @@ typedef struct ide_pci_device_s { | |||
1278 | u8 bootable; | 1277 | u8 bootable; |
1279 | unsigned int extra; | 1278 | unsigned int extra; |
1280 | struct ide_pci_device_s *next; | 1279 | struct ide_pci_device_s *next; |
1281 | u8 host_flags; | 1280 | u16 host_flags; |
1282 | u8 pio_mask; | 1281 | u8 pio_mask; |
1283 | u8 udma_mask; | 1282 | u8 udma_mask; |
1284 | } ide_pci_device_t; | 1283 | } ide_pci_device_t; |
@@ -1301,7 +1300,6 @@ int ide_in_drive_list(struct hd_driveid *, const struct drive_list_entry *); | |||
1301 | 1300 | ||
1302 | #ifdef CONFIG_BLK_DEV_IDEDMA | 1301 | #ifdef CONFIG_BLK_DEV_IDEDMA |
1303 | int __ide_dma_bad_drive(ide_drive_t *); | 1302 | int __ide_dma_bad_drive(ide_drive_t *); |
1304 | int __ide_dma_good_drive(ide_drive_t *); | ||
1305 | 1303 | ||
1306 | u8 ide_find_dma_mode(ide_drive_t *, u8); | 1304 | u8 ide_find_dma_mode(ide_drive_t *, u8); |
1307 | 1305 | ||
@@ -1420,6 +1418,9 @@ unsigned int ide_pio_cycle_time(ide_drive_t *, u8); | |||
1420 | u8 ide_get_best_pio_mode(ide_drive_t *, u8, u8); | 1418 | u8 ide_get_best_pio_mode(ide_drive_t *, u8, u8); |
1421 | extern const ide_pio_timings_t ide_pio_timings[6]; | 1419 | extern const ide_pio_timings_t ide_pio_timings[6]; |
1422 | 1420 | ||
1421 | int ide_set_pio_mode(ide_drive_t *, u8); | ||
1422 | int ide_set_dma_mode(ide_drive_t *, u8); | ||
1423 | |||
1423 | void ide_set_pio(ide_drive_t *, u8); | 1424 | void ide_set_pio(ide_drive_t *, u8); |
1424 | 1425 | ||
1425 | static inline void ide_set_max_pio(ide_drive_t *drive) | 1426 | static inline void ide_set_max_pio(ide_drive_t *drive) |