diff options
-rwxr-xr-x | scripts/checkpatch.pl | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7a2f54a0bd35..de639eeeed50 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -1772,6 +1772,21 @@ sub process { | |||
1772 | "line over 80 characters\n" . $herecurr); | 1772 | "line over 80 characters\n" . $herecurr); |
1773 | } | 1773 | } |
1774 | 1774 | ||
1775 | # Check for user-visible strings broken across lines, which breaks the ability | ||
1776 | # to grep for the string. Limited to strings used as parameters (those | ||
1777 | # following an open parenthesis), which almost completely eliminates false | ||
1778 | # positives, as well as warning only once per parameter rather than once per | ||
1779 | # line of the string. Make an exception when the previous string ends in a | ||
1780 | # newline (multiple lines in one string constant) or \n\t (common in inline | ||
1781 | # assembly to indent the instruction on the following line). | ||
1782 | if ($line =~ /^\+\s*"/ && | ||
1783 | $prevline =~ /"\s*$/ && | ||
1784 | $prevline =~ /\(/ && | ||
1785 | $prevrawline !~ /\\n(?:\\t)*"\s*$/) { | ||
1786 | WARN("SPLIT_STRING", | ||
1787 | "quoted string split across lines\n" . $hereprev); | ||
1788 | } | ||
1789 | |||
1775 | # check for spaces before a quoted newline | 1790 | # check for spaces before a quoted newline |
1776 | if ($rawline =~ /^.*\".*\s\\n/) { | 1791 | if ($rawline =~ /^.*\".*\s\\n/) { |
1777 | WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE", | 1792 | WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE", |