diff options
-rw-r--r-- | drivers/block/loop.c | 26 | ||||
-rw-r--r-- | include/linux/bio.h | 2 | ||||
-rw-r--r-- | include/linux/loop.h | 3 |
3 files changed, 9 insertions, 22 deletions
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index ddae80825899..9ca4bb014657 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c | |||
@@ -511,11 +511,7 @@ out: | |||
511 | */ | 511 | */ |
512 | static void loop_add_bio(struct loop_device *lo, struct bio *bio) | 512 | static void loop_add_bio(struct loop_device *lo, struct bio *bio) |
513 | { | 513 | { |
514 | if (lo->lo_biotail) { | 514 | bio_list_add(&lo->lo_bio_list, bio); |
515 | lo->lo_biotail->bi_next = bio; | ||
516 | lo->lo_biotail = bio; | ||
517 | } else | ||
518 | lo->lo_bio = lo->lo_biotail = bio; | ||
519 | } | 515 | } |
520 | 516 | ||
521 | /* | 517 | /* |
@@ -523,16 +519,7 @@ static void loop_add_bio(struct loop_device *lo, struct bio *bio) | |||
523 | */ | 519 | */ |
524 | static struct bio *loop_get_bio(struct loop_device *lo) | 520 | static struct bio *loop_get_bio(struct loop_device *lo) |
525 | { | 521 | { |
526 | struct bio *bio; | 522 | return bio_list_pop(&lo->lo_bio_list); |
527 | |||
528 | if ((bio = lo->lo_bio)) { | ||
529 | if (bio == lo->lo_biotail) | ||
530 | lo->lo_biotail = NULL; | ||
531 | lo->lo_bio = bio->bi_next; | ||
532 | bio->bi_next = NULL; | ||
533 | } | ||
534 | |||
535 | return bio; | ||
536 | } | 523 | } |
537 | 524 | ||
538 | static int loop_make_request(struct request_queue *q, struct bio *old_bio) | 525 | static int loop_make_request(struct request_queue *q, struct bio *old_bio) |
@@ -609,12 +596,13 @@ static int loop_thread(void *data) | |||
609 | 596 | ||
610 | set_user_nice(current, -20); | 597 | set_user_nice(current, -20); |
611 | 598 | ||
612 | while (!kthread_should_stop() || lo->lo_bio) { | 599 | while (!kthread_should_stop() || !bio_list_empty(&lo->lo_bio_list)) { |
613 | 600 | ||
614 | wait_event_interruptible(lo->lo_event, | 601 | wait_event_interruptible(lo->lo_event, |
615 | lo->lo_bio || kthread_should_stop()); | 602 | !bio_list_empty(&lo->lo_bio_list) || |
603 | kthread_should_stop()); | ||
616 | 604 | ||
617 | if (!lo->lo_bio) | 605 | if (bio_list_empty(&lo->lo_bio_list)) |
618 | continue; | 606 | continue; |
619 | spin_lock_irq(&lo->lo_lock); | 607 | spin_lock_irq(&lo->lo_lock); |
620 | bio = loop_get_bio(lo); | 608 | bio = loop_get_bio(lo); |
@@ -841,7 +829,7 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode, | |||
841 | lo->old_gfp_mask = mapping_gfp_mask(mapping); | 829 | lo->old_gfp_mask = mapping_gfp_mask(mapping); |
842 | mapping_set_gfp_mask(mapping, lo->old_gfp_mask & ~(__GFP_IO|__GFP_FS)); | 830 | mapping_set_gfp_mask(mapping, lo->old_gfp_mask & ~(__GFP_IO|__GFP_FS)); |
843 | 831 | ||
844 | lo->lo_bio = lo->lo_biotail = NULL; | 832 | bio_list_init(&lo->lo_bio_list); |
845 | 833 | ||
846 | /* | 834 | /* |
847 | * set queue make_request_fn, and add limits based on lower level | 835 | * set queue make_request_fn, and add limits based on lower level |
diff --git a/include/linux/bio.h b/include/linux/bio.h index 7b214fd672a2..f37ca8c726ba 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h | |||
@@ -506,7 +506,7 @@ static inline int bio_has_data(struct bio *bio) | |||
506 | } | 506 | } |
507 | 507 | ||
508 | /* | 508 | /* |
509 | * BIO list managment for use by remapping drivers (e.g. DM or MD). | 509 | * BIO list management for use by remapping drivers (e.g. DM or MD) and loop. |
510 | * | 510 | * |
511 | * A bio_list anchors a singly-linked list of bios chained through the bi_next | 511 | * A bio_list anchors a singly-linked list of bios chained through the bi_next |
512 | * member of the bio. The bio_list also caches the last list member to allow | 512 | * member of the bio. The bio_list also caches the last list member to allow |
diff --git a/include/linux/loop.h b/include/linux/loop.h index 40725447f5e0..66c194e2d9b9 100644 --- a/include/linux/loop.h +++ b/include/linux/loop.h | |||
@@ -56,8 +56,7 @@ struct loop_device { | |||
56 | gfp_t old_gfp_mask; | 56 | gfp_t old_gfp_mask; |
57 | 57 | ||
58 | spinlock_t lo_lock; | 58 | spinlock_t lo_lock; |
59 | struct bio *lo_bio; | 59 | struct bio_list lo_bio_list; |
60 | struct bio *lo_biotail; | ||
61 | int lo_state; | 60 | int lo_state; |
62 | struct mutex lo_ctl_mutex; | 61 | struct mutex lo_ctl_mutex; |
63 | struct task_struct *lo_thread; | 62 | struct task_struct *lo_thread; |