diff options
-rw-r--r-- | fs/namei.c | 4 | ||||
-rw-r--r-- | fs/nfsd/vfs.c | 17 |
2 files changed, 17 insertions, 4 deletions
diff --git a/fs/namei.c b/fs/namei.c index 00df735fb509..83c843b3fea3 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
@@ -2718,8 +2718,12 @@ static int do_rename(int olddfd, const char *oldname, | |||
2718 | if (new_dentry == trap) | 2718 | if (new_dentry == trap) |
2719 | goto exit5; | 2719 | goto exit5; |
2720 | 2720 | ||
2721 | error = mnt_want_write(oldnd.path.mnt); | ||
2722 | if (error) | ||
2723 | goto exit5; | ||
2721 | error = vfs_rename(old_dir->d_inode, old_dentry, | 2724 | error = vfs_rename(old_dir->d_inode, old_dentry, |
2722 | new_dir->d_inode, new_dentry); | 2725 | new_dir->d_inode, new_dentry); |
2726 | mnt_drop_write(oldnd.path.mnt); | ||
2723 | exit5: | 2727 | exit5: |
2724 | dput(new_dentry); | 2728 | dput(new_dentry); |
2725 | exit4: | 2729 | exit4: |
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 71f899482306..18a4cc9feeb3 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -1710,13 +1710,20 @@ nfsd_rename(struct svc_rqst *rqstp, struct svc_fh *ffhp, char *fname, int flen, | |||
1710 | if (ndentry == trap) | 1710 | if (ndentry == trap) |
1711 | goto out_dput_new; | 1711 | goto out_dput_new; |
1712 | 1712 | ||
1713 | #ifdef MSNFS | 1713 | if (svc_msnfs(ffhp) && |
1714 | if ((ffhp->fh_export->ex_flags & NFSEXP_MSNFS) && | ||
1715 | ((atomic_read(&odentry->d_count) > 1) | 1714 | ((atomic_read(&odentry->d_count) > 1) |
1716 | || (atomic_read(&ndentry->d_count) > 1))) { | 1715 | || (atomic_read(&ndentry->d_count) > 1))) { |
1717 | host_err = -EPERM; | 1716 | host_err = -EPERM; |
1718 | } else | 1717 | goto out_dput_new; |
1719 | #endif | 1718 | } |
1719 | |||
1720 | host_err = -EXDEV; | ||
1721 | if (ffhp->fh_export->ex_path.mnt != tfhp->fh_export->ex_path.mnt) | ||
1722 | goto out_dput_new; | ||
1723 | host_err = mnt_want_write(ffhp->fh_export->ex_path.mnt); | ||
1724 | if (host_err) | ||
1725 | goto out_dput_new; | ||
1726 | |||
1720 | host_err = vfs_rename(fdir, odentry, tdir, ndentry); | 1727 | host_err = vfs_rename(fdir, odentry, tdir, ndentry); |
1721 | if (!host_err && EX_ISSYNC(tfhp->fh_export)) { | 1728 | if (!host_err && EX_ISSYNC(tfhp->fh_export)) { |
1722 | host_err = nfsd_sync_dir(tdentry); | 1729 | host_err = nfsd_sync_dir(tdentry); |
@@ -1724,6 +1731,8 @@ nfsd_rename(struct svc_rqst *rqstp, struct svc_fh *ffhp, char *fname, int flen, | |||
1724 | host_err = nfsd_sync_dir(fdentry); | 1731 | host_err = nfsd_sync_dir(fdentry); |
1725 | } | 1732 | } |
1726 | 1733 | ||
1734 | mnt_drop_write(ffhp->fh_export->ex_path.mnt); | ||
1735 | |||
1727 | out_dput_new: | 1736 | out_dput_new: |
1728 | dput(ndentry); | 1737 | dput(ndentry); |
1729 | out_dput_old: | 1738 | out_dput_old: |