aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--include/net/sock.h12
-rw-r--r--net/core/filter.c23
2 files changed, 22 insertions, 13 deletions
diff --git a/include/net/sock.h b/include/net/sock.h
index b9cfe125c9e6..43fc3fa50d62 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -905,16 +905,6 @@ static inline int sk_filter(struct sock *sk, struct sk_buff *skb)
905} 905}
906 906
907/** 907/**
908 * sk_filter_rcu_free: Free a socket filter
909 * @rcu: rcu_head that contains the sk_filter to free
910 */
911static inline void sk_filter_rcu_free(struct rcu_head *rcu)
912{
913 struct sk_filter *fp = container_of(rcu, struct sk_filter, rcu);
914 kfree(fp);
915}
916
917/**
918 * sk_filter_release: Release a socket filter 908 * sk_filter_release: Release a socket filter
919 * @sk: socket 909 * @sk: socket
920 * @fp: filter to remove 910 * @fp: filter to remove
@@ -925,7 +915,7 @@ static inline void sk_filter_rcu_free(struct rcu_head *rcu)
925static inline void sk_filter_release(struct sk_filter *fp) 915static inline void sk_filter_release(struct sk_filter *fp)
926{ 916{
927 if (atomic_dec_and_test(&fp->refcnt)) 917 if (atomic_dec_and_test(&fp->refcnt))
928 call_rcu_bh(&fp->rcu, sk_filter_rcu_free); 918 kfree(fp);
929} 919}
930 920
931static inline void sk_filter_uncharge(struct sock *sk, struct sk_filter *fp) 921static inline void sk_filter_uncharge(struct sock *sk, struct sk_filter *fp)
diff --git a/net/core/filter.c b/net/core/filter.c
index 54dddc92452d..1f0068eae501 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -387,6 +387,25 @@ int sk_chk_filter(struct sock_filter *filter, int flen)
387} 387}
388 388
389/** 389/**
390 * sk_filter_rcu_release: Release a socket filter by rcu_head
391 * @rcu: rcu_head that contains the sk_filter to free
392 */
393static void sk_filter_rcu_release(struct rcu_head *rcu)
394{
395 struct sk_filter *fp = container_of(rcu, struct sk_filter, rcu);
396
397 sk_filter_release(fp);
398}
399
400static void sk_filter_delayed_uncharge(struct sock *sk, struct sk_filter *fp)
401{
402 unsigned int size = sk_filter_len(fp);
403
404 atomic_sub(size, &sk->sk_omem_alloc);
405 call_rcu_bh(&fp->rcu, sk_filter_rcu_release);
406}
407
408/**
390 * sk_attach_filter - attach a socket filter 409 * sk_attach_filter - attach a socket filter
391 * @fprog: the filter program 410 * @fprog: the filter program
392 * @sk: the socket to use 411 * @sk: the socket to use
@@ -428,7 +447,7 @@ int sk_attach_filter(struct sock_fprog *fprog, struct sock *sk)
428 rcu_assign_pointer(sk->sk_filter, fp); 447 rcu_assign_pointer(sk->sk_filter, fp);
429 rcu_read_unlock_bh(); 448 rcu_read_unlock_bh();
430 449
431 sk_filter_uncharge(sk, old_fp); 450 sk_filter_delayed_uncharge(sk, old_fp);
432 return 0; 451 return 0;
433} 452}
434 453
@@ -441,7 +460,7 @@ int sk_detach_filter(struct sock *sk)
441 filter = rcu_dereference(sk->sk_filter); 460 filter = rcu_dereference(sk->sk_filter);
442 if (filter) { 461 if (filter) {
443 rcu_assign_pointer(sk->sk_filter, NULL); 462 rcu_assign_pointer(sk->sk_filter, NULL);
444 sk_filter_uncharge(sk, filter); 463 sk_filter_delayed_uncharge(sk, filter);
445 ret = 0; 464 ret = 0;
446 } 465 }
447 rcu_read_unlock_bh(); 466 rcu_read_unlock_bh();