diff options
-rw-r--r-- | Documentation/trace/kprobetrace.txt | 16 | ||||
-rw-r--r-- | kernel/trace/trace_kprobe.c | 16 |
2 files changed, 19 insertions, 13 deletions
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt index aaa6c1067c78..a849889e6092 100644 --- a/Documentation/trace/kprobetrace.txt +++ b/Documentation/trace/kprobetrace.txt | |||
@@ -114,7 +114,7 @@ format: | |||
114 | field: unsigned long flags; offset:48;tsize:8; | 114 | field: unsigned long flags; offset:48;tsize:8; |
115 | field: unsigned long mode; offset:56;tsize:8; | 115 | field: unsigned long mode; offset:56;tsize:8; |
116 | 116 | ||
117 | print fmt: "%lx: dfd=%lx filename=%lx flags=%lx mode=%lx", ip, REC->dfd, REC->filename, REC->flags, REC->mode | 117 | print fmt: "(%lx) dfd=%lx filename=%lx flags=%lx mode=%lx", REC->ip, REC->dfd, REC->filename, REC->flags, REC->mode |
118 | 118 | ||
119 | 119 | ||
120 | You can see that the event has 4 arguments as in the expressions you specified. | 120 | You can see that the event has 4 arguments as in the expressions you specified. |
@@ -129,15 +129,15 @@ print fmt: "%lx: dfd=%lx filename=%lx flags=%lx mode=%lx", ip, REC->dfd, REC->fi | |||
129 | # | 129 | # |
130 | # TASK-PID CPU# TIMESTAMP FUNCTION | 130 | # TASK-PID CPU# TIMESTAMP FUNCTION |
131 | # | | | | | | 131 | # | | | | | |
132 | <...>-1447 [001] 1038282.286875: do_sys_open+0x0/0xd6: dfd=3 filename=7fffd1ec4440 flags=8000 mode=0 | 132 | <...>-1447 [001] 1038282.286875: myprobe: (do_sys_open+0x0/0xd6) dfd=3 filename=7fffd1ec4440 flags=8000 mode=0 |
133 | <...>-1447 [001] 1038282.286878: sys_openat+0xc/0xe <- do_sys_open: rv=fffffffffffffffe ra=ffffffff81367a3a | 133 | <...>-1447 [001] 1038282.286878: myretprobe: (sys_openat+0xc/0xe <- do_sys_open) rv=fffffffffffffffe ra=ffffffff81367a3a |
134 | <...>-1447 [001] 1038282.286885: do_sys_open+0x0/0xd6: dfd=ffffff9c filename=40413c flags=8000 mode=1b6 | 134 | <...>-1447 [001] 1038282.286885: myprobe: (do_sys_open+0x0/0xd6) dfd=ffffff9c filename=40413c flags=8000 mode=1b6 |
135 | <...>-1447 [001] 1038282.286915: sys_open+0x1b/0x1d <- do_sys_open: rv=3 ra=ffffffff81367a3a | 135 | <...>-1447 [001] 1038282.286915: myretprobe: (sys_open+0x1b/0x1d <- do_sys_open) rv=3 ra=ffffffff81367a3a |
136 | <...>-1447 [001] 1038282.286969: do_sys_open+0x0/0xd6: dfd=ffffff9c filename=4041c6 flags=98800 mode=10 | 136 | <...>-1447 [001] 1038282.286969: myprobe: (do_sys_open+0x0/0xd6) dfd=ffffff9c filename=4041c6 flags=98800 mode=10 |
137 | <...>-1447 [001] 1038282.286976: sys_open+0x1b/0x1d <- do_sys_open: rv=3 ra=ffffffff81367a3a | 137 | <...>-1447 [001] 1038282.286976: myretprobe: (sys_open+0x1b/0x1d <- do_sys_open) rv=3 ra=ffffffff81367a3a |
138 | 138 | ||
139 | 139 | ||
140 | Each line shows when the kernel hits a probe, and <- SYMBOL means kernel | 140 | Each line shows when the kernel hits an event, and <- SYMBOL means kernel |
141 | returns from SYMBOL(e.g. "sys_open+0x1b/0x1d <- do_sys_open" means kernel | 141 | returns from SYMBOL(e.g. "sys_open+0x1b/0x1d <- do_sys_open" means kernel |
142 | returns from do_sys_open to sys_open+0x1b). | 142 | returns from do_sys_open to sys_open+0x1b). |
143 | 143 | ||
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 44dad1aa95d3..1746afeaabf9 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c | |||
@@ -902,10 +902,13 @@ print_kprobe_event(struct trace_iterator *iter, int flags) | |||
902 | event = ftrace_find_event(field->ent.type); | 902 | event = ftrace_find_event(field->ent.type); |
903 | tp = container_of(event, struct trace_probe, event); | 903 | tp = container_of(event, struct trace_probe, event); |
904 | 904 | ||
905 | if (!trace_seq_printf(s, "%s: (", tp->call.name)) | ||
906 | goto partial; | ||
907 | |||
905 | if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET)) | 908 | if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET)) |
906 | goto partial; | 909 | goto partial; |
907 | 910 | ||
908 | if (!trace_seq_puts(s, ":")) | 911 | if (!trace_seq_puts(s, ")")) |
909 | goto partial; | 912 | goto partial; |
910 | 913 | ||
911 | for (i = 0; i < field->nargs; i++) | 914 | for (i = 0; i < field->nargs; i++) |
@@ -934,6 +937,9 @@ print_kretprobe_event(struct trace_iterator *iter, int flags) | |||
934 | event = ftrace_find_event(field->ent.type); | 937 | event = ftrace_find_event(field->ent.type); |
935 | tp = container_of(event, struct trace_probe, event); | 938 | tp = container_of(event, struct trace_probe, event); |
936 | 939 | ||
940 | if (!trace_seq_printf(s, "%s: (", tp->call.name)) | ||
941 | goto partial; | ||
942 | |||
937 | if (!seq_print_ip_sym(s, field->ret_ip, flags | TRACE_ITER_SYM_OFFSET)) | 943 | if (!seq_print_ip_sym(s, field->ret_ip, flags | TRACE_ITER_SYM_OFFSET)) |
938 | goto partial; | 944 | goto partial; |
939 | 945 | ||
@@ -943,7 +949,7 @@ print_kretprobe_event(struct trace_iterator *iter, int flags) | |||
943 | if (!seq_print_ip_sym(s, field->func, flags & ~TRACE_ITER_SYM_OFFSET)) | 949 | if (!seq_print_ip_sym(s, field->func, flags & ~TRACE_ITER_SYM_OFFSET)) |
944 | goto partial; | 950 | goto partial; |
945 | 951 | ||
946 | if (!trace_seq_puts(s, ":")) | 952 | if (!trace_seq_puts(s, ")")) |
947 | goto partial; | 953 | goto partial; |
948 | 954 | ||
949 | for (i = 0; i < field->nargs; i++) | 955 | for (i = 0; i < field->nargs; i++) |
@@ -1087,7 +1093,7 @@ static int kprobe_event_show_format(struct ftrace_event_call *call, | |||
1087 | SHOW_FIELD(unsigned long, args[i], tp->args[i].name); | 1093 | SHOW_FIELD(unsigned long, args[i], tp->args[i].name); |
1088 | trace_seq_puts(s, "\n"); | 1094 | trace_seq_puts(s, "\n"); |
1089 | 1095 | ||
1090 | return __probe_event_show_format(s, tp, "%lx:", "ip"); | 1096 | return __probe_event_show_format(s, tp, "(%lx)", "REC->ip"); |
1091 | } | 1097 | } |
1092 | 1098 | ||
1093 | static int kretprobe_event_show_format(struct ftrace_event_call *call, | 1099 | static int kretprobe_event_show_format(struct ftrace_event_call *call, |
@@ -1106,8 +1112,8 @@ static int kretprobe_event_show_format(struct ftrace_event_call *call, | |||
1106 | SHOW_FIELD(unsigned long, args[i], tp->args[i].name); | 1112 | SHOW_FIELD(unsigned long, args[i], tp->args[i].name); |
1107 | trace_seq_puts(s, "\n"); | 1113 | trace_seq_puts(s, "\n"); |
1108 | 1114 | ||
1109 | return __probe_event_show_format(s, tp, "%lx <- %lx:", | 1115 | return __probe_event_show_format(s, tp, "(%lx <- %lx)", |
1110 | "func, ret_ip"); | 1116 | "REC->func, REC->ret_ip"); |
1111 | } | 1117 | } |
1112 | 1118 | ||
1113 | #ifdef CONFIG_EVENT_PROFILE | 1119 | #ifdef CONFIG_EVENT_PROFILE |