aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--net/ipv4/ip_gre.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index e5dfd2843f28..987a4e5e07e2 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -159,14 +159,14 @@ static int ip_gre_calc_hlen(__be16 o_flags)
159static int parse_gre_header(struct sk_buff *skb, struct tnl_ptk_info *tpi, 159static int parse_gre_header(struct sk_buff *skb, struct tnl_ptk_info *tpi,
160 bool *csum_err, int *hdr_len) 160 bool *csum_err, int *hdr_len)
161{ 161{
162 struct iphdr *iph = ip_hdr(skb); 162 unsigned int ip_hlen = ip_hdrlen(skb);
163 struct gre_base_hdr *greh; 163 const struct gre_base_hdr *greh;
164 __be32 *options; 164 __be32 *options;
165 165
166 if (unlikely(!pskb_may_pull(skb, sizeof(struct gre_base_hdr)))) 166 if (unlikely(!pskb_may_pull(skb, sizeof(struct gre_base_hdr))))
167 return -EINVAL; 167 return -EINVAL;
168 168
169 greh = (struct gre_base_hdr *)((u8 *)iph + (iph->ihl << 2)); 169 greh = (struct gre_base_hdr *)(skb_network_header(skb) + ip_hlen);
170 if (unlikely(greh->flags & (GRE_VERSION | GRE_ROUTING))) 170 if (unlikely(greh->flags & (GRE_VERSION | GRE_ROUTING)))
171 return -EINVAL; 171 return -EINVAL;
172 172
@@ -176,6 +176,8 @@ static int parse_gre_header(struct sk_buff *skb, struct tnl_ptk_info *tpi,
176 if (!pskb_may_pull(skb, *hdr_len)) 176 if (!pskb_may_pull(skb, *hdr_len))
177 return -EINVAL; 177 return -EINVAL;
178 178
179 greh = (struct gre_base_hdr *)(skb_network_header(skb) + ip_hlen);
180
179 tpi->proto = greh->protocol; 181 tpi->proto = greh->protocol;
180 182
181 options = (__be32 *)(greh + 1); 183 options = (__be32 *)(greh + 1);