diff options
-rw-r--r-- | include/linux/interrupt.h | 1 | ||||
-rw-r--r-- | kernel/rcupdate.c | 25 |
2 files changed, 18 insertions, 8 deletions
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index 2306920fa388..c3db4a00f1fa 100644 --- a/include/linux/interrupt.h +++ b/include/linux/interrupt.h | |||
@@ -256,6 +256,7 @@ enum | |||
256 | #ifdef CONFIG_HIGH_RES_TIMERS | 256 | #ifdef CONFIG_HIGH_RES_TIMERS |
257 | HRTIMER_SOFTIRQ, | 257 | HRTIMER_SOFTIRQ, |
258 | #endif | 258 | #endif |
259 | RCU_SOFTIRQ, /* Preferable RCU should always be the last softirq */ | ||
259 | }; | 260 | }; |
260 | 261 | ||
261 | /* softirq mask and active fields moved to irq_cpustat_t in | 262 | /* softirq mask and active fields moved to irq_cpustat_t in |
diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c index f2c1a04e9b18..4dfa0b792efa 100644 --- a/kernel/rcupdate.c +++ b/kernel/rcupdate.c | |||
@@ -73,8 +73,6 @@ static struct rcu_ctrlblk rcu_bh_ctrlblk = { | |||
73 | DEFINE_PER_CPU(struct rcu_data, rcu_data) = { 0L }; | 73 | DEFINE_PER_CPU(struct rcu_data, rcu_data) = { 0L }; |
74 | DEFINE_PER_CPU(struct rcu_data, rcu_bh_data) = { 0L }; | 74 | DEFINE_PER_CPU(struct rcu_data, rcu_bh_data) = { 0L }; |
75 | 75 | ||
76 | /* Fake initialization required by compiler */ | ||
77 | static DEFINE_PER_CPU(struct tasklet_struct, rcu_tasklet) = {NULL}; | ||
78 | static int blimit = 10; | 76 | static int blimit = 10; |
79 | static int qhimark = 10000; | 77 | static int qhimark = 10000; |
80 | static int qlowmark = 100; | 78 | static int qlowmark = 100; |
@@ -231,6 +229,18 @@ void rcu_barrier(void) | |||
231 | } | 229 | } |
232 | EXPORT_SYMBOL_GPL(rcu_barrier); | 230 | EXPORT_SYMBOL_GPL(rcu_barrier); |
233 | 231 | ||
232 | /* Raises the softirq for processing rcu_callbacks. */ | ||
233 | static inline void raise_rcu_softirq(void) | ||
234 | { | ||
235 | raise_softirq(RCU_SOFTIRQ); | ||
236 | /* | ||
237 | * The smp_mb() here is required to ensure that this cpu's | ||
238 | * __rcu_process_callbacks() reads the most recently updated | ||
239 | * value of rcu->cur. | ||
240 | */ | ||
241 | smp_mb(); | ||
242 | } | ||
243 | |||
234 | /* | 244 | /* |
235 | * Invoke the completed RCU callbacks. They are expected to be in | 245 | * Invoke the completed RCU callbacks. They are expected to be in |
236 | * a per-cpu list. | 246 | * a per-cpu list. |
@@ -260,7 +270,7 @@ static void rcu_do_batch(struct rcu_data *rdp) | |||
260 | if (!rdp->donelist) | 270 | if (!rdp->donelist) |
261 | rdp->donetail = &rdp->donelist; | 271 | rdp->donetail = &rdp->donelist; |
262 | else | 272 | else |
263 | tasklet_schedule(&per_cpu(rcu_tasklet, rdp->cpu)); | 273 | raise_rcu_softirq(); |
264 | } | 274 | } |
265 | 275 | ||
266 | /* | 276 | /* |
@@ -412,7 +422,6 @@ static void rcu_offline_cpu(int cpu) | |||
412 | &per_cpu(rcu_bh_data, cpu)); | 422 | &per_cpu(rcu_bh_data, cpu)); |
413 | put_cpu_var(rcu_data); | 423 | put_cpu_var(rcu_data); |
414 | put_cpu_var(rcu_bh_data); | 424 | put_cpu_var(rcu_bh_data); |
415 | tasklet_kill_immediate(&per_cpu(rcu_tasklet, cpu), cpu); | ||
416 | } | 425 | } |
417 | 426 | ||
418 | #else | 427 | #else |
@@ -424,7 +433,7 @@ static void rcu_offline_cpu(int cpu) | |||
424 | #endif | 433 | #endif |
425 | 434 | ||
426 | /* | 435 | /* |
427 | * This does the RCU processing work from tasklet context. | 436 | * This does the RCU processing work from softirq context. |
428 | */ | 437 | */ |
429 | static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp, | 438 | static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp, |
430 | struct rcu_data *rdp) | 439 | struct rcu_data *rdp) |
@@ -469,7 +478,7 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp, | |||
469 | rcu_do_batch(rdp); | 478 | rcu_do_batch(rdp); |
470 | } | 479 | } |
471 | 480 | ||
472 | static void rcu_process_callbacks(unsigned long unused) | 481 | static void rcu_process_callbacks(struct softirq_action *unused) |
473 | { | 482 | { |
474 | __rcu_process_callbacks(&rcu_ctrlblk, &__get_cpu_var(rcu_data)); | 483 | __rcu_process_callbacks(&rcu_ctrlblk, &__get_cpu_var(rcu_data)); |
475 | __rcu_process_callbacks(&rcu_bh_ctrlblk, &__get_cpu_var(rcu_bh_data)); | 484 | __rcu_process_callbacks(&rcu_bh_ctrlblk, &__get_cpu_var(rcu_bh_data)); |
@@ -533,7 +542,7 @@ void rcu_check_callbacks(int cpu, int user) | |||
533 | rcu_bh_qsctr_inc(cpu); | 542 | rcu_bh_qsctr_inc(cpu); |
534 | } else if (!in_softirq()) | 543 | } else if (!in_softirq()) |
535 | rcu_bh_qsctr_inc(cpu); | 544 | rcu_bh_qsctr_inc(cpu); |
536 | tasklet_schedule(&per_cpu(rcu_tasklet, cpu)); | 545 | raise_rcu_softirq(); |
537 | } | 546 | } |
538 | 547 | ||
539 | static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp, | 548 | static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp, |
@@ -556,7 +565,7 @@ static void __cpuinit rcu_online_cpu(int cpu) | |||
556 | 565 | ||
557 | rcu_init_percpu_data(cpu, &rcu_ctrlblk, rdp); | 566 | rcu_init_percpu_data(cpu, &rcu_ctrlblk, rdp); |
558 | rcu_init_percpu_data(cpu, &rcu_bh_ctrlblk, bh_rdp); | 567 | rcu_init_percpu_data(cpu, &rcu_bh_ctrlblk, bh_rdp); |
559 | tasklet_init(&per_cpu(rcu_tasklet, cpu), rcu_process_callbacks, 0UL); | 568 | open_softirq(RCU_SOFTIRQ, rcu_process_callbacks, NULL); |
560 | } | 569 | } |
561 | 570 | ||
562 | static int __cpuinit rcu_cpu_notify(struct notifier_block *self, | 571 | static int __cpuinit rcu_cpu_notify(struct notifier_block *self, |