diff options
-rw-r--r-- | drivers/char/tty_io.c | 2 | ||||
-rw-r--r-- | fs/dquot.c | 2 | ||||
-rw-r--r-- | fs/file_table.c | 14 | ||||
-rw-r--r-- | fs/proc/generic.c | 2 | ||||
-rw-r--r-- | fs/super.c | 2 | ||||
-rw-r--r-- | include/linux/fs.h | 10 | ||||
-rw-r--r-- | security/selinux/hooks.c | 2 | ||||
-rw-r--r-- | security/selinux/selinuxfs.c | 2 |
8 files changed, 21 insertions, 15 deletions
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index f5649a337743..c586bfa852ee 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c | |||
@@ -809,7 +809,7 @@ static void do_tty_hangup(void *data) | |||
809 | check_tty_count(tty, "do_tty_hangup"); | 809 | check_tty_count(tty, "do_tty_hangup"); |
810 | file_list_lock(); | 810 | file_list_lock(); |
811 | /* This breaks for file handles being sent over AF_UNIX sockets ? */ | 811 | /* This breaks for file handles being sent over AF_UNIX sockets ? */ |
812 | list_for_each_entry(filp, &tty->tty_files, f_list) { | 812 | list_for_each_entry(filp, &tty->tty_files, f_u.fu_list) { |
813 | if (filp->f_op->write == redirected_tty_write) | 813 | if (filp->f_op->write == redirected_tty_write) |
814 | cons_filp = filp; | 814 | cons_filp = filp; |
815 | if (filp->f_op->write != tty_write) | 815 | if (filp->f_op->write != tty_write) |
diff --git a/fs/dquot.c b/fs/dquot.c index 05f3327d64a3..ea7644227a65 100644 --- a/fs/dquot.c +++ b/fs/dquot.c | |||
@@ -662,7 +662,7 @@ static void add_dquot_ref(struct super_block *sb, int type) | |||
662 | restart: | 662 | restart: |
663 | file_list_lock(); | 663 | file_list_lock(); |
664 | list_for_each(p, &sb->s_files) { | 664 | list_for_each(p, &sb->s_files) { |
665 | struct file *filp = list_entry(p, struct file, f_list); | 665 | struct file *filp = list_entry(p, struct file, f_u.fu_list); |
666 | struct inode *inode = filp->f_dentry->d_inode; | 666 | struct inode *inode = filp->f_dentry->d_inode; |
667 | if (filp->f_mode & FMODE_WRITE && dqinit_needed(inode, type)) { | 667 | if (filp->f_mode & FMODE_WRITE && dqinit_needed(inode, type)) { |
668 | struct dentry *dentry = dget(filp->f_dentry); | 668 | struct dentry *dentry = dget(filp->f_dentry); |
diff --git a/fs/file_table.c b/fs/file_table.c index 86ec8ae985b4..4dc205546547 100644 --- a/fs/file_table.c +++ b/fs/file_table.c | |||
@@ -56,13 +56,13 @@ void filp_dtor(void * objp, struct kmem_cache_s *cachep, unsigned long dflags) | |||
56 | 56 | ||
57 | static inline void file_free_rcu(struct rcu_head *head) | 57 | static inline void file_free_rcu(struct rcu_head *head) |
58 | { | 58 | { |
59 | struct file *f = container_of(head, struct file, f_rcuhead); | 59 | struct file *f = container_of(head, struct file, f_u.fu_rcuhead); |
60 | kmem_cache_free(filp_cachep, f); | 60 | kmem_cache_free(filp_cachep, f); |
61 | } | 61 | } |
62 | 62 | ||
63 | static inline void file_free(struct file *f) | 63 | static inline void file_free(struct file *f) |
64 | { | 64 | { |
65 | call_rcu(&f->f_rcuhead, file_free_rcu); | 65 | call_rcu(&f->f_u.fu_rcuhead, file_free_rcu); |
66 | } | 66 | } |
67 | 67 | ||
68 | /* Find an unused file structure and return a pointer to it. | 68 | /* Find an unused file structure and return a pointer to it. |
@@ -95,7 +95,7 @@ struct file *get_empty_filp(void) | |||
95 | f->f_gid = current->fsgid; | 95 | f->f_gid = current->fsgid; |
96 | rwlock_init(&f->f_owner.lock); | 96 | rwlock_init(&f->f_owner.lock); |
97 | /* f->f_version: 0 */ | 97 | /* f->f_version: 0 */ |
98 | INIT_LIST_HEAD(&f->f_list); | 98 | INIT_LIST_HEAD(&f->f_u.fu_list); |
99 | return f; | 99 | return f; |
100 | 100 | ||
101 | over: | 101 | over: |
@@ -225,15 +225,15 @@ void file_move(struct file *file, struct list_head *list) | |||
225 | if (!list) | 225 | if (!list) |
226 | return; | 226 | return; |
227 | file_list_lock(); | 227 | file_list_lock(); |
228 | list_move(&file->f_list, list); | 228 | list_move(&file->f_u.fu_list, list); |
229 | file_list_unlock(); | 229 | file_list_unlock(); |
230 | } | 230 | } |
231 | 231 | ||
232 | void file_kill(struct file *file) | 232 | void file_kill(struct file *file) |
233 | { | 233 | { |
234 | if (!list_empty(&file->f_list)) { | 234 | if (!list_empty(&file->f_u.fu_list)) { |
235 | file_list_lock(); | 235 | file_list_lock(); |
236 | list_del_init(&file->f_list); | 236 | list_del_init(&file->f_u.fu_list); |
237 | file_list_unlock(); | 237 | file_list_unlock(); |
238 | } | 238 | } |
239 | } | 239 | } |
@@ -245,7 +245,7 @@ int fs_may_remount_ro(struct super_block *sb) | |||
245 | /* Check that no files are currently opened for writing. */ | 245 | /* Check that no files are currently opened for writing. */ |
246 | file_list_lock(); | 246 | file_list_lock(); |
247 | list_for_each(p, &sb->s_files) { | 247 | list_for_each(p, &sb->s_files) { |
248 | struct file *file = list_entry(p, struct file, f_list); | 248 | struct file *file = list_entry(p, struct file, f_u.fu_list); |
249 | struct inode *inode = file->f_dentry->d_inode; | 249 | struct inode *inode = file->f_dentry->d_inode; |
250 | 250 | ||
251 | /* File with pending delete? */ | 251 | /* File with pending delete? */ |
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 8a8c34461d48..b638fb500743 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
@@ -533,7 +533,7 @@ static void proc_kill_inodes(struct proc_dir_entry *de) | |||
533 | */ | 533 | */ |
534 | file_list_lock(); | 534 | file_list_lock(); |
535 | list_for_each(p, &sb->s_files) { | 535 | list_for_each(p, &sb->s_files) { |
536 | struct file * filp = list_entry(p, struct file, f_list); | 536 | struct file * filp = list_entry(p, struct file, f_u.fu_list); |
537 | struct dentry * dentry = filp->f_dentry; | 537 | struct dentry * dentry = filp->f_dentry; |
538 | struct inode * inode; | 538 | struct inode * inode; |
539 | struct file_operations *fops; | 539 | struct file_operations *fops; |
diff --git a/fs/super.c b/fs/super.c index 6e57ee252e14..f60155ec7780 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -513,7 +513,7 @@ static void mark_files_ro(struct super_block *sb) | |||
513 | struct file *f; | 513 | struct file *f; |
514 | 514 | ||
515 | file_list_lock(); | 515 | file_list_lock(); |
516 | list_for_each_entry(f, &sb->s_files, f_list) { | 516 | list_for_each_entry(f, &sb->s_files, f_u.fu_list) { |
517 | if (S_ISREG(f->f_dentry->d_inode->i_mode) && file_count(f)) | 517 | if (S_ISREG(f->f_dentry->d_inode->i_mode) && file_count(f)) |
518 | f->f_mode &= ~FMODE_WRITE; | 518 | f->f_mode &= ~FMODE_WRITE; |
519 | } | 519 | } |
diff --git a/include/linux/fs.h b/include/linux/fs.h index f83d997c5582..6d6226732c93 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h | |||
@@ -574,7 +574,14 @@ struct file_ra_state { | |||
574 | #define RA_FLAG_INCACHE 0x02 /* file is already in cache */ | 574 | #define RA_FLAG_INCACHE 0x02 /* file is already in cache */ |
575 | 575 | ||
576 | struct file { | 576 | struct file { |
577 | struct list_head f_list; | 577 | /* |
578 | * fu_list becomes invalid after file_free is called and queued via | ||
579 | * fu_rcuhead for RCU freeing | ||
580 | */ | ||
581 | union { | ||
582 | struct list_head fu_list; | ||
583 | struct rcu_head fu_rcuhead; | ||
584 | } f_u; | ||
578 | struct dentry *f_dentry; | 585 | struct dentry *f_dentry; |
579 | struct vfsmount *f_vfsmnt; | 586 | struct vfsmount *f_vfsmnt; |
580 | struct file_operations *f_op; | 587 | struct file_operations *f_op; |
@@ -598,7 +605,6 @@ struct file { | |||
598 | spinlock_t f_ep_lock; | 605 | spinlock_t f_ep_lock; |
599 | #endif /* #ifdef CONFIG_EPOLL */ | 606 | #endif /* #ifdef CONFIG_EPOLL */ |
600 | struct address_space *f_mapping; | 607 | struct address_space *f_mapping; |
601 | struct rcu_head f_rcuhead; | ||
602 | }; | 608 | }; |
603 | extern spinlock_t files_lock; | 609 | extern spinlock_t files_lock; |
604 | #define file_list_lock() spin_lock(&files_lock); | 610 | #define file_list_lock() spin_lock(&files_lock); |
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index d50d7a782cf5..bb62838be496 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c | |||
@@ -1609,7 +1609,7 @@ static inline void flush_unauthorized_files(struct files_struct * files) | |||
1609 | 1609 | ||
1610 | if (tty) { | 1610 | if (tty) { |
1611 | file_list_lock(); | 1611 | file_list_lock(); |
1612 | file = list_entry(tty->tty_files.next, typeof(*file), f_list); | 1612 | file = list_entry(tty->tty_files.next, typeof(*file), f_u.fu_list); |
1613 | if (file) { | 1613 | if (file) { |
1614 | /* Revalidate access to controlling tty. | 1614 | /* Revalidate access to controlling tty. |
1615 | Use inode_has_perm on the tty inode directly rather | 1615 | Use inode_has_perm on the tty inode directly rather |
diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index 7a387fec2a0c..fdc382389720 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c | |||
@@ -914,7 +914,7 @@ static void sel_remove_bools(struct dentry *de) | |||
914 | 914 | ||
915 | file_list_lock(); | 915 | file_list_lock(); |
916 | list_for_each(p, &sb->s_files) { | 916 | list_for_each(p, &sb->s_files) { |
917 | struct file * filp = list_entry(p, struct file, f_list); | 917 | struct file * filp = list_entry(p, struct file, f_u.fu_list); |
918 | struct dentry * dentry = filp->f_dentry; | 918 | struct dentry * dentry = filp->f_dentry; |
919 | 919 | ||
920 | if (dentry->d_parent != de) { | 920 | if (dentry->d_parent != de) { |