aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/ide/ide-cd.c10
-rw-r--r--drivers/ide/ide-floppy.c9
-rw-r--r--drivers/ide/ide-io.c16
-rw-r--r--drivers/ide/ide-tape.c9
-rw-r--r--drivers/scsi/ide-scsi.c6
-rw-r--r--include/linux/ide.h2
6 files changed, 26 insertions, 26 deletions
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 855a23c1c815..44b033ec0ab0 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -922,14 +922,8 @@ static ide_startstop_t cdrom_start_packet_command(ide_drive_t *drive,
922 info->dma = !hwif->dma_setup(drive); 922 info->dma = !hwif->dma_setup(drive);
923 923
924 /* Set up the controller registers. */ 924 /* Set up the controller registers. */
925 if (IDE_CONTROL_REG) 925 ide_pktcmd_tf_load(drive, IDE_TFLAG_OUT_NSECT | IDE_TFLAG_OUT_LBAL |
926 HWIF(drive)->OUTB(drive->ctl, IDE_CONTROL_REG); 926 IDE_TFLAG_NO_SELECT_MASK, xferlen, info->dma);
927 HWIF(drive)->OUTB(info->dma, IDE_FEATURE_REG);
928 HWIF(drive)->OUTB(0, IDE_IREASON_REG);
929 HWIF(drive)->OUTB(0, IDE_SECTOR_REG);
930
931 HWIF(drive)->OUTB(xferlen & 0xff, IDE_BCOUNTL_REG);
932 HWIF(drive)->OUTB(xferlen >> 8 , IDE_BCOUNTH_REG);
933 927
934 if (CDROM_CONFIG_FLAGS (drive)->drq_interrupt) { 928 if (CDROM_CONFIG_FLAGS (drive)->drq_interrupt) {
935 /* waiting for CDB interrupt, not DMA yet. */ 929 /* waiting for CDB interrupt, not DMA yet. */
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index d4fd064cc76c..ff8232ef9659 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -1067,13 +1067,8 @@ static ide_startstop_t idefloppy_issue_pc (ide_drive_t *drive, idefloppy_pc_t *p
1067 if (test_bit(PC_DMA_RECOMMENDED, &pc->flags) && drive->using_dma) 1067 if (test_bit(PC_DMA_RECOMMENDED, &pc->flags) && drive->using_dma)
1068 dma = !hwif->dma_setup(drive); 1068 dma = !hwif->dma_setup(drive);
1069 1069
1070 if (IDE_CONTROL_REG) 1070 ide_pktcmd_tf_load(drive, IDE_TFLAG_NO_SELECT_MASK |
1071 HWIF(drive)->OUTB(drive->ctl, IDE_CONTROL_REG); 1071 IDE_TFLAG_OUT_DEVICE, bcount, dma);
1072 /* Use PIO/DMA */
1073 hwif->OUTB(dma, IDE_FEATURE_REG);
1074 hwif->OUTB(bcount & 0xff, IDE_BCOUNTL_REG);
1075 hwif->OUTB((bcount >> 8) & 0xff, IDE_BCOUNTH_REG);
1076 HWIF(drive)->OUTB(drive->select.all, IDE_SELECT_REG);
1077 1072
1078 if (dma) { /* Begin DMA, if necessary */ 1073 if (dma) { /* Begin DMA, if necessary */
1079 set_bit(PC_DMA_IN_PROGRESS, &pc->flags); 1074 set_bit(PC_DMA_IN_PROGRESS, &pc->flags);
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index d36df77c7519..1ed7a8627cca 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1734,3 +1734,19 @@ int ide_do_drive_cmd (ide_drive_t *drive, struct request *rq, ide_action_t actio
1734} 1734}
1735 1735
1736EXPORT_SYMBOL(ide_do_drive_cmd); 1736EXPORT_SYMBOL(ide_do_drive_cmd);
1737
1738void ide_pktcmd_tf_load(ide_drive_t *drive, u32 tf_flags, u16 bcount, u8 dma)
1739{
1740 ide_task_t task;
1741
1742 memset(&task, 0, sizeof(task));
1743 task.tf_flags = IDE_TFLAG_OUT_LBAH | IDE_TFLAG_OUT_LBAM |
1744 IDE_TFLAG_OUT_FEATURE | tf_flags;
1745 task.tf.feature = dma; /* Use PIO/DMA */
1746 task.tf.lbam = bcount & 0xff;
1747 task.tf.lbah = (bcount >> 8) & 0xff;
1748
1749 ide_tf_load(drive, &task);
1750}
1751
1752EXPORT_SYMBOL_GPL(ide_pktcmd_tf_load);
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index d1f2446739a4..3cbca3f4628a 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -2171,12 +2171,9 @@ static ide_startstop_t idetape_issue_packet_command (ide_drive_t *drive, idetape
2171 if (test_bit(PC_DMA_RECOMMENDED, &pc->flags) && drive->using_dma) 2171 if (test_bit(PC_DMA_RECOMMENDED, &pc->flags) && drive->using_dma)
2172 dma_ok = !hwif->dma_setup(drive); 2172 dma_ok = !hwif->dma_setup(drive);
2173 2173
2174 if (IDE_CONTROL_REG) 2174 ide_pktcmd_tf_load(drive, IDE_TFLAG_NO_SELECT_MASK |
2175 hwif->OUTB(drive->ctl, IDE_CONTROL_REG); 2175 IDE_TFLAG_OUT_DEVICE, bcount, dma_ok);
2176 hwif->OUTB(dma_ok ? 1 : 0, IDE_FEATURE_REG); /* Use PIO/DMA */ 2176
2177 hwif->OUTB(bcount & 0xff, IDE_BCOUNTL_REG);
2178 hwif->OUTB((bcount >> 8) & 0xff, IDE_BCOUNTH_REG);
2179 hwif->OUTB(drive->select.all, IDE_SELECT_REG);
2180 if (dma_ok) /* Will begin DMA later */ 2177 if (dma_ok) /* Will begin DMA later */
2181 set_bit(PC_DMA_IN_PROGRESS, &pc->flags); 2178 set_bit(PC_DMA_IN_PROGRESS, &pc->flags);
2182 if (test_bit(IDETAPE_DRQ_INTERRUPT, &tape->flags)) { 2179 if (test_bit(IDETAPE_DRQ_INTERRUPT, &tape->flags)) {
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index 76f0ccd2968b..02e91893064d 100644
--- a/drivers/scsi/ide-scsi.c
+++ b/drivers/scsi/ide-scsi.c
@@ -590,12 +590,8 @@ static ide_startstop_t idescsi_issue_pc (ide_drive_t *drive, idescsi_pc_t *pc)
590 } 590 }
591 591
592 SELECT_DRIVE(drive); 592 SELECT_DRIVE(drive);
593 if (IDE_CONTROL_REG)
594 HWIF(drive)->OUTB(drive->ctl, IDE_CONTROL_REG);
595 593
596 hwif->OUTB(dma, IDE_FEATURE_REG); 594 ide_pktcmd_tf_load(drive, IDE_TFLAG_NO_SELECT_MASK, bcount, dma);
597 hwif->OUTB(bcount & 0xff, IDE_BCOUNTL_REG);
598 hwif->OUTB((bcount >> 8) & 0xff, IDE_BCOUNTH_REG);
599 595
600 if (dma) 596 if (dma)
601 set_bit(PC_DMA_OK, &pc->flags); 597 set_bit(PC_DMA_OK, &pc->flags);
diff --git a/include/linux/ide.h b/include/linux/ide.h
index 790ffa7f6949..20969eb1789a 100644
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -968,6 +968,8 @@ extern void QUIRK_LIST(ide_drive_t *);
968 968
969extern int drive_is_ready(ide_drive_t *); 969extern int drive_is_ready(ide_drive_t *);
970 970
971void ide_pktcmd_tf_load(ide_drive_t *, u32, u16, u8);
972
971/* 973/*
972 * taskfile io for disks for now...and builds request from ide_ioctl 974 * taskfile io for disks for now...and builds request from ide_ioctl
973 */ 975 */