diff options
| -rw-r--r-- | drivers/i2c/i2c-dev.c | 22 |
1 files changed, 6 insertions, 16 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index b3fcb59a5a10..0b0427f7d348 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c | |||
| @@ -167,13 +167,9 @@ static ssize_t i2cdev_write(struct file *file, const char __user *buf, | |||
| 167 | if (count > 8192) | 167 | if (count > 8192) |
| 168 | count = 8192; | 168 | count = 8192; |
| 169 | 169 | ||
| 170 | tmp = kmalloc(count, GFP_KERNEL); | 170 | tmp = memdup_user(buf, count); |
| 171 | if (tmp == NULL) | 171 | if (IS_ERR(tmp)) |
| 172 | return -ENOMEM; | 172 | return PTR_ERR(tmp); |
| 173 | if (copy_from_user(tmp, buf, count)) { | ||
| 174 | kfree(tmp); | ||
| 175 | return -EFAULT; | ||
| 176 | } | ||
| 177 | 173 | ||
| 178 | pr_debug("i2c-dev: i2c-%d writing %zu bytes.\n", | 174 | pr_debug("i2c-dev: i2c-%d writing %zu bytes.\n", |
| 179 | iminor(file->f_path.dentry->d_inode), count); | 175 | iminor(file->f_path.dentry->d_inode), count); |
| @@ -245,15 +241,9 @@ static noinline int i2cdev_ioctl_rdrw(struct i2c_client *client, | |||
| 245 | break; | 241 | break; |
| 246 | } | 242 | } |
| 247 | data_ptrs[i] = (u8 __user *)rdwr_pa[i].buf; | 243 | data_ptrs[i] = (u8 __user *)rdwr_pa[i].buf; |
| 248 | rdwr_pa[i].buf = kmalloc(rdwr_pa[i].len, GFP_KERNEL); | 244 | rdwr_pa[i].buf = memdup_user(data_ptrs[i], rdwr_pa[i].len); |
| 249 | if (rdwr_pa[i].buf == NULL) { | 245 | if (IS_ERR(rdwr_pa[i].buf)) { |
| 250 | res = -ENOMEM; | 246 | res = PTR_ERR(rdwr_pa[i].buf); |
| 251 | break; | ||
| 252 | } | ||
| 253 | if (copy_from_user(rdwr_pa[i].buf, data_ptrs[i], | ||
| 254 | rdwr_pa[i].len)) { | ||
| 255 | ++i; /* Needs to be kfreed too */ | ||
| 256 | res = -EFAULT; | ||
| 257 | break; | 247 | break; |
| 258 | } | 248 | } |
| 259 | } | 249 | } |
