diff options
| -rw-r--r-- | net/dccp/ccids/ccid3.c | 9 | ||||
| -rw-r--r-- | net/dccp/ccids/lib/tfrc.h | 1 | ||||
| -rw-r--r-- | net/dccp/ccids/lib/tfrc_equation.c | 14 |
3 files changed, 19 insertions, 5 deletions
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 90bc0a7da8e4..9715eebf1551 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c | |||
| @@ -400,10 +400,10 @@ static void ccid3_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb) | |||
| 400 | 400 | ||
| 401 | /* Update loss event rate (which is scaled by 1e6) */ | 401 | /* Update loss event rate (which is scaled by 1e6) */ |
| 402 | pinv = opt_recv->ccid3or_loss_event_rate; | 402 | pinv = opt_recv->ccid3or_loss_event_rate; |
| 403 | if (pinv == ~0U || pinv == 0) /* see RFC 4342, 8.5 */ | 403 | if (pinv == 0) |
| 404 | hc->tx_p = 0; | 404 | hc->tx_p = 0; |
| 405 | else /* can not exceed 100% */ | 405 | else |
| 406 | hc->tx_p = scaled_div(1, pinv); | 406 | hc->tx_p = tfrc_invert_loss_event_rate(pinv); |
| 407 | 407 | ||
| 408 | /* | 408 | /* |
| 409 | * Update allowed sending rate X as per draft rfc3448bis-00, 4.2/3 | 409 | * Update allowed sending rate X as per draft rfc3448bis-00, 4.2/3 |
| @@ -834,8 +834,7 @@ static int ccid3_hc_rx_getsockopt(struct sock *sk, const int optname, int len, | |||
| 834 | return -EINVAL; | 834 | return -EINVAL; |
| 835 | rx_info.tfrcrx_x_recv = hc->rx_x_recv; | 835 | rx_info.tfrcrx_x_recv = hc->rx_x_recv; |
| 836 | rx_info.tfrcrx_rtt = hc->rx_rtt; | 836 | rx_info.tfrcrx_rtt = hc->rx_rtt; |
| 837 | rx_info.tfrcrx_p = hc->rx_pinv == 0 ? ~0U : | 837 | rx_info.tfrcrx_p = tfrc_invert_loss_event_rate(hc->rx_pinv); |
| 838 | scaled_div(1, hc->rx_pinv); | ||
| 839 | len = sizeof(rx_info); | 838 | len = sizeof(rx_info); |
| 840 | val = &rx_info; | 839 | val = &rx_info; |
| 841 | break; | 840 | break; |
diff --git a/net/dccp/ccids/lib/tfrc.h b/net/dccp/ccids/lib/tfrc.h index 01bb48e96c2e..f8ee3f549770 100644 --- a/net/dccp/ccids/lib/tfrc.h +++ b/net/dccp/ccids/lib/tfrc.h | |||
| @@ -57,6 +57,7 @@ static inline u32 tfrc_ewma(const u32 avg, const u32 newval, const u8 weight) | |||
| 57 | 57 | ||
| 58 | extern u32 tfrc_calc_x(u16 s, u32 R, u32 p); | 58 | extern u32 tfrc_calc_x(u16 s, u32 R, u32 p); |
| 59 | extern u32 tfrc_calc_x_reverse_lookup(u32 fvalue); | 59 | extern u32 tfrc_calc_x_reverse_lookup(u32 fvalue); |
| 60 | extern u32 tfrc_invert_loss_event_rate(u32 loss_event_rate); | ||
| 60 | 61 | ||
| 61 | extern int tfrc_tx_packet_history_init(void); | 62 | extern int tfrc_tx_packet_history_init(void); |
| 62 | extern void tfrc_tx_packet_history_exit(void); | 63 | extern void tfrc_tx_packet_history_exit(void); |
diff --git a/net/dccp/ccids/lib/tfrc_equation.c b/net/dccp/ccids/lib/tfrc_equation.c index 22ca1cf0eb55..a052a4377e26 100644 --- a/net/dccp/ccids/lib/tfrc_equation.c +++ b/net/dccp/ccids/lib/tfrc_equation.c | |||
| @@ -687,3 +687,17 @@ u32 tfrc_calc_x_reverse_lookup(u32 fvalue) | |||
| 687 | index = tfrc_binsearch(fvalue, 0); | 687 | index = tfrc_binsearch(fvalue, 0); |
| 688 | return (index + 1) * 1000000 / TFRC_CALC_X_ARRSIZE; | 688 | return (index + 1) * 1000000 / TFRC_CALC_X_ARRSIZE; |
| 689 | } | 689 | } |
| 690 | |||
| 691 | /** | ||
| 692 | * tfrc_invert_loss_event_rate - Compute p so that 10^6 corresponds to 100% | ||
| 693 | * When @loss_event_rate is large, there is a chance that p is truncated to 0. | ||
| 694 | * To avoid re-entering slow-start in that case, we set p = TFRC_SMALLEST_P > 0. | ||
| 695 | */ | ||
| 696 | u32 tfrc_invert_loss_event_rate(u32 loss_event_rate) | ||
| 697 | { | ||
| 698 | if (loss_event_rate == UINT_MAX) /* see RFC 4342, 8.5 */ | ||
| 699 | return 0; | ||
| 700 | if (unlikely(loss_event_rate == 0)) /* map 1/0 into 100% */ | ||
| 701 | return 1000000; | ||
| 702 | return max_t(u32, scaled_div(1, loss_event_rate), TFRC_SMALLEST_P); | ||
| 703 | } | ||
