diff options
| -rw-r--r-- | net/9p/trans_rdma.c | 29 |
1 files changed, 18 insertions, 11 deletions
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c index 0ea20c30466c..17c5ba7551a5 100644 --- a/net/9p/trans_rdma.c +++ b/net/9p/trans_rdma.c | |||
| @@ -426,8 +426,10 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req) | |||
| 426 | 426 | ||
| 427 | /* Allocate an fcall for the reply */ | 427 | /* Allocate an fcall for the reply */ |
| 428 | rpl_context = kmalloc(sizeof *rpl_context, GFP_KERNEL); | 428 | rpl_context = kmalloc(sizeof *rpl_context, GFP_KERNEL); |
| 429 | if (!rpl_context) | 429 | if (!rpl_context) { |
| 430 | err = -ENOMEM; | ||
| 430 | goto err_close; | 431 | goto err_close; |
| 432 | } | ||
| 431 | 433 | ||
| 432 | /* | 434 | /* |
| 433 | * If the request has a buffer, steal it, otherwise | 435 | * If the request has a buffer, steal it, otherwise |
| @@ -445,8 +447,8 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req) | |||
| 445 | } | 447 | } |
| 446 | rpl_context->rc = req->rc; | 448 | rpl_context->rc = req->rc; |
| 447 | if (!rpl_context->rc) { | 449 | if (!rpl_context->rc) { |
| 448 | kfree(rpl_context); | 450 | err = -ENOMEM; |
| 449 | goto err_close; | 451 | goto err_free2; |
| 450 | } | 452 | } |
| 451 | 453 | ||
| 452 | /* | 454 | /* |
| @@ -458,11 +460,8 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req) | |||
| 458 | */ | 460 | */ |
| 459 | if (atomic_inc_return(&rdma->rq_count) <= rdma->rq_depth) { | 461 | if (atomic_inc_return(&rdma->rq_count) <= rdma->rq_depth) { |
| 460 | err = post_recv(client, rpl_context); | 462 | err = post_recv(client, rpl_context); |
| 461 | if (err) { | 463 | if (err) |
| 462 | kfree(rpl_context->rc); | 464 | goto err_free1; |
| 463 | kfree(rpl_context); | ||
| 464 | goto err_close; | ||
| 465 | } | ||
| 466 | } else | 465 | } else |
| 467 | atomic_dec(&rdma->rq_count); | 466 | atomic_dec(&rdma->rq_count); |
| 468 | 467 | ||
| @@ -471,8 +470,10 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req) | |||
| 471 | 470 | ||
| 472 | /* Post the request */ | 471 | /* Post the request */ |
| 473 | c = kmalloc(sizeof *c, GFP_KERNEL); | 472 | c = kmalloc(sizeof *c, GFP_KERNEL); |
| 474 | if (!c) | 473 | if (!c) { |
| 475 | goto err_close; | 474 | err = -ENOMEM; |
| 475 | goto err_free1; | ||
| 476 | } | ||
| 476 | c->req = req; | 477 | c->req = req; |
| 477 | 478 | ||
| 478 | c->busa = ib_dma_map_single(rdma->cm_id->device, | 479 | c->busa = ib_dma_map_single(rdma->cm_id->device, |
| @@ -499,9 +500,15 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req) | |||
| 499 | return ib_post_send(rdma->qp, &wr, &bad_wr); | 500 | return ib_post_send(rdma->qp, &wr, &bad_wr); |
| 500 | 501 | ||
| 501 | error: | 502 | error: |
| 503 | kfree(c); | ||
| 504 | kfree(rpl_context->rc); | ||
| 505 | kfree(rpl_context); | ||
| 502 | P9_DPRINTK(P9_DEBUG_ERROR, "EIO\n"); | 506 | P9_DPRINTK(P9_DEBUG_ERROR, "EIO\n"); |
| 503 | return -EIO; | 507 | return -EIO; |
| 504 | 508 | err_free1: | |
| 509 | kfree(rpl_context->rc); | ||
| 510 | err_free2: | ||
| 511 | kfree(rpl_context); | ||
| 505 | err_close: | 512 | err_close: |
| 506 | spin_lock_irqsave(&rdma->req_lock, flags); | 513 | spin_lock_irqsave(&rdma->req_lock, flags); |
| 507 | if (rdma->state < P9_RDMA_CLOSING) { | 514 | if (rdma->state < P9_RDMA_CLOSING) { |
