diff options
| -rw-r--r-- | fs/ext2/balloc.c | 50 | ||||
| -rw-r--r-- | fs/ext3/balloc.c | 48 | ||||
| -rw-r--r-- | fs/ext4/balloc.c | 41 |
3 files changed, 9 insertions, 130 deletions
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index 18a42de25b55..377ad172d74b 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c | |||
| @@ -69,14 +69,6 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb, | |||
| 69 | return desc + offset; | 69 | return desc + offset; |
| 70 | } | 70 | } |
| 71 | 71 | ||
| 72 | static inline int | ||
| 73 | block_in_use(unsigned long block, struct super_block *sb, unsigned char *map) | ||
| 74 | { | ||
| 75 | return ext2_test_bit ((block - | ||
| 76 | le32_to_cpu(EXT2_SB(sb)->s_es->s_first_data_block)) % | ||
| 77 | EXT2_BLOCKS_PER_GROUP(sb), map); | ||
| 78 | } | ||
| 79 | |||
| 80 | /* | 72 | /* |
| 81 | * Read the bitmap for a given block_group, reading into the specified | 73 | * Read the bitmap for a given block_group, reading into the specified |
| 82 | * slot in the superblock's bitmap cache. | 74 | * slot in the superblock's bitmap cache. |
| @@ -86,51 +78,20 @@ block_in_use(unsigned long block, struct super_block *sb, unsigned char *map) | |||
| 86 | static struct buffer_head * | 78 | static struct buffer_head * |
| 87 | read_block_bitmap(struct super_block *sb, unsigned int block_group) | 79 | read_block_bitmap(struct super_block *sb, unsigned int block_group) |
| 88 | { | 80 | { |
| 89 | int i; | ||
| 90 | struct ext2_group_desc * desc; | 81 | struct ext2_group_desc * desc; |
| 91 | struct buffer_head * bh = NULL; | 82 | struct buffer_head * bh = NULL; |
| 92 | unsigned int bitmap_blk; | 83 | |
| 93 | |||
| 94 | desc = ext2_get_group_desc (sb, block_group, NULL); | 84 | desc = ext2_get_group_desc (sb, block_group, NULL); |
| 95 | if (!desc) | 85 | if (!desc) |
| 96 | return NULL; | 86 | goto error_out; |
| 97 | bitmap_blk = le32_to_cpu(desc->bg_block_bitmap); | 87 | bh = sb_bread(sb, le32_to_cpu(desc->bg_block_bitmap)); |
| 98 | bh = sb_bread(sb, bitmap_blk); | ||
| 99 | if (!bh) | 88 | if (!bh) |
| 100 | ext2_error (sb, __FUNCTION__, | 89 | ext2_error (sb, "read_block_bitmap", |
| 101 | "Cannot read block bitmap - " | 90 | "Cannot read block bitmap - " |
| 102 | "block_group = %d, block_bitmap = %u", | 91 | "block_group = %d, block_bitmap = %u", |
| 103 | block_group, le32_to_cpu(desc->bg_block_bitmap)); | 92 | block_group, le32_to_cpu(desc->bg_block_bitmap)); |
| 104 | |||
| 105 | /* check whether block bitmap block number is set */ | ||
| 106 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 107 | /* bad block bitmap */ | ||
| 108 | goto error_out; | ||
| 109 | } | ||
| 110 | /* check whether the inode bitmap block number is set */ | ||
| 111 | bitmap_blk = le32_to_cpu(desc->bg_inode_bitmap); | ||
| 112 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 113 | /* bad block bitmap */ | ||
| 114 | goto error_out; | ||
| 115 | } | ||
| 116 | /* check whether the inode table block number is set */ | ||
| 117 | bitmap_blk = le32_to_cpu(desc->bg_inode_table); | ||
| 118 | for (i = 0; i < EXT2_SB(sb)->s_itb_per_group; i++, bitmap_blk++) { | ||
| 119 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 120 | /* bad block bitmap */ | ||
| 121 | goto error_out; | ||
| 122 | } | ||
| 123 | } | ||
| 124 | |||
| 125 | return bh; | ||
| 126 | |||
| 127 | error_out: | 93 | error_out: |
| 128 | brelse(bh); | 94 | return bh; |
| 129 | ext2_error(sb, __FUNCTION__, | ||
| 130 | "Invalid block bitmap - " | ||
| 131 | "block_group = %d, block = %u", | ||
| 132 | block_group, bitmap_blk); | ||
| 133 | return NULL; | ||
| 134 | } | 95 | } |
| 135 | 96 | ||
| 136 | static void release_blocks(struct super_block *sb, int count) | 97 | static void release_blocks(struct super_block *sb, int count) |
| @@ -1461,7 +1422,6 @@ unsigned long ext2_count_free_blocks (struct super_block * sb) | |||
| 1461 | #endif | 1422 | #endif |
| 1462 | } | 1423 | } |
| 1463 | 1424 | ||
| 1464 | |||
| 1465 | static inline int test_root(int a, int b) | 1425 | static inline int test_root(int a, int b) |
| 1466 | { | 1426 | { |
| 1467 | int num = b; | 1427 | int num = b; |
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index 7a87d15523be..a8ba7e831278 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c | |||
| @@ -80,14 +80,6 @@ struct ext3_group_desc * ext3_get_group_desc(struct super_block * sb, | |||
| 80 | return desc + offset; | 80 | return desc + offset; |
| 81 | } | 81 | } |
| 82 | 82 | ||
| 83 | static inline int | ||
| 84 | block_in_use(ext3_fsblk_t block, struct super_block *sb, unsigned char *map) | ||
| 85 | { | ||
| 86 | return ext3_test_bit ((block - | ||
| 87 | le32_to_cpu(EXT3_SB(sb)->s_es->s_first_data_block)) % | ||
| 88 | EXT3_BLOCKS_PER_GROUP(sb), map); | ||
| 89 | } | ||
| 90 | |||
| 91 | /** | 83 | /** |
| 92 | * read_block_bitmap() | 84 | * read_block_bitmap() |
| 93 | * @sb: super block | 85 | * @sb: super block |
| @@ -101,51 +93,20 @@ block_in_use(ext3_fsblk_t block, struct super_block *sb, unsigned char *map) | |||
| 101 | static struct buffer_head * | 93 | static struct buffer_head * |
| 102 | read_block_bitmap(struct super_block *sb, unsigned int block_group) | 94 | read_block_bitmap(struct super_block *sb, unsigned int block_group) |
| 103 | { | 95 | { |
| 104 | int i; | ||
| 105 | struct ext3_group_desc * desc; | 96 | struct ext3_group_desc * desc; |
| 106 | struct buffer_head * bh = NULL; | 97 | struct buffer_head * bh = NULL; |
| 107 | ext3_fsblk_t bitmap_blk; | ||
| 108 | 98 | ||
| 109 | desc = ext3_get_group_desc (sb, block_group, NULL); | 99 | desc = ext3_get_group_desc (sb, block_group, NULL); |
| 110 | if (!desc) | 100 | if (!desc) |
| 111 | return NULL; | 101 | goto error_out; |
| 112 | bitmap_blk = le32_to_cpu(desc->bg_block_bitmap); | 102 | bh = sb_bread(sb, le32_to_cpu(desc->bg_block_bitmap)); |
| 113 | bh = sb_bread(sb, bitmap_blk); | ||
| 114 | if (!bh) | 103 | if (!bh) |
| 115 | ext3_error (sb, __FUNCTION__, | 104 | ext3_error (sb, "read_block_bitmap", |
| 116 | "Cannot read block bitmap - " | 105 | "Cannot read block bitmap - " |
| 117 | "block_group = %d, block_bitmap = %u", | 106 | "block_group = %d, block_bitmap = %u", |
| 118 | block_group, le32_to_cpu(desc->bg_block_bitmap)); | 107 | block_group, le32_to_cpu(desc->bg_block_bitmap)); |
| 119 | |||
| 120 | /* check whether block bitmap block number is set */ | ||
| 121 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 122 | /* bad block bitmap */ | ||
| 123 | goto error_out; | ||
| 124 | } | ||
| 125 | /* check whether the inode bitmap block number is set */ | ||
| 126 | bitmap_blk = le32_to_cpu(desc->bg_inode_bitmap); | ||
| 127 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 128 | /* bad block bitmap */ | ||
| 129 | goto error_out; | ||
| 130 | } | ||
| 131 | /* check whether the inode table block number is set */ | ||
| 132 | bitmap_blk = le32_to_cpu(desc->bg_inode_table); | ||
| 133 | for (i = 0; i < EXT3_SB(sb)->s_itb_per_group; i++, bitmap_blk++) { | ||
| 134 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 135 | /* bad block bitmap */ | ||
| 136 | goto error_out; | ||
| 137 | } | ||
| 138 | } | ||
| 139 | |||
| 140 | return bh; | ||
| 141 | |||
| 142 | error_out: | 108 | error_out: |
| 143 | brelse(bh); | 109 | return bh; |
| 144 | ext3_error(sb, __FUNCTION__, | ||
| 145 | "Invalid block bitmap - " | ||
| 146 | "block_group = %d, block = %lu", | ||
| 147 | block_group, bitmap_blk); | ||
| 148 | return NULL; | ||
| 149 | } | 110 | } |
| 150 | /* | 111 | /* |
| 151 | * The reservation window structure operations | 112 | * The reservation window structure operations |
| @@ -1772,7 +1733,6 @@ ext3_fsblk_t ext3_count_free_blocks(struct super_block *sb) | |||
| 1772 | #endif | 1733 | #endif |
| 1773 | } | 1734 | } |
| 1774 | 1735 | ||
| 1775 | |||
| 1776 | static inline int test_root(int a, int b) | 1736 | static inline int test_root(int a, int b) |
| 1777 | { | 1737 | { |
| 1778 | int num = b; | 1738 | int num = b; |
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index e906b65448e2..71ee95e534fd 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
| @@ -189,15 +189,6 @@ struct ext4_group_desc * ext4_get_group_desc(struct super_block * sb, | |||
| 189 | return desc; | 189 | return desc; |
| 190 | } | 190 | } |
| 191 | 191 | ||
| 192 | static inline int | ||
| 193 | block_in_use(ext4_fsblk_t block, struct super_block *sb, unsigned char *map) | ||
| 194 | { | ||
| 195 | ext4_grpblk_t offset; | ||
| 196 | |||
| 197 | ext4_get_group_no_and_offset(sb, block, NULL, &offset); | ||
| 198 | return ext4_test_bit (offset, map); | ||
| 199 | } | ||
| 200 | |||
| 201 | /** | 192 | /** |
| 202 | * read_block_bitmap() | 193 | * read_block_bitmap() |
| 203 | * @sb: super block | 194 | * @sb: super block |
| @@ -211,7 +202,6 @@ block_in_use(ext4_fsblk_t block, struct super_block *sb, unsigned char *map) | |||
| 211 | struct buffer_head * | 202 | struct buffer_head * |
| 212 | read_block_bitmap(struct super_block *sb, unsigned int block_group) | 203 | read_block_bitmap(struct super_block *sb, unsigned int block_group) |
| 213 | { | 204 | { |
| 214 | int i; | ||
| 215 | struct ext4_group_desc * desc; | 205 | struct ext4_group_desc * desc; |
| 216 | struct buffer_head * bh = NULL; | 206 | struct buffer_head * bh = NULL; |
| 217 | ext4_fsblk_t bitmap_blk; | 207 | ext4_fsblk_t bitmap_blk; |
| @@ -239,38 +229,7 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group) | |||
| 239 | "Cannot read block bitmap - " | 229 | "Cannot read block bitmap - " |
| 240 | "block_group = %d, block_bitmap = %llu", | 230 | "block_group = %d, block_bitmap = %llu", |
| 241 | block_group, bitmap_blk); | 231 | block_group, bitmap_blk); |
| 242 | |||
| 243 | /* check whether block bitmap block number is set */ | ||
| 244 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 245 | /* bad block bitmap */ | ||
| 246 | goto error_out; | ||
| 247 | } | ||
| 248 | |||
| 249 | /* check whether the inode bitmap block number is set */ | ||
| 250 | bitmap_blk = ext4_inode_bitmap(sb, desc); | ||
| 251 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 252 | /* bad block bitmap */ | ||
| 253 | goto error_out; | ||
| 254 | } | ||
| 255 | /* check whether the inode table block number is set */ | ||
| 256 | bitmap_blk = ext4_inode_table(sb, desc); | ||
| 257 | for (i = 0; i < EXT4_SB(sb)->s_itb_per_group; i++, bitmap_blk++) { | ||
| 258 | if (!block_in_use(bitmap_blk, sb, bh->b_data)) { | ||
| 259 | /* bad block bitmap */ | ||
| 260 | goto error_out; | ||
| 261 | } | ||
| 262 | } | ||
| 263 | |||
| 264 | return bh; | 232 | return bh; |
| 265 | |||
| 266 | error_out: | ||
| 267 | brelse(bh); | ||
| 268 | ext4_error(sb, __FUNCTION__, | ||
| 269 | "Invalid block bitmap - " | ||
| 270 | "block_group = %d, block = %llu", | ||
| 271 | block_group, bitmap_blk); | ||
| 272 | return NULL; | ||
| 273 | |||
| 274 | } | 233 | } |
| 275 | /* | 234 | /* |
| 276 | * The reservation window structure operations | 235 | * The reservation window structure operations |
